sonarcloud[bot] commented on PR #3379:
URL: https://github.com/apache/calcite/pull/3379#issuecomment-1730722563
Kudos, SonarCloud Quality Gate passed! [`, this should
be `FALSE` for BigQuery's percentile functions
Jiabao-Sun commented on PR #3430:
URL: https://github.com/apache/calcite/pull/3430#issuecomment-1729945707
Many thanks to @tanclary, please help review it again when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sonarcloud[bot] commented on PR #3430:
URL: https://github.com/apache/calcite/pull/3430#issuecomment-1729925930
Kudos, SonarCloud Quality Gate passed! [ {
public static
tanclary commented on code in PR #3395:
URL: https://github.com/apache/calcite/pull/3395#discussion_r1333269098
##
babel/src/test/resources/sql/big-query.iq:
##
@@ -1012,9 +1012,9 @@ FROM
SELECT
Review Comment:
Nit: could we change the commit message to "Use explicit
tanclary commented on code in PR #3417:
URL: https://github.com/apache/calcite/pull/3417#discussion_r1333242359
##
babel/src/test/resources/sql/big-query.iq:
##
@@ -2029,6 +2029,160 @@ SELECT CODE_POINTS_TO_BYTES(array[2147483648, 1]);
Input arguments of CODE_POINTS_TO_BYTES
chucheng92 commented on PR #3395:
URL: https://github.com/apache/calcite/pull/3395#issuecomment-1729817048
thanks Julian and Vladimir for reviewing the related commit calcite-5960.
Considering that commit has been resolved, so I have rebased this PR.
Currently all comments are
tanclary commented on code in PR #3430:
URL: https://github.com/apache/calcite/pull/3430#discussion_r1333231129
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -645,6 +645,13 @@ public static SqlCall stripSeparator(SqlCall call) {
public static
tanclary commented on code in PR #3430:
URL: https://github.com/apache/calcite/pull/3430#discussion_r1333226171
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -9314,11 +9314,12 @@ private static void
checkGroupConcatFuncFails(SqlOperatorFixture t)
sonarcloud[bot] commented on PR #3436:
URL: https://github.com/apache/calcite/pull/3436#issuecomment-1729716547
Kudos, SonarCloud Quality Gate passed! [ Allow
disabling field trim via `SqlToRelConverter` config
Use the value of `isTrimUnusedFields` set to
pfzhan commented on code in PR #3326:
URL: https://github.com/apache/calcite/pull/3326#discussion_r1332953600
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6422,6 +6422,10 @@ private static void checkIf(SqlOperatorFixture f) {
jiefei30 commented on code in PR #3399:
URL: https://github.com/apache/calcite/pull/3399#discussion_r1332803836
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -1988,8 +1988,8 @@ SqlLiteral JoinType() :
}
{
(
-LOOKAHEAD(3) // required for "LEFT SEMI JOIN" in
sonarcloud[bot] commented on PR #3395:
URL: https://github.com/apache/calcite/pull/3395#issuecomment-1729155890
Kudos, SonarCloud Quality Gate passed! [ were added to refs/heads/main by this push:
new e1991e08a2 [CALCITE-5974] Elasticsearch adapter
sonarcloud[bot] commented on PR #3362:
URL: https://github.com/apache/calcite/pull/3362#issuecomment-1729145371
Kudos, SonarCloud Quality Gate passed! [. I have
chucheng92 commented on code in PR #3395:
URL: https://github.com/apache/calcite/pull/3395#discussion_r1332706699
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java:
##
@@ -973,6 +973,9 @@ private static Expression scaleIntervalToNumber(
sonarcloud[bot] commented on PR #3362:
URL: https://github.com/apache/calcite/pull/3362#issuecomment-1729075499
Kudos, SonarCloud Quality Gate passed! [ were added to refs/heads/main by this push:
new 1775baf218 [CALCITE-5994] Add optimization rule
rubenada merged PR #3418:
URL: https://github.com/apache/calcite/pull/3418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vlsi commented on code in PR #3395:
URL: https://github.com/apache/calcite/pull/3395#discussion_r1332562309
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java:
##
@@ -973,6 +973,9 @@ private static Expression scaleIntervalToNumber(
39 matches
Mail list logo
