Rajeshwari4 closed pull request #2946: Ordinal fix
URL: https://github.com/apache/calcite/pull/2946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: comm
libenchao closed pull request #183: [CALCITE-5295] Read the values of plugins
(such as connect string properties) from ThreadLocal fields
URL: https://github.com/apache/calcite-avatica/pull/183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
libenchao commented on code in PR #2938:
URL: https://github.com/apache/calcite/pull/2938#discussion_r1003932604
##
core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java:
##
@@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean
windowDeclListNewline
F21 opened a new pull request, #187:
URL: https://github.com/apache/calcite-avatica/pull/187
The ASF is discontinuing Travis CI for testing, and it will no longer be
available after 31 December 2022.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
F21 opened a new pull request, #2950:
URL: https://github.com/apache/calcite/pull/2950
The ASF is discontinuing Travis CI for testing, and it will no longer be
available after 31 December 2022.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
libenchao commented on code in PR #2938:
URL: https://github.com/apache/calcite/pull/2938#discussion_r1003928315
##
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##
@@ -3749,26 +3774,26 @@ void checkPeriodPredicate(Checker checker) {
+ "select
libenchao commented on PR #2948:
URL: https://github.com/apache/calcite/pull/2948#issuecomment-1289869013
@asolimando The PR looks great. The only question I got is why
`TopDownOptTest` and `RuleMatchVisualizerTest` are not touched in this PR?
--
This is an automated message from the Apac
libenchao commented on code in PR #2686:
URL: https://github.com/apache/calcite/pull/2686#discussion_r1003909401
##
core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinTransposeRule.java:
##
@@ -157,7 +159,24 @@ public ProjectJoinTransposeRule(
@Value.Immutable(singlet
wnob opened a new pull request, #186:
URL: https://github.com/apache/calcite-avatica/pull/186
According to the [JDBC 4.2 spec][1], the `TIME_WITH_TIMEZONE` and
`TIMESTAMP_WITH_TIMEZONE` types are meant to be accessed as
`java.time.OffsetTime` and `java.time.OffsetDateTime` objects respectiv
HanumathRao commented on PR #2935:
URL: https://github.com/apache/calcite/pull/2935#issuecomment-1289138925
Thank you @zabetak for the review and improvements. Please go ahead and
merge the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
asolimando merged PR #2947:
URL: https://github.com/apache/calcite/pull/2947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite
wojustme commented on PR #2686:
URL: https://github.com/apache/calcite/pull/2686#issuecomment-1288937219
In my opinion, this case only works on in CALCITE's optimizer or validator,
which some expresion only change nullable attribute.
we couldn't write an sql `cast(c1 as not integer)`, and
zabetak commented on PR #2935:
URL: https://github.com/apache/calcite/pull/2935#issuecomment-1288891782
I pushed a few small changes to the PR. @HanumathRao let me know if you are
OK with those so that I can rebase and merge the PR.
--
This is an automated message from the Apache Git Serv
zabetak commented on code in PR #2935:
URL: https://github.com/apache/calcite/pull/2935#discussion_r1003201432
##
core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml:
##
@@ -3058,6 +3058,50 @@ LogicalSort(sort0=[$7], dir0=[ASC], fetch=[0])
+
+
asolimando commented on PR #2947:
URL: https://github.com/apache/calcite/pull/2947#issuecomment-1288630911
Thanks @JiajunBernoulli, I agree on your reasoning. Can I ask you to squash
the commits? Once done, I will merge it in the next 24 hours.
--
This is an automated message from the Apa
l4wei commented on code in PR #2938:
URL: https://github.com/apache/calcite/pull/2938#discussion_r1003027206
##
core/src/main/java/org/apache/calcite/sql/SqlCall.java:
##
@@ -118,7 +118,7 @@ public int operandCount() {
final SqlDialect dialect = writer.getDialect();
if
l4wei commented on code in PR #2938:
URL: https://github.com/apache/calcite/pull/2938#discussion_r1002851565
##
core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java:
##
@@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean
windowDeclListNewline) {
libenchao commented on code in PR #183:
URL: https://github.com/apache/calcite-avatica/pull/183#discussion_r1002804111
##
core/src/main/java/org/apache/calcite/avatica/AvaticaUtils.java:
##
@@ -222,15 +223,22 @@ public static T instantiatePlugin(Class
pluginClass,
fin
F21 commented on PR #184:
URL: https://github.com/apache/calcite-avatica/pull/184#issuecomment-1288233986
+1 to @joshelser's comments, otherwise everything else looks great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
julianhyde commented on code in PR #183:
URL: https://github.com/apache/calcite-avatica/pull/183#discussion_r1002773357
##
core/src/main/java/org/apache/calcite/avatica/AvaticaUtils.java:
##
@@ -211,6 +211,7 @@ public static T instantiatePlugin(Class pluginClass,
String
julianhyde commented on code in PR #183:
URL: https://github.com/apache/calcite-avatica/pull/183#discussion_r1002770970
##
core/src/main/java/org/apache/calcite/avatica/AvaticaUtils.java:
##
@@ -222,15 +223,22 @@ public static T instantiatePlugin(Class
pluginClass,
fi
julianhyde commented on code in PR #183:
URL: https://github.com/apache/calcite-avatica/pull/183#discussion_r1002770793
##
core/src/main/java/org/apache/calcite/avatica/AvaticaUtils.java:
##
@@ -222,15 +223,22 @@ public static T instantiatePlugin(Class
pluginClass,
fi
julianhyde commented on code in PR #2949:
URL: https://github.com/apache/calcite/pull/2949#discussion_r1002766746
##
babel/src/main/codegen/config.fmpp:
##
@@ -31,12 +31,14 @@ data: {
"org.apache.calcite.sql.babel.SqlBabelCreateTable",
"org.apache.calcite.sql.babel
zabetak closed pull request #185: [CALCITE-3078] Move public lastDay method
from Calcite to Avatica
URL: https://github.com/apache/calcite-avatica/pull/185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zabetak closed pull request #28: [WIP][CALCITE-1806] Add Apache Spark JDBC test
to Avatica server
URL: https://github.com/apache/calcite-avatica/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
zabetak commented on PR #28:
URL: https://github.com/apache/calcite-avatica/pull/28#issuecomment-1288156910
This PR has been inactive for quite some time now and it seems there is no
interest from the authors to push this forward thus I am closing it down.
--
This is an automated message
zabetak closed pull request #98: [CALCITE-3078] Duplicate code lastDay in
calcite-avatica and calcite
URL: https://github.com/apache/calcite-avatica/pull/98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zabetak commented on PR #98:
URL: https://github.com/apache/calcite-avatica/pull/98#issuecomment-1288156204
Closing this in favor of https://github.com/apache/calcite-avatica/pull/185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
JiajunBernoulli commented on PR #2947:
URL: https://github.com/apache/calcite/pull/2947#issuecomment-1288039472
Thanks for your review.@asolimando I agree with your suggestion and I use a
single description:
> Creates a test context with a SQL query.
There are two reasons to use
libenchao commented on code in PR #2938:
URL: https://github.com/apache/calcite/pull/2938#discussion_r1002626396
##
core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java:
##
@@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean
windowDeclListNewline
libenchao commented on code in PR #2686:
URL: https://github.com/apache/calcite/pull/2686#discussion_r1002623077
##
core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinTransposeRule.java:
##
@@ -157,7 +159,24 @@ public ProjectJoinTransposeRule(
@Value.Immutable(singlet
libenchao commented on code in PR #183:
URL: https://github.com/apache/calcite-avatica/pull/183#discussion_r1002613948
##
core/src/main/java/org/apache/calcite/avatica/AvaticaUtils.java:
##
@@ -222,15 +223,22 @@ public static T instantiatePlugin(Class
pluginClass,
fin
libenchao commented on PR #2612:
URL: https://github.com/apache/calcite/pull/2612#issuecomment-1287800206
I'm closing this PR because https://github.com/apache/calcite/pull/2853 has
been merged and fix this issue.
--
This is an automated message from the Apache Git Service.
To respond to
libenchao closed pull request #2612: [CALCITE-4888] Unify type inferring
logical for Sarg RexLiteral
URL: https://github.com/apache/calcite/pull/2612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
libenchao closed pull request #2853: [CALCITE-4632] SARG datatype should be
less restictive than any of the input types
URL: https://github.com/apache/calcite/pull/2853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
asolimando closed pull request #2944: Fixed and improved javadoc instructions
to regenerate RelOptRulesTest…
URL: https://github.com/apache/calcite/pull/2944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
asolimando commented on PR #2947:
URL: https://github.com/apache/calcite/pull/2947#issuecomment-1287672624
I have recently had the same issue, so +1 on the change.
I noticed that the comments for the `sql()` method are all different for
these three classes, maybe we can try to provide
JiajunBernoulli opened a new pull request, #2947:
URL: https://github.com/apache/calcite/pull/2947
- When I write a unit test, I often see which tables and columns are
available. At present, I have to search the catalog. If there is a link to jump
directly, it is very convenient.
- For n
henneberger commented on PR #2909:
URL: https://github.com/apache/calcite/pull/2909#issuecomment-1287596760
Closing as invalid. This change would cause other issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
henneberger closed pull request #2909: Update SqlSelect to add hints to
setOperand
URL: https://github.com/apache/calcite/pull/2909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
HanumathRao commented on PR #2935:
URL: https://github.com/apache/calcite/pull/2935#issuecomment-1287499498
> > I am using the call context to get the RelMetadataQuery, I think this is
not fully formed during the matching of the rule
>
> @HanumathRao can you elaborate a bit what you m
HanumathRao commented on code in PR #2935:
URL: https://github.com/apache/calcite/pull/2935#discussion_r1002223506
##
testkit/src/main/java/org/apache/calcite/test/catalog/MockCatalogReaderSimple.java:
##
@@ -261,6 +261,14 @@ protected MockCatalogReaderSimple(RelDataTypeFactory
HanumathRao commented on code in PR #2935:
URL: https://github.com/apache/calcite/pull/2935#discussion_r1002223406
##
core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml:
##
@@ -3058,6 +3058,50 @@ LogicalSort(sort0=[$7], dir0=[ASC], fetch=[0])
+
asolimando merged PR #2901:
URL: https://github.com/apache/calcite/pull/2901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite
joshelser commented on code in PR #184:
URL: https://github.com/apache/calcite-avatica/pull/184#discussion_r1001885363
##
server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java:
##
@@ -767,6 +771,27 @@ public Builder withTLS(File keystore, String
keystorePasswor
Aitozi commented on PR #2901:
URL: https://github.com/apache/calcite/pull/2901#issuecomment-1287071569
> @Aitozi, can you squash the commits into a single one having as commit
message `[CALCITE-5264] HintStrategy rule exclusion does not match innermost
rels`? As soon as this is done I am re
rubenada merged PR #182:
URL: https://github.com/apache/calcite-avatica/pull/182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cal
asolimando commented on PR #2901:
URL: https://github.com/apache/calcite/pull/2901#issuecomment-1286888938
@Aitozi, can you squash the commits into a single one having as commit
message `[CALCITE-5264] HintStrategy rule exclusion does not match innermost
rels`? As soon as this is done I am
rubenada merged PR #163:
URL: https://github.com/apache/calcite-avatica/pull/163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cal
dssysolyatin commented on code in PR #2819:
URL: https://github.com/apache/calcite/pull/2819#discussion_r1001563447
##
core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java:
##
@@ -721,4 +738,31 @@ boolean canImplicitTypeCast(List types,
List fam
dssysolyatin commented on code in PR #2819:
URL: https://github.com/apache/calcite/pull/2819#discussion_r1001561672
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -243,6 +243,17 @@ public class ${parser.class} extends SqlAbstractParserImpl
return SqlStmtList();
richardantal commented on PR #184:
URL: https://github.com/apache/calcite-avatica/pull/184#issuecomment-1286639811
I am not able to add reviewers for this PR, but could you please take a look
at it?
@joshelser @julianhyde @stoty
--
This is an automated message from the Apache Git Serv
dependabot[bot] closed pull request #2817: Bump nokogiri from 1.13.4 to 1.13.6
in /site
URL: https://github.com/apache/calcite/pull/2817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] commented on PR #2817:
URL: https://github.com/apache/calcite/pull/2817#issuecomment-1286379401
Superseded by #2945.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
dependabot[bot] opened a new pull request, #2945:
URL: https://github.com/apache/calcite/pull/2945
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.4 to
1.13.9.
Release notes
Sourced from https://github.com/sparklemotion/nokogiri/releases";>nokogiri's
releases
julianhyde closed pull request #2943: [CALCITE-5339] Use
Method#getParameterCount rather than Method#getParameterTypes to get length
URL: https://github.com/apache/calcite/pull/2943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
julianhyde commented on code in PR #2819:
URL: https://github.com/apache/calcite/pull/2819#discussion_r1000994647
##
core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java:
##
@@ -721,4 +738,31 @@ boolean canImplicitTypeCast(List types,
List famil
asolimando opened a new pull request, #2944:
URL: https://github.com/apache/calcite/pull/2944
….xml, updated RelOptRulesTest.xml to match current tests in
RelOptRulesTest.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
dssysolyatin commented on code in PR #2819:
URL: https://github.com/apache/calcite/pull/2819#discussion_r1000675480
##
core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java:
##
@@ -721,4 +738,31 @@ boolean canImplicitTypeCast(List types,
List fam
asolimando merged PR #2941:
URL: https://github.com/apache/calcite/pull/2941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite
ILuffZhe commented on PR #182:
URL: https://github.com/apache/calcite-avatica/pull/182#issuecomment-1284743905
Thanks for your review, @rubenada I've squashed the commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
snuyanzin opened a new pull request, #2943:
URL: https://github.com/apache/calcite/pull/2943
As stated in jira issue `Method#getParameterTypes` each time creates a new
array so it's better to use `Method#getParameterCount` to know length of array
--
This is an automated message from the
julianhyde closed pull request #2926: [CALCITE-5305] Support string constants
with c-style escapes
URL: https://github.com/apache/calcite/pull/2926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
asolimando opened a new pull request, #2941:
URL: https://github.com/apache/calcite/pull/2941
…ing Maven path with Gradle path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
rubenada commented on PR #182:
URL: https://github.com/apache/calcite-avatica/pull/182#issuecomment-1284238772
Thanks @ILuffZhe , lgtm.
Could you please squash commits into a single one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
libenchao commented on PR #2853:
URL: https://github.com/apache/calcite/pull/2853#issuecomment-1283915022
@abhishek-das-gupta I found that `RexBuilder#makeBetween` also may have the
same problem, could you help to confirm this, and fix it if it exists? (In this
issue, or a follow-up issue,
libenchao closed pull request #2936: [CALCITE-5326] fix values from sql merge
URL: https://github.com/apache/calcite/pull/2936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zabetak commented on code in PR #2935:
URL: https://github.com/apache/calcite/pull/2935#discussion_r999314056
##
core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml:
##
@@ -3058,6 +3058,50 @@ LogicalSort(sort0=[$7], dir0=[ASC], fetch=[0])
+
+
zabetak commented on code in PR #2935:
URL: https://github.com/apache/calcite/pull/2935#discussion_r999312483
##
testkit/src/main/java/org/apache/calcite/test/catalog/MockCatalogReaderSimple.java:
##
@@ -261,6 +261,14 @@ protected MockCatalogReaderSimple(RelDataTypeFactory
type
zabetak commented on PR #2935:
URL: https://github.com/apache/calcite/pull/2935#issuecomment-1283786273
> I am using the call context to get the RelMetadataQuery, I think this is
not fully formed during the matching of the rule
@HanumathRao can you elaborate a bit what you mean when y
wojustme commented on PR #2686:
URL: https://github.com/apache/calcite/pull/2686#issuecomment-1283656880
Add default config: PreserveExprCondition
Shouldn't push non-null field, which is wrapped by CAST's operator.
Hi @libenchao
Please review this pr again, thanks a lot.
--
This
asolimando merged PR #2940:
URL: https://github.com/apache/calcite/pull/2940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite
asolimando commented on PR #2940:
URL: https://github.com/apache/calcite/pull/2940#issuecomment-1283648291
Test failure after squashing is caused by the known flacky test
`org.apache.calcite.test.ServerTest`, not related to the PR
--
This is an automated message from the Apache Git Servic
asolimando commented on PR #2901:
URL: https://github.com/apache/calcite/pull/2901#issuecomment-1282762416
The PR LGTM, I will merge by the end of this week if there will be no
objections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
abhishek-das-gupta commented on code in PR #2853:
URL: https://github.com/apache/calcite/pull/2853#discussion_r997862622
##
core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java:
##
@@ -624,6 +624,29 @@ private void checkDate(RexLiteral literal) {
assertThat(inCall.
wojustme opened a new pull request, #2939:
URL: https://github.com/apache/calcite/pull/2939
ISSUE: https://issues.apache.org/jira/browse/CALCITE-5328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ILuffZhe commented on PR #182:
URL: https://github.com/apache/calcite-avatica/pull/182#issuecomment-1281717165
@rubenada Hi, Ruben. I've added unit test for this case, please take a look
when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the mes
libenchao commented on code in PR #2853:
URL: https://github.com/apache/calcite/pull/2853#discussion_r997163233
##
core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java:
##
@@ -624,6 +624,29 @@ private void checkDate(RexLiteral literal) {
assertThat(inCall.getKind()
rubenada commented on PR #182:
URL: https://github.com/apache/calcite-avatica/pull/182#issuecomment-1280950195
@ILuffZhe could you please add a unit test for the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rubenada commented on PR #163:
URL: https://github.com/apache/calcite-avatica/pull/163#issuecomment-1280946552
Thanks @Logioniz for the PR.
@NobiGo the PR seems in a good shape. Do you have any further comments?
Otherwise I'll merge it in the coming days.
--
This is an automated me
rubenada commented on PR #2937:
URL: https://github.com/apache/calcite/pull/2937#issuecomment-1280924430
@zabetak as you already mentioned in Jira, it seems PruneEmptyRule is the
only one that lacks a default config, so we should definitely add it and align
with the rest (see e.g. `ReduceEx
l4wei commented on code in PR #2938:
URL: https://github.com/apache/calcite/pull/2938#discussion_r996677165
##
core/src/main/java/org/apache/calcite/sql/SqlCall.java:
##
@@ -118,7 +118,7 @@ public int operandCount() {
final SqlDialect dialect = writer.getDialect();
if
l4wei commented on code in PR #2938:
URL: https://github.com/apache/calcite/pull/2938#discussion_r996676210
##
core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java:
##
@@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean
windowDeclListNewline) {
l4wei commented on code in PR #2938:
URL: https://github.com/apache/calcite/pull/2938#discussion_r996675145
##
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##
@@ -2241,6 +2241,34 @@ void checkPeriodPredicate(Checker checker) {
sql(sql).fails("(?s)
libenchao commented on code in PR #2938:
URL: https://github.com/apache/calcite/pull/2938#discussion_r996611975
##
core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java:
##
@@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean
windowDeclListNewline)
l4wei commented on code in PR #2938:
URL: https://github.com/apache/calcite/pull/2938#discussion_r996599562
##
core/src/main/java/org/apache/calcite/sql/SqlCall.java:
##
@@ -118,7 +118,7 @@ public int operandCount() {
final SqlDialect dialect = writer.getDialect();
if
l4wei commented on code in PR #2938:
URL: https://github.com/apache/calcite/pull/2938#discussion_r996593733
##
core/src/main/java/org/apache/calcite/sql/SqlWith.java:
##
@@ -103,8 +103,9 @@ private SqlWithOperator() {
}
writer.endList(frame1);
final SqlWrite
l4wei commented on code in PR #2938:
URL: https://github.com/apache/calcite/pull/2938#discussion_r996593539
##
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##
@@ -2241,6 +2241,34 @@ void checkPeriodPredicate(Checker checker) {
sql(sql).fails("(?s)
l4wei commented on code in PR #2938:
URL: https://github.com/apache/calcite/pull/2938#discussion_r996592477
##
core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java:
##
@@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean
windowDeclListNewline) {
l4wei commented on code in PR #2938:
URL: https://github.com/apache/calcite/pull/2938#discussion_r996591355
##
core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java:
##
@@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean
windowDeclListNewline) {
l4wei commented on code in PR #2938:
URL: https://github.com/apache/calcite/pull/2938#discussion_r996591355
##
core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java:
##
@@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean
windowDeclListNewline) {
l4wei commented on PR #2938:
URL: https://github.com/apache/calcite/pull/2938#issuecomment-1280237370
>
OH~, thank you very much for your tip, i have already changed the email in
my local git config.
--
This is an automated message from the Apache Git Service.
To respond to the me
libenchao commented on code in PR #2938:
URL: https://github.com/apache/calcite/pull/2938#discussion_r996443682
##
core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java:
##
@@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean
windowDeclListNewline)
abhishek-das-gupta commented on code in PR #2853:
URL: https://github.com/apache/calcite/pull/2853#discussion_r996345727
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -1258,6 +1259,26 @@ private static String toSql(RelNode root, SqlDialec
HanumathRao commented on PR #2935:
URL: https://github.com/apache/calcite/pull/2935#issuecomment-1279557853
Thanks @zabetak for the review. I have addressed all the comments except the
following.
_It is better to put the row count check in the matches method. When the
condition is n
julianhyde commented on code in PR #2853:
URL: https://github.com/apache/calcite/pull/2853#discussion_r996032708
##
core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java:
##
@@ -624,6 +624,29 @@ private void checkDate(RexLiteral literal) {
assertThat(inCall.getKind(
julianhyde commented on code in PR #2853:
URL: https://github.com/apache/calcite/pull/2853#discussion_r996031793
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -1258,6 +1259,26 @@ private static String toSql(RelNode root, SqlDialect
diale
l4wei opened a new pull request, #2938:
URL: https://github.com/apache/calcite/pull/2938
Remove unnecessary parentheses around SELECT in WITH body
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
l4wei closed pull request #2923: [CALCITE-5252] Unparsing "WITH ... AS (SELECT
... UNION SELECT ...)" missing parentheses
URL: https://github.com/apache/calcite/pull/2923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
zabetak commented on PR #2937:
URL: https://github.com/apache/calcite/pull/2937#issuecomment-1278688528
@rubenada I guess there are other rules which miss a `DEFAULT` config
instance. The problem though may not be so serious in every case if rules are
not declared as 'RelOptRule` but as a s
601 - 700 of 18629 matches
Mail list logo