[GitHub] [calcite] chunweilei commented on a change in pull request #1102: [CALCITE-1515] RelBuilder supports creating TableFunctionScan

2019-03-27 Thread GitBox
chunweilei commented on a change in pull request #1102: [CALCITE-1515] RelBuilder supports creating TableFunctionScan URL: https://github.com/apache/calcite/pull/1102#discussion_r269426080 ## File path: core/src/main/java/org/apache/calcite/rel/logical/LogicalTableFunctionScan.java

[GitHub] [calcite] chunweilei commented on a change in pull request #912: [CALCITE-2729] introducing WindowReduceExpressionsRule

2019-03-27 Thread GitBox
chunweilei commented on a change in pull request #912: [CALCITE-2729] introducing WindowReduceExpressionsRule URL: https://github.com/apache/calcite/pull/912#discussion_r269429047 ## File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml ## @@ -8674

[GitHub] [calcite] julianhyde commented on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

2019-03-27 Thread GitBox
julianhyde commented on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object URL: https://github.com/apache/calcite/pull/1071#issuecomment-477024050 The Schema should have no more functionality than the SchemaFactory - it is just allowed to accept arg

[GitHub] [calcite] chadasa commented on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

2019-03-27 Thread GitBox
chadasa commented on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object URL: https://github.com/apache/calcite/pull/1071#issuecomment-477029158 I need to make one change inside GeodeUtils.java createRegion function to handle RegionExistsException.

[GitHub] [calcite-avatica] julianhyde commented on issue #88: Improve exception message in AbstractService

2019-03-27 Thread GitBox
julianhyde commented on issue #88: Improve exception message in AbstractService URL: https://github.com/apache/calcite-avatica/pull/88#issuecomment-477031898 I can't believe how much time we've wasted on this PR. The switch is exhaustive. The throw will never happen. So it doesn't matter wh

[GitHub] [calcite] zhztheplayer commented on issue #1070: [CALCITE-2808] Add the JSON_LENGTH function

2019-03-27 Thread GitBox
zhztheplayer commented on issue #1070: [CALCITE-2808] Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-477037203 > hi @zhztheplayer Calcite 1.19.0 has been released. Can you continue to check this PR? @XuQianJin-Stars Will merge after [CALC

[GitHub] [calcite-avatica] zabetak commented on issue #88: Improve exception message in AbstractService

2019-03-27 Thread GitBox
zabetak commented on issue #88: Improve exception message in AbstractService URL: https://github.com/apache/calcite-avatica/pull/88#issuecomment-477037657 I don't believe it is a waste of time. There a was a fruitful discussion on if we want to have default case in enumerations in general a

[GitHub] [calcite-avatica] vlsi commented on issue #88: Improve exception message in AbstractService

2019-03-27 Thread GitBox
vlsi commented on issue #88: Improve exception message in AbstractService URL: https://github.com/apache/calcite-avatica/pull/88#issuecomment-477048459 @zabetak , I'm afraid I'm with Julian. Each message generates GitHub notification, and it does create disruptions. It forces everybody t

[GitHub] [calcite] yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

2019-03-27 Thread GitBox
yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r269519787 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.jav

[GitHub] [calcite] yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

2019-03-27 Thread GitBox
yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r269522882 ## File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java ###

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

2019-03-27 Thread GitBox
zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r269524420 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable

[GitHub] [calcite] yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

2019-03-27 Thread GitBox
yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r269527965 ## File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java ###

[GitHub] [calcite] yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

2019-03-27 Thread GitBox
yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r269541808 ## File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java ###

[GitHub] [calcite-avatica] joshelser commented on issue #90: [CALCITE-2950] Avatica DriverVersion.load leaks InputStream

2019-03-27 Thread GitBox
joshelser commented on issue #90: [CALCITE-2950] Avatica DriverVersion.load leaks InputStream URL: https://github.com/apache/calcite-avatica/pull/90#issuecomment-477214905 > The code implements a fallback logic if Exception happens, so exception should not be re-thrown? I'm more wor

[GitHub] [calcite-avatica] julianhyde commented on issue #90: [CALCITE-2950] Avatica DriverVersion.load leaks InputStream

2019-03-27 Thread GitBox
julianhyde commented on issue #90: [CALCITE-2950] Avatica DriverVersion.load leaks InputStream URL: https://github.com/apache/calcite-avatica/pull/90#issuecomment-477277706 I'll go further. That kind of problem should be a java.lang.Error. --

[GitHub] [calcite] asfgit closed pull request #1134: [CALCITE-2953] LatticeTest.testTileAlgorithm2 and LatticeTest.testTil…

2019-03-27 Thread GitBox
asfgit closed pull request #1134: [CALCITE-2953] LatticeTest.testTileAlgorithm2 and LatticeTest.testTil… URL: https://github.com/apache/calcite/pull/1134 This is an automated message from the Apache Git Service. To respond t

[GitHub] [calcite-avatica] julianhyde commented on issue #88: Improve exception message in AbstractService

2019-03-27 Thread GitBox
julianhyde commented on issue #88: Improve exception message in AbstractService URL: https://github.com/apache/calcite-avatica/pull/88#issuecomment-477283526 I agree with both of you. @zabetak I'm glad the discussion was useful, in an ideal world it would have happened somewhere else. As @v

[GitHub] [calcite] hsyuan commented on issue #912: [CALCITE-2729] introducing WindowReduceExpressionsRule

2019-03-27 Thread GitBox
hsyuan commented on issue #912: [CALCITE-2729] introducing WindowReduceExpressionsRule URL: https://github.com/apache/calcite/pull/912#issuecomment-477303707 @asereda-gs How to add label `LGTM-will-merge-soon` on it? I am not able to add label to the PR. --

[GitHub] [calcite] hsyuan commented on issue #1126: CalciteCatalogReader now uses config.caseSensitive() to get functions…

2019-03-27 Thread GitBox
hsyuan commented on issue #1126: CalciteCatalogReader now uses config.caseSensitive() to get functions… URL: https://github.com/apache/calcite/pull/1126#issuecomment-477311907 Hi @LaiZhou, Any JIRA opened for this? This is an

[GitHub] [calcite-avatica] zabetak merged pull request #88: Improve exception message in AbstractService

2019-03-27 Thread GitBox
zabetak merged pull request #88: Improve exception message in AbstractService URL: https://github.com/apache/calcite-avatica/pull/88 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite-avatica] risdenk commented on issue #40: [CALCITE-2269] Enable errorprone checking

2019-03-27 Thread GitBox
risdenk commented on issue #40: [CALCITE-2269] Enable errorprone checking URL: https://github.com/apache/calcite-avatica/pull/40#issuecomment-477340440 Added profile `ErrorProne` that will enable the Error Prone checking on demand. I did not add the JDK 8 stuff since we will eventually move

[GitHub] [calcite] asereda-gs commented on issue #912: [CALCITE-2729] introducing WindowReduceExpressionsRule

2019-03-27 Thread GitBox
asereda-gs commented on issue #912: [CALCITE-2729] introducing WindowReduceExpressionsRule URL: https://github.com/apache/calcite/pull/912#issuecomment-477345487 @hsyuan do you have github permissions ? Do you see "rebase and merge" button ? Are you synced as apache/calcite committer ? -

[GitHub] [calcite] risdenk commented on issue #912: [CALCITE-2729] introducing WindowReduceExpressionsRule

2019-03-27 Thread GitBox
risdenk commented on issue #912: [CALCITE-2729] introducing WindowReduceExpressionsRule URL: https://github.com/apache/calcite/pull/912#issuecomment-477347597 @asereda-gs @hsyuan doesn't look to be part of the https://github.com/orgs/apache/teams/calcite-committers/members @hsyuan h

[GitHub] [calcite-avatica] risdenk commented on issue #40: [CALCITE-2269] Enable errorprone checking

2019-03-27 Thread GitBox
risdenk commented on issue #40: [CALCITE-2269] Enable errorprone checking URL: https://github.com/apache/calcite-avatica/pull/40#issuecomment-477363357 Travis is having a few issues today. Will wait to merge after Travis finishes to make sure the Error Prone profile is triggered correctly f

[GitHub] [calcite] hsyuan commented on issue #912: [CALCITE-2729] introducing WindowReduceExpressionsRule

2019-03-27 Thread GitBox
hsyuan commented on issue #912: [CALCITE-2729] introducing WindowReduceExpressionsRule URL: https://github.com/apache/calcite/pull/912#issuecomment-477365431 @risdenk @asereda-gs Thanks, I will sync my apache/calcite account following the guide. --

[GitHub] [calcite] asfgit closed pull request #1136: [CALCITE-2958] Upgrade SQLLine to 1.7.0

2019-03-27 Thread GitBox
asfgit closed pull request #1136: [CALCITE-2958] Upgrade SQLLine to 1.7.0 URL: https://github.com/apache/calcite/pull/1136 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] asfgit closed pull request #1113: Site: Add Alibaba MaxCompute to powered-by page

2019-03-27 Thread GitBox
asfgit closed pull request #1113: Site: Add Alibaba MaxCompute to powered-by page URL: https://github.com/apache/calcite/pull/1113 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [calcite] asereda-gs merged pull request #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

2019-03-27 Thread GitBox
asereda-gs merged pull request #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object URL: https://github.com/apache/calcite/pull/1071 This is an automated message from the Apache Git Service.

[GitHub] [calcite] asereda-gs commented on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

2019-03-27 Thread GitBox
asereda-gs commented on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object URL: https://github.com/apache/calcite/pull/1071#issuecomment-477384360 Thank you! This is an automated messa

[GitHub] [calcite] asereda-gs commented on issue #1101: [CALCITE-2909] Optimize Enumerable SemiJoin with lazy computation of innerLookup (Ruben Quesada Lopez)

2019-03-27 Thread GitBox
asereda-gs commented on issue #1101: [CALCITE-2909] Optimize Enumerable SemiJoin with lazy computation of innerLookup (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1101#issuecomment-477384758 @rubenada can you pls squash and rebase against master ? I see a merge commit

[GitHub] [calcite] asereda-gs commented on issue #1101: [CALCITE-2909] Optimize Enumerable SemiJoin with lazy computation of innerLookup (Ruben Quesada Lopez)

2019-03-27 Thread GitBox
asereda-gs commented on issue #1101: [CALCITE-2909] Optimize Enumerable SemiJoin with lazy computation of innerLookup (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1101#issuecomment-477384957 Aslo pls append your name `(First Last)` to commit message. --

[GitHub] [calcite] hsyuan closed pull request #1098: [CALCITE-2903] Exception thrown when decorrelating query with TEMPORAL TABLE

2019-03-27 Thread GitBox
hsyuan closed pull request #1098: [CALCITE-2903] Exception thrown when decorrelating query with TEMPORAL TABLE URL: https://github.com/apache/calcite/pull/1098 This is an automated message from the Apache Git Service. To res

[GitHub] [calcite] asereda-gs commented on issue #1111: [CALCITE-2927] The Javadoc and implement of RuleQueue.computeImportance() is inconsistent

2019-03-27 Thread GitBox
asereda-gs commented on issue #: [CALCITE-2927] The Javadoc and implement of RuleQueue.computeImportance() is inconsistent URL: https://github.com/apache/calcite/pull/#issuecomment-477409037 Pls add your Full Name `(First Last)` to commit message. --

[GitHub] [calcite] asereda-gs commented on issue #1122: [CALCITE-2941] EnumerableLimitRule on Sort with no collation creates EnumerableLimit with wrong traitSet and cluster

2019-03-27 Thread GitBox
asereda-gs commented on issue #1122: [CALCITE-2941] EnumerableLimitRule on Sort with no collation creates EnumerableLimit with wrong traitSet and cluster URL: https://github.com/apache/calcite/pull/1122#issuecomment-477409539 LGTM. Pls squash and rebase. Also pls add your full name to c

[GitHub] [calcite] LaiZhou commented on issue #1126: CalciteCatalogReader now uses config.caseSensitive() to get functions…

2019-03-27 Thread GitBox
LaiZhou commented on issue #1126: CalciteCatalogReader now uses config.caseSensitive() to get functions… URL: https://github.com/apache/calcite/pull/1126#issuecomment-477416211 @hsyuan No JIRA issue yet. Is it required to track this PR ? I think this case may be simple enough. ---

[GitHub] [calcite] chunweilei commented on issue #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta…

2019-03-27 Thread GitBox
chunweilei commented on issue #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta… URL: https://github.com/apache/calcite/pull/921#issuecomment-477421947 @hsyuan I have rebased on master. Thank you very much. -

[GitHub] [calcite] hsyuan commented on issue #1126: CalciteCatalogReader now uses config.caseSensitive() to get functions…

2019-03-27 Thread GitBox
hsyuan commented on issue #1126: CalciteCatalogReader now uses config.caseSensitive() to get functions… URL: https://github.com/apache/calcite/pull/1126#issuecomment-477422178 Yes, no matter how simple the code change is, we need a JIRA logged for it. --

[GitHub] [calcite] chunweilei commented on issue #912: [CALCITE-2729] introducing WindowReduceExpressionsRule

2019-03-27 Thread GitBox
chunweilei commented on issue #912: [CALCITE-2729] introducing WindowReduceExpressionsRule URL: https://github.com/apache/calcite/pull/912#issuecomment-477422663 @hsyuan I have rebased on master. Thank you very much. This is

[GitHub] [calcite] chunweilei commented on issue #1102: [CALCITE-1515] RelBuilder supports creating TableFunctionScan

2019-03-27 Thread GitBox
chunweilei commented on issue #1102: [CALCITE-1515] RelBuilder supports creating TableFunctionScan URL: https://github.com/apache/calcite/pull/1102#issuecomment-477425234 Force-pushed to rebase on master. This is an automated

[GitHub] [calcite] wangzzu commented on issue #1111: [CALCITE-2927] The Javadoc and implement of RuleQueue.computeImportance() is inconsistent

2019-03-27 Thread GitBox
wangzzu commented on issue #: [CALCITE-2927] The Javadoc and implement of RuleQueue.computeImportance() is inconsistent URL: https://github.com/apache/calcite/pull/#issuecomment-477425904 @asereda-gs I have added Full Name to my github account. -

[GitHub] [calcite] zhztheplayer closed pull request #1070: [CALCITE-2808] Add the JSON_LENGTH function

2019-03-27 Thread GitBox
zhztheplayer closed pull request #1070: [CALCITE-2808] Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] hsyuan merged pull request #912: [CALCITE-2729] introducing WindowReduceExpressionsRule

2019-03-27 Thread GitBox
hsyuan merged pull request #912: [CALCITE-2729] introducing WindowReduceExpressionsRule URL: https://github.com/apache/calcite/pull/912 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [calcite] hsyuan commented on issue #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta…

2019-03-27 Thread GitBox
hsyuan commented on issue #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta… URL: https://github.com/apache/calcite/pull/921#issuecomment-477446432 You have to resolve conflicts. This is an automated

[GitHub] [calcite] zhztheplayer commented on issue #1111: [CALCITE-2927] The Javadoc and implement of RuleQueue.computeImportance() is inconsistent

2019-03-27 Thread GitBox
zhztheplayer commented on issue #: [CALCITE-2927] The Javadoc and implement of RuleQueue.computeImportance() is inconsistent URL: https://github.com/apache/calcite/pull/#issuecomment-477447304 I'll help do the merge due to lack of the contributor suffix in the commit message. Thank

[GitHub] [calcite] zhztheplayer closed pull request #1111: [CALCITE-2927] The Javadoc and implement of RuleQueue.computeImportance() is inconsistent

2019-03-27 Thread GitBox
zhztheplayer closed pull request #: [CALCITE-2927] The Javadoc and implement of RuleQueue.computeImportance() is inconsistent URL: https://github.com/apache/calcite/pull/ This is an automated message from the Apache

[GitHub] [calcite] LaiZhou commented on issue #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions…

2019-03-27 Thread GitBox
LaiZhou commented on issue #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions… URL: https://github.com/apache/calcite/pull/1126#issuecomment-477449008 @hsyuan done . [CALCITE-2960](https://issues.apache.org/jira/browse/CALCITE-2960) ---

[GitHub] [calcite] chunweilei commented on issue #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta…

2019-03-27 Thread GitBox
chunweilei commented on issue #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta… URL: https://github.com/apache/calcite/pull/921#issuecomment-477451000 @hsyuan Resolved. This is an automated message

[GitHub] [calcite] danny0405 opened a new pull request #1137: [CALCITE-2928] Make UDF case-sensitiveness configurable

2019-03-27 Thread GitBox
danny0405 opened a new pull request #1137: [CALCITE-2928] Make UDF case-sensitiveness configurable URL: https://github.com/apache/calcite/pull/1137 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite-avatica] zabetak merged pull request #82: [CALCITE-2776] Wrong value when accessing struct types with one attribute (Stamatis Zampetakis)

2019-03-27 Thread GitBox
zabetak merged pull request #82: [CALCITE-2776] Wrong value when accessing struct types with one attribute (Stamatis Zampetakis) URL: https://github.com/apache/calcite-avatica/pull/82 This is an automated message from the Ap

[GitHub] [calcite-avatica] risdenk merged pull request #40: [CALCITE-2269] Enable errorprone checking

2019-03-28 Thread GitBox
risdenk merged pull request #40: [CALCITE-2269] Enable errorprone checking URL: https://github.com/apache/calcite-avatica/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [calcite] hsyuan commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true

2019-03-28 Thread GitBox
hsyuan commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true URL: https://github.com/apache/calcite/pull/1130#discussion_r270069500 ## File path: core/src/main/java/org/apache/calcite/rel/r

[GitHub] [calcite] pengzhiwei2018 opened a new pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
pengzhiwei2018 opened a new pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [calcite] pengzhiwei2018 closed pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
pengzhiwei2018 closed pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] pengzhiwei2018 opened a new pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
pengzhiwei2018 opened a new pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [calcite] rubenada commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true

2019-03-28 Thread GitBox
rubenada commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true URL: https://github.com/apache/calcite/pull/1130#discussion_r270086239 ## File path: core/src/main/java/org/apache/calci

[GitHub] [calcite] julianhyde commented on issue #1100: Site: Improve documentation for MySQL Specific JSON operators

2019-03-28 Thread GitBox
julianhyde commented on issue #1100: Site: Improve documentation for MySQL Specific JSON operators URL: https://github.com/apache/calcite/pull/1100#issuecomment-477714731 Can you please rebase this? Then I will review. This i

[GitHub] [calcite] hsyuan merged pull request #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta…

2019-03-28 Thread GitBox
hsyuan merged pull request #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta… URL: https://github.com/apache/calcite/pull/921 This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] julianhyde commented on issue #1096: [CALCITE-2004] Push join predicate down into inner relation for lateral join

2019-03-28 Thread GitBox
julianhyde commented on issue #1096: [CALCITE-2004] Push join predicate down into inner relation for lateral join URL: https://github.com/apache/calcite/pull/1096#issuecomment-477752255 @hsyuan 2903 is fixed now. Can you rebase, if necessary? I'll review when the tests pass. -

[GitHub] [calcite] hsyuan commented on issue #1096: [CALCITE-2004] Push join predicate down into inner relation for lateral join

2019-03-28 Thread GitBox
hsyuan commented on issue #1096: [CALCITE-2004] Push join predicate down into inner relation for lateral join URL: https://github.com/apache/calcite/pull/1096#issuecomment-477752514 OK, will do This is an automated message fr

[GitHub] [calcite] hsyuan commented on issue #1096: [CALCITE-2004] Push join predicate down into inner relation for lateral join

2019-03-28 Thread GitBox
hsyuan commented on issue #1096: [CALCITE-2004] Push join predicate down into inner relation for lateral join URL: https://github.com/apache/calcite/pull/1096#issuecomment-45244 @julianhyde Rebased on master and tests passed.

[GitHub] [calcite] laurentgo commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true

2019-03-28 Thread GitBox
laurentgo commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true URL: https://github.com/apache/calcite/pull/1130#discussion_r270226064 ## File path: core/src/main/java/org/apache/calci

[GitHub] [calcite] zhztheplayer commented on issue #1100: Site: Improve documentation for MySQL Specific JSON operators

2019-03-28 Thread GitBox
zhztheplayer commented on issue #1100: Site: Improve documentation for MySQL Specific JSON operators URL: https://github.com/apache/calcite/pull/1100#issuecomment-477816295 @julianhyde - rebased onto master. This is an automa

[GitHub] [calcite] siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary

2019-03-28 Thread GitBox
siddharthteotia commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary URL: https://github.com/apache/calcite/pull/1033#issuecomment-477824627 @zabetak , @asereda-gs , can this be merged?

[GitHub] [calcite] XuQianJin-Stars commented on issue #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-03-28 Thread GitBox
XuQianJin-Stars commented on issue #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#issuecomment-477826322 hi @michaelmior @zhztheplayer I have updated this PR. Can you continue to review this PR? best qianjin

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270262645 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,175 @

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270262760 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,175 @

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270263078 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,175 @

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270263293 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,175 @

[GitHub] [calcite] zhztheplayer commented on issue #1100: Site: Improve documentation for MySQL Specific JSON operators

2019-03-28 Thread GitBox
zhztheplayer commented on issue #1100: Site: Improve documentation for MySQL Specific JSON operators URL: https://github.com/apache/calcite/pull/1100#issuecomment-477842029 And I would like to know your thoughts on separating the changes to two commits. Something like: - Commit 1 Sit

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270263293 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,175 @

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270267219 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,1

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270267783 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,1

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270267275 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,1

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-28 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270276154 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,1

[GitHub] [calcite-avatica] zabetak commented on a change in pull request #85: [CALCITE-2704] Avoid use of ISO-8859-1 to parse request in JsonHandler

2019-03-29 Thread GitBox
zabetak commented on a change in pull request #85: [CALCITE-2704] Avoid use of ISO-8859-1 to parse request in JsonHandler URL: https://github.com/apache/calcite-avatica/pull/85#discussion_r270307873 ## File path: server/src/main/java/org/apache/calcite/avatica/server/AvaticaJsonHan

[GitHub] [calcite-avatica] zabetak commented on a change in pull request #85: [CALCITE-2704] Avoid use of ISO-8859-1 to parse request in JsonHandler

2019-03-29 Thread GitBox
zabetak commented on a change in pull request #85: [CALCITE-2704] Avoid use of ISO-8859-1 to parse request in JsonHandler URL: https://github.com/apache/calcite-avatica/pull/85#discussion_r270308361 ## File path: server/src/main/java/org/apache/calcite/avatica/server/AvaticaJsonHan

[GitHub] [calcite] rubenada commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true

2019-03-29 Thread GitBox
rubenada commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true URL: https://github.com/apache/calcite/pull/1130#discussion_r270310144 ## File path: core/src/main/java/org/apache/calci

[GitHub] [calcite] XuQianJin-Stars edited a comment on issue #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-03-29 Thread GitBox
XuQianJin-Stars edited a comment on issue #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#issuecomment-477826322 hi @michaelmior @zhztheplayer I have updated this PR. Can you continue to review this PR? best qianjin

[GitHub] [calcite] zabetak commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary

2019-03-29 Thread GitBox
zabetak commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary URL: https://github.com/apache/calcite/pull/1033#issuecomment-477944403 Conflicts have to be resolved first!

[GitHub] [calcite] zabetak commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true

2019-03-29 Thread GitBox
zabetak commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true URL: https://github.com/apache/calcite/pull/1130#discussion_r270352233 ## File path: core/src/main/java/org/apache/calcite/rel/r

[GitHub] [calcite] yuqi1129 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-29 Thread GitBox
yuqi1129 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270405037 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,214 @@

[GitHub] [calcite] yuqi1129 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-29 Thread GitBox
yuqi1129 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270392435 ## File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java ## @@ -876,6 +876,16 @@ @Base

[GitHub] [calcite] yuqi1129 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-03-29 Thread GitBox
yuqi1129 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r270410362 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -1320,6 +1331,214 @@

[GitHub] [calcite] XuQianJin-Stars edited a comment on issue #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-03-29 Thread GitBox
XuQianJin-Stars edited a comment on issue #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#issuecomment-477826322 hi @michaelmior @zhztheplayer I have updated this PR. Can you continue to review this PR? best qianjin -

[GitHub] [calcite] julianhyde commented on issue #1100: Site: Improve documentation for MySQL Specific JSON operators

2019-03-29 Thread GitBox
julianhyde commented on issue #1100: Site: Improve documentation for MySQL Specific JSON operators URL: https://github.com/apache/calcite/pull/1100#issuecomment-478089536 Yes, splitting into two changes would be useful. Thanks for suggesting it.

[GitHub] [calcite-avatica] risdenk opened a new pull request #91: [CALCITE-2961] Enable Travis to test against JDK 13

2019-03-29 Thread GitBox
risdenk opened a new pull request #91: [CALCITE-2961] Enable Travis to test against JDK 13 URL: https://github.com/apache/calcite-avatica/pull/91 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [calcite] risdenk opened a new pull request #1139: [CALCITE-2961] Enable Travis to test against JDK 13

2019-03-29 Thread GitBox
risdenk opened a new pull request #1139: [CALCITE-2961] Enable Travis to test against JDK 13 URL: https://github.com/apache/calcite/pull/1139 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [calcite-avatica] risdenk commented on issue #91: [CALCITE-2961] Enable Travis to test against JDK 13

2019-03-29 Thread GitBox
risdenk commented on issue #91: [CALCITE-2961] Enable Travis to test against JDK 13 URL: https://github.com/apache/calcite-avatica/pull/91#issuecomment-478129247 Hmmm JDK 13 fails due to what looks like an older ASM version. We should be able to override that.

[GitHub] [calcite-avatica] risdenk edited a comment on issue #91: [CALCITE-2961] Enable Travis to test against JDK 13

2019-03-29 Thread GitBox
risdenk edited a comment on issue #91: [CALCITE-2961] Enable Travis to test against JDK 13 URL: https://github.com/apache/calcite-avatica/pull/91#issuecomment-478129247 Hmmm JDK 13 fails due to what looks like an older asm version for spotbugs. We should be able to override that. ``

[GitHub] [calcite] risdenk commented on issue #1139: [CALCITE-2961] Enable Travis to test against JDK 13

2019-03-29 Thread GitBox
risdenk commented on issue #1139: [CALCITE-2961] Enable Travis to test against JDK 13 URL: https://github.com/apache/calcite/pull/1139#issuecomment-478131066 Failed on Cassandra: ``` [INFO] Running org.apache.calcite.test.CassandraAdapterTest [ERROR] [1;

[GitHub] [calcite] risdenk edited a comment on issue #1139: [CALCITE-2961] Enable Travis to test against JDK 13

2019-03-29 Thread GitBox
risdenk edited a comment on issue #1139: [CALCITE-2961] Enable Travis to test against JDK 13 URL: https://github.com/apache/calcite/pull/1139#issuecomment-478131066 Failed on Cassandra on JDK 13: ``` [INFO] Running org.apache.calcite.test.CassandraAdapterTest [[1;

[GitHub] [calcite] risdenk commented on issue #1139: [CALCITE-2961] Enable Travis to test against JDK 13

2019-03-29 Thread GitBox
risdenk commented on issue #1139: [CALCITE-2961] Enable Travis to test against JDK 13 URL: https://github.com/apache/calcite/pull/1139#issuecomment-478133125 Pushed change that should skip on JDK11+ for Cassandra. We had to do the same thing on JDK 12 too.

[GitHub] [calcite-avatica] risdenk commented on issue #91: [CALCITE-2961] Enable Travis to test against JDK 13

2019-03-29 Thread GitBox
risdenk commented on issue #91: [CALCITE-2961] Enable Travis to test against JDK 13 URL: https://github.com/apache/calcite-avatica/pull/91#issuecomment-478134706 This was fixed upstream in commit - https://github.com/spotbugs/spotbugs/commit/5153f67498394fcbbbe49f331229f24b74faf58b

[GitHub] [calcite-avatica] risdenk commented on issue #91: [CALCITE-2961] Enable Travis to test against JDK 13

2019-03-29 Thread GitBox
risdenk commented on issue #91: [CALCITE-2961] Enable Travis to test against JDK 13 URL: https://github.com/apache/calcite-avatica/pull/91#issuecomment-478135437 Pushed a change that upgrades asm for Spotbugs. This is an auto

[GitHub] [calcite] risdenk commented on issue #1139: [CALCITE-2961] Enable Travis to test against JDK 13

2019-03-29 Thread GitBox
risdenk commented on issue #1139: [CALCITE-2961] Enable Travis to test against JDK 13 URL: https://github.com/apache/calcite/pull/1139#issuecomment-478140557 Well screwed up that logic. Fixing in a few minutes. This is an aut

[GitHub] [calcite] asereda-gs commented on a change in pull request #1139: [CALCITE-2961] Enable Travis to test against JDK 13

2019-03-29 Thread GitBox
asereda-gs commented on a change in pull request #1139: [CALCITE-2961] Enable Travis to test against JDK 13 URL: https://github.com/apache/calcite/pull/1139#discussion_r270568993 ## File path: cassandra/src/test/java/org/apache/calcite/test/CassandraAdapterTest.java ## @@

[GitHub] [calcite] risdenk commented on a change in pull request #1139: [CALCITE-2961] Enable Travis to test against JDK 13

2019-03-29 Thread GitBox
risdenk commented on a change in pull request #1139: [CALCITE-2961] Enable Travis to test against JDK 13 URL: https://github.com/apache/calcite/pull/1139#discussion_r270569245 ## File path: cassandra/src/test/java/org/apache/calcite/test/CassandraAdapterTest.java ## @@ -8

[GitHub] [calcite-avatica] risdenk commented on issue #91: [CALCITE-2961] Enable Travis to test against JDK 13

2019-03-29 Thread GitBox
risdenk commented on issue #91: [CALCITE-2961] Enable Travis to test against JDK 13 URL: https://github.com/apache/calcite-avatica/pull/91#issuecomment-478146461 Woot Travis passed with upgraded asm for spotbugs. This is an a

[GitHub] [calcite-avatica] risdenk merged pull request #91: [CALCITE-2961] Enable Travis to test against JDK 13

2019-03-29 Thread GitBox
risdenk merged pull request #91: [CALCITE-2961] Enable Travis to test against JDK 13 URL: https://github.com/apache/calcite-avatica/pull/91 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] asereda-gs commented on a change in pull request #1139: [CALCITE-2961] Enable Travis to test against JDK 13

2019-03-29 Thread GitBox
asereda-gs commented on a change in pull request #1139: [CALCITE-2961] Enable Travis to test against JDK 13 URL: https://github.com/apache/calcite/pull/1139#discussion_r270574346 ## File path: cassandra/src/test/java/org/apache/calcite/test/CassandraAdapterTest.java ## @@

<    3   4   5   6   7   8   9   10   11   12   >