rubenada commented on PR #3481:
URL: https://github.com/apache/calcite/pull/3481#issuecomment-1778916330
@mihaibudiu do we need to update this PR to re-enable the test that was
disabled on CALCITE-5921?
--
This is an automated message from the Apache Git Service.
To respond to the
rubenada commented on PR #3471:
URL: https://github.com/apache/calcite/pull/3471#issuecomment-177816
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
rubenada closed pull request #3412: [CALCITE-5921]
SqlOperatorFixture.checkFails and checkAggFails don't check runtime failure
URL: https://github.com/apache/calcite/pull/3412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
rubenada commented on PR #3412:
URL: https://github.com/apache/calcite/pull/3412#issuecomment-1778902006
Closing this one in favor of https://github.com/apache/calcite/pull/3471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
herunkang2018 commented on code in PR #3481:
URL: https://github.com/apache/calcite/pull/3481#discussion_r1375219714
##
linq4j/src/main/java/org/apache/calcite/linq4j/tree/Primitive.java:
##
@@ -367,28 +369,67 @@ public static List asList(double[] elements) {
}
/**
-
herunkang2018 commented on PR #3481:
URL: https://github.com/apache/calcite/pull/3481#issuecomment-1783767083
Thanks for the PR, I left some minor comments, other looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
herunkang2018 commented on code in PR #3317:
URL: https://github.com/apache/calcite/pull/3317#discussion_r1375230299
##
site/_docs/reference.md:
##
@@ -2729,6 +2729,7 @@ BigQuery's type system uses confusingly different names
for types and functions:
| o | EXTRACT(xml, xpath,
herunkang2018 commented on code in PR #3317:
URL: https://github.com/apache/calcite/pull/3317#discussion_r1375230343
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -1076,6 +1076,32 @@ public static int levenshtein(String string1, String
string2) {
chucheng92 commented on PR #3458:
URL: https://github.com/apache/calcite/pull/3458#issuecomment-1783777113
> For me, this is an improvement.
>
> If there is no objection, I will merge it.
thanks for approve + 1.
--
This is an automated message from the Apache Git Service.
To
sonarcloud[bot] commented on PR #3317:
URL: https://github.com/apache/calcite/pull/3317#issuecomment-1783779683
Kudos, SonarCloud Quality Gate passed! [ could be improved (IMO it should mention
rubenada commented on code in PR #3418:
URL: https://github.com/apache/calcite/pull/3418#discussion_r1329887547
##
core/src/main/java/org/apache/calcite/rel/rules/CoreRules.java:
##
@@ -715,6 +715,11 @@ private CoreRules() {}
public static final SortRemoveConstantKeysRule
chunweilei commented on code in PR #3404:
URL: https://github.com/apache/calcite/pull/3404#discussion_r1328415065
##
core/src/test/java/org/apache/calcite/rex/RexExecutorTest.java:
##
@@ -378,4 +383,140 @@ public void run() {
interface Action {
void check(RexBuilder
rubenada commented on code in PR #3418:
URL: https://github.com/apache/calcite/pull/3418#discussion_r1329887547
##
core/src/main/java/org/apache/calcite/rel/rules/CoreRules.java:
##
@@ -715,6 +715,11 @@ private CoreRules() {}
public static final SortRemoveConstantKeysRule
rubenada commented on code in PR #3418:
URL: https://github.com/apache/calcite/pull/3418#discussion_r1329885385
##
core/src/main/java/org/apache/calcite/rel/rules/CoreRules.java:
##
@@ -715,6 +715,11 @@ private CoreRules() {}
public static final SortRemoveConstantKeysRule
JiajunBernoulli commented on PR #3423:
URL: https://github.com/apache/calcite/pull/3423#issuecomment-1722669543
I think the current PR looks good.
@tanclary, Do you have any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
jiefei30 commented on code in PR #3399:
URL: https://github.com/apache/calcite/pull/3399#discussion_r1328200661
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -1988,8 +1988,8 @@ SqlLiteral JoinType() :
}
{
(
-LOOKAHEAD(3) // required for "LEFT SEMI JOIN" in
chucheng92 commented on code in PR #3395:
URL: https://github.com/apache/calcite/pull/3395#discussion_r132782
##
core/src/test/resources/sql/misc.iq:
##
@@ -2167,12 +2167,12 @@ select array[1,null,2] as a from (values (1));
values array['a',null,'bcd'],
array['efgh'];
sonarcloud[bot] commented on PR #3421:
URL: https://github.com/apache/calcite/pull/3421#issuecomment-1726692918
Kudos, SonarCloud Quality Gate passed! [
herunkang2018 commented on code in PR #3418:
URL: https://github.com/apache/calcite/pull/3418#discussion_r1330838164
##
core/src/main/java/org/apache/calcite/rel/rules/SortRemoveRedundantRule.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
JiajunBernoulli merged PR #3423:
URL: https://github.com/apache/calcite/pull/3423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #3421:
URL: https://github.com/apache/calcite/pull/3421#issuecomment-1726615819
Kudos, SonarCloud Quality Gate passed! [ under one or
herunkang2018 commented on code in PR #3318:
URL: https://github.com/apache/calcite/pull/3318#discussion_r1334902316
##
core/src/main/java/org/apache/calcite/runtime/UrlFunctions.java:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
LakeShen commented on code in PR #3436:
URL: https://github.com/apache/calcite/pull/3436#discussion_r1334906829
##
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##
@@ -8247,6 +8343,33 @@ private static String sums(int n, boolean c) {
return b.toString();
}
herunkang2018 commented on code in PR #3318:
URL: https://github.com/apache/calcite/pull/3318#discussion_r1334901753
##
core/src/main/java/org/apache/calcite/runtime/UrlFunctions.java:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
herunkang2018 commented on code in PR #3318:
URL: https://github.com/apache/calcite/pull/3318#discussion_r1334893854
##
core/src/main/java/org/apache/calcite/runtime/UrlFunctions.java:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
LakeShen commented on PR #3436:
URL: https://github.com/apache/calcite/pull/3436#issuecomment-1732185150
@WegdanGhazi thank you for opening this PR, left a couple of comments!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
sonarcloud[bot] commented on PR #3420:
URL: https://github.com/apache/calcite/pull/3420#issuecomment-1732130181
Kudos, SonarCloud Quality Gate passed! [ {
"deptno=10; name=Sales;
herunkang2018 commented on code in PR #3318:
URL: https://github.com/apache/calcite/pull/3318#discussion_r1334901753
##
core/src/main/java/org/apache/calcite/runtime/UrlFunctions.java:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
sonarcloud[bot] commented on PR #3362:
URL: https://github.com/apache/calcite/pull/3362#issuecomment-1729145371
Kudos, SonarCloud Quality Gate passed! [ :
}
{
(
-LOOKAHEAD(3) // required for "LEFT SEMI JOIN" in
chucheng92 commented on PR #3395:
URL: https://github.com/apache/calcite/pull/3395#issuecomment-1729133495
> @julianhyde hi, julian. I noticed that you gave a comment in the ticket to
suggest giving a test case for
[calcite-5960](https://issues.apache.org/jira/browse/CALCITE-5960). I have
asfgit closed pull request #3406: [CALCITE-5974] Elasticsearch adapter throws
ClassCastException when index mapping sets dynamic_templates without properties
URL: https://github.com/apache/calcite/pull/3406
--
This is an automated message from the Apache Git Service.
To respond to the
sonarcloud[bot] commented on PR #3395:
URL: https://github.com/apache/calcite/pull/3395#issuecomment-1729031291
Kudos, SonarCloud Quality Gate passed! [ {
herunkang2018 commented on code in PR #3318:
URL: https://github.com/apache/calcite/pull/3318#discussion_r1334891290
##
core/src/main/java/org/apache/calcite/runtime/UrlFunctions.java:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
JiajunBernoulli commented on code in PR #3429:
URL: https://github.com/apache/calcite/pull/3429#discussion_r1334934887
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -268,6 +268,14 @@ private static String toSql(RelNode root, SqlDialect
JiajunBernoulli commented on code in PR #3429:
URL: https://github.com/apache/calcite/pull/3429#discussion_r1334934806
##
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##
@@ -1409,8 +1411,20 @@ public static SqlNode toSql(RexLiteral literal) {
JiajunBernoulli commented on code in PR #3431:
URL: https://github.com/apache/calcite/pull/3431#discussion_r1334939074
##
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##
@@ -1878,6 +1878,11 @@ && hasSortByOrdinal()) {
&& (hasNestedAgg ||
sonarcloud[bot] commented on PR #3362:
URL: https://github.com/apache/calcite/pull/3362#issuecomment-1732197576
Kudos, SonarCloud Quality Gate passed! [ under one
LakeShen commented on code in PR #3379:
URL: https://github.com/apache/calcite/pull/3379#discussion_r1334909352
##
core/src/main/java/org/apache/calcite/rel/rules/LoptOptimizeJoinRule.java:
##
@@ -2071,12 +2071,12 @@ private static boolean
wq352400523 commented on code in PR #3379:
URL: https://github.com/apache/calcite/pull/3379#discussion_r1334922102
##
core/src/test/java/org/apache/calcite/tools/PlannerTest.java:
##
@@ -1576,4 +1583,77 @@ private static class VaryingTypeSystem extends
DelegatingTypeSystem {
wq352400523 commented on code in PR #3379:
URL: https://github.com/apache/calcite/pull/3379#discussion_r1334922101
##
core/src/test/java/org/apache/calcite/tools/PlannerTest.java:
##
@@ -1576,4 +1583,77 @@ private static class VaryingTypeSystem extends
DelegatingTypeSystem {
sonarcloud[bot] commented on PR #3440:
URL: https://github.com/apache/calcite/pull/3440#issuecomment-1732227674
Kudos, SonarCloud Quality Gate passed! [ {
JiajunBernoulli commented on code in PR #3396:
URL: https://github.com/apache/calcite/pull/3396#discussion_r1335105756
##
core/src/main/java/org/apache/calcite/rel/rules/SortMergeRule.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
JiajunBernoulli commented on code in PR #3396:
URL: https://github.com/apache/calcite/pull/3396#discussion_r1335105720
##
core/src/main/java/org/apache/calcite/rel/rules/SortMergeRule.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
LakeShen commented on code in PR #3396:
URL: https://github.com/apache/calcite/pull/3396#discussion_r1335104439
##
core/src/main/java/org/apache/calcite/rel/rules/SortMergeRule.java:
##
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
LakeShen commented on PR #3396:
URL: https://github.com/apache/calcite/pull/3396#issuecomment-1732477741
Hi @JiajunBernoulli ,
Thank you for your review suggestions. I have modified according to the
suggestions. If you have time, please help me review or merge it.
--
This is an
JiajunBernoulli commented on code in PR #3396:
URL: https://github.com/apache/calcite/pull/3396#discussion_r1335106001
##
core/src/main/java/org/apache/calcite/rel/rules/SortMergeRule.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
sonarcloud[bot] commented on PR #3396:
URL: https://github.com/apache/calcite/pull/3396#issuecomment-1732480033
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
JiajunBernoulli commented on code in PR #3399:
URL: https://github.com/apache/calcite/pull/3399#discussion_r1335131046
##
babel/src/main/codegen/config.fmpp:
##
@@ -62,7 +63,8 @@ data: {
"SEED"
"SEMI"
"SEQUENCES"
- "TEMP"
+ "TEMP",
Review
JiajunBernoulli commented on code in PR #3399:
URL: https://github.com/apache/calcite/pull/3399#discussion_r1335130964
##
babel/src/test/java/org/apache/calcite/test/BabelParserTest.java:
##
@@ -430,6 +431,23 @@ private void checkParseInfixCast(String sqlType) {
JiajunBernoulli commented on code in PR #3399:
URL: https://github.com/apache/calcite/pull/3399#discussion_r1335131033
##
babel/src/main/codegen/config.fmpp:
##
@@ -49,7 +49,8 @@ data: {
"SEMI"
"SEQUENCES"
"TEMP"
- "VOLATILE"
+ "VOLATILE",
+
sonarcloud[bot] commented on PR #3396:
URL: https://github.com/apache/calcite/pull/3396#issuecomment-1732536584
Kudos, SonarCloud Quality Gate passed! [ {
chucheng92 commented on code in PR #3395:
URL: https://github.com/apache/calcite/pull/3395#discussion_r1334163600
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java:
##
@@ -1309,6 +1311,63 @@ public static boolean isMeasure(SqlNode selectItem) {
sonarcloud[bot] commented on PR #3416:
URL: https://github.com/apache/calcite/pull/3416#issuecomment-1731159425
Kudos, SonarCloud Quality Gate passed! [