JeetKunDoug commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1541482050
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/SqlToCqlTypeConverter.java:
##
@@ -788,11 +797,54 @@ else if (object
JeetKunDoug commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1541478857
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/SqlToCqlTypeConverter.java:
##
@@ -763,6 +766,12 @@ else if (object
yifan-c commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1540148669
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraSchemaInfo.java:
##
@@ -19,19 +19,33 @@
package
yifan-c commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1540147665
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##
@@ -87,11 +87,21 @@ private
yifan-c commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1540144916
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##
@@ -64,7 +65,6 @@ private
frankgh commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1540121145
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##
@@ -87,11 +87,21 @@ private
JeetKunDoug commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1539956682
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CqlTableInfoProvider.java:
##
@@ -98,9 +98,20 @@ public CqlField.CqlType
JeetKunDoug commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1539951034
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##
@@ -87,11 +87,21 @@ private
JeetKunDoug commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1539949686
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##
@@ -64,7 +65,6 @@ private
frankgh commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1535498626
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##
@@ -87,11 +87,21 @@ private
aratno commented on code in PR #1922:
URL:
https://github.com/apache/cassandra-java-driver/pull/1922#discussion_r1538206832
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/RackAwareWeightedLoadBalancingPolicy.java:
##
@@ -0,0 +1,264 @@
+/*
+ *
akhaku commented on code in PR #1922:
URL:
https://github.com/apache/cassandra-java-driver/pull/1922#discussion_r1538193530
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/RackAwareWeightedLoadBalancingPolicy.java:
##
@@ -0,0 +1,264 @@
+/*
+ *
aratno commented on code in PR #1922:
URL:
https://github.com/apache/cassandra-java-driver/pull/1922#discussion_r1538189365
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/RackAwareWeightedLoadBalancingPolicy.java:
##
@@ -0,0 +1,264 @@
+/*
+ *
akhaku commented on code in PR #1922:
URL:
https://github.com/apache/cassandra-java-driver/pull/1922#discussion_r1538180527
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/RackAwareWeightedLoadBalancingPolicy.java:
##
@@ -0,0 +1,264 @@
+/*
+ *
aratno commented on code in PR #1922:
URL:
https://github.com/apache/cassandra-java-driver/pull/1922#discussion_r1538174008
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/RackAwareWeightedLoadBalancingPolicy.java:
##
@@ -0,0 +1,264 @@
+/*
+ *
akhaku commented on code in PR #1922:
URL:
https://github.com/apache/cassandra-java-driver/pull/1922#discussion_r1538173041
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/RackAwareWeightedLoadBalancingPolicy.java:
##
@@ -0,0 +1,264 @@
+/*
+ *
akhaku commented on code in PR #1922:
URL:
https://github.com/apache/cassandra-java-driver/pull/1922#discussion_r1538171418
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/RackAwareWeightedLoadBalancingPolicy.java:
##
@@ -0,0 +1,264 @@
+/*
+ *
aratno commented on code in PR #1922:
URL:
https://github.com/apache/cassandra-java-driver/pull/1922#discussion_r1538077033
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/RackAwareWeightedLoadBalancingPolicy.java:
##
@@ -0,0 +1,264 @@
+/*
+ *
aratno commented on PR #1922:
URL:
https://github.com/apache/cassandra-java-driver/pull/1922#issuecomment-2018636818
> The documentation could probably use some more work, but I'd love guidance
on where to focus that: the implementation class? Or reference.conf?
I'd put
akhaku commented on PR #1922:
URL:
https://github.com/apache/cassandra-java-driver/pull/1922#issuecomment-2018549946
Additionally, this will tackle JAVA-3040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
akhaku opened a new pull request, #1922:
URL: https://github.com/apache/cassandra-java-driver/pull/1922
This PR open-sources the work Joey Lynch and I did and presented at
ApacheCon 2022. It requires a bit of work before it's mergeable, but hoping to
get some feedback on a couple areas
frankgh merged PR #41:
URL: https://github.com/apache/cassandra-analytics/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
absurdfarce merged PR #1909:
URL: https://github.com/apache/cassandra-java-driver/pull/1909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
michaelsembwever commented on code in PR #1921:
URL:
https://github.com/apache/cassandra-java-driver/pull/1921#discussion_r1535104581
##
README.md:
##
@@ -80,7 +80,7 @@ See the [Cassandra error handling done right
blog](https://www.datastax.com/blog
* [FAQ]
[API docs]:
absurdfarce commented on code in PR #1921:
URL:
https://github.com/apache/cassandra-java-driver/pull/1921#discussion_r1535063321
##
README.md:
##
@@ -80,7 +80,7 @@ See the [Cassandra error handling done right
blog](https://www.datastax.com/blog
* [FAQ]
[API docs]:
absurdfarce commented on code in PR #1921:
URL:
https://github.com/apache/cassandra-java-driver/pull/1921#discussion_r1535063553
##
README.md:
##
@@ -80,7 +80,7 @@ See the [Cassandra error handling done right
blog](https://www.datastax.com/blog
* [FAQ]
[API docs]:
absurdfarce merged PR #1908:
URL: https://github.com/apache/cassandra-java-driver/pull/1908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
absurdfarce opened a new pull request, #1921:
URL: https://github.com/apache/cassandra-java-driver/pull/1921
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
absurdfarce merged PR #1913:
URL: https://github.com/apache/cassandra-java-driver/pull/1913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
arjunashok commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1534349869
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RingInstance.java:
##
@@ -130,6 +130,22 @@ private void
frankgh commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1534250572
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RingInstance.java:
##
@@ -130,6 +130,22 @@ private void
arjunashok commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1534232804
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkWriterContext.java:
##
@@ -21,7 +21,9 @@
import
arjunashok commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1534231920
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##
@@ -56,10 +57,12 @@ public class
arjunashok commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1534231627
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/WriteResult.java:
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
adutra commented on code in PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#discussion_r1532813593
##
metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerMetricUpdater.java:
##
@@ -100,7 +100,10 @@ protected
arjunashok commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1533473809
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkSourceRelation.java:
##
@@ -129,6 +143,64 @@ private void
JeetKunDoug commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1532764805
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkSourceRelation.java:
##
@@ -129,6 +143,64 @@ private void
adutra commented on code in PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#discussion_r1532813593
##
metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerMetricUpdater.java:
##
@@ -100,7 +100,10 @@ protected
adutra commented on code in PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#discussion_r1532801560
##
metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerNodeMetricUpdater.java:
##
@@ -31,13 +31,18 @@
import
absurdfarce commented on code in PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#discussion_r1532705838
##
metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerMetricUpdater.java:
##
@@ -100,7 +100,10 @@
absurdfarce commented on code in PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#discussion_r1532689998
##
metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerSessionMetricUpdater.java:
##
@@ -30,22 +30,28 @@
absurdfarce commented on code in PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#discussion_r1532687869
##
metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerNodeMetricUpdater.java:
##
@@ -31,13 +31,18 @@
frankgh commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1532396813
##
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/bulkwriter/MockBulkWriterContext.java:
##
@@ -77,6 +78,23 @@ public class
adutra commented on code in PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#discussion_r1532412536
##
metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerMetricUpdater.java:
##
@@ -100,7 +100,10 @@ protected
adutra commented on code in PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#discussion_r1532412536
##
metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerMetricUpdater.java:
##
@@ -100,7 +100,10 @@ protected
absurdfarce commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2007673373
@adutra When you have some time would you mind taking a look at this one?
This came up from an internal DataStax investigation but given the nature of
the issue I'm
akhaku commented on code in PR #1635:
URL:
https://github.com/apache/cassandra-java-driver/pull/1635#discussion_r1525623390
##
core/src/main/java/com/datastax/oss/driver/internal/core/type/codec/UdtCodec.java:
##
@@ -105,10 +105,7 @@ public UdtValue decode(@Nullable ByteBuffer
akhaku commented on code in PR #1920:
URL:
https://github.com/apache/cassandra-java-driver/pull/1920#discussion_r1525614078
##
core/src/test/java/com/datastax/oss/driver/internal/core/metadata/MetadataManagerTest.java:
##
@@ -286,6 +290,25 @@ public void should_remove_node() {
absurdfarce commented on PR #1918:
URL:
https://github.com/apache/cassandra-java-driver/pull/1918#issuecomment-1997947155
Closing this out, will address in CASSANDRA-19468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
absurdfarce closed pull request #1918: Correction of exception handling in
asynchronous programming
URL: https://github.com/apache/cassandra-java-driver/pull/1918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
aratno commented on code in PR #1635:
URL:
https://github.com/apache/cassandra-java-driver/pull/1635#discussion_r1524601669
##
core/src/main/java/com/datastax/oss/driver/internal/core/type/codec/UdtCodec.java:
##
@@ -105,10 +105,7 @@ public UdtValue decode(@Nullable ByteBuffer
SiyaoIsHiding commented on PR #1735:
URL:
https://github.com/apache/cassandra-java-driver/pull/1735#issuecomment-1996315515
Work taken over to https://github.com/apache/cassandra-java-driver/pull/1919
--
This is an automated message from the Apache Git Service.
To respond to the message,
SiyaoIsHiding opened a new pull request, #1919:
URL: https://github.com/apache/cassandra-java-driver/pull/1919
…need the endpoint to be proactively resolved
Refactor existing usages of EndPoint#resolve to use retrieve when resolved
ip addresses are not needed.
Taken over from
SiyaoIsHiding commented on code in PR #1735:
URL:
https://github.com/apache/cassandra-java-driver/pull/1735#discussion_r1524149783
##
core/src/test/java/com/datastax/oss/driver/internal/core/metadata/SniEndPointTest.java:
##
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache
absurdfarce commented on PR #1918:
URL:
https://github.com/apache/cassandra-java-driver/pull/1918#issuecomment-1996093338
Ah, okay, I see your fundamental point @vararo27. I got confused myself by
the sequence of CompletionStages at play there but you're correct; what really
matters in
akhaku commented on code in PR #1635:
URL:
https://github.com/apache/cassandra-java-driver/pull/1635#discussion_r1524006033
##
core/src/main/java/com/datastax/oss/driver/internal/core/type/codec/UdtCodec.java:
##
@@ -105,10 +105,7 @@ public UdtValue decode(@Nullable ByteBuffer
akhaku commented on PR #1607:
URL:
https://github.com/apache/cassandra-java-driver/pull/1607#issuecomment-1995596202
Thanks for the approval! Rebased to fix the merge conflict, please merge
when ready.
--
This is an automated message from the Apache Git Service.
To respond to the
aratno commented on code in PR #1635:
URL:
https://github.com/apache/cassandra-java-driver/pull/1635#discussion_r1523809556
##
core/src/main/java/com/datastax/oss/driver/internal/core/type/codec/UdtCodec.java:
##
@@ -105,10 +105,7 @@ public UdtValue decode(@Nullable ByteBuffer
vanditsramblings commented on PR #1640:
URL:
https://github.com/apache/cassandra-java-driver/pull/1640#issuecomment-1995012337
+1 , this would be a great addition , allowing more granular access to
execution metrics.
--
This is an automated message from the Apache Git Service.
To
vararo27 commented on PR #1918:
URL:
https://github.com/apache/cassandra-java-driver/pull/1918#issuecomment-1994959017
Yes, agreed that it will never reach thenApplyAsync() and subsequent
whenComplete(). Basically, exception thrown by
schemaQueriesFactory.newInstance() reference is lost
absurdfarce commented on PR #1918:
URL:
https://github.com/apache/cassandra-java-driver/pull/1918#issuecomment-1994643967
I think we're talking about different whenComplete() blocks. The
newInstance() call throws an exception inside the whenComplete block that
starts with this code:
vararo27 commented on PR #1918:
URL:
https://github.com/apache/cassandra-java-driver/pull/1918#issuecomment-1993839304
Actually, exception thrown by below line will not move to the whenComplete
block following that. Basically, problem is that we have logic and exception
thrown outside of
absurdfarce commented on PR #1918:
URL:
https://github.com/apache/cassandra-java-driver/pull/1918#issuecomment-1992441145
For reference the code in question can be found
adutra commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-1991260084
Hi @nitinitt sorry for the late reply. I'm syncing with @absurdfarce and
others in order to merge all the ready PRs, but that is taking some time
because of huge backlog
vararo27 opened a new pull request, #1918:
URL: https://github.com/apache/cassandra-java-driver/pull/1918
An exception is thrown from DefaultSchemaQueriesFactory.java (newInstance
method) when Control connection goes down for any reason and new connection has
not yet initialized yet.
arjunashok commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1520641363
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkWriterContext.java:
##
@@ -21,7 +21,9 @@
import
arjunashok commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1520627909
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkSourceRelation.java:
##
@@ -107,17 +112,25 @@ private void
absurdfarce commented on PR #1909:
URL:
https://github.com/apache/cassandra-java-driver/pull/1909#issuecomment-1989603867
With two +1's from committers (mine + @adutra) this ticket was considered
eligible to merge. We can't do a squash merge at the moment, however, so we
need to resolve
absurdfarce commented on PR #1908:
URL:
https://github.com/apache/cassandra-java-driver/pull/1908#issuecomment-1989603594
With two +1's from committers (mine + @adutra) this ticket was considered
eligible to merge. We can't do a squash merge at the moment, however, so we
need to resolve
absurdfarce commented on PR #1913:
URL:
https://github.com/apache/cassandra-java-driver/pull/1913#issuecomment-1989604266
With two +1's from committers (mine + @adutra) this ticket was considered
eligible to merge. We can't do a squash merge at the moment, however, so we
need to resolve
absurdfarce commented on PR #1907:
URL:
https://github.com/apache/cassandra-java-driver/pull/1907#issuecomment-1989597253
With two +1's from committers (mine + one from driftx on the JIRA ticket)
this ticket was considered eligible to merge.
--
This is an automated message from the
absurdfarce commented on PR #1913:
URL:
https://github.com/apache/cassandra-java-driver/pull/1913#issuecomment-1986449928
Can't add my +1 for some reason but I approve this message as well. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please
absurdfarce commented on PR #1914:
URL:
https://github.com/apache/cassandra-java-driver/pull/1914#issuecomment-1986448006
Can't add my +1 for some reason but I approve this message as well. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please
SiyaoIsHiding commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-1986407007
I find it will lead to some missing metrics like `connected-nodes`. We need
another way to fix this for sure.
--
This is an automated message from the Apache Git
SiyaoIsHiding commented on code in PR #1743:
URL:
https://github.com/apache/cassandra-java-driver/pull/1743#discussion_r1516944635
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/DefaultLoadBalancingPolicy.java:
##
@@ -96,14 +99,38 @@ public class
SiyaoIsHiding commented on code in PR #1743:
URL:
https://github.com/apache/cassandra-java-driver/pull/1743#discussion_r1516934381
##
core/src/main/java/com/datastax/oss/driver/internal/core/metrics/AbstractMetricUpdater.java:
##
@@ -173,9 +173,8 @@ protected Timeout
SiyaoIsHiding opened a new pull request, #1916:
URL: https://github.com/apache/cassandra-java-driver/pull/1916
It is leaked by micrometer gauge initialization.
I used the following `application.conf`, which includes all node and session
level metrics, and the memory leak is gone.
```
SiyaoIsHiding commented on code in PR #1743:
URL:
https://github.com/apache/cassandra-java-driver/pull/1743#discussion_r1516914752
##
core/src/main/java/com/datastax/oss/driver/internal/core/util/concurrent/ReplayingEventFilter.java:
##
@@ -82,6 +82,7 @@ public void
JeetKunDoug opened a new pull request, #45:
URL: https://github.com/apache/cassandra-analytics/pull/45
This commit brings support for UDTs to the Bulk Writer. It converts Spark
nested StructType(s) into UDT values.
--
This is an automated message from the Apache Git Service.
To respond
yifan-c merged PR #43:
URL: https://github.com/apache/cassandra-analytics/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
frankgh commented on code in PR #43:
URL:
https://github.com/apache/cassandra-analytics/pull/43#discussion_r1515113234
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/validation/KeyStoreValidation.java:
##
@@ -81,6 +84,15 @@ public void validate()
frankgh commented on code in PR #43:
URL:
https://github.com/apache/cassandra-analytics/pull/43#discussion_r1515102552
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/validation/KeyStoreValidation.java:
##
@@ -81,6 +84,15 @@ public void validate()
sarankk commented on code in PR #43:
URL:
https://github.com/apache/cassandra-analytics/pull/43#discussion_r1515057459
##
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/validation/KeyStoreValidationTests.java:
##
@@ -97,4 +98,15 @@ public void
arjunashok commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1513798245
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkSourceRelation.java:
##
@@ -107,17 +112,25 @@ private void
arjunashok commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1513793354
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkWriterContext.java:
##
@@ -21,7 +21,9 @@
import
arjunashok commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1513793217
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RingInstance.java:
##
@@ -49,6 +49,7 @@ public RingInstance(ReplicaMetadata
arjunashok commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1513793094
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/RingInstance.java:
##
@@ -125,40 +126,28 @@ private void
arjunashok commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1513792433
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/common/Reportable.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software
arjunashok commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1513792138
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/common/Reportable.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software
yifan-c merged PR #44:
URL: https://github.com/apache/cassandra-analytics/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
yifan-c commented on code in PR #44:
URL:
https://github.com/apache/cassandra-analytics/pull/44#discussion_r1513261310
##
cassandra-bridge/src/main/java/org/apache/cassandra/spark/data/DataLayer.java:
##
@@ -164,6 +164,11 @@ public CassandraVersion version()
public
yifan-c commented on code in PR #44:
URL:
https://github.com/apache/cassandra-analytics/pull/44#discussion_r1509875090
##
cassandra-bridge/src/main/java/org/apache/cassandra/spark/utils/ReaderTimeProvider.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software
yifan-c commented on code in PR #44:
URL:
https://github.com/apache/cassandra-analytics/pull/44#discussion_r1509874100
##
cassandra-bridge/src/main/java/org/apache/cassandra/spark/utils/TimeProvider.java:
##
@@ -19,16 +19,37 @@
package org.apache.cassandra.spark.utils;
frankgh commented on code in PR #44:
URL:
https://github.com/apache/cassandra-analytics/pull/44#discussion_r1509746490
##
cassandra-bridge/src/main/java/org/apache/cassandra/spark/utils/ReaderTimeProvider.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software
frankgh commented on code in PR #41:
URL:
https://github.com/apache/cassandra-analytics/pull/41#discussion_r1509715774
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/BulkWriterContext.java:
##
@@ -21,7 +21,9 @@
import java.io.Serializable;
frankgh commented on code in PR #43:
URL:
https://github.com/apache/cassandra-analytics/pull/43#discussion_r1509704327
##
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/validation/KeyStoreValidationTests.java:
##
@@ -97,4 +98,15 @@ public void
yifan-c commented on code in PR #44:
URL:
https://github.com/apache/cassandra-analytics/pull/44#discussion_r1508274918
##
cassandra-bridge/src/main/java/org/apache/cassandra/spark/utils/TimeProvider.java:
##
@@ -19,16 +19,37 @@
package org.apache.cassandra.spark.utils;
jberragan commented on code in PR #44:
URL:
https://github.com/apache/cassandra-analytics/pull/44#discussion_r1508249721
##
cassandra-bridge/src/main/java/org/apache/cassandra/spark/utils/TimeProvider.java:
##
@@ -19,16 +19,37 @@
package org.apache.cassandra.spark.utils;
jberragan commented on code in PR #44:
URL:
https://github.com/apache/cassandra-analytics/pull/44#discussion_r1508243589
##
cassandra-bridge/src/main/java/org/apache/cassandra/spark/utils/test/TestSchema.java:
##
@@ -398,9 +409,11 @@ private String buildCreateStatement(List
nitinitt commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-1971866885
Hey @adutra @absurdfarce Checking in, would the PR be accepted?
As I see other PR: https://github.com/apache/cassandra-java-driver/pull/1907
getting merged 2 weeks
201 - 300 of 1137 matches
Mail list logo
