[jira] [Commented] (CASSANDRA-14805) Fails on running Cassandra server
[ https://issues.apache.org/jira/browse/CASSANDRA-14805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639256#comment-16639256 ] Ravi Gangwar commented on CASSANDRA-14805: -- Need urgent help ! > Fails on running Cassandra server > -- > > Key: CASSANDRA-14805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14805 > Project: Cassandra > Issue Type: Bug >Reporter: Ravi Gangwar >Priority: Critical > > Full Product Version : > Fails on java version. It's Java "1.8.0_181" > Os Version : Ubuntu 16.04 LTS > EXTRA RELEVANT SYSTEM CONFIGURATION : > Just installed Cassandra 2.2.11 > A DESCRIPTION OF THE PROBLEM : > # > # A fatal error has been detected by the Java Runtime Environment: > # > # SIGBUS (0x7) at pc=0x7f42fc492e70, pid=12128, tid=0x7f42fc3c9700 > # > # JRE version: Java(TM) SE Runtime Environment (8.0_181-b13) (build > 1.8.0_181-b13) > # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.181-b13 mixed mode > linux-amd64 compressed oops) > # Problematic frame: > # C [liblz4-java8098863625230398555.so+0x5e70] LZ4_decompress_fast+0xd0 > # > # Failed to write core dump. Core dumps have been disabled. To enable core > dumping, try "ulimit -c unlimited" before starting Java again > # > # If you would like to submit a bug report, please visit: > # http://bugreport.java.com/bugreport/crash.jsp > # The crash happened outside the Java Virtual Machine in native code. > # See problematic frame for where to report the bug. > # > --- T H R E A D --- > Current thread (0x006d0800): JavaThread "CompactionExecutor:7" daemon > [_thread_in_native, id=5278, stack(0x7f42fc389000,0x7f42fc3ca000)] > siginfo: si_signo: 7 (SIGBUS), si_code: 2 (BUS_ADRERR), si_addr: > 0x7f2026b8b000 > Registers: > RAX=0x7f432200750a, RBX=0x7f2026b8affc, RCX=0x7f4322005856, > RDX=0x7f432200750a > RSP=0x7f42fc3c7e50, RBP=0x7f2026b8940f, RSI=0x7f4322011d88, > RDI=0x0007 > R8 =0x7f4322011d84, R9 =0x7f4322011d90, R10=0x0003, > R11=0x > R12=0x, R13=0x7f1ffe33d40f, R14=0x7f4322011d87, > R15=0x7f4322011d8b > RIP=0x7f42fc492e70, EFLAGS=0x00010287, CSGSFS=0x002b0033, > ERR=0x0004 > TRAPNO=0x000e > Top of Stack: (sp=0x7f42fc3c7e50) > 0x7f42fc3c7e50: 4ce9 > 0x7f42fc3c7e60: 0004 0001 > 0x7f42fc3c7e70: 0002 0001 > 0x7f42fc3c7e80: 0004 0004 > 0x7f42fc3c7e90: 0004 0004 > 0x7f42fc3c7ea0: > 0x7f42fc3c7eb0: > 0x7f42fc3c7ec0: 0001 > 0x7f42fc3c7ed0: 0002 0003 > 0x7f42fc3c7ee0: 7f42fc3c7fa8 006d09f8 > 0x7f42fc3c7ef0: > 0x7f42fc3c7f00: 7f1ffe33d40f 7f4322001d90 > 0x7f42fc3c7f10: 2884c000 7f42fc48f59d > 0x7f42fc3c7f20: 000733b5fa78 > 0x7f42fc3c7f30: 7f42fc3c7fc0 > 0x7f42fc3c7f40: 2884bfff 7f42fc3c7fa8 > 0x7f42fc3c7f50: 006d0800 7f43119e8f1d > 0x7f42fc3c7f60: 7f42fc3c7f98 > 0x7f42fc3c7f70: 0001 > 0x7f42fc3c7f80: 00070764f4d8 > 0x7f42fc3c7f90: 00075b5937f0 > 0x7f42fc3c7fa0: 7f42fc3c7ff0 0006f91d2e38 > 0x7f42fc3c7fb0: 0006d7e3f210 7f42fc3c8040 > 0x7f42fc3c7fc0: 00070764f4d8 7f4311f9eca8 > 0x7f42fc3c7fd0: 51070001 00072dc9abb0 > 0x7f42fc3c7fe0: 28851103 0006dd2d > 0x7f42fc3c7ff0: 00022883f40b eb6b26fe2884bffc > 0x7f42fc3c8000: 00070764f4d8 00012884c000 > 0x7f42fc3c8010: 00075b5937f0 00075b5937f0 > 0x7f42fc3c8020: 00060008 0006d7f67598 > 0x7f42fc3c8030: 0006d7f67348 7f43120080d4 > 0x7f42fc3c8040: 0001 0006d7f676d8 > > > SYSTEM CONFIGURATION : > > # CPU - Intel Core i7 - 4771 CPU @ 3.50 GHz * 8 > 2. RAM - 16 GB > 3. STORAGE - 967.6 GB > 4. OS - Ubuntu 16.04 LTS > 5. Apache Cassandra - 2.2.11 > 6. CPP Driver - 2.2.1-1 > 7. libuv - 1.4.2-1 > 8. Java version - "1.8.0_181" > Java (TM) SE Runtime Environment (build 1.8.0_181-b13) > Java Hotspot (TM) 64-Bit Server VM (build 25.181-b13, mixed mode) > > Cassandra was working normally before generating this bug. Now when i am > trying to restart my server getting this bug. > Please help me asap. > > Regards, > Ravi > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CASSANDRA-14373) Allow using custom script for chronicle queue BinLog archival
[
https://issues.apache.org/jira/browse/CASSANDRA-14373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638997#comment-16638997
]
Ariel Weisberg commented on CASSANDRA-14373:
The dtests are good tests but could they be unit tests since they are single
node. The reason I harp on it is that they are so much slower and not adding
more of them is a win. I'm not sure if we can test nodetool from a dtest, but
if we could it would be amazing.
> Allow using custom script for chronicle queue BinLog archival
> -
>
> Key: CASSANDRA-14373
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14373
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Stefan Podkowinski
>Assignee: Pramod K Sivaraju
>Priority: Major
> Labels: lhf, pull-request-available
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It would be nice to allow the user to configure an archival script that will
> be executed in {{BinLog.onReleased(cycle, file)}} for every deleted bin log,
> just as we do in {{CommitLogArchiver}}. The script should be able to copy the
> released file to an external location or do whatever the author hand in mind.
> Deleting the log file should be delegated to the script as well.
> See CASSANDRA-13983, CASSANDRA-12151 for use cases.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14373) Allow using custom script for chronicle queue BinLog archival
[
https://issues.apache.org/jira/browse/CASSANDRA-14373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638942#comment-16638942
]
Ariel Weisberg edited comment on CASSANDRA-14373 at 10/4/18 10:05 PM:
--
Some quick review feedback.
* [Removing documentation of defaults doesn't seem like a pure win since they
still seem to be
there?|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-e517aca4b5a9a4773e1957fa4574862aR26]
* [This isn't just a path right it's a format specified of sorts with
%path?|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-e517aca4b5a9a4773e1957fa4574862aR44]
* [This is BinLogOptions but the comments reference Audit log and there is a
typo in the first sentence
here|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-8d9638dbfb056fb8020e9b32e60e3a61R33]
* Depending on what the archiving script does and why it failed there could be
unfortunate consequences to retrying repeatedly.
* [exec forks, forking can be slow because of page table copying which in the
past was slow under things like
Xen.|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-3a9be5c6d02a55bd3efddb1053dc87dbR160].
I'm just mentioning it. I don't think you need to make it better right now. I
don't know offhand how you invoke an external command more efficiently from
Java.
* [Is this going to enable it for all
tests?|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-b1c721618608f703239339811634ef3dR51]
Is that a good idea can we only enable it for just the unit tests that require
it?
* [Should use execute instead of submit unless consuming the result
future|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-3a9be5c6d02a55bd3efddb1053dc87dbR77]
* [Same here |
https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-3a9be5c6d02a55bd3efddb1053dc87dbR120]
I'll look at the dtests now.
was (Author: aweisberg):
Some quick review feedback.
* [Removing documentation of defaults doesn't seem like a pure win since they
still seem to be
there?|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-e517aca4b5a9a4773e1957fa4574862aR26]
* [This isn't just a path right it's a format specified of sorts with
%path?|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-e517aca4b5a9a4773e1957fa4574862aR44]
* [This is BinLogOptions but the comments reference Audit log and there is a
typo in the first sentence
here|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-8d9638dbfb056fb8020e9b32e60e3a61R33]
* Depending on what the archiving script does and why it failed there could be
unfortunate consequences to retrying repeatedly.
* [exec forks, forking can be slow because of page table copying which in the
was slow under things like
Xen.|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-3a9be5c6d02a55bd3efddb1053dc87dbR160].
I'm just mentioning it. I don't think you need to make it better right now. I
don't know offhand how you invoke an external command more efficiently from
Java.
* [Is this going to enable it for all
tests?|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-b1c721618608f703239339811634ef3dR51]
Is that a good idea can we only enable it for just the unit tests that require
it?
* [Should use execute instead of submit unless consuming the result
future|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-3a9be5c6d02a55bd3efddb1053dc87dbR77]
* [Same here |
https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-3a9be5c6d02a55bd3efddb1053dc87dbR120]
I'll look at the dtests now.
> Allow using custom script for chronicle queue BinLog archival
> -
>
> Key: CASSANDRA-14373
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14373
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Stefan Podkowinski
>Assignee: Pramod K Sivaraju
>Priority: Major
> Labels: lhf, pull-request-available
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It would be nice to allow the user to configure an archival script that will
> be executed in {{BinLog.onReleased(cycle, file)}} for every deleted bin log,
> just as we do in {{CommitLogArchiver}}. The script should be able to copy the
> released file to an external location or do whatever the author hand in mind.
> Deleting the log file should be delegated to the script as
[jira] [Commented] (CASSANDRA-14373) Allow using custom script for chronicle queue BinLog archival
[
https://issues.apache.org/jira/browse/CASSANDRA-14373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638942#comment-16638942
]
Ariel Weisberg commented on CASSANDRA-14373:
Some quick review feedback.
* [Removing documentation of defaults doesn't seem like a pure win since they
still seem to be
there?|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-e517aca4b5a9a4773e1957fa4574862aR26]
* [This isn't just a path right it's a format specified of sorts with
%path?|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-e517aca4b5a9a4773e1957fa4574862aR44]
* [This is BinLogOptions but the comments reference Audit log and there is a
typo in the first sentence
here|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-8d9638dbfb056fb8020e9b32e60e3a61R33]
* Depending on what the archiving script does and why it failed there could be
unfortunate consequences to retrying repeatedly.
* [exec forks, forking can be slow because of page table copying which in the
was slow under things like
Xen.|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-3a9be5c6d02a55bd3efddb1053dc87dbR160].
I'm just mentioning it. I don't think you need to make it better right now. I
don't know offhand how you invoke an external command more efficiently from
Java.
* [Is this going to enable it for all
tests?|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-b1c721618608f703239339811634ef3dR51]
Is that a good idea can we only enable it for just the unit tests that require
it?
* [Should use execute instead of submit unless consuming the result
future|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-3a9be5c6d02a55bd3efddb1053dc87dbR77]
* [Same here |
https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14373?expand=1#diff-3a9be5c6d02a55bd3efddb1053dc87dbR120]
I'll look at the dtests now.
> Allow using custom script for chronicle queue BinLog archival
> -
>
> Key: CASSANDRA-14373
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14373
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Stefan Podkowinski
>Assignee: Pramod K Sivaraju
>Priority: Major
> Labels: lhf, pull-request-available
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It would be nice to allow the user to configure an archival script that will
> be executed in {{BinLog.onReleased(cycle, file)}} for every deleted bin log,
> just as we do in {{CommitLogArchiver}}. The script should be able to copy the
> released file to an external location or do whatever the author hand in mind.
> Deleting the log file should be delegated to the script as well.
> See CASSANDRA-13983, CASSANDRA-12151 for use cases.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14803) Rows that cross index block boundaries can cause incomplete reverse reads in some cases.
[ https://issues.apache.org/jira/browse/CASSANDRA-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-14803: Resolution: Fixed Status: Resolved (was: Patch Available) committed as [ab0e30e75904e4d637f07b2ec64334073eb061ec|https://github.com/apache/cassandra/commit/ab0e30e75904e4d637f07b2ec64334073eb061ec], thanks > Rows that cross index block boundaries can cause incomplete reverse reads in > some cases. > > > Key: CASSANDRA-14803 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14803 > Project: Cassandra > Issue Type: Bug >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Major > Fix For: 3.0.x, 3.11.x > > > When we're reading 2.1 sstables in reverse, we skip the first row of an index > block if it's split across index boundaries. The entire row will be read at > the end of the next block. In some cases though, the only thing in this index > block is the partial row, so we return an empty iterator. The empty iterator > is then interpreted as the end of the row further down the call stack, so we > return early without reading the rest of the data. This only affects 3.x > during upgrades from 2.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-12297) Privacy Violation - Heap Inspection
[
https://issues.apache.org/jira/browse/CASSANDRA-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ariel Weisberg reassigned CASSANDRA-12297:
--
Assignee: (was: Ariel Weisberg)
> Privacy Violation - Heap Inspection
> ---
>
> Key: CASSANDRA-12297
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12297
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Eduardo Aguinaga
>Priority: Major
>
> Overview:
> In May through June of 2016 a static analysis was performed on version 3.0.5
> of the Cassandra source code. The analysis included
> an automated analysis using HP Fortify v4.21 SCA and a manual analysis
> utilizing SciTools Understand v4. The results of that
> analysis includes the issue below.
> Issue:
> In the file PasswordAuthenticator.java on line 129, 164 and 222 a string
> object is used to store sensitive data. String objects are immutable and
> should not be used to store sensitive data. Sensitive data should be stored
> in char or byte arrays and the contents of those arrays should be cleared
> ASAP. Operations performed on string objects will require that the original
> object be copied and the operation be applied in the new copy of the string
> object. This results in the likelihood that multiple copies of sensitive data
> being present in the heap until garbage collection takes place.
> The snippet below shows the issue on line 129:
> PasswordAuthenticator.java, lines 123-134:
> {code:java}
> 123 public AuthenticatedUser legacyAuthenticate(Map
> credentials) throws AuthenticationException
> 124 {
> 125 String username = credentials.get(USERNAME_KEY);
> 126 if (username == null)
> 127 throw new AuthenticationException(String.format("Required key
> '%s' is missing", USERNAME_KEY));
> 128
> 129 String password = credentials.get(PASSWORD_KEY);
> 130 if (password == null)
> 131 throw new AuthenticationException(String.format("Required key
> '%s' is missing", PASSWORD_KEY));
> 132
> 133 return authenticate(username, password);
> 134 }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12297) Privacy Violation - Heap Inspection
[
https://issues.apache.org/jira/browse/CASSANDRA-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638816#comment-16638816
]
Ariel Weisberg commented on CASSANDRA-12297:
Unfortunately not a lot of eyes on this issue yet.
bcrypt accepts a {{String}} parameter for password so we are already in the
situation where we can't zero out this material in at least once instance. If
we were aiming to do that then we would also need to zero out the network
buffer we used to read this value.
The wire protocol sends the password over the wire in plaintext. Ideally we
would hash or salt and hash it before it ever leaves the client. That won't
help prevent the material from used to log into Cassandra, but it will help
with password reuse with other systems.
If heap inspection is a part of our threat model it seems like we need to do a
more thorough review review of how we handle key and password material.
> Privacy Violation - Heap Inspection
> ---
>
> Key: CASSANDRA-12297
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12297
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Eduardo Aguinaga
>Assignee: Ariel Weisberg
>Priority: Major
>
> Overview:
> In May through June of 2016 a static analysis was performed on version 3.0.5
> of the Cassandra source code. The analysis included
> an automated analysis using HP Fortify v4.21 SCA and a manual analysis
> utilizing SciTools Understand v4. The results of that
> analysis includes the issue below.
> Issue:
> In the file PasswordAuthenticator.java on line 129, 164 and 222 a string
> object is used to store sensitive data. String objects are immutable and
> should not be used to store sensitive data. Sensitive data should be stored
> in char or byte arrays and the contents of those arrays should be cleared
> ASAP. Operations performed on string objects will require that the original
> object be copied and the operation be applied in the new copy of the string
> object. This results in the likelihood that multiple copies of sensitive data
> being present in the heap until garbage collection takes place.
> The snippet below shows the issue on line 129:
> PasswordAuthenticator.java, lines 123-134:
> {code:java}
> 123 public AuthenticatedUser legacyAuthenticate(Map
> credentials) throws AuthenticationException
> 124 {
> 125 String username = credentials.get(USERNAME_KEY);
> 126 if (username == null)
> 127 throw new AuthenticationException(String.format("Required key
> '%s' is missing", USERNAME_KEY));
> 128
> 129 String password = credentials.get(PASSWORD_KEY);
> 130 if (password == null)
> 131 throw new AuthenticationException(String.format("Required key
> '%s' is missing", PASSWORD_KEY));
> 132
> 133 return authenticate(username, password);
> 134 }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[2/6] cassandra git commit: Reverse order reads can return incomplete results
Reverse order reads can return incomplete results
Patch by Blake Eggleston; Reviewed by Sam Tunnicliffe for CASSANDRA-14803
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/ab0e30e7
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/ab0e30e7
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/ab0e30e7
Branch: refs/heads/cassandra-3.11
Commit: ab0e30e75904e4d637f07b2ec64334073eb061ec
Parents: 30d2835
Author: Blake Eggleston
Authored: Wed Oct 3 15:53:04 2018 -0700
Committer: Blake Eggleston
Committed: Thu Oct 4 12:46:21 2018 -0700
--
CHANGES.txt | 1 +
.../columniterator/SSTableReversedIterator.java | 40 +--
...bles-legacy_ka_14803-ka-1-CompressionInfo.db | Bin 0 -> 43 bytes
.../legacy_tables-legacy_ka_14803-ka-1-Data.db | Bin 0 -> 16555 bytes
...gacy_tables-legacy_ka_14803-ka-1-Digest.sha1 | 1 +
...legacy_tables-legacy_ka_14803-ka-1-Filter.db | Bin 0 -> 16 bytes
.../legacy_tables-legacy_ka_14803-ka-1-Index.db | Bin 0 -> 206 bytes
...cy_tables-legacy_ka_14803-ka-1-Statistics.db | Bin 0 -> 4450 bytes
...egacy_tables-legacy_ka_14803-ka-1-Summary.db | Bin 0 -> 92 bytes
.../legacy_tables-legacy_ka_14803-ka-1-TOC.txt | 8
.../cassandra/io/sstable/LegacySSTableTest.java | 21 +-
11 files changed, 58 insertions(+), 13 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/ab0e30e7/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 70b2996..3c6d3b5 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.0.18
+ * Reverse order reads can return incomplete results (CASSANDRA-14803)
* Avoid calling iter.next() in a loop when notifying indexers about range
tombstones (CASSANDRA-14794)
* Fix purging semi-expired RT boundaries in reversed iterators
(CASSANDRA-14672)
* DESC order reads can fail to return the last Unfiltered in the partition
(CASSANDRA-14766)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/ab0e30e7/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java
--
diff --git
a/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java
b/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java
index d5b46a4..f8c0e77 100644
---
a/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java
+++
b/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java
@@ -20,6 +20,8 @@ package org.apache.cassandra.db.columniterator;
import java.io.IOException;
import java.util.*;
+import com.google.common.base.Preconditions;
+
import org.apache.cassandra.config.CFMetaData;
import org.apache.cassandra.db.*;
import org.apache.cassandra.db.filter.ColumnFilter;
@@ -314,18 +316,32 @@ public class SSTableReversedIterator extends
AbstractSSTableIterator
if (super.hasNextInternal())
return true;
-// We have nothing more for our current block, move the next one
(so the one before on disk).
-int nextBlockIdx = indexState.currentBlockIdx() - 1;
-if (nextBlockIdx < 0 || nextBlockIdx < lastBlockIdx)
-return false;
-
-// The slice start can be in
-indexState.setToBlock(nextBlockIdx);
-readCurrentBlock(true, nextBlockIdx != lastBlockIdx);
-// since that new block is within the bounds we've computed in
setToSlice(), we know there will
-// always be something matching the slice unless we're on the
lastBlockIdx (in which case there
-// may or may not be results, but if there isn't, we're done for
the slice).
-return iterator.hasNext();
+while (true)
+{
+// We have nothing more for our current block, move the next
one (so the one before on disk).
+int nextBlockIdx = indexState.currentBlockIdx() - 1;
+if (nextBlockIdx < 0 || nextBlockIdx < lastBlockIdx)
+return false;
+
+// The slice start can be in
+indexState.setToBlock(nextBlockIdx);
+readCurrentBlock(true, nextBlockIdx != lastBlockIdx);
+
+// for pre-3.0 storage formats, index blocks that only contain
a single row and that row crosses
+// index boundaries, the iterator will be empty even though we
haven't read everything we're intending
+// to read. In that case, we want to read the next index
block. This shouldn't be possible in 3.0+
+// formats (see next comment)
+if (!iterator.hasNext() && nextBlockIdx >
[4/6] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.11
Merge branch 'cassandra-3.0' into cassandra-3.11 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/70303563 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/70303563 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/70303563 Branch: refs/heads/trunk Commit: 70303563e9796ccc87581f5d41071b624872815e Parents: c7e6eee ab0e30e Author: Blake Eggleston Authored: Thu Oct 4 12:56:39 2018 -0700 Committer: Blake Eggleston Committed: Thu Oct 4 12:56:39 2018 -0700 -- CHANGES.txt | 2 + .../columniterator/SSTableReversedIterator.java | 40 +-- ...bles-legacy_ka_14803-ka-1-CompressionInfo.db | Bin 0 -> 43 bytes .../legacy_tables-legacy_ka_14803-ka-1-Data.db | Bin 0 -> 16555 bytes ...gacy_tables-legacy_ka_14803-ka-1-Digest.sha1 | 1 + ...legacy_tables-legacy_ka_14803-ka-1-Filter.db | Bin 0 -> 16 bytes .../legacy_tables-legacy_ka_14803-ka-1-Index.db | Bin 0 -> 206 bytes ...cy_tables-legacy_ka_14803-ka-1-Statistics.db | Bin 0 -> 4450 bytes ...egacy_tables-legacy_ka_14803-ka-1-Summary.db | Bin 0 -> 92 bytes .../legacy_tables-legacy_ka_14803-ka-1-TOC.txt | 8 .../cassandra/io/sstable/LegacySSTableTest.java | 20 ++ 11 files changed, 59 insertions(+), 12 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/70303563/CHANGES.txt -- diff --cc CHANGES.txt index dfc0eeb,3c6d3b5..0607528 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,5 -1,5 +1,7 @@@ +3.11.4 +Merged from 3.0: + 3.0.18 + * Reverse order reads can return incomplete results (CASSANDRA-14803) * Avoid calling iter.next() in a loop when notifying indexers about range tombstones (CASSANDRA-14794) * Fix purging semi-expired RT boundaries in reversed iterators (CASSANDRA-14672) * DESC order reads can fail to return the last Unfiltered in the partition (CASSANDRA-14766) http://git-wip-us.apache.org/repos/asf/cassandra/blob/70303563/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/70303563/test/unit/org/apache/cassandra/io/sstable/LegacySSTableTest.java -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[6/6] cassandra git commit: Merge branch 'cassandra-3.11' into trunk
Merge branch 'cassandra-3.11' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/a9138c5e Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/a9138c5e Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/a9138c5e Branch: refs/heads/trunk Commit: a9138c5e9cfabd4059848c7e611520ca2239edd2 Parents: bd0cef9 7030356 Author: Blake Eggleston Authored: Thu Oct 4 13:00:13 2018 -0700 Committer: Blake Eggleston Committed: Thu Oct 4 13:00:13 2018 -0700 -- -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[5/6] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.11
Merge branch 'cassandra-3.0' into cassandra-3.11 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/70303563 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/70303563 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/70303563 Branch: refs/heads/cassandra-3.11 Commit: 70303563e9796ccc87581f5d41071b624872815e Parents: c7e6eee ab0e30e Author: Blake Eggleston Authored: Thu Oct 4 12:56:39 2018 -0700 Committer: Blake Eggleston Committed: Thu Oct 4 12:56:39 2018 -0700 -- CHANGES.txt | 2 + .../columniterator/SSTableReversedIterator.java | 40 +-- ...bles-legacy_ka_14803-ka-1-CompressionInfo.db | Bin 0 -> 43 bytes .../legacy_tables-legacy_ka_14803-ka-1-Data.db | Bin 0 -> 16555 bytes ...gacy_tables-legacy_ka_14803-ka-1-Digest.sha1 | 1 + ...legacy_tables-legacy_ka_14803-ka-1-Filter.db | Bin 0 -> 16 bytes .../legacy_tables-legacy_ka_14803-ka-1-Index.db | Bin 0 -> 206 bytes ...cy_tables-legacy_ka_14803-ka-1-Statistics.db | Bin 0 -> 4450 bytes ...egacy_tables-legacy_ka_14803-ka-1-Summary.db | Bin 0 -> 92 bytes .../legacy_tables-legacy_ka_14803-ka-1-TOC.txt | 8 .../cassandra/io/sstable/LegacySSTableTest.java | 20 ++ 11 files changed, 59 insertions(+), 12 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/70303563/CHANGES.txt -- diff --cc CHANGES.txt index dfc0eeb,3c6d3b5..0607528 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,5 -1,5 +1,7 @@@ +3.11.4 +Merged from 3.0: + 3.0.18 + * Reverse order reads can return incomplete results (CASSANDRA-14803) * Avoid calling iter.next() in a loop when notifying indexers about range tombstones (CASSANDRA-14794) * Fix purging semi-expired RT boundaries in reversed iterators (CASSANDRA-14672) * DESC order reads can fail to return the last Unfiltered in the partition (CASSANDRA-14766) http://git-wip-us.apache.org/repos/asf/cassandra/blob/70303563/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/70303563/test/unit/org/apache/cassandra/io/sstable/LegacySSTableTest.java -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[3/6] cassandra git commit: Reverse order reads can return incomplete results
Reverse order reads can return incomplete results
Patch by Blake Eggleston; Reviewed by Sam Tunnicliffe for CASSANDRA-14803
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/ab0e30e7
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/ab0e30e7
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/ab0e30e7
Branch: refs/heads/trunk
Commit: ab0e30e75904e4d637f07b2ec64334073eb061ec
Parents: 30d2835
Author: Blake Eggleston
Authored: Wed Oct 3 15:53:04 2018 -0700
Committer: Blake Eggleston
Committed: Thu Oct 4 12:46:21 2018 -0700
--
CHANGES.txt | 1 +
.../columniterator/SSTableReversedIterator.java | 40 +--
...bles-legacy_ka_14803-ka-1-CompressionInfo.db | Bin 0 -> 43 bytes
.../legacy_tables-legacy_ka_14803-ka-1-Data.db | Bin 0 -> 16555 bytes
...gacy_tables-legacy_ka_14803-ka-1-Digest.sha1 | 1 +
...legacy_tables-legacy_ka_14803-ka-1-Filter.db | Bin 0 -> 16 bytes
.../legacy_tables-legacy_ka_14803-ka-1-Index.db | Bin 0 -> 206 bytes
...cy_tables-legacy_ka_14803-ka-1-Statistics.db | Bin 0 -> 4450 bytes
...egacy_tables-legacy_ka_14803-ka-1-Summary.db | Bin 0 -> 92 bytes
.../legacy_tables-legacy_ka_14803-ka-1-TOC.txt | 8
.../cassandra/io/sstable/LegacySSTableTest.java | 21 +-
11 files changed, 58 insertions(+), 13 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/ab0e30e7/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 70b2996..3c6d3b5 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.0.18
+ * Reverse order reads can return incomplete results (CASSANDRA-14803)
* Avoid calling iter.next() in a loop when notifying indexers about range
tombstones (CASSANDRA-14794)
* Fix purging semi-expired RT boundaries in reversed iterators
(CASSANDRA-14672)
* DESC order reads can fail to return the last Unfiltered in the partition
(CASSANDRA-14766)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/ab0e30e7/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java
--
diff --git
a/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java
b/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java
index d5b46a4..f8c0e77 100644
---
a/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java
+++
b/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java
@@ -20,6 +20,8 @@ package org.apache.cassandra.db.columniterator;
import java.io.IOException;
import java.util.*;
+import com.google.common.base.Preconditions;
+
import org.apache.cassandra.config.CFMetaData;
import org.apache.cassandra.db.*;
import org.apache.cassandra.db.filter.ColumnFilter;
@@ -314,18 +316,32 @@ public class SSTableReversedIterator extends
AbstractSSTableIterator
if (super.hasNextInternal())
return true;
-// We have nothing more for our current block, move the next one
(so the one before on disk).
-int nextBlockIdx = indexState.currentBlockIdx() - 1;
-if (nextBlockIdx < 0 || nextBlockIdx < lastBlockIdx)
-return false;
-
-// The slice start can be in
-indexState.setToBlock(nextBlockIdx);
-readCurrentBlock(true, nextBlockIdx != lastBlockIdx);
-// since that new block is within the bounds we've computed in
setToSlice(), we know there will
-// always be something matching the slice unless we're on the
lastBlockIdx (in which case there
-// may or may not be results, but if there isn't, we're done for
the slice).
-return iterator.hasNext();
+while (true)
+{
+// We have nothing more for our current block, move the next
one (so the one before on disk).
+int nextBlockIdx = indexState.currentBlockIdx() - 1;
+if (nextBlockIdx < 0 || nextBlockIdx < lastBlockIdx)
+return false;
+
+// The slice start can be in
+indexState.setToBlock(nextBlockIdx);
+readCurrentBlock(true, nextBlockIdx != lastBlockIdx);
+
+// for pre-3.0 storage formats, index blocks that only contain
a single row and that row crosses
+// index boundaries, the iterator will be empty even though we
haven't read everything we're intending
+// to read. In that case, we want to read the next index
block. This shouldn't be possible in 3.0+
+// formats (see next comment)
+if (!iterator.hasNext() && nextBlockIdx >
[1/6] cassandra git commit: Reverse order reads can return incomplete results
Repository: cassandra
Updated Branches:
refs/heads/cassandra-3.0 30d283580 -> ab0e30e75
refs/heads/cassandra-3.11 c7e6eee58 -> 70303563e
refs/heads/trunk bd0cef9a3 -> a9138c5e9
Reverse order reads can return incomplete results
Patch by Blake Eggleston; Reviewed by Sam Tunnicliffe for CASSANDRA-14803
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/ab0e30e7
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/ab0e30e7
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/ab0e30e7
Branch: refs/heads/cassandra-3.0
Commit: ab0e30e75904e4d637f07b2ec64334073eb061ec
Parents: 30d2835
Author: Blake Eggleston
Authored: Wed Oct 3 15:53:04 2018 -0700
Committer: Blake Eggleston
Committed: Thu Oct 4 12:46:21 2018 -0700
--
CHANGES.txt | 1 +
.../columniterator/SSTableReversedIterator.java | 40 +--
...bles-legacy_ka_14803-ka-1-CompressionInfo.db | Bin 0 -> 43 bytes
.../legacy_tables-legacy_ka_14803-ka-1-Data.db | Bin 0 -> 16555 bytes
...gacy_tables-legacy_ka_14803-ka-1-Digest.sha1 | 1 +
...legacy_tables-legacy_ka_14803-ka-1-Filter.db | Bin 0 -> 16 bytes
.../legacy_tables-legacy_ka_14803-ka-1-Index.db | Bin 0 -> 206 bytes
...cy_tables-legacy_ka_14803-ka-1-Statistics.db | Bin 0 -> 4450 bytes
...egacy_tables-legacy_ka_14803-ka-1-Summary.db | Bin 0 -> 92 bytes
.../legacy_tables-legacy_ka_14803-ka-1-TOC.txt | 8
.../cassandra/io/sstable/LegacySSTableTest.java | 21 +-
11 files changed, 58 insertions(+), 13 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/ab0e30e7/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 70b2996..3c6d3b5 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.0.18
+ * Reverse order reads can return incomplete results (CASSANDRA-14803)
* Avoid calling iter.next() in a loop when notifying indexers about range
tombstones (CASSANDRA-14794)
* Fix purging semi-expired RT boundaries in reversed iterators
(CASSANDRA-14672)
* DESC order reads can fail to return the last Unfiltered in the partition
(CASSANDRA-14766)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/ab0e30e7/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java
--
diff --git
a/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java
b/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java
index d5b46a4..f8c0e77 100644
---
a/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java
+++
b/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java
@@ -20,6 +20,8 @@ package org.apache.cassandra.db.columniterator;
import java.io.IOException;
import java.util.*;
+import com.google.common.base.Preconditions;
+
import org.apache.cassandra.config.CFMetaData;
import org.apache.cassandra.db.*;
import org.apache.cassandra.db.filter.ColumnFilter;
@@ -314,18 +316,32 @@ public class SSTableReversedIterator extends
AbstractSSTableIterator
if (super.hasNextInternal())
return true;
-// We have nothing more for our current block, move the next one
(so the one before on disk).
-int nextBlockIdx = indexState.currentBlockIdx() - 1;
-if (nextBlockIdx < 0 || nextBlockIdx < lastBlockIdx)
-return false;
-
-// The slice start can be in
-indexState.setToBlock(nextBlockIdx);
-readCurrentBlock(true, nextBlockIdx != lastBlockIdx);
-// since that new block is within the bounds we've computed in
setToSlice(), we know there will
-// always be something matching the slice unless we're on the
lastBlockIdx (in which case there
-// may or may not be results, but if there isn't, we're done for
the slice).
-return iterator.hasNext();
+while (true)
+{
+// We have nothing more for our current block, move the next
one (so the one before on disk).
+int nextBlockIdx = indexState.currentBlockIdx() - 1;
+if (nextBlockIdx < 0 || nextBlockIdx < lastBlockIdx)
+return false;
+
+// The slice start can be in
+indexState.setToBlock(nextBlockIdx);
+readCurrentBlock(true, nextBlockIdx != lastBlockIdx);
+
+// for pre-3.0 storage formats, index blocks that only contain
a single row and that row crosses
+// index boundaries, the iterator will be empty even though we
haven't read everything we're intending
+// to read. In that
[jira] [Assigned] (CASSANDRA-12297) Privacy Violation - Heap Inspection
[
https://issues.apache.org/jira/browse/CASSANDRA-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ariel Weisberg reassigned CASSANDRA-12297:
--
Assignee: Ariel Weisberg
> Privacy Violation - Heap Inspection
> ---
>
> Key: CASSANDRA-12297
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12297
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Eduardo Aguinaga
>Assignee: Ariel Weisberg
>Priority: Major
>
> Overview:
> In May through June of 2016 a static analysis was performed on version 3.0.5
> of the Cassandra source code. The analysis included
> an automated analysis using HP Fortify v4.21 SCA and a manual analysis
> utilizing SciTools Understand v4. The results of that
> analysis includes the issue below.
> Issue:
> In the file PasswordAuthenticator.java on line 129, 164 and 222 a string
> object is used to store sensitive data. String objects are immutable and
> should not be used to store sensitive data. Sensitive data should be stored
> in char or byte arrays and the contents of those arrays should be cleared
> ASAP. Operations performed on string objects will require that the original
> object be copied and the operation be applied in the new copy of the string
> object. This results in the likelihood that multiple copies of sensitive data
> being present in the heap until garbage collection takes place.
> The snippet below shows the issue on line 129:
> PasswordAuthenticator.java, lines 123-134:
> {code:java}
> 123 public AuthenticatedUser legacyAuthenticate(Map
> credentials) throws AuthenticationException
> 124 {
> 125 String username = credentials.get(USERNAME_KEY);
> 126 if (username == null)
> 127 throw new AuthenticationException(String.format("Required key
> '%s' is missing", USERNAME_KEY));
> 128
> 129 String password = credentials.get(PASSWORD_KEY);
> 130 if (password == null)
> 131 throw new AuthenticationException(String.format("Required key
> '%s' is missing", PASSWORD_KEY));
> 132
> 133 return authenticate(username, password);
> 134 }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14805) Fails on running Cassandra server
[ https://issues.apache.org/jira/browse/CASSANDRA-14805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-14805: - Summary: Fails on running Cassandra server (was: Fails on running cassnadra server ) > Fails on running Cassandra server > -- > > Key: CASSANDRA-14805 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14805 > Project: Cassandra > Issue Type: Bug >Reporter: Ravi Gangwar >Priority: Critical > > Full Product Version : > Fails on java version. It's Java "1.8.0_181" > Os Version : Ubuntu 16.04 LTS > EXTRA RELEVANT SYSTEM CONFIGURATION : > Just installed Cassandra 2.2.11 > A DESCRIPTION OF THE PROBLEM : > # > # A fatal error has been detected by the Java Runtime Environment: > # > # SIGBUS (0x7) at pc=0x7f42fc492e70, pid=12128, tid=0x7f42fc3c9700 > # > # JRE version: Java(TM) SE Runtime Environment (8.0_181-b13) (build > 1.8.0_181-b13) > # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.181-b13 mixed mode > linux-amd64 compressed oops) > # Problematic frame: > # C [liblz4-java8098863625230398555.so+0x5e70] LZ4_decompress_fast+0xd0 > # > # Failed to write core dump. Core dumps have been disabled. To enable core > dumping, try "ulimit -c unlimited" before starting Java again > # > # If you would like to submit a bug report, please visit: > # http://bugreport.java.com/bugreport/crash.jsp > # The crash happened outside the Java Virtual Machine in native code. > # See problematic frame for where to report the bug. > # > --- T H R E A D --- > Current thread (0x006d0800): JavaThread "CompactionExecutor:7" daemon > [_thread_in_native, id=5278, stack(0x7f42fc389000,0x7f42fc3ca000)] > siginfo: si_signo: 7 (SIGBUS), si_code: 2 (BUS_ADRERR), si_addr: > 0x7f2026b8b000 > Registers: > RAX=0x7f432200750a, RBX=0x7f2026b8affc, RCX=0x7f4322005856, > RDX=0x7f432200750a > RSP=0x7f42fc3c7e50, RBP=0x7f2026b8940f, RSI=0x7f4322011d88, > RDI=0x0007 > R8 =0x7f4322011d84, R9 =0x7f4322011d90, R10=0x0003, > R11=0x > R12=0x, R13=0x7f1ffe33d40f, R14=0x7f4322011d87, > R15=0x7f4322011d8b > RIP=0x7f42fc492e70, EFLAGS=0x00010287, CSGSFS=0x002b0033, > ERR=0x0004 > TRAPNO=0x000e > Top of Stack: (sp=0x7f42fc3c7e50) > 0x7f42fc3c7e50: 4ce9 > 0x7f42fc3c7e60: 0004 0001 > 0x7f42fc3c7e70: 0002 0001 > 0x7f42fc3c7e80: 0004 0004 > 0x7f42fc3c7e90: 0004 0004 > 0x7f42fc3c7ea0: > 0x7f42fc3c7eb0: > 0x7f42fc3c7ec0: 0001 > 0x7f42fc3c7ed0: 0002 0003 > 0x7f42fc3c7ee0: 7f42fc3c7fa8 006d09f8 > 0x7f42fc3c7ef0: > 0x7f42fc3c7f00: 7f1ffe33d40f 7f4322001d90 > 0x7f42fc3c7f10: 2884c000 7f42fc48f59d > 0x7f42fc3c7f20: 000733b5fa78 > 0x7f42fc3c7f30: 7f42fc3c7fc0 > 0x7f42fc3c7f40: 2884bfff 7f42fc3c7fa8 > 0x7f42fc3c7f50: 006d0800 7f43119e8f1d > 0x7f42fc3c7f60: 7f42fc3c7f98 > 0x7f42fc3c7f70: 0001 > 0x7f42fc3c7f80: 00070764f4d8 > 0x7f42fc3c7f90: 00075b5937f0 > 0x7f42fc3c7fa0: 7f42fc3c7ff0 0006f91d2e38 > 0x7f42fc3c7fb0: 0006d7e3f210 7f42fc3c8040 > 0x7f42fc3c7fc0: 00070764f4d8 7f4311f9eca8 > 0x7f42fc3c7fd0: 51070001 00072dc9abb0 > 0x7f42fc3c7fe0: 28851103 0006dd2d > 0x7f42fc3c7ff0: 00022883f40b eb6b26fe2884bffc > 0x7f42fc3c8000: 00070764f4d8 00012884c000 > 0x7f42fc3c8010: 00075b5937f0 00075b5937f0 > 0x7f42fc3c8020: 00060008 0006d7f67598 > 0x7f42fc3c8030: 0006d7f67348 7f43120080d4 > 0x7f42fc3c8040: 0001 0006d7f676d8 > > > SYSTEM CONFIGURATION : > > # CPU - Intel Core i7 - 4771 CPU @ 3.50 GHz * 8 > 2. RAM - 16 GB > 3. STORAGE - 967.6 GB > 4. OS - Ubuntu 16.04 LTS > 5. Apache Cassandra - 2.2.11 > 6. CPP Driver - 2.2.1-1 > 7. libuv - 1.4.2-1 > 8. Java version - "1.8.0_181" > Java (TM) SE Runtime Environment (build 1.8.0_181-b13) > Java Hotspot (TM) 64-Bit Server VM (build 25.181-b13, mixed mode) > > Cassandra was working normally before generating this bug. Now when i am > trying to restart my server getting this bug. > Please help me asap. > > Regards, > Ravi > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CASSANDRA-14803) Rows that cross index block boundaries can cause incomplete reverse reads in some cases.
[ https://issues.apache.org/jira/browse/CASSANDRA-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638633#comment-16638633 ] Sam Tunnicliffe commented on CASSANDRA-14803: - Thanks, LGTM +1 assuming the 3.11 tests pass, which I'm sure they will. > Rows that cross index block boundaries can cause incomplete reverse reads in > some cases. > > > Key: CASSANDRA-14803 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14803 > Project: Cassandra > Issue Type: Bug >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Major > Fix For: 3.0.x, 3.11.x > > > When we're reading 2.1 sstables in reverse, we skip the first row of an index > block if it's split across index boundaries. The entire row will be read at > the end of the next block. In some cases though, the only thing in this index > block is the partial row, so we return an empty iterator. The empty iterator > is then interpreted as the end of the row further down the call stack, so we > return early without reading the rest of the data. This only affects 3.x > during upgrades from 2.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14803) Rows that cross index block boundaries can cause incomplete reverse reads in some cases.
[
https://issues.apache.org/jira/browse/CASSANDRA-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638574#comment-16638574
]
Blake Eggleston commented on CASSANDRA-14803:
-
pushed up an update that moves the test into {{LegacySSTableTest}} and fixes
compile problem
> Rows that cross index block boundaries can cause incomplete reverse reads in
> some cases.
>
>
> Key: CASSANDRA-14803
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14803
> Project: Cassandra
> Issue Type: Bug
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
>Priority: Major
> Fix For: 3.0.x, 3.11.x
>
>
> When we're reading 2.1 sstables in reverse, we skip the first row of an index
> block if it's split across index boundaries. The entire row will be read at
> the end of the next block. In some cases though, the only thing in this index
> block is the partial row, so we return an empty iterator. The empty iterator
> is then interpreted as the end of the row further down the call stack, so we
> return early without reading the rest of the data. This only affects 3.x
> during upgrades from 2.1
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14803) Rows that cross index block boundaries can cause incomplete reverse reads in some cases.
[
https://issues.apache.org/jira/browse/CASSANDRA-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638475#comment-16638475
]
Sam Tunnicliffe commented on CASSANDRA-14803:
-
The fix and test itself LGTM, but I don't quite see what's differentiates this
test from the others in {{LegacySSTableTest}}. What am I missing?
Also, it merges to 3.11 cleanly, but the test won't compile because
{{DatabaseDescriptor::setDaemonInitialized}} has been replaced there.
> Rows that cross index block boundaries can cause incomplete reverse reads in
> some cases.
>
>
> Key: CASSANDRA-14803
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14803
> Project: Cassandra
> Issue Type: Bug
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
>Priority: Major
> Fix For: 3.0.x, 3.11.x
>
>
> When we're reading 2.1 sstables in reverse, we skip the first row of an index
> block if it's split across index boundaries. The entire row will be read at
> the end of the next block. In some cases though, the only thing in this index
> block is the partial row, so we return an empty iterator. The empty iterator
> is then interpreted as the end of the row further down the call stack, so we
> return early without reading the rest of the data. This only affects 3.x
> during upgrades from 2.1
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14803) Rows that cross index block boundaries can cause incomplete reverse reads in some cases.
[ https://issues.apache.org/jira/browse/CASSANDRA-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638439#comment-16638439 ] Aleksey Yeschenko commented on CASSANDRA-14803: --- My apologies, was typing in what I thought was a different window, and JIRA apparently has keyboard shortcuts. > Rows that cross index block boundaries can cause incomplete reverse reads in > some cases. > > > Key: CASSANDRA-14803 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14803 > Project: Cassandra > Issue Type: Bug >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Major > Fix For: 3.0.x, 3.11.x > > > When we're reading 2.1 sstables in reverse, we skip the first row of an index > block if it's split across index boundaries. The entire row will be read at > the end of the next block. In some cases though, the only thing in this index > block is the partial row, so we return an empty iterator. The empty iterator > is then interpreted as the end of the row further down the call stack, so we > return early without reading the rest of the data. This only affects 3.x > during upgrades from 2.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-14803) Rows that cross index block boundaries can cause incomplete reverse reads in some cases.
[ https://issues.apache.org/jira/browse/CASSANDRA-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko reassigned CASSANDRA-14803: - Assignee: Blake Eggleston (was: Aleksey Yeschenko) > Rows that cross index block boundaries can cause incomplete reverse reads in > some cases. > > > Key: CASSANDRA-14803 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14803 > Project: Cassandra > Issue Type: Bug >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Major > Fix For: 3.0.x, 3.11.x > > > When we're reading 2.1 sstables in reverse, we skip the first row of an index > block if it's split across index boundaries. The entire row will be read at > the end of the next block. In some cases though, the only thing in this index > block is the partial row, so we return an empty iterator. The empty iterator > is then interpreted as the end of the row further down the call stack, so we > return early without reading the rest of the data. This only affects 3.x > during upgrades from 2.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-14803) Rows that cross index block boundaries can cause incomplete reverse reads in some cases.
[ https://issues.apache.org/jira/browse/CASSANDRA-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko reassigned CASSANDRA-14803: - Assignee: Aleksey Yeschenko (was: Blake Eggleston) > Rows that cross index block boundaries can cause incomplete reverse reads in > some cases. > > > Key: CASSANDRA-14803 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14803 > Project: Cassandra > Issue Type: Bug >Reporter: Blake Eggleston >Assignee: Aleksey Yeschenko >Priority: Major > Fix For: 3.0.x, 3.11.x > > > When we're reading 2.1 sstables in reverse, we skip the first row of an index > block if it's split across index boundaries. The entire row will be read at > the end of the next block. In some cases though, the only thing in this index > block is the partial row, so we return an empty iterator. The empty iterator > is then interpreted as the end of the row further down the call stack, so we > return early without reading the rest of the data. This only affects 3.x > during upgrades from 2.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14747) Evaluate 200 node, compression=none, encryption=none, coalescing=off
[ https://issues.apache.org/jira/browse/CASSANDRA-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638181#comment-16638181 ] Jason Brown edited comment on CASSANDRA-14747 at 10/4/18 12:45 PM: --- Excellent find, [~jolynch]. Looks like we added the ability to set the send/recv buffer size in CASSANDRA-3378 (which apparently I reviewed, 5.5 years ago). Looks like in 3.11 we [set the SO_SNDBUF|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/net/OutboundTcpConnection.java#L444] if the operator provided a value in the yaml, but we did not set a default value. However, it does appear I added a hard-coded default in 4.0 with CASSANDRA-8457. As it's been nearly two years since I wrote that part of the patch, I have no recollection of why I added a default. Removing it is trivial and has huge benefits, as [~jolynch] has proven. I'm working on combining the findings [~jolynch] and I have discovered over the last weeks and should have a patch ready in a few days (which will probably be part CASSANDRA-14503, as most of this work was based on that work-in-progress). was (Author: jasobrown): Excellent find, [~jolynch]. Looks like we added the ability to set the send/recv buffer size in CASSANDRA-3378 (which apparently I reviewed, 5.5 years ago). Looks like in 3.11 we [set the SO_SNDBUF|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/net/OutboundTcpConnection.java#L444] if the operator provided a value in the yaml, but we did not set a default value. However, it does appear I added a hard-coded default in 4.0 with CASSANDRA-8457. As it's been nearly two years since I wrote that part of the patch, I have no recollection of why I added a default. Removing it is trivial and has huge benefits, as has proven. I'm working on combining the findings [~jolynch] and I have discovered over the last weeks and should have a patch ready in a few days (which will probably be part CASSANDRA-14503, as most of this work was based on that work-in-progress). > Evaluate 200 node, compression=none, encryption=none, coalescing=off > - > > Key: CASSANDRA-14747 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14747 > Project: Cassandra > Issue Type: Sub-task >Reporter: Joseph Lynch >Assignee: Joseph Lynch >Priority: Major > Attachments: 3.0.17-QPS.png, 4.0.1-QPS.png, > 4.0.11-after-jolynch-tweaks.svg, 4.0.12-after-unconditional-flush.svg, > 4.0.15-after-sndbuf-fix.svg, 4.0.7-before-my-changes.svg, > 4.0_errors_showing_heap_pressure.txt, > 4.0_heap_histogram_showing_many_MessageOuts.txt, > i-0ed2acd2dfacab7c1-after-looping-fixes.svg, > trunk_vs_3.0.17_latency_under_load.png, > ttop_NettyOutbound-Thread_spinning.txt, > useast1c-i-0e1ddfe8b2f769060-mutation-flame.svg, > useast1e-i-08635fa1631601538_flamegraph_96node.svg, > useast1e-i-08635fa1631601538_ttop_netty_outbound_threads_96nodes, > useast1e-i-08635fa1631601538_uninlinedcpuflamegraph.0_96node_60sec_profile.svg > > > Tracks evaluating a 200 node cluster with all internode settings off (no > compression, no encryption, no coalescing). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14747) Evaluate 200 node, compression=none, encryption=none, coalescing=off
[ https://issues.apache.org/jira/browse/CASSANDRA-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638181#comment-16638181 ] Jason Brown commented on CASSANDRA-14747: - Excellent find, [~jolynch]. Looks like we added the ability to set the send/recv buffer size in CASSANDRA-3378 (which apparently I reviewed, 5.5 years ago). Looks like in 3.11 we [set the SO_SNDBUF|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/net/OutboundTcpConnection.java#L444] if the operator provided a value in the yaml, but we did not set a default value. However, it does appear I added a hard-coded default in 4.0 with CASSANDRA-8457. As it's been nearly two years since I wrote that part of the patch, I have no recollection of why I added a default. Removing it is trivial and has huge benefits, as has proven. I'm working on combining the findings [~jolynch] and I have discovered over the last weeks and should have a patch ready in a few days (which will probably be part CASSANDRA-14503, as most of this work was based on that work-in-progress). > Evaluate 200 node, compression=none, encryption=none, coalescing=off > - > > Key: CASSANDRA-14747 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14747 > Project: Cassandra > Issue Type: Sub-task >Reporter: Joseph Lynch >Assignee: Joseph Lynch >Priority: Major > Attachments: 3.0.17-QPS.png, 4.0.1-QPS.png, > 4.0.11-after-jolynch-tweaks.svg, 4.0.12-after-unconditional-flush.svg, > 4.0.15-after-sndbuf-fix.svg, 4.0.7-before-my-changes.svg, > 4.0_errors_showing_heap_pressure.txt, > 4.0_heap_histogram_showing_many_MessageOuts.txt, > i-0ed2acd2dfacab7c1-after-looping-fixes.svg, > trunk_vs_3.0.17_latency_under_load.png, > ttop_NettyOutbound-Thread_spinning.txt, > useast1c-i-0e1ddfe8b2f769060-mutation-flame.svg, > useast1e-i-08635fa1631601538_flamegraph_96node.svg, > useast1e-i-08635fa1631601538_ttop_netty_outbound_threads_96nodes, > useast1e-i-08635fa1631601538_uninlinedcpuflamegraph.0_96node_60sec_profile.svg > > > Tracks evaluating a 200 node cluster with all internode settings off (no > compression, no encryption, no coalescing). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14713) Update docker image used for testing
[
https://issues.apache.org/jira/browse/CASSANDRA-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638103#comment-16638103
]
Marcus Eriksson commented on CASSANDRA-14713:
-
for the docker image: https://github.com/apache/cassandra-builds/pull/7 - added
a few comments, feel free to fix on commit
> Update docker image used for testing
>
>
> Key: CASSANDRA-14713
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14713
> Project: Cassandra
> Issue Type: New Feature
> Components: Testing
>Reporter: Stefan Podkowinski
>Assignee: Stefan Podkowinski
>Priority: Major
> Attachments: Dockerfile
>
>
> Tests executed on builds.apache.org ({{docker/jenkins/jenkinscommand.sh}})
> and circleCI ({{.circleci/config.yml}}) will currently use the same
> [cassandra-test|https://hub.docker.com/r/kjellman/cassandra-test/] docker
> image ([github|https://github.com/mkjellman/cassandra-test-docker]) by
> [~mkjellman].
> We should manage this image on our own as part of cassandra-builds, to keep
> it updated. There's also a [Apache
> user|https://hub.docker.com/u/apache/?page=1] on docker hub for publishing
> images.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-14805) Fails on running cassnadra server
Ravi Gangwar created CASSANDRA-14805: Summary: Fails on running cassnadra server Key: CASSANDRA-14805 URL: https://issues.apache.org/jira/browse/CASSANDRA-14805 Project: Cassandra Issue Type: Bug Reporter: Ravi Gangwar Full Product Version : Fails on java version. It's Java "1.8.0_181" Os Version : Ubuntu 16.04 LTS EXTRA RELEVANT SYSTEM CONFIGURATION : Just installed Cassandra 2.2.11 A DESCRIPTION OF THE PROBLEM : # # A fatal error has been detected by the Java Runtime Environment: # # SIGBUS (0x7) at pc=0x7f42fc492e70, pid=12128, tid=0x7f42fc3c9700 # # JRE version: Java(TM) SE Runtime Environment (8.0_181-b13) (build 1.8.0_181-b13) # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.181-b13 mixed mode linux-amd64 compressed oops) # Problematic frame: # C [liblz4-java8098863625230398555.so+0x5e70] LZ4_decompress_fast+0xd0 # # Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again # # If you would like to submit a bug report, please visit: # http://bugreport.java.com/bugreport/crash.jsp # The crash happened outside the Java Virtual Machine in native code. # See problematic frame for where to report the bug. # --- T H R E A D --- Current thread (0x006d0800): JavaThread "CompactionExecutor:7" daemon [_thread_in_native, id=5278, stack(0x7f42fc389000,0x7f42fc3ca000)] siginfo: si_signo: 7 (SIGBUS), si_code: 2 (BUS_ADRERR), si_addr: 0x7f2026b8b000 Registers: RAX=0x7f432200750a, RBX=0x7f2026b8affc, RCX=0x7f4322005856, RDX=0x7f432200750a RSP=0x7f42fc3c7e50, RBP=0x7f2026b8940f, RSI=0x7f4322011d88, RDI=0x0007 R8 =0x7f4322011d84, R9 =0x7f4322011d90, R10=0x0003, R11=0x R12=0x, R13=0x7f1ffe33d40f, R14=0x7f4322011d87, R15=0x7f4322011d8b RIP=0x7f42fc492e70, EFLAGS=0x00010287, CSGSFS=0x002b0033, ERR=0x0004 TRAPNO=0x000e Top of Stack: (sp=0x7f42fc3c7e50) 0x7f42fc3c7e50: 4ce9 0x7f42fc3c7e60: 0004 0001 0x7f42fc3c7e70: 0002 0001 0x7f42fc3c7e80: 0004 0004 0x7f42fc3c7e90: 0004 0004 0x7f42fc3c7ea0: 0x7f42fc3c7eb0: 0x7f42fc3c7ec0: 0001 0x7f42fc3c7ed0: 0002 0003 0x7f42fc3c7ee0: 7f42fc3c7fa8 006d09f8 0x7f42fc3c7ef0: 0x7f42fc3c7f00: 7f1ffe33d40f 7f4322001d90 0x7f42fc3c7f10: 2884c000 7f42fc48f59d 0x7f42fc3c7f20: 000733b5fa78 0x7f42fc3c7f30: 7f42fc3c7fc0 0x7f42fc3c7f40: 2884bfff 7f42fc3c7fa8 0x7f42fc3c7f50: 006d0800 7f43119e8f1d 0x7f42fc3c7f60: 7f42fc3c7f98 0x7f42fc3c7f70: 0001 0x7f42fc3c7f80: 00070764f4d8 0x7f42fc3c7f90: 00075b5937f0 0x7f42fc3c7fa0: 7f42fc3c7ff0 0006f91d2e38 0x7f42fc3c7fb0: 0006d7e3f210 7f42fc3c8040 0x7f42fc3c7fc0: 00070764f4d8 7f4311f9eca8 0x7f42fc3c7fd0: 51070001 00072dc9abb0 0x7f42fc3c7fe0: 28851103 0006dd2d 0x7f42fc3c7ff0: 00022883f40b eb6b26fe2884bffc 0x7f42fc3c8000: 00070764f4d8 00012884c000 0x7f42fc3c8010: 00075b5937f0 00075b5937f0 0x7f42fc3c8020: 00060008 0006d7f67598 0x7f42fc3c8030: 0006d7f67348 7f43120080d4 0x7f42fc3c8040: 0001 0006d7f676d8 SYSTEM CONFIGURATION : # CPU - Intel Core i7 - 4771 CPU @ 3.50 GHz * 8 2. RAM - 16 GB 3. STORAGE - 967.6 GB 4. OS - Ubuntu 16.04 LTS 5. Apache Cassandra - 2.2.11 6. CPP Driver - 2.2.1-1 7. libuv - 1.4.2-1 8. Java version - "1.8.0_181" Java (TM) SE Runtime Environment (build 1.8.0_181-b13) Java Hotspot (TM) 64-Bit Server VM (build 25.181-b13, mixed mode) Cassandra was working normally before generating this bug. Now when i am trying to restart my server getting this bug. Please help me asap. Regards, Ravi -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14717) Write tests for RepairJob
[
https://issues.apache.org/jira/browse/CASSANDRA-14717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638042#comment-16638042
]
Marcus Eriksson commented on CASSANDRA-14717:
-
very nice stuff, added a few comments on the pull request
> Write tests for RepairJob
> --
>
> Key: CASSANDRA-14717
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14717
> Project: Cassandra
> Issue Type: Test
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Major
>
> As a part of [CASSANDRA-14693], it was suggested to write additional unit
> tests for RepairJob.
> Specifically, the unit-test candidates are {{standardSyncing}} and
> {{optimisedSynching}}. The rest of the class is slightly less important to
> test as it's mostly gathering ranges and collecting trees.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14800) Avoid referencing DatabaseDescriptor in ProtocolVersion
[
https://issues.apache.org/jira/browse/CASSANDRA-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcus Eriksson updated CASSANDRA-14800:
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
committed as {{bd0cef9a369ae9245b45040796a6e10f51e522ce}}, thanks!
> Avoid referencing DatabaseDescriptor in ProtocolVersion
> ---
>
> Key: CASSANDRA-14800
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14800
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Minor
> Fix For: 4.0
>
>
> We should not reference {{DatabaseDescriptor}} in {{ProtocolVersion}} as it
> is used outside of Cassandra (for example when handling full query logs)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
cassandra git commit: Avoid using DatabaseDescriptor in ProtocolVersion
Repository: cassandra
Updated Branches:
refs/heads/trunk 47a10649d -> bd0cef9a3
Avoid using DatabaseDescriptor in ProtocolVersion
Patch by marcuse; reviewed by Sam Tunnicliffe for CASSANDRA-14800
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/bd0cef9a
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/bd0cef9a
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/bd0cef9a
Branch: refs/heads/trunk
Commit: bd0cef9a369ae9245b45040796a6e10f51e522ce
Parents: 47a1064
Author: Marcus Eriksson
Authored: Wed Oct 3 10:12:54 2018 +0200
Committer: Marcus Eriksson
Committed: Thu Oct 4 08:23:49 2018 +0200
--
src/java/org/apache/cassandra/transport/Client.java | 2 +-
src/java/org/apache/cassandra/transport/Frame.java| 2 +-
.../org/apache/cassandra/transport/ProtocolVersion.java | 6 ++
.../org/apache/cassandra/audit/FullQueryLoggerTest.java | 4 ++--
.../apache/cassandra/transport/ProtocolVersionTest.java | 10 +-
.../src/org/apache/cassandra/fqltool/FQLQueryReader.java | 2 +-
.../src/org/apache/cassandra/fqltool/commands/Dump.java | 2 +-
7 files changed, 13 insertions(+), 15 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/cassandra/blob/bd0cef9a/src/java/org/apache/cassandra/transport/Client.java
--
diff --git a/src/java/org/apache/cassandra/transport/Client.java
b/src/java/org/apache/cassandra/transport/Client.java
index f7ed272..eacd5a9 100644
--- a/src/java/org/apache/cassandra/transport/Client.java
+++ b/src/java/org/apache/cassandra/transport/Client.java
@@ -292,7 +292,7 @@ public class Client extends SimpleClient
// Parse options.
String host = args[0];
int port = Integer.parseInt(args[1]);
-ProtocolVersion version = args.length == 3 ?
ProtocolVersion.decode(Integer.parseInt(args[2])) : ProtocolVersion.CURRENT;
+ProtocolVersion version = args.length == 3 ?
ProtocolVersion.decode(Integer.parseInt(args[2]),
DatabaseDescriptor.getNativeTransportAllowOlderProtocols()) :
ProtocolVersion.CURRENT;
EncryptionOptions encryptionOptions = new EncryptionOptions();
System.out.println("CQL binary protocol console " + host + "@" + port
+ " using native protocol version " + version);
http://git-wip-us.apache.org/repos/asf/cassandra/blob/bd0cef9a/src/java/org/apache/cassandra/transport/Frame.java
--
diff --git a/src/java/org/apache/cassandra/transport/Frame.java
b/src/java/org/apache/cassandra/transport/Frame.java
index d6a1cbc..d3c810b 100644
--- a/src/java/org/apache/cassandra/transport/Frame.java
+++ b/src/java/org/apache/cassandra/transport/Frame.java
@@ -174,7 +174,7 @@ public class Frame
int firstByte = buffer.getByte(idx++);
Message.Direction direction =
Message.Direction.extractFromVersion(firstByte);
int versionNum = firstByte & PROTOCOL_VERSION_MASK;
-ProtocolVersion version = ProtocolVersion.decode(versionNum);
+ProtocolVersion version = ProtocolVersion.decode(versionNum,
DatabaseDescriptor.getNativeTransportAllowOlderProtocols());
// Wait until we have the complete header
if (readableBytes < Header.LENGTH)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/bd0cef9a/src/java/org/apache/cassandra/transport/ProtocolVersion.java
--
diff --git a/src/java/org/apache/cassandra/transport/ProtocolVersion.java
b/src/java/org/apache/cassandra/transport/ProtocolVersion.java
index e1f634c..546983f 100644
--- a/src/java/org/apache/cassandra/transport/ProtocolVersion.java
+++ b/src/java/org/apache/cassandra/transport/ProtocolVersion.java
@@ -26,8 +26,6 @@ import java.util.Optional;
import org.apache.commons.lang3.ArrayUtils;
-import org.apache.cassandra.config.DatabaseDescriptor;
-
/**
* The native (CQL binary) protocol version.
*
@@ -95,7 +93,7 @@ public enum ProtocolVersion implements
Comparable
return versions;
}
-public static ProtocolVersion decode(int versionNum)
+public static ProtocolVersion decode(int versionNum, boolean
allowOlderProtocols)
{
ProtocolVersion ret = versionNum >= MIN_SUPPORTED_VERSION.num &&
versionNum <= MAX_SUPPORTED_VERSION.num
? SUPPORTED_VERSIONS[versionNum -
MIN_SUPPORTED_VERSION.num]
@@ -116,7 +114,7 @@ public enum ProtocolVersion implements
Comparable
throw new ProtocolException(invalidVersionMessage(versionNum),
MAX_SUPPORTED_VERSION);
}
-if (!DatabaseDescriptor.getNativeTransportAllowOlderProtocols() &&
[jira] [Comment Edited] (CASSANDRA-14747) Evaluate 200 node, compression=none, encryption=none, coalescing=off
[ https://issues.apache.org/jira/browse/CASSANDRA-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637835#comment-16637835 ] Dinesh Joshi edited comment on CASSANDRA-14747 at 10/4/18 6:13 AM: --- [~jolynch] this is pretty cool! I think it would make sense to set all tunable knobs to default and see the impact. Then we can start tuning the parameters to arrive at sensible defaults. We should also document the findings. was (Author: djoshi3): [~jolynch] this is pretty cool! I think it would make sense to set all tunable knobs to default and see the impact. > Evaluate 200 node, compression=none, encryption=none, coalescing=off > - > > Key: CASSANDRA-14747 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14747 > Project: Cassandra > Issue Type: Sub-task >Reporter: Joseph Lynch >Assignee: Joseph Lynch >Priority: Major > Attachments: 3.0.17-QPS.png, 4.0.1-QPS.png, > 4.0.11-after-jolynch-tweaks.svg, 4.0.12-after-unconditional-flush.svg, > 4.0.15-after-sndbuf-fix.svg, 4.0.7-before-my-changes.svg, > 4.0_errors_showing_heap_pressure.txt, > 4.0_heap_histogram_showing_many_MessageOuts.txt, > i-0ed2acd2dfacab7c1-after-looping-fixes.svg, > trunk_vs_3.0.17_latency_under_load.png, > ttop_NettyOutbound-Thread_spinning.txt, > useast1c-i-0e1ddfe8b2f769060-mutation-flame.svg, > useast1e-i-08635fa1631601538_flamegraph_96node.svg, > useast1e-i-08635fa1631601538_ttop_netty_outbound_threads_96nodes, > useast1e-i-08635fa1631601538_uninlinedcpuflamegraph.0_96node_60sec_profile.svg > > > Tracks evaluating a 200 node cluster with all internode settings off (no > compression, no encryption, no coalescing). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14747) Evaluate 200 node, compression=none, encryption=none, coalescing=off
[ https://issues.apache.org/jira/browse/CASSANDRA-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637835#comment-16637835 ] Dinesh Joshi edited comment on CASSANDRA-14747 at 10/4/18 6:05 AM: --- [~jolynch] this is pretty cool! I think it would make sense to set all tunable knobs to default and see the impact. was (Author: djoshi3): [~jolynch] this is pretty cool! > Evaluate 200 node, compression=none, encryption=none, coalescing=off > - > > Key: CASSANDRA-14747 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14747 > Project: Cassandra > Issue Type: Sub-task >Reporter: Joseph Lynch >Assignee: Joseph Lynch >Priority: Major > Attachments: 3.0.17-QPS.png, 4.0.1-QPS.png, > 4.0.11-after-jolynch-tweaks.svg, 4.0.12-after-unconditional-flush.svg, > 4.0.15-after-sndbuf-fix.svg, 4.0.7-before-my-changes.svg, > 4.0_errors_showing_heap_pressure.txt, > 4.0_heap_histogram_showing_many_MessageOuts.txt, > i-0ed2acd2dfacab7c1-after-looping-fixes.svg, > trunk_vs_3.0.17_latency_under_load.png, > ttop_NettyOutbound-Thread_spinning.txt, > useast1c-i-0e1ddfe8b2f769060-mutation-flame.svg, > useast1e-i-08635fa1631601538_flamegraph_96node.svg, > useast1e-i-08635fa1631601538_ttop_netty_outbound_threads_96nodes, > useast1e-i-08635fa1631601538_uninlinedcpuflamegraph.0_96node_60sec_profile.svg > > > Tracks evaluating a 200 node cluster with all internode settings off (no > compression, no encryption, no coalescing). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14747) Evaluate 200 node, compression=none, encryption=none, coalescing=off
[ https://issues.apache.org/jira/browse/CASSANDRA-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637835#comment-16637835 ] Dinesh Joshi commented on CASSANDRA-14747: -- [~jolynch] this is pretty cool! > Evaluate 200 node, compression=none, encryption=none, coalescing=off > - > > Key: CASSANDRA-14747 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14747 > Project: Cassandra > Issue Type: Sub-task >Reporter: Joseph Lynch >Assignee: Joseph Lynch >Priority: Major > Attachments: 3.0.17-QPS.png, 4.0.1-QPS.png, > 4.0.11-after-jolynch-tweaks.svg, 4.0.12-after-unconditional-flush.svg, > 4.0.15-after-sndbuf-fix.svg, 4.0.7-before-my-changes.svg, > 4.0_errors_showing_heap_pressure.txt, > 4.0_heap_histogram_showing_many_MessageOuts.txt, > i-0ed2acd2dfacab7c1-after-looping-fixes.svg, > trunk_vs_3.0.17_latency_under_load.png, > ttop_NettyOutbound-Thread_spinning.txt, > useast1c-i-0e1ddfe8b2f769060-mutation-flame.svg, > useast1e-i-08635fa1631601538_flamegraph_96node.svg, > useast1e-i-08635fa1631601538_ttop_netty_outbound_threads_96nodes, > useast1e-i-08635fa1631601538_uninlinedcpuflamegraph.0_96node_60sec_profile.svg > > > Tracks evaluating a 200 node cluster with all internode settings off (no > compression, no encryption, no coalescing). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
