[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

2015-07-28 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644421#comment-14644421 ] Benedict commented on CASSANDRA-7066: - [~stefania]: jake has correctly pointed out

[jira] [Updated] (CASSANDRA-8894) Our default buffer size for (uncompressed) buffered reads should be smaller, and based on the expected record size

2015-07-28 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-8894: Fix Version/s: (was: 3.x) 3.0 alpha 1 > Our default buffer size for (unco

[jira] [Commented] (CASSANDRA-8894) Our default buffer size for (uncompressed) buffered reads should be smaller, and based on the expected record size

2015-07-28 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1466#comment-1466 ] Benedict commented on CASSANDRA-8894: - Thanks. Committed. I'll hold off closing t

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-07-28 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644500#comment-14644500 ] Benedict commented on CASSANDRA-9908: - Hmm. So our secondary index files don't use

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-07-28 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644539#comment-14644539 ] Benedict commented on CASSANDRA-9908: - Doesn't that sort of obviate much of the su

[jira] [Commented] (CASSANDRA-9382) Snapshot file descriptors not getting purged (possible fd leak)

2015-07-28 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644592#comment-14644592 ] Benedict commented on CASSANDRA-9382: - +1. This bug shouldn't affect 2.1+, howeve

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

2015-07-28 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644607#comment-14644607 ] Benedict commented on CASSANDRA-7066: - If you lose one of these files you are SOL,

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

2015-07-28 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644623#comment-14644623 ] Benedict commented on CASSANDRA-7066: - bq. Is that SOL as in "Now we can't tell wh

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

2015-07-28 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644635#comment-14644635 ] Benedict commented on CASSANDRA-7066: - Well, if your file system is losing files y

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

2015-07-28 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644685#comment-14644685 ] Benedict commented on CASSANDRA-7066: - Well, a bug in the implementation could scr

[jira] [Comment Edited] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

2015-07-28 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644685#comment-14644685 ] Benedict edited comment on CASSANDRA-7066 at 7/28/15 5:23 PM: --

[jira] [Comment Edited] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

2015-07-28 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644685#comment-14644685 ] Benedict edited comment on CASSANDRA-7066 at 7/28/15 5:34 PM: --

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

2015-07-28 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644718#comment-14644718 ] Benedict commented on CASSANDRA-7066: - bq. The value of the 'old way' was the nami

[jira] [Reopened] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

2015-07-28 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict reopened CASSANDRA-7066: - [~stefania]: I'm not sure if we entirely settled on a modification, but it sounds like we should

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

2015-07-29 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645754#comment-14645754 ] Benedict commented on CASSANDRA-7066: - Thanks Stef. A couple of comments about th

[jira] [Commented] (CASSANDRA-9738) Migrate key-cache to be fully off-heap

2015-07-29 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645807#comment-14645807 ] Benedict commented on CASSANDRA-9738: - Looks like improved occupancy is also a fac

[jira] [Commented] (CASSANDRA-9669) If sstable flushes complete out of order, on restart we can fail to replay necessary commit log records

2015-07-29 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645845#comment-14645845 ] Benedict commented on CASSANDRA-9669: - So, I have a patch available for this [her

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-07-29 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645925#comment-14645925 ] Benedict commented on CASSANDRA-9908: - Probably we should at least introduce a {{T

[jira] [Comment Edited] (CASSANDRA-9738) Migrate key-cache to be fully off-heap

2015-07-29 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645807#comment-14645807 ] Benedict edited comment on CASSANDRA-9738 at 7/29/15 2:25 PM: --

[jira] [Commented] (CASSANDRA-9738) Migrate key-cache to be fully off-heap

2015-07-29 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646112#comment-14646112 ] Benedict commented on CASSANDRA-9738: - Yes. Thanks > Migrate key-cache to be full

[jira] [Commented] (CASSANDRA-8931) IndexSummary (and Index) should store the token, and the minimal key to unambiguously direct a query

2015-07-29 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646156#comment-14646156 ] Benedict commented on CASSANDRA-8931: - Right > IndexSummary (and Index) should st

[jira] [Created] (CASSANDRA-9918) Introduce extra Ref usage when debugrefcount=true

2015-07-29 Thread Benedict (JIRA)
Benedict created CASSANDRA-9918: --- Summary: Introduce extra Ref usage when debugrefcount=true Key: CASSANDRA-9918 URL: https://issues.apache.org/jira/browse/CASSANDRA-9918 Project: Cassandra Iss

[jira] [Created] (CASSANDRA-9919) Cleanup closeable iterator usage

2015-07-29 Thread Benedict (JIRA)
Benedict created CASSANDRA-9919: --- Summary: Cleanup closeable iterator usage Key: CASSANDRA-9919 URL: https://issues.apache.org/jira/browse/CASSANDRA-9919 Project: Cassandra Issue Type: Improvem

[jira] [Commented] (CASSANDRA-9865) Broken vint encoding, at least when interacting with OHCProvider

2015-07-29 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646328#comment-14646328 ] Benedict commented on CASSANDRA-9865: - +1 > Broken vint encoding, at least when i

[jira] [Created] (CASSANDRA-9925) Sorted + Unique BTree.Builder usage can use a thread-local TreeBuilder directly

2015-07-29 Thread Benedict (JIRA)
Benedict created CASSANDRA-9925: --- Summary: Sorted + Unique BTree.Builder usage can use a thread-local TreeBuilder directly Key: CASSANDRA-9925 URL: https://issues.apache.org/jira/browse/CASSANDRA-9925 P

[jira] [Updated] (CASSANDRA-9896) Add ability to disable commitlog recycling

2015-07-29 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-9896: Fix Version/s: (was: 2.1.x) 2.1.9 > Add ability to disable commitlog recy

[jira] [Updated] (CASSANDRA-9525) Commitlog allocation failure doesn't stop the entire node.

2015-07-29 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-9525: Fix Version/s: (was: 2.1.x) > Commitlog allocation failure doesn't stop the entire node. > -

[jira] [Commented] (CASSANDRA-9471) Columns should be backed by a BTree, not an array

2015-07-29 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646593#comment-14646593 ] Benedict commented on CASSANDRA-9471: - Patch available [here|https://github.com/be

[jira] [Updated] (CASSANDRA-9586) ant eclipse-warnings fails in trunk

2015-07-29 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-9586: Fix Version/s: (was: 3.x) 3.0 alpha 1 > ant eclipse-warnings fails in tru

[jira] [Updated] (CASSANDRA-9307) test-long contains tests that are not appropriate for running on every commit

2015-07-29 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-9307: Fix Version/s: (was: 3.x) 3.0 alpha 1 > test-long contains tests that are

[jira] [Created] (CASSANDRA-9926) Avoid AbstractRow.isEmpty() where possible

2015-07-29 Thread Benedict (JIRA)
Benedict created CASSANDRA-9926: --- Summary: Avoid AbstractRow.isEmpty() where possible Key: CASSANDRA-9926 URL: https://issues.apache.org/jira/browse/CASSANDRA-9926 Project: Cassandra Issue Type

[jira] [Comment Edited] (CASSANDRA-9894) Serialize the header only once per message

2015-07-29 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646840#comment-14646840 ] Benedict edited comment on CASSANDRA-9894 at 7/29/15 10:27 PM: -

[jira] [Created] (CASSANDRA-9932) Make all partitions btree backed

2015-07-29 Thread Benedict (JIRA)
Benedict created CASSANDRA-9932: --- Summary: Make all partitions btree backed Key: CASSANDRA-9932 URL: https://issues.apache.org/jira/browse/CASSANDRA-9932 Project: Cassandra Issue Type: Improvem

[jira] [Commented] (CASSANDRA-9932) Make all partitions btree backed

2015-07-29 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646885#comment-14646885 ] Benedict commented on CASSANDRA-9932: - An in progress patch is available [here|ht

[jira] [Resolved] (CASSANDRA-9888) BTreeBackedRow and ComplexColumnData

2015-07-30 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict resolved CASSANDRA-9888. - Resolution: Fixed Thanks. I've ninja fixed. (Although I'm having weird problems running this

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-07-30 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647351#comment-14647351 ] Benedict commented on CASSANDRA-9908: - Take a look in {{Keyspace.dropCf}} for anot

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

2015-07-30 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647469#comment-14647469 ] Benedict commented on CASSANDRA-7066: - bq. not sure what a panic error is exactly?

[jira] [Commented] (CASSANDRA-9894) Serialize the header only once per message

2015-07-30 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648324#comment-14648324 ] Benedict commented on CASSANDRA-9894: - bq. Looks good to me conditional on a unit

[jira] [Commented] (CASSANDRA-9471) Columns should be backed by a BTree, not an array

2015-07-30 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648337#comment-14648337 ] Benedict commented on CASSANDRA-9471: - [~aweisberg] said: {quote} It would be nice

[jira] [Commented] (CASSANDRA-9894) Serialize the header only once per message

2015-07-30 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648349#comment-14648349 ] Benedict commented on CASSANDRA-9894: - bq. I thought the reason you did it was to

[jira] [Comment Edited] (CASSANDRA-9471) Columns should be backed by a BTree, not an array

2015-07-30 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648337#comment-14648337 ] Benedict edited comment on CASSANDRA-9471 at 7/30/15 9:39 PM: --

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

2015-07-30 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648509#comment-14648509 ] Benedict commented on CASSANDRA-7066: - [~rcoli]: while this patch does not remove

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

2015-07-31 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649193#comment-14649193 ] Benedict commented on CASSANDRA-7066: - Thanks. Looks like great work as always.

[jira] [Commented] (CASSANDRA-9908) Potential race caused by async cleanup of transaction log files

2015-08-03 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651564#comment-14651564 ] Benedict commented on CASSANDRA-9908: - Yep, that all looks good. bq. Isn't this

[jira] [Commented] (CASSANDRA-7066) Simplify (and unify) cleanup of compaction leftovers

2015-08-03 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651571#comment-14651571 ] Benedict commented on CASSANDRA-7066: - bq. Will this cause problems if the alpha g

[jira] [Commented] (CASSANDRA-9471) Columns should be backed by a BTree, not an array

2015-08-03 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651724#comment-14651724 ] Benedict commented on CASSANDRA-9471: - I've rebased this and introduced unit tests

[jira] [Commented] (CASSANDRA-9894) Serialize the header only once per message

2015-08-03 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651953#comment-14651953 ] Benedict commented on CASSANDRA-9894: - I've rebased against CASSANDRA-9471, to whi

[jira] [Created] (CASSANDRA-9962) WaitQueueTest is flakey

2015-08-03 Thread Benedict (JIRA)
Benedict created CASSANDRA-9962: --- Summary: WaitQueueTest is flakey Key: CASSANDRA-9962 URL: https://issues.apache.org/jira/browse/CASSANDRA-9962 Project: Cassandra Issue Type: Bug Com

[jira] [Commented] (CASSANDRA-9962) WaitQueueTest is flakey

2015-08-03 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653118#comment-14653118 ] Benedict commented on CASSANDRA-9962: - Patch available [here|https://github.com/be

[jira] [Created] (CASSANDRA-9974) Improve debuggability of 3.0

2015-08-03 Thread Benedict (JIRA)
Benedict created CASSANDRA-9974: --- Summary: Improve debuggability of 3.0 Key: CASSANDRA-9974 URL: https://issues.apache.org/jira/browse/CASSANDRA-9974 Project: Cassandra Issue Type: Improvement

[jira] [Created] (CASSANDRA-9975) Flatten RowIterator call hierarchy with a shared RowTransformer

2015-08-03 Thread Benedict (JIRA)
Benedict created CASSANDRA-9975: --- Summary: Flatten RowIterator call hierarchy with a shared RowTransformer Key: CASSANDRA-9975 URL: https://issues.apache.org/jira/browse/CASSANDRA-9975 Project: Cassandr

[jira] [Created] (CASSANDRA-9976) Flatten PartitionIterator call hierarchy with PartitionTransformer

2015-08-03 Thread Benedict (JIRA)
Benedict created CASSANDRA-9976: --- Summary: Flatten PartitionIterator call hierarchy with PartitionTransformer Key: CASSANDRA-9976 URL: https://issues.apache.org/jira/browse/CASSANDRA-9976 Project: Cassa

[jira] [Commented] (CASSANDRA-9932) Make all partitions btree backed

2015-08-04 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653186#comment-14653186 ] Benedict commented on CASSANDRA-9932: - Patch available [here|https://github.com/be

[jira] [Updated] (CASSANDRA-9974) Improve debuggability

2015-08-04 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-9974: Summary: Improve debuggability (was: Improve debuggability of 3.0) > Improve debuggability > --

[jira] [Updated] (CASSANDRA-9926) Remove AbstractRow.isEmpty

2015-08-04 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-9926: Summary: Remove AbstractRow.isEmpty (was: Avoid AbstractRow.isEmpty() where possible) > Remove

[jira] [Commented] (CASSANDRA-9926) Remove AbstractRow.isEmpty

2015-08-04 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653194#comment-14653194 ] Benedict commented on CASSANDRA-9926: - Since we only have one implementation of {{

[jira] [Updated] (CASSANDRA-9926) Remove AbstractRow.isEmpty

2015-08-04 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-9926: Priority: Trivial (was: Minor) > Remove AbstractRow.isEmpty > -- > >

[jira] [Commented] (CASSANDRA-8630) Faster sequential IO (on compaction, streaming, etc)

2015-08-04 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653263#comment-14653263 ] Benedict commented on CASSANDRA-8630: - Yes, spot on (at a high level - specifics m

[jira] [Commented] (CASSANDRA-8630) Faster sequential IO (on compaction, streaming, etc)

2015-08-04 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653676#comment-14653676 ] Benedict commented on CASSANDRA-8630: - We already have a branch in every case? Thi

[jira] [Commented] (CASSANDRA-8630) Faster sequential IO (on compaction, streaming, etc)

2015-08-04 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653678#comment-14653678 ] Benedict commented on CASSANDRA-8630: - We already have a branch in every case? Thi

[jira] [Commented] (CASSANDRA-8630) Faster sequential IO (on compaction, streaming, etc)

2015-08-04 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653738#comment-14653738 ] Benedict commented on CASSANDRA-8630: - My expectation was that we would extract th

[jira] [Commented] (CASSANDRA-9962) WaitQueueTest is flakey

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654957#comment-14654957 ] Benedict commented on CASSANDRA-9962: - bq. A semaphore would be an easier way to

[jira] [Commented] (CASSANDRA-8630) Faster sequential IO (on compaction, streaming, etc)

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654962#comment-14654962 ] Benedict commented on CASSANDRA-8630: - I think we can do something much simpler, w

[jira] [Created] (CASSANDRA-9985) Introduce our own AbstractIterator

2015-08-05 Thread Benedict (JIRA)
Benedict created CASSANDRA-9985: --- Summary: Introduce our own AbstractIterator Key: CASSANDRA-9985 URL: https://issues.apache.org/jira/browse/CASSANDRA-9985 Project: Cassandra Issue Type: Sub-ta

[jira] [Commented] (CASSANDRA-9533) Make batch commitlog mode easier to tune

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654985#comment-14654985 ] Benedict commented on CASSANDRA-9533: - Really trivial patch [here|https://github.

[jira] [Updated] (CASSANDRA-9926) Remove AbstractRow.isEmpty

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-9926: Fix Version/s: (was: 3.0 beta 1) 3.0.0 rc1 > Remove AbstractRow.isEmpty >

[jira] [Created] (CASSANDRA-9986) Remove SliceableUnfilteredRowIterator

2015-08-05 Thread Benedict (JIRA)
Benedict created CASSANDRA-9986: --- Summary: Remove SliceableUnfilteredRowIterator Key: CASSANDRA-9986 URL: https://issues.apache.org/jira/browse/CASSANDRA-9986 Project: Cassandra Issue Type: Sub

[jira] [Assigned] (CASSANDRA-9974) Improve debuggability

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict reassigned CASSANDRA-9974: --- Assignee: Benedict > Improve debuggability > - > > Ke

[jira] [Commented] (CASSANDRA-9974) Improve debuggability

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655000#comment-14655000 ] Benedict commented on CASSANDRA-9974: - Assigning to myself so that this encapsulat

[jira] [Updated] (CASSANDRA-9978) Split/Scrub tools no longer remove original sstable

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-9978: Reviewer: Benedict > Split/Scrub tools no longer remove original sstable > -

[jira] [Commented] (CASSANDRA-9978) Split/Scrub tools no longer remove original sstable

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655003#comment-14655003 ] Benedict commented on CASSANDRA-9978: - Yep, no problem. Also: SGTM. > Split/Scr

[jira] [Commented] (CASSANDRA-9986) Remove SliceableUnfilteredRowIterator

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655007#comment-14655007 ] Benedict commented on CASSANDRA-9986: - Unassigning, in case somebody else wants to

[jira] [Updated] (CASSANDRA-9986) Remove SliceableUnfilteredRowIterator

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-9986: Assignee: (was: Benedict) > Remove SliceableUnfilteredRowIterator >

[jira] [Commented] (CASSANDRA-9985) Introduce our own AbstractIterator

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655039#comment-14655039 ] Benedict commented on CASSANDRA-9985: - Trivial patch available [here|https://gith

[jira] [Created] (CASSANDRA-9987) BTree Related Optimisations

2015-08-05 Thread Benedict (JIRA)
Benedict created CASSANDRA-9987: --- Summary: BTree Related Optimisations Key: CASSANDRA-9987 URL: https://issues.apache.org/jira/browse/CASSANDRA-9987 Project: Cassandra Issue Type: Improvement

[jira] [Created] (CASSANDRA-9988) Introduce leaf-only iterator

2015-08-05 Thread Benedict (JIRA)
Benedict created CASSANDRA-9988: --- Summary: Introduce leaf-only iterator Key: CASSANDRA-9988 URL: https://issues.apache.org/jira/browse/CASSANDRA-9988 Project: Cassandra Issue Type: Sub-task

[jira] [Created] (CASSANDRA-9989) Optimise BTree.Buider

2015-08-05 Thread Benedict (JIRA)
Benedict created CASSANDRA-9989: --- Summary: Optimise BTree.Buider Key: CASSANDRA-9989 URL: https://issues.apache.org/jira/browse/CASSANDRA-9989 Project: Cassandra Issue Type: Sub-task

[jira] [Created] (CASSANDRA-9990) Use TreeBuilder directly where possible

2015-08-05 Thread Benedict (JIRA)
Benedict created CASSANDRA-9990: --- Summary: Use TreeBuilder directly where possible Key: CASSANDRA-9990 URL: https://issues.apache.org/jira/browse/CASSANDRA-9990 Project: Cassandra Issue Type: S

[jira] [Created] (CASSANDRA-9991) Implement efficient btree removal

2015-08-05 Thread Benedict (JIRA)
Benedict created CASSANDRA-9991: --- Summary: Implement efficient btree removal Key: CASSANDRA-9991 URL: https://issues.apache.org/jira/browse/CASSANDRA-9991 Project: Cassandra Issue Type: Sub-tas

[jira] [Commented] (CASSANDRA-8630) Faster sequential IO (on compaction, streaming, etc)

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655149#comment-14655149 ] Benedict commented on CASSANDRA-8630: - bq. For the fast path, the built-in BB meth

[jira] [Comment Edited] (CASSANDRA-8630) Faster sequential IO (on compaction, streaming, etc)

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655149#comment-14655149 ] Benedict edited comment on CASSANDRA-8630 at 8/5/15 10:33 AM: --

[jira] [Comment Edited] (CASSANDRA-8630) Faster sequential IO (on compaction, streaming, etc)

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655149#comment-14655149 ] Benedict edited comment on CASSANDRA-8630 at 8/5/15 10:34 AM: --

[jira] [Resolved] (CASSANDRA-9925) Sorted + Unique BTree.Builder usage can use a thread-local TreeBuilder directly

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict resolved CASSANDRA-9925. - Resolution: Duplicate > Sorted + Unique BTree.Builder usage can use a thread-local TreeBuilder

[jira] [Resolved] (CASSANDRA-9600) DescriptorTypeTidy and GlobalTypeTidy do not benefit from being full fledged Ref instances

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict resolved CASSANDRA-9600. - Resolution: Won't Fix We've already removed DescriptorTypeTidy, and I don't think it's worth w

[jira] [Commented] (CASSANDRA-9985) Introduce our own AbstractIterator

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658273#comment-14658273 ] Benedict commented on CASSANDRA-9985: - I wouldn't care if it weren't for the sheer

[jira] [Commented] (CASSANDRA-9985) Introduce our own AbstractIterator

2015-08-05 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658310#comment-14658310 ] Benedict commented on CASSANDRA-9985: - FTR, I've had to update the patch to closer

[jira] [Commented] (CASSANDRA-9985) Introduce our own AbstractIterator

2015-08-06 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659823#comment-14659823 ] Benedict commented on CASSANDRA-9985: - bq. Can I bring up the icache boogyman? Y

[jira] [Commented] (CASSANDRA-9985) Introduce our own AbstractIterator

2015-08-06 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659837#comment-14659837 ] Benedict commented on CASSANDRA-9985: - So, I've pushed a version with Guava's test

[jira] [Commented] (CASSANDRA-9894) Serialize the header only once per message

2015-08-06 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14660099#comment-14660099 ] Benedict commented on CASSANDRA-9894: - bq. I changed it to return the assembled l

[jira] [Updated] (CASSANDRA-9925) Sorted + Unique BTree.Builder usage can use a thread-local TreeBuilder directly

2015-08-06 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-9925: Fix Version/s: (was: 3.0.x) > Sorted + Unique BTree.Builder usage can use a thread-local Tre

[jira] [Updated] (CASSANDRA-9962) WaitQueueTest is flakey

2015-08-06 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-9962: Fix Version/s: (was: 3.x) 3.0 beta 1 2.2.1

[jira] [Commented] (CASSANDRA-9998) LEAK DETECTED with snapshot/sequential repairs

2015-08-06 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661382#comment-14661382 ] Benedict commented on CASSANDRA-9998: - +1 > LEAK DETECTED with snapshot/sequentia

[jira] [Commented] (CASSANDRA-9985) Introduce our own AbstractIterator

2015-08-06 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661392#comment-14661392 ] Benedict commented on CASSANDRA-9985: - Right, it seems exceedingly difficult to ge

[jira] [Commented] (CASSANDRA-8630) Faster sequential IO (on compaction, streaming, etc)

2015-08-07 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661560#comment-14661560 ] Benedict commented on CASSANDRA-8630: - It would be better, from that perspective t

[jira] [Commented] (CASSANDRA-8921) Experiment with a probabilistic tree of membership for maxPurgeableTimestamp

2015-08-07 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661802#comment-14661802 ] Benedict commented on CASSANDRA-8921: - Hi Daniel, No one is working on this, no,

[jira] [Commented] (CASSANDRA-10002) Repeated slices on RowSearchers are incorrect

2015-08-07 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662156#comment-14662156 ] Benedict commented on CASSANDRA-10002: -- It's worth pointing out this code will b

[jira] [Updated] (CASSANDRA-9500) SequentialWriter should extend BufferedDataOutputStreamPlus

2015-08-08 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-9500: Reviewer: Benedict > SequentialWriter should extend BufferedDataOutputStreamPlus > -

[jira] [Updated] (CASSANDRA-9985) Introduce our own AbstractIterator

2015-08-08 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict updated CASSANDRA-9985: Fix Version/s: (was: 3.0.0 rc1) 3.0 beta 1 > Introduce our own AbstractIt

[jira] [Commented] (CASSANDRA-9533) Make batch commitlog mode easier to tune

2015-08-08 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662908#comment-14662908 ] Benedict commented on CASSANDRA-9533: - If you're trickling one erase block every 1

[jira] [Commented] (CASSANDRA-9932) Make all partitions btree backed

2015-08-08 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662973#comment-14662973 ] Benedict commented on CASSANDRA-9932: - bq. This change to a large extent looks lik

  1   2   3   4   5   6   7   8   9   10   >