[
https://issues.apache.org/jira/browse/CASSANDRA-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648324#comment-14648324
]
Benedict commented on CASSANDRA-9894:
-------------------------------------
bq. Looks good to me conditional on a unit test for Columns.
bq. , but in the common case will there be enough columns to benefit?
Those are both comments for a different ticket, CASSANDRA-9471. This is built
upon that simply because it made the patch a little easier. I will respond to
these comments there.
bq. In Columns when you serialize -1 for the encoding/number of columns can you
add a comment that using the unsigned varint is intentional?
The reason we is we cannot use any other encoding: the other two branches use
it, so we _have_ to in order for deserialization to know what's going on....
I'll add a comment to that effect, but I felt this was commented by the code.
> Serialize the header only once per message
> ------------------------------------------
>
> Key: CASSANDRA-9894
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9894
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Benedict
> Fix For: 3.0 beta 1
>
>
> One last improvement I'd like to do on the serialization side is that we
> currently serialize the {{SerializationHeader}} for each partition. That
> header contains the serialized columns in particular and for range queries,
> serializing that for every partition is wasted (note that it's only a problem
> for the messaging protocol as for sstable we only write the header once per
> sstable).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
