[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808673#comment-17808673
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
Great! Thanks!
Committed to
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808403#comment-17808403
]
Michael Semb Wever commented on CASSANDRA-18688:
bq. do you have your setup working
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808330#comment-17808330
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
Thanks [~skokoori] !
[~mck], do
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807834#comment-17807834
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
Test comment
> Limit Java
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806214#comment-17806214
]
shylaja kokoori commented on CASSANDRA-18688:
-
Thanks for fixing it Ekaterina:)
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806088#comment-17806088
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
Thanks, I can change this nit on
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805892#comment-17805892
]
Berenguer Blasi commented on CASSANDRA-18688:
-
I got asked about my previous comment on
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805388#comment-17805388
]
Berenguer Blasi commented on CASSANDRA-18688:
-
Agree with CI analysis. Nit missing space
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805307#comment-17805307
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
No related failures from CI.
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804852#comment-17804852
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
Rebased the branch and squashed
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804545#comment-17804545
]
shylaja kokoori commented on CASSANDRA-18688:
-
Thank you, updated the changes [here
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804330#comment-17804330
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
Happy New Year! Sorry for the
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801925#comment-17801925
]
shylaja kokoori commented on CASSANDRA-18688:
-
Thanks [~mck] , I will wait to hear from
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801922#comment-17801922
]
Michael Semb Wever commented on CASSANDRA-18688:
Works for me [~skokoori].
> Limit
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801866#comment-17801866
]
shylaja kokoori commented on CASSANDRA-18688:
-
Thanks everyone for all the feedback you
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799474#comment-17799474
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
{quote} I think with new
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799384#comment-17799384
]
Michael Semb Wever commented on CASSANDRA-18688:
bq. For me, as a user, this is
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799166#comment-17799166
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
{quote}this quickly becomes a
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799158#comment-17799158
]
Michael Semb Wever commented on CASSANDRA-18688:
bq. Shouldn't we check to see if it
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799141#comment-17799141
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
I think people trust me more than
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799046#comment-17799046
]
Michael Semb Wever commented on CASSANDRA-18688:
+1
> Limit Java runtime in 5.0 to
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795192#comment-17795192
]
Berenguer Blasi commented on CASSANDRA-18688:
-
+1 go ahead. Thanks [~skokoori] for all
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793436#comment-17793436
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
[~mck] confirmed on GH that he
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793027#comment-17793027
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
The patch LGTM, tested:
JDK11 -
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791950#comment-17791950
]
Berenguer Blasi commented on CASSANDRA-18688:
-
Uhh packaging. Good point. Yes we need
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791667#comment-17791667
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
This ticket is clearly not for a
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791612#comment-17791612
]
Michael Semb Wever commented on CASSANDRA-18688:
+1
(and no outstanding comments on
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787446#comment-17787446
]
shylaja kokoori commented on CASSANDRA-18688:
-
I have updated the debian & redhat
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783488#comment-17783488
]
Berenguer Blasi commented on CASSANDRA-18688:
-
There is a [pending
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783408#comment-17783408
]
shylaja kokoori commented on CASSANDRA-18688:
-
Are there any other changes needed for
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772437#comment-17772437
]
Berenguer Blasi commented on CASSANDRA-18688:
-
I am going to be OOO next week and I
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772408#comment-17772408
]
shylaja kokoori commented on CASSANDRA-18688:
-
Thank you everyone for helping with the
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771548#comment-17771548
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
Great, so it seems the only still
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771374#comment-17771374
]
Berenguer Blasi commented on CASSANDRA-18688:
-
CASSANDRA_JDK_UNSUPPORTED it is then...
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771195#comment-17771195
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
All of them are super lengthy,
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771000#comment-17771000
]
Michael Semb Wever commented on CASSANDRA-18688:
CASSANDRA_JDK_UNSUPPORTED is still
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770961#comment-17770961
]
Berenguer Blasi commented on CASSANDRA-18688:
-
Yep but lest see what others think or
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770627#comment-17770627
]
shylaja kokoori commented on CASSANDRA-18688:
-
Thank you very much for the input. I
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769001#comment-17769001
]
Berenguer Blasi commented on CASSANDRA-18688:
-
CASSANDRA_JDK_GT_SUPPORTED?
> Limit Java
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768900#comment-17768900
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
{quote}yes, but that'll change
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768897#comment-17768897
]
Michael Semb Wever commented on CASSANDRA-18688:
yes, but that'll change each time
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768896#comment-17768896
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
The thing is that it is not ANY.
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768893#comment-17768893
]
Michael Semb Wever commented on CASSANDRA-18688:
CASSANDRA_JDK_ANY or
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768821#comment-17768821
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
Thanks [~skokoori] , I left a
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765878#comment-17765878
]
shylaja kokoori commented on CASSANDRA-18688:
-
Hi All, I have updated the pull request
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17764026#comment-17764026
]
Berenguer Blasi commented on CASSANDRA-18688:
-
SGTM Thanks for driving this
> Limit
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763289#comment-17763289
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
{quote}Please let me know if this
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763285#comment-17763285
]
shylaja kokoori commented on CASSANDRA-18688:
-
I have pinged everybody offline & you
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759162#comment-17759162
]
Michael Semb Wever commented on CASSANDRA-18688:
I'm easy, either way this is good,
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758598#comment-17758598
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
bq. This was almost ready. Is
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758395#comment-17758395
]
Berenguer Blasi commented on CASSANDRA-18688:
-
This was almost ready. Is anything
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755652#comment-17755652
]
shylaja kokoori commented on CASSANDRA-18688:
-
Mick, to answer your questions
{quote}How
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755582#comment-17755582
]
Michael Semb Wever commented on CASSANDRA-18688:
What are users asking for? JDKs in
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755577#comment-17755577
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
bq. Enabling anything new, like
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755395#comment-17755395
]
Berenguer Blasi commented on CASSANDRA-18688:
-
Enabling anything new, like versions 11
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752920#comment-17752920
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
On second thought we left in
[
https://issues.apache.org/jira/browse/CASSANDRA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752919#comment-17752919
]
Ekaterina Dimitrova commented on CASSANDRA-18688:
-
Overall LGTM, I left just two
57 matches
Mail list logo