[GitHub] [cloudstack] anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-16 Thread GitBox
anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r358641743 ## File path: server/src/main/java/org/apache/cloudstack/diagnostics/Diagnosti

[GitHub] [cloudstack] borisstoyanov opened a new issue #3770: UI: JOB does not complete when you create a template from snapshot

2019-12-16 Thread GitBox
borisstoyanov opened a new issue #3770: UI: JOB does not complete when you create a template from snapshot URL: https://github.com/apache/cloudstack/issues/3770 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-16 Thread GitBox
anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r358634282 ## File path: server/src/main/java/org/apache/cloudstack/diagnostics/Diagnosti

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-16 Thread GitBox
anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r358632573 ## File path: server/src/main/java/org/apache/cloudstack/diagnostics/Diagnosti

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-16 Thread GitBox
anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r358630842 ## File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-16 Thread GitBox
anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r358630818 ## File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-16 Thread GitBox
anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r358630678 ## File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-16 Thread GitBox
anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r358630463 ## File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-16 Thread GitBox
anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r358630492 ## File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-12-16 Thread GitBox
anuragaw commented on a change in pull request #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router URL: https://github.com/apache/cloudstack/pull/3350#discussion_r358630428 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/diagno

[GitHub] [cloudstack] shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2019-12-16 Thread GitBox
shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-566409958 @poussa Will be adding documentation soon. Meanwhile you can check feature spec if that helps, https://cwiki.apache.org/confluenc

[GitHub] [cloudstack] poussa commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2019-12-16 Thread GitBox
poussa commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-566402597 @shwstppr Do we have any docs how one can test/try this feature? Th

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
anuragaw commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358595423 ## File path: api/src/main/java/org/apache/cloudstack/api/ApiConstants.java ## @@ -722

[GitHub] [cloudstack] blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2019-12-16 Thread GitBox
blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-566377598 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-475 This is

[GitHub] [cloudstack] blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2019-12-16 Thread GitBox
blueorangutan commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-566374427 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service

2019-12-16 Thread GitBox
shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-566374305 @blueorangutan package This is an automated message from the Apac

[GitHub] [cloudstack] anuragaw commented on issue #3769: README: that time of the year!

2019-12-16 Thread GitBox
anuragaw commented on issue #3769: README: that time of the year! URL: https://github.com/apache/cloudstack/pull/3769#issuecomment-566367636 Happy new year and best wishes for the season all! :) This is an automated message f

[GitHub] [cloudstack] blueorangutan commented on issue #3768: [HEALTH][4.13] Health Check Run

2019-12-16 Thread GitBox
blueorangutan commented on issue #3768: [HEALTH][4.13] Health Check Run URL: https://github.com/apache/cloudstack/pull/3768#issuecomment-566350351 Trillian test result (tid-630) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27217 seconds Ma

[GitHub] [cloudstack] blueorangutan commented on issue #3768: [HEALTH][4.13] Health Check Run

2019-12-16 Thread GitBox
blueorangutan commented on issue #3768: [HEALTH][4.13] Health Check Run URL: https://github.com/apache/cloudstack/pull/3768#issuecomment-566348270 Trillian test result (tid-631) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 26554 seconds Mar

[cloudstack] branch master updated (0d92b92 -> da62cec)

2019-12-16 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 0d92b92 Fix OS category for some OS-es added in 4.13 (#3746) add da62cec README: that time of the ye

[GitHub] [cloudstack] andrijapanicsb commented on issue #3769: README: that time of the year!

2019-12-16 Thread GitBox
andrijapanicsb commented on issue #3769: README: that time of the year! URL: https://github.com/apache/cloudstack/pull/3769#issuecomment-566286389 Merging based on so may LGTMs and +1 (Rohit you'll have the pleasure or reverting the stuff later)

[GitHub] [cloudstack] andrijapanicsb merged pull request #3769: README: that time of the year!

2019-12-16 Thread GitBox
andrijapanicsb merged pull request #3769: README: that time of the year! URL: https://github.com/apache/cloudstack/pull/3769 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-16 Thread GitBox
andrijapanicsb commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#discussion_r358468145 ## File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java ## @@ -1348,11 +1

[GitHub] [cloudstack] nvazquez commented on issue #3769: README: that time of the year!

2019-12-16 Thread GitBox
nvazquez commented on issue #3769: README: that time of the year! URL: https://github.com/apache/cloudstack/pull/3769#issuecomment-566226794 Happy holidays and new year all! This is an automated message from the Apache Git Ser

[GitHub] [cloudstack] mike-tutkowski commented on issue #3769: README: that time of the year!

2019-12-16 Thread GitBox
mike-tutkowski commented on issue #3769: README: that time of the year! URL: https://github.com/apache/cloudstack/pull/3769#issuecomment-566212062 LGTM :) This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] svenvogel commented on issue #3769: README: that time of the year!

2019-12-16 Thread GitBox
svenvogel commented on issue #3769: README: that time of the year! URL: https://github.com/apache/cloudstack/pull/3769#issuecomment-566188671 @rohit and all other ... happy holiday ... :star::evergreen_tree::snowflake::snowman::gift::santa::bell: ---

[GitHub] [cloudstack] svenvogel edited a comment on issue #3769: README: that time of the year!

2019-12-16 Thread GitBox
svenvogel edited a comment on issue #3769: README: that time of the year! URL: https://github.com/apache/cloudstack/pull/3769#issuecomment-566188671 @rhtyd and all other ... happy holiday ... :star::evergreen_tree::snowflake::snowman::gift::santa::bell: ---

[GitHub] [cloudstack] blueorangutan commented on issue #3768: [HEALTH][4.13] Health Check Run

2019-12-16 Thread GitBox
blueorangutan commented on issue #3768: [HEALTH][4.13] Health Check Run URL: https://github.com/apache/cloudstack/pull/3768#issuecomment-566180312 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smo

[GitHub] [cloudstack] DaanHoogland commented on issue #3768: [HEALTH][4.13] Health Check Run

2019-12-16 Thread GitBox
DaanHoogland commented on issue #3768: [HEALTH][4.13] Health Check Run URL: https://github.com/apache/cloudstack/pull/3768#issuecomment-566179975 @blueorangutan test matrix This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-566162259 Trillian test result (tid-628) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] [cloudstack] blueorangutan commented on issue #3743: only update powerstate if sure it is the latest

2019-12-16 Thread GitBox
blueorangutan commented on issue #3743: only update powerstate if sure it is the latest URL: https://github.com/apache/cloudstack/pull/3743#issuecomment-566131750 Trillian test result (tid-627) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 266

[GitHub] [cloudstack] blueorangutan commented on issue #3768: [HEALTH][4.13] Health Check Run

2019-12-16 Thread GitBox
blueorangutan commented on issue #3768: [HEALTH][4.13] Health Check Run URL: https://github.com/apache/cloudstack/pull/3768#issuecomment-566123032 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-474 This is an automated messa

[GitHub] [cloudstack] msinhore commented on issue #3769: README: that time of the year!

2019-12-16 Thread GitBox
msinhore commented on issue #3769: README: that time of the year! URL: https://github.com/apache/cloudstack/pull/3769#issuecomment-566122086 Happy holidays folks! This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] syed commented on issue #3769: README: that time of the year!

2019-12-16 Thread GitBox
syed commented on issue #3769: README: that time of the year! URL: https://github.com/apache/cloudstack/pull/3769#issuecomment-566119312 Happy holidays all :) On Mon, Dec 16, 2019 at 10:49 AM Rohit Yadav wrote: > To all of CloudStack contributors - Happy Christmas and holid

[GitHub] [cloudstack] rhtyd commented on issue #3769: README: that time of the year!

2019-12-16 Thread GitBox
rhtyd commented on issue #3769: README: that time of the year! URL: https://github.com/apache/cloudstack/pull/3769#issuecomment-566118631 To all of CloudStack contributors - Happy Christmas and holidays! /cc alphabetically-ish @andrijapanic @anuragaw @borisstoyanov @bwsw @chiradeep @Daan

[GitHub] [cloudstack] rhtyd opened a new pull request #3769: README: that time of the year!

2019-12-16 Thread GitBox
rhtyd opened a new pull request #3769: README: that time of the year! URL: https://github.com/apache/cloudstack/pull/3769 That time of the year :christmas_tree: - let's merge this without tests? ## Types of changes - [ ] Breaking change (fix or feature that would cause existing

[GitHub] [cloudstack] blueorangutan commented on issue #3768: [HEALTH][4.13] Health Check Run

2019-12-16 Thread GitBox
blueorangutan commented on issue #3768: [HEALTH][4.13] Health Check Run URL: https://github.com/apache/cloudstack/pull/3768#issuecomment-566113192 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] DaanHoogland commented on issue #3768: [HEALTH][4.13] Health Check Run

2019-12-16 Thread GitBox
DaanHoogland commented on issue #3768: [HEALTH][4.13] Health Check Run URL: https://github.com/apache/cloudstack/pull/3768#issuecomment-566113013 @blueorangutan package This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] DaanHoogland opened a new pull request #3768: [HEALTH][4.13] Health Check Run

2019-12-16 Thread GitBox
DaanHoogland opened a new pull request #3768: [HEALTH][4.13] Health Check Run URL: https://github.com/apache/cloudstack/pull/3768 This is an automated message from the Apache Git Service. To respond to the message, please log

[cloudstack] branch health-4.13 created (now 58ebcf2)

2019-12-16 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch health-4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. at 58ebcf2 please do not merge this;) This branch includes the following new commits: new 58ebcf2 please

[cloudstack] 01/01: please do not merge this;)

2019-12-16 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch health-4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 58ebcf2533399b341e588c575e6410792ef956b8 Author: Daan Hoogland AuthorDate: Mon Dec 16 16:34:24 2019 +0100 pl

[GitHub] [cloudstack] blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-16 Thread GitBox
blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-566098066 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-473 This is an a

[GitHub] [cloudstack] wido commented on a change in pull request #3736: Add protocol number support for security group rules

2019-12-16 Thread GitBox
wido commented on a change in pull request #3736: Add protocol number support for security group rules URL: https://github.com/apache/cloudstack/pull/3736#discussion_r358277625 ## File path: scripts/vm/network/security_group.py ## @@ -1032,7 +1032,18 @@ def add_network_rul

[GitHub] [cloudstack] blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-16 Thread GitBox
blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-566090007 @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-16 Thread GitBox
andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-566089627 @blueorangutan package This is an automated message from the Apa

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-16 Thread GitBox
nvazquez commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#discussion_r358245701 ## File path: api/src/main/java/com/cloud/network/Network.java ## @@ -44,6 +46,24 @@ Shared

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#discussion_r358236887 ## File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java ## @@ -1348,11 +136

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#discussion_r358235797 ## File path: api/src/main/java/com/cloud/network/Network.java ## @@ -44,6 +46,24 @@ Sh

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-16 Thread GitBox
nvazquez commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#discussion_r358233838 ## File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java ## @@ -1348,11 +1363,54

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-16 Thread GitBox
nvazquez commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#discussion_r358226332 ## File path: api/src/main/java/com/cloud/network/Network.java ## @@ -44,6 +46,24 @@ Shared

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-16 Thread GitBox
nvazquez commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#discussion_r358226332 ## File path: api/src/main/java/com/cloud/network/Network.java ## @@ -44,6 +46,24 @@ Shared

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358194315 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerI

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358134388 ## File path: api/src/main/java/org/apache/cloudstack/api/ApiConstants.java ## @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358202932 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerI

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358190756 ## File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/facade/SetMonitorS

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358191316 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerI

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358207814 ## File path: systemvm/debian/root/health_checks/router_version_check.py ## @@ -0,

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358191021 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerI

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358199342 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerI

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358205508 ## File path: systemvm/debian/opt/cloud/bin/cs/CsMonitor.py ## @@ -17,27 +17,55 @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358142736 ## File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingReso

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358208523 ## File path: systemvm/debian/opt/cloud/bin/getRouterMonitorResults.sh ## @@ -0,0

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358133243 ## File path: api/src/main/java/org/apache/cloudstack/api/ApiConstants.java ## @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358140160 ## File path: core/src/main/java/com/cloud/agent/api/routing/SetMonitorServiceCommand.java

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358151388 ## File path: engine/schema/src/main/java/com/cloud/network/dao/RouterHealthCheckResultVO.j

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358203567 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerI

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358141715 ## File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingReso

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358152728 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManager.

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358139468 ## File path: core/src/main/java/com/cloud/agent/api/routing/LoadRouterHealthChecksConfigCo

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358200431 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerI

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358144424 ## File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingReso

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358198478 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerI

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358141034 ## File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/VRScripts.java ##

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358154223 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerI

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358145224 ## File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/facade/AbstractCon

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358211628 ## File path: systemvm/debian/root/health_checks/memory_usage_check.py ## @@ -0,0

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358207561 ## File path: systemvm/debian/root/health_checks/router_version_check.py ## @@ -0,

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358158692 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerI

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358149685 ## File path: engine/schema/src/main/java/com/cloud/network/dao/RouterHealthCheckResultDao.

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358170833 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerI

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#discussion_r358154589 ## File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerI

[GitHub] [cloudstack] rhtyd commented on issue #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework

2019-12-16 Thread GitBox
rhtyd commented on issue #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework URL: https://github.com/apache/cloudstack/pull/3553#issuecomment-566016730 Thanks @nvazquez - most of the comments may require name/cosmetics refactorings but nothing major from a design rework/refa

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#discussion_r358121584 ## File path: api/src/main/java/com/cloud/network/Network.java ## @@ -44,6 +46,24 @@ Sh

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#discussion_r358128258 ## File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java ## @@ -1348,11 +136

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-16 Thread GitBox
DaanHoogland commented on a change in pull request #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#discussion_r358123594 ## File path: server/src/main/java/com/cloud/network/NetworkServiceImpl.java ## @@ -1239,14 +124

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-565978267 @anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-565978008 @blueorangutan test This is an automated message from th

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-565974835 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-472 ---

[GitHub] [cloudstack] blueorangutan commented on issue #3747: convert protocal names to be found as labels

2019-12-16 Thread GitBox
blueorangutan commented on issue #3747: convert protocal names to be found as labels URL: https://github.com/apache/cloudstack/pull/3747#issuecomment-565969371 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-471 This is an a

[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-565967947 @blueorangutan package This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-16 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-565968000 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] blueorangutan commented on issue #3747: convert protocal names to be found as labels

2019-12-16 Thread GitBox
blueorangutan commented on issue #3747: convert protocal names to be found as labels URL: https://github.com/apache/cloudstack/pull/3747#issuecomment-565961790 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] borisstoyanov commented on issue #3747: convert protocal names to be found as labels

2019-12-16 Thread GitBox
borisstoyanov commented on issue #3747: convert protocal names to be found as labels URL: https://github.com/apache/cloudstack/pull/3747#issuecomment-565961494 @blueorangutan package This is an automated message from the Apac

[GitHub] [cloudstack] DaanHoogland commented on issue #3743: only update powerstate if sure it is the latest

2019-12-16 Thread GitBox
DaanHoogland commented on issue #3743: only update powerstate if sure it is the latest URL: https://github.com/apache/cloudstack/pull/3743#issuecomment-565956886 @blueorangutan test This is an automated message from the Apach

[GitHub] [cloudstack] blueorangutan commented on issue #3743: only update powerstate if sure it is the latest

2019-12-16 Thread GitBox
blueorangutan commented on issue #3743: only update powerstate if sure it is the latest URL: https://github.com/apache/cloudstack/pull/3743#issuecomment-565956913 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] DaanHoogland commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-12-16 Thread GitBox
DaanHoogland commented on issue #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-565955907 @svenvogel @gmueller-ewerk it is better practice to rebase the branch upon master, but as we squash-merge on merge a new commit