Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#issuecomment-2080375440 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud commented on PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#issuecomment-2080375134 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2080370216 [SF] Trillian Build Failed (tid-10063) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2080370166 [SF] Trillian Build Failed (tid-10061) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#issuecomment-2080369490 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9451 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2080365687 @rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests --

Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2080364673 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2080362392 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2080362124 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2080360286 Thanks @weizhouapache @JoaoJandre I've addressed the feedback and comments. Joao's remarks are valid, however, my comments at the time were largely around metrics vs

Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#issuecomment-2080352750 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud commented on PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#issuecomment-2080352554 Thanks @weizhouapache @sureshanaparti I've addressed the review comments. @blueorangutan package -- This is an automated message from the Apache Git Service. To

Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud commented on code in PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#discussion_r1581727099 ## utils/src/main/java/com/cloud/utils/net/MacAddress.java: ## @@ -79,209 +72,45 @@ public String toString() { static { String macAddress =

Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud commented on code in PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#discussion_r1581725346 ## utils/src/main/java/com/cloud/utils/net/MacAddress.java: ## @@ -79,209 +72,45 @@ public String toString() { static { String macAddress =

Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8243: URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2080341492 [SF] Trillian test result (tid-10052) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 51115 seconds Marvin logs:

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2080335049 [SF] Trillian test result (tid-10054) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48698 seconds Marvin logs:

Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8974: URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2080322814 [SF] Trillian test result (tid-10046) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a8 Total time taken: 56860 seconds Marvin logs:

Re: [PR] Accept a role ID on linking an account to LDAP [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8236: URL: https://github.com/apache/cloudstack/pull/8236#issuecomment-2080304770 [SF] Trillian test result (tid-10053) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44428 seconds Marvin logs:

Re: [PR] sanatise log in case multiple passwords have been passed [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8891: URL: https://github.com/apache/cloudstack/pull/8891#issuecomment-2080247652 [SF] Trillian test result (tid-10047) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47863 seconds Marvin logs:

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2080246212 [SF] Trillian test result (tid-10050) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45290 seconds Marvin logs:

Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]

2024-04-26 Thread via GitHub
rg9975 commented on code in PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#discussion_r1581627317 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/MultipathSCSIAdapterBase.java: ## @@ -223,15 +228,19 @@ public boolean

Re: [PR] Fix: Update rootdisksize detail on restore VM [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8981: URL: https://github.com/apache/cloudstack/pull/8981#issuecomment-2080231020 [SF] Trillian test result (tid-10049) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44709 seconds Marvin logs:

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2080207600 [SF] Trillian test result (tid-10045) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48172 seconds Marvin logs:

Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]

2024-04-26 Thread via GitHub
rg9975 commented on code in PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#discussion_r1581566150 ## engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java: ## @@ -2975,19 +3076,21 @@ private

Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]

2024-04-26 Thread via GitHub
rg9975 commented on code in PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#discussion_r1581565857 ## engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java: ## @@ -2496,15 +2599,17 @@ private void

Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]

2024-04-26 Thread via GitHub
rg9975 commented on code in PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#discussion_r1581565512 ## engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java: ## @@ -1696,14 +1850,15 @@ private void

Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2080128999 [SF] Trillian test result (tid-10042) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 49762 seconds Marvin logs:

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2080113463 [SF] Trillian test result (tid-10044) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43454 seconds Marvin logs:

Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2079994634 [SF] Trillian Build Failed (tid-10060) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2079966364 [SF] Trillian Build Failed (tid-10058) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2079939039 @rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests --

Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2079935495 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] (VirtualRouter) Provider is not ready, cannot Enable the provider, please configure the provider first [cloudstack]

2024-04-26 Thread via GitHub
boring-cyborg[bot] commented on issue #8997: URL: https://github.com/apache/cloudstack/issues/8997#issuecomment-2079930659 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[I] (VirtualRouter) Provider is not ready, cannot Enable the provider, please configure the provider first [cloudstack]

2024-04-26 Thread via GitHub
Luskan777 opened a new issue, #8997: URL: https://github.com/apache/cloudstack/issues/8997 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VirtualRouter ~~~ # CLOUDSTACK VERSION ~~~ 4.19.0.1 ~~~ #

Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]

2024-04-26 Thread via GitHub
weizhouapache commented on code in PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#discussion_r1581384065 ## utils/src/main/java/com/cloud/utils/net/MacAddress.java: ## @@ -79,209 +72,45 @@ public String toString() { static { String macAddress =

Re: [I] System VM / Agent on KVM host does not support NFSv3 on Secondary Storage [cloudstack]

2024-04-26 Thread via GitHub
weizhouapache commented on issue #8996: URL: https://github.com/apache/cloudstack/issues/8996#issuecomment-2079911841 > This bug is probably related to the first bug I submitted, ie, the zone set up let me configure secondary storage that it could not actually make use of and no errors

Re: [I] System VM / Agent on KVM host does not support NFSv3 on Secondary Storage [cloudstack]

2024-04-26 Thread via GitHub
Jayd603 commented on issue #8996: URL: https://github.com/apache/cloudstack/issues/8996#issuecomment-2079897685 This bug is probably related to the first bug I submitted, ie, the zone set up let me configure secondary storage that it could not actually make use of and no errors were shown.

Re: [I] System VM / Agent on KVM host does not support NFSv3 on Secondary Storage [cloudstack]

2024-04-26 Thread via GitHub
weizhouapache commented on issue #8996: URL: https://github.com/apache/cloudstack/issues/8996#issuecomment-2079890833 > > Update /etc/nfsmount.conf to set the NFS version to 4.0 and retry > > Thanks but the storage server I am using actually only supports nfsv3 due to legacy clients

Re: [PR] Fix message publish in transaction [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8980: URL: https://github.com/apache/cloudstack/pull/8980#issuecomment-2079890508 [SF] Trillian test result (tid-10041) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47282 seconds Marvin logs:

Re: [PR] Use parameter dcId as wrapper to prevent NPE [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8986: URL: https://github.com/apache/cloudstack/pull/8986#issuecomment-2079869662 @weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This

Re: [PR] Use parameter dcId as wrapper to prevent NPE [cloudstack]

2024-04-26 Thread via GitHub
weizhouapache commented on PR #8986: URL: https://github.com/apache/cloudstack/pull/8986#issuecomment-2079867296 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] IP address conflicts held by public IPs of virtual routers [cloudstack]

2024-04-26 Thread via GitHub
vdombrovski commented on issue #8967: URL: https://github.com/apache/cloudstack/issues/8967#issuecomment-2079829634 @DaanHoogland yes correct, released after I wrote my comment, which means we will surely plan our tests now. As for proof inside the DB, I've ran more tests, and I can

Re: [PR] Use parameter dcId as wrapper to prevent NPE [cloudstack]

2024-04-26 Thread via GitHub
KlausDornsbach commented on PR #8986: URL: https://github.com/apache/cloudstack/pull/8986#issuecomment-2079819706 CLGTM. Also done some testing: 1. Remove NFS secondary storage. 2. Create AWS Bucket, generate access and secret keys. 3. Add the S3 secondary storage bucket to

Re: [I] System VM / Agent on KVM host does not support NFSv3 on Secondary Storage [cloudstack]

2024-04-26 Thread via GitHub
Jayd603 commented on issue #8996: URL: https://github.com/apache/cloudstack/issues/8996#issuecomment-2079756749 > Update /etc/nfsmount.conf to set the NFS version to 4.0 and retry Thanks but the server I am using actually only supports nfsv3 due to legacy clients making use of it.

Re: [I] System VM / Agent on KVM host does not support NFSv3 on Secondary Storage [cloudstack]

2024-04-26 Thread via GitHub
weizhouapache commented on issue #8996: URL: https://github.com/apache/cloudstack/issues/8996#issuecomment-2079755098 Update /etc/nfsmount.conf to set the NFS version to 4.0 and retry -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Clean up Python code; Python `2` to `3` [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8993: URL: https://github.com/apache/cloudstack/pull/8993#issuecomment-2079739683 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9448 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Add password enabled during ISO register and update [cloudstack]

2024-04-26 Thread via GitHub
codecov-commenter commented on PR #8992: URL: https://github.com/apache/cloudstack/pull/8992#issuecomment-2079732337 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8992?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

Re: [PR] VNF: add API listVnfAppliances [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8994: URL: https://github.com/apache/cloudstack/pull/8994#issuecomment-2079665237 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9447 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Clean up Python code; Python `2` to `3` [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8993: URL: https://github.com/apache/cloudstack/pull/8993#issuecomment-2079603515 @jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Clean up Python code; Python `2` to `3` [cloudstack]

2024-04-26 Thread via GitHub
jbampton commented on PR #8993: URL: https://github.com/apache/cloudstack/pull/8993#issuecomment-2079600356 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Unstable 4.19 and main branch smoketests [cloudstack]

2024-04-26 Thread via GitHub
weizhouapache commented on issue #8931: URL: https://github.com/apache/cloudstack/issues/8931#issuecomment-2079559208 I updated the integration test ``` diff --git a/test/integration/smoke/test_events_resource.py b/test/integration/smoke/test_events_resource.py index

Re: [I] Initial zone set-up does not verify usable secondary storage - leads to issues [cloudstack]

2024-04-26 Thread via GitHub
boring-cyborg[bot] commented on issue #8995: URL: https://github.com/apache/cloudstack/issues/8995#issuecomment-2079548780 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[I] Initial zone set-up does not verify usable secondary storage - leads to issues [cloudstack]

2024-04-26 Thread via GitHub
Jayd603 opened a new issue, #8995: URL: https://github.com/apache/cloudstack/issues/8995 Latest cloudstack, I just did a new cloudstack install, set up first zone, I accidentally used the wrong secondary NFS storage path, the set-up process gave no errors. Now, after creating new and

Re: [PR] VNF: add API listVnfAppliances [cloudstack]

2024-04-26 Thread via GitHub
codecov-commenter commented on PR #8994: URL: https://github.com/apache/cloudstack/pull/8994#issuecomment-2079548300 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8994?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

Re: [PR] VNF: add API listVnfAppliances [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8994: URL: https://github.com/apache/cloudstack/pull/8994#issuecomment-2079536410 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] VNF: add API listVnfAppliances [cloudstack]

2024-04-26 Thread via GitHub
weizhouapache commented on PR #8994: URL: https://github.com/apache/cloudstack/pull/8994#issuecomment-2079532671 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] VNF: add API listVnfAppliances [cloudstack]

2024-04-26 Thread via GitHub
weizhouapache opened a new pull request, #8994: URL: https://github.com/apache/cloudstack/pull/8994 ### Description This PR fixes #8979 ### Types of changes - [ ] Breaking change (fix or feature that would cause

Re: [PR] Clean up Python code; Python `2` to `3` [cloudstack]

2024-04-26 Thread via GitHub
codecov-commenter commented on PR #8993: URL: https://github.com/apache/cloudstack/pull/8993#issuecomment-2079514027 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8993?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

Re: [I] Cannot remove Secondary storage after using new feature "migration of secondary storage" [cloudstack]

2024-04-26 Thread via GitHub
Jayd603 commented on issue #4613: URL: https://github.com/apache/cloudstack/issues/4613#issuecomment-2079503884 I just did a new cloudstack install, set up first zone, I accidentally used the wrong secondary storage path, the set-up process gave no errors. Now, after creating new and

[PR] Clean up Python code; Python `2` to `3` [cloudstack]

2024-04-26 Thread via GitHub
jbampton opened a new pull request, #8993: URL: https://github.com/apache/cloudstack/pull/8993 ### Description This PR cleans up some Python code. Mainly `print` statements. ### Types of changes - [ ] Breaking

[PR] add password enabled during ISO register and update [cloudstack]

2024-04-26 Thread via GitHub
GaOrtiga opened a new pull request, #8992: URL: https://github.com/apache/cloudstack/pull/8992 ### Description The parameter `passwordenabled` is available on the APIs that register and update ISOs, however, it had not been added to the UI yet. This parameter was added to the

Re: [I] Ubuntu 24.04 support [cloudstack]

2024-04-26 Thread via GitHub
weizhouapache commented on issue #8991: URL: https://github.com/apache/cloudstack/issues/8991#issuecomment-2079384769 +1 Do we consider it in 4.19.1? @sureshanaparti @rohityadavcloud @DaanHoogland -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] extract host from websocket to add route [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2079363901 [SF] Trillian test result (tid-10040) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9 Total time taken: 51459 seconds Marvin logs:

[I] Ubuntu 24.04 support [cloudstack]

2024-04-26 Thread via GitHub
fmcwebs opened a new issue, #8991: URL: https://github.com/apache/cloudstack/issues/8991 # ISSUE TYPE * Enhancement Request # COMPONENT NAME ~~~ OS Support ~~~ # CLOUDSTACK VERSION ~~~ 4.18 / 4.19 ~~~ #

Re: [PR] Fix spelling, word case, duplicate words in code comments only [cloudstack]

2024-04-26 Thread via GitHub
DaanHoogland closed pull request #8987: Fix spelling, word case, duplicate words in code comments only URL: https://github.com/apache/cloudstack/pull/8987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]

2024-04-26 Thread via GitHub
sureshanaparti commented on code in PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#discussion_r1580998790 ## utils/src/main/java/com/cloud/utils/net/MacAddress.java: ## @@ -79,209 +72,45 @@ public String toString() { static { String macAddress =

Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]

2024-04-26 Thread via GitHub
sureshanaparti commented on code in PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#discussion_r1580995715 ## utils/src/main/java/com/cloud/utils/net/MacAddress.java: ## @@ -79,209 +72,45 @@ public String toString() { static { String macAddress =

Re: [PR] list VMs by displayname instead of name [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8503: URL: https://github.com/apache/cloudstack/pull/8503#issuecomment-2079332819 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8503 (QA-JID-325) -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079323373 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] Show menu section if user has access to at least one of its pages [cloudstack]

2024-04-26 Thread via GitHub
BryanMLima commented on code in PR #8978: URL: https://github.com/apache/cloudstack/pull/8978#discussion_r1580981216 ## ui/src/store/modules/permission.js: ## @@ -17,24 +17,39 @@ import { asyncRouterMap, constantRouterMap } from '@/config/router' -function hasApi (apis,

Re: [PR] Show menu section if user has access to at least one of its pages [cloudstack]

2024-04-26 Thread via GitHub
BryanMLima commented on code in PR #8978: URL: https://github.com/apache/cloudstack/pull/8978#discussion_r1580985185 ## ui/src/store/modules/permission.js: ## @@ -17,24 +17,39 @@ import { asyncRouterMap, constantRouterMap } from '@/config/router' -function hasApi (apis,

Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]

2024-04-26 Thread via GitHub
sureshanaparti commented on code in PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#discussion_r1580982750 ## utils/src/main/java/com/cloud/utils/net/MacAddress.java: ## @@ -79,209 +72,45 @@ public String toString() { static { String macAddress =

Re: [PR] Fix restore VM with allocated root disk [cloudstack]

2024-04-26 Thread via GitHub
weizhouapache commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079320521 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Order the `.gitignore` file [cloudstack]

2024-04-26 Thread via GitHub
DaanHoogland merged PR #8989: URL: https://github.com/apache/cloudstack/pull/8989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(cloudstack) branch main updated (00ee5fd4298 -> 6e823b2cd34)

2024-04-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 00ee5fd4298 Show menu section if user has access to at least one of its pages (#8978) add 6e823b2cd34 Order the

Re: [PR] Accept a role ID on linking an account to LDAP [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8236: URL: https://github.com/apache/cloudstack/pull/8236#issuecomment-2079309379 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8243: URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2079309332 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] list VMs by displayname instead of name [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8503: URL: https://github.com/apache/cloudstack/pull/8503#issuecomment-2079310865 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

Re: [PR] list VMs by displayname instead of name [cloudstack]

2024-04-26 Thread via GitHub
DaanHoogland commented on PR #8503: URL: https://github.com/apache/cloudstack/pull/8503#issuecomment-2079309205 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]

2024-04-26 Thread via GitHub
DaanHoogland commented on PR #8243: URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2079306991 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Accept a role ID on linking an account to LDAP [cloudstack]

2024-04-26 Thread via GitHub
DaanHoogland commented on PR #8236: URL: https://github.com/apache/cloudstack/pull/8236#issuecomment-2079306095 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [UI] Storage menu not showing even with API permissions [cloudstack]

2024-04-26 Thread via GitHub
DaanHoogland closed issue #8730: [UI] Storage menu not showing even with API permissions URL: https://github.com/apache/cloudstack/issues/8730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Show menu section if user has access to at least one of its pages [cloudstack]

2024-04-26 Thread via GitHub
DaanHoogland commented on PR #8978: URL: https://github.com/apache/cloudstack/pull/8978#issuecomment-2079299649 > I suppose that the user you created was `cripple`. I verified that it did not have access to `listZones`, which is an API users are unable to login without. This behavior has

(cloudstack) branch main updated: Show menu section if user has access to at least one of its pages (#8978)

2024-04-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 00ee5fd4298 Show menu section if user has access

Re: [PR] Show menu section if user has access to at least one of its pages [cloudstack]

2024-04-26 Thread via GitHub
DaanHoogland merged PR #8978: URL: https://github.com/apache/cloudstack/pull/8978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2079294747 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9446 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] list VMs by displayname instead of name [cloudstack]

2024-04-26 Thread via GitHub
codecov-commenter commented on PR #8503: URL: https://github.com/apache/cloudstack/pull/8503#issuecomment-2079290539 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8503?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

(cloudstack) branch 4.18 updated: linstor: cleanup diskless nodes on disconnect (#8790)

2024-04-26 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new 9d5d4e55648 linstor: cleanup diskless nodes on

Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]

2024-04-26 Thread via GitHub
winterhazel commented on PR #8243: URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2079286992 @DaanHoogland GHI tests are passing now ;) Can you run the CI one last time so we can proceed with this PR? -- This is an automated message from the Apache Git Service. To

Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]

2024-04-26 Thread via GitHub
DaanHoogland merged PR #8790: URL: https://github.com/apache/cloudstack/pull/8790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Accept a role ID on linking an account to LDAP [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8236: URL: https://github.com/apache/cloudstack/pull/8236#issuecomment-2079274145 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9445 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] api: improve listVM API handling and response speed [cloudstack]

2024-04-26 Thread via GitHub
JoaoJandre commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2079269843 Hello @rohityadavcloud , @weizhouapache Looking briefly at this PR I noticed that it has a big intersection with #8782, especially the changes on the listVirtualMachines

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2079270686 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9444 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Show menu section if user has access to at least one of its pages [cloudstack]

2024-04-26 Thread via GitHub
winterhazel commented on PR #8978: URL: https://github.com/apache/cloudstack/pull/8978#issuecomment-2079268907 > @winterhazel @bernardodemarco I tried this in qa: > > ``` > I created a role based on the Read-Only User role. > I denied the role's access to listVirtualMachines,

Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]

2024-04-26 Thread via GitHub
weizhouapache commented on PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#issuecomment-2079265875 @rohityadavcloud I copied the code and run it locally - on mgmt server (with only 1 interface), the `macAddressInLong` value is same as previous legacy code. that is

Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]

2024-04-26 Thread via GitHub
sureshanaparti commented on code in PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1580920735 ## server/src/main/java/com/cloud/storage/StoragePoolAutomationImpl.java: ## @@ -318,9 +323,12 @@ public boolean cancelMaintain(DataStore store) {

(cloudstack) branch main updated: plugin: fix nsx build failure with mvn 3.9 (#8974)

2024-04-26 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 380385d0451 plugin: fix nsx build failure with

Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud merged PR #8974: URL: https://github.com/apache/cloudstack/pull/8974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud commented on code in PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#discussion_r1580918983 ## utils/src/main/java/com/cloud/utils/net/MacAddress.java: ## @@ -79,209 +72,45 @@ public String toString() { static { String macAddress =

Re: [PR] utils: cleanup MacAddress and MacAddressTest [cloudstack]

2024-04-26 Thread via GitHub
rohityadavcloud commented on code in PR #8988: URL: https://github.com/apache/cloudstack/pull/8988#discussion_r1580918983 ## utils/src/main/java/com/cloud/utils/net/MacAddress.java: ## @@ -79,209 +72,45 @@ public String toString() { static { String macAddress =

  1   2   3   >