[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-12 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116166622 ## File path: server/src/com/cloud/vm/UserVmManagerImpl.java ## @@ -3761,6 +3767,8 @@

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-12 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116166347 ## File path: server/src/com/cloud/network/router/NetworkHelperImpl.java ## @@ -171,8

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-12 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116166198 ## File path: server/src/com/cloud/ha/KVMFencer.java ## @@ -98,10 +99,7 @@ public Boolean

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-12 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116166097 ## File path: server/src/com/cloud/api/query/vo/AsyncJobJoinVO.java ## @@ -202,6 +205,14

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-12 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116165984 ## File path: plugins/hypervisors/xenserver/src/com/cloud/ha/XenServerFencer.java ## @@

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-12 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116165915 ## File path: plugins/hypervisors/simulator/src/com/cloud/ha/SimulatorFencer.java ## @@

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-12 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116165314 ## File path:

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-12 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116165085 ## File path: plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmFencer.java ## @@

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-12 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116164905 ## File path:

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-12 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116164729 ## File path: framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-12 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116164374 ## File path: framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-12 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116164295 ## File path: framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-12 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116164162 ## File path: framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-12 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116158218 ## File path: framework/jobs/src/org/apache/cloudstack/framework/jobs/AsyncJobManager.java

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-12 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116158204 ## File path: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ##

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-11 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116151896 ## File path: api/src/com/cloud/exception/OperationTimedoutException.java ## @@ -67,4

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-11 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116151902 ## File path: api/src/org/apache/cloudstack/api/command/user/job/CancelAsyncJobCmd.java ##

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-11 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116151889 ## File path: api/src/com/cloud/exception/OperationTimedoutException.java ## @@ -67,4

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-11 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116151883 ## File path: api/src/com/cloud/exception/OperationTimedoutException.java ## @@ -38,6

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-11 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116151868 ## File path: api/src/com/cloud/exception/AgentUnavailableException.java ## @@ -38,4

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-11 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r116151873 ## File path: api/src/com/cloud/exception/OperationCancelledException.java ## @@ -0,0

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-11 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r115916534 ## File path: framework/jobs/src/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-11 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r115915881 ## File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ## @@

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-11 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r115914969 ## File path: engine/orchestration/src/com/cloud/agent/manager/AgentAttache.java ## @@

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-11 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r115914866 ## File path: engine/components-api/src/com/cloud/agent/AgentManager.java ## @@ -80,9

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-11 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r115914811 ## File path: engine/api/src/com/cloud/vm/VirtualMachineManager.java ## @@ -108,7 +109,7

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-11 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r115914294 ## File path: api/src/org/apache/cloudstack/api/command/user/job/CancelAsyncJobCmd.java ##

[GitHub] karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs

2017-05-09 Thread git
karuturi commented on a change in pull request #1832: CLOUDSTACK-9652 Job framework - Cancelling async jobs URL: https://github.com/apache/cloudstack/pull/1832#discussion_r115656830 ## File path: server/src/com/cloud/server/ManagementServerImpl.java ## @@ -2793,6 +2795,8