[GitHub] [cloudstack] blueorangutan commented on pull request #4114: hypervisor: XCP-ng 8.1 support

blueorangutan commented on pull request #4114: URL: https://github.com/apache/cloudstack/pull/4114#issuecomment-636743913 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] shwstppr commented on pull request #4114: hypervisor: XCP-ng 8.1 support

shwstppr commented on pull request #4114: URL: https://github.com/apache/cloudstack/pull/4114#issuecomment-636743543 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] shwstppr commented on a change in pull request #4114: hypervisor: XCP-ng 8.1 support

shwstppr commented on a change in pull request #4114: URL: https://github.com/apache/cloudstack/pull/4114#discussion_r433140395 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql ## @@ -18,3 +18,10 @@ --; -- Schema upgrade from 4.14.0.0 to

[GitHub] [cloudstack] shwstppr commented on a change in pull request #4114: hypervisor: XCP-ng 8.1 support

shwstppr commented on a change in pull request #4114: URL: https://github.com/apache/cloudstack/pull/4114#discussion_r433142378 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql ## @@ -18,3 +18,12 @@ --; -- Schema upgrade from 4.14.0.0 to

[GitHub] [cloudstack] blueorangutan commented on pull request #4121: [WIP] db: remove TransactionLegacy once it is closed

blueorangutan commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-637215297 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd commented on pull request #4121: [WIP] db: remove TransactionLegacy once it is closed

rhtyd commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-637214940 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd commented on pull request #4121: [WIP] db: remove TransactionLegacy once it is closed

rhtyd commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-637233713 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4121: [WIP] db: remove TransactionLegacy once it is closed

blueorangutan commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-637216413 Packaging result: ✖centos7 ✖debian. JID-1263 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4071: Dynamic roles improvements

sureshanaparti commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r433398348 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/acl/RoleCmd.java ## @@ -18,11 +18,41 @@ package

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4071: Dynamic roles improvements

sureshanaparti commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r433406006 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41310to41400-cleanup.sql ## @@ -26,3 +26,6 @@ UPDATE `cloud`.`storage_pool`

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4071: Dynamic roles improvements

sureshanaparti commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r433408963 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41310to41400.sql ## @@ -379,3 +379,81 @@ CREATE TABLE IF NOT EXISTS

[GitHub] [cloudstack] sureshanaparti commented on pull request #4071: Dynamic roles improvements

sureshanaparti commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-637032225 > First pass review, no major issues; mostly logistics/cosmetics/nits. > Please ping after addressing @sureshanaparti Thanks. @rhyd addressed the comments,

[GitHub] [cloudstack] blueorangutan commented on pull request #4121: [WIP] db: remove TransactionLegacy once it is closed

blueorangutan commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-637013964 Packaging result: ✔centos7 ✔debian. JID-1261 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] rhtyd commented on pull request #4121: [WIP] db: remove TransactionLegacy once it is closed

rhtyd commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-637013422 On big reason why this was not seen before is Java 11 uses G1, perhaps we should move back to ParallelGC - `-XX:+UseParallelGC`

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4071: Dynamic roles improvements

sureshanaparti commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r433404787 ## File path: server/src/main/java/org/apache/cloudstack/acl/RoleManagerImpl.java ## @@ -159,9 +242,6 @@ public Role updateRole(final Role

[GitHub] [cloudstack] blueorangutan commented on pull request #4121: [WIP] db: remove TransactionLegacy once it is closed

blueorangutan commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-637028102 Packaging result: ✔centos7 ✔debian. JID-1262 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] rhtyd commented on pull request #4121: [WIP] db: remove TransactionLegacy once it is closed

rhtyd commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-637028468 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4071: Dynamic roles improvements

sureshanaparti commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r433412427 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41310to41400.sql ## @@ -379,3 +379,81 @@ CREATE TABLE IF NOT EXISTS

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4071: Dynamic roles improvements

sureshanaparti commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r433412175 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41310to41400.sql ## @@ -379,3 +379,81 @@ CREATE TABLE IF NOT EXISTS

[GitHub] [cloudstack] rhtyd commented on pull request #4121: [WIP] db: remove TransactionLegacy once it is closed

rhtyd commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-637015315 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4071: Dynamic roles improvements

sureshanaparti commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r433400535 ## File path: api/src/main/java/org/apache/cloudstack/api/response/RoleResponse.java ## @@ -43,6 +43,10 @@ @Param(description = "the

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4071: Dynamic roles improvements

sureshanaparti commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r433407021 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41310to41400.sql ## @@ -379,3 +379,81 @@ CREATE TABLE IF NOT EXISTS

[GitHub] [cloudstack] blueorangutan commented on pull request #4121: [WIP] db: remove TransactionLegacy once it is closed

blueorangutan commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-637029117 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4071: Dynamic roles improvements

sureshanaparti commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r433412531 ## File path: server/src/main/java/org/apache/cloudstack/acl/RoleManagerImpl.java ## @@ -146,10 +150,89 @@ public RoleVO

[GitHub] [cloudstack] blueorangutan commented on pull request #4121: [WIP] db: remove TransactionLegacy once it is closed

blueorangutan commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-637015898 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4071: Dynamic roles improvements

sureshanaparti commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r433405275 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/acl/ImportRoleCmd.java ## @@ -0,0 +1,139 @@ +// Licensed to the Apache

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4071: Dynamic roles improvements

sureshanaparti commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r433405404 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/acl/ImportRoleCmd.java ## @@ -0,0 +1,139 @@ +// Licensed to the Apache

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4071: Dynamic roles improvements

sureshanaparti commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r433407328 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41310to41400.sql ## @@ -379,3 +379,81 @@ CREATE TABLE IF NOT EXISTS

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4071: Dynamic roles improvements

sureshanaparti commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r433411189 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41310to41400.sql ## @@ -379,3 +379,81 @@ CREATE TABLE IF NOT EXISTS

[GitHub] [cloudstack] mike-tutkowski commented on pull request #3794: create Volume Access Groups per cluster instead of CloudStack-RandomUUID()

mike-tutkowski commented on pull request #3794: URL: https://github.com/apache/cloudstack/pull/3794#issuecomment-636933152 @DaanHoogland First of all, I had to look up iynsho. :) Secondly, it's not technically a blocker. It is just my recommendation on how to improve this one area of the

[GitHub] [cloudstack] rhtyd commented on pull request #4121: [WIP] db: remove TransactionLegacy once it is closed

rhtyd commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-636987317 Now let's try to see what causes DB connection pool to not return a Connection cc @DaanHoogland @nvazquez Thread/CPU/Memory have led to no hints so far, GC and threads have

[GitHub] [cloudstack] rhtyd commented on pull request #4121: [WIP] db: remove TransactionLegacy once it is closed

rhtyd commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-636991695 Commit that removed it - https://github.com/apache/cloudstack/commit/7b7f4cd1fd72ece80a7efecf6d841b293773f726 @blueorangutan package

[GitHub] [cloudstack] blueorangutan commented on pull request #4121: [WIP] db: remove TransactionLegacy once it is closed

blueorangutan commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-637001931 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd opened a new pull request #4121: [WIP] db: remove TransactionLegacy once it is closed

rhtyd opened a new pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121 The TransactionLegacy instances are tracked by TransactionMBeanImpl in a concurrent hashmap. Even when TransactionLegacy instances are closed, the hashmap keep the references and makes it hard

[GitHub] [cloudstack] rhtyd commented on issue #4041: Add API parameter to list unique Templates and Isos

rhtyd commented on issue #4041: URL: https://github.com/apache/cloudstack/issues/4041#issuecomment-636833309 Assigned to @davidjumani This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd commented on pull request #4121: [WIP] db: remove TransactionLegacy once it is closed

rhtyd commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-637001172 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] andrijapanicsb opened a new issue #4120: CKS: Consider the UEFI for the VMs used as nodes

andrijapanicsb opened a new issue #4120: URL: https://github.com/apache/cloudstack/issues/4120 # ISSUE TYPE * Bug Report * Improvement Request * Enhancement Request * Feature Idea * Documentation Report * Other Purely as an enhancement, consider having

[GitHub] [cloudstack] blueorangutan commented on pull request #4114: hypervisor: XCP-ng 8.1 support

blueorangutan commented on pull request #4114: URL: https://github.com/apache/cloudstack/pull/4114#issuecomment-636757764 Packaging result: ✔centos7 ✔debian. JID-1259 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

blueorangutan commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-636789067 @borisstoyanov a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[GitHub] [cloudstack] borisstoyanov commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

borisstoyanov commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-636788793 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4069: Ubuntu 20.04 support (as hypervisor)

blueorangutan commented on pull request #4069: URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-636803646 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on pull request #4069: Ubuntu 20.04 support (as hypervisor)

blueorangutan commented on pull request #4069: URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-636816318 Packaging result: ✔centos7 ✔debian. JID-1260 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] shwstppr commented on pull request #4069: Ubuntu 20.04 support (as hypervisor)

shwstppr commented on pull request #4069: URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-636803211 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] sureshanaparti opened a new pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

sureshanaparti opened a new pull request #4122: URL: https://github.com/apache/cloudstack/pull/4122 Description - Fix to pick the max data volumes limit using the actual hypervisor version, instead of "default" version Changes: - Use the hypervisor version

[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs

blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-637291560 Packaging result: ✔centos7 ✔debian. JID-1264 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] nvazquez commented on pull request #4103: Enable unmanaging guest VMs

nvazquez commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-637281516 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4103: Enable unmanaging guest VMs

blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-637281902 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.