[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null
blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-362630952 Trillian test result (tid-2220) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 17385 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2444-t2220-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_accounts.py Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_iso.py Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py Intermitten failure detected: /marvin/tests/smoke/test_metrics_api.py Intermitten failure detected: /marvin/tests/smoke/test_migration.py Intermitten failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermitten failure detected: /marvin/tests/smoke/test_nested_virtualization.py Intermitten failure detected: /marvin/tests/smoke/test_network_acl.py Intermitten failure detected: /marvin/tests/smoke/test_network.py Intermitten failure detected: /marvin/tests/smoke/test_nic.py Intermitten failure detected: /marvin/tests/smoke/test_over_provisioning.py Intermitten failure detected: /marvin/tests/smoke/test_password_server.py Intermitten failure detected: /marvin/tests/smoke/test_portforwardingrules.py Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_projects.py Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_routers.py Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_usage.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 22 look OK, 45 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_iso_with_checksum_sha1 | `Error` | 65.39 | test_iso.py test_02_create_iso_with_checksum_sha256 | `Error` | 65.40 | test_iso.py test_03_create_iso_with_checksum_md5 | `Error` | 65.40 | test_iso.py test_04_create_iso_with_no_checksum | `Error` | 65.39 | test_iso.py test_01_create_iso | `Failure` | 1513.02 | test_iso.py ContextSuite context=TestISO>:setup | `Error` | 3027.23 | test_iso.py ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py test_DeleteDomain | `Error` | 1.38 | test_accounts.py test_forceDeleteDomain | `Error` | 1.36 | test_accounts.py ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.71 | test_accounts.py
[GitHub] blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check
blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-362626521 Trillian test result (tid-2218) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 17253 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2376-t2218-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_accounts.py Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_iso.py Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py Intermitten failure detected: /marvin/tests/smoke/test_metrics_api.py Intermitten failure detected: /marvin/tests/smoke/test_migration.py Intermitten failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermitten failure detected: /marvin/tests/smoke/test_nested_virtualization.py Intermitten failure detected: /marvin/tests/smoke/test_network_acl.py Intermitten failure detected: /marvin/tests/smoke/test_network.py Intermitten failure detected: /marvin/tests/smoke/test_nic.py Intermitten failure detected: /marvin/tests/smoke/test_over_provisioning.py Intermitten failure detected: /marvin/tests/smoke/test_password_server.py Intermitten failure detected: /marvin/tests/smoke/test_portforwardingrules.py Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_projects.py Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_routers.py Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_usage.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 21 look OK, 46 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_iso_with_checksum_sha1 | `Error` | 65.43 | test_iso.py test_02_create_iso_with_checksum_sha256 | `Error` | 65.44 | test_iso.py test_03_create_iso_with_checksum_md5 | `Error` | 65.47 | test_iso.py test_04_create_iso_with_no_checksum | `Error` | 65.43 | test_iso.py test_01_create_iso | `Failure` | 1514.14 | test_iso.py ContextSuite context=TestISO>:setup | `Error` | 3029.69 | test_iso.py ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py test_DeleteDomain | `Error` | 1.74 | test_accounts.py test_forceDeleteDomain | `Error` | 1.69 | test_accounts.py ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 6.10 | test_accounts.py ContextSuite
[GitHub] blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check
blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-362616782 Trillian test result (tid-2217) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 6 Total time taken: 15361 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2376-t2217-xenserver-71.zip Intermitten failure detected: /marvin/tests/smoke/test_accounts.py Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_iso.py Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py Intermitten failure detected: /marvin/tests/smoke/test_metrics_api.py Intermitten failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermitten failure detected: /marvin/tests/smoke/test_nested_virtualization.py Intermitten failure detected: /marvin/tests/smoke/test_network_acl.py Intermitten failure detected: /marvin/tests/smoke/test_network.py Intermitten failure detected: /marvin/tests/smoke/test_nic.py Intermitten failure detected: /marvin/tests/smoke/test_over_provisioning.py Intermitten failure detected: /marvin/tests/smoke/test_password_server.py Intermitten failure detected: /marvin/tests/smoke/test_portforwardingrules.py Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_projects.py Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_routers.py Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_usage.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 23 look OK, 44 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_iso_with_checksum_sha1 | `Error` | 65.77 | test_iso.py test_02_create_iso_with_checksum_sha256 | `Error` | 65.62 | test_iso.py test_03_create_iso_with_checksum_md5 | `Error` | 65.68 | test_iso.py test_04_create_iso_with_no_checksum | `Error` | 66.17 | test_iso.py test_01_create_iso | `Failure` | 1518.18 | test_iso.py ContextSuite context=TestISO>:setup | `Error` | 3036.12 | test_iso.py ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py test_DeleteDomain | `Error` | 1.66 | test_accounts.py test_forceDeleteDomain | `Error` | 1.71 | test_accounts.py ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 6.13 | test_accounts.py ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 6.40 | test_accounts.py ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null
blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-362555052 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null
rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-362554954 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check
blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-362550943 @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2376: [4.11/master] Smoketest Health Check
rhtyd commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-362550910 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null
blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-362550533 Packaging result: ?centos6 ?centos7 ?debian. JID-1689 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check
blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-362547966 Packaging result: ?centos6 ?centos7 ?debian. JID-1688 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null
rhtyd commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-362544096 Roles related tests pass: ``` Test to ensure 4 default roles cannot be deleted ... === TestName: test_default_role_deletion | Status : SUCCESS === ok Test to check role, role permissions and account life cycles ... === TestName: test_role_account_acls | Status : SUCCESS === ok Test for role-rule enforcement in case of multiple mgmt servers ... === TestName: test_role_account_acls_multiple_mgmt_servers | Status : SUCCESS === ok Test to ensure role in use cannot be deleted ... === TestName: test_role_inuse_deletion | Status : SUCCESS === ok Tests normal lifecycle operations for roles ... === TestName: test_role_lifecycle_create | Status : SUCCESS === ok Tests role update ... === TestName: test_role_lifecycle_delete | Status : SUCCESS === ok Tests that default four roles exist ... === TestName: test_role_lifecycle_list | Status : SUCCESS === ok Tests role update ... === TestName: test_role_lifecycle_update | Status : SUCCESS === ok Tests role update when role is in use by an account ... === TestName: test_role_lifecycle_update_role_inuse | Status : SUCCESS === ok Tests concurrent order updation of role permission ... === TestName: test_rolepermission_lifecycle_concurrent_updates | Status : SUCCESS === ok Tests creation of role permission ... === TestName: test_rolepermission_lifecycle_create | Status : SUCCESS === ok Tests deletion of role permission ... === TestName: test_rolepermission_lifecycle_delete | Status : SUCCESS === ok Tests listing of default role's permission ... === TestName: test_rolepermission_lifecycle_list | Status : SUCCESS === ok Tests order updation of role permission ... === TestName: test_rolepermission_lifecycle_update | Status : SUCCESS === ok Tests update of Allow to Deny permission of a rule ... === TestName: test_rolepermission_lifecycle_update_permission | Status : SUCCESS === ok Tests negative test for setting incorrect value as permission ... === TestName: test_rolepermission_lifecycle_update_permission_negative | Status : SUCCESS === ok -- Ran 16 tests in 33.095s ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd opened a new pull request #2444: CLOUDSTACK-10269: On deletion of role set name to null
rhtyd opened a new pull request #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444 During deletion of role, set name to null. This fixes concurrent exception issue where previously it would rename the deleted role with a timestamp. Pinging for review - @DaanHoogland @nvazquez @borisstoyanov and others. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null
blueorangutan commented on issue #2444: CLOUDSTACK-10269: On deletion of role set name to null URL: https://github.com/apache/cloudstack/pull/2444#issuecomment-362544043 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check
blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-362540147 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2376: [4.11/master] Smoketest Health Check
rhtyd commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-362539915 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds
DaanHoogland commented on a change in pull request #2244:
CLOUDSTACK-10054:Volume download times out in 3600 seconds
URL: https://github.com/apache/cloudstack/pull/2244#discussion_r165599968
##
File path: core/src/main/java/com/cloud/storage/template/QCOW2Processor.java
##
@@ -40,6 +40,11 @@
private StorageLayer _storage;
+ @Override
+ public FormatInfo process(String templatePath, ImageFormat format, String
templateName, long processTimeout) throws InternalErrorException {
+ return process(templatePath, format, templateName);
Review comment:
this is not right. it closes the door for implementing this for KVM (and
other below) If this is really not applicable for any format but the VMware/OVA
bit it should not be on the generic interface.
If we do expect future implementation teh call hierarchy must be reversed:
the specific version calling the more generic one.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds
DaanHoogland commented on a change in pull request #2244:
CLOUDSTACK-10054:Volume download times out in 3600 seconds
URL: https://github.com/apache/cloudstack/pull/2244#discussion_r165599968
##
File path: core/src/main/java/com/cloud/storage/template/QCOW2Processor.java
##
@@ -40,6 +40,11 @@
private StorageLayer _storage;
+ @Override
+ public FormatInfo process(String templatePath, ImageFormat format, String
templateName, long processTimeout) throws InternalErrorException {
+ return process(templatePath, format, templateName);
Review comment:
this is not right. it closes the door for implementing this for KVM (and
other below) If this is really not applicable for any format but the VMware/OVA
bit it should not be on the generic interface.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] houthuis opened a new pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's
houthuis opened a new pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's URL: https://github.com/apache/cloudstack/pull/2442 ENVIRONMENT = XenServer Version : 6.2 , 7 ISSUE == Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are still active Repro. steps followed == Disabled Cluster from UI. Deploy a new VM Expected Behavior === After disabling the cluster , the hosts should be disabled. and no VM's can be deployed Note: it's the same results for XenServer or simulator, can't deploy on disabled hosts, but can deploy on disabled cluster Solution: Added a check to skip disabled clusters when selecting a host to deploy on. Deploying on a disabled cluster will now result in a InsufficientServerCapacityException, if no enabled clusters are found. i didn't want to propagate disabling a cluster down to the hosts, because then you would have to enable all the hosts again when you enable the cluster, and we won't know which hosts should be left in a disabled state This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houthuis closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's
houthuis closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster
can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
index cc244ce41ba..5d8ad0a7051 100644
--- a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
+++ b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
@@ -1040,6 +1040,11 @@ private DeployDestination
checkClustersforDestination(List clusterList, Vi
for (Long clusterId : clusterList) {
ClusterVO clusterVO = _clusterDao.findById(clusterId);
+if (clusterVO.getAllocationState() ==
Grouping.AllocationState.Disabled) {
+s_logger.debug("Cannot deploy in disabled cluster " +
clusterId + ", skipping this cluster");
+avoid.addCluster(clusterVO.getId());
+}
+
if (clusterVO.getHypervisorType() !=
vmProfile.getHypervisorType()) {
s_logger.debug("Cluster: " + clusterId + " has HyperVisorType
that does not match the VM, skipping this cluster");
avoid.addCluster(clusterVO.getId());
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly
DaanHoogland commented on issue #2443: [CLOUDSTACK-9338] ACS is not accounting resources of VMs with custom service offering properly URL: https://github.com/apache/cloudstack/pull/2443#issuecomment-362529970 As @bwsw (wow a company involved) says, accounting is important and needs a lot of tlc. If we don't make regression tests and write fix over fix, regressions are bound to happen, @rafaelweingartner . So if you have the mental and clock space for it , please do. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houthuis opened a new pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's
houthuis opened a new pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's URL: https://github.com/apache/cloudstack/pull/2442 ENVIRONMENT = XenServer Version : 6.2 , 7 ISSUE == Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are still active Repro. steps followed == Disabled Cluster from UI. Deploy a new VM Expected Behavior === After disabling the cluster , the hosts should be disabled. and no VM's can be deployed Note: it's the same results for XenServer or simulator, can't deploy on disabled hosts, but can deploy on disabled cluster Solution: Added a check to skip disabled clusters when selecting a host to deploy on. Deploying on a disabled cluster will now result in a InsufficientServerCapacityException, if no enabled clusters are found. i didn't want to propagate disabling a cluster down to the hosts, because then you would have to enable all the hosts again when you enable the cluster, and we won't know which hosts should be left in a disabled state This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houthuis closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's
houthuis closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster
can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
index cc244ce41ba..5d8ad0a7051 100644
--- a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
+++ b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
@@ -1040,6 +1040,11 @@ private DeployDestination
checkClustersforDestination(List clusterList, Vi
for (Long clusterId : clusterList) {
ClusterVO clusterVO = _clusterDao.findById(clusterId);
+if (clusterVO.getAllocationState() ==
Grouping.AllocationState.Disabled) {
+s_logger.debug("Cannot deploy in disabled cluster " +
clusterId + ", skipping this cluster");
+avoid.addCluster(clusterVO.getId());
+}
+
if (clusterVO.getHypervisorType() !=
vmProfile.getHypervisorType()) {
s_logger.debug("Cluster: " + clusterId + " has HyperVisorType
that does not match the VM, skipping this cluster");
avoid.addCluster(clusterVO.getId());
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] houthuis closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's
houthuis closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster
can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
index cc244ce41ba..5d8ad0a7051 100644
--- a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
+++ b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
@@ -1040,6 +1040,11 @@ private DeployDestination
checkClustersforDestination(List clusterList, Vi
for (Long clusterId : clusterList) {
ClusterVO clusterVO = _clusterDao.findById(clusterId);
+if (clusterVO.getAllocationState() ==
Grouping.AllocationState.Disabled) {
+s_logger.debug("Cannot deploy in disabled cluster " +
clusterId + ", skipping this cluster");
+avoid.addCluster(clusterVO.getId());
+}
+
if (clusterVO.getHypervisorType() !=
vmProfile.getHypervisorType()) {
s_logger.debug("Cluster: " + clusterId + " has HyperVisorType
that does not match the VM, skipping this cluster");
avoid.addCluster(clusterVO.getId());
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] houthuis opened a new pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's
houthuis opened a new pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's URL: https://github.com/apache/cloudstack/pull/2442 ENVIRONMENT = XenServer Version : 6.2 , 7 ISSUE == Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are still active Repro. steps followed == Disabled Cluster from UI. Deploy a new VM Expected Behavior === After disabling the cluster , the hosts should be disabled. and no VM's can be deployed Note: it's the same results for XenServer or simulator, can't deploy on disabled hosts, but can deploy on disabled cluster Solution: Added a check to skip disabled clusters when selecting a host to deploy on. Deploying on a disabled cluster will now result in a InsufficientServerCapacityException, if no enabled clusters are found. i didn't want to propagate disabling a cluster down to the hosts, because then you would have to enable all the hosts again when you enable the cluster, and we won't know which hosts should be left in a disabled state This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houthuis opened a new pull request #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT
houthuis opened a new pull request #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT URL: https://github.com/apache/cloudstack/pull/2382 added a check for network state when determining whether a new IP should be source NAT. this prevents associated IP's to be marked as source NAT when the network is in allocated state, causing disassociateIpAddress to fail later Code will now throw a InvalidParameterValueException in the above scenario. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houthuis closed pull request #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT
houthuis closed pull request #2382: CLOUDSTACK-4045 IP address acquired with
associateIpAddress is marked as source NAT
URL: https://github.com/apache/cloudstack/pull/2382
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
b/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
index c00359c92f0..d0b3098c3d3 100644
--- a/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
+++ b/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java
@@ -1370,16 +1370,7 @@ public IPAddressVO associateIPToGuestNetwork(long ipId,
long networkId, boolean
}
}
-NetworkOffering offering =
_networkOfferingDao.findById(network.getNetworkOfferingId());
-boolean sharedSourceNat = offering.getSharedSourceNat();
-boolean isSourceNat = false;
-if (!sharedSourceNat) {
-if (getExistingSourceNatInNetwork(owner.getId(), networkId) ==
null) {
-if (network.getGuestType() == GuestType.Isolated &&
network.getVpcId() == null && !ipToAssoc.isPortable()) {
-isSourceNat = true;
-}
-}
-}
+boolean isSourceNat = isSourceNatAvailableForNetwork(owner, ipToAssoc,
network);
s_logger.debug("Associating ip " + ipToAssoc + " to network " +
network);
@@ -1417,6 +1408,25 @@ public IPAddressVO associateIPToGuestNetwork(long ipId,
long networkId, boolean
}
}
+protected boolean isSourceNatAvailableForNetwork(Account owner,
IPAddressVO ipToAssoc, Network network) {
+NetworkOffering offering =
_networkOfferingDao.findById(network.getNetworkOfferingId());
+boolean sharedSourceNat = offering.getSharedSourceNat();
+boolean isSourceNat = false;
+if (!sharedSourceNat) {
+if (getExistingSourceNatInNetwork(owner.getId(), network.getId())
== null) {
+if (network.getGuestType() == GuestType.Isolated &&
network.getVpcId() == null && !ipToAssoc.isPortable()) {
+if (network.getState() == Network.State.Allocated) {
+//prevent associating an ip address to an allocated
(unimplemented network).
+//it will cause the ip to become source nat, and it
can't be disassociated later on.
+throw new InvalidParameterValueException("Network is
in allocated state, implement network first before acquiring an IP address");
+}
+isSourceNat = true;
+}
+}
+}
+return isSourceNat;
+}
+
protected boolean isSharedNetworkOfferingWithServices(long
networkOfferingId) {
NetworkOfferingVO networkOffering =
_networkOfferingDao.findById(networkOfferingId);
if ((networkOffering.getGuestType() == Network.GuestType.Shared)
diff --git a/server/src/test/java/com/cloud/network/IpAddressManagerTest.java
b/server/src/test/java/com/cloud/network/IpAddressManagerTest.java
index 0bf92ee2f69..fe11292e826 100644
--- a/server/src/test/java/com/cloud/network/IpAddressManagerTest.java
+++ b/server/src/test/java/com/cloud/network/IpAddressManagerTest.java
@@ -17,38 +17,74 @@
package com.cloud.network;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.network.dao.IPAddressDao;
+import com.cloud.network.dao.IPAddressVO;
+import com.cloud.network.dao.NetworkDao;
+import com.cloud.network.dao.NetworkVO;
+import com.cloud.network.rules.StaticNat;
+import com.cloud.network.rules.StaticNatImpl;
+import com.cloud.offerings.NetworkOfferingVO;
+import com.cloud.offerings.dao.NetworkOfferingDao;
+import com.cloud.user.AccountVO;
+import com.cloud.utils.net.Ip;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import org.mockito.InjectMocks;
import org.mockito.Mock;
+import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
-
-import com.cloud.network.dao.IPAddressDao;
-import com.cloud.network.dao.IPAddressVO;
-import com.cloud.network.rules.StaticNat;
-import com.cloud.network.rules.StaticNatImpl;
-import com.cloud.utils.net.Ip;
-
-import static org.mockito.Mockito.when;
+import org.mockito.Spy;
import java.util.Collections;
import java.util.List;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
import static org.mockito.Mockito.anyLong;
+import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
public class IpAddressManagerTest {
@Mock
IPAddressDao _ipAddrDao;
+@Mock
+NetworkDao
