Re: [PR] Fix null pointer exception in restore VM [cloudstack]
codecov-commenter commented on PR #8930: URL: https://github.com/apache/cloudstack/pull/8930#issuecomment-2063036340 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8930?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `0%` with `2 lines` in your changes are missing coverage. Please review. > Project coverage is 17.35%. Comparing base [(`c25264b`)](https://app.codecov.io/gh/apache/cloudstack/commit/c25264bada3b84118b4b20720426625bf6e4b1c0?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`54c5f67`)](https://app.codecov.io/gh/apache/cloudstack/pull/8930?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 17 commits behind head on 4.19. > :exclamation: Current head 54c5f67 differs from pull request most recent head 8109d69. Consider uploading reports for the commit 8109d69 to get more accurate results | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8930?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [.../src/main/java/com/cloud/vm/UserVmManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/8930?src=pr=tree=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fvm%2FUserVmManagerImpl.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXJJbXBsLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8930?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19#8930 +/- ## = - Coverage 30.98% 17.35% -13.63% + Complexity3440815771-18637 = Files 5359 4863 -496 Lines377017 326030-50987 Branches 5485645839 -9017 = - Hits 11680456586-60218 - Misses 244852 261236+16384 + Partials 15361 8208 -7153 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8930/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8930/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `17.35% <0.00%> (-7.46%)` | :arrow_down: | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8930/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8930/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8930?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix null pointer exception in restore VM [cloudstack]
blueorangutan commented on PR #8930: URL: https://github.com/apache/cloudstack/pull/8930#issuecomment-2063035354 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix null pointer exception in restore VM [cloudstack]
vishesh92 commented on PR #8930: URL: https://github.com/apache/cloudstack/pull/8930#issuecomment-2063034798 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) 01/01: Merge remote-tracking branch 'origin/4.18' into 4.19
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit cadbb563afaa907a45e8931cb8a95e8ca5b8f034 Merge: 85110147071 8a101fbbc11 Author: Rohit Yadav AuthorDate: Thu Apr 18 10:21:54 2024 +0530 Merge remote-tracking branch 'origin/4.18' into 4.19
(cloudstack) branch 4.19 updated (85110147071 -> cadbb563afa)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 85110147071 Fix error message for checkVolume command (#8842) add 154566f914c Updating pom.xml version numbers for release 4.18.2.0 add 8a101fbbc11 Updating pom.xml version numbers for release 4.18.3.0-SNAPSHOT new cadbb563afa Merge remote-tracking branch 'origin/4.18' into 4.19 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes:
Re: [PR] Allow kvm storage plugin to customize diskdef, add geometry [cloudstack]
blueorangutan commented on PR #8839: URL: https://github.com/apache/cloudstack/pull/8839#issuecomment-2062838034 [SF] Trillian test result (tid-9878) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 52051 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8839-t9878-kvm-alma9.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 328.67 | test_events_resource.py test_01_events_resource | `Error` | 328.68 | test_events_resource.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 89.78 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.53 | test_network_permissions.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix null pointer exception in restore VM [cloudstack]
blueorangutan commented on PR #8930: URL: https://github.com/apache/cloudstack/pull/8930#issuecomment-2062826968 [SF] Trillian test result (tid-9883) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47528 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8930-t9883-kvm-centos7.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 411.74 | test_events_resource.py test_02_trigger_shutdown | `Failure` | 346.70 | test_safe_shutdown.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2062825827 [SF] Trillian test result (tid-9884) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45095 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8911-t9884-kvm-centos7.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 296.55 | test_events_resource.py test_01_events_resource | `Error` | 296.56 | test_events_resource.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 85.55 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.39 | test_network_permissions.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2062814169 [SF] Trillian test result (tid-9880) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49576 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7235-t9880-kvm-centos7.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_extract_Iso | `Failure` | 1.09 | test_iso.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ability to set cpu.threadspercore similar to existing cpu.corespersocket [cloudstack]
blueorangutan commented on PR #8850: URL: https://github.com/apache/cloudstack/pull/8850#issuecomment-2062811152 [SF] Trillian test result (tid-9879) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50158 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8850-t9879-kvm-centos7.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_trigger_shutdown | `Failure` | 346.71 | test_safe_shutdown.py test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.05 | test_ssvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] protect against null-path [cloudstack]
blueorangutan commented on PR #8915: URL: https://github.com/apache/cloudstack/pull/8915#issuecomment-2062732668 [SF] Trillian test result (tid-9877) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9 Total time taken: 46074 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8915-t9877-vmware-70u3.zip Smoke tests completed. 109 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_list_cpvm_vm | `Failure` | 0.05 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.07 | test_ssvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix migration from local storage to NFS in KVM [cloudstack]
blueorangutan commented on PR #8909: URL: https://github.com/apache/cloudstack/pull/8909#issuecomment-2062722778 [SF] Trillian test result (tid-9875) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46521 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8909-t9875-kvm-centos7.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 296.90 | test_events_resource.py test_01_events_resource | `Error` | 296.91 | test_events_resource.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 84.97 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.43 | test_network_permissions.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add logs to CPVM connection process [cloudstack]
bernardodemarco commented on PR #8924: URL: https://github.com/apache/cloudstack/pull/8924#issuecomment-2062446576 @DaanHoogland, thanks for your review! As logging standards in CloudStack are still under discussion (#8746), I'd rather keep logging the exceptions stacktraces at the `error` level. Honestly, I do not see the point in turning off the stacktraces at the `error` level. For operators that have a minimum software development background, the stacktraces can be a useful way to perform troubleshooting processes. On the other hand, if the operator has no knowledge of development, he might not understand the stacktraces, and that is fine, causing no harm. Besides that, following along with what you've proposed in #8746, what happens when the operator chooses to turn the stacktraces down by setting the logs level to `error`? Are all exception logs be lost, since they are gonna be at `debug` level? If so, the difficulty of performing troubleshootings would increase significantly, as some errors/problems might be difficult to reproduce. Honestly, I'm looking forward to see the outcome of the #8746 discussion and I commit myself to participate on it. However, as I've mentioned before, I'd rather keep the proposed changes related to the stacktraces at the `error` level the way they are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]
sureshanaparti commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-2062158383 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Download Volume Snapshots [cloudstack]
gpordeus commented on PR #8878: URL: https://github.com/apache/cloudstack/pull/8878#issuecomment-2062139592 > Can you add unit tests for the new method added? @RodrigoDLopez Added them, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
blueorangutan commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2062092996 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Draft: Add logs to CPVM connection process [cloudstack]
github-actions[bot] commented on PR #8924: URL: https://github.com/apache/cloudstack/pull/8924#issuecomment-2062092698 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
weizhouapache commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2062089592 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-2062057457 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
blueorangutan commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2061987889 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix `deleteAccount` API to prevent deletion of the caller [cloudstack]
weizhouapache commented on PR #8743: URL: https://github.com/apache/cloudstack/pull/8743#issuecomment-2061970915 > Hey @weizhouapache, > > Are there any further concerns regarding this implementation or can we move on this PR? @lucas-a-martins sorry I missed your reply. looks good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] refactor configuration SystemVMDefaultHypervisor [cloudstack]
GaOrtiga opened a new pull request, #8934:
URL: https://github.com/apache/cloudstack/pull/8934
### Description
The configuration `SystemVMDefaultHypervisor` is not dynamic, it is
necessary to restart the management server after each alteration to its value.
Besides, its input is a String, which forces the user to type in the name of
the chosen hypervisor, being subject to typos.
This configuration was refactored, allowing its value to be altered in
runtime; besides, its input was converted to a select, in order to facilitate
the process of choosing the new value.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [X] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### How Has This Been Tested?
I changed the values of the configurations and verified that the default
hypervisors for new system vms changed accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-2061922000 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]
sureshanaparti commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-2061920326 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19-dummy updated (1770204568b -> dfebc09f947)
This is an automated email from the ASF dual-hosted git repository. sureshanaparti pushed a change to branch 4.19-dummy in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 1770204568b do not merge add f25d35c5d6b VM Import: Use datastore name when datastore path is not set to search for pools on DB (#8759) add d487a1c3417 Fix disk offering override in VM deployment wizard (#8070) add f8fd22c2d62 Usage: Fixup entity exists exception (#8726) add 0780f0e5c61 Merge remote-tracking branch 'apache/4.18' into 4.19 add e0731c50985 Fix the removal of network offering tags (#8758) add 9acba904237 Fix 404 when moving a VM to out of a project (#8650) add ffd59720dd8 storage,plugins: delegate allow zone-wide volume migration check and access grant check to storage drivers (#8762) add 0043540fa30 Use join instead of views (#8321) add 9d748f0837f server: update default value of setting 'expose.dns.externally' to 'false' (#8776) add fe5d7412364 Merge branch '4.18' into '4.19' add 720407ba737 snapshot: don't schedule next snapshot job for a removed volume (#8735) add 8c62365dbb1 VPC VR: fix empty iptables if there is no vpc tier (#8787) add 308ed1399ee Merge remote-tracking branch 'origin/4.18' into 4.19 add 24d5c45f7f4 Add indexes for vm_stats (#8737) add 2e88eb45a3b Update mysql-connector version (#8753) add 88017ad45e3 Fix Virtual router count in Capacity dashboard (#8807) add f4058705d7b UI: add dialog to select a VPC tier when create LB for autoscaling in VPC (#8793) add 08d9d06d453 api,server,ui: add project ID and name to UserDataResponse (#8656) add 31301f56f64 Fix missing actions on Guest IP ranges for networks (#8777) add 6c6023b790c UI: Fix irrelevant conversion options in import instance modal (#8838) add f7603dcbcc8 AllLinesParser: Enable draining of stdout (#8670) add 38f028613fc Fix getRepair method in checkVolume command (#8840) add fc3c625beba server: fix security issues caused by extraconfig on KVM add 67e2061f4b8 api: client verification in servlet add 939d0b9011a engine-storage: control download redirection add 72b2eb0087f server: fix security issues caused by extraconfig on KVM add 00f687db1be api: client verification in servlet add b642500f153 Merge remote-tracking branch 'origin/4.18' into 4.19 add ff3e9bd821f engine-storage: control download redirection add 16aba6b5881 Merge remote-tracking branch 'origin/4.18' into 4.19 add 7a9985b42bf upgrade: add unit tests from/to a security release (#8870) add f2da882d68f Merge remote-tracking branch 'origin/4.18' into 4.19 add b8f8321f0f9 Allow listing of inactive offerings (#8821) add c25264bada3 UI Fixes: allow filtering on alertype in UI & add events tab (#8630) add a5508acc54d server: fix haproxy misconfiguration after VPC VR start (#8881) add c7626ebfd63 Merge remote-tracking branch 'apache/4.18' into 4.19 add c24c1a5c000 Fix VM import & VM delete with custom offering (#8813) add 730cc5d5b8f Change iops on offering change (#8872) add d3e020a5452 Mark libvirt events experimental, add properties flag (#8825) add b998e7dbb63 Allow overriding root disk offering & size, and expunge old root disk while restoring a VM (#8800) add 44aa08c02a3 Fixup 4.19 build issue (#8905) add 0a26f3315a1 Fix listStoragePoolsMetricsCmd (#8885) add 6cd5c6a1d01 linstor: Do not pretend handling disconnect paths that are non Linstor (#8897) add a55ba96a08e Merge remote-tracking branch 'origin/4.18' into 4.19 add 075b4130412 Fix VR inheriting boot settings from user's VM (#8894) add 7721133ea9a Fix display of properties related to backup size (#8845) add 44b8d3af0ca ui: bump UI dependencies versions (#8923) add 85110147071 Fix error message for checkVolume command (#8842) add dfebc09f947 Merge branch '4.19' into 4.19-dummy No new revisions were added by this update. Summary of changes: agent/conf/agent.properties|4 + .../cloud/agent/properties/AgentProperties.java|7 + .../java/com/cloud/offering/ServiceOffering.java |2 +- .../java/com/cloud/storage/VolumeApiService.java |2 + api/src/main/java/com/cloud/vm/UserVmService.java |2 +- .../java/com/cloud/vm/VirtualMachineProfile.java |2 + .../org/apache/cloudstack/acl/RoleService.java |4 +- .../org/apache/cloudstack/alert/AlertService.java |4 + .../apache/cloudstack/api/InternalIdentity.java| 14 + .../admin/acl/project/CreateProjectRoleCmd.java| 10 + .../project/CreateProjectRolePermissionCmd.java| 11 + .../admin/acl/project/DeleteProjectRoleCmd.java| 11 + .../project/DeleteProjectRolePermissionCmd.java| 11 + .../admin/acl/project/UpdateProjectRoleCmd.java| 11 + .../project/UpdateProjectRolePermissionCmd.java| 11 +
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2061913833 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix `deleteAccount` API to prevent deletion of the caller [cloudstack]
lucas-a-martins commented on PR #8743: URL: https://github.com/apache/cloudstack/pull/8743#issuecomment-2061892867 Hey @weizhouapache, Are there any further concerns regarding this implementation or can we move on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
blueorangutan commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2061858935 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
weizhouapache closed pull request #8933: server: fix duplicated records for templates if there are multiple zones URL: https://github.com/apache/cloudstack/pull/8933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
weizhouapache commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2061852765 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]
blueorangutan commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2061792144 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]
DaanHoogland commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2061788892 @blueorangutan test alma9 kvm-alma9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
svn commit: r68611 - /dev/cloudstack/4.18.2.0/ /release/cloudstack/releases/4.18.2.0/
Author: dahn Date: Wed Apr 17 16:45:04 2024 New Revision: 68611 Log: Publishing 4.18.2.0 release Added: release/cloudstack/releases/4.18.2.0/ - copied from r68610, dev/cloudstack/4.18.2.0/ Removed: dev/cloudstack/4.18.2.0/
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
weizhouapache commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2061633059 > @DaanHoogland looks like it's still failing on this codecov plugin, is there something misconfigured in the actions for the build workflow? Nothing was changed in this PR related to those items. I would think this is showing up for other PR's as well. > Ignore the codecov errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a shutdownhook to remove jobs owned by the process [cloudstack]
vladimirpetrov commented on PR #8896: URL: https://github.com/apache/cloudstack/pull/8896#issuecomment-2061534875 Not sure if this can be avoided but when the usage server is killed (with -9, simulating crash), this machanism no longer works - the old entry stays in the db and a new one (with the new pid) is not created when the server is started again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
rg9975 commented on PR #8889:
URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2061532951
@DaanHoogland looks like it's still failing on this codecov plugin, is there
something misconfigured in the actions for the build workflow? Nothing was
changed in this PR related to those items. I would think this is showing up
for other PR's as well.
[2024-04-17T15:15:37.873Z] ['info'] Pinging Codecov:
https://codecov.io/upload/v4?package=github-action-3.1.6-uploader-0.7.3=***=4.19=8603324714_url=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Factions%2Fruns%2F8603324714%2Fjob%2F23934642703=11bfad7a56fcd6b07233f8f6afd812fe79d87b13=UI+Build=8889=github-actions=apache%2Fcloudstack=codecov==uitests=
[2024-04-17T15:15:37.873Z] ['verbose'] Passed token was 0 characters long
[2024-04-17T15:15:37.873Z] ['verbose']
https://codecov.io/upload/v4?package=github-action-3.1.6-uploader-0.7.3=4.19=8603324714_url=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Factions%2Fruns%2F8603324714%2Fjob%2F23934642703=11bfad7a56fcd6b07233f8f6afd812fe79d87b13=UI+Build=8889=github-actions=apache%2Fcloudstack=codecov==uitests=
Content-Type: 'text/plain'
Content-Encoding: 'gzip'
X-Reduced-Redundancy: 'false'
[2024-04-17T15:15:38.075Z] ['error'] There was an error running the
uploader: Error uploading to https://codecov.io: Error: There was an error
fetching the storage URL during POST: 404 - {'detail':
ErrorDetail(string='Unable to locate build via Github Actions API. Please
upload with the Codecov repository upload token to resolve issue.',
code='not_found')}
[2024-04-17T15:15:38.075Z] ['verbose'] The error stack is: Error: Error
uploading to https://codecov.io: Error: There was an error fetching the storage
URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build
via Github Actions API. Please upload with the Codecov repository upload token
to resolve issue.', code='not_found')}
at main (/snapshot/repo/dist/src/index.js)
at process.processTicksAndRejections
(node:internal/process/task_queues:[95](https://github.com/apache/cloudstack/actions/runs/8603324698/job/23934641419?pr=8889#step:6:96):5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
weizhouapache commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2061494703 > @DaanHoogland is there something holding up approving these workflows? approved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
weizhouapache opened a new pull request, #8933:
URL: https://github.com/apache/cloudstack/pull/8933
### Description
This PR fixes #8928
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
rg9975 commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2061442318 @DaanHoogland is there something holding up approving these workflows? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
weizhouapache commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2061441566 This fixes a bug in #7659 cc @BryanMLima -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Removed deprecated instruction MAINTAINER [cloudstack]
github-actions[bot] commented on PR #8846: URL: https://github.com/apache/cloudstack/pull/8846#issuecomment-2061429305 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated: build: fix build failure after merge-forward
This is an automated email from the ASF dual-hosted git repository.
weizhou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 38ca11f99ac build: fix build failure after merge-forward
38ca11f99ac is described below
commit 38ca11f99ac1ec804694f2383607bcaf4c467ccd
Author: Wei Zhou
AuthorDate: Wed Apr 17 16:40:31 2024 +0200
build: fix build failure after merge-forward
---
.../cloud/hypervisor/kvm/resource/LibvirtDomainListener.java | 5 +++--
.../wrapper/LibvirtCheckAndRepairVolumeCommandWrapper.java| 11 ---
2 files changed, 7 insertions(+), 9 deletions(-)
diff --git
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtDomainListener.java
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtDomainListener.java
index 281de01c5da..5adb383c6cd 100644
---
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtDomainListener.java
+++
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtDomainListener.java
@@ -15,7 +15,8 @@
package com.cloud.hypervisor.kvm.resource;
import com.cloud.resource.AgentStatusUpdater;
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
import org.libvirt.Domain;
import org.libvirt.LibvirtException;
import org.libvirt.event.DomainEvent;
@@ -24,7 +25,7 @@ import org.libvirt.event.LifecycleListener;
import org.libvirt.event.StoppedDetail;
public class LibvirtDomainListener implements LifecycleListener {
-private static final Logger LOGGER =
Logger.getLogger(LibvirtDomainListener.class);
+private static final Logger LOGGER =
LogManager.getLogger(LibvirtDomainListener.class);
private final AgentStatusUpdater agentStatusUpdater;
diff --git
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCheckAndRepairVolumeCommandWrapper.java
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCheckAndRepairVolumeCommandWrapper.java
index cd81a2fbc23..8dcdd09beb2 100644
---
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCheckAndRepairVolumeCommandWrapper.java
+++
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCheckAndRepairVolumeCommandWrapper.java
@@ -42,7 +42,6 @@ import org.apache.cloudstack.utils.qemu.QemuObject;
import org.apache.cloudstack.utils.qemu.QemuObject.EncryptFormat;
import org.apache.commons.lang.ArrayUtils;
import org.apache.commons.lang3.StringUtils;
-import org.apache.log4j.Logger;
import org.libvirt.LibvirtException;
import java.io.IOException;
@@ -53,8 +52,6 @@ import java.util.List;
@ResourceWrapper(handles = CheckAndRepairVolumeCommand.class)
public class LibvirtCheckAndRepairVolumeCommandWrapper extends
CommandWrapper {
-private static final Logger s_logger =
Logger.getLogger(LibvirtCheckAndRepairVolumeCommandWrapper.class);
-
@Override
public Answer execute(CheckAndRepairVolumeCommand command,
LibvirtComputingResource serverResource) {
final String volumeId = command.getPath();
@@ -105,7 +102,7 @@ public class LibvirtCheckAndRepairVolumeCommandWrapper
extends CommandWrapper
(cloudstack) branch 4.18.2.0-RC20240412T0825 deleted (was 154566f914c)
This is an automated email from the ASF dual-hosted git repository. joao pushed a change to branch 4.18.2.0-RC20240412T0825 in repository https://gitbox.apache.org/repos/asf/cloudstack.git was 154566f914c Updating pom.xml version numbers for release 4.18.2.0 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(cloudstack) branch 4.18.2.0-RC20240405T1541 deleted (was 0d19ffa61c7)
This is an automated email from the ASF dual-hosted git repository. joao pushed a change to branch 4.18.2.0-RC20240405T1541 in repository https://gitbox.apache.org/repos/asf/cloudstack.git was 0d19ffa61c7 Updating pom.xml version numbers for release 4.18.2.0 This change permanently discards the following revisions: discard 0d19ffa61c7 Updating pom.xml version numbers for release 4.18.2.0
Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]
blueorangutan commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2061366968 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) 01/01: Updating pom.xml version numbers for release 4.18.3.0-SNAPSHOT
This is an automated email from the ASF dual-hosted git repository. joao pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 8a101fbbc1147f5d451b4c01e4dd0376345eb632 Author: João Jandre <48719461+joaojan...@users.noreply.github.com> AuthorDate: Wed Apr 17 11:01:13 2024 -0300 Updating pom.xml version numbers for release 4.18.3.0-SNAPSHOT Signed-off-by: João Jandre <48719461+joaojan...@users.noreply.github.com> --- agent/pom.xml | 2 +- api/pom.xml | 2 +- client/pom.xml | 2 +- core/pom.xml| 2 +- debian/changelog| 6 ++ developer/pom.xml | 2 +- engine/api/pom.xml | 2 +- engine/components-api/pom.xml | 2 +- engine/orchestration/pom.xml| 2 +- engine/pom.xml | 2 +- engine/schema/pom.xml | 2 +- engine/service/pom.xml | 2 +- engine/storage/cache/pom.xml| 2 +- engine/storage/configdrive/pom.xml | 2 +- engine/storage/datamotion/pom.xml | 2 +- engine/storage/image/pom.xml| 2 +- engine/storage/integration-test/pom.xml | 2 +- engine/storage/pom.xml | 2 +- engine/storage/snapshot/pom.xml | 2 +- engine/storage/volume/pom.xml | 2 +- framework/agent-lb/pom.xml | 2 +- framework/ca/pom.xml| 2 +- framework/cluster/pom.xml | 2 +- framework/config/pom.xml| 2 +- framework/db/pom.xml| 2 +- framework/direct-download/pom.xml | 4 ++-- framework/events/pom.xml| 2 +- framework/ipc/pom.xml | 2 +- framework/jobs/pom.xml | 2 +- framework/managed-context/pom.xml | 2 +- framework/pom.xml | 2 +- framework/quota/pom.xml | 2 +- framework/rest/pom.xml | 2 +- framework/security/pom.xml | 2 +- framework/spring/lifecycle/pom.xml | 2 +- framework/spring/module/pom.xml | 2 +- plugins/acl/dynamic-role-based/pom.xml | 2 +- plugins/acl/project-role-based/pom.xml | 2 +- plugins/acl/static-role-based/pom.xml | 2 +- plugins/affinity-group-processors/explicit-dedication/pom.xml | 2 +- plugins/affinity-group-processors/host-affinity/pom.xml | 2 +- plugins/affinity-group-processors/host-anti-affinity/pom.xml| 2 +- plugins/affinity-group-processors/non-strict-host-affinity/pom.xml | 2 +- .../affinity-group-processors/non-strict-host-anti-affinity/pom.xml | 4 ++-- plugins/alert-handlers/snmp-alerts/pom.xml | 2 +- plugins/alert-handlers/syslog-alerts/pom.xml| 2 +- plugins/api/discovery/pom.xml | 2 +- plugins/api/rate-limit/pom.xml | 2 +- plugins/api/solidfire-intg-test/pom.xml | 2 +- plugins/api/vmware-sioc/pom.xml | 2 +- plugins/backup/dummy/pom.xml| 2 +- plugins/backup/networker/pom.xml| 2 +- plugins/backup/veeam/pom.xml| 2 +- plugins/ca/root-ca/pom.xml | 2 +- plugins/database/mysql-ha/pom.xml | 2 +- plugins/database/quota/pom.xml | 2 +- plugins/dedicated-resources/pom.xml | 2 +- plugins/deployment-planners/implicit-dedication/pom.xml | 2 +- plugins/deployment-planners/user-concentrated-pod/pom.xml | 2 +-
(cloudstack) branch 4.18 updated (6cd5c6a1d01 -> 8a101fbbc11)
This is an automated email from the ASF dual-hosted git repository. joao pushed a change to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 6cd5c6a1d01 linstor: Do not pretend handling disconnect paths that are non Linstor (#8897) add 154566f914c Updating pom.xml version numbers for release 4.18.2.0 new 8a101fbbc11 Updating pom.xml version numbers for release 4.18.3.0-SNAPSHOT The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: agent/pom.xml| 2 +- api/pom.xml | 2 +- client/pom.xml | 2 +- core/pom.xml | 2 +- debian/changelog | 12 developer/pom.xml| 2 +- engine/api/pom.xml | 2 +- engine/components-api/pom.xml| 2 +- engine/orchestration/pom.xml | 2 +- engine/pom.xml | 2 +- engine/schema/pom.xml| 2 +- engine/service/pom.xml | 2 +- engine/storage/cache/pom.xml | 2 +- engine/storage/configdrive/pom.xml | 2 +- engine/storage/datamotion/pom.xml| 2 +- engine/storage/image/pom.xml | 2 +- engine/storage/integration-test/pom.xml | 2 +- engine/storage/pom.xml | 2 +- engine/storage/snapshot/pom.xml | 2 +- engine/storage/volume/pom.xml| 2 +- framework/agent-lb/pom.xml | 2 +- framework/ca/pom.xml | 2 +- framework/cluster/pom.xml| 2 +- framework/config/pom.xml | 2 +- framework/db/pom.xml | 2 +- framework/direct-download/pom.xml| 4 ++-- framework/events/pom.xml | 2 +- framework/ipc/pom.xml| 2 +- framework/jobs/pom.xml | 2 +- framework/managed-context/pom.xml| 2 +- framework/pom.xml| 2 +- framework/quota/pom.xml | 2 +- framework/rest/pom.xml | 2 +- framework/security/pom.xml | 2 +- framework/spring/lifecycle/pom.xml | 2 +- framework/spring/module/pom.xml | 2 +- plugins/acl/dynamic-role-based/pom.xml | 2 +- plugins/acl/project-role-based/pom.xml | 2 +- plugins/acl/static-role-based/pom.xml| 2 +- .../affinity-group-processors/explicit-dedication/pom.xml| 2 +- plugins/affinity-group-processors/host-affinity/pom.xml | 2 +- plugins/affinity-group-processors/host-anti-affinity/pom.xml | 2 +- .../non-strict-host-affinity/pom.xml | 2 +- .../non-strict-host-anti-affinity/pom.xml| 4 ++-- plugins/alert-handlers/snmp-alerts/pom.xml | 2 +- plugins/alert-handlers/syslog-alerts/pom.xml | 2 +- plugins/api/discovery/pom.xml| 2 +- plugins/api/rate-limit/pom.xml | 2 +- plugins/api/solidfire-intg-test/pom.xml | 2 +- plugins/api/vmware-sioc/pom.xml | 2 +- plugins/backup/dummy/pom.xml | 2 +- plugins/backup/networker/pom.xml | 2 +- plugins/backup/veeam/pom.xml | 2 +- plugins/ca/root-ca/pom.xml | 2 +- plugins/database/mysql-ha/pom.xml| 2 +- plugins/database/quota/pom.xml | 2 +- plugins/dedicated-resources/pom.xml | 2 +- plugins/deployment-planners/implicit-dedication/pom.xml | 2 +- plugins/deployment-planners/user-concentrated-pod/pom.xml| 2 +- plugins/deployment-planners/user-dispersing/pom.xml | 2 +- plugins/event-bus/inmemory/pom.xml | 2 +-
Re: [PR] packaging: move juniper-contrail network plugin to noredist build [cloudstack]
codecov-commenter commented on PR #8932: URL: https://github.com/apache/cloudstack/pull/8932#issuecomment-2061358546 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8932?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 13.17%. Comparing base [(`f731fe8`)](https://app.codecov.io/gh/apache/cloudstack/commit/f731fe882c5b8459a14da9a13269a8360df2743e?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`8a80f5c`)](https://app.codecov.io/gh/apache/cloudstack/pull/8932?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 20 commits behind head on 4.18. Additional details and impacted files ```diff @@Coverage Diff @@ ## 4.18#8932+/- ## == Coverage 13.16% 13.17% - Complexity 9203 9216+13 == Files 2724 2725 +1 Lines258130 258240 +110 Branches 4023240249+17 == + Hits 3398934016+27 - Misses 219833 219912+79 - Partials 4308 4312 +4 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8932?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) tag 4.18.2.0 created (now 154566f914c)
This is an automated email from the ASF dual-hosted git repository. joao pushed a change to tag 4.18.2.0 in repository https://gitbox.apache.org/repos/asf/cloudstack.git at 154566f914c (commit) No new revisions were added by this update.
(cloudstack) annotated tag 4.18.2.0 updated (0d19ffa61c7 -> 3312c7c381e)
This is an automated email from the ASF dual-hosted git repository. joao pushed a change to annotated tag 4.18.2.0 in repository https://gitbox.apache.org/repos/asf/cloudstack.git *** WARNING: tag 4.18.2.0 was modified! *** from 0d19ffa61c7 (commit) to 3312c7c381e (tag) tagging 0d19ffa61c76f592c77ea04a982e15e8575ceb45 (commit) replaces 4.18.0.0 by João Jandre on Fri Apr 5 15:41:19 2024 -0300 - Log - Tagging release 4.18.2.0 on branch 4.18. -BEGIN PGP SIGNATURE- iQGzBAABCgAdFiEESI2Q2hB0ReMkPRYmBvPOxlszV5AFAmYQRc8ACgkQBvPOxlsz V5B5EgwAx3JSy6lyyHi8LNmm2pZOpa6tiVJUjX8F/E8s9v98yDNZU1Q8MP5gtspv vg3GcaNw1Wj52gu8oY9LGWoEVn077FZskcAHt2yaC+AkThVPCvjp4K7Fvc5jc4j8 4uw+tCD2mal6NfS6jSq4VGSE9rx6FGQ5M3DmM8qmW4EKDfP2TRjehJnUuN1SZfsq GOTVEjIRhlAZ+c7/3jt4iLfYANmuziy9UoY+cGHRJYUQfZbIhB/yQgF3pgoKApK/ KFSGkHwLBdeRB4XdUYy0+asR0m1w66WgFFvv2nTTgjJaQdN2ca5/CQFtE5uG5ZRK i32Sm6ICHZtVhQp6VdqQcLMHeBh7TpQczwaSEP6U4exAeRrpagJO7xbHsHG/hXvS Dhhk2/QEOTVYlys2BxIFV3JQZklJepimEvGMMVbVWhMFSKYS/qzytCzfd7/Ldwok 2SAC1YsXayxyXZmmxBnJDciefuwk1JyzZgZ8cHU2di8PKR083S8KDR45tsID+y3D z07Nz5f1 =pj/a -END PGP SIGNATURE- --- No new revisions were added by this update. Summary of changes:
(cloudstack) annotated tag 4.18.2.0 deleted (was 3312c7c381e)
This is an automated email from the ASF dual-hosted git repository. joao pushed a change to annotated tag 4.18.2.0 in repository https://gitbox.apache.org/repos/asf/cloudstack.git *** WARNING: tag 4.18.2.0 was deleted! *** tag was 3312c7c381e The revisions that were on this annotated tag are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2061276427 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]
blueorangutan commented on PR #8908: URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2061276423 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Qemu agent is not installed after importing from VMware [cloudstack]
DaanHoogland commented on issue #8926: URL: https://github.com/apache/cloudstack/issues/8926#issuecomment-2061255840 @ahmedali6 , this is not a cloudstack issue, check your guest os and virt-v2v versions. see [the third note in this paragraph of the docs on this subject](https://docs.cloudstack.apache.org/en/latest/adminguide/virtual_machines.html#converting-and-importing-a-vmware-vm) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]
DaanHoogland commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2061236716 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]
blueorangutan commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2061238978 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]
rp- commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2061218217 I have fixed a NPE if the device paths had been null (reported from Linstor, because a node was down) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
DaanHoogland commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2061179040 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
DaanHoogland commented on code in PR #8898:
URL: https://github.com/apache/cloudstack/pull/8898#discussion_r1568782998
##
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/store/TemplateObject.java:
##
@@ -373,10 +380,7 @@ public String getInstallPath() {
@Override
public boolean isDirectDownload() {
-if (this.imageVO == null) {
-return false;
-}
-return this.imageVO.isDirectDownload();
+return getImage().isDirectDownload();
Review Comment:
```suggestion
try {
return getImage().isDirectDownload();
} catch (InvalidParameterValueException e) {
return false;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
DaanHoogland commented on code in PR #8898:
URL: https://github.com/apache/cloudstack/pull/8898#discussion_r1568778603
##
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/store/TemplateObject.java:
##
@@ -76,11 +78,16 @@ public class TemplateObject implements TemplateInfo {
TemplateDataStoreDao templateStoreDao;
final private boolean followRedirects;
-public TemplateObject() {
+private TemplateObject() {
this.followRedirects =
StorageManager.DataStoreDownloadFollowRedirects.value();
}
protected void configure(VMTemplateVO template, DataStore dataStore) {
+if (template == null) {
+String msg = String.format("Template Object is not properly
initialised %s", this.toString());
+s_logger.error(msg);
+throw new InvalidParameterValueException(msg);
+}
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
DaanHoogland commented on code in PR #8898:
URL: https://github.com/apache/cloudstack/pull/8898#discussion_r1568779770
##
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/store/TemplateObject.java:
##
@@ -93,7 +100,7 @@ public static TemplateObject getTemplate(VMTemplateVO vo,
DataStore store, Strin
}
public void setSize(Long size) {
-imageVO.setSize(size);
+getImage().setSize(size);
}
public VMTemplateVO getImage() {
Review Comment:
```suggestion
public VMTemplateVO getImage() {
if (template == null) {
String msg = String.format("Template Object is not properly
initialised %s", this.toString());
s_logger.error(msg);
throw new InvalidParameterValueException(msg);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
DaanHoogland commented on code in PR #8898:
URL: https://github.com/apache/cloudstack/pull/8898#discussion_r1568777802
##
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/store/TemplateObject.java:
##
@@ -93,10 +95,15 @@ public static TemplateObject getTemplate(VMTemplateVO vo,
DataStore store, Strin
}
public void setSize(Long size) {
-imageVO.setSize(size);
+getImage().setSize(size);
}
public VMTemplateVO getImage() {
+if (imageVO == null) {
Review Comment:
@suresh, this tactic fails as some `TemplateObject`s are created from spring
contexts. I think the null check needs to go back into the `getImage()` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2061182332 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
DaanHoogland commented on code in PR #8898:
URL: https://github.com/apache/cloudstack/pull/8898#discussion_r1568783462
##
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/store/TemplateObject.java:
##
@@ -410,10 +414,7 @@ public boolean canBeDeletedFromDataStore() {
@Override
public boolean isDeployAsIs() {
-if (this.imageVO == null) {
-return false;
-}
-return this.imageVO.isDeployAsIs();
+return getImage().isDeployAsIs();
Review Comment:
```suggestion
try {
return getImage().isDirectDownload();
} catch (InvalidParameterValueException e) {
return false;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
DaanHoogland commented on code in PR #8898:
URL: https://github.com/apache/cloudstack/pull/8898#discussion_r1568778603
##
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/store/TemplateObject.java:
##
@@ -76,11 +78,16 @@ public class TemplateObject implements TemplateInfo {
TemplateDataStoreDao templateStoreDao;
final private boolean followRedirects;
-public TemplateObject() {
+private TemplateObject() {
this.followRedirects =
StorageManager.DataStoreDownloadFollowRedirects.value();
}
protected void configure(VMTemplateVO template, DataStore dataStore) {
+if (template == null) {
+String msg = String.format("Template Object is not properly
initialised %s", this.toString());
+s_logger.error(msg);
+throw new InvalidParameterValueException(msg);
+}
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] packaging: move juniper-contrail network plugin to noredist build [cloudstack]
blueorangutan commented on PR #8932: URL: https://github.com/apache/cloudstack/pull/8932#issuecomment-2061154181 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]
JoaoJandre commented on PR #8908: URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2061121408 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Host IP address value inconsistent when adding hosts [cloudstack]
adietrich-ussignal commented on issue #8794: URL: https://github.com/apache/cloudstack/issues/8794#issuecomment-2061113315 This was solved after correctly assigning interface names in the agent.properties file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2061136709 [SF] Trillian Build Failed (tid-9881) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2061100330 > @weizhouapache, could you describe the objectives of this feature and how you expect it to work? @GutoVeronezi I just added a paragraph in the description. Hope it answers your question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]
blueorangutan commented on PR #8908: URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2061123541 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: Fix error message for checkVolume command (#8842)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new 85110147071 Fix error message for checkVolume command (#8842)
85110147071 is described below
commit 851101470718fa734d448fb57ce3b812c22bc626
Author: Vishesh
AuthorDate: Wed Apr 17 17:27:27 2024 +0530
Fix error message for checkVolume command (#8842)
---
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
b/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
index 8679221107d..02add0db174 100644
--- a/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
+++ b/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
@@ -1895,7 +1895,8 @@ public class VolumeApiServiceImpl extends ManagerBase
implements VolumeApiServic
} else if (jobResult instanceof ResourceAllocationException) {
throw (ResourceAllocationException)jobResult;
} else if (jobResult instanceof Throwable) {
-throw new RuntimeException("Unexpected exception",
(Throwable)jobResult);
+Throwable throwable = (Throwable) jobResult;
+throw new RuntimeException(String.format("Unexpected
exception: %s", throwable.getMessage()), throwable);
}
}
Re: [I] Host IP address value inconsistent when adding hosts [cloudstack]
adietrich-ussignal closed issue #8794: Host IP address value inconsistent when adding hosts URL: https://github.com/apache/cloudstack/issues/8794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] cloudstack-agent incorrectly assigning private.network.device [cloudstack]
adietrich-ussignal commented on issue #8795: URL: https://github.com/apache/cloudstack/issues/8795#issuecomment-2061112127 This was a source of confusion regarding the names of interfaces in the agent file. It was not abundantly clear in the documentation that private could also be considered the management bridge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] cloudstack-agent incorrectly assigning private.network.device [cloudstack]
adietrich-ussignal closed issue #8795: cloudstack-agent incorrectly assigning private.network.device URL: https://github.com/apache/cloudstack/issues/8795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix null pointer exception in restore VM [cloudstack]
blueorangutan commented on PR #8930: URL: https://github.com/apache/cloudstack/pull/8930#issuecomment-2061075973 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix null pointer exception in restore VM [cloudstack]
blueorangutan commented on PR #8930: URL: https://github.com/apache/cloudstack/pull/8930#issuecomment-2061068242 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Wrong resource usage often reported in multiple area [cloudstack]
levindecaro commented on issue #8927: URL: https://github.com/apache/cloudstack/issues/8927#issuecomment-2061062489 @vishesh92 I have resourcecount.check.interval=300 inplace, but seems not help for this discrepancies problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
GutoVeronezi commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2061054455 @weizhouapache, could you describe the objectives of this feature and how you expect it to work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error message for checkVolume command [cloudstack]
rohityadavcloud merged PR #8842: URL: https://github.com/apache/cloudstack/pull/8842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] packaging: move juniper-contrail network plugin to noredist build [cloudstack]
weizhouapache commented on PR #8932: URL: https://github.com/apache/cloudstack/pull/8932#issuecomment-2061041785 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix null pointer exception in restore VM [cloudstack]
blueorangutan commented on PR #8930: URL: https://github.com/apache/cloudstack/pull/8930#issuecomment-2061051833 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on code in PR #8929:
URL: https://github.com/apache/cloudstack/pull/8929#discussion_r1568698055
##
api/src/main/java/org/apache/cloudstack/api/response/HostForMigrationResponse.java:
##
@@ -205,9 +205,13 @@ public class HostForMigrationResponse extends BaseResponse
{
private String events;
@SerializedName("hosttags")
-@Param(description = "comma-separated list of tags for the host")
+@Param(description = "comma-separated list of explicit host tags for the
host")
private String hostTags;
+@SerializedName("implicithosttags")
+@Param(description = "comma-separated list of implicit host tags for the
host", since = "4.18.1")
Review Comment:
updated this and another file , thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] packaging: move juniper-contrail network plugin to noredist build [cloudstack]
blueorangutan commented on PR #8932: URL: https://github.com/apache/cloudstack/pull/8932#issuecomment-2061045552 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix null pointer exception in restore VM [cloudstack]
vishesh92 commented on PR #8930: URL: https://github.com/apache/cloudstack/pull/8930#issuecomment-2061065474 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix null pointer exception in restore VM [cloudstack]
blueorangutan commented on PR #8930: URL: https://github.com/apache/cloudstack/pull/8930#issuecomment-2061064183 [SF] Trillian Build Failed (tid-9882) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow kvm storage plugin to customize diskdef, add geometry [cloudstack]
blueorangutan commented on PR #8839: URL: https://github.com/apache/cloudstack/pull/8839#issuecomment-2060952066 @borisstoyanov a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow kvm storage plugin to customize diskdef, add geometry [cloudstack]
borisstoyanov commented on PR #8839: URL: https://github.com/apache/cloudstack/pull/8839#issuecomment-2060949772 @blueorangutan test alma9 kvm-alma9 keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix null pointer exception in restore VM [cloudstack]
vishesh92 commented on PR #8930: URL: https://github.com/apache/cloudstack/pull/8930#issuecomment-2061049712 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix null pointer exception in restore VM [cloudstack]
blueorangutan commented on PR #8930: URL: https://github.com/apache/cloudstack/pull/8930#issuecomment-2061048150 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] protect against null-path [cloudstack]
DaanHoogland commented on PR #8915: URL: https://github.com/apache/cloudstack/pull/8915#issuecomment-2060946821 @blueorangutan test alma9 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix null pointer exception in restore VM [cloudstack]
blueorangutan commented on PR #8930: URL: https://github.com/apache/cloudstack/pull/8930#issuecomment-2060955522 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add ability to set cpu.threadspercore similar to existing cpu.corespersocket [cloudstack]
borisstoyanov commented on PR #8850: URL: https://github.com/apache/cloudstack/pull/8850#issuecomment-2060970908 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] packaging: move juniper-contrail network plugin to noredist build [cloudstack]
weizhouapache opened a new pull request, #8932:
URL: https://github.com/apache/cloudstack/pull/8932
### Description
This PR moves juniper-contrail to noredist and removes the repository for it.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2061026016 [SF] Trillian Build Failed (tid-9874) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2060961936 [SF] Trillian Build Failed (tid-9872) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix null pointer exception in restore VM [cloudstack]
weizhouapache commented on code in PR #8930:
URL: https://github.com/apache/cloudstack/pull/8930#discussion_r1568594891
##
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##
@@ -7700,8 +7700,8 @@ public UserVm restoreVM(RestoreVMCmd cmd) throws
InsufficientCapacityException,
_accountMgr.checkAccess(caller, null, true, vm);
DiskOffering diskOffering = rootDiskOfferingId != null ?
validateAndGetDiskOffering(rootDiskOfferingId, vm, caller) : null;
-VMTemplateVO template = _templateDao.findById(newTemplateId);
-if (template.getSize() != null) {
+VMTemplateVO template = _templateDao.findById(newTemplateId != null ?
newTemplateId : vm.getTemplateId());
+if (template != null && template.getSize() != null) {
Review Comment:
@vishesh92
throw an exception if template is removed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix null pointer exception in restore VM [cloudstack]
vishesh92 commented on PR #8930: URL: https://github.com/apache/cloudstack/pull/8930#issuecomment-2060937258 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2060977601 [SF] Trillian Build Failed (tid-9873) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated: Introduce scheduled executor wrapper with dynamic interval (#8916)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 63a0797b180 Introduce scheduled executor wrapper with dynamic interval
(#8916)
63a0797b180 is described below
commit 63a0797b18046397961c620a39931552d90e0588
Author: Vishesh
AuthorDate: Wed Apr 17 15:15:37 2024 +0530
Introduce scheduled executor wrapper with dynamic interval (#8916)
* Introduce scheduled executor wrapper with dynamic interval
* Add validation for configkey
---
.../java/com/cloud/user/ResourceLimitService.java | 2 +-
.../config/ConfigKeyScheduledExecutionWrapper.java | 114 +
.../ConfigKeyScheduledExecutionWrapperTest.java| 177 +
.../resourcelimit/ResourceLimitManagerImpl.java| 10 +-
4 files changed, 297 insertions(+), 6 deletions(-)
diff --git a/api/src/main/java/com/cloud/user/ResourceLimitService.java
b/api/src/main/java/com/cloud/user/ResourceLimitService.java
index 0a64cbb7440..04560df428f 100644
--- a/api/src/main/java/com/cloud/user/ResourceLimitService.java
+++ b/api/src/main/java/com/cloud/user/ResourceLimitService.java
@@ -38,7 +38,7 @@ public interface ResourceLimitService {
static final ConfigKey MaxProjectSecondaryStorage = new
ConfigKey<>("Project Defaults", Long.class, "max.project.secondary.storage",
"400",
"The default maximum secondary storage space (in GiB) that can be
used for a project", false);
static final ConfigKey ResourceCountCheckInterval = new
ConfigKey<>("Advanced", Long.class, "resourcecount.check.interval", "300",
-"Time (in seconds) to wait before running resource recalculation
and fixing task. Default is 300 seconds, Setting this to 0 disables execution
of the task", false);
+"Time (in seconds) to wait before running resource recalculation
and fixing task. Default is 300 seconds, Setting this to 0 disables execution
of the task", true);
static final ConfigKey ResourceLimitHostTags = new
ConfigKey<>("Advanced", String.class, "resource.limit.host.tags", "",
"A comma-separated list of tags for host resource limits", true);
static final ConfigKey ResourceLimitStorageTags = new
ConfigKey<>("Advanced", String.class, "resource.limit.storage.tags", "",
diff --git
a/framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKeyScheduledExecutionWrapper.java
b/framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKeyScheduledExecutionWrapper.java
new file mode 100644
index 000..b8d7e782971
--- /dev/null
+++
b/framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKeyScheduledExecutionWrapper.java
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.framework.config;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.TimeUnit;
+
+import static java.util.concurrent.TimeUnit.NANOSECONDS;
+
+/**
+ * Uses a ScheduledExecutorService and config key to execute a runnable,
+ * dynamically rescheduling based on the long value of the config key.
+ * Timing is similar to ScheduledExecutorService.scheduleAtFixedRate(),
+ * but we look up the next runtime dynamically via the config key.
+ *
+ * If config key is zero, this disables the execution. We skip execution
+ * and check once a minute in order to re-start execution if re-enabled.
+ */
+public class ConfigKeyScheduledExecutionWrapper implements Runnable {
+protected Logger logger = LogManager.getLogger(getClass());
+private final ScheduledExecutorService executorService;
+private final Runnable command;
+private final ConfigKey configKey;
+private final TimeUnit unit;
+private long enableIntervalSeconds = 60;
+
+private void validateArgs(ScheduledExecutorService executorService,
Runnable command, ConfigKey configKey) {
+if (executorService == null) {
+
