[GitHub] [cloudstack] blueorangutan commented on pull request #5797: Improve global settings UI to be more intuitive/logical
blueorangutan commented on PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1386681785 @davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7073: storage: validate disk size range of custom disk offering when resize volume
DaanHoogland merged PR #7073: URL: https://github.com/apache/cloudstack/pull/7073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7073: storage: validate disk size range of custom disk offering when resize volume
DaanHoogland commented on PR #7073: URL: https://github.com/apache/cloudstack/pull/7073#issuecomment-1386680795 tested in a lab env :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5797: Improve global settings UI to be more intuitive/logical
davidjumani commented on PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1386680255 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7075: UI: add filter user/all to list user/all volumes
blueorangutan commented on PR #7075: URL: https://github.com/apache/cloudstack/pull/7075#issuecomment-1386669391 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7075: UI: add filter user/all to list user/all volumes
DaanHoogland commented on PR #7075: URL: https://github.com/apache/cloudstack/pull/7075#issuecomment-1386668603 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6924: [Draft] User two factor authentication
sonarcloud[bot] commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1386663621 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6924) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6924=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6924=false=SECURITY_HOTSPOT) [3 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6924=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=CODE_SMELL) [55 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6924=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6924=new_coverage=list) [35.8% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6924=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6924=new_duplicated_lines_density=list) [3.9% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6924=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6924: [Draft] User two factor authentication
blueorangutan commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1386655757 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency
blueorangutan commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1386650187 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency
DaanHoogland commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1386649043 I'd say ready for merge, but one last pass @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7061: Rollback of changes with errors during the VM assign
weizhouapache commented on code in PR #7061:
URL: https://github.com/apache/cloudstack/pull/7061#discussion_r1073196190
##
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##
@@ -7052,525 +7051,766 @@ public VirtualMachine
migrateVirtualMachineWithVolume(Long vmId, Host destinatio
@DB
@Override
@ActionEvent(eventType = EventTypes.EVENT_VM_MOVE, eventDescription =
"move VM to another user", async = false)
-public UserVm moveVMToUser(final AssignVMCmd cmd) throws
ResourceAllocationException, ConcurrentOperationException,
ResourceUnavailableException, InsufficientCapacityException {
-// VERIFICATIONS and VALIDATIONS
-
-// VV 1: verify the two users
+public UserVm moveVmToUser(final AssignVMCmd cmd) throws
ResourceAllocationException, InsufficientCapacityException {
Account caller = CallContext.current().getCallingAccount();
-if (!_accountMgr.isRootAdmin(caller.getId())
-&& !_accountMgr.isDomainAdmin(caller.getId())) { // only
-// root
-// admin
-// can
-// assign
-// VMs
-throw new InvalidParameterValueException("Only domain admins are
allowed to assign VMs and not " + caller.getType());
-}
-
-// get and check the valid VM
-final UserVmVO vm = _vmDao.findById(cmd.getVmId());
-if (vm == null) {
-throw new InvalidParameterValueException("There is no vm by that
id " + cmd.getVmId());
-} else if (vm.getState() == State.Running) { // VV 3: check if vm is
-// running
-if (s_logger.isDebugEnabled()) {
-s_logger.debug("VM is Running, unable to move the vm " + vm);
-}
-InvalidParameterValueException ex = new
InvalidParameterValueException("VM is Running, unable to move the vm with
specified vmId");
-ex.addProxyObject(vm.getUuid(), "vmId");
-throw ex;
+Long callerId = caller.getId();
+s_logger.trace(String.format("Verifying if caller [%s] is root or
domain admin.", caller));
+if (!_accountMgr.isRootAdmin(callerId) &&
!_accountMgr.isDomainAdmin(callerId)) {
+throw new InvalidParameterValueException(String.format("Only root
or domain admins are allowed to assign VMs. Caller [%s] is of type [%s].",
caller, caller.getType()));
}
-final Account oldAccount =
_accountService.getActiveAccountById(vm.getAccountId());
-if (oldAccount == null) {
-throw new InvalidParameterValueException("Invalid account for VM "
+ vm.getAccountId() + " in domain.");
-}
-final Account newAccount = _accountMgr.finalizeOwner(caller,
cmd.getAccountName(), cmd.getDomainId(), cmd.getProjectId());
-if (newAccount == null) {
-throw new InvalidParameterValueException("Invalid accountid=" +
cmd.getAccountName() + " in domain " + cmd.getDomainId());
-}
+Long vmId = cmd.getVmId();
+final UserVmVO vm = _vmDao.findById(vmId);
+validateIfVmExistsAndIsNotRunning(vm, vmId);
-if (newAccount.getState() == Account.State.DISABLED) {
-throw new InvalidParameterValueException("The new account owner "
+ cmd.getAccountName() + " is disabled.");
-}
+Long domainId = cmd.getDomainId();
+Long projectId = cmd.getProjectId();
+Long oldAccountId = vm.getAccountId();
+String newAccountName = cmd.getAccountName();
+final Account oldAccount =
_accountService.getActiveAccountById(oldAccountId);
+final Account newAccount = _accountMgr.finalizeOwner(caller,
newAccountName, domainId, projectId);
+validateOldAndNewAccounts(oldAccount, newAccount, oldAccountId,
newAccountName, domainId);
+
+checkCallerAccessToAccounts(caller, oldAccount, newAccount);
-if (cmd.getProjectId() != null && cmd.getDomainId() == null) {
+s_logger.trace(String.format("Verifying if the provided domain ID [%s]
is valid.", domainId));
+if (projectId != null && domainId == null) {
throw new InvalidParameterValueException("Please provide a valid
domain ID; cannot assign VM to a project if domain ID is NULL.");
}
-//check caller has access to both the old and new account
-_accountMgr.checkAccess(caller, null, true, oldAccount);
-_accountMgr.checkAccess(caller, null, true, newAccount);
+validateIfVmHasNoRules(vm, vmId);
-// make sure the accounts are not same
-if (oldAccount.getAccountId() == newAccount.getAccountId()) {
-throw new InvalidParameterValueException("The new account is the
same as the old account. Account id =" + oldAccount.getAccountId());
+final List volumes = _volsDao.findByInstance(vmId);
+validateIfVolumesHaveNoSnapshots(volumes);
+
+final ServiceOfferingVO offering =
[GitHub] [cloudstack] boring-cyborg[bot] commented on issue #7102: Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec when building cloudstack from source
boring-cyborg[bot] commented on issue #7102: URL: https://github.com/apache/cloudstack/issues/7102#issuecomment-1386630221 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] mail2lawi opened a new issue, #7102: Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec when building cloudstack from source
mail2lawi opened a new issue, #7102:
URL: https://github.com/apache/cloudstack/issues/7102
# ISSUE TYPE
* Bug Report
# COMPONENT NAME
~~~
~~~
# CLOUDSTACK VERSION
~~~
~~~
# CONFIGURATION
# OS / ENVIRONMENT
Red Hat Enterprise Linux 8.7
Apache Maven 3.5.4 (Red Hat 3.5.4-5)
Maven home: /usr/share/maven
Java version: 11.0.17, vendor: Red Hat, Inc., runtime:
/usr/lib/jvm/java-11-openjdk-11.0.17.0.8-2.el8_6.x86_64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.18.0-425.10.1.el8_7.x86_64", arch: "amd64",
family: "unix"
Node v10.24.0
# SUMMARY
I am trying to build the rpm pack for Cloudstack from source as per the
instructions in the doc site.
After running the ./package.sh -d centos8 the process fails after around 25
mins with the error below:
[ERROR] Failed to execute goal
org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (compile) on project
cloud-apidoc: Command execution failed.: Process exited with an error: 1 (Exit
value: 1) -> [Help 1]
I had been getting almost similar errors with other plugins which I resolved
by setting the correct versions in the pom.xml:
- gmaven - changed version to 1.5
- Added a missing maven-assembly-plugin ver 2.2.1
- Addded a missing maven-war-plugin ver 2.2
Those interventions seemed to solve the issues as I'm not failing at those
steps (yet).
However, with the org.codehaus.mojo:exec-maven-plugin:1.2.1:exec error I
can't seem to get a way around it. For one, I do not know if the issue is with
the pom.xml.
Secondly, I do not know where exactly to edit even if the issue with the
pom.xml
# STEPS TO REPRODUCE
~~~
~~~
# EXPECTED RESULTS
~~~
~~~
# ACTUAL RESULTS
~~~
packaging]$ ./package.sh -d centos8
skipped for brevity---
[INFO] Apache CloudStack Developer Mode ... SUCCESS [ 1.129
s]
[INFO] Apache CloudStack Developer Tools .. SUCCESS [ 0.017
s]
[INFO] Apache CloudStack apidocs .. FAILURE [ 6.354
s]
[INFO] Apache CloudStack marvin ... SKIPPED
[INFO] Apache CloudStack DevCloud4 SKIPPED
[INFO] Apache CloudStack DevCloud-KVM 4.17.2.0 SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 25:43 min
[INFO] Finished at: 2023-01-18T10:10:32+03:00
[INFO]
[ERROR] Failed to execute goal
org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (compile) on project
cloud-apidoc: Command execution failed.: Process exited with an error: 1 (Exit
value: 1) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the
command
[ERROR] mvn -rf :cloud-apidoc
error: Bad exit status from /var/tmp/rpm-tmp.KHosT0 (%build)
RPM build errors:
Macro expanded in comment on line 590:
%{_sysconfdir}/logrotate.d/%{name}-catalina
Bad exit status from /var/tmp/rpm-tmp.KHosT0 (%build)
RPM Build Failed
~~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical
sonarcloud[bot] commented on PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1386625240 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=5797) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=5797=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=5797=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=5797=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=CODE_SMELL) [56 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=5797=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=5797=new_coverage=list) [19.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=5797=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=5797=new_duplicated_lines_density=list) [2.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=5797=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6924: [Draft] User two factor authentication
blueorangutan commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1386605271 @harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6924: [Draft] User two factor authentication
harikrishna-patnala commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1386604262 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #6865: A running vm cannot dynamically scale cpu and memory. It can be expanded when stopped
weizhouapache commented on issue #6865: URL: https://github.com/apache/cloudstack/issues/6865#issuecomment-1386556512 > Hello @1450793561 @weizhouapache > > KVM requires defining ranges for CPU and memory in the VM XML to allow the VM to be dynamically scaled. Currently, those ranges are set only when working with custom compute offerings. For custom-constrained offerings, the ranges are defined while creating them; for custom-unconstrained offerings, the ranges are defined via the global settings `vm.serviceoffering.cpu.cores.max` and `vm.serviceoffering.ram.size.max`, or, if the settings are `0`, they are defined according to the host capacities. > > As KVM supports dynamic scaling, this situation is a matter of designing the logical solution in ACS. We are planning to extend ACS to allow dynamic scaling VMs with fixed offerings in KVM; however, we do not have a due date yet. > > @1450793561, while a VM with fixed offering cannot be dynamically scaled yet, you could try using custom offerings. Along with the custom offerings, some configurations have to be done: > > * in the global settings, `enable.dynamic.scale.vm` must be `true`; > * the template and the VM must be marked as `Dynamically scalable`; > > VMs started after setting those configurations will be able to be dynamically scaled. If you have any doubts or issues using this alternative, just ping me in this issue. Great, thanks @GutoVeronezi for your detailed explanation. Looking forward to the improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7046: Add support for vSphere 8.0
weizhouapache commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1386551978 @rohityadavcloud The trillian failures are not related, no worries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #7089: URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1386530087 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7094: Handle console session in multiple management servers
blueorangutan commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1386530088 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7061: Rollback of changes with errors during the VM assign
blueorangutan commented on PR #7061: URL: https://github.com/apache/cloudstack/pull/7061#issuecomment-1386530089 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7100: api/server: add project id/name in ssh keypair response
blueorangutan commented on PR #7100: URL: https://github.com/apache/cloudstack/pull/7100#issuecomment-1386524782 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7046: Add support for vSphere 8.0
rohityadavcloud commented on code in PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#discussion_r1073103958 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -19,6 +19,10 @@ -- Schema upgrade from 4.17.2.0 to 4.18.0.0 --; +-- Add support for VMware 8.0 +INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '8.0', 1024, 0, 59, 64, 1, 1); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '8.0', guest_os_name, guest_os_id, utc_timestamp(), 0 FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='7.0.3.0'; + Review Comment: I can try to spin a new env locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7046: Add support for vSphere 8.0
blueorangutan commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1386503101 @rohityadavcloud a Trillian-Jenkins test job (ubuntu20 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7046: Add support for vSphere 8.0
rohityadavcloud commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1386502975 @blueorangutan test ubuntu20 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7061: Rollback of changes with errors during the VM assign
blueorangutan commented on PR #7061: URL: https://github.com/apache/cloudstack/pull/7061#issuecomment-1386502525 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #7089: URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1386502496 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7089: [HEALTH] 4.18/main Health Check, please don't merge this!
rohityadavcloud commented on PR #7089: URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1386502294 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7061: Rollback of changes with errors during the VM assign
rohityadavcloud commented on PR #7061: URL: https://github.com/apache/cloudstack/pull/7061#issuecomment-1386501801 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7094: Handle console session in multiple management servers
blueorangutan commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1386499853 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7094: Handle console session in multiple management servers
rohityadavcloud commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1386499547 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7100: api/server: add project id/name in ssh keypair response
blueorangutan commented on PR #7100: URL: https://github.com/apache/cloudstack/pull/7100#issuecomment-1386496714 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7100: api/server: add project id/name in ssh keypair response
rohityadavcloud commented on PR #7100: URL: https://github.com/apache/cloudstack/pull/7100#issuecomment-1386496452 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #7091: .github: run all gha on ubuntu latest
rohityadavcloud merged PR #7091: URL: https://github.com/apache/cloudstack/pull/7091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rahulbcn27 commented on issue #6855: UI: make display elements optional
rahulbcn27 commented on issue #6855: URL: https://github.com/apache/cloudstack/issues/6855#issuecomment-1386450786 Thanks @rohityadavcloud .Working on it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1386388350 Trillian test result (tid-5878) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48427 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7015-t5878-kvm-centos7.zip Smoke tests completed. 104 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_upgrade_kubernetes_cluster | `Failure` | 514.51 | test_kubernetes_clusters.py test_02_unsecure_vm_migration | `Error` | 222.95 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 141.06 | test_vm_life_cycle.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 470.76 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1386356511 Trillian test result (tid-5879) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44969 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7015-t5879-kvm-centos7.zip Smoke tests completed. 106 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_unsecure_vm_migration | `Error` | 219.96 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 143.94 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on issue #6865: A running vm cannot dynamically scale cpu and memory. It can be expanded when stopped
GutoVeronezi commented on issue #6865: URL: https://github.com/apache/cloudstack/issues/6865#issuecomment-1386334137 Hello @1450793561 @weizhouapache KVM requires defining ranges for CPU and memory in the VM XML to allow the VM to be dynamically scaled. Currently, those ranges are set only when working with custom compute offerings. For custom-constrained offerings, the ranges are defined while creating them; for custom-unconstrained offerings, the ranges are defined via the global settings `vm.serviceoffering.cpu.cores.max` and `vm.serviceoffering.ram.size.max`, or, if the settings are `0`, they are defined according to the host capacities. As KVM supports dynamic scaling, this situation is a matter of designing the logical solution in ACS. We are planning to extend ACS to allow dynamic scaling VMs with fixed offerings in KVM; however, we do not have a due date yet. --- @1450793561, while a VM with fixed offering cannot be dynamically scaled yet, you could try using custom offerings. Along with the custom offerings, some configurations have to be done: - in the global settings, `enable.dynamic.scale.vm` must be `true`; - the template and the VM must be marked as `Dynamically scalable`; VMs started after setting those configurations will be able to be dynamically scaled. If you have any doubts or issues using this alternative, just ping me in this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1386329029 Trillian test result (tid-5877) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 44025 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7015-t5877-vmware-67u3.zip Smoke tests completed. 107 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1386298966 Trillian test result (tid-5876) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41982 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7015-t5876-xenserver-71.zip Smoke tests completed. 106 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 901.58 | test_host_maintenance.py test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 0.27 | test_host_maintenance.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7046: Add support for vSphere 8.0
blueorangutan commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1386247617 Trillian test result (tid-5874) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server u20 Total time taken: 49664 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7046-t5874-vmware-70u3.zip Smoke tests completed. 96 look OK, 10 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_verify_ipv6_network | `Failure` | 114.70 | test_network_ipv6.py test_isolate_network_password_server | `Failure` | 11.82 | test_password_server.py test_router_dhcphosts | `Failure` | 16.21 | test_router_dhcphosts.py test_router_dhcp_opts | `Failure` | 11.85 | test_router_dhcphosts.py test_03_ssvm_internals | `Failure` | 0.65 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.63 | test_ssvm.py test_05_stop_ssvm | `Failure` | 85.45 | test_ssvm.py test_06_stop_cpvm | `Failure` | 81.53 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 98.15 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 23.28 | test_ssvm.py test_09_reboot_ssvm_forced | `Failure` | 160.88 | test_ssvm.py test_10_reboot_cpvm_forced | `Failure` | 62.59 | test_ssvm.py test_11_destroy_ssvm | `Failure` | 73.86 | test_ssvm.py test_12_destroy_cpvm | `Failure` | 64.99 | test_ssvm.py test_network_rules_acquired_public_ip_1_static_nat_rule | `Failure` | 5.46 | test_network.py test_network_rules_acquired_public_ip_2_nat_rule | `Failure` | 5.95 | test_network.py test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Failure` | 8.14 | test_network.py test_01_deployVMInSharedNetwork | `Failure` | 88.83 | test_network.py test_02_verifyRouterIpAfterNetworkRestart | `Failure` | 50.27 | test_network.py test_03_destroySharedNetwork | `Failure` | 1.10 | test_network.py ContextSuite context=TestSharedNetwork>:teardown | `Error` | 2.24 | test_network.py test_01_router_internal_basic | `Failure` | 0.92 | test_routers.py test_02_router_internal_adv | `Failure` | 0.72 | test_routers.py test_04_restart_network_wo_cleanup | `Failure` | 2.97 | test_routers.py test_03_RVR_Network_check_router_state | `Failure` | 179.94 | test_routers_network_ops.py test_02_routervm_iptables_policies | `Failure` | 96.28 | test_routers_iptables_default_policy.py test_01_single_VPC_iptables_policies | `Failure` | 262.25 | test_routers_iptables_default_policy.py test_01_verify_ipv6_vpc | `Failure` | 177.69 | test_vpc_ipv6.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 479.23 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | `Failure` | 471.00 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 355.86 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 308.32 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Failure` | 424.15 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 424.17 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6892: Externalize KVM HA heartbeat frequency
sonarcloud[bot] commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1386079381 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6892) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6892=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6892=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6892=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6892=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6892=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6892=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6892=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6892=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6892=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6892=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6892=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack=6892=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6892=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6892=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6892=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6892=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7094: Handle console session in multiple management servers
weizhouapache commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1072817262 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -1035,3 +1035,16 @@ WHERE role_id = (SELECT id FROM `cloud`.`roles` WHERE name = 'Read-Only User - INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, `permission`) SELECT UUID(), `roles`.`id`, 'isAccountAllowedToCreateOfferingsWithTags', 'ALLOW' FROM `cloud`.`roles` WHERE `role_type` = 'DomainAdmin'; + +--- Create table for handling allowed console session temporally #7094 + +CREATE TABLE IF NOT EXISTS `cloud`.`console_session` ( +`id` bigint(20) unsigned NOT NULL AUTO_INCREMENT PRIMARY KEY, +`uuid` varchar(40) NOT NULL COMMENT 'UUID generated for the session', +`created` datetime NOT NULL COMMENT 'When the session was created', +`account_id` bigint(20) unsigned NOT NULL COMMENT 'Account who generated the session' references cloud.account(id), Review Comment: Great. Thanks for the quick fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #7094: Handle console session in multiple management servers
GutoVeronezi commented on code in PR #7094:
URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1072786938
##
server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java:
##
@@ -303,6 +310,16 @@ private ConsoleEndpoint
composeConsoleAccessEndpoint(String rootUrl, VirtualMach
return consoleEndpoint;
}
+protected void persistConsoleSession(String sessionUuid, long instanceId,
long hostId) {
+ConsoleSessionVO consoleSessionVo = new ConsoleSessionVO();
+consoleSessionVo.setUuid(sessionUuid);
Review Comment:
On principle, I would rather not create a constructor for informing the
object properties, as the more properties it has, the longer the constructor
would get, becoming harder to read/interpret the code. For Python, that
supports keyword arguments, this approach works fine, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #7094: Handle console session in multiple management servers
GutoVeronezi commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1072763279 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -1035,3 +1035,16 @@ WHERE role_id = (SELECT id FROM `cloud`.`roles` WHERE name = 'Read-Only User - INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, `permission`) SELECT UUID(), `roles`.`id`, 'isAccountAllowedToCreateOfferingsWithTags', 'ALLOW' FROM `cloud`.`roles` WHERE `role_type` = 'DomainAdmin'; + +--- Create table for handling allowed console session temporally #7094 + +CREATE TABLE IF NOT EXISTS `cloud`.`console_session` ( +`id` bigint(20) unsigned NOT NULL AUTO_INCREMENT PRIMARY KEY, +`uuid` varchar(40) NOT NULL COMMENT 'UUID generated for the session', +`created` datetime NOT NULL COMMENT 'When the session was created', +`account_id` bigint(20) unsigned NOT NULL COMMENT 'Account who generated the session' references cloud.account(id), Review Comment: @weizhouapache, I found out the reason:  https://mariadb.com/kb/en/foreign-keys/ The syntax I firstly used would do nothing (neither warn the user :man_shrugging:) for environments with MariaDB version previous to 10.5. I changed it to work with the previous syntax (https://github.com/apache/cloudstack/pull/7094/commits/6173aa0896e42df81fcae5e4c806c9f56ad54b08), thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency
weizhouapache commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1072572879
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##
@@ -33,7 +35,7 @@ public class KVMHABase {
private long _timeout = 6; /* 1 minutes */
protected static String s_heartBeatPath;
protected long _heartBeatUpdateTimeout = 6;
-protected long _heartBeatUpdateFreq = 6;
+protected long _heartBeatUpdateFreq =
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);
Review Comment:
> (1) The focus of this PR is only the `heartBeatUpdateFreq`. What other
variables would you consider necessary to externalize? (2) Yes, this will be
fixed.
@stephankruggg
good.
can you discuss with your team if other fixed values need be configurable as
well ?
if you want only this configurable, it is ok.
if you want more to be configurable, you can make all the changes in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] stephankruggg commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency
stephankruggg commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1072549527
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##
@@ -33,7 +35,7 @@ public class KVMHABase {
private long _timeout = 6; /* 1 minutes */
protected static String s_heartBeatPath;
protected long _heartBeatUpdateTimeout = 6;
-protected long _heartBeatUpdateFreq = 6;
+protected long _heartBeatUpdateFreq =
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);
Review Comment:
(1) The focus of this PR is only the `heartBeatUpdateFreq`. What other
variables would you consider necessary to externalize?
(2) Yes, this will be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #7094: Handle console session in multiple management servers
nvazquez commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1385787949 @GutoVeronezi thanks for the refactor, you are right I have now checked that the lastUsedTime on the ConsoleProxyLoadReportCommand keeps being updated even when the session is not used, that makes the session not to timeout -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7094: Handle console session in multiple management servers
weizhouapache commented on code in PR #7094:
URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1072541492
##
engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql:
##
@@ -1035,3 +1035,16 @@ WHERE role_id = (SELECT id FROM `cloud`.`roles` WHERE
name = 'Read-Only User -
INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`,
`permission`)
SELECT UUID(), `roles`.`id`, 'isAccountAllowedToCreateOfferingsWithTags',
'ALLOW'
FROM `cloud`.`roles` WHERE `role_type` = 'DomainAdmin';
+
+--- Create table for handling allowed console session temporally #7094
+
+CREATE TABLE IF NOT EXISTS `cloud`.`console_session` (
+`id` bigint(20) unsigned NOT NULL AUTO_INCREMENT PRIMARY KEY,
+`uuid` varchar(40) NOT NULL COMMENT 'UUID generated for the session',
+`created` datetime NOT NULL COMMENT 'When the session was created',
+`account_id` bigint(20) unsigned NOT NULL COMMENT 'Account who generated
the session' references cloud.account(id),
Review Comment:
the table can be created successfully
however, the references do not have any impact.
```
MariaDB [cloud]> insert into console_session values
(1,uuid(),now(),,,,,now());
Query OK, 1 row affected (0.01 sec)
MariaDB [cloud]> insert into console_session values
(2,uuid(),now(),111,,333,444,now());
Query OK, 1 row affected (0.00 sec)
MariaDB [cloud]> show create table console_session\G
*** 1. row ***
Table: console_session
Create Table: CREATE TABLE `console_session` (
`id` bigint(20) unsigned NOT NULL AUTO_INCREMENT,
`uuid` varchar(40) NOT NULL COMMENT 'UUID generated for the session',
`created` datetime NOT NULL COMMENT 'When the session was created',
`account_id` bigint(20) unsigned NOT NULL COMMENT 'Account who generated
the session',
`user_id` bigint(20) unsigned NOT NULL COMMENT 'User who generated the
session',
`instance_id` bigint(20) unsigned NOT NULL COMMENT 'VM for which the
session was generated',
`host_id` bigint(20) unsigned NOT NULL COMMENT 'Host where the VM was when
the session was generated',
`removed` datetime DEFAULT NULL COMMENT 'When the session was
removed/used',
PRIMARY KEY (`id`)
) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=latin1
1 row in set (0.00 sec)
```
please refer to
https://github.com/apache/cloudstack/blob/d0293c4532602f63d445d9c56539ee4f9f51409e/engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql#L563-L575
##
server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java:
##
@@ -303,6 +310,16 @@ private ConsoleEndpoint
composeConsoleAccessEndpoint(String rootUrl, VirtualMach
return consoleEndpoint;
}
+protected void persistConsoleSession(String sessionUuid, long instanceId,
long hostId) {
+ConsoleSessionVO consoleSessionVo = new ConsoleSessionVO();
+consoleSessionVo.setUuid(sessionUuid);
Review Comment:
these lines can be replaced by a constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7094: Handle console session in multiple management servers
sonarcloud[bot] commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1385750812 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7094) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7094=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7094=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7094=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7094=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7094=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7094=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7094=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7067: UI: Enable shared network with scope option in advanced zone with SG
DaanHoogland commented on PR #7067: URL: https://github.com/apache/cloudstack/pull/7067#issuecomment-1385691406 retested in qa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6909: KVM support of iothreads and IO driver policy
sonarcloud[bot] commented on PR #6909: URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1385627335 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6909) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6909=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6909=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6909=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6909=new_coverage=list) [15.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6909=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6909=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6909=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7067: UI: Enable shared network with scope option in advanced zone with SG
codecov[bot] commented on PR #7067: URL: https://github.com/apache/cloudstack/pull/7067#issuecomment-1385560598 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7067?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#7067](https://codecov.io/gh/apache/cloudstack/pull/7067?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c0daa46) into [main](https://codecov.io/gh/apache/cloudstack/commit/20306d612928712e5354bad57691b5fe4e1f59a9?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (20306d6) will **increase** coverage by `0.18%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## main#7067 +/- ## + Coverage 11.58% 11.77% +0.18% - Complexity 7548 7663 +115 Files 2494 2503 +9 Lines247089 245962-1127 Branches 3861538378 -237 + Hits 2863028959 +329 + Misses 214714 213237-1477 - Partials 3745 3766 +21 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7067?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...er/src/main/java/com/cloud/hypervisor/KVMGuru.java](https://codecov.io/gh/apache/cloudstack/pull/7067?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2h5cGVydmlzb3IvS1ZNR3VydS5qYXZh) | `50.81% <0.00%> (-22.41%)` | :arrow_down: | | [...m/resource/wrapper/LibvirtReadyCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/7067?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0UmVhZHlDb21tYW5kV3JhcHBlci5qYXZh) | `61.53% <0.00%> (-11.19%)` | :arrow_down: | | [...rg/apache/cloudstack/quota/QuotaStatementImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7067?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL1F1b3RhU3RhdGVtZW50SW1wbC5qYXZh) | `36.28% <0.00%> (-3.99%)` | :arrow_down: | | [...om/cloud/deploy/DeploymentPlanningManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7067?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2RlcGxveS9EZXBsb3ltZW50UGxhbm5pbmdNYW5hZ2VySW1wbC5qYXZh) | `28.17% <0.00%> (-0.76%)` | :arrow_down: | | [...ava/com/cloud/api/dispatch/ParamProcessWorker.java](https://codecov.io/gh/apache/cloudstack/pull/7067?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9kaXNwYXRjaC9QYXJhbVByb2Nlc3NXb3JrZXIuamF2YQ==) | `13.82% <0.00%> (-0.29%)` | :arrow_down: | | [...n/java/com/cloud/storage/VolumeApiServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7067?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2UvVm9sdW1lQXBpU2VydmljZUltcGwuamF2YQ==) | `12.99% <0.00%> (-0.03%)` | :arrow_down: | | [.../cloud/configuration/ConfigurationManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7067?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2NvbmZpZ3VyYXRpb24vQ29uZmlndXJhdGlvbk1hbmFnZXJJbXBsLmphdmE=) | `12.48% <0.00%> (-0.02%)` | :arrow_down: | | [...om/cloud/hypervisor/vmware/util/VmwareContext.java](https://codecov.io/gh/apache/cloudstack/pull/7067?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dm13YXJlLWJhc2Uvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci92bXdhcmUvdXRpbC9WbXdhcmVDb250ZXh0LmphdmE=) | `14.94% <0.00%> (ø)` | | |
[GitHub] [cloudstack] weizhouapache commented on pull request #6386: [VMWare] Limit IOPS in Compute/Disk Offerings
weizhouapache commented on PR #6386: URL: https://github.com/apache/cloudstack/pull/6386#issuecomment-1385546049 anyone has tested this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
codecov[bot] commented on PR #7095: URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1385542392 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#7095](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (8e54f07) into [main](https://codecov.io/gh/apache/cloudstack/commit/566578297b6164fc1e9f8a2b3ea38789b459fd7a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5665782) will **increase** coverage by `0.00%`. > The diff coverage is `0.37%`. ```diff @@Coverage Diff@@ ## main#7095 +/- ## = Coverage 11.76% 11.77% - Complexity 7661 7665+4 = Files 2503 2503 Lines245958 245950-8 Branches 3837438378+4 = + Hits 2894628962 +16 + Misses 213248 213222 -26 - Partials 3764 3766+2 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...src/main/java/com/cloud/upgrade/GuestOsMapper.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL0d1ZXN0T3NNYXBwZXIuamF2YQ==) | `5.37% <0.00%> (-0.12%)` | :arrow_down: | | [...ava/com/cloud/upgrade/dao/Upgrade41400to41500.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE0MDB0bzQxNTAwLmphdmE=) | `0.00% <ø> (ø)` | | | [...ava/com/cloud/upgrade/dao/Upgrade41500to41510.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE1MDB0bzQxNTEwLmphdmE=) | `2.12% <ø> (+0.75%)` | :arrow_up: | | [...ava/com/cloud/upgrade/dao/Upgrade41510to41520.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE1MTB0bzQxNTIwLmphdmE=) | `12.50% <ø> (-1.79%)` | :arrow_down: | | [...ava/com/cloud/upgrade/dao/Upgrade41520to41600.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE1MjB0bzQxNjAwLmphdmE=) | `6.45% <ø> (-1.02%)` | :arrow_down: | | [...ava/com/cloud/upgrade/dao/Upgrade41600to41610.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE2MDB0bzQxNjEwLmphdmE=) | `0.00% <ø> (ø)` | | | [...ava/com/cloud/upgrade/dao/Upgrade41720to41800.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE3MjB0bzQxODAwLmphdmE=) | `0.81% <0.38%> (-1.07%)` | :arrow_down: | | [...m/resource/wrapper/LibvirtReadyCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/7095?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0UmVhZHlDb21tYW5kV3JhcHBlci5qYXZh) | `61.53% <0.00%> (-11.19%)` | :arrow_down: | |
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6973: conditional logging for prio
github-actions[bot] commented on PR #6973: URL: https://github.com/apache/cloudstack/pull/6973#issuecomment-1385539340 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6012: Add volume group handling
github-actions[bot] commented on PR #6012: URL: https://github.com/apache/cloudstack/pull/6012#issuecomment-1385539293 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7100: api/server: add project id/name in ssh keypair response
weizhouapache commented on code in PR #7100:
URL: https://github.com/apache/cloudstack/pull/7100#discussion_r1072300454
##
api/src/main/java/org/apache/cloudstack/api/response/SSHKeyPairResponse.java:
##
@@ -46,6 +46,14 @@ public class SSHKeyPairResponse extends
BaseResponseWithAnnotations {
@SerializedName(ApiConstants.DOMAIN) @Param(description="the domain name
of the keypair owner")
private String domain;
+@SerializedName(ApiConstants.PROJECT_ID)
+@Param(description = "the project id of the keypair owner")
+private String projectId;
+
+@SerializedName(ApiConstants.PROJECT)
+@Param(description = "the project name of the keypair owner")
+private String projectName;
Review Comment:
same as other properties (zone id/name, domaini id/name, service offering
id/name, etc) in other responses, the names are displayed on UI and more
visible for users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency
weizhouapache commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1072258310
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##
@@ -33,7 +35,7 @@ public class KVMHABase {
private long _timeout = 6; /* 1 minutes */
protected static String s_heartBeatPath;
protected long _heartBeatUpdateTimeout = 6;
-protected long _heartBeatUpdateFreq = 6;
+protected long _heartBeatUpdateFreq =
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);
Review Comment:
@stephankruggg
(1) will you add other heartbeat configs to agent.properties as well ?
(2) can you move the import of "com.cloud.*" near other
com.cloud.utils.script.* ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7067: UI: Enable shared network with scope option in advanced zone with SG
sonarcloud[bot] commented on PR #7067: URL: https://github.com/apache/cloudstack/pull/7067#issuecomment-1385478982 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7067) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7067=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7067=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7067=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7067=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7067=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7067=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7067=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7067=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7067=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7067=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7067=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7067=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7067=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7067=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7067: UI: Enable shared network with scope option in advanced zone with SG
blueorangutan commented on PR #7067: URL: https://github.com/apache/cloudstack/pull/7067#issuecomment-1385471705 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7067 (QA-JID-30) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7067: UI: Enable shared network with scope option in advanced zone with SG
blueorangutan commented on PR #7067: URL: https://github.com/apache/cloudstack/pull/7067#issuecomment-1385462500 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7067: UI: Enable shared network with scope option in advanced zone with SG
DaanHoogland commented on PR #7067: URL: https://github.com/apache/cloudstack/pull/7067#issuecomment-1385461270 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7091: .github: run all gha on ubuntu latest
sonarcloud[bot] commented on PR #7091: URL: https://github.com/apache/cloudstack/pull/7091#issuecomment-1385453892 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7091) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7091=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7091=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7091=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7091=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7091=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7091=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7091=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7091=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7091=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7091=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7091=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7091=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7091=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7091=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7095: fix guestOsMapper and move mapping code to latest upgrade
sonarcloud[bot] commented on PR #7095: URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1385447208 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7095) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7095=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7095=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7095=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7095=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7095=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7095=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7095=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7095=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7095=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7095=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7095=false=CODE_SMELL) [36 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7095=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7095=new_coverage=list) [0.4% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7095=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7095=new_duplicated_lines_density=list) [84.7% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7095=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7100: api/server: add project id/name in ssh keypair response
DaanHoogland commented on code in PR #7100:
URL: https://github.com/apache/cloudstack/pull/7100#discussion_r1072226672
##
api/src/main/java/org/apache/cloudstack/api/response/SSHKeyPairResponse.java:
##
@@ -46,6 +46,14 @@ public class SSHKeyPairResponse extends
BaseResponseWithAnnotations {
@SerializedName(ApiConstants.DOMAIN) @Param(description="the domain name
of the keypair owner")
private String domain;
+@SerializedName(ApiConstants.PROJECT_ID)
+@Param(description = "the project id of the keypair owner")
+private String projectId;
+
+@SerializedName(ApiConstants.PROJECT)
+@Param(description = "the project name of the keypair owner")
+private String projectName;
Review Comment:
why do we need both in the response?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6386: [VMWare] Limit IOPS in Compute/Disk Offerings
DaanHoogland merged PR #6386: URL: https://github.com/apache/cloudstack/pull/6386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7046: Add support for vSphere 8.0
weizhouapache commented on code in PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#discussion_r1072206782 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -19,6 +19,10 @@ -- Schema upgrade from 4.17.2.0 to 4.18.0.0 --; +-- Add support for VMware 8.0 +INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '8.0', 1024, 0, 59, 64, 1, 1); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '8.0', guest_os_name, guest_os_id, utc_timestamp(), 0 FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='7.0.3.0'; + Review Comment: Hi @rohityadavcloud in my opinion, the SDK upgrade and vmware 8 support are two different tasks. I am fine with SDk upgrade, but hesitated to merge the SQL changes for vmware 8 (code looks good but it is not tested manually or automatedly). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7094: Handle console session in multiple management servers
codecov[bot] commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1385416900 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7094?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#7094](https://codecov.io/gh/apache/cloudstack/pull/7094?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9e66078) into [main](https://codecov.io/gh/apache/cloudstack/commit/566578297b6164fc1e9f8a2b3ea38789b459fd7a?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5665782) will **increase** coverage by `0.00%`. > The diff coverage is `0.00%`. ```diff @@Coverage Diff@@ ## main#7094 +/- ## = Coverage 11.76% 11.77% - Complexity 7661 7665+4 = Files 2503 2505+2 Lines245958 246005 +47 Branches 3837438379+5 = + Hits 2894628963 +17 - Misses 213248 213276 +28 - Partials 3764 3766+2 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7094?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...a/src/main/java/com/cloud/vm/ConsoleSessionVO.java](https://codecov.io/gh/apache/cloudstack/pull/7094?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC92bS9Db25zb2xlU2Vzc2lvblZPLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...n/java/com/cloud/vm/dao/ConsoleSessionDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7094?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC92bS9kYW8vQ29uc29sZVNlc3Npb25EYW9JbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...ain/java/com/cloud/consoleproxy/AgentHookBase.java](https://codecov.io/gh/apache/cloudstack/pull/7094?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2NvbnNvbGVwcm94eS9BZ2VudEhvb2tCYXNlLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...udstack/consoleproxy/ConsoleAccessManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7094?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2NvbnNvbGVwcm94eS9Db25zb2xlQWNjZXNzTWFuYWdlckltcGwuamF2YQ==) | `5.30% <0.00%> (-0.25%)` | :arrow_down: | | [...m/resource/wrapper/LibvirtReadyCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/7094?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0UmVhZHlDb21tYW5kV3JhcHBlci5qYXZh) | `61.53% <0.00%> (-11.19%)` | :arrow_down: | | [...bernetes/cluster/KubernetesClusterManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7094?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9pbnRlZ3JhdGlvbnMva3ViZXJuZXRlcy1zZXJ2aWNlL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2t1YmVybmV0ZXMvY2x1c3Rlci9LdWJlcm5ldGVzQ2x1c3Rlck1hbmFnZXJJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...ervisor/kvm/resource/LibvirtComputingResource.java](https://codecov.io/gh/apache/cloudstack/pull/7094?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydENvbXB1dGluZ1Jlc291cmNlLmphdmE=) | `18.62% <0.00%> (+0.27%)` | :arrow_up: | | [...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java](https://codecov.io/gh/apache/cloudstack/pull/7094?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydFZNRGVmLmphdmE=) | `67.39% <0.00%> (+0.70%)` | :arrow_up: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
[GitHub] [cloudstack] weizhouapache closed issue #7101: Compute offering for VR provider specified in network offering is ignored when using web interface
weizhouapache closed issue #7101: Compute offering for VR provider specified in network offering is ignored when using web interface URL: https://github.com/apache/cloudstack/issues/7101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7101: Compute offering for VR provider specified in network offering is ignored when using web interface
weizhouapache commented on issue #7101: URL: https://github.com/apache/cloudstack/issues/7101#issuecomment-1385411877 Hi @tbudx thanks for your report. this issue has been recently fixed by #7057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7067: UI: Enable shared network with scope option in advanced zone with SG
weizhouapache commented on PR #7067: URL: https://github.com/apache/cloudstack/pull/7067#issuecomment-1385400537 @rohityadavcloud @DaanHoogland I made some changes for envs wth multiple zones with different types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6938: Create API to reassign volume
sonarcloud[bot] commented on PR #6938: URL: https://github.com/apache/cloudstack/pull/6938#issuecomment-1385379064 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6938) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6938=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6938=false=SECURITY_HOTSPOT) [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6938=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6938=new_coverage=list) [29.2% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6938=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6938=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6938=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1385372910 @borisstoyanov a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
borisstoyanov commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1385372291 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7094: Handle console session in multiple management servers
sonarcloud[bot] commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1385346000 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7094) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7094=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7094=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7094=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7094=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7094=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7094=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7094=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #7094: Handle console session in multiple management servers
GutoVeronezi commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1072115961 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -1036,9 +1036,9 @@ INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, `permission`) SELECT UUID(), `roles`.`id`, 'isAccountAllowedToCreateOfferingsWithTags', 'ALLOW' FROM `cloud`.`roles` WHERE `role_type` = 'DomainAdmin'; Create table for handling allowed console session temporally +--- Create table for handling allowed console session temporally #7094 -CREATE TABLE `cloud`.`allowed_console_session` ( +CREATE TABLE IF NOT EXISTS `cloud`.`console_session` ( `id` bigint(20) unsigned NOT NULL AUTO_INCREMENT PRIMARY KEY, Review Comment: @rohityadavcloud, the table was redesigned, vide https://github.com/apache/cloudstack/pull/7094#issuecomment-1385309721. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #7094: Handle console session in multiple management servers
GutoVeronezi commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1072115452 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -1035,3 +1035,10 @@ WHERE role_id = (SELECT id FROM `cloud`.`roles` WHERE name = 'Read-Only User - INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, `permission`) SELECT UUID(), `roles`.`id`, 'isAccountAllowedToCreateOfferingsWithTags', 'ALLOW' FROM `cloud`.`roles` WHERE `role_type` = 'DomainAdmin'; + +--- Create table for handling allowed console session temporally + +CREATE TABLE `cloud`.`allowed_console_session` ( Review Comment: @weizhouapache, the table was redesigned, vide https://github.com/apache/cloudstack/pull/7094#issuecomment-1385309721. ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -1035,3 +1035,10 @@ WHERE role_id = (SELECT id FROM `cloud`.`roles` WHERE name = 'Read-Only User - INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, `permission`) SELECT UUID(), `roles`.`id`, 'isAccountAllowedToCreateOfferingsWithTags', 'ALLOW' FROM `cloud`.`roles` WHERE `role_type` = 'DomainAdmin'; + +--- Create table for handling allowed console session temporally + +CREATE TABLE `cloud`.`allowed_console_session` ( +`id` bigint(20) unsigned NOT NULL AUTO_INCREMENT PRIMARY KEY, Review Comment: @weizhouapache, the table was redesigned, vide https://github.com/apache/cloudstack/pull/7094#issuecomment-1385309721. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7094: Handle console session in multiple management servers
GutoVeronezi commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1385309721 @DaanHoogland @nvazquez @rohityadavcloud @weizhouapache I redesigned the table `console_session` to store more data, based on the idea in https://github.com/apache/cloudstack/pull/7094#discussion_r1071235407. When generated via UI (ids 1, 2, and 3), the session is set as removed right away, as the UI redirects to the URL and consumes the session. When generated via API directly (id 4) , the session will not be set as removed until be consumed:  During the tests I did not notice a workflow to expire not used sessions. Will they be valid "forever" if not used? Or am I missing something? cc: @nvazquez --- Regarding the `on cascade` clause, as the referenced entities are never deleted by ACS (they are only marked as removed), I do not see a reason to use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #6909: KVM support of iothreads and IO driver policy
slavkap commented on PR #6909: URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1385291913 Thanks, @wido! A lot has changed from the initial idea, but I think it's ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6909: KVM support of iothreads and IO driver policy
sonarcloud[bot] commented on PR #6909: URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1385291199 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6909) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6909=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6909=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6909=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6909=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6909=new_coverage=list) [15.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6909=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6909=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6909=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7046: Add support for vSphere 8.0
rohityadavcloud commented on code in PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#discussion_r1072092572 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -19,6 +19,10 @@ -- Schema upgrade from 4.17.2.0 to 4.18.0.0 --; +-- Add support for VMware 8.0 +INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) values (UUID(), 'VMware', '8.0', 1024, 0, 59, 64, 1, 1); +INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) SELECT UUID(),'VMware', '8.0', guest_os_name, guest_os_id, utc_timestamp(), 0 FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND hypervisor_version='7.0.3.0'; + Review Comment: Sorry I didn't get your comments earlier @weizhouapache @DaanHoogland I'm of the opinion that SDK upgrade isn't just enough you need to add (1) the new hypervisor in hypervisor capability, and (2) copy the guest OS mappings from the previous hypervisor version. You an review the previous PRs that added support for vcenter 7.0 (and it's minor versions), 6.7, 6.5 etc. they all follow the same pattern. In the SDK, there's a utility and enums that translate the guest OS label to what it means in cloudstack DB (and vice-versa), because of this you can copy the guest OS mappings in CloudStack DB. This list is here too: https://docs.vmware.com/en/VMware-HCX/4.5/hcx-user-guide/GUID-D4FFCBD6-9FEC-44E5-9E26-1BD0A2A81389.html So in my opinion, as long as regression tests are passing with the new SDK it's fair to say we can copy the mappings to the guest_os_hypervisor table. We may later still need to do these things (a) add support for the template in trillian/BO, (b) review and add new guest OSs that the new vSphere version supports incl. fixing any incorrect mapping (if any), (c) ensure smoketests pass with the new template (from trillian/BO). These addtional things can be done in 4.18.1.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] slavkap commented on a diff in pull request #6909: KVM support of iothreads and IO driver policy
slavkap commented on code in PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#discussion_r1072088093
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##
@@ -3185,12 +3199,32 @@ protected String getIoUringCheckCommand() {
* (i) Qemu >= 5.0;
* (ii) Libvirt >= 6.3.0
*/
-protected void setDiskIoDriver(DiskDef disk) {
-if (enableIoUring) {
+public void setDiskIoDriver(DiskDef disk, boolean iothreadsEnabled,
IoDriver ioDriver) {
+if (iothreadsEnabled) {
+disk.setIothreads(iothreadsEnabled);
+if (!enableIoUring && IoDriver.IOURING == ioDriver) {
Review Comment:
@wido, I think it's good to leave the check if the OS supports the
`io_uring` option. I've just removed it from the `agent.properties` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7059: guestos: add el9 distros
sonarcloud[bot] commented on PR #7059: URL: https://github.com/apache/cloudstack/pull/7059#issuecomment-1385254134 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7059) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7059=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7059=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7059=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7059=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7059=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7059=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] boring-cyborg[bot] commented on issue #7101: Compute offering for VR provider specified in network offering is ignored when using web interface
boring-cyborg[bot] commented on issue #7101: URL: https://github.com/apache/cloudstack/issues/7101#issuecomment-1385103008 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] tbudx opened a new issue, #7101: Compute offering for VR provider specified in network offering is ignored when using web interface
tbudx opened a new issue, #7101: URL: https://github.com/apache/cloudstack/issues/7101 # ISSUE TYPE * Bug Report # COMPONENT NAME Network offering # CLOUDSTACK VERSION 4.17.1.0, 4.17.2.0, earlier versions not tested # CONFIGURATION Advanced zone # OS / ENVIRONMENT Management server: CentOS 8.8 VMware version: 6.7 # SUMMARY Creating a custom Network offering for isolated and/or shared networks with a set of supported services and a Compute offering definition for the VR provider results in the Compute offering being ignored. This only applies to the custom Network definition created using the web interface. Using the appropriate API (createNetworkOffering) with specifying the serviceOfferingID works. As a result of this the corresponding VR is created with the default service offering and not attached to the appropriate network. Also not honoring host tags, etc. # STEPS TO REPRODUCE 1. Create a System offering for type "Domain router", use host tags and storage tags to allow for workload separation. Hypervisor used is VMware. 2. Create a custom Network offering. Isolated. Pick necessary services to be enabled on VR and select the previously created System (Compute) offering 3. Create a new Guest network (isolated) using the previously defined Network offering 4. Create a Compute Instance attached to the previously created Network, with host and storage tags for workload separation. # EXPECTED RESULTS 1. Compute Instance created and running on the chosen network 2. VR created and also attached on the selected network, providing requested services and using the System offering associated with the Network/Network offering. # ACTUAL RESULTS 1. Compute instance created and running on the selected network, on host matching host tags. 2. VR created and started, however, ignoring the Compute offering associated with the network offering and Network. Therefore, started on wrong host and network. It is using the default Compute offering. Temporary workaround is to destroy the VR, change router.service.offering UUID in global settings to the appropriate one and start the compute instance. This creates the VR with appropriate compute offering. Finally reset router.service.offering global setting. Alternative workaround is to create the Network offering using API, not the web interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7046: Add support for vSphere 8.0
blueorangutan commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1385089386 @weizhouapache a Trillian-Jenkins test job (ubuntu20 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7046: Add support for vSphere 8.0
weizhouapache commented on PR #7046: URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1385087533 @blueorangutan test ubuntu20 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #6865: A running vm cannot dynamically scale cpu and memory. It can be expanded when stopped
weizhouapache commented on issue #6865:
URL: https://github.com/apache/cloudstack/issues/6865#issuecomment-1385076840
@1450793561
as @DaanHoogland mentioned, this is a known limitation, introduced by #4878
the UI change was introduced in #5923
```
if (vmHypervisorType.equals(HypervisorType.KVM) &&
!currentServiceOffering.isDynamic()) {
String message = String.format("Unable to live scale VM on KVM
when current service offering is a \"Fixed Offering\". KVM needs the tag
\"maxMemory\" to live scale and it is only configured when VM is deployed with
a custom service offering and \"Dynamic Scalable\" is enabled.");
s_logger.info(message);
throw new InvalidParameterValueException(message);
```
maybe @GutoVeronezi can have a look to see if it is possible to improve it
in the future.
for example, scale a running vm on kvm from a fixed offering to another
fixed offering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache opened a new pull request, #7100: api/server: add project id/name in ssh keypair response
weizhouapache opened a new pull request, #7100:
URL: https://github.com/apache/cloudstack/pull/7100
### Description
This fixes #7096
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud opened a new issue, #7099: Add Github Action support to other repos
rohityadavcloud opened a new issue, #7099: URL: https://github.com/apache/cloudstack/issues/7099 Migrate from Travis to Github Actions: https://github.com/apache/cloudstack-cloudmonkey (https://github.com/apache/cloudstack-cloudmonkey/issues/120) https://github.com/apache/cloudstack-terraform-provider https://github.com/apache/cloudstack-kubernetes-provider https://github.com/apache/cloudstack-gcestack https://github.com/apache/cloudstack-ec2stack with @rahulbcn27 cc @DaanHoogland @weizhouapache Start with cloudmonkey, once that is completed to satisfactory, move with rest of the list. Refer: https://docs.github.com/en/actions/migrating-to-github-actions/migrating-from-travis-ci-to-github-actions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on issue #6855: UI: make display elements optional
rohityadavcloud commented on issue #6855: URL: https://github.com/apache/cloudstack/issues/6855#issuecomment-1384997473 with @rahulbcn27 attempting it cc @DaanHoogland @weizhouapache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7091: .github: run all gha on ubuntu latest
rohityadavcloud commented on PR #7091: URL: https://github.com/apache/cloudstack/pull/7091#issuecomment-1384993699 @DaanHoogland I think the ubuntu-latest is buggy in how Github Actions interprets it, it's better to be specific and move everything to ubuntu-22.04. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7094: Handle console session in multiple management servers
rohityadavcloud commented on code in PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1071872532 ## engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql: ## @@ -1036,9 +1036,9 @@ INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, `permission`) SELECT UUID(), `roles`.`id`, 'isAccountAllowedToCreateOfferingsWithTags', 'ALLOW' FROM `cloud`.`roles` WHERE `role_type` = 'DomainAdmin'; Create table for handling allowed console session temporally +--- Create table for handling allowed console session temporally #7094 -CREATE TABLE `cloud`.`allowed_console_session` ( +CREATE TABLE IF NOT EXISTS `cloud`.`console_session` ( `id` bigint(20) unsigned NOT NULL AUTO_INCREMENT PRIMARY KEY, Review Comment: Is this VM ID? If yes, this should be linked to vm_instance table and to be deleted (on cascade...). @GutoVeronezi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #6909: KVM support of iothreads
wido commented on PR #6909: URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1384902598 > Ok, great! This PR is very much welcome. Looking forward to the changes so I can do an additional review. Ping @Rubueno and @BartJM to get them onboard as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6386: [VMWare] Limit IOPS in Compute/Disk Offerings
blueorangutan commented on PR #6386: URL: https://github.com/apache/cloudstack/pull/6386#issuecomment-1384842266 Trillian test result (tid-5872) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48783 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6386-t5872-vmware-67u3.zip Smoke tests completed. 106 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 614.32 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency
blueorangutan commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1384828744 Trillian test result (tid-5873) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43162 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6892-t5873-kvm-centos7.zip Smoke tests completed. 106 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 568.43 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7094: Handle console session in multiple management servers
sonarcloud[bot] commented on PR #7094: URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1384822915 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7094) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7094=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7094=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7094=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7094=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7094=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7094=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7094=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7094=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #7094: Handle console session in multiple management servers
GutoVeronezi commented on code in PR #7094:
URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1071704746
##
server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java:
##
@@ -151,11 +156,16 @@ public boolean isSessionAllowed(String sessionUuid) {
Review Comment:
@nvazquez, thanks. I missed a line while porting the changes to the PR. I
fixed it with commit dec6e3fb461763605ca6be34013d7e2c2438827a and was doing
some more testing before pinging you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7094: Handle console session in multiple management servers
nvazquez commented on code in PR #7094:
URL: https://github.com/apache/cloudstack/pull/7094#discussion_r1071697570
##
server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java:
##
@@ -151,11 +156,16 @@ public boolean isSessionAllowed(String sessionUuid) {
Review Comment:
@GutoVeronezi the problem listed previously for one mgmt server comes from
the method `isSessionAllowed` that does not query the database for the session
UUID and always returns false, therefore the
`ConsoleAccessAuthenticationAnswer` is false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
