weizhouapache commented on PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1396829906
> @wido That in my view
>
> > Overall it is looking good.
> > What I am missing is a validation that nobody can set a value <0 or
maybe a super large like 1TB or example
weizhouapache commented on code in PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#discussion_r1081127968
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##
@@ -990,7 +992,16 @@ public boolean configure(fina
weizhouapache commented on code in PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#discussion_r1081127968
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##
@@ -990,7 +992,16 @@ public boolean configure(fina
blueorangutan commented on PR #7113:
URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396821169
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15.
SL-JID 5326
--
This is an automated
rohityadavcloud closed issue #7110: Latest main can't create networks
URL: https://github.com/apache/cloudstack/issues/7110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
rohityadavcloud commented on issue #7110:
URL: https://github.com/apache/cloudstack/issues/7110#issuecomment-1396817333
Can't reproduce with latest main, closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
sonarcloud[bot] commented on PR #7113:
URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396813896
Kudos, SonarCloud Quality Gate passed! [
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43178 seconds
Marvin logs:
https://github.com/blue
soreana commented on PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1396762393
@wido That in my view
> Overall it is looking good.
>
> What I am missing is a validation that nobody can set a value <0 or maybe
a super large like 1TB or example. Do we
blueorangutan commented on PR #7104:
URL: https://github.com/apache/cloudstack/pull/7104#issuecomment-1396761093
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
rohityadavcloud commented on PR #7104:
URL: https://github.com/apache/cloudstack/pull/7104#issuecomment-1396759920
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
weizhouapache commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1396759510
> LGTM @DaanHoogland would we need to do that with every release?
if we will do another 4.17 minor release (4.17.3.0), we need to fix in 4.17
as well.
--
This is an auto
rohityadavcloud commented on PR #7095:
URL: https://github.com/apache/cloudstack/pull/7095#issuecomment-1396757072
LGTM @DaanHoogland would we need to do that with every release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
blueorangutan commented on PR #7113:
URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396744169
@weizhouapache a Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
weizhouapache commented on PR #7113:
URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396743437
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
blueorangutan commented on PR #7103:
URL: https://github.com/apache/cloudstack/pull/7103#issuecomment-1396742968
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To res
blueorangutan commented on PR #7113:
URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396743024
@weizhouapache a Jenkins job has been kicked to build packages. It will be
bundled with` is not the last line of your comment (e.g. blank/empty line after
that).
SystemVM
weizhouapache commented on PR #7113:
URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396742721
@rohityadavcloud
systemvm templates are not bundled if `@blueorangutan package` is not the
last line of your comment (e.g. blank/empty line after that).
@blueorangutan
rohityadavcloud commented on PR #7103:
URL: https://github.com/apache/cloudstack/pull/7103#issuecomment-1396741980
LGTM, didn't test it.
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
blueorangutan commented on PR #7113:
URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396740681
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: debian. SL-JID
5323
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
weizhouapache commented on PR #7111:
URL: https://github.com/apache/cloudstack/pull/7111#issuecomment-1396739920
looks good.
```
[root@pr7111-t5901-kvm-centos7-marvin ~]# pip3 list |grep mysql
mysql-connector-python 8.0.20
[root@pr7111-t5901-kvm-centos7-marvin ~]# pip list |grep m
blueorangutan commented on PR #7113:
URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396736932
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be
bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an a
rohityadavcloud commented on PR #7113:
URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396735680
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
sonarcloud[bot] commented on PR #7112:
URL: https://github.com/apache/cloudstack/pull/7112#issuecomment-1396735586
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to
blueorangutan commented on PR #7112:
URL: https://github.com/apache/cloudstack/pull/7112#issuecomment-1396694129
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7112 (QA-JID-32)
--
This is an automated message from the Apache Git Service.
To respond to
rohityadavcloud closed pull request #7113: Adds tar as dependency used for
VMware to seed systemvmtemplate on mgmt server
URL: https://github.com/apache/cloudstack/pull/7113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
blueorangutan commented on PR #7113:
URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396693834
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be
bundled with SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automate
rohityadavcloud commented on PR #7113:
URL: https://github.com/apache/cloudstack/pull/7113#issuecomment-1396692723
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
rohityadavcloud opened a new pull request, #7113:
URL: https://github.com/apache/cloudstack/pull/7113
Adds tar as dependency used for VMware to seed systemvmtemplate on mgmt
server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
rohityadavcloud commented on PR #7111:
URL: https://github.com/apache/cloudstack/pull/7111#issuecomment-1396689318
@weizhouapache I can bump to .29 as .30 which is latest breaks Marvin
install and cloudstack-setup-management on el7, el8. .20 what was tried and
tested and included in the cl
DaanHoogland commented on code in PR #7112:
URL: https://github.com/apache/cloudstack/pull/7112#discussion_r1081014489
##
ui/src/views/network/CreateIsolatedNetworkForm.vue:
##
@@ -40,7 +40,7 @@
blueorangutan commented on PR #7112:
URL: https://github.com/apache/cloudstack/pull/7112#issuecomment-1396688175
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep
you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To resp
rohityadavcloud commented on PR #7112:
URL: https://github.com/apache/cloudstack/pull/7112#issuecomment-1396687263
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
weizhouapache commented on PR #7046:
URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1396687230
> Ubuntu mgmt server smoketests doesn’t work with VMware, Wei logged a bug
or PR on trillian I think
yes @rohityadavcloud
It is actually not a bug with Trillian, but wi
blueorangutan commented on PR #7112:
URL: https://github.com/apache/cloudstack/pull/7112#issuecomment-1396687168
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep
you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To resp
rohityadavcloud commented on PR #7112:
URL: https://github.com/apache/cloudstack/pull/7112#issuecomment-1396686723
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
rohityadavcloud commented on PR #7046:
URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1396685413
Ubuntu doesn’t work with VMware, Wei logged a bug or PR on trillian I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
rahulbcn27 opened a new pull request, #7112:
URL: https://github.com/apache/cloudstack/pull/7112
### Description
This is a improvement change to make display field optional as mentioned in
issue #6855.
This PR...
### Types of
wido commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396661606
> @nvazquez @wido has either of you tested this?
No, I do not have a testing bed for this. I should have commented: 'Code
LGTM'
--
This is an automated message from the Apache Gi
DaanHoogland commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396656086
@nvazquez @wido has either of you tested this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
weizhouapache commented on issue #7109:
URL: https://github.com/apache/cloudstack/issues/7109#issuecomment-1396648618
@ccycv
good to know it. closing this issue then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
weizhouapache closed issue #7109: (HTTP 530, error code 4250) Failed to fetch
any free public IP address
URL: https://github.com/apache/cloudstack/issues/7109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
blueorangutan commented on PR #7046:
URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1396627569
@DaanHoogland a Trillian-Jenkins test job (ubuntu20 mgmt + vmware-70u3) has
been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respo
blueorangutan commented on PR #7094:
URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1396627369
Trillian test result (tid-5889)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 79671 seconds
Marvin logs:
https://github.com/blu
ccycv commented on issue #7109:
URL: https://github.com/apache/cloudstack/issues/7109#issuecomment-1396626653
@weizhouapache Yes, looks like I have an IP with allocated=NULL but with
state=allocated. Looks like after I have changed the state to free ( it was an
used IP). Thank you for th
DaanHoogland commented on PR #7046:
URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1396626556
hm, doing an extra check, I don´t _think_ these errors are related to this
PR but
@blueorangutan test ubuntu20 vmware-70u3
--
This is an automated message from the Apache Git
DaanHoogland commented on code in PR #6947:
URL: https://github.com/apache/cloudstack/pull/6947#discussion_r1080955098
##
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##
@@ -5398,11 +5403,19 @@ public Pair> startVirtualMach
String password = "saved_pass
DaanHoogland commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1396619394
> From what I can see, this haven't been fixed yet, here is what I got when
testing as described in issue #6736:
>
> When registering the mentioned template (PI-VA-3.10.0.0.
DaanHoogland commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1080947374
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##
@@ -33,7 +35,7 @@ public class KVMHABase {
private long _time
blueorangutan commented on PR #7089:
URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1396591677
Trillian test result (tid-5886)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 81165 seconds
Marvin logs:
https://github.com/blu
rohityadavcloud commented on issue #7110:
URL: https://github.com/apache/cloudstack/issues/7110#issuecomment-1396561474
Thanks @weizhouapache let me rebuild an email and confirm the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
weizhouapache commented on issue #7109:
URL: https://github.com/apache/cloudstack/issues/7109#issuecomment-1396554665
@ccycv
can you please check the database if there is an Ip which is not allocated
(allocated=NULL) but not in Free state ?
select * from cloud.user_ip_address wher
blueorangutan commented on PR #7111:
URL: https://github.com/apache/cloudstack/pull/7111#issuecomment-1396474902
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To res
rohityadavcloud commented on PR #7111:
URL: https://github.com/apache/cloudstack/pull/7111#issuecomment-1396474656
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
wido commented on PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1396473638
Overall it is looking good.
What I am missing is a validation that nobody can set a value <0 or maybe a
super large like 1TB or example. Do we maybe need to set some lower and upper
wido commented on code in PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#discussion_r1080828276
##
agent/conf/agent.properties:
##
@@ -398,3 +395,6 @@ iscsi.session.cleanup.enabled=false
#consoleproxy.httpListenPort=443
#ping.retries=5
+
+# The number of iothr
blueorangutan commented on PR #7015:
URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1396399969
Trillian test result (tid-5897)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40604 seconds
Marvin logs:
https://github.com/blue
blueorangutan commented on PR #7003:
URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1396318105
Trillian test result (tid-99)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 51674 seconds
Marvin logs:
https://github.com/blueor
blueorangutan commented on PR #7094:
URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1396210853
Trillian test result (tid-5888)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44802 seconds
Marvin logs:
https://github.com/blu
blueorangutan commented on PR #5797:
URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1396207202
Trillian test result (tid-5893)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40857 seconds
Marvin logs:
https://github.com/blue
blueorangutan commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396182835
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to
nvazquez commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396182261
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
blueorangutan commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396181846
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15.
SL-JID 5320
--
This is an automated
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1396177550
Trillian test result (tid-5891)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41805 seconds
Marvin logs:
https://github.com/blue
blueorangutan commented on PR #7094:
URL: https://github.com/apache/cloudstack/pull/7094#issuecomment-1396145319
Trillian test result (tid-5890)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40757 seconds
Marvin logs:
https://github.com/blue
blueorangutan commented on PR #7089:
URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1396127329
Trillian test result (tid-5887)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43319 seconds
Marvin logs:
https://github.com/blue
blueorangutan commented on PR #7089:
URL: https://github.com/apache/cloudstack/pull/7089#issuecomment-1396124166
Trillian test result (tid-5885)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43308 seconds
Marvin logs:
https://github.com/blu
nvazquez commented on PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1396109276
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
sonarcloud[bot] commented on PR #7082:
URL: https://github.com/apache/cloudstack/pull/7082#issuecomment-1396097018
SonarCloud Quality Gate failed. [
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37410 seconds
Marvin logs:
https://github.com/blue
blueorangutan commented on PR #7046:
URL: https://github.com/apache/cloudstack/pull/7046#issuecomment-1387692810
Trillian test result (tid-5882)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server u20
Total time taken: 5 seconds
Marvin logs:
https://github.com/bl
weizhouapache commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1074012350
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##
@@ -33,7 +35,7 @@ public class KVMHABase {
private long _tim
sonarcloud[bot] commented on PR #7111:
URL: https://github.com/apache/cloudstack/pull/7111#issuecomment-1387685730
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
'Q
blueorangutan commented on PR #7111:
URL: https://github.com/apache/cloudstack/pull/7111#issuecomment-1387680213
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15.
SL-JID 5319
--
This is an automated
sonarcloud[bot] commented on PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1387667236
SonarCloud Quality Gate failed. [![Quality Gate
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
'Quality
weizhouapache commented on PR #7111:
URL: https://github.com/apache/cloudstack/pull/7111#issuecomment-1387653748
@rohityadavcloud
fyi, we use 8.0.29 in marvin node
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
weizhouapache commented on issue #7110:
URL: https://github.com/apache/cloudstack/issues/7110#issuecomment-1387652512
@rohityadavcloud
I cannot reproduce the issue in a fresh environment.
what's the type of the zone ?
what's the last commit ?
do you use nodejs development mod
blueorangutan commented on PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1387641440
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15.
SL-JID 5318
--
This is an automated
slavkap commented on code in PR #6909:
URL: https://github.com/apache/cloudstack/pull/6909#discussion_r1073975173
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##
@@ -3055,24 +3073,34 @@ protected String getIoUringCheck
GutoVeronezi commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1073957316
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##
@@ -33,7 +35,7 @@ public class KVMHABase {
private long _time
blueorangutan commented on PR #7111:
URL: https://github.com/apache/cloudstack/pull/7111#issuecomment-1387592489
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
rohityadavcloud commented on PR #7111:
URL: https://github.com/apache/cloudstack/pull/7111#issuecomment-1387589892
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
rohityadavcloud opened a new pull request, #7111:
URL: https://github.com/apache/cloudstack/pull/7111
On EL7 and EL8, when Marvin is installed and if newer mysql-connector-python
is installed leads to errors which aren't compatible with python 2.7 and 3.6.
--
This is an automated message
blueorangutan commented on PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1387528688
@soreana a Jenkins job has been kicked to build packages. It will be bundled
with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I
make progress.
--
Th
soreana commented on PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1387527090
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
RodrigoDLopez commented on code in PR #6947:
URL: https://github.com/apache/cloudstack/pull/6947#discussion_r1073862795
##
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##
@@ -5398,11 +5403,19 @@ public Pair> startVirtualMach
String password = "saved_pas
sonarcloud[bot] commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1387416494
Kudos, SonarCloud Quality Gate passed! [