DaanHoogland merged PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
blueorangutan commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1977656966
[SF] Trillian test result (tid-9378)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43386 seconds
Marvin logs:
blueorangutan commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1976337974
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To
DaanHoogland commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1976336603
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1975399781
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
GutoVeronezi commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1975383120
@DaanHoogland @JoaoJandre
I think one more round of tests is needed (just for sanity); aside that, I
think this one is good to go.
--
This is an automated message from
blueorangutan commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1975382634
@GutoVeronezi a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make
GutoVeronezi commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1975382530
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hsato03 commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1969571672
> @hsato03, the events are being created correctly and the filter in the UI
is working. However, the `resource` column is empty; it should present the
tariff's name.
>
>
GutoVeronezi commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1962793678
@hsato03, the events are being created correctly and the filter in the UI is
working. However, the `resource` column is empty; it should present the
tariff's name.
DaanHoogland commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1944213634
@hsato03 I think this needs testing but as you guys are the only heavy users
of quota, can you find one of your colleagues to verify this, please?
--
This is an automated
blueorangutan commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1942353163
[SF] Trillian test result (tid-9189)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40247 seconds
Marvin logs:
blueorangutan commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1940740499
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To
DaanHoogland commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1940734465
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1938934280
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1938811982
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make
DaanHoogland commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1938810223
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hsato03 commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1936464995
@DaanHoogland I changed the base branch to 4.18.
Some unrelated labels to the PR were added. Could you remove them please?
--
This is an automated message from the Apache Git
github-actions[bot] commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1936429677
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache
DaanHoogland commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1936159922
> @DaanHoogland @JoaoJandre Maybe we can target it to the 4.18.2. What do
you think?
You'll have to rebase - force push for that @hsato03 otherwise we are
pulling the
JoaoJandre commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1934113718
> @DaanHoogland @JoaoJandre Maybe we can target it to the 4.18.2. What do
you think?
@hsato03 sure
--
This is an automated message from the Apache Git Service.
To respond
github-actions[bot] commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1934110177
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache
vishesh92 commented on code in PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#discussion_r1481007562
##
api/src/main/java/org/apache/cloudstack/quota/QuotaTariff.java:
##
@@ -0,0 +1,7 @@
+package org.apache.cloudstack.quota;
Review Comment:
@hsato03 Please
vishesh92 commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1931444908
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1930654274
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1930566343
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
vishesh92 commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1930553486
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
hsato03 commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1930519189
@DaanHoogland @JoaoJandre Maybe we can target it to the 4.18.2. What do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
DaanHoogland commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1929243937
@hsato03 are we targeting 20 with this PR (cc @JoaoJandre )?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
DaanHoogland commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1929242008
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hsato03 commented on code in PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#discussion_r1478911247
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffCreateCmd.java:
##
@@ -70,6 +71,7 @@ public class QuotaTariffCreateCmd extends
blueorangutan commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1882535743
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1882476714
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
vishesh92 commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1882475037
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
github-actions[bot] commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1836125718
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache
blueorangutan commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1755065897
@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To
DaanHoogland commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1755060306
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
DaanHoogland commented on code in PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#discussion_r1352253932
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffCreateCmd.java:
##
@@ -70,6 +71,7 @@ public class QuotaTariffCreateCmd
blueorangutan commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1754592246
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15.
SL-JID 7292
--
This is an
vishesh92 commented on code in PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#discussion_r1351622203
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffCreateCmd.java:
##
@@ -70,6 +71,7 @@ public class QuotaTariffCreateCmd
blueorangutan commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1754490214
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will
be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make
DaanHoogland commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1754489266
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DaanHoogland commented on code in PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#discussion_r1351608713
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffCreateCmd.java:
##
@@ -70,6 +71,7 @@ public class QuotaTariffCreateCmd
vishesh92 commented on code in PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#discussion_r1350725760
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffCreateCmd.java:
##
@@ -70,6 +71,7 @@ public class QuotaTariffCreateCmd
DaanHoogland commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1746298102
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
codecov[bot] commented on PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#issuecomment-1746297846
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8030?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
> Merging
hsato03 opened a new pull request, #8030:
URL: https://github.com/apache/cloudstack/pull/8030
### Description
While creating, updating or removing a quota tariff there are no events for
any of these actions.
To address that, every time a quota tariff is created, updated or
47 matches
Mail list logo
