[GitHub] janpio closed pull request #895: Minor spelling mistake

2018-10-01 Thread GitBox
janpio closed pull request #895: Minor spelling mistake URL: https://github.com/apache/cordova-docs/pull/895 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

[GitHub] janpio commented on issue #239: Not seeing files that are stored on the Android device

2018-10-01 Thread GitBox
janpio commented on issue #239: Not seeing files that are stored on the Android device URL: https://github.com/apache/cordova-plugin-file/issues/239#issuecomment-425834677 It has not been abandoned, there is just a pretty massive backlog of stuff in general regarding Cordova core plugins

[GitHub] phil4literacy commented on issue #239: Not seeing files that are stored on the Android device

2018-10-01 Thread GitBox
phil4literacy commented on issue #239: Not seeing files that are stored on the Android device URL: https://github.com/apache/cordova-plugin-file/issues/239#issuecomment-425840903 @janpio : That's good to know. Thanks for all your hard work!

[GitHub] Lahrachtdi opened a new issue #35: screen.orientation.lock() is not available on this device.

2018-10-01 Thread GitBox
Lahrachtdi opened a new issue #35: screen.orientation.lock() is not available on this device. URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/35 Getting this error: screen.orientation.lock() is not available on this device. Config: - android platfrom: 7.1.1

[GitHub] janpio opened a new issue #37: [Plugins] Improve plugin tests

2018-10-01 Thread GitBox
janpio opened a new issue #37: [Plugins] Improve plugin tests URL: https://github.com/apache/cordova/issues/37 Change plugin tests to: - [ ] test all relevant platforms - [ ] are structured and built in a similar way - [ ] same libraries and versions - [ ]

svn commit: r1842443 - in /cordova/site/public: docs/en/dev/guide/appdev/privacy/index.html feed.xml

2018-10-01 Thread steven
Author: steven Date: Mon Oct 1 09:26:46 2018 New Revision: 1842443 URL: http://svn.apache.org/viewvc?rev=1842443=rev Log: Updated docs Modified: cordova/site/public/docs/en/dev/guide/appdev/privacy/index.html cordova/site/public/feed.xml Modified:

[cordova-fetch] branch master updated: Collect test coverage during `npm test` (#48)

2018-10-01 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-fetch.git The following commit(s) were added to refs/heads/master by this push: new fef644a Collect test coverage

[cordova-docs] branch master updated: Minor spelling mistake (#895)

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git The following commit(s) were added to refs/heads/master by this push: new 54c9b8e Minor spelling mistake (#895)

[GitHub] janpio commented on issue #895: Minor spelling mistake

2018-10-01 Thread GitBox
janpio commented on issue #895: Minor spelling mistake URL: https://github.com/apache/cordova-docs/pull/895#issuecomment-425834347 Thanks! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] janpio commented on issue #35: screen.orientation.lock() is not available on this device.

2018-10-01 Thread GitBox
janpio commented on issue #35: screen.orientation.lock() is not available on this device. URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/35#issuecomment-425853775 In general I would say: Seems the plugin thinks this functionality is not supported on that device.

[GitHub] helmut opened a new pull request #895: Minor spelling mistake

2018-10-01 Thread GitBox
helmut opened a new pull request #895: Minor spelling mistake URL: https://github.com/apache/cordova-docs/pull/895 Very minor change from "you" to "your". This is an automated message from the Apache Git Service. To

[GitHub] janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425941320 Noticed one more thing in our failing test run on Saucelabs:

[GitHub] janpio edited a comment on issue #320: Get applicationId from package name

2018-10-01 Thread GitBox
janpio edited a comment on issue #320: Get applicationId from package name URL: https://github.com/apache/cordova-plugin-camera/pull/320#issuecomment-425946523 Well, review first ;) (Just noticed the merge _is_ a bit messed up as it pulled in all the changes into your branch

[GitHub] janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425937979 Watching the video of the test run at

[GitHub] squallstar commented on issue #320: Get applicationId from package name

2018-10-01 Thread GitBox
squallstar commented on issue #320: Get applicationId from package name URL: https://github.com/apache/cordova-plugin-camera/pull/320#issuecomment-425938679 Great! Feel free to merge anytime. This is an automated message

[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425938899 So probably better comparison is `cordova-plugin-dialogs`:

[GitHub] janpio commented on issue #320: Get applicationId from package name

2018-10-01 Thread GitBox
janpio commented on issue #320: Get applicationId from package name URL: https://github.com/apache/cordova-plugin-camera/pull/320#issuecomment-425946523 (Just noticed the merge _is_ a bit messed up as it pulled in all the changes into your branch individually, but your actual change is

[GitHub] janpio opened a new issue #38: [Plugins] Test current platforms

2018-10-01 Thread GitBox
janpio opened a new issue #38: [Plugins] Test current platforms URL: https://github.com/apache/cordova/issues/38 iOS 11 and 12? Android 7.1 and 8? This is an automated message from the Apache Git Service. To respond to the

[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425937979 Watching the video of the test run at https://saucelabs.com/beta/tests/7e834da3d10d4f08b614d05fcccdfa39/watch#5

[GitHub] cjpearson commented on issue #88: CB-12479: Add loading spinner for android

2018-10-01 Thread GitBox
cjpearson commented on issue #88: CB-12479: Add loading spinner for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-425937808 @janpio No problem, I had to make another change anyway. The latest commit replaces the deprecated ProgressDialog with a

[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425941092 Observation on the Saucelabs "Commands" tab: No red border for "POST element" line:

[GitHub] sanjeetnonia opened a new issue #107: captureAudio Does not work on oreo

2018-10-01 Thread GitBox
sanjeetnonia opened a new issue #107: captureAudio Does not work on oreo URL: https://github.com/apache/cordova-plugin-media-capture/issues/107 App crash on oreo device when we give pemission for audio record This is an

[GitHub] premtemp1 opened a new issue #258: Not seeing any files on the android device

2018-10-01 Thread GitBox
premtemp1 opened a new issue #258: Not seeing any files on the android device URL: https://github.com/apache/cordova-plugin-file/issues/258 Hello, I trying to read android folder and show the user a list of files but I am NOT seeing any files that I have uploaded in any folders.

[GitHub] premtemp1 commented on issue #254: Cordova plugin file does not work

2018-10-01 Thread GitBox
premtemp1 commented on issue #254: Cordova plugin file does not work URL: https://github.com/apache/cordova-plugin-file/issues/254#issuecomment-426105096 I am having same issue. These are folders that I am traversing var localURLs = [

[GitHub] Ravenstine commented on issue #114: Not working on Android devices

2018-10-01 Thread GitBox
Ravenstine commented on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-426101408 On my Samsung Galaxy S5, the issue has to do with Wi-Fi scanning being enabled. Turning this feature off immediately allows the

[GitHub] janpio commented on a change in pull request #277: Quick CI fixes

2018-10-01 Thread GitBox
janpio commented on a change in pull request #277: Quick CI fixes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/277#discussion_r221564651 ## File path: README.md ## @@ -24,6 +24,11 @@ description: Open an in-app browser window. |AppVeyor|Travis CI|

[GitHub] janpio commented on a change in pull request #277: Quick CI fixes

2018-10-01 Thread GitBox
janpio commented on a change in pull request #277: Quick CI fixes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/277#discussion_r221564605 ## File path: .travis.yml ## @@ -44,36 +52,41 @@ matrix: - platform-tools - tools -

[GitHub] janpio commented on issue #277: Quick CI fixes

2018-10-01 Thread GitBox
janpio commented on issue #277: Quick CI fixes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/277#issuecomment-425863925 What the heck are these changes? Did you do similar commits in other plugin repos?

[GitHub] janpio commented on a change in pull request #277: Quick CI fixes

2018-10-01 Thread GitBox
janpio commented on a change in pull request #277: Quick CI fixes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/277#discussion_r221564560 ## File path: .travis.yml ## @@ -29,11 +33,15 @@ matrix: osx_image: xcode7.3 language: node_js

[cordova-plugin-device] branch master updated: also accept terms for android sdk `android-27`

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-device.git The following commit(s) were added to refs/heads/master by this push: new f870c9b also accept terms for

[cordova-plugin-dialogs] branch master updated: also accept terms for android sdk `android-27`

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-dialogs.git The following commit(s) were added to refs/heads/master by this push: new 6d88a8c also accept terms for

[cordova-plugin-media-capture] branch janpio-travis_node deleted (was 6d65ed1)

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-travis_node in repository https://gitbox.apache.org/repos/asf/cordova-plugin-media-capture.git. was 6d65ed1 Update .travis.yml The revisions that were on this branch are still

[GitHub] janpio closed pull request #106: [WIP] newer node on travis

2018-10-01 Thread GitBox
janpio closed pull request #106: [WIP] newer node on travis URL: https://github.com/apache/cordova-plugin-media-capture/pull/106 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] janpio commented on issue #277: Quick CI fixes

2018-10-01 Thread GitBox
janpio commented on issue #277: Quick CI fixes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/277#issuecomment-425868610 I undid the test disabling and removed the TBD comments. I also didn't find any other plugins altered in a similar way so we can trust tests there.

[GitHub] janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS

2018-10-01 Thread GitBox
janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-425896071 The test failure was caused by a timeout - the test seemed to need a tiny bit more than the 5 minutes that were

[GitHub] janpio commented on issue #37: [Plugins] Improve plugin tests

2018-10-01 Thread GitBox
janpio commented on issue #37: [Plugins] Improve plugin tests URL: https://github.com/apache/cordova/issues/37#issuecomment-425859315 `.travis.yml` has this bit: ``` before_install: - rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm && (cd ~/.nvm && git

[cordova-plugin-camera] branch master updated: also accept terms for android sdk `android-27`

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-camera.git The following commit(s) were added to refs/heads/master by this push: new a346212 also accept terms for

[cordova-plugin-media] branch master updated: also accept terms for android sdk `android-27`

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-media.git The following commit(s) were added to refs/heads/master by this push: new 74772c3 also accept terms for

[cordova-plugin-inappbrowser] branch master updated: also accept terms for android sdk `android-27`

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git The following commit(s) were added to refs/heads/master by this push: new f8ad528 also accept

[cordova-plugin-media-capture] branch master updated: also accept terms for android sdk `android-27`

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-media-capture.git The following commit(s) were added to refs/heads/master by this push: new 59966ac also accept

[cordova-plugin-network-information] branch master updated: also accept terms for android sdk `android-27`

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-network-information.git The following commit(s) were added to refs/heads/master by this push: new 2cde33a also

[GitHub] janpio commented on a change in pull request #159: iPhone XR, XS, XSMax Support

2018-10-01 Thread GitBox
janpio commented on a change in pull request #159: iPhone XR, XS, XSMax Support URL: https://github.com/apache/cordova-plugin-splashscreen/pull/159#discussion_r221582546 ## File path: src/ios/CDVSplashScreen.m ## @@ -175,7 +181,8 @@ - (CDV_iOSDevice) getCurrentDevice

[cordova-paramedic] branch master updated: increase timeout to 10min + clearer output in case this timeout isn't enough

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git The following commit(s) were added to refs/heads/master by this push: new cd41bdc increase timeout to 10min +

[GitHub] janpio commented on issue #36: [Plugins] iOS tests failing across multiple plugins

2018-10-01 Thread GitBox
janpio commented on issue #36: [Plugins] iOS tests failing across multiple plugins URL: https://github.com/apache/cordova/issues/36#issuecomment-425890977 Test failures are actually individual test failures and not a sign for a more general problem.

[GitHub] janpio closed issue #36: [Plugins] iOS tests failing across multiple plugins

2018-10-01 Thread GitBox
janpio closed issue #36: [Plugins] iOS tests failing across multiple plugins URL: https://github.com/apache/cordova/issues/36 This is an automated message from the Apache Git Service. To respond to the message, please log on

[cordova-plugin-file] branch master updated: also accept terms for android sdk `android-27`

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-file.git The following commit(s) were added to refs/heads/master by this push: new 6e7871b also accept terms for

[cordova-plugin-splashscreen] branch master updated: also accept terms for android sdk `android-27`

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-splashscreen.git The following commit(s) were added to refs/heads/master by this push: new e78f1d1 also accept

[GitHub] raphinesse commented on issue #37: [Plugins] Improve plugin tests

2018-10-01 Thread GitBox
raphinesse commented on issue #37: [Plugins] Improve plugin tests URL: https://github.com/apache/cordova/issues/37#issuecomment-425864116 Travis CI itself uses `nvm` to manage different Node.js versions: https://travis-ci.org/raphinesse/cordova-lib/jobs/435129609#L423

[GitHub] janpio commented on issue #37: [Plugins] Improve plugin tests

2018-10-01 Thread GitBox
janpio commented on issue #37: [Plugins] Improve plugin tests URL: https://github.com/apache/cordova/issues/37#issuecomment-425864406 Probably historical reasons plugins are still doing it this way, but can definitely be changed then.

[GitHub] janpio commented on issue #35: [Plugins] Android Tests are failing across multiple plugin repos

2018-10-01 Thread GitBox
janpio commented on issue #35: [Plugins] Android Tests are failing across multiple plugin repos URL: https://github.com/apache/cordova/issues/35#issuecomment-425865533 Solved by adding `,android-27` to the end of the "accept Android SDK terms" command in `.travis.yml`. Currently working

[cordova-plugin-screen-orientation] branch master updated: also accept terms for android sdk `android-27`

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-screen-orientation.git The following commit(s) were added to refs/heads/master by this push: new 9d2a422 also

[cordova-plugin-statusbar] branch master updated: also accept terms for android sdk `android-27`

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-statusbar.git The following commit(s) were added to refs/heads/master by this push: new c8a13b8 also accept terms

[GitHub] janpio edited a comment on issue #37: [Plugins] Improve plugin tests

2018-10-01 Thread GitBox
janpio edited a comment on issue #37: [Plugins] Improve plugin tests URL: https://github.com/apache/cordova/issues/37#issuecomment-425869351 - Chrome is missing for cordova-plugin-file - Idea: Plugins just define the supported platforms, rest is done by some other package that has all

[cordova-lib] branch cross-spawn-test updated (460d3ac -> 883b9a7)

2018-10-01 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a change to branch cross-spawn-test in repository https://gitbox.apache.org/repos/asf/cordova-lib.git. discard 460d3ac TEMP revert to default jasmine reporter discard 2820f58 CB-14166: (cli) Fixed issue

[cordova-lib] 02/02: TEMP revert to default jasmine reporter

2018-10-01 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a commit to branch cross-spawn-test in repository https://gitbox.apache.org/repos/asf/cordova-lib.git commit 883b9a79ab2e0ce96a62b45ba6c0c3d79696ba20 Author: Raphael von der Grün AuthorDate: Sun Sep 16

[cordova-lib] 01/02: CB-14166: (cli) Fixed issue when install plugins on windows

2018-10-01 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a commit to branch cross-spawn-test in repository https://gitbox.apache.org/repos/asf/cordova-lib.git commit 7ac19a8b086e8fa19551cbfc2e188c3bd7072da1 Author: Almir Kadric AuthorDate: Tue Jul 17 03:23:57 2018

[GitHub] janpio commented on a change in pull request #159: iPhone XR, XS, XSMax Support

2018-10-01 Thread GitBox
janpio commented on a change in pull request #159: iPhone XR, XS, XSMax Support URL: https://github.com/apache/cordova-plugin-splashscreen/pull/159#discussion_r221582468 ## File path: src/ios/CDVSplashScreen.m ## @@ -175,7 +181,8 @@ - (CDV_iOSDevice) getCurrentDevice

[cordova-plugin-inappbrowser] branch master updated: reenable testing on all platforms

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git The following commit(s) were added to refs/heads/master by this push: new 0ed0bf5 reenable testing

[cordova-plugin-vibration] branch master updated: also accept terms for android sdk `android-27`

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-vibration.git The following commit(s) were added to refs/heads/master by this push: new 8c8d701 also accept terms

[GitHub] janpio commented on issue #35: [Plugins] Android Tests are failing across multiple plugin repos

2018-10-01 Thread GitBox
janpio commented on issue #35: [Plugins] Android Tests are failing across multiple plugin repos URL: https://github.com/apache/cordova/issues/35#issuecomment-425876329 Fixed all Android tests for plugins. This is an

[GitHub] janpio closed issue #35: [Plugins] Android Tests are failing across multiple plugin repos

2018-10-01 Thread GitBox
janpio closed issue #35: [Plugins] Android Tests are failing across multiple plugin repos URL: https://github.com/apache/cordova/issues/35 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] Stefano1964 commented on a change in pull request #159: iPhone XR, XS, XSMax Support

2018-10-01 Thread GitBox
Stefano1964 commented on a change in pull request #159: iPhone XR, XS, XSMax Support URL: https://github.com/apache/cordova-plugin-splashscreen/pull/159#discussion_r221587761 ## File path: src/ios/CDVSplashScreen.m ## @@ -175,7 +181,8 @@ - (CDV_iOSDevice)

[cordova-plugin-battery-status] branch master updated: add android-27 to `android update sdk -u --filter`

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-battery-status.git The following commit(s) were added to refs/heads/master by this push: new 53beb6d add android-27

[cordova-plugin-geolocation] branch master updated: add android-27 to `android update sdk -u --filter`

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-geolocation.git The following commit(s) were added to refs/heads/master by this push: new 3b1f63a add android-27 to

[GitHub] janpio commented on issue #37: [Plugins] Improve plugin tests

2018-10-01 Thread GitBox
janpio commented on issue #37: [Plugins] Improve plugin tests URL: https://github.com/apache/cordova/issues/37#issuecomment-425862133 Maybe all this repeating stuff should not be handled in the plugin itself? This is an

[GitHub] janpio commented on issue #37: [Plugins] Improve plugin tests

2018-10-01 Thread GitBox
janpio commented on issue #37: [Plugins] Improve plugin tests URL: https://github.com/apache/cordova/issues/37#issuecomment-425869351 - Chrome is missing for cordova-plugin-file - Idea: Plugins just define the supported platforms, rest is done by some other package that has all the

[GitHub] janpio opened a new issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio opened a new issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307 This is the configration that is failing: ``` "os": "linux", "env": "PLATFORM=android-7.0", "jdk": "oraclejdk8", ```

[cordova-paramedic] branch master updated: decrease to 9 min to work around 10min command limit on travis: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git The following commit(s) were added to refs/heads/master by this push: new 5bed039 decrease to 9 min to work

[GitHub] StevenMapes commented on issue #114: Not working on Android devices

2018-10-01 Thread GitBox
StevenMapes commented on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-425990735 I had the same problem with Phonegap and every version of this plugin since 2.4.3 (tested on a OnePlus5). Though even that

[GitHub] charlesverge commented on issue #268: CB-12873: Add customization options for caputre button, resizing of v…

2018-10-01 Thread GitBox
charlesverge commented on issue #268: CB-12873: Add customization options for caputre button, resizing of v… URL: https://github.com/apache/cordova-plugin-camera/pull/268#issuecomment-425989962 @janpio I've rebased the commit, the changes since the last rebase do not affect this code and

[GitHub] janpio commented on issue #286: CB-13307: (Android) Fixed issue when unable to load image with mime t…

2018-10-01 Thread GitBox
janpio commented on issue #286: CB-13307: (Android) Fixed issue when unable to load image with mime t… URL: https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-425996898 And another rebase/merge from `master` to get those tests passing @DavidBriglio?

[GitHub] janpio edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support for iOS

2018-10-01 Thread GitBox
janpio edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-425728887 Simplest answer: Because the testing setup for plugins is all messed up, see a WIP issue here:

[GitHub] janpio commented on issue #242: CB-11714: (windows) added check for encoding in savePhoto() without height/width

2018-10-01 Thread GitBox
janpio commented on issue #242: CB-11714: (windows) added check for encoding in savePhoto() without height/width URL: https://github.com/apache/cordova-plugin-camera/pull/242#issuecomment-426043765 Thanks @DisruptiveMind. Tests are now failing because of ```

[GitHub] janpio commented on issue #133: Added LaunchImageFileCustom for hybrid app and multiples Launch Images

2018-10-01 Thread GitBox
janpio commented on issue #133: Added LaunchImageFileCustom for hybrid app and multiples Launch Images URL: https://github.com/apache/cordova-plugin-splashscreen/pull/133#issuecomment-426044606 Hey, I just fixed the problem that caused Android tests to fail in master. Could you rebase

[cordova-osx] branch master updated: Test Framework Implementation Improvements (#67)

2018-10-01 Thread erisu
This is an automated email from the ASF dual-hosted git repository. erisu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-osx.git The following commit(s) were added to refs/heads/master by this push: new dcdea9a Test Framework Implementation

[GitHub] erisu closed pull request #67: Test Framework Implementation Improvements

2018-10-01 Thread GitBox
erisu closed pull request #67: Test Framework Implementation Improvements URL: https://github.com/apache/cordova-osx/pull/67 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] janpio commented on issue #217: CB-13245: (android) Fix bug caused by negative length reported for an asset

2018-10-01 Thread GitBox
janpio commented on issue #217: CB-13245: (android) Fix bug caused by negative length reported for an asset URL: https://github.com/apache/cordova-plugin-file/pull/217#issuecomment-425912429 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase

[GitHub] janpio commented on issue #216: CB-13208: (windows) Fix `readAsBinaryString` to only read the requested range

2018-10-01 Thread GitBox
janpio commented on issue #216: CB-13208: (windows) Fix `readAsBinaryString` to only read the requested range URL: https://github.com/apache/cordova-plugin-file/pull/216#issuecomment-425912291 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase

[GitHub] janpio commented on issue #211: CB-6938: (fix) on iOS, copyTo should overwrite any existing file

2018-10-01 Thread GitBox
janpio commented on issue #211: CB-6938: (fix) on iOS, copyTo should overwrite any existing file URL: https://github.com/apache/cordova-plugin-file/pull/211#issuecomment-425912239 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR

[GitHub] janpio commented on issue #164: CB-13774: repair broken recording and playback functionality on Android

2018-10-01 Thread GitBox
janpio commented on issue #164: CB-13774: repair broken recording and playback functionality on Android URL: https://github.com/apache/cordova-plugin-media/pull/164#issuecomment-425912074 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this

[cordova-status] branch master updated: Generate table entries for all Cordova repositories (#13)

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-status.git The following commit(s) were added to refs/heads/master by this push: new d43dcc9 Generate table entries for all

[GitHub] janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425921890 Compare the failing test here, to a similarly configured one from another plugin: failing here:

[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425926266 Here is the commit that added the "permissions buster" for Android:

[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425926940 Unfortunately the logs for the last succeeding test run in _this_ repo are not archived on Saucelabs any more, so no

[GitHub] janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425929064 Similar situation in the Appium Server log as before in the normal Appium log: First 281 lines are

[GitHub] janpio commented on issue #88: CB-12479: Add loading spinner for android

2018-10-01 Thread GitBox
janpio commented on issue #88: CB-12479: Add loading spinner for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-425935160 Thanks for the rebase, and sorry I didn't check what repo this PR was in before writing this: `cordova-plugin-inappbrowser`

[cordova-plugin-inappbrowser] 01/01: remove unwanted information in README table

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-remove_data_from_readme_table in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git commit 4dadf6e5890d46c5c9fd290fd5cfc2d79f7a431a Author: Jan Piotrowski

[GitHub] janpio opened a new pull request #308: [WIP] remove unwanted information in README table

2018-10-01 Thread GitBox
janpio opened a new pull request #308: [WIP] remove unwanted information in README table URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/308 ### Platforms affected ### What does this PR do? ### What testing has been done on this change?

[GitHub] luisfernando-rf commented on issue #118: Geolocation Interval position

2018-10-01 Thread GitBox
luisfernando-rf commented on issue #118: Geolocation Interval position URL: https://github.com/apache/cordova-plugin-geolocation/issues/118#issuecomment-425911492 ??? This is an automated message from the Apache Git

[GitHub] janpio commented on issue #136: Add dots spinner loader for android

2018-10-01 Thread GitBox
janpio commented on issue #136: Add dots spinner loader for android URL: https://github.com/apache/cordova-plugin-splashscreen/pull/136#issuecomment-425911693 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid

[GitHub] janpio commented on issue #155: CB-13632: (android) Allow UDP media streaming.

2018-10-01 Thread GitBox
janpio commented on issue #155: CB-13632: (android) Allow UDP media streaming. URL: https://github.com/apache/cordova-plugin-media/pull/155#issuecomment-425911778 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get

[GitHub] janpio commented on issue #165: CB-13852: (iOS) Fix bug prevent error on getPosition

2018-10-01 Thread GitBox
janpio commented on issue #165: CB-13852: (iOS) Fix bug prevent error on getPosition URL: https://github.com/apache/cordova-plugin-media/pull/165#issuecomment-425911880 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This

[GitHub] janpio commented on issue #156: CB-13633: (android) Propagate buffering start/stop events on Android.

2018-10-01 Thread GitBox
janpio commented on issue #156: CB-13633: (android) Propagate buffering start/stop events on Android. URL: https://github.com/apache/cordova-plugin-media/pull/156#issuecomment-425911924 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR

[GitHub] janpio commented on issue #230: CB-13849: (android) getDirectory("") returns current path instead of / path

2018-10-01 Thread GitBox
janpio commented on issue #230: CB-13849: (android) getDirectory("") returns current path instead of / path URL: https://github.com/apache/cordova-plugin-file/pull/230#issuecomment-425912496 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase

[GitHub] janpio commented on issue #268: CB-12873: Add customization options for caputre button, resizing of v…

2018-10-01 Thread GitBox
janpio commented on issue #268: CB-12873: Add customization options for caputre button, resizing of v… URL: https://github.com/apache/cordova-plugin-camera/pull/268#issuecomment-425912660 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this

[GitHub] janpio commented on issue #339: Localizing hardcoded messages

2018-10-01 Thread GitBox
janpio commented on issue #339: Localizing hardcoded messages URL: https://github.com/apache/cordova-plugin-camera/pull/339#issuecomment-425912742 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the

[GitHub] janpio commented on issue #311: CB-13836 Windows phone correct filename

2018-10-01 Thread GitBox
janpio commented on issue #311: CB-13836 Windows phone correct filename URL: https://github.com/apache/cordova-plugin-camera/pull/311#issuecomment-425912543 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of

[GitHub] janpio commented on issue #320: Get applicationId from package name

2018-10-01 Thread GitBox
janpio commented on issue #320: Get applicationId from package name URL: https://github.com/apache/cordova-plugin-camera/pull/320#issuecomment-425912588 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the

[GitHub] squallstar commented on issue #320: Get applicationId from package name

2018-10-01 Thread GitBox
squallstar commented on issue #320: Get applicationId from package name URL: https://github.com/apache/cordova-plugin-camera/pull/320#issuecomment-425917869 @janpio done, can you check if it's correct now? This is what I've done: ``` git remote add edx

[GitHub] janpio closed pull request #107: Remove docs translations

2018-10-01 Thread GitBox
janpio closed pull request #107: Remove docs translations URL: https://github.com/apache/cordova-plugin-dialogs/pull/107 This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   >