[GitHub] [cordova-android] dpogue commented on issue #896: feat: add kotlin support

2020-01-15 Thread GitBox
dpogue commented on issue #896: feat: add kotlin support URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574997513 > @timbru31 I just added the Kotlin source set as well, per your change request's overview comment. The only thing I was not sure is if it was necessary

[GitHub] [cordova-android] codecov-io edited a comment on issue #896: feat: add kotlin support

2020-01-15 Thread GitBox
codecov-io edited a comment on issue #896: feat: add kotlin support URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=h1) Report > Merging

[GitHub] [cordova-android] codecov-io edited a comment on issue #896: feat: add kotlin support

2020-01-15 Thread GitBox
codecov-io edited a comment on issue #896: feat: add kotlin support URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=h1) Report > Merging

[GitHub] [cordova-android] erisu commented on issue #896: feat: add kotlin support

2020-01-15 Thread GitBox
erisu commented on issue #896: feat: add kotlin support URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574996574 @timbru31 I just added the Kotlin source set as well, per your change request's overview comment. The only thing I was not sure is if it was necessary to

[GitHub] [cordova-android] erisu commented on issue #896: feat: add kotlin support

2020-01-15 Thread GitBox
erisu commented on issue #896: feat: add kotlin support URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574994317 @timbru31 I went ahead and created a new Kotlin support PR so we can quickly apply all the changes and improvements to get Kotlin prepared and

[GitHub] [cordova-android] codecov-io commented on issue #896: feat: add kotlin support

2020-01-15 Thread GitBox
codecov-io commented on issue #896: feat: add kotlin support URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=h1) Report > Merging

[GitHub] [cordova-android] erisu commented on issue #441: CB-14089: (android) Add Kotlin support

2020-01-15 Thread GitBox
erisu commented on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-574989908 Hi @joshchandler, I noticed that there was no activity after the "request change" that was posted a week ago. I went ahead and created a

[GitHub] [cordova-android] erisu opened a new pull request #896: dFeat/kotlin support

2020-01-15 Thread GitBox
erisu opened a new pull request #896: dFeat/kotlin support URL: https://github.com/apache/cordova-android/pull/896 ### Motivation and Context To finish off the change requests and close out PR #441 closes: #441 ### Description What this PR does: *

[GitHub] [cordova-android] erisu edited a comment on issue #438: Add support for EnableGoogleServicesPlugin

2020-01-15 Thread GitBox
erisu edited a comment on issue #438: Add support for EnableGoogleServicesPlugin URL: https://github.com/apache/cordova-android/pull/438#issuecomment-574946339 @chemerisuk I do not have an issue ticket regarding the issues I described with the `phonegap-plugin-push` plugin. But, I

[GitHub] [cordova-android] erisu commented on issue #438: Add support for EnableGoogleServicesPlugin

2020-01-15 Thread GitBox
erisu commented on issue #438: Add support for EnableGoogleServicesPlugin URL: https://github.com/apache/cordova-android/pull/438#issuecomment-574946339 @chemerisuk I do not have an issue ticket on the `phonegap-plugin-push` issues I mentioned. But I pushed a PR that briefly explains some

[GitHub] [cordova-windows] breautek commented on issue #374: Cordova Build Android shows error

2020-01-15 Thread GitBox
breautek commented on issue #374: Cordova Build Android shows error URL: https://github.com/apache/cordova-windows/issues/374#issuecomment-574923731 What command line shell are you using? I see windows-style paths, but linux/mac executables are attempted to be executed.

[GitHub] [cordova-windows] buchion opened a new issue #374: Cordova Build Android shows error

2020-01-15 Thread GitBox
buchion opened a new issue #374: Cordova Build Android shows error URL: https://github.com/apache/cordova-windows/issues/374 cordova run android Discovered saved plugin "cordova-plugin-splashscreen". Adding it to the project Failed to restore plugin "cordova-plugin-splashscreen" from

[GitHub] [cordova-plugin-inappbrowser] cedw032 commented on issue #555: IAB.close() called but it was already closed

2020-01-15 Thread GitBox
cedw032 commented on issue #555: IAB.close() called but it was already closed URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/555#issuecomment-574910008 +1 This is an automated message from the Apache Git

[GitHub] [cordova-android] erisu commented on issue #895: feat: move ci to gh-actions

2020-01-15 Thread GitBox
erisu commented on issue #895: feat: move ci to gh-actions URL: https://github.com/apache/cordova-android/pull/895#issuecomment-574909489 Please ignore that the AppVeyor CI service is failing. AppVeyor would be turned off as this would replace it.

[cordova-android] branch master updated: feat: add google services support (#893)

2020-01-15 Thread erisu
This is an automated email from the ASF dual-hosted git repository. erisu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git The following commit(s) were added to refs/heads/master by this push: new a951793 feat: add google services

[GitHub] [cordova-android] erisu merged pull request #893: feat: add google services support

2020-01-15 Thread GitBox
erisu merged pull request #893: feat: add google services support URL: https://github.com/apache/cordova-android/pull/893 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cordova-android] erisu closed pull request #438: Add support for EnableGoogleServicesPlugin

2020-01-15 Thread GitBox
erisu closed pull request #438: Add support for EnableGoogleServicesPlugin URL: https://github.com/apache/cordova-android/pull/438 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cordova-plugin-file] fragatak edited a comment on issue #239: Not seeing files that are stored on the Android device

2020-01-15 Thread GitBox
fragatak edited a comment on issue #239: Not seeing files that are stored on the Android device URL: https://github.com/apache/cordova-plugin-file/issues/239#issuecomment-574849382 I think I have got this working in initial testing. I added `` to the AndroidManifest.xml. I

[GitHub] [cordova-plugin-file] fragatak commented on issue #239: Not seeing files that are stored on the Android device

2020-01-15 Thread GitBox
fragatak commented on issue #239: Not seeing files that are stored on the Android device URL: https://github.com/apache/cordova-plugin-file/issues/239#issuecomment-574849382 I think I have got this working in initial testing. I added to the AndroidManifest.xml. I also

[GitHub] [cordova-docs] brodybits opened a new issue #1051: feature tag seems to be missing in plugin reference

2020-01-15 Thread GitBox
brodybits opened a new issue #1051: feature tag seems to be missing in plugin reference URL: https://github.com/apache/cordova-docs/issues/1051 The feature and param tags are part of the config-file in plugin.xml but seems to be not documented in

[GitHub] [cordova-plugin-splashscreen] dwasyluk commented on issue #197: Android: White screen before splash screen

2020-01-15 Thread GitBox
dwasyluk commented on issue #197: Android: White screen before splash screen URL: https://github.com/apache/cordova-plugin-splashscreen/issues/197#issuecomment-574803429 Thanks @hungtranpg I can confirm that fix works. I was able to just add `true` to the default `AppTheme` and that did

[GitHub] [cordova-plugin-camera] PabbleDabble edited a comment on issue #448: Incorrect Orientation on Windows 10

2020-01-15 Thread GitBox
PabbleDabble edited a comment on issue #448: Incorrect Orientation on Windows 10 URL: https://github.com/apache/cordova-plugin-camera/issues/448#issuecomment-574780339 I'll be picking this ticket up in our upcoming sprint. If anyone is alerted by this message and has any new information,

[GitHub] [cordova-android] bhandaribhumin commented on issue #887: android build error

2020-01-15 Thread GitBox
bhandaribhumin commented on issue #887: android build error URL: https://github.com/apache/cordova-android/issues/887#issuecomment-574792060 i resolve this issue using some tweaks, @tryhardest thanks for your advice and help. cheers  bro 

[GitHub] [cordova] tryhardest edited a comment on issue #185: Deprecated plugins

2020-01-15 Thread GitBox
tryhardest edited a comment on issue #185: Deprecated plugins URL: https://github.com/apache/cordova/issues/185#issuecomment-574777183 To be clear I presume you are only suggesting sunsetting when newer versions of plugins are available aka close-to drop in replacement plugins?

[GitHub] [cordova-plugin-camera] PabbleDabble commented on issue #448: Incorrect Orientation on Windows 10

2020-01-15 Thread GitBox
PabbleDabble commented on issue #448: Incorrect Orientation on Windows 10 URL: https://github.com/apache/cordova-plugin-camera/issues/448#issuecomment-574780339 I'll be picking this ticket up in our upcoming sprint. If anyone is alerted by this message and has any new information, I

[GitHub] [cordova] tryhardest commented on issue #185: Deprecated plugins

2020-01-15 Thread GitBox
tryhardest commented on issue #185: Deprecated plugins URL: https://github.com/apache/cordova/issues/185#issuecomment-574777183 To be clear I presume you are only suggesting sunsetting when newer versions of plugins are available aka close-to drop in replacement plugins? Often new

[GitHub] [cordova-plugin-inappbrowser] brandPittCode closed issue #611: [ Ionic iOS] create window opens a white screen

2020-01-15 Thread GitBox
brandPittCode closed issue #611: [ Ionic iOS] create window opens a white screen URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/611 This is an automated message from the Apache Git Service. To respond to

[GitHub] [cordova-plugin-inappbrowser] brandPittCode commented on issue #611: [ Ionic iOS] create window opens a white screen

2020-01-15 Thread GitBox
brandPittCode commented on issue #611: [ Ionic iOS] create window opens a white screen URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/611#issuecomment-574742212 I was a problem of url encoding This is an

[GitHub] [cordova-android] ZumelzuR commented on issue #678: authenticator.xml resource mipmap/icon not found

2020-01-15 Thread GitBox
ZumelzuR commented on issue #678: authenticator.xml resource mipmap/icon not found URL: https://github.com/apache/cordova-android/issues/678#issuecomment-574714031 Is not a good practice to touch the files inside platforms> (edit or create stuff there), so I recommend to change the ICON

[GitHub] [cordova-plugin-inappbrowser] Hadatko commented on issue #580: Download is not working in a link opened in inappbrowser in ionic 4

2020-01-15 Thread GitBox
Hadatko commented on issue #580: Download is not working in a link opened in inappbrowser in ionic 4 URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/580#issuecomment-574712863 Hi, check this: https://getsatisfaction.com/apperyio/topics/in_app_browser_download_links

[GitHub] [cordova-android] erisu opened a new pull request #895: feat: move ci to gh-actions

2020-01-15 Thread GitBox
erisu opened a new pull request #895: feat: move ci to gh-actions URL: https://github.com/apache/cordova-android/pull/895 ### Motivation and Context Use GitHub Actions instead of third-party CI services. ### Description * Created GitHub Actions Task * Move all Travis

[GitHub] [cordova-plugin-wkwebview-engine] DimitrisMpanis commented on issue #55: Could not signal service com.apple.WebKit.WebContent in ios 11.4.1

2020-01-15 Thread GitBox
DimitrisMpanis commented on issue #55: Could not signal service com.apple.WebKit.WebContent in ios 11.4.1 URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/55#issuecomment-574681778 Should this be included in the official cordova wkwebview plug in?

[GitHub] [cordova-plugin-inappbrowser] brandPittCode opened a new issue #611: [ Ionic iOS] create window opens a white screen

2020-01-15 Thread GitBox
brandPittCode opened a new issue #611: [ Ionic iOS] create window opens a white screen URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/611 ### Issue Type - [x ] Bug Report - [ ] Feature Request - [ ] Support Question ## Description When I open an

[GitHub] [cordova-plugin-inappbrowser] huahuichin commented on issue #374: Webview offset and height issue on ios when `toolbarposition=top`

2020-01-15 Thread GitBox
huahuichin commented on issue #374: Webview offset and height issue on ios when `toolbarposition=top` URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/374#issuecomment-574637160 hi, i still have a problem, how to remove the top gray area

[GitHub] [cordova-plugin-wkwebview-engine] GlausLivio closed issue #129: webrtc issue

2020-01-15 Thread GitBox
GlausLivio closed issue #129: webrtc issue URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/129 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cordova-plugin-wkwebview-engine] GlausLivio opened a new issue #129: webrtc issue

2020-01-15 Thread GitBox
GlausLivio opened a new issue #129: webrtc issue URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/129 I tried to implement video call using webrtc, it is working well on Android, iOS browsers. (ios Safari, too). but It is not working on iOS wkwebview. Do you have

[GitHub] [cordova-plugin-camera] ankitjainOfficial commented on issue #419: No camera permission in Android app.

2020-01-15 Thread GitBox
ankitjainOfficial commented on issue #419: No camera permission in Android app. URL: https://github.com/apache/cordova-plugin-camera/issues/419#issuecomment-574580292 @AmrAlmagic It's been a while, I think the solution was: Adding this to your config.xml ```

[GitHub] [cordova-plugin-camera] ankitjainOfficial edited a comment on issue #419: No camera permission in Android app.

2020-01-15 Thread GitBox
ankitjainOfficial edited a comment on issue #419: No camera permission in Android app. URL: https://github.com/apache/cordova-plugin-camera/issues/419#issuecomment-574580292 @AmrAlmagic It's been a while, I think the solution was: Adding this to your `config.xml` ```

[GitHub] [cordova-android] chemerisuk commented on issue #438: Add support for EnableGoogleServicesPlugin

2020-01-15 Thread GitBox
chemerisuk commented on issue #438: Add support for EnableGoogleServicesPlugin URL: https://github.com/apache/cordova-android/pull/438#issuecomment-574561084 @erisu thanks for the update. Unfortunately my current environment is a bit different now, so it will be hard to test those changes