[incubator-dolphinscheduler-website] branch master updated (a5b861c -> 3a22cd4)
This is an automated email from the ASF dual-hosted git repository. lidongdai pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler-website.git. from a5b861c Merge pull request #163 from lgcareer/master-1.3.1-doc new 1ff2a7e Update site.js new c86fc45 Update site.js new 3a22cd4 Merge pull request #164 from geosmart/patch-1 The 466 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site_config/site.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
[incubator-dolphinscheduler-website] branch master updated (a5b861c -> 3a22cd4)
This is an automated email from the ASF dual-hosted git repository. lidongdai pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler-website.git. from a5b861c Merge pull request #163 from lgcareer/master-1.3.1-doc new 1ff2a7e Update site.js new c86fc45 Update site.js new 3a22cd4 Merge pull request #164 from geosmart/patch-1 The 466 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site_config/site.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
[GitHub] [incubator-dolphinscheduler-website] dailidong merged pull request #164: Update site.js
dailidong merged pull request #164: URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/164 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] geosmart opened a new pull request #164: Update site.js
geosmart opened a new pull request #164: URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/164 fix the development 404 url This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-dolphinscheduler] branch 1.3.2-release updated: [Feture-3327][ui]Add the function of re-uploading files in the resource center (#3394)
This is an automated email from the ASF dual-hosted git repository.
lgcareer pushed a commit to branch 1.3.2-release
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/1.3.2-release by this push:
new 78672b0 [Feture-3327][ui]Add the function of re-uploading files in
the resource center (#3394)
78672b0 is described below
commit 78672b035900d5d06f1f66af73f2ee41f87086ca
Author: break60 <790061...@qq.com>
AuthorDate: Tue Aug 4 11:40:49 2020 +0800
[Feture-3327][ui]Add the function of re-uploading files in the resource
center (#3394)
* Before creating a workflow, clear the canvas
* [Fix-3256][ui] herry pick commit from dev for Fix admin user info update
error (#3306)
* [Feture-3327][ui]Add the function of re-uploading files in the resource
center
Co-authored-by: wuchunfu <319355...@qq.com>
---
.../projects/pages/taskInstance/_source/list.vue | 1 +
.../pages/file/pages/list/_source/list.vue | 18 +-
.../pages/file/pages/subdirectory/_source/list.vue | 18 +-
.../pages/udf/pages/resource/_source/list.vue | 19 +-
.../components/fileUpdate/fileChildReUpdate.vue| 336 +
.../module/components/fileUpdate/fileReUpload.vue | 335
.../src/js/module/components/nav/nav.vue | 89 +-
.../src/js/module/i18n/locale/en_US.js | 1 +
.../src/js/module/i18n/locale/zh_CN.js | 1 +
9 files changed, 814 insertions(+), 4 deletions(-)
diff --git
a/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/taskInstance/_source/list.vue
b/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/taskInstance/_source/list.vue
index cdcf0b0..5fd0392 100644
---
a/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/taskInstance/_source/list.vue
+++
b/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/taskInstance/_source/list.vue
@@ -98,6 +98,7 @@
data-toggle="tooltip"
:title="$t('View log')"
icon="ans-icon-log"
+:disabled="item.taskType==='SUB_PROCESS'? true: false"
@click="_refreshLog(item)">
diff --git
a/dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/file/pages/list/_source/list.vue
b/dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/file/pages/list/_source/list.vue
index 4ccfa2e..4f256f8 100755
---
a/dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/file/pages/list/_source/list.vue
+++
b/dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/file/pages/list/_source/list.vue
@@ -40,7 +40,7 @@
{{$t('Update Time')}}
-
+
{{$t('Operation')}}
@@ -79,6 +79,18 @@
@click="_edit(item,$index)"
icon="ans-icon-edit">
+
+
+
+
{{$t('Update Time')}}
-
+
{{$t('Operation')}}
@@ -79,6 +79,18 @@
@click="_edit(item,$index)"
icon="ans-icon-edit">
+
+
+
+
{{$t('Update Time')}}
-
+
{{$t('Operation')}}
@@ -80,6 +80,16 @@
type="info"
shape="circle"
size="xsmall"
+data-toggle="tooltip"
+:title="$t('ReUpload File')"
+:disabled="item.directory? true: false"
+@click="_reUpload(item)"
+icon="ans-icon-upload">
+
+http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+
+
+
+
+
+{{$t('Drag the file into the current upload window')}}
+
+
+
+
+
+
+
+ {{$t('Drag area upload')}}
+
+
+
+*{{$t('File
Name')}}
+
+
+
+
+
+
+{{$t('Description')}}
+
+
+
+
+
+
+*{{$t('Upload
Files')}}
+
+
+
+
+ {{$t('Upload')}}
+
+
+
+
+
[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #3394: [Feture-3327][ui]Add the function of re-uploading files in the resource center
lgcareer merged pull request #3394: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3394 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] lenboo commented on issue #3387: [Feature][API] Workflow definition add tag filter
lenboo commented on issue #3387: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3387#issuecomment-668359544 this feature is wonderful! i am not the business department, but i think the tag is enough, you can set the tag value 'a-b-c-d' to display the multilevel relationship. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #3394: [Feture-3327][ui]Add the function of re-uploading files in the resource center
break60 opened a new pull request #3394: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3394 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] geosmart edited a comment on issue #249: Lineage data kinship（Lineage数据血缘关系）
geosmart edited a comment on issue #249: URL: https://github.com/apache/incubator-dolphinscheduler/issues/249#issuecomment-668352856 just like airflow ,task have inlets and outlets attribute, user can define the inlets and outlets manualy; and after task finish ,the inlets/outlets will send to metadata server(e.g atlas) how can I impl this in dolphinscheduler? @dailidong This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] geosmart commented on issue #249: Lineage data kinship（Lineage数据血缘关系）
geosmart commented on issue #249: URL: https://github.com/apache/incubator-dolphinscheduler/issues/249#issuecomment-668352856 just like airflow ,task have inlets and outlets attribute, user can define the inlets and outlets manualy; how can I impl this in dolphinscheduler? @dailidong This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] geosmart commented on issue #249: Lineage data kinship（Lineage数据血缘关系）
geosmart commented on issue #249: URL: https://github.com/apache/incubator-dolphinscheduler/issues/249#issuecomment-668351873 > if anybody else also need this feature , please reply "+1", thx > > finally, we will decide which version to implement this feature based on the level of attention. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] geosmart removed a comment on issue #249: Lineage data kinship（Lineage数据血缘关系）
geosmart removed a comment on issue #249: URL: https://github.com/apache/incubator-dolphinscheduler/issues/249#issuecomment-668351788 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] geosmart commented on issue #249: Lineage data kinship（Lineage数据血缘关系）
geosmart commented on issue #249: URL: https://github.com/apache/incubator-dolphinscheduler/issues/249#issuecomment-668351788 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-dolphinscheduler] branch dev updated: [FIX_BUG][*] fix some bugs from sonar analysis (#3322)
This is an automated email from the ASF dual-hosted git repository.
journey pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new 6ecc95a [FIX_BUG][*] fix some bugs from sonar analysis (#3322)
6ecc95a is described below
commit 6ecc95a338fbb73558c983964d2611f3df2e6dc7
Author: CalvinKirs
AuthorDate: Tue Aug 4 10:23:50 2020 +0800
[FIX_BUG][*] fix some bugs from sonar analysis (#3322)
* [FIX_BUG][*] fix some bugs from sonar analysis
* remove invalid single test
* code smell
* remove exception catches that never happen
* delete invalid exception catch
* remove excess locks
* fix e2e test error
* recovery related exception removal
---
.../java/org/apache/dolphinscheduler/api/utils/ZooKeeperState.java | 1 +
.../api/controller/ProcessInstanceControllerTest.java | 3 ++-
.../org/apache/dolphinscheduler/common/shell/AbstractShell.java | 4 ++--
.../java/org/apache/dolphinscheduler/common/thread/ThreadUtils.java | 4 +++-
.../org/apache/dolphinscheduler/common/utils/PropertyUtilsTest.java | 2 +-
.../apache/dolphinscheduler/dao/mapper/AccessTokenMapperTest.java | 1 -
.../org/apache/dolphinscheduler/dao/mapper/AlertMapperTest.java | 1 -
.../org/apache/dolphinscheduler/dao/mapper/CommandMapperTest.java | 1 -
.../apache/dolphinscheduler/dao/mapper/DataSourceMapperTest.java| 1 -
.../dolphinscheduler/dao/mapper/ProcessInstanceMapperTest.java | 2 +-
.../server/master/processor/queue/TaskResponseService.java | 1 +
.../dolphinscheduler/server/master/runner/MasterExecThread.java | 1 +
.../server/master/runner/MasterSchedulerService.java| 6 --
.../java/org/apache/dolphinscheduler/service/log/LogPromise.java| 1 +
.../apache/dolphinscheduler/service/zk/ZookeeperCachedOperator.java | 1 +
15 files changed, 18 insertions(+), 12 deletions(-)
diff --git
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/ZooKeeperState.java
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/ZooKeeperState.java
index 55bb3d3..ea458c9 100644
---
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/ZooKeeperState.java
+++
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/ZooKeeperState.java
@@ -149,6 +149,7 @@ public class ZooKeeperState {
return sendThread.ret;
} catch (InterruptedException e) {
logger.error("send " + cmd + " to server " + host + ":"
+ port + " failed!", e);
+ Thread.currentThread().interrupt();
}
return "";
}
diff --git
a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/ProcessInstanceControllerTest.java
b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/ProcessInstanceControllerTest.java
index 96fbe4c..5189097 100644
---
a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/ProcessInstanceControllerTest.java
+++
b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/ProcessInstanceControllerTest.java
@@ -74,7 +74,8 @@ public class ProcessInstanceControllerTest extends
AbstractControllerTest {
.andReturn();
Result result =
JSONUtils.parseObject(mvcResult.getResponse().getContentAsString(),
Result.class);
-
Assert.assertEquals(Status.PROJECT_NOT_FOUNT,result.getCode().intValue());
+assert result != null;
+
Assert.assertEquals(Status.PROJECT_NOT_FOUNT.getCode(),result.getCode().intValue());
logger.info(mvcResult.getResponse().getContentAsString());
}
diff --git
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/shell/AbstractShell.java
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/shell/AbstractShell.java
index aafdb86..9a24fdb 100644
---
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/shell/AbstractShell.java
+++
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/shell/AbstractShell.java
@@ -78,7 +78,7 @@ public abstract class AbstractShell {
/**
* If or not script finished executing
*/
- private volatile AtomicBoolean completed;
+ private AtomicBoolean completed;
public AbstractShell() {
this(0L);
@@ -202,7 +202,7 @@ public abstract class AbstractShell {
} catch (InterruptedException ie) {
logger.warn("Interrupted while reading the error and in stream", ie);
}
- completed.set(true);
+ completed.compareAndSet(false,true);
//the timeout thread handling
//taken care in finally block
if (exitCode != 0 || errMsg.length() > 0) {
diff --git
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #3322: [FIX_BUG][*] fix some bugs from sonar analysis
qiaozhanwei merged pull request #3322: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3322 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #3388: Before creating a workflow, clear the canvas
qiaozhanwei merged pull request #3388: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3388 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] xingchun-chen opened a new issue #3393: [Bug][api] view the log of the subtask, prompt "task instance does not exist"
xingchun-chen opened a new issue #3393: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3393 Click "View Log" of the subtask, prompt "The task instance does not exist"  **Which version of Dolphin Scheduler:** -[1.3.2-release] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-dolphinscheduler] branch 1.3.2-release updated: Before creating a workflow, clear the canvas (#3388)
This is an automated email from the ASF dual-hosted git repository.
journey pushed a commit to branch 1.3.2-release
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/1.3.2-release by this push:
new 811fd48 Before creating a workflow, clear the canvas (#3388)
811fd48 is described below
commit 811fd48f0a27b3112092b4f8b4fbeb5d55cf2da0
Author: break60 <790061...@qq.com>
AuthorDate: Tue Aug 4 10:22:00 2020 +0800
Before creating a workflow, clear the canvas (#3388)
* Before creating a workflow, clear the canvas
* [Fix-3256][ui] herry pick commit from dev for Fix admin user info update
error (#3306)
Co-authored-by: wuchunfu <319355...@qq.com>
---
.../src/js/conf/home/pages/dag/_source/dag.js| 12 +---
.../release-1.0.0_schema/mysql/dolphinscheduler_dml.sql | 2 +-
.../release-1.2.0_schema/postgresql/dolphinscheduler_dml.sql | 2 +-
sql/dolphinscheduler-postgre.sql | 2 +-
sql/dolphinscheduler_mysql.sql | 2 +-
5 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.js
b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.js
index ff8a452..5a41091 100644
--- a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.js
+++ b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.js
@@ -52,7 +52,9 @@ Dag.prototype.setConfig = function (o) {
*/
Dag.prototype.create = function () {
const self = this
- jsPlumb.ready(() => {
+ let plumbIns = jsPlumb.getInstance()
+ plumbIns.reset()
+ plumbIns.ready(() => {
JSP.init({
dag: this.dag,
instance: this.instance,
@@ -304,7 +306,9 @@ Dag.prototype.backfill = function (arg) {
locationsValue = dataObject
const self = this
-jsPlumb.ready(() => {
+let plumbIns = jsPlumb.getInstance()
+plumbIns.reset()
+plumbIns.ready(() => {
JSP.init({
dag: this.dag,
instance: this.instance,
@@ -326,7 +330,9 @@ Dag.prototype.backfill = function (arg) {
})
} else {
const self = this
-jsPlumb.ready(() => {
+let plumbIns = jsPlumb.getInstance()
+plumbIns.reset()
+plumbIns.ready(() => {
JSP.init({
dag: this.dag,
instance: this.instance,
diff --git a/sql/create/release-1.0.0_schema/mysql/dolphinscheduler_dml.sql
b/sql/create/release-1.0.0_schema/mysql/dolphinscheduler_dml.sql
index e8c797b..fd65d30 100644
--- a/sql/create/release-1.0.0_schema/mysql/dolphinscheduler_dml.sql
+++ b/sql/create/release-1.0.0_schema/mysql/dolphinscheduler_dml.sql
@@ -16,7 +16,7 @@
*/
-- Records of t_escheduler_user,user : admin , password : dolphinscheduler123
-INSERT INTO `t_escheduler_user` VALUES ('1', 'admin',
'7ad2410b2f4c074479a8937a28a22b8f', '0', 'x...@qq.com', 'xx', '0', '2018-03-27
15:48:50', '2018-10-24 17:40:22');
+INSERT INTO `t_escheduler_user` VALUES ('1', 'admin',
'7ad2410b2f4c074479a8937a28a22b8f', '0', 'x...@qq.com', '', '0', '2018-03-27
15:48:50', '2018-10-24 17:40:22');
INSERT INTO `t_escheduler_alertgroup` VALUES (1, 'default admin warning
group', '0', 'default admin warning group','2018-11-29 10:20:39', '2018-11-29
10:20:39');
INSERT INTO `t_escheduler_relation_user_alertgroup` VALUES ('1', '1', '1',
'2018-11-29 10:22:33', '2018-11-29 10:22:33');
diff --git
a/sql/create/release-1.2.0_schema/postgresql/dolphinscheduler_dml.sql
b/sql/create/release-1.2.0_schema/postgresql/dolphinscheduler_dml.sql
index 4b83d78..d075cab 100644
--- a/sql/create/release-1.2.0_schema/postgresql/dolphinscheduler_dml.sql
+++ b/sql/create/release-1.2.0_schema/postgresql/dolphinscheduler_dml.sql
@@ -16,7 +16,7 @@
*/
-- Records of t_ds_user，user : admin , password : dolphinscheduler123
-INSERT INTO
t_ds_user(user_name,user_password,user_type,email,phone,tenant_id,create_time,update_time)
VALUES ('admin', '7ad2410b2f4c074479a8937a28a22b8f', '0', 'x...@qq.com', 'xx',
'0', '2018-03-27 15:48:50', '2018-10-24 17:40:22');
+INSERT INTO
t_ds_user(user_name,user_password,user_type,email,phone,tenant_id,create_time,update_time)
VALUES ('admin', '7ad2410b2f4c074479a8937a28a22b8f', '0', 'x...@qq.com', '',
'0', '2018-03-27 15:48:50', '2018-10-24 17:40:22');
-- Records of t_ds_alertgroup，dolphinscheduler warning group
INSERT INTO
t_ds_alertgroup(group_name,group_type,description,create_time,update_time)
VALUES ('dolphinscheduler warning group', '0', 'dolphinscheduler warning
group','2018-11-29 10:20:39', '2018-11-29 10:20:39');
diff --git a/sql/dolphinscheduler-postgre.sql b/sql/dolphinscheduler-postgre.sql
index b16965a..df93c1b 100644
--- a/sql/dolphinscheduler-postgre.sql
+++ b/sql/dolphinscheduler-postgre.sql
@@ -750,7 +750,7 @@ ALTER TABLE t_ds_worker_server ALTER COLUMN id SET DEFAULT
NEXTVAL('t_ds_worker_
-- Records of t_ds_user?user : admin , password :
[GitHub] [incubator-dolphinscheduler] Jops-data closed issue #3353: Modify the application.properties What service do I need to restart to make it work
Jops-data closed issue #3353: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] Jops-data commented on issue #3353: Modify the application.properties What service do I need to restart to make it work
Jops-data commented on issue #3353: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3353#issuecomment-668320725 That's OK. Thank you very much! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] JinyLeeChina commented on pull request #3300: [BugFix] isssue #3299
JinyLeeChina commented on pull request #3300: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3300#issuecomment-668340296 Update actions.js fixed #3351 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] gabrywu edited a comment on pull request #3322: [FIX_BUG][*] fix some bugs from sonar analysis
gabrywu edited a comment on pull request #3322: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3322#issuecomment-668339935 @CalvinKirs Let's invite @qiaozhanwei @dailidong to review this PR, if there're no opposite suggestions, PR can be merged This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] gabrywu commented on pull request #3322: [FIX_BUG][*] fix some bugs from sonar analysis
gabrywu commented on pull request #3322: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3322#issuecomment-668339935 Let's invite @qiaozhanwei @dailidong to review this PR, if there're no opposite suggestions, PR can be merged This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] BoYiZhang commented on issue #3387: [Feature][API] Workflow definition add tag filter
BoYiZhang commented on issue #3387: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3387#issuecomment-668325839 > Yes, I think this feature is valuable. Maybe we can design it more functional, for example, using folder to manage workflow. > Or some companies have datamap, we can add the front-end url to locate the workflow. > > 我觉得这个feature是很有价值的。我觉得可以集思广益多想一下把这个功能做的更强大一点，比如使用文件夹管理。 > 并且还有一个想法，有些公司是有xx地图类的应用的，我们也可以加一个前端locate url(比如直接通过名称)，通过xx地图直接能跳转到工作流页面。 Yes, our business department's requirement is to be able to build a folder for display. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] glxfeng closed issue #3391: 怎么指定maste选择worker的策略？ How to set the strategy for master choose worker?
glxfeng closed issue #3391: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3391 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] cpsky opened a new issue #3392: [Feature][Api] Admin can activate user registerd by themselves
cpsky opened a new issue #3392: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3392 **Describe the feature** Admin can activate user registerd by themselves，user-self register api has completed. https://github.com/apache/incubator-dolphinscheduler/commit/d4d6aded1184b803557f444c42253d02887995b9 **Describe the solution you'd like** https://lists.apache.org/thread.html/r285280835025aaac4d610c5614f89948de2d1938843c4b0bcb3fb7e3%40%3Cdev.dolphinscheduler.apache.org%3E This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on issue #3387: [Feature][API] Workflow definition add tag filter
yangyichao-mango edited a comment on issue #3387: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3387#issuecomment-668003332 Yes, I think this feature is valuable. Maybe we can design it more functional, for example, using folder to manage workflow. Or some companies have datamap, we can add the front-end url to locate the workflow. 我觉得这个feature是很有价值的。我觉得可以集思广益多想一下把这个功能做的更强大一点，比如使用文件夹管理。 并且还有一个想法，有些公司是有xx地图类的应用的，我们也可以加一个前端locate url(比如直接通过名称)，通过xx地图直接能跳转到工作流页面。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #3391: 怎么指定maste选择worker的策略？ How to set the strategy for master choose worker?
yangyichao-mango commented on issue #3391: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3391#issuecomment-668010129 Tag: could be closed. @yangyichao-mango This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on issue #3387: [Feature][API] Workflow definition add tag filter
yangyichao-mango edited a comment on issue #3387: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3387#issuecomment-668003332 Yes, I think this feature is valuable. Maybe we can design it more functional, for example, using folder to manage workflow. Or some companies have datamap, we can add the front-end url to locate the workflow. 我觉得这个feature是很有价值的。我觉得可以集思广益多想一下把这个功能做的更强大一点，比如使用文件夹管理。 并且还有一个想法，有些公司是有xx地图类的应用的，我们也可以加一个前端locate url，通过xx地图直接能跳转到工作流页面。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #3387: [Feature][API] Workflow definition add tag filter
yangyichao-mango commented on issue #3387: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3387#issuecomment-668003332 > > Hi, > > I think we can first to improvement the search, expand the search to more fields like `desc`. Search is more basic function.#3170 > >  > > I know what you mean. In fact, we are already using the query extension. > > We're working on the middle platform > > In data modeling, data should be divided into multiple layers > > Each layer has a special meaning > > In this way, the current scheduling can only display one level, not multiple levels > > It's not intuitive enough Yes, I think this feature is valuable. Maybe we can design it more functional, for example, using folder to manage workflow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on issue #3391: 怎么指定maste选择worker的策略？ How to set the strategy for master choose worker?
yangyichao-mango edited a comment on issue #3391: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3391#issuecomment-668001974 Hi, You can configure `master.host.selector:RANDOM` in `master.properties`. RANDOM, ROUNDROBIN, LOWERWEIGHT This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #3391: 怎么指定maste选择worker的策略？ How to set the strategy for master choose worker?
yangyichao-mango commented on issue #3391: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3391#issuecomment-668001974 Hi, You can configure `master.host.selector:lowerWeight` in `master.properties`. RANDOM, ROUNDROBIN, LOWERWEIGHT This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] BoYiZhang commented on issue #3387: [Feature][API] Workflow definition add tag filter
BoYiZhang commented on issue #3387: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3387#issuecomment-667999749 > Hi, > I think we can first to improvement the search, expand the search to more fields like `desc`. Search is more basic function.#3170 > >  I know what you mean. In fact, we are already using the query extension. -- We're working on the middle platform In data modeling, data should be divided into multiple layers Each layer has a special meaning In this way, the current scheduling can only display one level, not multiple levels It's not intuitive enough This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #3387: [Feature][API] Workflow definition add tag filter
yangyichao-mango commented on issue #3387: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3387#issuecomment-667994003 Hi, I think we can first to improvement the search, expand the search to more fields like `desc`. Search is more basic function.#3170  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] glxfeng opened a new issue #3391: 怎么指定maste选择worker的策略？ How to set the strategy for master choose worker?
glxfeng opened a new issue #3391: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3391 1.3的更新日志里说maste选择worker有3种策略（Random，RoundRobin和基于cpu和内存加权），这个在哪里设置？ According to the changelog for version 1.3，when master choose worker，it has three choices(Random, RoundRobin, and linear weighted based on cpu and memory)，how to set it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #3390: [Bug][api] Run hive task, udf resource path is incorrect
xingchun-chen commented on issue #3390: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3390#issuecomment-667926675 @lgcareer please fix it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] xingchun-chen opened a new issue #3390: [Bug][api] Run hive task, udf resource path is incorrect
xingchun-chen opened a new issue #3390: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3390 1. Run hive task 2.Find the udf resource path of d is incorrect,As shown in the figure below, a "/" is missing after udfs   **Which version of Dolphin Scheduler:** -[1.3.2-release] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask
yangyichao-mango commented on pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#issuecomment-667912862 Hi, Please add test case for your new code in `TaskInstance` to resolve this sonar fail.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask
sonarcloud[bot] removed a comment on pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#issuecomment-667897099 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3385=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask
sonarcloud[bot] commented on pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#issuecomment-667898732 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3385=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask
sonarcloud[bot] commented on pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#issuecomment-667897099 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3385=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask
sonarcloud[bot] removed a comment on pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#issuecomment-667688525 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3385=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3385=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask
yangyichao-mango commented on a change in pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464268239 ## File path: dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/ConditionsTaskTest.java ## @@ -17,7 +17,16 @@ package org.apache.dolphinscheduler.server.master; Review comment: Hi, I checkout to your branch and found that the `ConditionsTaskTest.java` is not in the test case includer. Please add the test to root pom.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask
yangyichao-mango commented on a change in pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464259687 ## File path: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java ## @@ -16,19 +16,18 @@ */ package org.apache.dolphinscheduler.dao.entity; -import com.baomidou.mybatisplus.annotation.IdType; -import com.baomidou.mybatisplus.annotation.TableField; -import com.fasterxml.jackson.annotation.JsonFormat; import org.apache.dolphinscheduler.common.enums.ExecutionStatus; import org.apache.dolphinscheduler.common.enums.Flag; import org.apache.dolphinscheduler.common.enums.Priority; import org.apache.dolphinscheduler.common.enums.TaskType; import org.apache.dolphinscheduler.common.model.TaskNode; -import org.apache.dolphinscheduler.common.utils.*; +import org.apache.dolphinscheduler.common.utils.JSONUtils; + import com.baomidou.mybatisplus.annotation.IdType; +import com.baomidou.mybatisplus.annotation.TableField; import com.baomidou.mybatisplus.annotation.TableId; import com.baomidou.mybatisplus.annotation.TableName; -import org.apache.dolphinscheduler.common.utils.JSONUtils; +import com.fasterxml.jackson.annotation.JsonFormat; Review comment: The `JsonFormat` is not unused. Please delete. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask
yangyichao-mango commented on a change in pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464259687 ## File path: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java ## @@ -16,19 +16,18 @@ */ package org.apache.dolphinscheduler.dao.entity; -import com.baomidou.mybatisplus.annotation.IdType; -import com.baomidou.mybatisplus.annotation.TableField; -import com.fasterxml.jackson.annotation.JsonFormat; import org.apache.dolphinscheduler.common.enums.ExecutionStatus; import org.apache.dolphinscheduler.common.enums.Flag; import org.apache.dolphinscheduler.common.enums.Priority; import org.apache.dolphinscheduler.common.enums.TaskType; import org.apache.dolphinscheduler.common.model.TaskNode; -import org.apache.dolphinscheduler.common.utils.*; +import org.apache.dolphinscheduler.common.utils.JSONUtils; + import com.baomidou.mybatisplus.annotation.IdType; +import com.baomidou.mybatisplus.annotation.TableField; import com.baomidou.mybatisplus.annotation.TableId; import com.baomidou.mybatisplus.annotation.TableName; -import org.apache.dolphinscheduler.common.utils.JSONUtils; +import com.fasterxml.jackson.annotation.JsonFormat; Review comment: The `JsonFormat` is not unused. Please delete. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask
yangyichao-mango commented on a change in pull request #3385:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464259230
##
File path:
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
##
@@ -391,7 +391,12 @@ private Constants() {
public static final int RPC_PORT = 50051;
/**
- * forbid running task
+ * task can be run normally
+ */
+public static final String FLOWNODE_RUN_FLAG_NORMAL = "NORMAL";
Review comment:
Hi,
Good job, but there is no necessary to add the `FLOWNODE_RUN_FLAG_NORMAL` in
Constants just for test case.
If you want to add the constant, you can directly add
`FLOWNODE_RUN_FLAG_NORMAL` in `ConditionsTaskTest`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] hsupu commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask
hsupu commented on a change in pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464252205 ## File path: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java ## @@ -16,19 +16,18 @@ */ package org.apache.dolphinscheduler.dao.entity; -import com.baomidou.mybatisplus.annotation.IdType; -import com.baomidou.mybatisplus.annotation.TableField; -import com.fasterxml.jackson.annotation.JsonFormat; import org.apache.dolphinscheduler.common.enums.ExecutionStatus; import org.apache.dolphinscheduler.common.enums.Flag; import org.apache.dolphinscheduler.common.enums.Priority; import org.apache.dolphinscheduler.common.enums.TaskType; import org.apache.dolphinscheduler.common.model.TaskNode; -import org.apache.dolphinscheduler.common.utils.*; +import org.apache.dolphinscheduler.common.utils.JSONUtils; + import com.baomidou.mybatisplus.annotation.IdType; +import com.baomidou.mybatisplus.annotation.TableField; import com.baomidou.mybatisplus.annotation.TableId; import com.baomidou.mybatisplus.annotation.TableName; -import org.apache.dolphinscheduler.common.utils.JSONUtils; +import com.fasterxml.jackson.annotation.JsonFormat; Review comment: > Why change common.utils.JSONUtils to jackson.annotation.JsonFormat ? A import refactoring happened here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] hsupu commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask
hsupu commented on a change in pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464252205 ## File path: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java ## @@ -16,19 +16,18 @@ */ package org.apache.dolphinscheduler.dao.entity; -import com.baomidou.mybatisplus.annotation.IdType; -import com.baomidou.mybatisplus.annotation.TableField; -import com.fasterxml.jackson.annotation.JsonFormat; import org.apache.dolphinscheduler.common.enums.ExecutionStatus; import org.apache.dolphinscheduler.common.enums.Flag; import org.apache.dolphinscheduler.common.enums.Priority; import org.apache.dolphinscheduler.common.enums.TaskType; import org.apache.dolphinscheduler.common.model.TaskNode; -import org.apache.dolphinscheduler.common.utils.*; +import org.apache.dolphinscheduler.common.utils.JSONUtils; + import com.baomidou.mybatisplus.annotation.IdType; +import com.baomidou.mybatisplus.annotation.TableField; import com.baomidou.mybatisplus.annotation.TableId; import com.baomidou.mybatisplus.annotation.TableName; -import org.apache.dolphinscheduler.common.utils.JSONUtils; +import com.fasterxml.jackson.annotation.JsonFormat; Review comment: > Why change common.utils.JSONUtils to jackson.annotation.JsonFormat ? A import auto refactoring happened here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] hsupu commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask
hsupu commented on a change in pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464252205 ## File path: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java ## @@ -16,19 +16,18 @@ */ package org.apache.dolphinscheduler.dao.entity; -import com.baomidou.mybatisplus.annotation.IdType; -import com.baomidou.mybatisplus.annotation.TableField; -import com.fasterxml.jackson.annotation.JsonFormat; import org.apache.dolphinscheduler.common.enums.ExecutionStatus; import org.apache.dolphinscheduler.common.enums.Flag; import org.apache.dolphinscheduler.common.enums.Priority; import org.apache.dolphinscheduler.common.enums.TaskType; import org.apache.dolphinscheduler.common.model.TaskNode; -import org.apache.dolphinscheduler.common.utils.*; +import org.apache.dolphinscheduler.common.utils.JSONUtils; + import com.baomidou.mybatisplus.annotation.IdType; +import com.baomidou.mybatisplus.annotation.TableField; import com.baomidou.mybatisplus.annotation.TableId; import com.baomidou.mybatisplus.annotation.TableName; -import org.apache.dolphinscheduler.common.utils.JSONUtils; +import com.fasterxml.jackson.annotation.JsonFormat; Review comment: A import refactoring happened here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] Jave-Chen commented on pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask
Jave-Chen commented on pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#issuecomment-667871328 Sonar Analysis failed, you can see more at https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3385=new_coverage=list This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] Jave-Chen commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask
Jave-Chen commented on a change in pull request #3385: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464251296 ## File path: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java ## @@ -16,19 +16,18 @@ */ package org.apache.dolphinscheduler.dao.entity; -import com.baomidou.mybatisplus.annotation.IdType; -import com.baomidou.mybatisplus.annotation.TableField; -import com.fasterxml.jackson.annotation.JsonFormat; import org.apache.dolphinscheduler.common.enums.ExecutionStatus; import org.apache.dolphinscheduler.common.enums.Flag; import org.apache.dolphinscheduler.common.enums.Priority; import org.apache.dolphinscheduler.common.enums.TaskType; import org.apache.dolphinscheduler.common.model.TaskNode; -import org.apache.dolphinscheduler.common.utils.*; +import org.apache.dolphinscheduler.common.utils.JSONUtils; + import com.baomidou.mybatisplus.annotation.IdType; +import com.baomidou.mybatisplus.annotation.TableField; import com.baomidou.mybatisplus.annotation.TableId; import com.baomidou.mybatisplus.annotation.TableName; -import org.apache.dolphinscheduler.common.utils.JSONUtils; +import com.fasterxml.jackson.annotation.JsonFormat; Review comment: Why change common.utils.JSONUtils to jackson.annotation.JsonFormat ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3388: Before creating a workflow, clear the canvas
sonarcloud[bot] commented on pull request #3388: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3388#issuecomment-667835582 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3388=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3388=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3388=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3388=new_duplicated_lines_density=list) The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3388: Before creating a workflow, clear the canvas
sonarcloud[bot] removed a comment on pull request #3388: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3388#issuecomment-667824920 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3388=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3388=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3388=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3388=new_duplicated_lines_density=list) The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3388: Before creating a workflow, clear the canvas
sonarcloud[bot] commented on pull request #3388: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3388#issuecomment-667824920 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3388=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3388=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3388=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3388=new_duplicated_lines_density=list) The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3388: Before creating a workflow, clear the canvas
sonarcloud[bot] removed a comment on pull request #3388: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3388#issuecomment-667781357 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3388=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3388=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3388=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3388=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3388=new_duplicated_lines_density=list) The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
