[GitHub] [incubator-doris] imay commented on a change in pull request #1816: v2 segment support string encode(#1766)

imay commented on a change in pull request #1816: v2 segment support string encode(#1766) URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r329406093 ## File path: be/src/olap/types.h ## @@ -568,6 +577,13 @@ struct FieldTypeTraits : public BaseFieldtype

[GitHub] [incubator-doris] imay commented on a change in pull request #1816: v2 segment support string encode(#1766)

imay commented on a change in pull request #1816: v2 segment support string encode(#1766) URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r329392626 ## File path: be/src/olap/rowset/segment_v2/column_reader.cpp ## @@ -426,6 +431,20 @@ Status FileColumnI

[GitHub] [incubator-doris] imay commented on a change in pull request #1816: v2 segment support string encode(#1766)

imay commented on a change in pull request #1816: v2 segment support string encode(#1766) URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r329393936 ## File path: be/src/olap/types.h ## @@ -568,6 +577,13 @@ struct FieldTypeTraits : public BaseFieldtype

[GitHub] [incubator-doris] imay commented on a change in pull request #1816: v2 segment support string encode(#1766)

imay commented on a change in pull request #1816: v2 segment support string encode(#1766) URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r326849242 ## File path: be/src/olap/rowset/segment_v2/column_reader.cpp ## @@ -166,6 +167,24 @@ void ColumnReader:

[GitHub] [incubator-doris] imay commented on a change in pull request #1816: v2 segment support string encode(#1766)

imay commented on a change in pull request #1816: v2 segment support string encode(#1766) URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r326849634 ## File path: be/src/olap/rowset/segment_v2/column_reader.h ## @@ -103,6 +106,9 @@ class ColumnReader {

[GitHub] [incubator-doris] imay commented on a change in pull request #1816: v2 segment support string encode(#1766)

imay commented on a change in pull request #1816: v2 segment support string encode(#1766) URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r325480215 ## File path: be/src/util/arena.cpp ## @@ -59,6 +60,7 @@ char* Arena::AllocateAligned(size_t bytes) {

[GitHub] [incubator-doris] imay commented on a change in pull request #1816: v2 segment support string encode(#1766)

imay commented on a change in pull request #1816: v2 segment support string encode(#1766) URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r325261462 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -173,6 +189,7 @@ Status BinaryDic

[GitHub] [incubator-doris] imay commented on a change in pull request #1816: v2 segment support string encode(#1766)

imay commented on a change in pull request #1816: v2 segment support string encode(#1766) URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r325260234 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -102,7 +102,16 @@ Slice BinaryDic

[GitHub] [incubator-doris] imay commented on a change in pull request #1816: v2 segment support string encode(#1766)

imay commented on a change in pull request #1816: v2 segment support string encode(#1766) URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r325262158 ## File path: be/src/util/arena.cpp ## @@ -59,6 +60,7 @@ char* Arena::AllocateAligned(size_t bytes) {