[GitHub] bhrgv-bolla opened a new issue #6509: New Feature : Cluster Rating

2018-10-23 Thread GitBox
bhrgv-bolla opened a new issue #6509: New Feature : Cluster Rating URL: https://github.com/apache/incubator-druid/issues/6509 @fjy Please review. Druid has a well thought out cluster setup. It would be great to have an endpoint to see if the cluster is setup to make the best

[GitHub] jsun98 commented on issue #6508: fix KafkaSupervisor stats report error

2018-10-23 Thread GitBox
jsun98 commented on issue #6508: fix KafkaSupervisor stats report error URL: https://github.com/apache/incubator-druid/pull/6508#issuecomment-432508275 @jihoonson thanks for the comment. In `getCurrentTotalStats()` in `KafkaSupervisor` the code ```java for (int groupId :

[GitHub] jihoonson commented on issue #6508: fix KafkaSupervisor stats report error

2018-10-23 Thread GitBox
jihoonson commented on issue #6508: fix KafkaSupervisor stats report error URL: https://github.com/apache/incubator-druid/pull/6508#issuecomment-432477708 @jsun98 thanks for the PR. I guess `SeekableStreamSupervisor` is from another PR you're working on, but it's difficult to find the

[GitHub] jsun98 opened a new pull request #6508: fix KafkaSupervisor stats report error

2018-10-23 Thread GitBox
jsun98 opened a new pull request #6508: fix KafkaSupervisor stats report error URL: https://github.com/apache/incubator-druid/pull/6508 ``` HTTP ERROR 500 Problem accessing /druid/indexer/v1/supervisor/twitter-523d/stats. Reason: Server Error Caused by:

[GitHub] jihoonson commented on a change in pull request #6505: Add default comparison to HavingSpecMetricComparator for custom Aggregator types

2018-10-23 Thread GitBox
jihoonson commented on a change in pull request #6505: Add default comparison to HavingSpecMetricComparator for custom Aggregator types URL: https://github.com/apache/incubator-druid/pull/6505#discussion_r227612116 ## File path:

[GitHub] jihoonson commented on a change in pull request #6505: Add default comparison to HavingSpecMetricComparator for custom Aggregator types

2018-10-23 Thread GitBox
jihoonson commented on a change in pull request #6505: Add default comparison to HavingSpecMetricComparator for custom Aggregator types URL: https://github.com/apache/incubator-druid/pull/6505#discussion_r227609416 ## File path:

[GitHub] leventov commented on a change in pull request #6504: Remove unused code

2018-10-23 Thread GitBox
leventov commented on a change in pull request #6504: Remove unused code URL: https://github.com/apache/incubator-druid/pull/6504#discussion_r227602182 ## File path: processing/src/test/java/org/apache/druid/query/groupby/NestedQueryPushDownTest.java ## @@ -394,27 +394,26

[GitHub] clintropolis commented on a change in pull request #6432: Allow custom TLS cert checks

2018-10-23 Thread GitBox
clintropolis commented on a change in pull request #6432: Allow custom TLS cert checks URL: https://github.com/apache/incubator-druid/pull/6432#discussion_r227585611 ## File path: server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java ##

[GitHub] clintropolis commented on a change in pull request #6432: Allow custom TLS cert checks

2018-10-23 Thread GitBox
clintropolis commented on a change in pull request #6432: Allow custom TLS cert checks URL: https://github.com/apache/incubator-druid/pull/6432#discussion_r227577082 ## File path: integration-tests/src/main/java/org/apache/druid/testing/ConfigFileConfigProvider.java ##

[GitHub] a2l007 commented on issue #6505: Add default comparison to HavingSpecMetricComparator for custom Aggregator types

2018-10-23 Thread GitBox
a2l007 commented on issue #6505: Add default comparison to HavingSpecMetricComparator for custom Aggregator types URL: https://github.com/apache/incubator-druid/pull/6505#issuecomment-432431447 @jihoonson I've made the changes based on our discussion. Could you please review?

[GitHub] jon-wei commented on issue #6432: Allow custom TLS cert checks

2018-10-23 Thread GitBox
jon-wei commented on issue #6432: Allow custom TLS cert checks URL: https://github.com/apache/incubator-druid/pull/6432#issuecomment-432426580 fixed conflicts This is an automated message from the Apache Git Service. To

[GitHub] patelh commented on issue #6500: Historicals have issues connecting to S3

2018-10-23 Thread GitBox
patelh commented on issue #6500: Historicals have issues connecting to S3 URL: https://github.com/apache/incubator-druid/issues/6500#issuecomment-432414233 Does it retry to download the file? This is an automated message

[GitHub] patelh commented on issue #6500: Historicals have issues connecting to S3

2018-10-23 Thread GitBox
patelh commented on issue #6500: Historicals have issues connecting to S3 URL: https://github.com/apache/incubator-druid/issues/6500#issuecomment-432413652 Sounds like an AWS error, not really a druid one, no? This is an

[GitHub] jihoonson commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types

2018-10-23 Thread GitBox
jihoonson commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types URL: https://github.com/apache/incubator-druid/issues/6486#issuecomment-432412350 Thanks. That makes sense to me.

[GitHub] a2l007 commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types

2018-10-23 Thread GitBox
a2l007 commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types URL: https://github.com/apache/incubator-druid/issues/6486#issuecomment-432406700 @jihoonson I see your point. Regarding the usecase, the custom metric in question is a compressed

[GitHub] egor-ryashin opened a new issue #6507: Indexer should report an ip address along with an instance id during provisioning or termination.

2018-10-23 Thread GitBox
egor-ryashin opened a new issue #6507: Indexer should report an ip address along with an instance id during provisioning or termination. URL: https://github.com/apache/incubator-druid/issues/6507 It could help out during debugging of production issues. This issue could address both

[GitHub] jihoonson commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types

2018-10-23 Thread GitBox
jihoonson commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types URL: https://github.com/apache/incubator-druid/issues/6486#issuecomment-432393912 Hmm, that may involve some accuracy loss which can cause inexact result. For example, if

[GitHub] a2l007 commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types

2018-10-23 Thread GitBox
a2l007 commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types URL: https://github.com/apache/incubator-druid/issues/6486#issuecomment-432373282 I think another way to handle this would be to have an explicit instanceof check for the Number

[GitHub] jihoonson edited a comment on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types

2018-10-23 Thread GitBox
jihoonson edited a comment on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types URL: https://github.com/apache/incubator-druid/issues/6486#issuecomment-432367778 > The basic requirement is that for custom types, the compare method should not to throw

[GitHub] jihoonson commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types

2018-10-23 Thread GitBox
jihoonson commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types URL: https://github.com/apache/incubator-druid/issues/6486#issuecomment-432367778 > The basic requirement is that for custom types, the compare method should not to throw an

[GitHub] samarthjain commented on a change in pull request #6504: Remove unused code

2018-10-23 Thread GitBox
samarthjain commented on a change in pull request #6504: Remove unused code URL: https://github.com/apache/incubator-druid/pull/6504#discussion_r227509994 ## File path: processing/src/test/java/org/apache/druid/query/groupby/NestedQueryPushDownTest.java ## @@ -394,27

[incubator-druid] branch master updated: updated to use the latest sketches-core-0.12.0 (#6381)

2018-10-23 Thread himanshug
This is an automated email from the ASF dual-hosted git repository. himanshug pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new ec9d182 updated to use the latest

[GitHub] himanshug closed pull request #6381: datsketches extension updated to use the latest sketches-core-0.12.0

2018-10-23 Thread GitBox
himanshug closed pull request #6381: datsketches extension updated to use the latest sketches-core-0.12.0 URL: https://github.com/apache/incubator-druid/pull/6381 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] a2l007 commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types

2018-10-23 Thread GitBox
a2l007 commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types URL: https://github.com/apache/incubator-druid/issues/6486#issuecomment-432362305 @jihoonson The basic requirement is that for custom types, the compare method should not to throw

[GitHub] himanshug commented on issue #6458: Supply numeric index

2018-10-23 Thread GitBox
himanshug commented on issue #6458: Supply numeric index URL: https://github.com/apache/incubator-druid/issues/6458#issuecomment-432359218 Is this about creating indexes for numerical columns for faster filtering? I couldn't really understand the design/plan from the description

[GitHub] himanshug commented on issue #6457: Support Join

2018-10-23 Thread GitBox
himanshug commented on issue #6457: Support Join URL: https://github.com/apache/incubator-druid/issues/6457#issuecomment-432357985 so the idea is that "joint tables" (that is tables to be joined together) will be sharded by same "join key" and special arrangements are made so that all

[GitHub] bhrgv-bolla commented on issue #4849: Select Query - Recursive pagingIdentifiers

2018-10-23 Thread GitBox
bhrgv-bolla commented on issue #4849: Select Query - Recursive pagingIdentifiers URL: https://github.com/apache/incubator-druid/issues/4849#issuecomment-432348953 first request => you get paging identifiers in response. Use the first response paging identifiers for second request => you

[GitHub] leventov commented on a change in pull request #6504: Remove unused code

2018-10-23 Thread GitBox
leventov commented on a change in pull request #6504: Remove unused code URL: https://github.com/apache/incubator-druid/pull/6504#discussion_r227496661 ## File path: processing/src/test/java/org/apache/druid/query/groupby/NestedQueryPushDownTest.java ## @@ -394,27 +394,26

[GitHub] leventov commented on a change in pull request #6504: Remove unused code

2018-10-23 Thread GitBox
leventov commented on a change in pull request #6504: Remove unused code URL: https://github.com/apache/incubator-druid/pull/6504#discussion_r227495135 ## File path: processing/src/test/java/org/apache/druid/query/groupby/NestedQueryPushDownTest.java ## @@ -686,35 +679,33

[GitHub] bhrgv-bolla opened a new issue #6506: Support for pagination semantics get 20th-30th of a 1000 result set.

2018-10-23 Thread GitBox
bhrgv-bolla opened a new issue #6506: Support for pagination semantics get 20th-30th of a 1000 result set. URL: https://github.com/apache/incubator-druid/issues/6506 Can druid support pagination. Is it in the road map? Paging Identifiers provide very limited pagination

[GitHub] jihoonson commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types

2018-10-23 Thread GitBox
jihoonson commented on issue #6486: HavingSpecMetricComparator ignores comparison for custom Aggregator types URL: https://github.com/apache/incubator-druid/issues/6486#issuecomment-432339280 Hi @a2l007, would you elaborate more on the default behavior? Is this issue to add an assumption

[GitHub] jihoonson commented on a change in pull request #4033: Query Response format to be based on http 'accept' header & Query Payload content type to be based on 'content-type' header

2018-10-23 Thread GitBox
jihoonson commented on a change in pull request #4033: Query Response format to be based on http 'accept' header & Query Payload content type to be based on 'content-type' header URL: https://github.com/apache/incubator-druid/pull/4033#discussion_r227486635 ## File path:

[GitHub] samarthjain commented on issue #6504: Remove unused code

2018-10-23 Thread GitBox
samarthjain commented on issue #6504: Remove unused code URL: https://github.com/apache/incubator-druid/pull/6504#issuecomment-432325181 @leventov - I have made the fixes in the latest commit. This is an automated message

[GitHub] churrodog commented on a change in pull request #4033: Query Response format to be based on http 'accept' header & Query Payload content type to be based on 'content-type' header

2018-10-23 Thread GitBox
churrodog commented on a change in pull request #4033: Query Response format to be based on http 'accept' header & Query Payload content type to be based on 'content-type' header URL: https://github.com/apache/incubator-druid/pull/4033#discussion_r227472007 ## File path:

[GitHub] churrodog commented on a change in pull request #4033: Query Response format to be based on http 'accept' header & Query Payload content type to be based on 'content-type' header

2018-10-23 Thread GitBox
churrodog commented on a change in pull request #4033: Query Response format to be based on http 'accept' header & Query Payload content type to be based on 'content-type' header URL: https://github.com/apache/incubator-druid/pull/4033#discussion_r227472007 ## File path:

[GitHub] gaodayue commented on issue #6402: Thread-safe QueryMetrics

2018-10-23 Thread GitBox
gaodayue commented on issue #6402: Thread-safe QueryMetrics URL: https://github.com/apache/incubator-druid/pull/6402#issuecomment-432172691 @leventov sorry for the late reply. I have addressed previous round of review comments, could you check it again?

[GitHub] gaodayue commented on a change in pull request #6402: Thread-safe QueryMetrics

2018-10-23 Thread GitBox
gaodayue commented on a change in pull request #6402: Thread-safe QueryMetrics URL: https://github.com/apache/incubator-druid/pull/6402#discussion_r227297357 ## File path: processing/src/main/java/org/apache/druid/query/QueryMetrics.java ## @@ -92,7 +94,7 @@ * 100%

[GitHub] samarthjain opened a new pull request #6504: Remove unused code

2018-10-23 Thread GitBox
samarthjain opened a new pull request #6504: Remove unused code URL: https://github.com/apache/incubator-druid/pull/6504 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] gaodayue commented on a change in pull request #6402: Thread-safe QueryMetrics

2018-10-23 Thread GitBox
gaodayue commented on a change in pull request #6402: Thread-safe QueryMetrics URL: https://github.com/apache/incubator-druid/pull/6402#discussion_r227251555 ## File path: processing/src/main/java/org/apache/druid/query/QueryPlus.java ## @@ -100,23 +100,11 @@ private

[GitHub] gaodayue commented on a change in pull request #6402: Thread-safe QueryMetrics

2018-10-23 Thread GitBox
gaodayue commented on a change in pull request #6402: Thread-safe QueryMetrics URL: https://github.com/apache/incubator-druid/pull/6402#discussion_r227246539 ## File path: processing/src/main/java/org/apache/druid/query/QueryPlus.java ## @@ -68,7 +68,7 @@ private

[GitHub] gaodayue commented on a change in pull request #6402: Thread-safe QueryMetrics

2018-10-23 Thread GitBox
gaodayue commented on a change in pull request #6402: Thread-safe QueryMetrics URL: https://github.com/apache/incubator-druid/pull/6402#discussion_r227246539 ## File path: processing/src/main/java/org/apache/druid/query/QueryPlus.java ## @@ -68,7 +68,7 @@ private