[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

2021-02-18 Thread GitBox
clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r578985027 ## File path: processing/src/main/java/org/apache/druid/query/filter/DruidPredicateFactory.java ## @@ -27,6 +27,13 @@ { Predicate

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

2021-02-18 Thread GitBox
clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r578982727 ## File path: core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java ## @@ -74,7 +74,7 @@ public ExprType

[GitHub] [druid] zhangxin12138 opened a new issue #10903: Idle timeout expired:300000/300000 ms

2021-02-18 Thread GitBox
zhangxin12138 opened a new issue #10903: URL: https://github.com/apache/druid/issues/10903 version: druid-0.15.1 error message: 2021-02-19T05:41:57,130 WARN [qtp1898870910-192] org.eclipse.jetty.server.HttpChannel - /druid/v2/ java.lang.RuntimeException: java.io.IOException:

[GitHub] [druid] zhangxin12138 commented on issue #8312: Druid Jetty Exception

2021-02-18 Thread GitBox
zhangxin12138 commented on issue #8312: URL: https://github.com/apache/druid/issues/8312#issuecomment-781884175 > The connection failed because the common configuration file changed the host incorrectly. Sorry; > > Use 0.15.1 请教下the common configuration file changed the host

[GitHub] [druid] zhangxin12138 removed a comment on issue #8312: Druid Jetty Exception

2021-02-18 Thread GitBox
zhangxin12138 removed a comment on issue #8312: URL: https://github.com/apache/druid/issues/8312#issuecomment-781883642 请教下the common configuration file changed the host incorrectly是什么问题,碰到相同问题 This is an automated message

[GitHub] [druid] zhangxin12138 commented on issue #8312: Druid Jetty Exception

2021-02-18 Thread GitBox
zhangxin12138 commented on issue #8312: URL: https://github.com/apache/druid/issues/8312#issuecomment-781883642 请教下the common configuration file changed the host incorrectly是什么问题,碰到相同问题 This is an automated message from the

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

2021-02-18 Thread GitBox
clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r578967958 ## File path: core/src/main/java/org/apache/druid/math/expr/ExprTypeConversion.java ## @@ -20,24 +20,29 @@ package org.apache.druid.math.expr;

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

2021-02-18 Thread GitBox
clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r578964740 ## File path: processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java ## @@ -305,17 +305,29 @@ private static

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

2021-02-18 Thread GitBox
clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r578964617 ## File path: processing/src/main/java/org/apache/druid/segment/filter/ExpressionFilter.java ## @@ -55,6 +69,105 @@ public ExpressionFilter(final

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

2021-02-18 Thread GitBox
clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r578961978 ## File path: processing/src/main/java/org/apache/druid/segment/filter/ExpressionFilter.java ## @@ -55,6 +69,105 @@ public ExpressionFilter(final

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

2021-02-18 Thread GitBox
clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r578961003 ## File path: processing/src/main/java/org/apache/druid/segment/filter/ExpressionFilter.java ## @@ -55,6 +69,105 @@ public ExpressionFilter(final

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

2021-02-18 Thread GitBox
clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r578960768 ## File path: processing/src/main/java/org/apache/druid/segment/vector/VectorColumnSelectorFactory.java ## @@ -57,6 +57,15 @@ default int

[druid] branch master updated: Fix maxBytesInMemory for heap overhead of all sinks and hydrants check (#10891)

2021-02-18 Thread maytasm
This is an automated email from the ASF dual-hosted git repository. maytasm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new f5bfccc Fix maxBytesInMemory for heap overhead

[GitHub] [druid] maytasm merged pull request #10891: Fix maxBytesInMemory for heap overhead of all sinks and hydrants check

2021-02-18 Thread GitBox
maytasm merged pull request #10891: URL: https://github.com/apache/druid/pull/10891 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] maytasm commented on a change in pull request #10891: Fix maxBytesInMemory for heap overhead of all sinks and hydrants check

2021-02-18 Thread GitBox
maytasm commented on a change in pull request #10891: URL: https://github.com/apache/druid/pull/10891#discussion_r578944750 ## File path: server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorImpl.java ## @@ -332,6 +332,47 @@ public

[GitHub] [druid] hackallan commented on issue #9221: Previous sequenceNumber [344019] is no longer available for partition [0]

2021-02-18 Thread GitBox
hackallan commented on issue #9221: URL: https://github.com/apache/druid/issues/9221#issuecomment-781840970 > “You can clear the previous sequenceNumber and start reading from a valid message by using the supervisor's reset API“ >

[GitHub] [druid] stale[bot] commented on issue #9221: Previous sequenceNumber [344019] is no longer available for partition [0]

2021-02-18 Thread GitBox
stale[bot] commented on issue #9221: URL: https://github.com/apache/druid/issues/9221#issuecomment-781840989 This issue is no longer marked as stale. This is an automated message from the Apache Git Service. To respond

[GitHub] [druid] kaijianding commented on pull request #10899: fix ClassCastException when finalize hyperUnique metric in sql

2021-02-18 Thread GitBox
kaijianding commented on pull request #10899: URL: https://github.com/apache/druid/pull/10899#issuecomment-781827520 The CI failure `java.lang.AssertionError: expected [200 OK] but found [401 Unauthorized]` in `30393.61 (Compile=openjdk8, Run=openjdk8, ZK=3.4) leadership and high

[druid] branch master updated (8434173 -> cbbef80)

2021-02-18 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 8434173 Add property for binding view manager type (#10895) add cbbef80 add SQL operators for bitwise

[GitHub] [druid] clintropolis merged pull request #10823: add SQL operators for bitwise expressions

2021-02-18 Thread GitBox
clintropolis merged pull request #10823: URL: https://github.com/apache/druid/pull/10823 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [druid] ruibinx opened a new issue #10902: Index Kafka job shutdown without any exceptions

2021-02-18 Thread GitBox
ruibinx opened a new issue #10902: URL: https://github.com/apache/druid/issues/10902 ### Affected Version 0.19.0 ### Description Occasionally index kafka job shutdown without any exceptions. The status reports is 'FAILED', and there is no exceptions in logs.

[GitHub] [druid] liubo-it commented on issue #10607: When I ingest, It'll reset if it's over 10 million rows.

2021-02-18 Thread GitBox
liubo-it commented on issue #10607: URL: https://github.com/apache/druid/issues/10607#issuecomment-781777964 @silverflow Hi, apache druid 0.20.0 , I have the same problem,But the final state of my task is success。 This is

[GitHub] [druid] clintropolis commented on a change in pull request #10901: Ldap integration tests

2021-02-18 Thread GitBox
clintropolis commented on a change in pull request #10901: URL: https://github.com/apache/druid/pull/10901#discussion_r57140 ## File path: integration-tests/docker/docker-compose.base.yml ## @@ -356,3 +356,20 @@ services: env_file: -

[GitHub] [druid] zachjsh commented on a change in pull request #10901: Ldap integration tests

2021-02-18 Thread GitBox
zachjsh commented on a change in pull request #10901: URL: https://github.com/apache/druid/pull/10901#discussion_r578887035 ## File path: integration-tests/docker/test-data/ldap-security-sample-data.sql ## @@ -0,0 +1,17 @@ +-- Licensed to the Apache Software Foundation (ASF)

[GitHub] [druid] zachjsh commented on a change in pull request #10901: Ldap integration tests

2021-02-18 Thread GitBox
zachjsh commented on a change in pull request #10901: URL: https://github.com/apache/druid/pull/10901#discussion_r578886679 ## File path: integration-tests/docker/docker-compose.base.yml ## @@ -356,3 +356,20 @@ services: env_file: - ./environment-configs/common

[GitHub] [druid] zachjsh opened a new pull request #10901: Ldap integration tests

2021-02-18 Thread GitBox
zachjsh opened a new pull request #10901: URL: https://github.com/apache/druid/pull/10901 ### Description Added integration tests for testing the [druid-basic-security](https://druid.apache.org/docs/latest/development/extensions-core/druid-basic-security.html) extension in ldap

[GitHub] [druid] clintropolis commented on a change in pull request #10891: Fix maxBytesInMemory for heap overhead of all sinks and hydrants check

2021-02-18 Thread GitBox
clintropolis commented on a change in pull request #10891: URL: https://github.com/apache/druid/pull/10891#discussion_r578850100 ## File path: server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorImpl.java ## @@ -332,6 +332,47 @@ public

[GitHub] [druid] maytasm opened a new pull request #10900: Add query granularity to compaction task

2021-02-18 Thread GitBox
maytasm opened a new pull request #10900: URL: https://github.com/apache/druid/pull/10900 Add query granularity to compaction task ### Description Add query granularity to compaction task. Note that query granularity is still not supported in auto compaction. This PR also

[GitHub] [druid] jon-wei merged pull request #10895: Add property for binding view manager type

2021-02-18 Thread GitBox
jon-wei merged pull request #10895: URL: https://github.com/apache/druid/pull/10895 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[druid] branch master updated (eabad0f -> 8434173)

2021-02-18 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from eabad0f Keep query granularity of compacted segments after compaction (#10856) add 8434173 Add property for

[GitHub] [druid] zhangyue19921010 edited a comment on pull request #10524: Dynamic auto scale Kafka-Stream ingest tasks

2021-02-18 Thread GitBox
zhangyue19921010 edited a comment on pull request #10524: URL: https://github.com/apache/druid/pull/10524#issuecomment-781690717 > I will try to finish my review by end of this week. Hi @pjain1 Thanks a lot. This is

[GitHub] [druid] zhangyue19921010 commented on pull request #10524: Dynamic auto scale Kafka-Stream ingest tasks

2021-02-18 Thread GitBox
zhangyue19921010 commented on pull request #10524: URL: https://github.com/apache/druid/pull/10524#issuecomment-781690717 > I will try to finish my review by end of this week. Thanks a lot. This is an automated

[GitHub] [druid] zachjsh commented on a change in pull request #10896: basic security extension ignore permissions that use unknown ResourceType or Action

2021-02-18 Thread GitBox
zachjsh commented on a change in pull request #10896: URL: https://github.com/apache/druid/pull/10896#discussion_r578749327 ## File path: extensions-core/druid-basic-security/src/test/java/org/apache/druid/security/BasicAuthUtilsTest.java ## @@ -36,4 +51,112 @@ public void

[GitHub] [druid] zachjsh commented on a change in pull request #10896: basic security extension ignore permissions that use unknown ResourceType or Action

2021-02-18 Thread GitBox
zachjsh commented on a change in pull request #10896: URL: https://github.com/apache/druid/pull/10896#discussion_r578749327 ## File path: extensions-core/druid-basic-security/src/test/java/org/apache/druid/security/BasicAuthUtilsTest.java ## @@ -36,4 +51,112 @@ public void

[GitHub] [druid] zachjsh commented on a change in pull request #10896: basic security extension ignore permissions that use unknown ResourceType or Action

2021-02-18 Thread GitBox
zachjsh commented on a change in pull request #10896: URL: https://github.com/apache/druid/pull/10896#discussion_r578744980 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authorization/entity/BasicAuthorizerRole.java ## @@

[GitHub] [druid] abhishekagarwal87 commented on pull request #10892: [Draft] Avoid expensive findEntry call in segment metadata query

2021-02-18 Thread GitBox
abhishekagarwal87 commented on pull request #10892: URL: https://github.com/apache/druid/pull/10892#issuecomment-781577467 It would seem this change alone is not enough. Adding a chunk to timeline is also O(N*N) since it calls `PartitionHolder.isComplete` which is O(N) op.

[GitHub] [druid] capistrant commented on pull request #10894: Add instructions for updating licenses

2021-02-18 Thread GitBox
capistrant commented on pull request #10894: URL: https://github.com/apache/druid/pull/10894#issuecomment-781531865 This is awesome content and very informative! I don't know if I'm qualified to review since it is all new information to me. All of the content made sense to me, an

[GitHub] [druid] pjain1 commented on pull request #10524: Dynamic auto scale Kafka-Stream ingest tasks

2021-02-18 Thread GitBox
pjain1 commented on pull request #10524: URL: https://github.com/apache/druid/pull/10524#issuecomment-781394408 I will try to finish my review by end of this week. This is an automated message from the Apache Git Service. To

[GitHub] [druid] zhangyue19921010 commented on pull request #10524: Dynamic auto scale Kafka-Stream ingest tasks

2021-02-18 Thread GitBox
zhangyue19921010 commented on pull request #10524: URL: https://github.com/apache/druid/pull/10524#issuecomment-781384835 Hi @bananaaggle I will try my best to get it done. For now I still wait for a further review after code changed.

[GitHub] [druid] kaijianding opened a new pull request #10899: fix ClassCastException when finalize hyperUnique metric in sql

2021-02-18 Thread GitBox
kaijianding opened a new pull request #10899: URL: https://github.com/apache/druid/pull/10899 ### Description for a sql like this ```sql select count(1) as totalData from ( select count(distinct unique_user_id) as uv from a_table group by city_name

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10884: Reload segment usage when starting the process

2021-02-18 Thread GitBox
abhishekagarwal87 commented on a change in pull request #10884: URL: https://github.com/apache/druid/pull/10884#discussion_r578269049 ## File path: server/src/main/java/org/apache/druid/segment/loading/StorageLocation.java ## @@ -117,6 +117,33 @@ public synchronized File

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10884: Reload segment usage when starting the process

2021-02-18 Thread GitBox
abhishekagarwal87 commented on a change in pull request #10884: URL: https://github.com/apache/druid/pull/10884#discussion_r578269049 ## File path: server/src/main/java/org/apache/druid/segment/loading/StorageLocation.java ## @@ -117,6 +117,33 @@ public synchronized File

[druid] branch master updated: Keep query granularity of compacted segments after compaction (#10856)

2021-02-18 Thread maytasm
This is an automated email from the ASF dual-hosted git repository. maytasm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new eabad0f Keep query granularity of compacted

[GitHub] [druid] maytasm merged pull request #10856: Keep query granularity of compacted segments after compaction

2021-02-18 Thread GitBox
maytasm merged pull request #10856: URL: https://github.com/apache/druid/pull/10856 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to