[GitHub] [druid] gianm edited a comment on issue #12262: Multi-stage distributed queries

2022-02-28 Thread GitBox
gianm edited a comment on issue #12262: URL: https://github.com/apache/druid/issues/12262#issuecomment-1055125017 > Gian, Are there any algorithms that would be made possible by this architecture? (By algorithms, I mean distributed implementations of relational operators, e.g. shuffle-sort

[GitHub] [druid] gianm commented on issue #12262: Multi-stage distributed queries

2022-02-28 Thread GitBox
gianm commented on issue #12262: URL: https://github.com/apache/druid/issues/12262#issuecomment-1055125017 > Gian, Are there any algorithms that would be made possible by this architecture? (By algorithms, I mean distributed implementations of relational operators, e.g. shuffle-sort, shuff

[GitHub] [druid] kfaraz commented on a change in pull request #12280: RowStats for multiphase parallel indexing task

2022-02-28 Thread GitBox
kfaraz commented on a change in pull request #12280: URL: https://github.com/apache/druid/pull/12280#discussion_r816511853 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java ## @@ -1535,27 +1571,47

[GitHub] [druid] jihoonson commented on pull request #12026: Fix vulnerabilities in some HTTP endpoints

2022-02-28 Thread GitBox
jihoonson commented on pull request #12026: URL: https://github.com/apache/druid/pull/12026#issuecomment-1055088634 @FrankChen021 my apologies, I forgot to take another look. Please feel free to ping me if I forget again and don't finish my review in time. I took another look. Thank

[GitHub] [druid] gianm commented on issue #12262: Multi-stage distributed queries

2022-02-28 Thread GitBox
gianm commented on issue #12262: URL: https://github.com/apache/druid/issues/12262#issuecomment-1055084660 @samarthjain Thanks for your comments. I totally agree about the importance of fault tolerance and good resource management. It'll be important as queries can get more complex and lon

[GitHub] [druid] didip edited a comment on issue #11303: Issues connecting to S3 on EKS

2022-02-28 Thread GitBox
didip edited a comment on issue #11303: URL: https://github.com/apache/druid/issues/11303#issuecomment-1055037028 It seems like `AWSCredentialsUtils.defaultAWSCredentialsProviderChain` is not even used in `S3InputSource.java` and `S3StorageDruidModule.java` Also, it looks like talkin

[GitHub] [druid] didip edited a comment on issue #11303: Issues connecting to S3 on EKS

2022-02-28 Thread GitBox
didip edited a comment on issue #11303: URL: https://github.com/apache/druid/issues/11303#issuecomment-1055037028 It seems like `AWSCredentialsUtils.defaultAWSCredentialsProviderChain` is not even used in `S3InputSource.java` and `S3StorageDruidModule.java` Also, it looks like talkin

[GitHub] [druid] didip edited a comment on issue #11303: Issues connecting to S3 on EKS

2022-02-28 Thread GitBox
didip edited a comment on issue #11303: URL: https://github.com/apache/druid/issues/11303#issuecomment-1055037028 It seems like `AWSCredentialsUtils.defaultAWSCredentialsProviderChain` is not even used in `S3InputSource.java` and `S3StorageDruidModule.java` Also, it looks like talkin

[GitHub] [druid] didip commented on issue #11303: Issues connecting to S3 on EKS

2022-02-28 Thread GitBox
didip commented on issue #11303: URL: https://github.com/apache/druid/issues/11303#issuecomment-1055037028 It seems like `AWSCredentialsUtils.defaultAWSCredentialsProviderChain` is not even used in `S3InputSource.java` and `S3StorageDruidModule.java` -- This is an automated message from

[GitHub] [druid] clintropolis commented on a change in pull request #12291: add topn heap optimization when string is dictionary encoded, but not uniquely

2022-02-28 Thread GitBox
clintropolis commented on a change in pull request #12291: URL: https://github.com/apache/druid/pull/12291#discussion_r816448406 ## File path: processing/src/main/java/org/apache/druid/query/topn/types/StringTopNColumnAggregatesProcessor.java ## @@ -172,6 +180,54 @@ private lo

[GitHub] [druid] imply-cheddar commented on a change in pull request #12291: add topn heap optimization when string is dictionary encoded, but not uniquely

2022-02-28 Thread GitBox
imply-cheddar commented on a change in pull request #12291: URL: https://github.com/apache/druid/pull/12291#discussion_r816443116 ## File path: processing/src/main/java/org/apache/druid/query/topn/types/StringTopNColumnAggregatesProcessor.java ## @@ -172,6 +180,54 @@ private l

[GitHub] [druid] clintropolis commented on pull request #12291: add topn heap optimization when string is dictionary encoded, but not uniquely

2022-02-28 Thread GitBox
clintropolis commented on pull request #12291: URL: https://github.com/apache/druid/pull/12291#issuecomment-1054990097 >The existing topn tests should provide adequate coverage for this change, but will confirm this with the coverage bot once it runs in travis. [It looks like I was

[GitHub] [druid] clintropolis opened a new pull request #12291: add topn heap optimization when string is dictionary encoded, but not uniquely

2022-02-28 Thread GitBox
clintropolis opened a new pull request #12291: URL: https://github.com/apache/druid/pull/12291 ### Description This PR adds an additional optimization to `StringTopNColumnAggregatesProcessor`, the string processor used for heap based topN, for the case where a column is dictionary encod

[druid] branch dependabot/maven/jersey.version-1.19.4 created (now 43aef49)

2022-02-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/jersey.version-1.19.4 in repository https://gitbox.apache.org/repos/asf/druid.git. at 43aef49 Bump jersey.version from 1.19.3 to 1.19.4 No new revisions were added by

[GitHub] [druid] dependabot[bot] opened a new pull request #12290: Bump jersey.version from 1.19.3 to 1.19.4

2022-02-28 Thread GitBox
dependabot[bot] opened a new pull request #12290: URL: https://github.com/apache/druid/pull/12290 Bumps `jersey.version` from 1.19.3 to 1.19.4. Updates `jersey-client` from 1.19.3 to 1.19.4 Updates `jersey-core` from 1.19.3 to 1.19.4 Updates `jersey-grizzly2` from 1.19.3 to

[GitHub] [druid] jasonk000 commented on pull request #12097: perf: eliminate double string concat in remote-task-runner shutdown logging

2022-02-28 Thread GitBox
jasonk000 commented on pull request #12097: URL: https://github.com/apache/druid/pull/12097#issuecomment-1054774274 Hi @FrankChen021 I moved the detailed log output to debug instead of info; I think this is a better balance. Let me know your thoughts. In 5685eafeb4. -- This is an

[GitHub] [druid] jasonk000 commented on a change in pull request #12096: perf: improve RemoteTaskRunner task assignment loop performance

2022-02-28 Thread GitBox
jasonk000 commented on a change in pull request #12096: URL: https://github.com/apache/druid/pull/12096#discussion_r816281880 ## File path: indexing-service/src/test/java/org/apache/druid/indexing/overlord/ZkWorkerTest.java ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache S

[GitHub] [druid] jasonk000 commented on a change in pull request #12096: perf: improve RemoteTaskRunner task assignment loop performance

2022-02-28 Thread GitBox
jasonk000 commented on a change in pull request #12096: URL: https://github.com/apache/druid/pull/12096#discussion_r816281705 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/ZkWorker.java ## @@ -102,19 +136,29 @@ public Worker getWorker() @

[GitHub] [druid] samarthjain commented on pull request #12096: perf: improve RemoteTaskRunner task assignment loop performance

2022-02-28 Thread GitBox
samarthjain commented on pull request #12096: URL: https://github.com/apache/druid/pull/12096#issuecomment-1054602169 > HI @samarthjain @xvrl , I believe these comments have all been addressed in [a633c74](https://github.com/apache/druid/pull/12096/commits/a633c7447e69f407b58140b61f1d04ef6

[GitHub] [druid] julianhyde commented on issue #12262: Multi-stage distributed queries

2022-02-28 Thread GitBox
julianhyde commented on issue #12262: URL: https://github.com/apache/druid/issues/12262#issuecomment-1054594201 Gian, Are there any algorithms that would be made possible by this architecture? (By algorithms, I mean distributed implementations of relational operators, e.g. shuffle-sort, sh

[GitHub] [druid] samarthjain commented on a change in pull request #12096: perf: improve RemoteTaskRunner task assignment loop performance

2022-02-28 Thread GitBox
samarthjain commented on a change in pull request #12096: URL: https://github.com/apache/druid/pull/12096#discussion_r814536835 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/ZkWorker.java ## @@ -102,19 +136,29 @@ public Worker getWorker()

[GitHub] [druid] jasonk000 commented on pull request #12096: perf: improve RemoteTaskRunner task assignment loop performance

2022-02-28 Thread GitBox
jasonk000 commented on pull request #12096: URL: https://github.com/apache/druid/pull/12096#issuecomment-1054591159 HI @samarthjain @xvrl , I believe these comments have all been addressed in [a633c74](https://github.com/apache/druid/pull/12096/commits/a633c7447e69f407b58140b61f1d04ef6d078d

[GitHub] [druid] samarthjain commented on issue #12262: Multi-stage distributed queries

2022-02-28 Thread GitBox
samarthjain commented on issue #12262: URL: https://github.com/apache/druid/issues/12262#issuecomment-1054567811 Thank you for the proposal, Gian! Building a DAG based query execution model seems like the next logical thing to do in Druid. I am excited to see progress on that front.

[GitHub] [druid] jihoonson commented on a change in pull request #12279: Store null columns in the segments

2022-02-28 Thread GitBox
jihoonson commented on a change in pull request #12279: URL: https://github.com/apache/druid/pull/12279#discussion_r816139077 ## File path: processing/pom.xml ## @@ -99,6 +99,10 @@ commons-net commons-net + +org.apache.com

[druid] branch master updated: Make ParseExceptions more informative (#12259)

2022-02-28 Thread abhishek
This is an automated email from the ASF dual-hosted git repository. abhishek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 3f709db Make ParseExceptions more informative

[GitHub] [druid] abhishekagarwal87 commented on pull request #12259: Make ParseExceptions more informative

2022-02-28 Thread GitBox
abhishekagarwal87 commented on pull request #12259: URL: https://github.com/apache/druid/pull/12259#issuecomment-1054466121 Ignored code coverage failures since only a simple getter was missing code coverage. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [druid] abhishekagarwal87 merged pull request #12259: Make ParseExceptions more informative

2022-02-28 Thread GitBox
abhishekagarwal87 merged pull request #12259: URL: https://github.com/apache/druid/pull/12259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[GitHub] [druid] gitmstoute opened a new issue #12288: Datasource Autocompaction stuck 'Awaiting First Run'

2022-02-28 Thread GitBox
gitmstoute opened a new issue #12288: URL: https://github.com/apache/druid/issues/12288 ### Affected Version 0.22.1 ### Description I'm opening a ticket after having no luck with my druidforum post: https://www.druidforum.org/t/datasource-autocompaction-awaiting-first-run/7087.

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #12259: Make ParseExceptions more informative

2022-02-28 Thread GitBox
abhishekagarwal87 commented on a change in pull request #12259: URL: https://github.com/apache/druid/pull/12259#discussion_r815679114 ## File path: core/src/main/java/org/apache/druid/data/input/IntermediateRowParsingReader.java ## @@ -155,6 +259,39 @@ public void close() thro