[druid] branch master updated: Web console: Misc fixes and improvements (#12361)

This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new a139cd22aa Web console: Misc fixes and

[GitHub] [druid] vogievetsky merged pull request #12361: Web console: Misc fixes and improvements

vogievetsky merged PR #12361: URL: https://github.com/apache/druid/pull/12361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] clintropolis commented on a diff in pull request #12361: Web console: Misc fixes and improvements

clintropolis commented on code in PR #12361: URL: https://github.com/apache/druid/pull/12361#discussion_r849078359 ## web-console/src/utils/general.tsx: ## @@ -476,3 +476,39 @@ export function twoLines(line1: string, line2: string) { ); } + +export function

[GitHub] [druid] lgtm-com[bot] commented on pull request #11634: Add IPAddress java library as dependency and migrate IPv4 functions to use the new library.

lgtm-com[bot] commented on PR #11634: URL: https://github.com/apache/druid/pull/11634#issuecomment-1097486911 This pull request **introduces 1 alert** and **fixes 2** when merging 34d47694bc5e2ee89d97fa9bb36da07f42f76b31 into 2c79d28bb772567893433602c9a39acb0d188e10 - [view on

[GitHub] [druid] abhishekrb19 commented on pull request #11634: Add IPAddress java library as dependency and migrate IPv4 functions to use the new library.

abhishekrb19 commented on PR #11634: URL: https://github.com/apache/druid/pull/11634#issuecomment-1097451571 @clintropolis, sorry the delayed response. I've added a benchmark and the results are in the PR summary now. Please let me know when you've a chance to take a look. Thanks! --

[GitHub] [druid] abhishekrb19 commented on a diff in pull request #11634: Add IPAddress java library as dependency and migrate IPv4 functions to use the new library.

abhishekrb19 commented on code in PR #11634: URL: https://github.com/apache/druid/pull/11634#discussion_r848986676 ## processing/src/main/java/org/apache/druid/query/expression/IPv4AddressMatchExprMacro.java: ## @@ -104,19 +105,21 @@ public ExprEval eval(final ObjectBinding

[GitHub] [druid] abhishekrb19 commented on a diff in pull request #11634: Add IPAddress java library as dependency and migrate IPv4 functions to use the new library.

abhishekrb19 commented on code in PR #11634: URL: https://github.com/apache/druid/pull/11634#discussion_r848986251 ## processing/src/main/java/org/apache/druid/query/expression/IPv4AddressMatchExprMacro.java: ## @@ -70,17 +71,17 @@ public Expr apply(final List args)

[GitHub] [druid] hqx871 commented on a diff in pull request #12417: Use binary search to improve DimensionRangeShardSpec lookup

hqx871 commented on code in PR #12417: URL: https://github.com/apache/druid/pull/12417#discussion_r848978621 ## core/src/main/java/org/apache/druid/timeline/partition/BaseDimensionRangeShardSpec.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [druid] loquisgon commented on a diff in pull request #12392: Make tombstones ingestible by having them return an empty result set.

loquisgon commented on code in PR #12392: URL: https://github.com/apache/druid/pull/12392#discussion_r848955927 ## server/src/main/java/org/apache/druid/server/coordinator/duty/CompactSegments.java: ## @@ -426,6 +426,17 @@ private CoordinatorStats doRun( if

[GitHub] [druid] loquisgon commented on a diff in pull request #12392: Make tombstones ingestible by having them return an empty result set.

loquisgon commented on code in PR #12392: URL: https://github.com/apache/druid/pull/12392#discussion_r848951942 ## integration-tests/src/test/java/org/apache/druid/tests/coordinator/duty/ITAutoCompactionTest.java: ## @@ -555,30 +577,169 @@ public void

[GitHub] [druid] loquisgon commented on a diff in pull request #12392: Make tombstones ingestible by having them return an empty result set.

loquisgon commented on code in PR #12392: URL: https://github.com/apache/druid/pull/12392#discussion_r848951065 ## indexing-service/src/test/java/org/apache/druid/indexing/common/task/CompactionTaskRunTest.java: ## @@ -1099,6 +1100,164 @@ public void

[GitHub] [druid] loquisgon commented on a diff in pull request #12392: Make tombstones ingestible by having them return an empty result set.

loquisgon commented on code in PR #12392: URL: https://github.com/apache/druid/pull/12392#discussion_r848923172 ## indexing-service/src/main/java/org/apache/druid/indexing/input/DruidSegmentInputFormat.java: ## @@ -55,14 +55,27 @@ public InputEntityReader createReader(

[GitHub] [druid] lgtm-com[bot] commented on pull request #11634: Add IPAddress java library as dependency and migrate IPv4 functions to use the new library.

lgtm-com[bot] commented on PR #11634: URL: https://github.com/apache/druid/pull/11634#issuecomment-1097291542 This pull request **introduces 1 alert** and **fixes 2** when merging f2b3069d935ac0cedaf71a00ab36f0c2ca15b555 into 2c79d28bb772567893433602c9a39acb0d188e10 - [view on

[druid] branch dependabot/maven/org.apache.hadoop-hadoop-common-3.2.3 created (now 8b4d9f1439)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.hadoop-hadoop-common-3.2.3 in repository https://gitbox.apache.org/repos/asf/druid.git at 8b4d9f1439 Bump hadoop-common from 2.8.5 to 3.2.3 No new

[GitHub] [druid] dependabot[bot] opened a new pull request, #12433: Bump hadoop-common from 2.8.5 to 3.2.3

dependabot[bot] opened a new pull request, #12433: URL: https://github.com/apache/druid/pull/12433 Bumps hadoop-common from 2.8.5 to 3.2.3. [![Dependabot compatibility

[GitHub] [druid] hqx871 commented on a diff in pull request #12417: Use binary search to improve DimensionRangeShardSpec lookup

hqx871 commented on code in PR #12417: URL: https://github.com/apache/druid/pull/12417#discussion_r848889538 ## core/src/main/java/org/apache/druid/timeline/partition/BaseDimensionRangeShardSpec.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [druid] hqx871 commented on a diff in pull request #12417: Use binary search to improve DimensionRangeShardSpec lookup

hqx871 commented on code in PR #12417: URL: https://github.com/apache/druid/pull/12417#discussion_r848889538 ## core/src/main/java/org/apache/druid/timeline/partition/BaseDimensionRangeShardSpec.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [druid] jameskelleher opened a new pull request, #12432: Fix NOTES.txt tooltips when adding a LoadBalancer service

jameskelleher opened a new pull request, #12432: URL: https://github.com/apache/druid/pull/12432 ### Description Fixes some errors in NOTES.txt when installing or upgrading with a `LoadBalancer` service. 1. Add the namespace arg in two commands where it was missing 2. Append

[GitHub] [druid] dat-vikash commented on pull request #11224: PulsarIndexingService and PulsarSchemaRegistryBytesDecoder

dat-vikash commented on PR #11224: URL: https://github.com/apache/druid/pull/11224#issuecomment-1097141266 Hi, if we can get a description of whats left on this, I'm sure someone can pick it up. Druid badly needs a pulsar integration. -- This is an automated message from the Apache Git

[GitHub] [druid] clintropolis commented on pull request #12418: Handling planning with alias for time for group by and order by

clintropolis commented on PR #12418: URL: https://github.com/apache/druid/pull/12418#issuecomment-1097140531 >hmm. I believe the part of the PR that fixes the bug, is using the row signature of the subquery. If you remove that and just explain the subQuery, the overall query will still

[GitHub] [druid] loquisgon commented on a diff in pull request #12392: Make tombstones ingestible by having them return an empty result set.

loquisgon commented on code in PR #12392: URL: https://github.com/apache/druid/pull/12392#discussion_r848773509 ## indexing-service/src/main/java/org/apache/druid/indexing/input/DruidSegmentInputFormat.java: ## @@ -55,14 +55,27 @@ public InputEntityReader createReader(

[GitHub] [druid] loquisgon commented on a diff in pull request #12392: Make tombstones ingestible by having them return an empty result set.

loquisgon commented on code in PR #12392: URL: https://github.com/apache/druid/pull/12392#discussion_r848770664 ## indexing-service/src/main/java/org/apache/druid/indexing/input/DruidSegmentReaderBase.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [druid] loquisgon commented on a diff in pull request #12392: Make tombstones ingestible by having them return an empty result set.

loquisgon commented on code in PR #12392: URL: https://github.com/apache/druid/pull/12392#discussion_r848770664 ## indexing-service/src/main/java/org/apache/druid/indexing/input/DruidSegmentReaderBase.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [druid] loquisgon commented on a diff in pull request #12392: Make tombstones ingestible by having them return an empty result set.

loquisgon commented on code in PR #12392: URL: https://github.com/apache/druid/pull/12392#discussion_r848770664 ## indexing-service/src/main/java/org/apache/druid/indexing/input/DruidSegmentReaderBase.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [druid] stale[bot] commented on issue #9539: Data versioning

stale[bot] commented on issue #9539: URL: https://github.com/apache/druid/issues/9539#issuecomment-1097089634 This issue is no longer marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [druid] pantlavanya commented on issue #9539: Data versioning

pantlavanya commented on issue #9539: URL: https://github.com/apache/druid/issues/9539#issuecomment-1097089535 Hi @aP0StAl, Is data versioning possible with DRUID, are you able to achieve? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [druid] loquisgon commented on a diff in pull request #12392: Make tombstones ingestible by having them return an empty result set.

loquisgon commented on code in PR #12392: URL: https://github.com/apache/druid/pull/12392#discussion_r848756111 ## indexing-service/src/main/java/org/apache/druid/indexing/input/DruidSegmentReaderBase.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [druid] loquisgon commented on a diff in pull request #12392: Make tombstones ingestible by having them return an empty result set.

loquisgon commented on code in PR #12392: URL: https://github.com/apache/druid/pull/12392#discussion_r848753443 ## indexing-service/src/main/java/org/apache/druid/indexing/input/DruidSegmentReaderBase.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [druid] loquisgon commented on a diff in pull request #12392: Make tombstones ingestible by having them return an empty result set.

loquisgon commented on code in PR #12392: URL: https://github.com/apache/druid/pull/12392#discussion_r848751638 ## indexing-service/src/main/java/org/apache/druid/indexing/input/DruidSegmentInputFormat.java: ## @@ -55,14 +55,27 @@ public InputEntityReader createReader(

[GitHub] [druid] vtlim commented on a diff in pull request #12415: Add docs to metric spec for auto compaction

vtlim commented on code in PR #12415: URL: https://github.com/apache/druid/pull/12415#discussion_r848750303 ## docs/configuration/index.md: ## @@ -970,6 +970,7 @@ A description of the compaction config is: |`granularitySpec`|Custom `granularitySpec`. See [Automatic compaction

[GitHub] [druid] maytasm commented on a diff in pull request #12415: Add docs to metric spec for auto compaction

maytasm commented on code in PR #12415: URL: https://github.com/apache/druid/pull/12415#discussion_r848745045 ## docs/configuration/index.md: ## @@ -970,6 +970,7 @@ A description of the compaction config is: |`granularitySpec`|Custom `granularitySpec`. See [Automatic

[GitHub] [druid] vtlim commented on a diff in pull request #12415: Add docs to metric spec for auto compaction

vtlim commented on code in PR #12415: URL: https://github.com/apache/druid/pull/12415#discussion_r848738936 ## docs/configuration/index.md: ## @@ -970,6 +970,7 @@ A description of the compaction config is: |`granularitySpec`|Custom `granularitySpec`. See [Automatic compaction

[GitHub] [druid] vtlim commented on a diff in pull request #12415: Add docs to metric spec for auto compaction

vtlim commented on code in PR #12415: URL: https://github.com/apache/druid/pull/12415#discussion_r848736156 ## docs/configuration/index.md: ## @@ -970,6 +970,7 @@ A description of the compaction config is: |`granularitySpec`|Custom `granularitySpec`. See [Automatic compaction

[GitHub] [druid] vtlim commented on a diff in pull request #12415: Add docs to metric spec for auto compaction

vtlim commented on code in PR #12415: URL: https://github.com/apache/druid/pull/12415#discussion_r848736156 ## docs/configuration/index.md: ## @@ -970,6 +970,7 @@ A description of the compaction config is: |`granularitySpec`|Custom `granularitySpec`. See [Automatic compaction

[GitHub] [druid] Green-Angry-Bird commented on issue #11816: Zstd version is incompatible with the version of Zstd used by the Kafka Indexing service

Green-Angry-Bird commented on issue #11816: URL: https://github.com/apache/druid/issues/11816#issuecomment-1097038974 Current workaround: For each node in the cluster, replace the zstd-jni-1.3.3-1.jar provided by Druid 0.22.1 with zstd-jni-1.5.0-4.jar (which can be found in Maven

[GitHub] [druid] gianm commented on issue #11929: Batch ingestion using SQL INSERT

gianm commented on issue #11929: URL: https://github.com/apache/druid/issues/11929#issuecomment-1097009985 > @gianm - can you elaborate more on how "DELETE WHERE" is a better clause than just "WHERE" clause? @abhishekagarwal87 It's for the reasons in this comment:

[GitHub] [druid] abhishekagarwal87 commented on pull request #12387: Add Kinesis ListShards permission

abhishekagarwal87 commented on PR #12387: URL: https://github.com/apache/druid/pull/12387#issuecomment-1096969597 Thank you @ektravel. can you fix merge conflicts? We can merge it once the conflicts are resolved. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [druid] jihoonson commented on a diff in pull request #12428: Fix indexMerger to respect the includeAllDimensions flag

jihoonson commented on code in PR #12428: URL: https://github.com/apache/druid/pull/12428#discussion_r848642474 ## processing/src/main/java/org/apache/druid/segment/IndexMergerV9.java: ## @@ -1460,4 +1456,33 @@ private static T reorderRowPointerColumns( ); } }

[GitHub] [druid] jihoonson commented on a diff in pull request #12428: Fix indexMerger to respect the includeAllDimensions flag

jihoonson commented on code in PR #12428: URL: https://github.com/apache/druid/pull/12428#discussion_r848642727 ## indexing-service/src/test/java/org/apache/druid/indexing/common/task/batch/parallel/HashPartitionMultiPhaseParallelIndexingWithNullColumnTest.java: ## @@ -165,37

[GitHub] [druid] ektravel commented on a diff in pull request #12387: Add Kinesis ListShards permission

ektravel commented on code in PR #12387: URL: https://github.com/apache/druid/pull/12387#discussion_r848567024 ## docs/development/extensions-core/kinesis-ingestion.md: ## @@ -340,18 +340,63 @@ For Concise bitmaps: ## Operations -This section gives descriptions of how some

[GitHub] [druid] pjfanning commented on pull request #12422: update httpclient due to cve

pjfanning commented on PR #12422: URL: https://github.com/apache/druid/pull/12422#issuecomment-1096815301 @kfaraz added link to https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-13956 in the PR description -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [druid] kfaraz commented on pull request #12422: update httpclient due to cve

kfaraz commented on PR #12422: URL: https://github.com/apache/druid/pull/12422#issuecomment-1096808362 @pjfanning , thank you for the changes. Please include the CVE link/details in the PR description. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [druid] kfaraz commented on a diff in pull request #12417: Use binary search to improve DimensionRangeShardSpec lookup

kfaraz commented on code in PR #12417: URL: https://github.com/apache/druid/pull/12417#discussion_r848498587 ## core/src/main/java/org/apache/druid/timeline/partition/BaseDimensionRangeShardSpec.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [druid] kfaraz commented on a diff in pull request #12417: Use binary search to improve DimensionRangeShardSpec lookup

kfaraz commented on code in PR #12417: URL: https://github.com/apache/druid/pull/12417#discussion_r848498166 ## core/src/main/java/org/apache/druid/timeline/partition/BaseDimensionRangeShardSpec.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [druid] kfaraz commented on a diff in pull request #12417: Use binary search to improve DimensionRangeShardSpec lookup

kfaraz commented on code in PR #12417: URL: https://github.com/apache/druid/pull/12417#discussion_r848497461 ## core/src/main/java/org/apache/druid/timeline/partition/BaseDimensionRangeShardSpec.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [druid] kfaraz commented on a diff in pull request #12428: Fix indexMerger to respect the includeAllDimensions flag

kfaraz commented on code in PR #12428: URL: https://github.com/apache/druid/pull/12428#discussion_r848297249 ## core/src/test/java/org/apache/druid/data/input/impl/JsonInputFormatTest.java: ## @@ -72,4 +72,26 @@ public void testEquals()

[GitHub] [druid] pjfanning commented on pull request #12427: issue-12426 upgrade k8s client due to cve

pjfanning commented on PR #12427: URL: https://github.com/apache/druid/pull/12427#issuecomment-1096475335 > @pjfanning can we indicate in the PR description what version we are upgrading to, and point out that this is a major version bump (including a link to the release notes would be

[GitHub] [druid] adarshsanjeev opened a new pull request, #12431: Validate select columns for insert statement

adarshsanjeev opened a new pull request, #12431: URL: https://github.com/apache/druid/pull/12431 ### Description Unnamed columns in the select part of insert SQL statements currently create a table with the column name such as "EXPR$3". This PR adds a check for this. - Add

[GitHub] [druid] pjfanning opened a new issue, #12430: Security: upgrade h2 database version due to multiple CVEs

pjfanning opened a new issue, #12430: URL: https://github.com/apache/druid/issues/12430 ### Description processing/pom.xml upgrade h2 to at least 2.1.210 * https://github.com/advisories/GHSA-45hx-wfhj-473x * https://github.com/advisories/GHSA-7rpj-hg47-cx62 *

[GitHub] [druid] pjfanning commented on pull request #12422: update httpclient due to cve

pjfanning commented on PR #12422: URL: https://github.com/apache/druid/pull/12422#issuecomment-1096465206 Build failed with memory issues in one test - org.apache.druid.query.groupby.epinephelinae.BufferHashGrouperTest -- This is an automated message from the Apache Git Service. To

[GitHub] [druid] rohangarg commented on issue #11929: Batch ingestion using SQL INSERT

rohangarg commented on issue #11929: URL: https://github.com/apache/druid/issues/11929#issuecomment-1096453944 +1 to Gian's new syntax suggestion. I strongly prefer `ALL` over `WHERE TRUE` in the `DELETE` clause - even if both can be supported. -- This is an automated message from

[GitHub] [druid] LakshSingla commented on issue #11929: Batch ingestion using SQL INSERT

LakshSingla commented on issue #11929: URL: https://github.com/apache/druid/issues/11929#issuecomment-1096431798 > One nit on the `WHERE TRUE`: this won't work the way we hope. The default in SQL is `WHERE TRUE`. Calcite will optimize all trivial expressions `WHERE 1=1`, `WHERE 0=0`, etc.

[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #12387: Add Kinesis ListShards permission

abhishekagarwal87 commented on code in PR #12387: URL: https://github.com/apache/druid/pull/12387#discussion_r848182584 ## docs/development/extensions-core/kinesis-ingestion.md: ## @@ -340,18 +340,63 @@ For Concise bitmaps: ## Operations -This section gives descriptions of

[GitHub] [druid] abhishekagarwal87 commented on issue #11929: Batch ingestion using SQL INSERT

abhishekagarwal87 commented on issue #11929: URL: https://github.com/apache/druid/issues/11929#issuecomment-1096352215 @gianm - can you elaborate more on how "DELETE WHERE" is a better clause than just "WHERE" clause? -- This is an automated message from the Apache Git Service. To

[GitHub] [druid] hqx871 commented on a diff in pull request #12417: Use binary search to improve DimensionRangeShardSpec lookup

hqx871 commented on code in PR #12417: URL: https://github.com/apache/druid/pull/12417#discussion_r848018747 ## core/src/main/java/org/apache/druid/timeline/partition/DimensionRangeShardSpec.java: ## @@ -279,25 +253,14 @@ public PartitionChunk createChunk(T obj) } }

[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #12387: Add Kinesis ListShards permission

abhishekagarwal87 commented on code in PR #12387: URL: https://github.com/apache/druid/pull/12387#discussion_r847956546 ## docs/development/extensions-core/kinesis-ingestion.md: ## @@ -340,18 +340,63 @@ For Concise bitmaps: ## Operations -This section gives descriptions of