Re: [PR] Add storeCompactionState flag support to msq (druid)

github-advanced-security[bot] commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1535093716 ## extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQReplaceTest.java: ## @@ -948,6 +1053,68 @@

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

cryptoe commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535114824 ## indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java: ## @@ -175,6 +182,11 @@ public TaskQueue(

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

kfaraz commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535124620 ## indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java: ## @@ -152,6 +157,8 @@ public class TaskQueue private final AtomicInteger

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

kfaraz commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535127992 ## indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java: ## @@ -970,15 +982,32 @@ public CoordinatorRunStats getQueueStats() return

Re: [PR] pacj4: add UserProfile attributes to AuthenticationResult context (druid)

abhishekagarwal87 commented on code in PR #16109: URL: https://github.com/apache/druid/pull/16109#discussion_r1535256072 ## extensions-core/druid-pac4j/src/main/java/org/apache/druid/security/pac4j/Pac4jFilter.java: ## @@ -96,24 +97,24 @@ public void doFilter(ServletRequest

Re: [PR] pacj4: add UserProfile attributes to AuthenticationResult context (druid)

jakubmatyszewski commented on code in PR #16109: URL: https://github.com/apache/druid/pull/16109#discussion_r1535280910 ## extensions-core/druid-pac4j/src/main/java/org/apache/druid/security/pac4j/Pac4jFilter.java: ## @@ -96,24 +97,24 @@ public void doFilter(ServletRequest

Re: [PR] pacj4: add UserProfile attributes to AuthenticationResult context (druid)

abhishekagarwal87 commented on code in PR #16109: URL: https://github.com/apache/druid/pull/16109#discussion_r1535257536 ## extensions-core/druid-pac4j/src/main/java/org/apache/druid/security/pac4j/Pac4jFilter.java: ## @@ -96,24 +97,24 @@ public void doFilter(ServletRequest

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

kfaraz commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535261509 ## indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java: ## @@ -152,6 +157,8 @@ public class TaskQueue private final AtomicInteger

Re: [PR] add tutorial with examples of sql null handling (druid)

clintropolis commented on code in PR #16185: URL: https://github.com/apache/druid/pull/16185#discussion_r1535336126 ## docs/querying/sql-data-types.md: ## @@ -140,23 +140,38 @@ as regular JSON arrays instead of in stringified form. ## NULL values +By default, Druid treats

Re: [PR] add new typed in filter (druid)

clintropolis commented on code in PR #16039: URL: https://github.com/apache/druid/pull/16039#discussion_r1535392032 ## processing/src/main/java/org/apache/druid/query/filter/TypedInFilter.java: ## @@ -0,0 +1,713 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

AmatyaAvadhanula commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535500985 ## indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskStorageQueryAdapter.java: ## @@ -114,7 +114,7 @@ public Optional getTask(final String

Re: [PR] Add storeCompactionState flag support to msq (druid)

gargvishesh commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1535540376 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1715,9 +1726,119 @@ private void publishSegmentsIfNeeded(

Re: [PR] Add storeCompactionState flag support to msq (druid)

AmatyaAvadhanula commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1535685779 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1715,11 +1726,116 @@ private void

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

AmatyaAvadhanula commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535447920 ## indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java: ## @@ -152,6 +157,8 @@ public class TaskQueue private final

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

AmatyaAvadhanula commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535447490 ## indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java: ## @@ -970,15 +982,32 @@ public CoordinatorRunStats getQueueStats()

[PR] Refactor: Clean up TaskQueueTest (druid)

kfaraz opened a new pull request, #16187: URL: https://github.com/apache/druid/pull/16187 ### Changes - Remove redundant code from `TaskQueueTest` - Use lambdas in `TaskQueue` - Simplify error message when `TaskQueue` is full -- This is an automated message from the Apache Git

Re: [PR] Parameterize segment IDs (druid)

abhishekrb19 merged PR #16174: URL: https://github.com/apache/druid/pull/16174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: Parameterize segment IDs (#16174)

This is an automated email from the ASF dual-hosted git repository. abhishekrb pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new a70e28a3c28 Parameterize segment IDs

Re: [PR] Add storeCompactionState flag support to msq (druid)

gargvishesh commented on PR #15965: URL: https://github.com/apache/druid/pull/15965#issuecomment-2015067945 > I think we are interested in storing the compaction state to prevent additional compactions from running on an already compacted interval. I've moved the annotation function

Re: [PR] Add storeCompactionState flag support to msq (druid)

gargvishesh commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1535545607 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1715,9 +1726,119 @@ private void publishSegmentsIfNeeded(

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

AmatyaAvadhanula commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535524733 ## indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskQueueTest.java: ## @@ -519,6 +550,95 @@ public void testGetTaskStatus()

Re: [PR] Add storeCompactionState flag support to msq (druid)

github-advanced-security[bot] commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1535645356 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1715,11 +1726,116 @@

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

kfaraz commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535779057 ## indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java: ## @@ -152,6 +157,7 @@ public class TaskQueue private final AtomicInteger

Re: [PR] Add storeCompactionState flag support to msq (druid)

gargvishesh commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1535547300 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1719,9 +1731,129 @@ private void publishSegmentsIfNeeded(

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

kfaraz commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535497863 ## indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskQueueTest.java: ## @@ -519,6 +550,95 @@ public void testGetTaskStatus()

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

kfaraz commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535497863 ## indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskQueueTest.java: ## @@ -519,6 +550,95 @@ public void testGetTaskStatus()

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

AmatyaAvadhanula commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535525437 ## indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskQueueTest.java: ## @@ -519,6 +550,95 @@ public void testGetTaskStatus()

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

AmatyaAvadhanula commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535526176 ## indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java: ## @@ -1000,11 +997,13 @@ public Optional getActiveTask(String id) throws

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

AmatyaAvadhanula commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535525904 ## indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskQueueTest.java: ## @@ -519,6 +550,95 @@ public void testGetTaskStatus()

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

kfaraz commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535468113 ## indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java: ## @@ -1000,11 +997,13 @@ public Optional getActiveTask(String id) throws

Re: [PR] Refactor: Clean up TaskQueueTest (druid)

github-advanced-security[bot] commented on code in PR #16187: URL: https://github.com/apache/druid/pull/16187#discussion_r1535733776 ## indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskQueueTest.java: ## @@ -658,111 +516,28 @@ } } - private

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

kfaraz commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535778633 ## indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskStorageQueryAdapter.java: ## @@ -114,7 +114,7 @@ public Optional getTask(final String taskid)

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

AmatyaAvadhanula commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1535448346 ## indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java: ## @@ -175,6 +182,11 @@ public TaskQueue(

[PR] Add errorCode to failure type `InternalServerError` (druid)

kfaraz opened a new pull request, #16186: URL: https://github.com/apache/druid/pull/16186 Looking at other failure types such as `InvalidInput`, `InvalidSqlInput`, etc. it makes to have the error code be fixed for a certain of failure. The only two usages of the method

[PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

zachjsh opened a new pull request, #16190: URL: https://github.com/apache/druid/pull/16190 Fixes #16189 ### Description This fixes an issue in which updating a kafka streaming supervisors topic from single to multi-topic (pattern), or vice versa, could cause old offsets to

Re: [PR] Enhanced JsonInputFormatBenchmark. (druid)

gianm commented on PR #16188: URL: https://github.com/apache/druid/pull/16188#issuecomment-2016059800 This benchmark is also present in #15693. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Allow non literal rhs in MV_FILTER_ONLY and MV_FILTER_NONE (druid)

clintropolis commented on code in PR #16113: URL: https://github.com/apache/druid/pull/16113#discussion_r1536306394 ## processing/src/test/java/org/apache/druid/math/expr/ApplyFunctionTest.java: ## @@ -93,6 +93,10 @@ public void testFilter() assertExpr("filter((x) -> x >

Re: [PR] Handling nil selector column in vector math processors (druid)

clintropolis commented on code in PR #16128: URL: https://github.com/apache/druid/pull/16128#discussion_r1536314706 ## processing/src/main/java/org/apache/druid/math/expr/Function.java: ## @@ -241,7 +241,11 @@ public ExpressionType getOutputType(Expr.InputBindingInspector

Re: [PR] Web console: Better forced mode indication (druid)

techdocsmith commented on code in PR #16191: URL: https://github.com/apache/druid/pull/16191#discussion_r1536324781 ## web-console/src/components/header-bar/header-bar.tsx: ## @@ -496,6 +358,38 @@ export const HeaderBar = React.memo(function HeaderBar(props: HeaderBarProps) {

Re: [PR] Web console: Better forced mode indication (druid)

techdocsmith commented on code in PR #16191: URL: https://github.com/apache/druid/pull/16191#discussion_r1536335958 ## web-console/src/components/header-bar/restricted-mode/__snapshots__/restricted-mode.spec.tsx.snap: ## @@ -0,0 +1,69 @@ +// Jest Snapshot v1,

Re: [PR] Geo spatial interfaces (druid)

pranavbhole commented on code in PR #16029: URL: https://github.com/apache/druid/pull/16029#discussion_r1536112027 ## processing/src/main/java/org/apache/druid/collections/spatial/RTreeUtils.java: ## @@ -71,4 +72,41 @@ public static void enclose(Node[] nodes) } } +

Re: [PR] Geo spatial interfaces (druid)

pranavbhole commented on code in PR #16029: URL: https://github.com/apache/druid/pull/16029#discussion_r1536112367 ## processing/src/main/java/org/apache/druid/collections/spatial/ImmutableRTree32BitImpl.java: ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software

Re: [PR] Bump sigar.version from 1.6.5.132 to 1.6.5.132-6 (druid)

github-actions[bot] commented on PR #14821: URL: https://github.com/apache/druid/pull/14821#issuecomment-2016211971 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Re: [PR] Bump sigar.version from 1.6.5.132 to 1.6.5.132-6 (druid)

github-actions[bot] closed pull request #14821: Bump sigar.version from 1.6.5.132 to 1.6.5.132-6 URL: https://github.com/apache/druid/pull/14821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix a bug in index_hadoop that leads to orphaned indexing files in hdfs after jobs run (druid)

github-actions[bot] closed pull request #14829: Fix a bug in index_hadoop that leads to orphaned indexing files in hdfs after jobs run URL: https://github.com/apache/druid/pull/14829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Bump sigar.version from 1.6.5.132 to 1.6.5.132-6 (druid)

dependabot[bot] commented on PR #14821: URL: https://github.com/apache/druid/pull/14821#issuecomment-2016212007 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency

[PR] Bump org.apache.commons:commons-compress from 1.26.0 to 1.26.1 (druid)

dependabot[bot] opened a new pull request, #16193: URL: https://github.com/apache/druid/pull/16193 Bumps org.apache.commons:commons-compress from 1.26.0 to 1.26.1. [![Dependabot compatibility

(druid) branch dependabot/maven/org.apache.commons-commons-compress-1.26.1 created (now aca754cb3cb)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.commons-commons-compress-1.26.1 in repository https://gitbox.apache.org/repos/asf/druid.git at aca754cb3cb Bump org.apache.commons:commons-compress from

Re: [PR] Fix a bug in index_hadoop that leads to orphaned indexing files in hdfs after jobs run (druid)

github-actions[bot] commented on PR #14829: URL: https://github.com/apache/druid/pull/14829#issuecomment-2016211989 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

(druid) branch dependabot/maven/sigar.version-1.6.5.132-6 deleted (was 9c55bd7d2f2)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/sigar.version-1.6.5.132-6 in repository https://gitbox.apache.org/repos/asf/druid.git was 9c55bd7d2f2 update licenses.yaml The revisions that were on this branch are

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

AmatyaAvadhanula commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1536571617 ## indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskStorageQueryAdapter.java: ## @@ -114,7 +114,7 @@ public Optional getTask(final String

Re: [PR] Redact passwords from tasks fetched from the TaskQueue (druid)

AmatyaAvadhanula commented on code in PR #16182: URL: https://github.com/apache/druid/pull/16182#discussion_r1536571640 ## indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java: ## @@ -152,6 +157,7 @@ public class TaskQueue private final

[I] Kafka with topicPattern can ignore old offsets spuriously (druid)

zachjsh opened a new issue, #16189: URL: https://github.com/apache/druid/issues/16189 In SeekableStreamSupervisor::getOffsetsFromMetadataStorage(), we do: ``` if (!ioConfig.getStream().equals(partitions.getStream())) { log.warn( "Topic/stream in

[PR] Adding null value check and appropriate log (druid)

aruraghuwanshi opened a new pull request, #16192: URL: https://github.com/apache/druid/pull/16192 Fixes #16177. ### Description Fixed a bug in the KafkaStringHeaderReader class where ingestion would throw a

Re: [PR] Adding null value check and appropriate log (druid)

kfaraz commented on code in PR #16192: URL: https://github.com/apache/druid/pull/16192#discussion_r1536548096 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/data/input/kafkainput/KafkaStringHeaderReader.java: ## @@ -48,10 +48,17 @@ public

Re: [PR] Geo spatial interfaces (druid)

pranavbhole commented on code in PR #16029: URL: https://github.com/apache/druid/pull/16029#discussion_r1536245348 ## processing/src/main/java/org/apache/druid/collections/spatial/search/RadiusBound.java: ## @@ -23,37 +23,60 @@ import

Re: [PR] Geo spatial interfaces (druid)

clintropolis commented on code in PR #16029: URL: https://github.com/apache/druid/pull/16029#discussion_r1536184367 ## processing/src/main/java/org/apache/druid/collections/spatial/search/RadiusBound.java: ## @@ -23,37 +23,60 @@ import

[PR] Enhanced JsonInputFormatBenchmark. (druid)

gianm opened a new pull request, #16188: URL: https://github.com/apache/druid/pull/16188 Renames JsonLineReaderBenchmark to JsonInputFormatBenchmark, and enhances it to test various readers (JsonReader, JsonLineReader, JsonNodeReader) as well as to test with/without field discovery.

Re: [PR] add new typed in filter (druid)

clintropolis merged PR #16039: URL: https://github.com/apache/druid/pull/16039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] INSERT/REPLACE dimension target column types are validated against source input expressions (druid)

clintropolis commented on code in PR #15962: URL: https://github.com/apache/druid/pull/15962#discussion_r1536264246 ## sql/src/test/java/org/apache/druid/sql/calcite/CalciteCatalogIngestionDmlTest.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation