(druid) tag druid-29.0.1 created (now 15b3efd085d)

2024-04-01 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a change to tag druid-29.0.1 in repository https://gitbox.apache.org/repos/asf/druid.git at 15b3efd085d (commit) No new revisions were added by this update.

Re: [PR] Fix deadlock that can occur while merging group by results (druid)

2024-04-01 Thread via GitHub
LakshSingla commented on code in PR #15420: URL: https://github.com/apache/druid/pull/15420#discussion_r1547144457 ## processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryQueryToolChest.java: ## @@ -102,35 +104,53 @@ public class GroupByQueryQueryToolChest

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
gargvishesh commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1547165462 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1715,9 +1726,109 @@ private void publishSegmentsIfNeeded(

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
gargvishesh commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1547168972 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1715,9 +1726,109 @@ private void publishSegmentsIfNeeded(

Re: [PR] Configure a max limit for lgK values of HLL sketches (druid)

2024-04-01 Thread via GitHub
github-actions[bot] commented on PR #15516: URL: https://github.com/apache/druid/pull/15516#issuecomment-2030834237 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

svn commit: r68235 - /dev/druid/29.0.1-rc1/ /release/druid/29.0.1/

2024-04-01 Thread karan
Author: karan Date: Tue Apr 2 04:46:08 2024 New Revision: 68235 Log: add 29.0.1 artifacts Added: release/druid/29.0.1/ - copied from r68234, dev/druid/29.0.1-rc1/ Removed: dev/druid/29.0.1-rc1/ - To unsubscribe,

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
gargvishesh commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1547166593 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1715,9 +1726,109 @@ private void publishSegmentsIfNeeded(

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
gargvishesh commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1547165252 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1715,9 +1726,109 @@ private void publishSegmentsIfNeeded(

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
gargvishesh commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1547166348 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java: ## @@ -583,7 +583,7 @@ public static boolean

Re: [PR] Bump commons-io:commons-io from 2.11.0 to 2.15.1 (druid)

2024-04-01 Thread via GitHub
dependabot[bot] closed pull request #15578: Bump commons-io:commons-io from 2.11.0 to 2.15.1 URL: https://github.com/apache/druid/pull/15578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Bump commons-io:commons-io from 2.11.0 to 2.16.0 (druid)

2024-04-01 Thread via GitHub
dependabot[bot] opened a new pull request, #16225: URL: https://github.com/apache/druid/pull/16225 Bumps commons-io:commons-io from 2.11.0 to 2.16.0. [![Dependabot compatibility

(druid) branch dependabot/maven/commons-io-commons-io-2.16.0 created (now 32090ec5f16)

2024-04-01 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/commons-io-commons-io-2.16.0 in repository https://gitbox.apache.org/repos/asf/druid.git at 32090ec5f16 Bump commons-io:commons-io from 2.11.0 to 2.16.0 No new

Re: [PR] Bump commons-io:commons-io from 2.11.0 to 2.15.1 (druid)

2024-04-01 Thread via GitHub
dependabot[bot] commented on PR #15578: URL: https://github.com/apache/druid/pull/15578#issuecomment-2030833181 Superseded by #16225. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(druid) branch dependabot/maven/commons-io-commons-io-2.15.1 deleted (was 231b38da2b0)

2024-04-01 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/commons-io-commons-io-2.15.1 in repository https://gitbox.apache.org/repos/asf/druid.git was 231b38da2b0 Bump commons-io:commons-io from 2.11.0 to 2.15.1 The

Re: [PR] Fix deadlock that can occur while merging group by results (druid)

2024-04-01 Thread via GitHub
gianm commented on code in PR #15420: URL: https://github.com/apache/druid/pull/15420#discussion_r1546905734 ## processing/src/main/java/org/apache/druid/query/FluentQueryRunner.java: ## @@ -90,9 +90,9 @@ public FluentQueryRunner postProcess(PostProcessingOperator

[PR] Fix OverlordClient to read reports as a concrete `ReportMap` object instead of a generic map (druid)

2024-04-01 Thread via GitHub
kfaraz opened a new pull request, #16226: URL: https://github.com/apache/druid/pull/16226 ### Changes - Update `OverlordClient.getReportAsMap()` to return `TaskReport.ReportMap` - Move the following classes to `org.apache.druid.indexer.report` in the `druid-processing` module

Re: [PR] Handling nil selector column in vector math processors (druid)

2024-04-01 Thread via GitHub
sreemanamala commented on code in PR #16128: URL: https://github.com/apache/druid/pull/16128#discussion_r1547135705 ## processing/src/main/java/org/apache/druid/math/expr/Function.java: ## @@ -241,7 +241,11 @@ public ExpressionType getOutputType(Expr.InputBindingInspector

[PR] Fix name of combining filtered aggregator factory. (druid)

2024-04-01 Thread via GitHub
gianm opened a new pull request, #16224: URL: https://github.com/apache/druid/pull/16224 The name of the combining filtered aggregator factory should be the same as the name of the original factory. However, it wasn't the same in the case where the original factory's name and the original

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
gargvishesh commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1547164186 ## docs/multi-stage-query/reference.md: ## @@ -366,6 +366,7 @@ The following table lists the context parameters for the MSQ task engine: | `rowsPerPage` |

Re: [PR] fix complex types returning UNKNOWN as their SQL type inference (druid)

2024-04-01 Thread via GitHub
clintropolis commented on code in PR #16216: URL: https://github.com/apache/druid/pull/16216#discussion_r1547164612 ## sql/src/main/java/org/apache/druid/sql/calcite/planner/Calcites.java: ## @@ -100,6 +100,15 @@ public class Calcites public static final

Re: [PR] Cleanup serialiazation of TaskReportMap (druid)

2024-04-01 Thread via GitHub
gianm merged PR #16217: URL: https://github.com/apache/druid/pull/16217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: Cleanup serialiazation of TaskReportMap (#16217)

2024-04-01 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 0de44d91f1b Cleanup serialiazation of

(druid) branch master updated: only pick kafka input format by default when needed (#16180)

2024-04-01 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 06268bf060e only pick kafka input format by

(druid) branch master updated (0de44d91f1b -> a818b8acb67)

2024-04-01 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from 0de44d91f1b Cleanup serialiazation of TaskReportMap (#16217) add a818b8acb67 Fix

[PR] INSERT/REPLACE complex target column types are validated against source input expressions (druid)

2024-04-01 Thread via GitHub
zachjsh opened a new pull request, #16223: URL: https://github.com/apache/druid/pull/16223 ### Description This change allows for tables that are defined in the catalog to have their complex defined column types validated against source input expressions mapped to them during DML

[I] /v2 and /v2/candidates endpoints not respecting broker partition pruning - range partition (druid)

2024-04-01 Thread via GitHub
ColeAtCharter opened a new issue, #16222: URL: https://github.com/apache/druid/issues/16222 This is to report unexpected behavior where the broker selects too many segments to query. The identified scenario is when secondary partition information exists (eg, for range partitioning) but is

Re: [I] SQL does not properly handle equals between timestamp and string literal (druid)

2024-04-01 Thread via GitHub
gianm closed issue #13400: SQL does not properly handle equals between timestamp and string literal URL: https://github.com/apache/druid/issues/13400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Fix CalciteQueryTest#testCountStarWithTimeFilterUsingStringLiterals (druid)

2024-04-01 Thread via GitHub
gianm merged PR #16221: URL: https://github.com/apache/druid/pull/16221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Web console: Better manual capabilities detection indication (druid)

2024-04-01 Thread via GitHub
gianm commented on code in PR #16191: URL: https://github.com/apache/druid/pull/16191#discussion_r1546830453 ## web-console/src/components/header-bar/header-bar.tsx: ## @@ -495,7 +365,48 @@ export const HeaderBar = React.memo(function HeaderBar(props: HeaderBarProps) {

Re: [PR] Web console: only pick kafka input format by default when needed (druid)

2024-04-01 Thread via GitHub
gianm merged PR #16180: URL: https://github.com/apache/druid/pull/16180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Improve worst-case performance of LIKE filters by 20x (druid)

2024-04-01 Thread via GitHub
gianm commented on PR #16153: URL: https://github.com/apache/druid/pull/16153#issuecomment-2030550437 For `LIKE` it seems reasonable to have an optimized matcher specifically geared towards the needs of `LIKE`. I am disappointed that the JDK regexp library doesn't handle these relatively

Re: [PR] docs: add tutorial with examples of sql null handling (druid)

2024-04-01 Thread via GitHub
317brian merged PR #16185: URL: https://github.com/apache/druid/pull/16185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: docs: add tutorial with examples of sql null handling (#16185)

2024-04-01 Thread brile
This is an automated email from the ASF dual-hosted git repository. brile pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 1aa6808b9a5 docs: add tutorial with examples of

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
kfaraz commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1546067491 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1715,9 +1726,109 @@ private void publishSegmentsIfNeeded(

Re: [PR] Geo spatial interfaces (druid)

2024-04-01 Thread via GitHub
abhishekagarwal87 merged PR #16029: URL: https://github.com/apache/druid/pull/16029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated (27b4028782b -> 20de7fd95a6)

2024-04-01 Thread abhishek
This is an automated email from the ASF dual-hosted git repository. abhishek pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from 27b4028782b Bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /web-console (#16195) add 20de7fd95a6 Geo

Re: [I] SQL does not properly handle equals between timestamp and string literal (druid)

2024-04-01 Thread via GitHub
alex-plekhanov commented on issue #13400: URL: https://github.com/apache/druid/issues/13400#issuecomment-2030105466 @gianm looks like this issue is already fixed by Calcite. I've added new test cases and the test is passed (but failure is reproduced on branches before Calcite upgrade to

Re: [PR] Geo spatial interfaces (druid)

2024-04-01 Thread via GitHub
abhishekagarwal87 commented on code in PR #16029: URL: https://github.com/apache/druid/pull/16029#discussion_r1546147919 ## processing/src/main/java/org/apache/druid/collections/spatial/ImmutableFloatNode.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
kfaraz commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1546076578 ## processing/src/test/java/org/apache/druid/timeline/DataSegmentTest.java: ## @@ -361,10 +364,48 @@ public void testWithLastCompactionState()

Re: [PR] Add heartbeat and zk-connected metrics in defaultMetrics.json (druid)

2024-04-01 Thread via GitHub
kfaraz commented on PR #16209: URL: https://github.com/apache/druid/pull/16209#issuecomment-2029491903 Congrats on your first contribution to Druid, @tapojit047 !! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Add heartbeat and zk-connected metrics in defaultMetrics.json (druid)

2024-04-01 Thread via GitHub
kfaraz merged PR #16209: URL: https://github.com/apache/druid/pull/16209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Druid prometheus-emitter does not emit all the metrics (druid)

2024-04-01 Thread via GitHub
kfaraz closed issue #16148: Druid prometheus-emitter does not emit all the metrics URL: https://github.com/apache/druid/issues/16148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(druid) branch master updated (20de7fd95a6 -> dbef348249d)

2024-04-01 Thread kfaraz
This is an automated email from the ASF dual-hosted git repository. kfaraz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from 20de7fd95a6 Geo spatial interfaces (#16029) add dbef348249d Include heartbeat and zk-connected metric in

[PR] Fix CalciteQueryTest#testCountStarWithTimeFilterUsingStringLiterals (druid)

2024-04-01 Thread via GitHub
alex-plekhanov opened a new pull request, #16221: URL: https://github.com/apache/druid/pull/16221 Fixes #13400. ### Description Added test cases to check handling equals between timestamp and string literal This PR has: - [ ] been self-reviewed. - [ ]

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
cryptoe commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1546034348 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1715,9 +1726,109 @@ private void publishSegmentsIfNeeded(

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
kfaraz commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1546061477 ## extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQReplaceTest.java: ## @@ -948,6 +1053,68 @@ new

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
kfaraz commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1546062627 ## docs/multi-stage-query/reference.md: ## @@ -366,6 +366,7 @@ The following table lists the context parameters for the MSQ task engine: | `rowsPerPage` | SELECTThe

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
kfaraz commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1546064796 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1715,9 +1726,109 @@ private void publishSegmentsIfNeeded(

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
kfaraz commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1546065103 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1715,9 +1726,109 @@ private void publishSegmentsIfNeeded(

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
kfaraz commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1546066568 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1715,9 +1726,109 @@ private void publishSegmentsIfNeeded(

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
kfaraz commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1546066568 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1715,9 +1726,109 @@ private void publishSegmentsIfNeeded(

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
kfaraz commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1546067491 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1715,9 +1726,109 @@ private void publishSegmentsIfNeeded(

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
kfaraz commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1546061477 ## extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQReplaceTest.java: ## @@ -948,6 +1053,68 @@ new

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
kfaraz commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1546024386 ## processing/src/main/java/org/apache/druid/timeline/CompactionState.java: ## @@ -146,4 +149,29 @@ public String toString() ", metricsSpec=" + metricsSpec

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
kfaraz commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1546027085 ## docs/multi-stage-query/reference.md: ## @@ -366,6 +366,7 @@ The following table lists the context parameters for the MSQ task engine: | `rowsPerPage` | SELECTThe

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-01 Thread via GitHub
kfaraz commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1546028100 ## website/.spelling: ## @@ -1328,6 +1328,7 @@ valueFormat IOConfig compactionTask compactionTasks +storeCompactionState Review Comment: This will probably not