Re: [PR] add google as external storage for msq export (druid)

2024-04-05 Thread via GitHub
abhishekagarwal87 commented on code in PR #16051: URL: https://github.com/apache/druid/pull/16051#discussion_r1552981537 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/output/GoogleExportConfig.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to

Re: [PR] add google as external storage for msq export (druid)

2024-04-05 Thread via GitHub
abhishekagarwal87 commented on PR #16051: URL: https://github.com/apache/druid/pull/16051#issuecomment-2039026288 @adarshsanjeev - If its looks good to you, can we merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] add google as external storage for msq export (druid)

2024-04-05 Thread via GitHub
abhishekagarwal87 merged PR #16051: URL: https://github.com/apache/druid/pull/16051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] add google as external storage for msq export (druid)

2024-04-05 Thread via GitHub
adarshsanjeev commented on PR #16051: URL: https://github.com/apache/druid/pull/16051#issuecomment-2039043960 Yes, the changes look good to me! Thanks for the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Add reasoning for choosing shardSpec to the MSQ report (druid)

2024-04-05 Thread via GitHub
cryptoe commented on PR #16175: URL: https://github.com/apache/druid/pull/16175#issuecomment-2039023633 cc @vogievetsky for the web console changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Unifying GroupBy strategies and grouping on complex columns (druid)

2024-04-05 Thread via GitHub
LakshSingla commented on code in PR #16068: URL: https://github.com/apache/druid/pull/16068#discussion_r1553265926 ## processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByColumnSelectorStrategyFactory.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the

Re: [PR] Reduce upload buffer size in GoogleTaskLogs. (druid)

2024-04-05 Thread via GitHub
gargvishesh commented on code in PR #16236: URL: https://github.com/apache/druid/pull/16236#discussion_r1553040950 ## extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleStorage.java: ## @@ -53,20 +62,34 @@ public class GoogleStorage *

Re: [PR] Improve worst-case performance of LIKE filters by 20x (druid)

2024-04-05 Thread via GitHub
abhishekagarwal87 commented on PR #16153: URL: https://github.com/apache/druid/pull/16153#issuecomment-2039313940 @gianm - https://github.com/google/re2j seems to fit the bill. A cluster-wide setting that switches the regex-based filters to use this library instead of the standard Java

Re: [PR] Add reasoning for choosing shardSpec to the MSQ report (druid)

2024-04-05 Thread via GitHub
adarshsanjeev commented on code in PR #16175: URL: https://github.com/apache/druid/pull/16175#discussion_r1553104056 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -2036,19 +2045,24 @@ private static boolean

Re: [PR] Add reasoning for choosing shardSpec to the MSQ report (druid)

2024-04-05 Thread via GitHub
adarshsanjeev commented on code in PR #16175: URL: https://github.com/apache/druid/pull/16175#discussion_r1553110171 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -2057,25 +2071,25 @@ private static List

Re: [PR] Geo spatial interfaces (druid)

2024-04-05 Thread via GitHub
pranavbhole commented on code in PR #16029: URL: https://github.com/apache/druid/pull/16029#discussion_r1552983200 ## processing/src/main/java/org/apache/druid/collections/spatial/ImmutableFloatNode.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation

[PR] Moving object contains to Bound for string/object matchers (druid)

2024-04-05 Thread via GitHub
pranavbhole opened a new pull request, #16241: URL: https://github.com/apache/druid/pull/16241 Followup of https://github.com/apache/druid/pull/16029/files + Addressing @abhishekagarwal87 's comments from previous PR. ### Description Creating a generic object contains interface

(druid) branch master updated: add google as external storage for msq export (#16051)

2024-04-05 Thread abhishek
This is an automated email from the ASF dual-hosted git repository. abhishek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new f55c9e58a8b add google as external storage for

Re: [PR] Add reasoning for choosing shardSpec to the MSQ report (druid)

2024-04-05 Thread via GitHub
adarshsanjeev commented on code in PR #16175: URL: https://github.com/apache/druid/pull/16175#discussion_r1553104056 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -2036,19 +2045,24 @@ private static boolean

Re: [PR] Add reasoning for choosing shardSpec to the MSQ report (druid)

2024-04-05 Thread via GitHub
adarshsanjeev commented on code in PR #16175: URL: https://github.com/apache/druid/pull/16175#discussion_r1553103594 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -2036,19 +2045,24 @@ private static boolean

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-05 Thread via GitHub
kfaraz commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1553532394 ## extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQReplaceTest.java: ## @@ -948,6 +1053,68 @@ new

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-05 Thread via GitHub
kfaraz commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1553532394 ## extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQReplaceTest.java: ## @@ -948,6 +1053,68 @@ new

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-05 Thread via GitHub
gargvishesh commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1553524461 ## docs/multi-stage-query/reference.md: ## @@ -346,27 +346,27 @@ If you're using the web console, you can specify the context parameters through The following

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-05 Thread via GitHub
gargvishesh commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1553523869 ## extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQReplaceTest.java: ## @@ -948,6 +1053,68 @@ new

Re: [PR] Fix CVE errors (druid)

2024-04-05 Thread via GitHub
abhishekagarwal87 merged PR #16147: URL: https://github.com/apache/druid/pull/16147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: Fix CVE errors (#16147)

2024-04-05 Thread abhishek
This is an automated email from the ASF dual-hosted git repository. abhishek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new af24cc88ce9 Fix CVE errors (#16147)

Re: [PR] Add storeCompactionState flag support to msq (druid)

2024-04-05 Thread via GitHub
gargvishesh commented on code in PR #15965: URL: https://github.com/apache/druid/pull/15965#discussion_r1553525438 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -1714,12 +1727,121 @@ private void publishSegmentsIfNeeded(

[PR] Correct the properties used at ranger authorizer (druid)

2024-04-05 Thread via GitHub
zemin-piao opened a new pull request, #16242: URL: https://github.com/apache/druid/pull/16242 Second attempt on https://github.com/apache/druid/pull/13255 ### Description Following changes are done at

[PR] Bump io.grpc:grpc-netty-shaded from 1.57.2 to 1.63.0 (druid)

2024-04-05 Thread via GitHub
dependabot[bot] opened a new pull request, #16243: URL: https://github.com/apache/druid/pull/16243 Bumps [io.grpc:grpc-netty-shaded](https://github.com/grpc/grpc-java) from 1.57.2 to 1.63.0. Release notes Sourced from

(druid) branch dependabot/maven/io.grpc-grpc-netty-shaded-1.63.0 created (now 46a6c5235be)

2024-04-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/io.grpc-grpc-netty-shaded-1.63.0 in repository https://gitbox.apache.org/repos/asf/druid.git at 46a6c5235be Bump io.grpc:grpc-netty-shaded from 1.57.2 to 1.63.0 No

Re: [PR] Bump io.grpc:grpc-netty-shaded from 1.57.2 to 1.62.2 (druid)

2024-04-05 Thread via GitHub
dependabot[bot] closed pull request #15988: Bump io.grpc:grpc-netty-shaded from 1.57.2 to 1.62.2 URL: https://github.com/apache/druid/pull/15988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump io.grpc:grpc-netty-shaded from 1.57.2 to 1.62.2 (druid)

2024-04-05 Thread via GitHub
dependabot[bot] commented on PR #15988: URL: https://github.com/apache/druid/pull/15988#issuecomment-2040834039 Superseded by #16243. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(druid) branch dependabot/maven/io.grpc-grpc-netty-shaded-1.62.2 deleted (was 56d014a02e8)

2024-04-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/io.grpc-grpc-netty-shaded-1.62.2 in repository https://gitbox.apache.org/repos/asf/druid.git was 56d014a02e8 Bump io.grpc:grpc-netty-shaded from 1.57.2 to 1.62.2 The

Re: [PR] Improve Task Monitoring and Analysis (druid)

2024-04-05 Thread via GitHub
github-advanced-security[bot] commented on code in PR #16041: URL: https://github.com/apache/druid/pull/16041#discussion_r1554264379 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/TaskContextEnricher.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the

Re: [PR] Improve worst-case performance of LIKE filters by 20x (druid)

2024-04-05 Thread via GitHub
twilliamson commented on PR #16153: URL: https://github.com/apache/druid/pull/16153#issuecomment-2040716015 This info is from 5 or 6 years back while working on stream processing systems at Facebook, but my recollection is that `re2j` had issues with UTF-8 multi-byte sequences. Not sure if

Re: [PR] Kafka with topicPattern can ignore old offsets spuriously (druid)

2024-04-05 Thread via GitHub
zachjsh commented on code in PR #16190: URL: https://github.com/apache/druid/pull/16190#discussion_r1554346513 ## extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaSeekableStreamStartSequenceNumbers.java: ## @@ -0,0 +1,158 @@ +/* + *

Re: [I] DELETE syntax for MSQ (druid)

2024-04-05 Thread via GitHub
github-actions[bot] commented on issue #14145: URL: https://github.com/apache/druid/issues/14145#issuecomment-2040807550 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

Re: [I] Deletetion of segments to delete specific data in datasource. (druid)

2024-04-05 Thread via GitHub
github-actions[bot] commented on issue #14509: URL: https://github.com/apache/druid/issues/14509#issuecomment-2040807615 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If this issue is still relevant,

Re: [I] DELETE syntax for MSQ (druid)

2024-04-05 Thread via GitHub
github-actions[bot] closed issue #14145: DELETE syntax for MSQ URL: https://github.com/apache/druid/issues/14145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Improve Task Monitoring and Analysis (druid)

2024-04-05 Thread via GitHub
kfaraz commented on code in PR #16041: URL: https://github.com/apache/druid/pull/16041#discussion_r1554523657 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/TaskContextEnricher.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation