[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7799: Web-console: update supervisors table

2019-05-29 Thread GitBox
clintropolis commented on a change in pull request #7799: Web-console: update supervisors table URL: https://github.com/apache/incubator-druid/pull/7799#discussion_r288875741 ## File path: web-console/src/views/task-view/tasks-view.tsx ## @@ -109,6 +109,22 @@ function stat

[GitHub] [incubator-druid] mcbrewster opened a new pull request #7799: Web-console: update supervisors table

2019-05-29 Thread GitBox
mcbrewster opened a new pull request #7799: Web-console: update supervisors table URL: https://github.com/apache/incubator-druid/pull/7799 https://user-images.githubusercontent.com/37322608/58613205-e49a3880-8269-11e9-8f6f-7f595e6094ef.png";> Adds new columns to show Detailed State,

[GitHub] [incubator-druid] clintropolis commented on issue #7791: Fix repeatedly expr parsing in ExpressionPostAggregation

2019-05-29 Thread GitBox
clintropolis commented on issue #7791: Fix repeatedly expr parsing in ExpressionPostAggregation URL: https://github.com/apache/incubator-druid/pull/7791#issuecomment-497210520 >BTW, I also found that the ExpressionVirtualColumn and ExpressionDimFilter don't have the repeatedly parsing patt

[GitHub] [incubator-druid] clintropolis commented on issue #7794: fix group-by v2 BufferArrayGrouper for empty multi-value dimension row

2019-05-29 Thread GitBox
clintropolis commented on issue #7794: fix group-by v2 BufferArrayGrouper for empty multi-value dimension row URL: https://github.com/apache/incubator-druid/pull/7794#issuecomment-497209707 >Would you please check the CI failure? Yeah, unfortunately the CI failure is legitimate, I'm

[GitHub] [incubator-druid] litao91 commented on issue #7791: Fix repeatedly expr parsing in ExpressionPostAggregation

2019-05-29 Thread GitBox
litao91 commented on issue #7791: Fix repeatedly expr parsing in ExpressionPostAggregation URL: https://github.com/apache/incubator-druid/pull/7791#issuecomment-497206286 > Thanks for the contribution! > > Between #7724, which in some sense was caused by needlessly parsing the expre

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation

2019-05-29 Thread GitBox
surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r288859714 ## File path: core/src/main/java/org/apache/druid/timeline/SegmentWithOvershadowedStatus.java #

[GitHub] [incubator-druid] surekhasaharan opened a new issue #7798: Use smile format instead of json for internal Druid process communication.

2019-05-29 Thread GitBox
surekhasaharan opened a new issue #7798: Use smile format instead of json for internal Druid process communication. URL: https://github.com/apache/incubator-druid/issues/7798 For internal communication between Druid processes, switching to a binary format would provide reduction in bytes t

[GitHub] [incubator-druid] jihoonson commented on issue #7794: fix group-by v2 BufferArrayGrouper for empty multi-value dimension row

2019-05-29 Thread GitBox
jihoonson commented on issue #7794: fix group-by v2 BufferArrayGrouper for empty multi-value dimension row URL: https://github.com/apache/incubator-druid/pull/7794#issuecomment-497204096 Would you please check the CI failure?

[GitHub] [incubator-druid] litao91 commented on a change in pull request #7791: Fix repeatedly expr parsing in ExpressionPostAggregation

2019-05-29 Thread GitBox
litao91 commented on a change in pull request #7791: Fix repeatedly expr parsing in ExpressionPostAggregation URL: https://github.com/apache/incubator-druid/pull/7791#discussion_r288857622 ## File path: processing/src/main/java/org/apache/druid/query/aggregation/post/ExpressionPost

[GitHub] [incubator-druid] litao91 commented on a change in pull request #7791: Fix repeatedly expr parsing in ExpressionPostAggregation

2019-05-29 Thread GitBox
litao91 commented on a change in pull request #7791: Fix repeatedly expr parsing in ExpressionPostAggregation URL: https://github.com/apache/incubator-druid/pull/7791#discussion_r288857712 ## File path: processing/src/main/java/org/apache/druid/query/aggregation/post/ExpressionPost

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation

2019-05-29 Thread GitBox
surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r288857105 ## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorRuleRu

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation

2019-05-29 Thread GitBox
surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r288857124 ## File path: server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java ###

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation

2019-05-29 Thread GitBox
surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r288857115 ## File path: server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java ###

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7797: Fix missing/wrong licenses for web console

2019-05-29 Thread GitBox
jihoonson commented on a change in pull request #7797: Fix missing/wrong licenses for web console URL: https://github.com/apache/incubator-druid/pull/7797#discussion_r288852833 ## File path: LICENSE.BINARY ## @@ -794,176 +794,170 @@ BINARY/EXTENSIONS/druid-kafka-eight BIN

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7797: Fix missing/wrong licenses for web console

2019-05-29 Thread GitBox
jihoonson commented on a change in pull request #7797: Fix missing/wrong licenses for web console URL: https://github.com/apache/incubator-druid/pull/7797#discussion_r288852846 ## File path: licenses/bin/value-equal.MIT ## @@ -1,21 +1,55 @@ -MIT License - -Copyright (c) Mi

[GitHub] [incubator-druid] gianm commented on issue #7747: Remove keepSegmentGranularity option for compaction

2019-05-29 Thread GitBox
gianm commented on issue #7747: Remove keepSegmentGranularity option for compaction URL: https://github.com/apache/incubator-druid/pull/7747#issuecomment-497195719 Thanks @jihoonson. Could you remove them from the web console too? I think that it's designed such that you could edit the li

[GitHub] [incubator-druid] jihoonson commented on issue #7747: Remove keepSegmentGranularity option for compaction

2019-05-29 Thread GitBox
jihoonson commented on issue #7747: Remove keepSegmentGranularity option for compaction URL: https://github.com/apache/incubator-druid/pull/7747#issuecomment-497194895 @gianm thanks. I also noticed that `keepSegmentGranularity` remained in other places. Removed them except web-console. -

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7747: Remove keepSegmentGranularity option for compaction

2019-05-29 Thread GitBox
jihoonson commented on a change in pull request #7747: Remove keepSegmentGranularity option for compaction URL: https://github.com/apache/incubator-druid/pull/7747#discussion_r288851280 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTa

[GitHub] [incubator-druid] gianm commented on a change in pull request #7797: Fix missing/wrong licenses for web console

2019-05-29 Thread GitBox
gianm commented on a change in pull request #7797: Fix missing/wrong licenses for web console URL: https://github.com/apache/incubator-druid/pull/7797#discussion_r288850701 ## File path: licenses/bin/toggle-selection.MIT ## @@ -0,0 +1,18 @@ +# Toggle Selection Review co

[GitHub] [incubator-druid] gianm commented on a change in pull request #7797: Fix missing/wrong licenses for web console

2019-05-29 Thread GitBox
gianm commented on a change in pull request #7797: Fix missing/wrong licenses for web console URL: https://github.com/apache/incubator-druid/pull/7797#discussion_r288850679 ## File path: licenses/bin/value-equal.MIT ## @@ -1,21 +1,55 @@ -MIT License - -Copyright (c) Michae

[GitHub] [incubator-druid] gianm commented on a change in pull request #7797: Fix missing/wrong licenses for web console

2019-05-29 Thread GitBox
gianm commented on a change in pull request #7797: Fix missing/wrong licenses for web console URL: https://github.com/apache/incubator-druid/pull/7797#discussion_r288850626 ## File path: LICENSE.BINARY ## @@ -794,176 +794,170 @@ BINARY/EXTENSIONS/druid-kafka-eight BINARY/

[GitHub] [incubator-druid] jihoonson opened a new pull request #7797: Fix missing/wrong licenses for web console

2019-05-29 Thread GitBox
jihoonson opened a new pull request #7797: Fix missing/wrong licenses for web console URL: https://github.com/apache/incubator-druid/pull/7797 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-druid] jihoonson closed pull request #7795: Fix missing/wrong license

2019-05-29 Thread GitBox
jihoonson closed pull request #7795: Fix missing/wrong license URL: https://github.com/apache/incubator-druid/pull/7795 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7795: Fix missing/wrong license

2019-05-29 Thread GitBox
jihoonson commented on a change in pull request #7795: Fix missing/wrong license URL: https://github.com/apache/incubator-druid/pull/7795#discussion_r288847794 ## File path: LICENSE.BINARY ## @@ -794,176 +794,170 @@ BINARY/EXTENSIONS/druid-kafka-eight BINARY/WEB-CONSOLE T

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7795: Fix missing/wrong license

2019-05-29 Thread GitBox
jihoonson commented on a change in pull request #7795: Fix missing/wrong license URL: https://github.com/apache/incubator-druid/pull/7795#discussion_r288847577 ## File path: LICENSE.BINARY ## @@ -272,7 +272,7 @@ BINARY/WEB-CONSOLE This product bundles diff-match-patc

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7795: Fix missing/wrong license

2019-05-29 Thread GitBox
jihoonson commented on a change in pull request #7795: Fix missing/wrong license URL: https://github.com/apache/incubator-druid/pull/7795#discussion_r288847282 ## File path: licenses/bin/ua-parser-js.MIT ## @@ -1,6 +1,6 @@ MIT License -Copyright (c) 2012-2018 Faisal Salm

[GitHub] [incubator-druid] gianm opened a new pull request #7796: SQL: Use SegmentId instead of DataSegment as set/map keys.

2019-05-29 Thread GitBox
gianm opened a new pull request #7796: SQL: Use SegmentId instead of DataSegment as set/map keys. URL: https://github.com/apache/incubator-druid/pull/7796 Recently we've been talking about using SegmentIds as map keys rather than DataSegments, because its sense of equality is more well-d

[GitHub] [incubator-druid] gianm commented on issue #7793: Enable SQL by default

2019-05-29 Thread GitBox
gianm commented on issue #7793: Enable SQL by default URL: https://github.com/apache/incubator-druid/issues/7793#issuecomment-497177980 I think the only real downside is that there will be slightly more load on historicals (due to extra metadata queries) and memory use on the broker will

[GitHub] [incubator-druid] lml2468 commented on a change in pull request #7792: Fix wrong order when ordering by string first/last agg with GroupBy V2

2019-05-29 Thread GitBox
lml2468 commented on a change in pull request #7792: Fix wrong order when ordering by string first/last agg with GroupBy V2 URL: https://github.com/apache/incubator-druid/pull/7792#discussion_r288814120 ## File path: processing/src/main/java/org/apache/druid/query/groupby/orderby/D

[GitHub] [incubator-druid] gianm commented on a change in pull request #7795: Fix missing/wrong license

2019-05-29 Thread GitBox
gianm commented on a change in pull request #7795: Fix missing/wrong license URL: https://github.com/apache/incubator-druid/pull/7795#discussion_r288826140 ## File path: LICENSE.BINARY ## @@ -272,7 +272,7 @@ BINARY/WEB-CONSOLE This product bundles diff-match-patch ve

[GitHub] [incubator-druid] gianm commented on a change in pull request #7795: Fix missing/wrong license

2019-05-29 Thread GitBox
gianm commented on a change in pull request #7795: Fix missing/wrong license URL: https://github.com/apache/incubator-druid/pull/7795#discussion_r288826416 ## File path: LICENSE.BINARY ## @@ -794,176 +794,170 @@ BINARY/EXTENSIONS/druid-kafka-eight BINARY/WEB-CONSOLE The f

[GitHub] [incubator-druid] gianm commented on a change in pull request #7795: Fix missing/wrong license

2019-05-29 Thread GitBox
gianm commented on a change in pull request #7795: Fix missing/wrong license URL: https://github.com/apache/incubator-druid/pull/7795#discussion_r288825279 ## File path: licenses/bin/ua-parser-js.MIT ## @@ -1,6 +1,6 @@ MIT License -Copyright (c) 2012-2018 Faisal Salman <

[GitHub] [incubator-druid] jihoonson opened a new pull request #7795: Fix missing/wrong license

2019-05-29 Thread GitBox
jihoonson opened a new pull request #7795: Fix missing/wrong license URL: https://github.com/apache/incubator-druid/pull/7795 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7791: Fix repeatedly expr parsing in ExpressionPostAggregation

2019-05-29 Thread GitBox
clintropolis commented on a change in pull request #7791: Fix repeatedly expr parsing in ExpressionPostAggregation URL: https://github.com/apache/incubator-druid/pull/7791#discussion_r288820257 ## File path: processing/src/main/java/org/apache/druid/query/aggregation/post/Expressio

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7791: Fix repeatedly expr parsing in ExpressionPostAggregation

2019-05-29 Thread GitBox
clintropolis commented on a change in pull request #7791: Fix repeatedly expr parsing in ExpressionPostAggregation URL: https://github.com/apache/incubator-druid/pull/7791#discussion_r288817723 ## File path: processing/src/main/java/org/apache/druid/query/aggregation/post/Expressio

[GitHub] [incubator-druid] gianm commented on a change in pull request #7747: Remove keepSegmentGranularity option for compaction

2019-05-29 Thread GitBox
gianm commented on a change in pull request #7747: Remove keepSegmentGranularity option for compaction URL: https://github.com/apache/incubator-druid/pull/7747#discussion_r288814604 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.j

[GitHub] [incubator-druid] lml2468 commented on a change in pull request #7792: Fix wrong order when ordering by string first/last agg with GroupBy V2

2019-05-29 Thread GitBox
lml2468 commented on a change in pull request #7792: Fix wrong order when ordering by string first/last agg with GroupBy V2 URL: https://github.com/apache/incubator-druid/pull/7792#discussion_r288814120 ## File path: processing/src/main/java/org/apache/druid/query/groupby/orderby/D

[GitHub] [incubator-druid] lml2468 commented on a change in pull request #7792: Fix wrong order when ordering by string first/last agg with GroupBy V2

2019-05-29 Thread GitBox
lml2468 commented on a change in pull request #7792: Fix wrong order when ordering by string first/last agg with GroupBy V2 URL: https://github.com/apache/incubator-druid/pull/7792#discussion_r288814120 ## File path: processing/src/main/java/org/apache/druid/query/groupby/orderby/D

[GitHub] [incubator-druid] lml2468 commented on a change in pull request #7792: Fix wrong order when ordering by string first/last agg with GroupBy V2

2019-05-29 Thread GitBox
lml2468 commented on a change in pull request #7792: Fix wrong order when ordering by string first/last agg with GroupBy V2 URL: https://github.com/apache/incubator-druid/pull/7792#discussion_r288814120 ## File path: processing/src/main/java/org/apache/druid/query/groupby/orderby/D

[GitHub] [incubator-druid] clintropolis opened a new pull request #7794: fix group-by v2 BufferArrayGrouper for empty multi-value dimension row

2019-05-29 Thread GitBox
clintropolis opened a new pull request #7794: fix group-by v2 BufferArrayGrouper for empty multi-value dimension row URL: https://github.com/apache/incubator-druid/pull/7794 This PR fixes an 'off by 1' issue in `BufferArrayGrouper` for the scenario that when faced with multi-value dimensio

[GitHub] [incubator-druid] jon-wei commented on issue #7653: Refactor SQLMetadataSegmentManager; Change contract of REST methods in DataSourcesResource

2019-05-29 Thread GitBox
jon-wei commented on issue #7653: Refactor SQLMetadataSegmentManager; Change contract of REST methods in DataSourcesResource URL: https://github.com/apache/incubator-druid/pull/7653#issuecomment-497146866 Reviewed the REST API changes in DataSourcesResource and MetadataResource, those LGTM

[GitHub] [incubator-druid] clintropolis merged pull request #7787: Web-console: Add run keyboard short cut to sql-control

2019-05-29 Thread GitBox
clintropolis merged pull request #7787: Web-console: Add run keyboard short cut to sql-control URL: https://github.com/apache/incubator-druid/pull/7787 This is an automated message from the Apache Git Service. To respond to

[incubator-druid] branch master updated: Web-console: Add run keyboard short cut to sql-control (#7787)

2019-05-29 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 245eded Web-console: Add run keyboard

[GitHub] [incubator-druid] pdeva commented on issue #7762: Regression: Coordinator startup fails with exception

2019-05-29 Thread GitBox
pdeva commented on issue #7762: Regression: Coordinator startup fails with exception URL: https://github.com/apache/incubator-druid/issues/7762#issuecomment-497140192 i see. confirming that fix does work and coordinator starts up

[GitHub] [incubator-druid] vogievetsky commented on issue #7793: Enable SQL by default

2019-05-29 Thread GitBox
vogievetsky commented on issue #7793: Enable SQL by default URL: https://github.com/apache/incubator-druid/issues/7793#issuecomment-497139785 It should also be noted that the new web console heavily relies on SQL and while the functionality is there to make it work without SQL having SQL e

[GitHub] [incubator-druid] clintropolis closed issue #7628: 0.14.2-incubating release notes

2019-05-29 Thread GitBox
clintropolis closed issue #7628: 0.14.2-incubating release notes URL: https://github.com/apache/incubator-druid/issues/7628 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-druid] jon-wei commented on issue #7652: Response code for DataSourcesResource on non-existent dataSource or segmentId

2019-05-29 Thread GitBox
jon-wei commented on issue #7652: Response code for DataSourcesResource on non-existent dataSource or segmentId URL: https://github.com/apache/incubator-druid/issues/7652#issuecomment-497133193 From my reading of https://tools.ietf.org/html/rfc7231#section-6.3.5 and https://tools.ietf.org

[GitHub] [incubator-druid] yurmix opened a new issue #7793: Enable SQL by default

2019-05-29 Thread GitBox
yurmix opened a new issue #7793: Enable SQL by default URL: https://github.com/apache/incubator-druid/issues/7793 ### Description Is there a reason (configuration, performance, security) that Druid SQL is disabled by default? I think that since SQL is no longer considered expe

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #6702: Add SelfDiscoveryResource; rename org.apache.druid.discovery.NodeType to NodeRole

2019-05-29 Thread GitBox
jon-wei commented on a change in pull request #6702: Add SelfDiscoveryResource; rename org.apache.druid.discovery.NodeType to NodeRole URL: https://github.com/apache/incubator-druid/pull/6702#discussion_r288785786 ## File path: server/src/main/java/org/apache/druid/server/http/Self

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #6702: Add SelfDiscoveryResource; rename org.apache.druid.discovery.NodeType to NodeRole

2019-05-29 Thread GitBox
jon-wei commented on a change in pull request #6702: Add SelfDiscoveryResource; rename org.apache.druid.discovery.NodeType to NodeRole URL: https://github.com/apache/incubator-druid/pull/6702#discussion_r288782124 ## File path: server/src/main/java/org/apache/druid/server/http/Self

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7595: Optimize overshadowed segments computation

2019-05-29 Thread GitBox
jon-wei commented on a change in pull request #7595: Optimize overshadowed segments computation URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r288771515 ## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorRuleRunner.ja

[GitHub] [incubator-druid] esevastyanov commented on issue #7789: Druid basic authentication class composition config

2019-05-29 Thread GitBox
esevastyanov commented on issue #7789: Druid basic authentication class composition config URL: https://github.com/apache/incubator-druid/pull/7789#issuecomment-497101774 Hmmm, integration tests failed so I believe sometimes null is expected

svn commit: r34316 - in /release/incubator/druid: 0.14.0-incubating/ 0.14.1-incubating/

2019-05-29 Thread cwylie
Author: cwylie Date: Wed May 29 20:18:10 2019 New Revision: 34316 Log: remove old releases from mirrors Removed: release/incubator/druid/0.14.0-incubating/ release/incubator/druid/0.14.1-incubating/ - To unsubscribe, e-

[incubator-druid-website] branch asf-site updated (ce5f4b5 -> 915ecec)

2019-05-29 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-druid-website.git. from ce5f4b5 Merge pull request #5 from apache/0.14.1-downloads add 16f4b56 0.14.2 download link

[incubator-druid-website] 01/01: Merge pull request #6 from apache/0.14.2-downloads

2019-05-29 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-druid-website.git commit 915ecec1b965c338146163c171cbbbcf88f3dcf1 Merge: ce5f4b5 ed7dadf Author: Clint Wylie AuthorDate: Wed M

[GitHub] [incubator-druid-website] clintropolis merged pull request #6: 0.14.2 download link, change older releases to use archive links

2019-05-29 Thread GitBox
clintropolis merged pull request #6: 0.14.2 download link, change older releases to use archive links URL: https://github.com/apache/incubator-druid-website/pull/6 This is an automated message from the Apache Git Service. To

[incubator-druid-website] branch 0.14.2-downloads deleted (was ed7dadf)

2019-05-29 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch 0.14.2-downloads in repository https://gitbox.apache.org/repos/asf/incubator-druid-website.git. was ed7dadf other The revisions that were on this branch are still contained in other refere

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation

2019-05-29 Thread GitBox
surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r288734333 ## File path: core/src/main/java/org/apache/druid/timeline/SegmentWithOvershadowedStatus.java #

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation

2019-05-29 Thread GitBox
surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r288732586 ## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorRuleRu

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation

2019-05-29 Thread GitBox
surekhasaharan commented on a change in pull request #7595: Optimize overshadowed segments computation URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r288731372 ## File path: server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java ###

[GitHub] [incubator-druid] gianm commented on issue #7787: Web-console: Add run keyboard short cut to sql-control

2019-05-29 Thread GitBox
gianm commented on issue #7787: Web-console: Add run keyboard short cut to sql-control URL: https://github.com/apache/incubator-druid/pull/7787#issuecomment-497072113 > Ok, that makes sense. Also could you please not force push as much. It is totally ok to just add a bunch of small commits

[GitHub] [incubator-druid] gianm commented on issue #7762: Regression: Coordinator startup fails with exception

2019-05-29 Thread GitBox
gianm commented on issue #7762: Regression: Coordinator startup fails with exception URL: https://github.com/apache/incubator-druid/issues/7762#issuecomment-497071559 They aren't supposed to match. This is an automated messa

[GitHub] [incubator-druid] gianm commented on a change in pull request #7792: Fix wrong order when ordering by string first/last agg with GroupBy V2

2019-05-29 Thread GitBox
gianm commented on a change in pull request #7792: Fix wrong order when ordering by string first/last agg with GroupBy V2 URL: https://github.com/apache/incubator-druid/pull/7792#discussion_r288725592 ## File path: processing/src/main/java/org/apache/druid/query/groupby/orderby/Def

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #7789: Druid basic authentication class composition config

2019-05-29 Thread GitBox
esevastyanov commented on a change in pull request #7789: Druid basic authentication class composition config URL: https://github.com/apache/incubator-druid/pull/7789#discussion_r288721804 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/ba

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #7789: Druid basic authentication class composition config

2019-05-29 Thread GitBox
esevastyanov commented on a change in pull request #7789: Druid basic authentication class composition config URL: https://github.com/apache/incubator-druid/pull/7789#discussion_r288721307 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/ba

[GitHub] [incubator-druid] gianm commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status

2019-05-29 Thread GitBox
gianm commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status URL: https://github.com/apache/incubator-druid/issues/7571#issuecomment-497059869 > "Yes" for several reasons: 1) Liskov substitution principle 2) overshadowed is not "metadata" because

[GitHub] [incubator-druid] gianm merged pull request #7738: Fix some problems reported by PVS-Studio

2019-05-29 Thread GitBox
gianm merged pull request #7738: Fix some problems reported by PVS-Studio URL: https://github.com/apache/incubator-druid/pull/7738 This is an automated message from the Apache Git Service. To respond to the message, please lo

[incubator-druid] branch master updated: Fix some problems reported by PVS-Studio (#7738)

2019-05-29 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 782863e Fix some problems reported by PV

[GitHub] [incubator-druid] leventov commented on a change in pull request #7595: Optimize overshadowed segments computation

2019-05-29 Thread GitBox
leventov commented on a change in pull request #7595: Optimize overshadowed segments computation URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r288704576 ## File path: server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java ## @

[GitHub] [incubator-druid] leventov commented on a change in pull request #7595: Optimize overshadowed segments computation

2019-05-29 Thread GitBox
leventov commented on a change in pull request #7595: Optimize overshadowed segments computation URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r288704366 ## File path: server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java ## @

[GitHub] [incubator-druid] leventov commented on a change in pull request #7789: Druid basic authentication class composition config

2019-05-29 Thread GitBox
leventov commented on a change in pull request #7789: Druid basic authentication class composition config URL: https://github.com/apache/incubator-druid/pull/7789#discussion_r288702717 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/

[GitHub] [incubator-druid] leventov commented on a change in pull request #7789: Druid basic authentication class composition config

2019-05-29 Thread GitBox
leventov commented on a change in pull request #7789: Druid basic authentication class composition config URL: https://github.com/apache/incubator-druid/pull/7789#discussion_r288702717 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #7789: Druid basic authentication class composition config

2019-05-29 Thread GitBox
esevastyanov commented on a change in pull request #7789: Druid basic authentication class composition config URL: https://github.com/apache/incubator-druid/pull/7789#discussion_r288696632 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/ba

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #7789: Druid basic authentication class composition config

2019-05-29 Thread GitBox
esevastyanov commented on a change in pull request #7789: Druid basic authentication class composition config URL: https://github.com/apache/incubator-druid/pull/7789#discussion_r288693182 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/ba

[GitHub] [incubator-druid] leventov commented on a change in pull request #7595: Optimize overshadowed segments computation

2019-05-29 Thread GitBox
leventov commented on a change in pull request #7595: Optimize overshadowed segments computation URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r288672814 ## File path: core/src/main/java/org/apache/druid/timeline/SegmentWithOvershadowedStatus.java ##

[GitHub] [incubator-druid] leventov commented on a change in pull request #7789: Druid basic authentication class composition config

2019-05-29 Thread GitBox
leventov commented on a change in pull request #7789: Druid basic authentication class composition config URL: https://github.com/apache/incubator-druid/pull/7789#discussion_r288671103 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/

[GitHub] [incubator-druid] leventov commented on a change in pull request #7789: Druid basic authentication class composition config

2019-05-29 Thread GitBox
leventov commented on a change in pull request #7789: Druid basic authentication class composition config URL: https://github.com/apache/incubator-druid/pull/7789#discussion_r288670045 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/

[GitHub] [incubator-druid] leventov commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status

2019-05-29 Thread GitBox
leventov commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status URL: https://github.com/apache/incubator-druid/issues/7571#issuecomment-497019287 > I think the cleanest way to deal with this concern is to keep SegmentWithOvershadowedStatus as a wr

[GitHub] [incubator-druid] leventov commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status

2019-05-29 Thread GitBox
leventov commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status URL: https://github.com/apache/incubator-druid/issues/7571#issuecomment-497018916 There can be a separate method `allDataAndOvershadowedStatusEquals()` in `SegmentWithOvershadowedStat

[GitHub] [incubator-druid] leventov commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status

2019-05-29 Thread GitBox
leventov commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status URL: https://github.com/apache/incubator-druid/issues/7571#issuecomment-497018429 > should it consider a DataSegment instance and a SegmentWithOvershadowedStatus instance as equal or

[incubator-druid] branch master updated: bump deps (#7788)

2019-05-29 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new b051d66 bump deps (#7788) b051d66 is desc

[GitHub] [incubator-druid] fjy merged pull request #7788: Web console: bump dependancies

2019-05-29 Thread GitBox
fjy merged pull request #7788: Web console: bump dependancies URL: https://github.com/apache/incubator-druid/pull/7788 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-druid] lml2468 opened a new pull request #7792: Fix wrong order when ordering by string first/last agg with GroupBy V2

2019-05-29 Thread GitBox
lml2468 opened a new pull request #7792: Fix wrong order when ordering by string first/last agg with GroupBy V2 URL: https://github.com/apache/incubator-druid/pull/7792 Resolves #7691 This is an automated message from the Ap

[GitHub] [incubator-druid] OItsMAK commented on issue #7778: How can we do health checks on Druid processes?

2019-05-29 Thread GitBox
OItsMAK commented on issue #7778: How can we do health checks on Druid processes? URL: https://github.com/apache/incubator-druid/issues/7778#issuecomment-496962324 Will set it up. thanks. Btw, What I found to do the job for me is: * `/status/health` for Coordinator, Overlords

[GitHub] [incubator-druid] OItsMAK closed issue #7778: How can we do health checks on Druid processes?

2019-05-29 Thread GitBox
OItsMAK closed issue #7778: How can we do health checks on Druid processes? URL: https://github.com/apache/incubator-druid/issues/7778 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-druid] litao91 opened a new pull request #7791: Fix repeatedly expr parsing in ExpressionPostAggregation

2019-05-29 Thread GitBox
litao91 opened a new pull request #7791: Fix repeatedly expr parsing in ExpressionPostAggregation URL: https://github.com/apache/incubator-druid/pull/7791 Change-Id: Ib739fb1cbc460afeb59a255f635305441dc6997b Fix: #7790 1. Pass the `parsed`, and `dependentFields` while calling `E

[GitHub] [incubator-druid] litao91 opened a new issue #7790: Repeatedly parsing expression in ExpressionPostAggregator wastes a lot of CPU time and potentially hits performance

2019-05-29 Thread GitBox
litao91 opened a new issue #7790: Repeatedly parsing expression in ExpressionPostAggregator wastes a lot of CPU time and potentially hits performance URL: https://github.com/apache/incubator-druid/issues/7790 ### Affected Version 0.10, after `ExpressionPostAggregator` being introduc

[GitHub] [incubator-druid] esevastyanov opened a new pull request #7789: Druid basic authentication class composition config

2019-05-29 Thread GitBox
esevastyanov opened a new pull request #7789: Druid basic authentication class composition config URL: https://github.com/apache/incubator-druid/pull/7789 The config is an option to specify classes of user/role managers, caches and notifiers. If a config field is specified then the corr

[GitHub] [incubator-druid] pdeva commented on issue #7762: Regression: Coordinator startup fails with exception

2019-05-29 Thread GitBox
pdeva commented on issue #7762: Regression: Coordinator startup fails with exception URL: https://github.com/apache/incubator-druid/issues/7762#issuecomment-496820936 so something weird is happening with version numbers. in installed imply 2.9.11 but i see version numbers everywhere as

[GitHub] [incubator-druid] vogievetsky commented on issue #7762: Regression: Coordinator startup fails with exception

2019-05-29 Thread GitBox
vogievetsky commented on issue #7762: Regression: Coordinator startup fails with exception URL: https://github.com/apache/incubator-druid/issues/7762#issuecomment-496820256 Note: this is fixed as part of 0.14.0-iap12 This is

[GitHub] [incubator-druid] leventov commented on a change in pull request #7738: Fix some problems reported by PVS-Studio

2019-05-29 Thread GitBox
leventov commented on a change in pull request #7738: Fix some problems reported by PVS-Studio URL: https://github.com/apache/incubator-druid/pull/7738#discussion_r288427816 ## File path: extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleDataSegm

[GitHub] [incubator-druid] leventov commented on a change in pull request #7738: Fix some problems reported by PVS-Studio

2019-05-29 Thread GitBox
leventov commented on a change in pull request #7738: Fix some problems reported by PVS-Studio URL: https://github.com/apache/incubator-druid/pull/7738#discussion_r288427729 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authenticat

[GitHub] [incubator-druid] leventov commented on a change in pull request #7738: Fix some problems reported by PVS-Studio

2019-05-29 Thread GitBox
leventov commented on a change in pull request #7738: Fix some problems reported by PVS-Studio URL: https://github.com/apache/incubator-druid/pull/7738#discussion_r288427521 ## File path: extensions-core/google-extensions/src/main/java/org/apache/druid/storage/google/GoogleDataSegm

[GitHub] [incubator-druid] leventov commented on a change in pull request #7738: Fix some problems reported by PVS-Studio

2019-05-29 Thread GitBox
leventov commented on a change in pull request #7738: Fix some problems reported by PVS-Studio URL: https://github.com/apache/incubator-druid/pull/7738#discussion_r288427369 ## File path: extensions-core/histogram/src/main/java/org/apache/druid/query/aggregation/histogram/Approxima

[GitHub] [incubator-druid] leventov commented on a change in pull request #7738: Fix some problems reported by PVS-Studio

2019-05-29 Thread GitBox
leventov commented on a change in pull request #7738: Fix some problems reported by PVS-Studio URL: https://github.com/apache/incubator-druid/pull/7738#discussion_r288427334 ## File path: integration-tests/src/main/java/org/apache/druid/testing/clients/CoordinatorResourceTestClient

[GitHub] [incubator-druid] vogievetsky commented on issue #7787: Web-console: Add run keyboard short cut to sql-control

2019-05-29 Thread GitBox
vogievetsky commented on issue #7787: Web-console: Add run keyboard short cut to sql-control URL: https://github.com/apache/incubator-druid/pull/7787#issuecomment-496812602 YES! Awesome. 👍 This is an automated message from t

[GitHub] [incubator-druid] leventov commented on a change in pull request #7653: Refactor SQLMetadataSegmentManager; Change contract of REST methods in DataSourcesResource

2019-05-29 Thread GitBox
leventov commented on a change in pull request #7653: Refactor SQLMetadataSegmentManager; Change contract of REST methods in DataSourcesResource URL: https://github.com/apache/incubator-druid/pull/7653#discussion_r288418726 ## File path: server/src/main/java/org/apache/druid/metad

[GitHub] [incubator-druid] leventov commented on a change in pull request #7653: Refactor SQLMetadataSegmentManager; Change contract of REST methods in DataSourcesResource

2019-05-29 Thread GitBox
leventov commented on a change in pull request #7653: Refactor SQLMetadataSegmentManager; Change contract of REST methods in DataSourcesResource URL: https://github.com/apache/incubator-druid/pull/7653#discussion_r288418745 ## File path: server/src/main/java/org/apache/druid/metad

[GitHub] [incubator-druid] leventov commented on a change in pull request #7653: Refactor SQLMetadataSegmentManager; Change contract of REST methods in DataSourcesResource

2019-05-29 Thread GitBox
leventov commented on a change in pull request #7653: Refactor SQLMetadataSegmentManager; Change contract of REST methods in DataSourcesResource URL: https://github.com/apache/incubator-druid/pull/7653#discussion_r288418766 ## File path: docs/content/operations/api-reference.md ##