[GitHub] gaodayue opened a new pull request #6242: fix incorrect check of maxSemiJoinRowsInMemory

2018-08-26 Thread GitBox
gaodayue opened a new pull request #6242: fix incorrect check of maxSemiJoinRowsInMemory URL: https://github.com/apache/incubator-druid/pull/6242 We should check maxSemiJoinRowsInMemory on right table's output rows count instead of number of values inside one row. Added a test case

[GitHub] gaodayue opened a new issue #6243: semi join query throws AssertionError

2018-08-26 Thread GitBox
gaodayue opened a new issue #6243: semi join query throws AssertionError URL: https://github.com/apache/incubator-druid/issues/6243 Example query: ```sql SELECT COUNT(*) FROM ( SELECT DISTINCT dim2 FROM druid.foo WHERE SUBSTRING(dim2, 1, 1) IN ( SELECT

[GitHub] gaodayue opened a new pull request #6244: fix AssertionError of semi join query

2018-08-26 Thread GitBox
gaodayue opened a new pull request #6244: fix AssertionError of semi join query URL: https://github.com/apache/incubator-druid/pull/6244 Fixed #6243 This is an automated message from the Apache Git Service. To respond to the

[GitHub] fjy closed pull request #6191: SQL: Support more result formats, add columns header.

2018-08-26 Thread GitBox
fjy closed pull request #6191: SQL: Support more result formats, add columns header. URL: https://github.com/apache/incubator-druid/pull/6191 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] fjy closed pull request #6240: [Backport] SQL: Fix precision of TIMESTAMP types.

2018-08-26 Thread GitBox
fjy closed pull request #6240: [Backport] SQL: Fix precision of TIMESTAMP types. URL: https://github.com/apache/incubator-druid/pull/6240 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] gianm commented on issue #6206: Fix NPE in KafkaSupervisor.checkpointTaskGroup

2018-08-26 Thread GitBox
gianm commented on issue #6206: Fix NPE in KafkaSupervisor.checkpointTaskGroup URL: https://github.com/apache/incubator-druid/pull/6206#issuecomment-416115263 @jihoonson Got it, could you please merge master into this branch in order to get that?

[GitHub] gianm closed issue #6021: NPE in KafkaSupervisor.checkpointTaskGroup

2018-08-26 Thread GitBox
gianm closed issue #6021: NPE in KafkaSupervisor.checkpointTaskGroup URL: https://github.com/apache/incubator-druid/issues/6021 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] gianm closed pull request #6206: Fix NPE in KafkaSupervisor.checkpointTaskGroup

2018-08-26 Thread GitBox
gianm closed pull request #6206: Fix NPE in KafkaSupervisor.checkpointTaskGroup URL: https://github.com/apache/incubator-druid/pull/6206 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] gianm opened a new pull request #6245: [Backport] Fix NPE in KafkaSupervisor.checkpointTaskGroup

2018-08-26 Thread GitBox
gianm opened a new pull request #6245: [Backport] Fix NPE in KafkaSupervisor.checkpointTaskGroup URL: https://github.com/apache/incubator-druid/pull/6245 Backport of #6206 to 0.12.3. This is an automated message from the

[GitHub] fjy closed pull request #6229: [Backport] SQL: Finalize aggregations for inner queries when necessary.

2018-08-26 Thread GitBox
fjy closed pull request #6229: [Backport] SQL: Finalize aggregations for inner queries when necessary. URL: https://github.com/apache/incubator-druid/pull/6229 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] fjy closed pull request #6236: Fix all inspection errors currently reported.

2018-08-26 Thread GitBox
fjy closed pull request #6236: Fix all inspection errors currently reported. URL: https://github.com/apache/incubator-druid/pull/6236 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] gianm commented on issue #6206: Fix NPE in KafkaSupervisor.checkpointTaskGroup

2018-08-26 Thread GitBox
gianm commented on issue #6206: Fix NPE in KafkaSupervisor.checkpointTaskGroup URL: https://github.com/apache/incubator-druid/pull/6206#issuecomment-416085168 Merged master into this branch to get the fixes from #6236. Let's see how this goes.

[GitHub] fjy closed pull request #6228: [Backport] Support projection after sorting in SQL

2018-08-26 Thread GitBox
fjy closed pull request #6228: [Backport] Support projection after sorting in SQL URL: https://github.com/apache/incubator-druid/pull/6228 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] fjy closed pull request #6230: [Backport] Fix four bugs with numeric dimension output types.

2018-08-26 Thread GitBox
fjy closed pull request #6230: [Backport] Fix four bugs with numeric dimension output types. URL: https://github.com/apache/incubator-druid/pull/6230 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] gianm commented on issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
gianm commented on issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255#issuecomment-416616545 Great catch! Btw, I think you meant to link to #4704 instead of #4707.

[GitHub] gianm commented on a change in pull request #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
gianm commented on a change in pull request #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#discussion_r213366682 ## File path: extensions-contrib/opentsdb-emitter/src/main/java/io/druid/emitter/opentsdb/OpentsdbSender.java

[GitHub] gaodayue commented on issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
gaodayue commented on issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255#issuecomment-416583814 In order to find out which class puts too much pressure on garbage collector, I captured flight record (60s) before and after

[GitHub] gaodayue opened a new pull request #6256: RowBasedKeySerde should use empty dictionary in constructor

2018-08-28 Thread GitBox
gaodayue opened a new pull request #6256: RowBasedKeySerde should use empty dictionary in constructor URL: https://github.com/apache/incubator-druid/pull/6256 Fixes #6255 This is an automated message from the Apache Git

[GitHub] gianm commented on issue #6253: Multiple datasources with multiple topic in one spec file

2018-08-28 Thread GitBox
gianm commented on issue #6253: Multiple datasources with multiple topic in one spec file URL: https://github.com/apache/incubator-druid/issues/6253#issuecomment-416635332 Hi @Harish346, currently the model is 1 supervisor and 1 set of tasks per datasource.

[GitHub] QiuMM commented on a change in pull request #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
QiuMM commented on a change in pull request #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#discussion_r213365894 ## File path: extensions-contrib/opentsdb-emitter/src/main/java/io/druid/emitter/opentsdb/OpentsdbSender.java

[GitHub] QiuMM commented on issue #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
QiuMM commented on issue #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#issuecomment-416634103 It have been solved in #6251 . This is an automated message from the

[GitHub] QiuMM commented on a change in pull request #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
QiuMM commented on a change in pull request #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#discussion_r213372654 ## File path: extensions-contrib/opentsdb-emitter/src/main/java/io/druid/emitter/opentsdb/OpentsdbSender.java

[GitHub] himanshug commented on issue #6219: Add optional `name` to top level of FilteredAggregatorFactory

2018-08-28 Thread GitBox
himanshug commented on issue #6219: Add optional `name` to top level of FilteredAggregatorFactory URL: https://github.com/apache/incubator-druid/pull/6219#issuecomment-416659072 @drcrallen I added the `compatibility` label to this PR for the catch that you

[GitHub] jihoonson commented on issue #6124: KafkaIndexTask can delete published segments on restart

2018-08-28 Thread GitBox
jihoonson commented on issue #6124: KafkaIndexTask can delete published segments on restart URL: https://github.com/apache/incubator-druid/issues/6124#issuecomment-416669984 @gianm I think it makes sense to close this issue since the title is about kafka tasks deleting pushed segments.

[GitHub] himanshug commented on issue #6212: fix TaskQueue-HRTR deadlock

2018-08-28 Thread GitBox
himanshug commented on issue #6212: fix TaskQueue-HRTR deadlock URL: https://github.com/apache/incubator-druid/pull/6212#issuecomment-416659850 @gianm sure, thanks. This is an automated message from the Apache Git Service. To

[GitHub] himanshug closed issue #2406: [proposal]datasketches lib based quantiles/histogram support in druid

2018-08-28 Thread GitBox
himanshug closed issue #2406: [proposal]datasketches lib based quantiles/histogram support in druid URL: https://github.com/apache/incubator-druid/issues/2406 This is an automated message from the Apache Git Service. To

[GitHub] gianm commented on issue #6124: KafkaIndexTask can delete published segments on restart

2018-08-28 Thread GitBox
gianm commented on issue #6124: KafkaIndexTask can delete published segments on restart URL: https://github.com/apache/incubator-druid/issues/6124#issuecomment-416667501 Got it, I think we can close this then. This is an

[GitHub] himanshug commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query

2018-08-28 Thread GitBox
himanshug commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query URL: https://github.com/apache/incubator-druid/pull/5280#discussion_r213413936 ## File path: docs/content/querying/groupbyquery.md ## @@ -113,6 +114,94 @@ improve

[GitHub] himanshug commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query

2018-08-28 Thread GitBox
himanshug commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query URL: https://github.com/apache/incubator-druid/pull/5280#discussion_r213413907 ## File path: docs/content/querying/groupbyquery.md ## @@ -113,6 +114,94 @@ improve

[GitHub] gianm closed issue #6124: KafkaIndexTask can delete published segments on restart

2018-08-28 Thread GitBox
gianm closed issue #6124: KafkaIndexTask can delete published segments on restart URL: https://github.com/apache/incubator-druid/issues/6124 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jihoonson commented on issue #6256: RowBasedKeySerde should use empty dictionary in constructor

2018-08-28 Thread GitBox
jihoonson commented on issue #6256: RowBasedKeySerde should use empty dictionary in constructor URL: https://github.com/apache/incubator-druid/pull/6256#issuecomment-416668830 Hi @gaodayue, I left a comment on https://github.com/apache/incubator-druid/issues/6255.

[GitHub] jihoonson commented on issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
jihoonson commented on issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255#issuecomment-416668676 @gaodayue thank you for catching this. Could you share some more details of your use case? I wonder especially how large the

[GitHub] himanshug commented on issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
himanshug commented on issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255#issuecomment-416662430 #4704 did run the benchmarks for performance, unfortunately benchmarks don't report memory allocation or else it would be

[GitHub] QiuMM edited a comment on issue #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
QiuMM edited a comment on issue #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#issuecomment-416634103 I have opened #6251 to solve same issue. This is an automated

[GitHub] himanshug commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query

2018-08-28 Thread GitBox
himanshug commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query URL: https://github.com/apache/incubator-druid/pull/5280#discussion_r213413800 ## File path: docs/content/querying/groupbyquery.md ## @@ -113,6 +114,94 @@ improve

[GitHub] himanshug commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query

2018-08-28 Thread GitBox
himanshug commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query URL: https://github.com/apache/incubator-druid/pull/5280#discussion_r213413760 ## File path: docs/content/querying/groupbyquery.md ## @@ -70,6 +70,7 @@ There are 11 main

[GitHub] b-slim commented on a change in pull request #6251: fix opentsdb emitter always be running

2018-08-28 Thread GitBox
b-slim commented on a change in pull request #6251: fix opentsdb emitter always be running URL: https://github.com/apache/incubator-druid/pull/6251#discussion_r213459729 ## File path: docs/content/development/extensions-contrib/opentsdb-emitter.md ## @@ -18,10 +18,11 @@

[GitHub] gianm opened a new pull request #6257: SQL: Fix post-aggregator naming logic for sort-project. (#6250)

2018-08-28 Thread GitBox
gianm opened a new pull request #6257: SQL: Fix post-aggregator naming logic for sort-project. (#6250) URL: https://github.com/apache/incubator-druid/pull/6257 The old code assumes that post-aggregator prefixes are one character long followed by numbers. This isn't always true (we may

[GitHub] jon-wei commented on a change in pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner

2018-08-28 Thread GitBox
jon-wei commented on a change in pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/6258#discussion_r213468683 ## File path:

[GitHub] jihoonson commented on a change in pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/6258#discussion_r213467270 ## File path:

[GitHub] jihoonson commented on a change in pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/6258#discussion_r213467072 ## File path:

[GitHub] himanshug commented on a change in pull request #5872: add method getRequiredColumns for DimFilter

2018-08-28 Thread GitBox
himanshug commented on a change in pull request #5872: add method getRequiredColumns for DimFilter URL: https://github.com/apache/incubator-druid/pull/5872#discussion_r213452493 ## File path: processing/src/main/java/io/druid/query/filter/DimFilter.java ## @@ -75,4 +77,9

[GitHub] gianm commented on issue #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
gianm commented on issue #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#issuecomment-416729102 What are the pros and cons of this approach vs. the approach in #6251? (Sorry, I haven't had a chance to study how the OpenTSDB emitter

[GitHub] jon-wei opened a new pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner

2018-08-28 Thread GitBox
jon-wei opened a new pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/6258 This is an automated message

[GitHub] himanshug commented on issue #5280: add "subtotalsSpec" attribute to groupBy query

2018-08-28 Thread GitBox
himanshug commented on issue #5280: add "subtotalsSpec" attribute to groupBy query URL: https://github.com/apache/incubator-druid/pull/5280#issuecomment-416745224 @gianm updated the docs. This is an automated message from

[GitHub] amalakar commented on issue #5150: Druid-parquet-extensions fails on timestamps (stored as INT96) in parquet files

2018-08-28 Thread GitBox
amalakar commented on issue #5150: Druid-parquet-extensions fails on timestamps (stored as INT96) in parquet files URL: https://github.com/apache/incubator-druid/issues/5150#issuecomment-416762573 @shaharck in our case we ended up converting to csv and then importing into druid, which is

[GitHub] b-slim commented on a change in pull request #6251: fix opentsdb emitter always be running

2018-08-28 Thread GitBox
b-slim commented on a change in pull request #6251: fix opentsdb emitter always be running URL: https://github.com/apache/incubator-druid/pull/6251#discussion_r213460483 ## File path: extensions-contrib/opentsdb-emitter/src/main/java/io/druid/emitter/opentsdb/OpentsdbSender.java

[GitHub] shaharck commented on issue #5150: Druid-parquet-extensions fails on timestamps (stored as INT96) in parquet files

2018-08-28 Thread GitBox
shaharck commented on issue #5150: Druid-parquet-extensions fails on timestamps (stored as INT96) in parquet files URL: https://github.com/apache/incubator-druid/issues/5150#issuecomment-416733014 is there an existing work around if you do not need that column? doesn't seem like

[GitHub] jihoonson commented on a change in pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/6258#discussion_r213473735 ## File path:

[GitHub] himanshug commented on issue #6252: Deadlock may be in TaskMaster when stopping

2018-08-28 Thread GitBox
himanshug commented on issue #6252: Deadlock may be in TaskMaster when stopping URL: https://github.com/apache/incubator-druid/issues/6252#issuecomment-416743373 did you shutdown zookeeper processes along with druid or did Overlord somehow lost connection to zookeeper ? from a quick

[GitHub] jon-wei closed pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner

2018-08-28 Thread GitBox
jon-wei closed pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/6258 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213460949 ## File path:

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213503720 ## File path:

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213495920 ## File path:

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213461237 ## File path:

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213156930 ## File path:

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213502966 ## File path:

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213499301 ## File path:

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213502018 ## File path:

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213484372 ## File path:

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213490673 ## File path:

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213496363 ## File path:

[GitHub] jon-wei opened a new pull request #6260: [Backport] Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner

2018-08-28 Thread GitBox
jon-wei opened a new pull request #6260: [Backport] Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/6260 Backport of #6258 to 0.12.3

[GitHub] gianm closed pull request #5280: add "subtotalsSpec" attribute to groupBy query

2018-08-28 Thread GitBox
gianm closed pull request #5280: add "subtotalsSpec" attribute to groupBy query URL: https://github.com/apache/incubator-druid/pull/5280 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] gianm closed issue #5179: [Proposal] Add support for multiple grouping specs in groupBy query

2018-08-28 Thread GitBox
gianm closed issue #5179: [Proposal] Add support for multiple grouping specs in groupBy query URL: https://github.com/apache/incubator-druid/issues/5179 This is an automated message from the Apache Git Service. To respond

[GitHub] jihoonson closed pull request #6261: [Backport] RowBasedKeySerde should use empty dictionary in constructor

2018-08-28 Thread GitBox
jihoonson closed pull request #6261: [Backport] RowBasedKeySerde should use empty dictionary in constructor URL: https://github.com/apache/incubator-druid/pull/6261 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213502827 ## File path:

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213474326 ## File path:

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213156952 ## File path:

[GitHub] gianm commented on issue #6257: [Backport] SQL: Fix post-aggregator naming logic for sort-project.

2018-08-28 Thread GitBox
gianm commented on issue #6257: [Backport] SQL: Fix post-aggregator naming logic for sort-project. URL: https://github.com/apache/incubator-druid/pull/6257#issuecomment-416780459 Had to fix a test-- repushed. This is an

[GitHub] gianm opened a new pull request #6261: [Backport] RowBasedKeySerde should use empty dictionary in constructor

2018-08-28 Thread GitBox
gianm opened a new pull request #6261: [Backport] RowBasedKeySerde should use empty dictionary in constructor URL: https://github.com/apache/incubator-druid/pull/6261 Backport of #6256 to 0.12.3. This is an automated message

[GitHub] jihoonson commented on issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
jihoonson commented on issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255#issuecomment-416798810 @gaodayue thank you for the details! Probably we can optimize the initial dictionary size based on 1) spilling is enabled, 2)

[GitHub] fjy closed pull request #6260: [Backport] Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner

2018-08-28 Thread GitBox
fjy closed pull request #6260: [Backport] Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/6260 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] gaodayue commented on issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
gaodayue commented on issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255#issuecomment-416797137 > @gaodayue thank you for catching this. Could you share some more details of your use case? I wonder especially how large the

[GitHub] gaodayue commented on issue #6256: RowBasedKeySerde should use empty dictionary in constructor

2018-08-28 Thread GitBox
gaodayue commented on issue #6256: RowBasedKeySerde should use empty dictionary in constructor URL: https://github.com/apache/incubator-druid/pull/6256#issuecomment-416799333 > Could you please add a comment about why the map is starting out empty (avoiding allocating too much when it's

[GitHub] gaodayue commented on issue #6246: add a sql option to force user to specify time condition

2018-08-28 Thread GitBox
gaodayue commented on issue #6246: add a sql option to force user to specify time condition URL: https://github.com/apache/incubator-druid/pull/6246#issuecomment-416800294 Hi @gianm , could you take a look at this? This is

[GitHub] gaodayue commented on issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
gaodayue commented on issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255#issuecomment-416798257 As I mentioned above, the creation rate of merging dictionary is roughly `2 (forward and reverse dict) x processing.numThreads

[GitHub] QiuMM commented on a change in pull request #6251: fix opentsdb emitter always be running

2018-08-28 Thread GitBox
QiuMM commented on a change in pull request #6251: fix opentsdb emitter always be running URL: https://github.com/apache/incubator-druid/pull/6251#discussion_r213537407 ## File path: extensions-contrib/opentsdb-emitter/src/main/java/io/druid/emitter/opentsdb/OpentsdbSender.java

[GitHub] QiuMM commented on issue #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-29 Thread GitBox
QiuMM commented on issue #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#issuecomment-416835680 I have fixed what you mentioned @zhaojiandong. This is an automated

[GitHub] waixiaoyu commented on issue #6252: Deadlock may be in TaskMaster when stopping

2018-08-29 Thread GitBox
waixiaoyu commented on issue #6252: Deadlock may be in TaskMaster when stopping URL: https://github.com/apache/incubator-druid/issues/6252#issuecomment-416838393 @himanshug No, my zookeeper is used by other programs. So I just wanna shutdown Druid cluster, except Zookeeper.

[GitHub] QiuMM commented on a change in pull request #6251: fix opentsdb emitter always be running

2018-08-29 Thread GitBox
QiuMM commented on a change in pull request #6251: fix opentsdb emitter always be running URL: https://github.com/apache/incubator-druid/pull/6251#discussion_r213552927 ## File path: extensions-contrib/opentsdb-emitter/src/main/java/io/druid/emitter/opentsdb/OpentsdbSender.java

[GitHub] QiuMM commented on a change in pull request #6251: fix opentsdb emitter always be running

2018-08-29 Thread GitBox
QiuMM commented on a change in pull request #6251: fix opentsdb emitter always be running URL: https://github.com/apache/incubator-druid/pull/6251#discussion_r213552927 ## File path: extensions-contrib/opentsdb-emitter/src/main/java/io/druid/emitter/opentsdb/OpentsdbSender.java

[GitHub] zhaojiandong commented on a change in pull request #6251: fix opentsdb emitter always be running

2018-08-28 Thread GitBox
zhaojiandong commented on a change in pull request #6251: fix opentsdb emitter always be running URL: https://github.com/apache/incubator-druid/pull/6251#discussion_r213538511 ## File path:

[GitHub] zhaojiandong commented on issue #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
zhaojiandong commented on issue #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#issuecomment-416825059 [#6251](https://github.com/apache/incubator-druid/pull/6251/files) uses ScheduledExecutorService to schedule. But if emitter has

[GitHub] QiuMM commented on a change in pull request #6251: fix opentsdb emitter always be running

2018-08-29 Thread GitBox
QiuMM commented on a change in pull request #6251: fix opentsdb emitter always be running URL: https://github.com/apache/incubator-druid/pull/6251#discussion_r213553407 ## File path: docs/content/development/extensions-contrib/opentsdb-emitter.md ## @@ -18,10 +18,11 @@

[GitHub] ranjan321 commented on issue #6210: Csv with Header giving 'Success' but not loading any data

2018-08-29 Thread GitBox
ranjan321 commented on issue #6210: Csv with Header giving 'Success' but not loading any data URL: https://github.com/apache/incubator-druid/issues/6210#issuecomment-416881656 Still i didn't get any response .please look into this issue as it an urgency

[GitHub] gianm closed issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
gianm closed issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] gianm closed pull request #6256: RowBasedKeySerde should use empty dictionary in constructor

2018-08-28 Thread GitBox
gianm closed pull request #6256: RowBasedKeySerde should use empty dictionary in constructor URL: https://github.com/apache/incubator-druid/pull/6256 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] fjy closed pull request #6257: [Backport] SQL: Fix post-aggregator naming logic for sort-project.

2018-08-28 Thread GitBox
fjy closed pull request #6257: [Backport] SQL: Fix post-aggregator naming logic for sort-project. URL: https://github.com/apache/incubator-druid/pull/6257 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] fjy commented on issue #5938: URL encode datasources, task ids, authenticator names.

2018-08-19 Thread GitBox
fjy commented on issue #5938: URL encode datasources, task ids, authenticator names. URL: https://github.com/apache/incubator-druid/pull/5938#issuecomment-414143789 @gianm this is having a hard time passing integration tests

[GitHub] KenjiTakahashi opened a new pull request #6195: Fix running Overlord inside Coordinator

2018-08-19 Thread GitBox
KenjiTakahashi opened a new pull request #6195: Fix running Overlord inside Coordinator URL: https://github.com/apache/incubator-druid/pull/6195 Fixes #6133. This is an automated message from the Apache Git Service. To

[GitHub] gianm edited a comment on issue #5709: Broker resiliency to misbehaving historical nodes

2018-08-19 Thread GitBox
gianm edited a comment on issue #5709: Broker resiliency to misbehaving historical nodes URL: https://github.com/apache/incubator-druid/issues/5709#issuecomment-414175186 Hi @peferron, That scope sounds useful for an initial patch. I think the biggest risk is that queries that are

[GitHub] gianm commented on issue #5709: Broker resiliency to misbehaving historical nodes

2018-08-19 Thread GitBox
gianm commented on issue #5709: Broker resiliency to misbehaving historical nodes URL: https://github.com/apache/incubator-druid/issues/5709#issuecomment-414175186 Hi @peferron, That scope sounds useful for an initial patch. I think the biggest risk is that queries that are doomed

[GitHub] gianm commented on issue #6189: Lucene indexing for free form text

2018-08-19 Thread GitBox
gianm commented on issue #6189: Lucene indexing for free form text URL: https://github.com/apache/incubator-druid/issues/6189#issuecomment-414172408 Hi @RestfulBlue, it sounds like an interesting idea. Are you imagining adding a Lucene index as a companion to a Druid segment (i.e. adding

[GitHub] gianm commented on issue #6088: Scan query: time-ordering

2018-08-19 Thread GitBox
gianm commented on issue #6088: Scan query: time-ordering URL: https://github.com/apache/incubator-druid/issues/6088#issuecomment-414174269 > FYI: I'd just like to see this kept as option in the query, so ones that do no need sorting avoid the performance hit. Agreed, we should

[GitHub] gianm commented on issue #5938: URL encode datasources, task ids, authenticator names.

2018-08-19 Thread GitBox
gianm commented on issue #5938: URL encode datasources, task ids, authenticator names. URL: https://github.com/apache/incubator-druid/pull/5938#issuecomment-414175659 I wasn't sure if it was timing out (we are pretty close to the timeout) or if there was something wrong with the patch

[GitHub] leventov commented on issue #5737: Include hybrid and caffeine in cache docs and show caffeine as default

2018-08-19 Thread GitBox
leventov commented on issue #5737: Include hybrid and caffeine in cache docs and show caffeine as default URL: https://github.com/apache/incubator-druid/pull/5737#issuecomment-414162618 Related: #6161 This is an automated

[GitHub] QiuMM opened a new pull request #6193: remove duplicate link to operations/recommendations.html

2018-08-19 Thread GitBox
QiuMM opened a new pull request #6193: remove duplicate link to operations/recommendations.html URL: https://github.com/apache/incubator-druid/pull/6193 There are two item links to the operations/recommendations.html, just remove one.

[GitHub] QiuMM opened a new pull request #6194: remove unnecessary tlsPortFinder to avoid potential port conflicts

2018-08-19 Thread GitBox
QiuMM opened a new pull request #6194: remove unnecessary tlsPortFinder to avoid potential port conflicts URL: https://github.com/apache/incubator-druid/pull/6194 Fix #6190. This is an automated message from the Apache Git

[GitHub] jon-wei commented on issue #6187: [Backport] Fix three bugs with segment publishing. (#6155)

2018-08-17 Thread GitBox
jon-wei commented on issue #6187: [Backport] Fix three bugs with segment publishing. (#6155) URL: https://github.com/apache/incubator-druid/pull/6187#issuecomment-414017677 @fjy The backport was incomplete, I fixed it now

<    7   8   9   10   11   12   13   14   15   16   >