[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695911751 > i've tried feeding typed arrays to uPlot in the past and surprisingly did not measure a difference in performance. i'll take a closer look in a few days

[GitHub] [incubator-echarts] pissang commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang commented on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695911751 > i've tried feeding typed arrays to uPlot in the past and surprisingly did not measure a difference in performance. i'll take a closer look in a few days at your

[GitHub] [incubator-echarts] leeoniya edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
leeoniya edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695890304 thanks for the detailed reply. i agree that exceeding the local extremes is a worse outcome than a more "S" shaped creative interpolation between

[GitHub] [incubator-echarts] leeoniya commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
leeoniya commented on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695890304 thanks for the detailed reply. i agree that exceeding the local extremes is a worse outcome than a more "S" shaped creative interpolation between datapoints.

[GitHub] [incubator-echarts] SnailSword commented on pull request #13312: feat(sample): support largest-triangle-three-buckets algo

2020-09-20 Thread GitBox
SnailSword commented on pull request #13312: URL: https://github.com/apache/incubator-echarts/pull/13312#issuecomment-695882203 > Thanks a lot for the work! Do you mind changing the pull request target to the next branch @pissang OK, I will open a new pr.

[GitHub] [incubator-echarts] SnailSword closed pull request #13312: feat(sample): support largest-triangle-three-buckets algo

2020-09-20 Thread GitBox
SnailSword closed pull request #13312: URL: https://github.com/apache/incubator-echarts/pull/13312 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695879944 https://echarts-bench-from-uplot.glitch.me/uplot-smoothing.html I tried it and the result seems a bit different from my Catmull-Rom spline

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695879944 https://echarts-bench-from-uplot.glitch.me/uplot-smoothing.html I tried it and seems a bit different from my Catmull-Rom spline implementation.

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695879944 https://echarts-bench-from-uplot.glitch.me/uplot-smoothing.html I tried it and seems a bit different from my Catmull-Rom spline implementation.

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695879944 https://echarts-bench-from-uplot.glitch.me/uplot-smoothing.html I tried it and seems a bit different from my Catmull-Rom spline implementation.

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695879944 https://echarts-bench-from-uplot.glitch.me/uplot-smoothing.html I tried it and seems a bit different from my Catmull-Rom spline implementation.

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695879944 https://echarts-bench-from-uplot.glitch.me/uplot-smoothing.html I tried it and seems a bit different from my Catmull-Rom spline implementation.

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695879944 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-echarts] pissang commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang commented on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695880821 Merged this PR. @leeoniya We can still discuss the smoothing algorithm here. I will open another PR to improve it if necessary.

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695879944 https://echarts-bench-from-uplot.glitch.me/uplot-smoothing.html I tried it and seems a bit different from my Catmull-Rom spline implementation.

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695879944 https://echarts-bench-from-uplot.glitch.me/uplot-smoothing.html I tried it and seems a bit different with my Catmull-Rom spline implementation.

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
echarts-bot[bot] commented on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695880093 Congratulations! Your PR has been merged. Thanks for your contribution!  This is an

[incubator-echarts] branch next updated (e8f22f2 -> a40b939)

2020-09-20 Thread shenyi
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch next in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from e8f22f2 fix: add registerPostInit for gl. add 71a590b line: optimize memory cost and initialize time

[incubator-echarts] 01/01: Merge pull request #13314 from apache/line-optimize

2020-09-20 Thread shenyi
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a commit to branch next in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git commit a40b939db4dd8c363f9d2385fc210dc9eb79ca86 Merge: e8f22f2 76bf8f4 Author: Yi Shen AuthorDate: Mon Sep 21

[GitHub] [incubator-echarts] pissang merged pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang merged pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-echarts] pissang commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang commented on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695879944 https://echarts-bench-from-uplot.glitch.me/uplot-smoothing.html I tried it and it looks similar to our original bezier curve implementation without limiting

[GitHub] [incubator-echarts] wangdi244 commented on issue #13300: 背景画出一个圆形,点在圆形范围之内活动

2020-09-20 Thread GitBox
wangdi244 commented on issue #13300: URL: https://github.com/apache/incubator-echarts/issues/13300#issuecomment-695879358 ![图](https://user-images.githubusercontent.com/13075509/93729665-0d310900-fbf8-11ea-9459-a0aaa2991d06.png)

[GitHub] [incubator-echarts] msbasanth commented on issue #13279: Allow chart action controls for modifying data visualization in the rendered charts

2020-09-20 Thread GitBox
msbasanth commented on issue #13279: URL: https://github.com/apache/incubator-echarts/issues/13279#issuecomment-695876523 @100pah Agree that ECharts is rendered using Canvas or SVG. As you said we could move this data filtering controls outside chart rendering area and and

[GitHub] [incubator-echarts] plainheart commented on issue #13290: Update echarts on cdnjs.com

2020-09-20 Thread GitBox
plainheart commented on issue #13290: URL: https://github.com/apache/incubator-echarts/issues/13290#issuecomment-695857231 BTW, echarts 4.9.0 is available on https://www.jsdelivr.com/package/npm/echarts?path=dist This is

[GitHub] [incubator-echarts] plainheart edited a comment on issue #13290: Update echarts on cdnjs.com

2020-09-20 Thread GitBox
plainheart edited a comment on issue #13290: URL: https://github.com/apache/incubator-echarts/issues/13290#issuecomment-695856446 @piotrzarzycki21 Sorry for the late reply. I've opened an issue (see cdnjs/packages#442) to request an update of 4.9.0 several days ago, a member said that

[GitHub] [incubator-echarts] plainheart commented on issue #13290: Update echarts on cdnjs.com

2020-09-20 Thread GitBox
plainheart commented on issue #13290: URL: https://github.com/apache/incubator-echarts/issues/13290#issuecomment-695856446 @piotrzarzycki21 Sorry for the late reply. I've opened an issue (see cdnjs/packages#442) to request an update of 4.9.0 several days ago, a member said that both

[incubator-echarts] branch next updated: fix: add registerPostInit for gl.

2020-09-20 Thread shenyi
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a commit to branch next in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git The following commit(s) were added to refs/heads/next by this push: new e8f22f2 fix: add registerPostInit for

[GitHub] [incubator-echarts] paradox010 commented on issue #13277: 自定义图形的纹理

2020-09-20 Thread GitBox
paradox010 commented on issue #13277: URL: https://github.com/apache/incubator-echarts/issues/13277#issuecomment-695797402 我没把问题讲清楚,纹理是可以绘制出来的,麻烦的是移动的时候纹理也会跟着走orz。 This is an automated message from the Apache Git Service.

[GitHub] [incubator-echarts] paradox010 commented on issue #13277: 自定义图形的纹理

2020-09-20 Thread GitBox
paradox010 commented on issue #13277: URL: https://github.com/apache/incubator-echarts/issues/13277#issuecomment-695797178 @100pah 抱歉不合适我的需求。我的需求是 1.背景世界地图+全国地图在一起,(支持平移缩放) 2.全国地图可以响应选择/悬浮事件,但是背景的地图不可以。 3.背景地图和全国地图样式不一样,各自有纹理。

[GitHub] [incubator-echarts] leeoniya edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
leeoniya edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695785582 > I'm not sure if you did any modification on the original Catmull-Rom Spline algorithm. i simply adjusted this implementation for the uPlot demo

[GitHub] [incubator-echarts] leeoniya edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
leeoniya edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695785582 > I'm not sure if you did any modification on the original Catmull-Rom Spline algorithm. i simply adjusted this implementation for the uPlot demo

[GitHub] [incubator-echarts] leeoniya commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
leeoniya commented on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695785582 > I'm not sure if you did any modification on the original Catmull-Rom Spline algorithm. i simply adjusted the algo for the uPlot demo from this gist:

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695777118 PS: I did both the performance improvement and smoothing algorithm improvement when refactoring the [polyline

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695777118 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695777118 PS: I did both the performance improvement and smoothing algorithm improvement when refactoring the polyline builder

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695777118 PS: I did both the performance improvement and smoothing algorithm improvement when refactoring the polyline builder. So I didn't try to separate it into

[GitHub] [incubator-echarts] pissang commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang commented on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695777118 PS: I did both the performance imrpvoment and smoothing algorithm improvement when refactoring the polyline builder. So I didn't try to separate it into two PRs.

[GitHub] [incubator-echarts] piotrzarzycki21 commented on issue #13290: Update echarts on cdnjs.com

2020-09-20 Thread GitBox
piotrzarzycki21 commented on issue #13290: URL: https://github.com/apache/incubator-echarts/issues/13290#issuecomment-695773783 Any update on this ? We would like to use newest version of Echarts, but now it's impossible trough cdnjs, unless there is different place where framework is

[GitHub] [incubator-echarts] stale[bot] commented on issue #8450: 动态嵌套饼图时, Cannot read property 'startAngle' of undefined

2020-09-20 Thread GitBox
stale[bot] commented on issue #8450: URL: https://github.com/apache/incubator-echarts/issues/8450#issuecomment-695768375 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695762009 Did some modifications to make the case look better(won't affect the performance.

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695762009 Did some modifications to make these two versions look better(won't affect the performance.

[GitHub] [incubator-echarts] pissang commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang commented on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695762009 Did some modifications to make these two versions look more reasonable :)

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695762009 Did some modifications to make these two versions look more reasonable(won't affect the performance.

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695758284 @leeoniya Thanks for the benchmark. I'm really impressed by the performance of uPlot! I add an optimized version that takes a Float64Array as input

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695758284 @leeoniya Thanks for the benchmark. I'm really impressed by the performance of uPlot! I add an optimized version that takes a Float64Array as input

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695758284 @leeoniya Thanks for the benchmark. I'm really impressed by the performance of uPlot! I add an optimized version that takes a Float64Array as input

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695758284 @leeoniya Thanks for the benchmark. I'm really impressed by the performance of uPlot! I add an optimized version that takes a Float64Array as input

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695758284 @leeoniya Thanks for the benchmark. I'm really impressed by the performance of uPlot! I add an optimized version that takes a Float64Array as input

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695758284 @leeoniya Thanks for the benchmark. I'm really impressed by the performance of uPlot I add an optimized version that takes a Float64Array as input

[GitHub] [incubator-echarts] pissang edited a comment on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695758284 @leeoniya Thanks for the benchmark. I'm really impressed by the performance of uPlot I add an optimized version that takes a Float64Array as data

[GitHub] [incubator-echarts] pissang commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.

2020-09-20 Thread GitBox
pissang commented on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695758284 @leeoniya Thanks for the benchmark. I'm really impressed by the performance of uPlot I add an optimized version that takes a Float64Array as data input.

[GitHub] [incubator-echarts] stale[bot] commented on issue #9109: 柱状图可否定制一组数据不同颜色(根据正负值)

2020-09-20 Thread GitBox
stale[bot] commented on issue #9109: URL: https://github.com/apache/incubator-echarts/issues/9109#issuecomment-695753506 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your