[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1307320706 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/search/service/SearchUtil.java: ## @@ -116,47 +116,75 @@ public static void

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1307313580 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/datatable/DatatableIntegrationTest.java: ## @@ -499,37 +499,40 @@ public void

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1307310298 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java: ## @@ -1940,8 +2047,8 @@

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1307308919 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/JdbcJavaType.java: ## @@ -30,14 +30,14 @@ public enum JdbcJavaType {

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1281670436 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java: ## @@ -36,14 +42,26 @@ public

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1281653731 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/JavaType.java: ## @@ -0,0 +1,352 @@ +package

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1281648777 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseTypeResolver.java: ## @@ -58,10 +58,10 @@ public DatabaseType

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1281646312 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseType.java: ## @@ -19,5 +19,16 @@ package

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1279488865 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/EntityDatatableChecksWritePlatformServiceImpl.java: ## @@ -105,11

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1279487950 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/EntityDatatableChecksReadPlatformServiceImpl.java: ## @@ -174,20

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1279482653 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/api/DatatablesApiResource.java: ## @@ -225,6 +228,18 @@ public String

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1279479557 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/JdbcJavaType.java: ## @@ -0,0 +1,321 @@ +package

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1279478794 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/JavaType.java: ## @@ -0,0 +1,352 @@ +package

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1275191605 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainServiceJpa.java: ## @@ -173,9 +173,8 @@ public

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1275185065 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java: ## @@ -36,14 +42,26 @@ public

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1275182347 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityTables.java: ## @@ -18,88 +18,114 @@ */ package

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

marta-jankovics commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1275178102 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java: ## @@ -36,14 +42,26 @@ public