[GitHub] [fineract] adamsaghy merged pull request #3410: FINERACT-1911: Assign Data Table to Transaction - validation

adamsaghy merged PR #3410: URL: https://github.com/apache/fineract/pull/3410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[fineract] branch develop updated: FINERACT-1911: Assign Data Table to Transaction - validation

This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 28e9a6213 FINERACT-1911: Assign Data

[GitHub] [fineract] abraham-menyhart commented on pull request #3411: FINERACT-1760: savings account externalId support

abraham-menyhart commented on PR #3411: URL: https://github.com/apache/fineract/pull/3411#issuecomment-1700892287 Thanks for your review @adamsaghy, I fixed the code according to your comments. Can you please review it again? -- This is an automated message from the Apache Git Service.

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3411: FINERACT-1760: savings account externalId support

adamsaghy commented on code in PR #3411: URL: https://github.com/apache/fineract/pull/3411#discussion_r1311569574 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountRepository.java: ## @@ -65,5 +66,8 @@ SavingsAccount

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3409: Fineract-1969: Datatable insert, update SQL Injection

adamsaghy commented on code in PR #3409: URL: https://github.com/apache/fineract/pull/3409#discussion_r1311616319 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/DateUtils.java: ## @@ -78,6 +79,14 @@ public static LocalDateTime

[GitHub] [fineract] adamsaghy commented on pull request #3411: FINERACT-1760: savings account externalId support

adamsaghy commented on PR #3411: URL: https://github.com/apache/fineract/pull/3411#issuecomment-1701060918 @abraham-menyhart Run './gradlew :integration-tests:spotlessApply' to fix these violations. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract] abraham-menyhart commented on a diff in pull request #3411: FINERACT-1760: savings account externalId support

abraham-menyhart commented on code in PR #3411: URL: https://github.com/apache/fineract/pull/3411#discussion_r1311648580 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountRepository.java: ## @@ -65,5 +66,8 @@ SavingsAccount

[GitHub] [fineract] marta-jankovics commented on a diff in pull request #3409: Fineract-1969: Datatable insert, update SQL Injection

marta-jankovics commented on code in PR #3409: URL: https://github.com/apache/fineract/pull/3409#discussion_r1311811466 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/DateUtils.java: ## @@ -78,6 +79,14 @@ public static LocalDateTime

[GitHub] [fineract] mmagdiab commented on a diff in pull request #3373: FINERACT-1932: Add custom AutoConfiguration class for transfer service

mmagdiab commented on code in PR #3373: URL: https://github.com/apache/fineract/pull/3373#discussion_r1311816982 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/transfer/starter/TransferAutoConfiguration.java: ## @@ -0,0 +1,58 @@ +/** + * Licensed to the Apache

[fineract] branch develop updated: FINERACT-1969 SQL Injection exception thrown even if no insecure string is in the input

This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 6a90ce3f1 FINERACT-1969 SQL Injection

[GitHub] [fineract] adamsaghy merged pull request #3409: Fineract-1969: Datatable insert, update SQL Injection

adamsaghy merged PR #3409: URL: https://github.com/apache/fineract/pull/3409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] mmagdiab opened a new pull request, #3419: FINERACT-1932: Add custom Configuration class for shareproduct services

mmagdiab opened a new pull request, #3419: URL: https://github.com/apache/fineract/pull/3419 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] mmagdiab opened a new pull request, #3420: FINERACT-1932: Add custom Configuration class for shareaccounts services

mmagdiab opened a new pull request, #3420: URL: https://github.com/apache/fineract/pull/3420 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA