vorburger opened a new pull request #581: remove Instructions to download
gradle wrapper from README
URL: https://github.com/apache/fineract/pull/581
because the Gradle Wrapper is available in fineract-provider/gradle/wrapper
and therefore not a pre-requisite to contribute
> as
vorburger opened a new pull request #583: add Fedora prereq install doc to
README
URL: https://github.com/apache/fineract/pull/583
WIP, do not merge - using mariadb-server currently fails due to below.
Once we're done with the upcoming upgrades, this hopefully will work though.
vorburger commented on issue #246: Put gradle version in build.gradle and avoid
having to download the correct gradle version prior to building
URL: https://github.com/apache/fineract/pull/246#issuecomment-501151866
This has meanwhile been done by someone else, and one can now just use:
vishwasbabu merged pull request #584: Batch Repayment strategy - New feature
URL: https://github.com/apache/fineract/pull/584
This is an automated message from the Apache Git Service.
To respond to the message, please log on
vishwasbabu merged pull request #587: minor README clean up to remove more left
over Gradle wrapper mentions
URL: https://github.com/apache/fineract/pull/587
This is an automated message from the Apache Git Service.
To
vishwasbabu merged pull request #590: run integrationTest on Travis without
gradlew migrateTenantDB/migrateTenantListDB (re. FINERACT-765)
URL: https://github.com/apache/fineract/pull/590
This is an automated message from
mohitsinha commented on issue #584: Batch Repayment strategy - New feature
URL: https://github.com/apache/fineract/pull/584#issuecomment-502212787
I have made those changes.
Thanks @vishwasbabu
This is an automated
vishwasbabu commented on a change in pull request #574: FINERACT-609 Group
Topup Loan Bug Fix.
URL: https://github.com/apache/fineract/pull/574#discussion_r293961114
##
File path:
michaelbukachi commented on issue #582: use MariaDB ConnectorJ instead of
Drizzle MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761)
URL: https://github.com/apache/fineract/pull/582#issuecomment-501210339
@vorburger reference to the drizzle driver is thrown quite a
muarachmann commented on issue #582: use MariaDB ConnectorJ instead of Drizzle
MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761)
URL: https://github.com/apache/fineract/pull/582#issuecomment-501203188
@vorburger absolutely. I see what is ongoing i too switched to
therajanmaurya merged pull request #67: Passcode and Splash Screen added
URL: https://github.com/apache/fineract-cn-mobile/pull/67
This is an automated message from the Apache Git Service.
To respond to the message, please
michaelbukachi commented on issue #582: use MariaDB ConnectorJ instead of
Drizzle MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761)
URL: https://github.com/apache/fineract/pull/582#issuecomment-501238125
If it's okay to go ahead with it. I could take a look at your code
vorburger commented on issue #582: use MariaDB ConnectorJ instead of Drizzle
MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761)
URL: https://github.com/apache/fineract/pull/582#issuecomment-501226724
> I see what is ongoing i too switched to mysql-connector which worked
vorburger merged pull request #589: rename SQL Query Parameters (fixes
FINERACT-766)
URL: https://github.com/apache/fineract/pull/589
This is an automated message from the Apache Git Service.
To respond to the message,
vorburger commented on issue #589: rename SQL Query Parameters (fixes
FINERACT-766)
URL: https://github.com/apache/fineract/pull/589#issuecomment-502488421
Ok, let's merge it then.. I'll (exceptionally) self merge this one, based on
the discussion and confidence that it shouldn't break
angelboxes edited a comment on issue #589: rename SQL Query Parameters (fixes
FINERACT-766)
URL: https://github.com/apache/fineract/pull/589#issuecomment-502383914
It seems to be right, unless you change how the entity is mapped or the name
of the function findByKey, I don't see how this
angelboxes commented on issue #589: rename SQL Query Parameters (fixes
FINERACT-766)
URL: https://github.com/apache/fineract/pull/589#issuecomment-502383914
It seems to be right, unless you change how the mapped entity or the name of
this repository function, I don't see how this change
miPlodder opened a new pull request #66: Migration to AndroidX
URL: https://github.com/apache/fineract-cn-mobile/pull/66
- [ ] Apply the `AndroidStyle.xml` style template to your code in Android
Studio.
- [ ] Run the unit tests with `./gradlew check` to make sure you didn't
break
miPlodder commented on issue #66: Migration to AndroidX
URL: https://github.com/apache/fineract-cn-mobile/pull/66#issuecomment-500208421
@therajanmaurya Ok
This is an automated message from the Apache Git Service.
To respond
therajanmaurya commented on issue #66: Migration to AndroidX
URL: https://github.com/apache/fineract-cn-mobile/pull/66#issuecomment-500208404
@miPlodder Please fix the conflicts and let me know.
This is an automated message
therajanmaurya closed pull request #41: feat: added roboto font
URL: https://github.com/apache/fineract-cn-mobile/pull/41
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
therajanmaurya commented on issue #41: feat: added roboto font
URL: https://github.com/apache/fineract-cn-mobile/pull/41#issuecomment-500208359
Fixed in #65
This is an automated message from the Apache Git Service.
To
awasum commented on issue #11: Thymeleaf templating for Email
URL:
https://github.com/apache/fineract-cn-notifications/pull/11#issuecomment-500202432
Have u tested and everything works on your side?
Let me know to merge this today.
therajanmaurya commented on issue #51: feat: Add Support Gradle Play Publisher
URL: https://github.com/apache/fineract-cn-mobile/pull/51#issuecomment-500208306
Ok @miPlodder closing!
This is an automated message from the
therajanmaurya commented on a change in pull request #65: feat# Roboto font
added
URL: https://github.com/apache/fineract-cn-mobile/pull/65#discussion_r291835944
##
File path: build.gradle
##
@@ -31,7 +31,7 @@ task clean(type: Delete) {
ext {
// Sdk and tools
-
therajanmaurya merged pull request #65: feat# Roboto font added
URL: https://github.com/apache/fineract-cn-mobile/pull/65
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
therajanmaurya merged pull request #66: Migration to AndroidX and some bug fixes
URL: https://github.com/apache/fineract-cn-mobile/pull/66
This is an automated message from the Apache Git Service.
To respond to the message,
ebenezergraham opened a new pull request #14: Fixed Failing test-case
URL: https://github.com/apache/fineract-cn-accounting/pull/14
This is an automated message from the Apache Git Service.
To respond to the message, please
ebenezergraham opened a new pull request #30: Removed extra user dedicated to
the notification service
URL: https://github.com/apache/fineract-cn-demo-server/pull/30
Removed Notifications user to use org admin
This will reduce the load on the demo-server
kangbreder closed pull request #578: Organisation module
URL: https://github.com/apache/fineract/pull/578
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kangbreder closed pull request #579: Portfolio module
URL: https://github.com/apache/fineract/pull/579
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kangbreder closed pull request #577: Corrected API description in the
infrastructure module
URL: https://github.com/apache/fineract/pull/577
This is an automated message from the Apache Git Service.
To respond to the
kangbreder closed pull request #576: corrected API description in the commands
module
URL: https://github.com/apache/fineract/pull/576
This is an automated message from the Apache Git Service.
To respond to the message,
awasum merged pull request #14: Fixed Failing test-case
URL: https://github.com/apache/fineract-cn-accounting/pull/14
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
vorburger commented on issue #582: use MariaDB ConnectorJ instead of Drizzle
MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761)
URL: https://github.com/apache/fineract/pull/582#issuecomment-501316815
> If it's okay to go ahead with it.
vorburger commented on issue #582: use MariaDB ConnectorJ instead of Drizzle
MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761)
URL: https://github.com/apache/fineract/pull/582#issuecomment-501337279
> I'm not sure I understand the TravisCI build failure here... don't
vorburger opened a new pull request #585: use Ubuntu Trusty instead of Xenial
on Travis CI (fixes FINERACT-763)
URL: https://github.com/apache/fineract/pull/585
see https://issues.apache.org/jira/browse/FINERACT-763
re.
vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to
5.2.1
URL: https://github.com/apache/fineract/pull/525#issuecomment-501171690
I've just rebased this on the current `develop`, and resolved the conflict
it had in `fineract-provider/dependencies.gradle`; my main
vorburger opened a new pull request #587: minor README clean up to remove more
left over Gradle wrapper mentions
URL: https://github.com/apache/fineract/pull/587
as in #581 (the last mention is intentionally left, because #586 removes
that one)
@vishwasbabu @awasum @angelboxes
vorburger opened a new pull request #586: document how to run mysql in docker
container in README
URL: https://github.com/apache/fineract/pull/586
@vishwasbabu @awasum @angelboxes review and merge?
This is an automated
vorburger commented on issue #584: Batch Repayment strategy - New feature
URL: https://github.com/apache/fineract/pull/584#issuecomment-501421733
@awasum @angelboxes @muarachmann @vishwasbabu anyone willing to review this
one?
PS: @mohitsinha what I do in general is just check the
vishwasbabu commented on issue #579: Portfolio module
URL: https://github.com/apache/fineract/pull/579#issuecomment-501427670
@kangbreder: Given that the pr's you are sending out are a part of GSOC, can
you please get in touch with your mentor and ensure that (s)he is reviewing and
vishwasbabu commented on a change in pull request #584: Batch Repayment
strategy - New feature
URL: https://github.com/apache/fineract/pull/584#discussion_r293081621
##
File path:
fineract-provider/src/main/java/org/apache/fineract/batch/command/CommandStrategyProvider.java
vorburger merged pull request #585: use Ubuntu Trusty instead of Xenial on
Travis CI (fixes FINERACT-763)
URL: https://github.com/apache/fineract/pull/585
This is an automated message from the Apache Git Service.
To respond
vorburger commented on issue #582: use MariaDB ConnectorJ instead of Drizzle
MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761)
URL: https://github.com/apache/fineract/pull/582#issuecomment-501439424
Voilà, build is green now!
@awasum @angelboxes @muarachmann
michaelbukachi commented on issue #582: use MariaDB ConnectorJ instead of
Drizzle MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761)
URL: https://github.com/apache/fineract/pull/582#issuecomment-501467657
Awesome stuff! This is truly a breakthrough!
vorburger opened a new pull request #588: {WIP} make WAR executable again
(fixes FINERACT-730)
URL: https://github.com/apache/fineract/pull/588
This currently doesn't actually fully work due to missing OpenJPA
enhancement... :-(
vorburger commented on issue #582: use MariaDB ConnectorJ instead of Drizzle
MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761)
URL: https://github.com/apache/fineract/pull/582#issuecomment-501906137
> @vorburger : Thinking back, we could probably have simply removed all
vorburger commented on issue #525: FINERACT-700: upgrade Gradle from 2.10 to
5.2.1
URL: https://github.com/apache/fineract/pull/525#issuecomment-501922674
I've made further progress on this, and now almost works, except `./gradlew
integrationTest` fails to start Tomact... one possible
vorburger commented on issue #589: rename SQL Query Parameters (fixes
FINERACT-766)
URL: https://github.com/apache/fineract/pull/589#issuecomment-501929878
@vishwasbabu @awasum @angelboxes is this safe to change?
see https://issues.apache.org/jira/browse/FINERACT-766
vorburger commented on issue #550: Fineract 700 upgrade gradle - Flyway plugin
Upgrade
URL: https://github.com/apache/fineract/pull/550#issuecomment-501931500
> @muarachmann Pull request #582 has been merged :-). You can now work on
upgrading flyway based off the latest develop commit
vorburger commented on issue #588: {WIP} make WAR executable again (fixes
FINERACT-730)
URL: https://github.com/apache/fineract/pull/588#issuecomment-501934114
Closing this, as this only works if it's on top of #525.
This is
vorburger closed pull request #588: {WIP} make WAR executable again (fixes
FINERACT-730)
URL: https://github.com/apache/fineract/pull/588
This is an automated message from the Apache Git Service.
To respond to the message,
vorburger edited a comment on issue #588: {WIP} make WAR executable again
(fixes FINERACT-730)
URL: https://github.com/apache/fineract/pull/588#issuecomment-501934114
Closing this, as this only works if it's on top of #525, where I've now
integrated it.
mohitsinha edited a comment on issue #584: Batch Repayment strategy - New
feature
URL: https://github.com/apache/fineract/pull/584#issuecomment-501985972
https://jira.apache.org/jira/browse/FINERACT-767
I created a new task on jira for this.
mohitsinha commented on a change in pull request #584: Batch Repayment strategy
- New feature
URL: https://github.com/apache/fineract/pull/584#discussion_r293673953
##
File path:
fineract-provider/src/main/java/org/apache/fineract/batch/command/CommandStrategyProvider.java
mohitsinha edited a comment on issue #584: Batch Repayment strategy - New
feature
URL: https://github.com/apache/fineract/pull/584#issuecomment-501985972
https://jira.apache.org/jira/browse/FINERACT-767
I created a new task on jira for this.
No new Api's have been created hence,
vishwasbabu commented on issue #584: Batch Repayment strategy - New feature
URL: https://github.com/apache/fineract/pull/584#issuecomment-501987582
API docs list details of all available commands (see
https://demo.openmf.org/api-docs/apiLive.htm#batch_api), the same would need to
be
ebenezergraham commented on issue #11: Thymeleaf templating for Email
URL:
https://github.com/apache/fineract-cn-notifications/pull/11#issuecomment-500464653
Not yet, I broke my environment trying to replicate the issue Eric faced. I
will inform you once I test it.
ebenezergraham commented on issue #11: Thymeleaf templating for Email
URL:
https://github.com/apache/fineract-cn-notifications/pull/11#issuecomment-500465523
Not yet, I broke my environment trying to replicate the issue Eric faced. I
will inform you once I test it. Hipefully, by tomorrow
angelboxes opened a new pull request #592: FINERACT-614: Rates Module
URL: https://github.com/apache/fineract/pull/592
## Description
This is a follow up for [Pull Request 465
](https://github.com/apache/fineract/pull/465)
This pull requests add a new rates module which allows
miPlodder opened a new pull request #68: View Group functionality added
URL: https://github.com/apache/fineract-cn-mobile/pull/68
- [x] Apply the `AndroidStyle.xml` style template to your code in Android
Studio.
- [x] Run the unit tests with `./gradlew check` to make sure you didn't
conradsp opened a new pull request #593: Create one-touch deploy with docker
URL: https://github.com/apache/fineract/pull/593
## Description
Allow users to launch a new Fineract instance easily with Docker and
docker-compose. Also allow local devs to run in a docker environment.
vorburger commented on a change in pull request #593: Create one-touch deploy
with docker
URL: https://github.com/apache/fineract/pull/593#discussion_r295935316
##
File path: docker/build.gradle
##
@@ -0,0 +1,553 @@
+/**
Review comment:
@conradsp this appears to be
vorburger commented on a change in pull request #593: Create one-touch deploy
with docker
URL: https://github.com/apache/fineract/pull/593#discussion_r295936681
##
File path: docker/Dockerfile
##
@@ -0,0 +1,28 @@
+FROM bitnami/tomcat:7.0.94 as fineract
+
+USER root
+RUN
vorburger commented on a change in pull request #593: Create one-touch deploy
with docker
URL: https://github.com/apache/fineract/pull/593#discussion_r295935550
##
File path: docker/README.md
##
@@ -0,0 +1,25 @@
+Installing Fineract with Docker and docker-compose
vorburger commented on issue #594: fix minor SQL syntax problem in
V271__accounting_for_client_charges.sql
URL: https://github.com/apache/fineract/pull/594#issuecomment-504146454
upgrading flyway-gradle-plugin from 3.0 to 5.2.4 required this
vishwasbabu merged pull request #594: fix minor SQL syntax problem in
V271__accounting_for_client_charges.sql
URL: https://github.com/apache/fineract/pull/594
This is an automated message from the Apache Git Service.
To
vorburger commented on a change in pull request #593: Create one-touch deploy
with docker
URL: https://github.com/apache/fineract/pull/593#discussion_r296234162
##
File path: README.md
##
@@ -49,6 +49,26 @@ Run the following commands, very similarly to how
conradsp commented on a change in pull request #593: Create one-touch deploy
with docker
URL: https://github.com/apache/fineract/pull/593#discussion_r296259067
##
File path: README.md
##
@@ -49,6 +49,26 @@ Run the following commands, very similarly to how
vorburger commented on a change in pull request #593: Create one-touch deploy
with docker
URL: https://github.com/apache/fineract/pull/593#discussion_r296237547
##
File path: Dockerfile
##
@@ -0,0 +1,20 @@
+FROM bitnami/tomcat:7.0.94 as fineract
+
+USER root
+RUN apt-get
conradsp commented on a change in pull request #593: Create one-touch deploy
with docker
URL: https://github.com/apache/fineract/pull/593#discussion_r296259681
##
File path: Dockerfile
##
@@ -0,0 +1,20 @@
+FROM bitnami/tomcat:7.0.94 as fineract
+
+USER root
+RUN apt-get
vishwasbabu merged pull request #580: Fineract-759: Thread unsafe bug in batch
transactions
URL: https://github.com/apache/fineract/pull/580
This is an automated message from the Apache Git Service.
To respond to the
vishwasbabu commented on issue #582: use MariaDB ConnectorJ instead of Drizzle
MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761)
URL: https://github.com/apache/fineract/pull/582#issuecomment-501543815
@vorburger : Thinking back, we could probably have simply removed all
vishwasbabu merged pull request #582: use MariaDB ConnectorJ instead of Drizzle
MySQL JDBC driver -only- during build for Flyway (fixes FINERACT-761)
URL: https://github.com/apache/fineract/pull/582
This is an automated
miPlodder opened a new pull request #67: Passcode and Splash Screen added
URL: https://github.com/apache/fineract-cn-mobile/pull/67
- [x] Apply the `AndroidStyle.xml` style template to your code in Android
Studio.
- [x] Run the unit tests with `./gradlew check` to make sure you
vishwasbabu merged pull request #591: clarify README doc re. downloading the
Gradle wrapper
URL: https://github.com/apache/fineract/pull/591
This is an automated message from the Apache Git Service.
To respond to the
awasum commented on issue #10: Changing Notification Admin to OrgAdmin
URL:
https://github.com/apache/fineract-cn-notifications/pull/10#issuecomment-490896599
@Izakey Will you be able to test and merge if all is well?
This
awasum commented on a change in pull request #10: Changing Notification Admin
to OrgAdmin
URL:
https://github.com/apache/fineract-cn-notifications/pull/10#discussion_r282475925
##
File path: .gitignore
##
@@ -2,13 +2,8 @@
.idea
build/
target/
-build/out
-service/out
ebenezergraham commented on a change in pull request #10: Changing Notification
Admin to OrgAdmin
URL:
https://github.com/apache/fineract-cn-notifications/pull/10#discussion_r282473833
##
File path: .gitignore
##
@@ -2,13 +2,8 @@
.idea
build/
target/
-build/out
ebenezergraham commented on issue #9: Migrate notification service to PostgreSQL
URL:
https://github.com/apache/fineract-cn-notifications/pull/9#issuecomment-490977282
> Conflicts here.
>
> Also work with Graham to enable Travis here.
@awasum I have added the Travis
awasum commented on issue #9: Migrate notification service to PostgreSQL
URL:
https://github.com/apache/fineract-cn-notifications/pull/9#issuecomment-490812088
Conflicts here.
Also work with Graham to enable Travis here.
andrew-dzak opened a new pull request #568: FINERACT-753 incorrect savings
account balance when charge transactio…
URL: https://github.com/apache/fineract/pull/568
…n is reversed during an overdraft recalculate Daily Balance
## Description
Describe the changes made and why they
awasum commented on issue #9: Migrate notification service to PostgreSQL
URL:
https://github.com/apache/fineract-cn-notifications/pull/9#issuecomment-491571262
Great point, discuss it on the mailing list and see others options. Then
maybe create an issue after that.
On Sat, May
ebenezergraham commented on issue #9: Migrate notification service to PostgreSQL
URL:
https://github.com/apache/fineract-cn-notifications/pull/9#issuecomment-491549798
> > Conflicts here.
> > Also work with Graham to enable Travis here.
>
> @awasum I have added the Travis
vishwasbabu commented on issue #562: FINERACT-706 - Mojaloop fineract 1.0
URL: https://github.com/apache/fineract/pull/562#issuecomment-492078123
@conradsp : The pr at https://github.com/apache/fineract/pull/565 has been
updated with Integration tests cases and looks ready to merge (from a
vishwasbabu commented on a change in pull request #565: FINERACT-706:
Interoperation Mojaloop integration 1.0.1
URL: https://github.com/apache/fineract/pull/565#discussion_r283624708
##
File path:
aasaru commented on issue #29: simplify running demo-server by fetching
fineract-cn-* projects from Artifactory
URL:
https://github.com/apache/fineract-cn-demo-server/pull/29#issuecomment-494915539
Could anyone please review (and accept) this pull request. Thanks!
awasum merged pull request #29: simplify running demo-server by fetching
fineract-cn-* projects from Artifactory
URL: https://github.com/apache/fineract-cn-demo-server/pull/29
This is an automated message from the Apache
awasum commented on issue #29: simplify running demo-server by fetching
fineract-cn-* projects from Artifactory
URL:
https://github.com/apache/fineract-cn-demo-server/pull/29#issuecomment-494919311
LGTM
This is an automated
awasum commented on issue #29: simplify running demo-server by fetching
fineract-cn-* projects from Artifactory
URL:
https://github.com/apache/fineract-cn-demo-server/pull/29#issuecomment-494919487
Will you update the README on usage?
aasaru commented on issue #29: simplify running demo-server by fetching
fineract-cn-* projects from Artifactory
URL:
https://github.com/apache/fineract-cn-demo-server/pull/29#issuecomment-494920104
Yes, I will update readme shortly.
aasaru commented on issue #29: simplify running demo-server by fetching
fineract-cn-* projects from Artifactory
URL:
https://github.com/apache/fineract-cn-demo-server/pull/29#issuecomment-494920187
Thanks for reviewing.
awasum commented on issue #29: simplify running demo-server by fetching
fineract-cn-* projects from Artifactory
URL:
https://github.com/apache/fineract-cn-demo-server/pull/29#issuecomment-494921732
When you do that just merge the PR. Thanks for the work done.
ebenezergraham opened a new pull request #11: Thymeleaf templating for Email
URL: https://github.com/apache/fineract-cn-notifications/pull/11
Started HTML templating
This is an automated message from the Apache Git Service.
awasum commented on issue #11: Thymeleaf templating for Email
URL:
https://github.com/apache/fineract-cn-notifications/pull/11#issuecomment-495356243
Apache RAT task is failing.
https://travis-ci.com/apache/fineract-cn-notifications/builds/112988545
ebenezergraham commented on issue #11: Thymeleaf templating for Email
URL:
https://github.com/apache/fineract-cn-notifications/pull/11#issuecomment-495374287
> Apache RAT task is failing.
https://travis-ci.com/apache/fineract-cn-notifications/builds/112988545
The rat fails are
palanisami closed pull request #569: FINERACT-689
URL: https://github.com/apache/fineract/pull/569
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
aasaru opened a new pull request #12: FINCN-148 build with travis-ci.com and
upload artifacts to Artifactory
URL: https://github.com/apache/fineract-cn-notifications/pull/12
It seems I have missed to create PR for this repo.
palanisami opened a new pull request #569: FINERACT-689
URL: https://github.com/apache/fineract/pull/569
## Description
1) Go to Admin>Products and select either Fixed Deposit Products or
Recurring Deposit Products and then click on Create Fixed Deposit
Product/Recurring Deposit
1301 - 1400 of 15004 matches
Mail list logo
