[GitHub] [fineract] adamsaghy merged pull request #3415: FINERACT-1724: Fix for closing the AWS credentials provider unnecessa…

2023-08-30 Thread via GitHub
adamsaghy merged PR #3415: URL: https://github.com/apache/fineract/pull/3415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy opened a new pull request, #3416: FINERACT-1724: Refactor loan repayment transaction processor

2023-08-30 Thread via GitHub
adamsaghy opened a new pull request, #3416: URL: https://github.com/apache/fineract/pull/3416 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] adamsaghy merged pull request #3413: FINERACT-1968: Advanced payment allocation strategy for Loan

2023-08-30 Thread via GitHub
adamsaghy merged PR #3413: URL: https://github.com/apache/fineract/pull/3413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy merged pull request #3416: FINERACT-1724: Refactor loan repayment transaction processor

2023-08-30 Thread via GitHub
adamsaghy merged PR #3416: URL: https://github.com/apache/fineract/pull/3416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #3372: FINERACT-1932: Add configuration for useradministration service

2023-08-30 Thread via GitHub
galovics merged PR #3372: URL: https://github.com/apache/fineract/pull/3372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #3417: FINERACT-1760: Get office by external id

2023-08-30 Thread via GitHub
galovics merged PR #3417: URL: https://github.com/apache/fineract/pull/3417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #3392: FINERACT-1932: Add custom Configuration class for Account module

2023-08-30 Thread via GitHub
galovics merged PR #3392: URL: https://github.com/apache/fineract/pull/3392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] b0c1 opened a new pull request, #3417: FINERACT-1760: Get office by external id

2023-08-30 Thread via GitHub
b0c1 opened a new pull request, #3417: URL: https://github.com/apache/fineract/pull/3417 FINERACT-1760: Get office by external id - [x] Add new resource to update - [x] Integration test -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3411: FINERACT-1760: savings account externalId support

2023-08-30 Thread via GitHub
adamsaghy commented on code in PR #3411: URL: https://github.com/apache/fineract/pull/3411#discussion_r1310130709 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountRepository.java: ## @@ -66,4 +66,7 @@ SavingsAccount

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3411: FINERACT-1760: savings account externalId support

2023-08-30 Thread via GitHub
adamsaghy commented on code in PR #3411: URL: https://github.com/apache/fineract/pull/3411#discussion_r1310133363 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/SavingsAccountsTest.java: ## @@ -80,18 +101,73 @@ void approveSavingsAccount() { }

[GitHub] [fineract] galovics merged pull request #3414: FINERACT-1932: Add custom Configuration class for collateral module

2023-08-30 Thread via GitHub
galovics merged PR #3414: URL: https://github.com/apache/fineract/pull/3414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #3402: FINERACT-1932: Add custom Configuration class for charge module

2023-08-30 Thread via GitHub
galovics merged PR #3402: URL: https://github.com/apache/fineract/pull/3402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #3398: FINERACT-1932: Add custom Configuration class for calendar module

2023-08-30 Thread via GitHub
galovics merged PR #3398: URL: https://github.com/apache/fineract/pull/3398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] ruchiD commented on a diff in pull request #3427: FINERACT-1968: Advanced payment allocation - Default allocation

2023-09-05 Thread via GitHub
ruchiD commented on code in PR #3427: URL: https://github.com/apache/fineract/pull/3427#discussion_r1315712958 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java: ## @@

[GitHub] [fineract] ruchiD commented on a diff in pull request #3427: FINERACT-1968: Advanced payment allocation - Default allocation

2023-09-05 Thread via GitHub
ruchiD commented on code in PR #3427: URL: https://github.com/apache/fineract/pull/3427#discussion_r1315710914 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java: ## @@

[GitHub] [fineract] adamsaghy merged pull request #3427: FINERACT-1968: Advanced payment allocation - Default allocation

2023-09-05 Thread via GitHub
adamsaghy merged PR #3427: URL: https://github.com/apache/fineract/pull/3427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3427: FINERACT-1968: Advanced payment allocation - Default allocation

2023-09-05 Thread via GitHub
adamsaghy commented on code in PR #3427: URL: https://github.com/apache/fineract/pull/3427#discussion_r1315716001 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java: ##

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3427: FINERACT-1968: Advanced payment allocation - Default allocation

2023-09-05 Thread via GitHub
adamsaghy commented on code in PR #3427: URL: https://github.com/apache/fineract/pull/3427#discussion_r1315716001 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java: ##

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3427: FINERACT-1968: Advanced payment allocation - Default allocation

2023-09-05 Thread via GitHub
adamsaghy commented on code in PR #3427: URL: https://github.com/apache/fineract/pull/3427#discussion_r1315715514 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java: ##

[GitHub] [fineract] ruchiD commented on a diff in pull request #3427: FINERACT-1968: Advanced payment allocation - Default allocation

2023-09-05 Thread via GitHub
ruchiD commented on code in PR #3427: URL: https://github.com/apache/fineract/pull/3427#discussion_r1315721707 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java: ## @@

[GitHub] [fineract] mmagdiab opened a new pull request, #3422: FINERACT-1932: Add custom Configuration class for search module

2023-09-03 Thread via GitHub
mmagdiab opened a new pull request, #3422: URL: https://github.com/apache/fineract/pull/3422 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] mmagdiab opened a new pull request, #3421: FINERACT-1932: Add custom Configuration class for self-account module

2023-09-03 Thread via GitHub
mmagdiab opened a new pull request, #3421: URL: https://github.com/apache/fineract/pull/3421 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] mmagdiab closed pull request #3421: FINERACT-1932: Add custom Configuration class for self-account module

2023-09-03 Thread via GitHub
mmagdiab closed pull request #3421: FINERACT-1932: Add custom Configuration class for self-account module URL: https://github.com/apache/fineract/pull/3421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [fineract] marta-jankovics opened a new pull request, #3433: FINERACT-1931: Savings Account with overdraft - cannot deposit after …

2023-09-05 Thread via GitHub
marta-jankovics opened a new pull request, #3433: URL: https://github.com/apache/fineract/pull/3433 …negative balance ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] github-actions[bot] commented on pull request #3358: TFS-65 added office opening date in response

2023-09-03 Thread via GitHub
github-actions[bot] commented on PR #3358: URL: https://github.com/apache/fineract/pull/3358#issuecomment-1704445873 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] taskain7 opened a new pull request, #3423: [FINERACT-1958] Tests for interest not applied on down payment instal…

2023-09-03 Thread via GitHub
taskain7 opened a new pull request, #3423: URL: https://github.com/apache/fineract/pull/3423 …lment ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] github-actions[bot] closed pull request #3180: FINERACT-1013: Fixed validation of boolean input values

2023-09-05 Thread via GitHub
github-actions[bot] closed pull request #3180: FINERACT-1013: Fixed validation of boolean input values URL: https://github.com/apache/fineract/pull/3180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] galovics merged pull request #3432: Bump actions/checkout from 3.6.0 to 4.0.0

2023-09-06 Thread via GitHub
galovics merged PR #3432: URL: https://github.com/apache/fineract/pull/3432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] abhinav7sinha opened a new pull request, #3428: FINERACT-1932: Add custom Configuration class for delinquency module

2023-09-04 Thread via GitHub
abhinav7sinha opened a new pull request, #3428: URL: https://github.com/apache/fineract/pull/3428 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] dependabot[bot] opened a new pull request, #3432: Bump actions/checkout from 3.6.0 to 4.0.0

2023-09-04 Thread via GitHub
dependabot[bot] opened a new pull request, #3432: URL: https://github.com/apache/fineract/pull/3432 Bumps [actions/checkout](https://github.com/actions/checkout) from 3.6.0 to 4.0.0. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's

[GitHub] [fineract] adamsaghy merged pull request #3431: [FINERACT-1958] Tests for delinquency bucket on down payment installment

2023-09-05 Thread via GitHub
adamsaghy merged PR #3431: URL: https://github.com/apache/fineract/pull/3431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] dependabot[bot] opened a new pull request, #3436: Bump actions/upload-artifact from 3.1.2 to 3.1.3

2023-09-06 Thread via GitHub
dependabot[bot] opened a new pull request, #3436: URL: https://github.com/apache/fineract/pull/3436 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.2 to 3.1.3. Release notes Sourced from

[GitHub] [fineract] jdailey commented on pull request #3427: FINERACT-1968: Advanced payment allocation - Default allocation

2023-09-10 Thread via GitHub
jdailey commented on PR #3427: URL: https://github.com/apache/fineract/pull/3427#issuecomment-1712907577 This needs a section in the documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] faheem205 opened a new pull request, #3444: FINERACT-1973 Date picker in edit employee allows date before Office …

2023-09-10 Thread via GitHub
faheem205 opened a new pull request, #3444: URL: https://github.com/apache/fineract/pull/3444 …Opening Date ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] SubhamKrGuptaDev opened a new pull request, #3441: FinancialActivityData class bug fixed

2023-09-10 Thread via GitHub
SubhamKrGuptaDev opened a new pull request, #3441: URL: https://github.com/apache/fineract/pull/3441 Hi, I have seen FinancialActivityData This class doesn't have a constructor but 'convertToFinancialActivityData(final FinancialActivity type)' this method is try to inject value by

[GitHub] [fineract] reluxa opened a new pull request, #3442: FINERACT-1958 - reverse handling of disbursement with down payment

2023-09-10 Thread via GitHub
reluxa opened a new pull request, #3442: URL: https://github.com/apache/fineract/pull/3442 Reverse handling of disbursement with down payment ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache

[GitHub] [fineract] faheem205 opened a new pull request, #3443: FINERACT-1972 Fees and taxes deduction ordering in saving account tra…

2023-09-10 Thread via GitHub
faheem205 opened a new pull request, #3443: URL: https://github.com/apache/fineract/pull/3443 …nsactions page ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] faheem205 opened a new pull request, #3445: FINERACT-1974 Bulk Loan Reassignment fails with no error message

2023-09-10 Thread via GitHub
faheem205 opened a new pull request, #3445: URL: https://github.com/apache/fineract/pull/3445 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3411: FINERACT-1760: savings account externalId support

2023-09-11 Thread via GitHub
adamsaghy commented on code in PR #3411: URL: https://github.com/apache/fineract/pull/3411#discussion_r1321120748 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/DepositAccountAssembler.java: ## @@ -323,10 +324,10 @@ public SavingsAccount

[GitHub] [fineract] renovate-bot opened a new pull request, #3448: Update actions/checkout action to v4

2023-09-10 Thread via GitHub
renovate-bot opened a new pull request, #3448: URL: https://github.com/apache/fineract/pull/3448 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change |

[GitHub] [fineract] renovate-bot opened a new pull request, #3446: Update actions/checkout digest to f43a0e5

2023-09-10 Thread via GitHub
renovate-bot opened a new pull request, #3446: URL: https://github.com/apache/fineract/pull/3446 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change |

[GitHub] [fineract] renovate-bot opened a new pull request, #3447: Update actions/upload-artifact digest to a8a3f3a

2023-09-10 Thread via GitHub
renovate-bot opened a new pull request, #3447: URL: https://github.com/apache/fineract/pull/3447 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change |

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3411: FINERACT-1760: savings account externalId support

2023-09-11 Thread via GitHub
adamsaghy commented on code in PR #3411: URL: https://github.com/apache/fineract/pull/3411#discussion_r1321121511 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java: ## @@ -1662,10 +1664,10 @@ public void modifyApplication(final

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3411: FINERACT-1760: savings account externalId support

2023-09-11 Thread via GitHub
adamsaghy commented on code in PR #3411: URL: https://github.com/apache/fineract/pull/3411#discussion_r1321121033 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/DepositAccountAssembler.java: ## @@ -341,7 +342,7 @@ public SavingsAccount

[GitHub] [fineract] adamsaghy commented on pull request #3374: FINERACT-1932: Add custom Configuration class for tax service

2023-09-11 Thread via GitHub
adamsaghy commented on PR #3374: URL: https://github.com/apache/fineract/pull/3374#issuecomment-1713388766 @mmagdiab Please kindly check the below error: ``` (see https://errorprone.info/bugpattern/StringCaseLocaleUsage) Did you mean

[GitHub] [fineract] adamsaghy commented on pull request #3373: FINERACT-1932: Add custom Configuration class for transfer service

2023-09-11 Thread via GitHub
adamsaghy commented on PR #3373: URL: https://github.com/apache/fineract/pull/3373#issuecomment-1713385735 @mmagdiab Please kindly rebase this PR with the latest develop branch. The failing tests were already addressed. -- This is an automated message from the Apache Git Service. To

[GitHub] [fineract] adamsaghy merged pull request #3438: FINERACT-1958-Configuration-extending-schedule-with-downpayment

2023-09-11 Thread via GitHub
adamsaghy merged PR #3438: URL: https://github.com/apache/fineract/pull/3438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #3446: Update actions/checkout digest to f43a0e5

2023-09-11 Thread via GitHub
galovics merged PR #3446: URL: https://github.com/apache/fineract/pull/3446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] abraham-menyhart commented on a diff in pull request #3411: FINERACT-1760: savings account externalId support

2023-09-11 Thread via GitHub
abraham-menyhart commented on code in PR #3411: URL: https://github.com/apache/fineract/pull/3411#discussion_r1321706086 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java: ## @@ -1662,10 +1664,10 @@ public void

[GitHub] [fineract] galovics merged pull request #3434: FINERACT-1932: Add custom Configuration class for self-loanaccount mo…

2023-09-11 Thread via GitHub
galovics merged PR #3434: URL: https://github.com/apache/fineract/pull/3434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] renovate-bot closed pull request #3447: Update actions/upload-artifact digest to a8a3f3a - autoclosed

2023-09-11 Thread via GitHub
renovate-bot closed pull request #3447: Update actions/upload-artifact digest to a8a3f3a - autoclosed URL: https://github.com/apache/fineract/pull/3447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] galovics merged pull request #3448: Update actions/checkout action to v4

2023-09-11 Thread via GitHub
galovics merged PR #3448: URL: https://github.com/apache/fineract/pull/3448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #3439: FINERACT-1932: Add custom Configuration class for self-registration module

2023-09-11 Thread via GitHub
galovics merged PR #3439: URL: https://github.com/apache/fineract/pull/3439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #3440: FINERACT-1932: Add custom Configuration class for self-savings module

2023-09-11 Thread via GitHub
galovics merged PR #3440: URL: https://github.com/apache/fineract/pull/3440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #3359: FINERACT-1932: Add custom Configuration class for meeting service

2023-09-11 Thread via GitHub
galovics merged PR #3359: URL: https://github.com/apache/fineract/pull/3359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #3436: Bump actions/upload-artifact from 3.1.2 to 3.1.3

2023-09-11 Thread via GitHub
galovics merged PR #3436: URL: https://github.com/apache/fineract/pull/3436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] abraham-menyhart commented on a diff in pull request #3411: FINERACT-1760: savings account externalId support

2023-09-11 Thread via GitHub
abraham-menyhart commented on code in PR #3411: URL: https://github.com/apache/fineract/pull/3411#discussion_r1321592966 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java: ## @@ -1662,10 +1664,10 @@ public void

[GitHub] [fineract] adamsaghy merged pull request #3442: FINERACT-1958 - reverse handling of disbursement with down payment

2023-09-11 Thread via GitHub
adamsaghy merged PR #3442: URL: https://github.com/apache/fineract/pull/3442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3411: FINERACT-1760: savings account externalId support

2023-09-11 Thread via GitHub
adamsaghy commented on code in PR #3411: URL: https://github.com/apache/fineract/pull/3411#discussion_r1321645034 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java: ## @@ -1662,10 +1664,10 @@ public void modifyApplication(final

[GitHub] [fineract] galovics merged pull request #3422: FINERACT-1932: Add custom Configuration class for search module

2023-09-11 Thread via GitHub
galovics merged PR #3422: URL: https://github.com/apache/fineract/pull/3422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #3428: FINERACT-1932: Add custom Configuration class for delinquency module

2023-09-11 Thread via GitHub
galovics merged PR #3428: URL: https://github.com/apache/fineract/pull/3428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] marta-jankovics commented on pull request #3433: FINERACT-1931: Savings Account with overdraft - cannot deposit after …

2023-09-15 Thread via GitHub
marta-jankovics commented on PR #3433: URL: https://github.com/apache/fineract/pull/3433#issuecomment-1721494818 Test added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [fineract] marta-jankovics opened a new pull request, #3455: FINERACT-1976: Payment type permissions not working

2023-09-15 Thread via GitHub
marta-jankovics opened a new pull request, #3455: URL: https://github.com/apache/fineract/pull/3455 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] adamsaghy opened a new pull request, #3453: FINERACT-1975: BatchAPI - JSON handler cannot handle null (fix)

2023-09-14 Thread via GitHub
adamsaghy opened a new pull request, #3453: URL: https://github.com/apache/fineract/pull/3453 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] adamsaghy opened a new pull request, #3452: FINERACT-1724: Fix pagination

2023-09-14 Thread via GitHub
adamsaghy opened a new pull request, #3452: URL: https://github.com/apache/fineract/pull/3452 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] adamsaghy merged pull request #3451: FINERACT-1958-backdated-disbursement

2023-09-14 Thread via GitHub
adamsaghy merged PR #3451: URL: https://github.com/apache/fineract/pull/3451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] renovate-bot opened a new pull request, #3456: Update ghcr.io/navikt/mock-oauth2-server Docker tag to v2

2023-09-17 Thread via GitHub
renovate-bot opened a new pull request, #3456: URL: https://github.com/apache/fineract/pull/3456 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change |

[GitHub] [fineract] renovate-bot opened a new pull request, #3457: Update postgres Docker tag to v16

2023-09-17 Thread via GitHub
renovate-bot opened a new pull request, #3457: URL: https://github.com/apache/fineract/pull/3457 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change |

[GitHub] [fineract] adamsaghy merged pull request #3321: Fineract-1910 data table query advanced

2023-08-28 Thread via GitHub
adamsaghy merged PR #3321: URL: https://github.com/apache/fineract/pull/3321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] ruchiD opened a new pull request, #3407: FINERACT-1958-Overlapping-installment-payment-allocation

2023-08-28 Thread via GitHub
ruchiD opened a new pull request, #3407: URL: https://github.com/apache/fineract/pull/3407 ## Description Changes for payment allocation for overlapping downpayment and regular installment. Integration test Describe the changes made and why they were made. Ignore if

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3350: FINERACT-1926: Asset Externalization on Fineract

2023-09-01 Thread via GitHub
adamsaghy commented on code in PR #3350: URL: https://github.com/apache/fineract/pull/3350#discussion_r1312834856 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/investor/externalassetowner/ExternalAssetOwnerTransferTest.java: ## @@ -0,0 +1,410 @@ +/** +

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3350: FINERACT-1926: Asset Externalization on Fineract

2023-09-01 Thread via GitHub
adamsaghy commented on code in PR #3350: URL: https://github.com/apache/fineract/pull/3350#discussion_r1312834856 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/investor/externalassetowner/ExternalAssetOwnerTransferTest.java: ## @@ -0,0 +1,410 @@ +/** +

[GitHub] [fineract] adamsaghy merged pull request #3350: FINERACT-1926: Asset Externalization on Fineract

2023-09-01 Thread via GitHub
adamsaghy merged PR #3350: URL: https://github.com/apache/fineract/pull/3350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] github-actions[bot] commented on pull request #3337: FINERACT-1945

2023-09-01 Thread via GitHub
github-actions[bot] commented on PR #3337: URL: https://github.com/apache/fineract/pull/3337#issuecomment-1703539641 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] github-actions[bot] commented on pull request #3331: FINERACT-1956: Added the skeleton structure necessary to publish doc …

2023-09-01 Thread via GitHub
github-actions[bot] commented on PR #3331: URL: https://github.com/apache/fineract/pull/3331#issuecomment-1703539697 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] reluxa opened a new pull request, #3450: FINERACT-1971 - validation added for the case when advanced repayment strategy is used with empty or missing allocation rules.

2023-09-13 Thread via GitHub
reluxa opened a new pull request, #3450: URL: https://github.com/apache/fineract/pull/3450 - validation added for the case when advanced repayment strategy is used with empty or missing allocation rules. ## Description Describe the changes made and why they were made.

[GitHub] [fineract] adamsaghy merged pull request #3411: FINERACT-1760: savings account externalId support

2023-09-13 Thread via GitHub
adamsaghy merged PR #3411: URL: https://github.com/apache/fineract/pull/3411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] ruchiD opened a new pull request, #3451: FINERACT-1958-backdated-disbursement

2023-09-13 Thread via GitHub
ruchiD opened a new pull request, #3451: URL: https://github.com/apache/fineract/pull/3451 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] taskain7 opened a new pull request, #3449: [FINERACT-1958] Business events for down payment installments

2023-09-12 Thread via GitHub
taskain7 opened a new pull request, #3449: URL: https://github.com/apache/fineract/pull/3449 ## Description Installment data in events include if the isntallment is down payment. LoanTransactionEvenet is raised on auto payment on down paymnet. API changes if the installment is

[GitHub] [fineract] adamsaghy opened a new pull request, #3437: FINERACT-1968: Enhance Loan product template with advanced payment allocation

2023-09-07 Thread via GitHub
adamsaghy opened a new pull request, #3437: URL: https://github.com/apache/fineract/pull/3437 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] ruchiD opened a new pull request, #3438: FINERACT-1958-Configuration-extending-schedule-with-downpayment

2023-09-08 Thread via GitHub
ruchiD opened a new pull request, #3438: URL: https://github.com/apache/fineract/pull/3438 ## Description Changes for new loan product configuration for extending or not extending repayment schedule for downpayment Describe the changes made and why they were made. Ignore if

[GitHub] [fineract] mmagdiab opened a new pull request, #3440: FINERACT-1932: Add custom Configuration class for self-savings module

2023-09-09 Thread via GitHub
mmagdiab opened a new pull request, #3440: URL: https://github.com/apache/fineract/pull/3440 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] mmagdiab opened a new pull request, #3439: FINERACT-1932: Add custom Configuration class for self-registration module

2023-09-09 Thread via GitHub
mmagdiab opened a new pull request, #3439: URL: https://github.com/apache/fineract/pull/3439 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] josehernandezfintecheandomx commented on pull request #3350: FINERACT-1926: Asset Externalization on Fineract

2023-08-30 Thread via GitHub
josehernandezfintecheandomx commented on PR #3350: URL: https://github.com/apache/fineract/pull/3350#issuecomment-1699716373 > 1. HttpMessageNotReadableErrorController is okay, however i reckon we need an erorr handler to handle DateTimeParseException and provide back a valid error message

[GitHub] [fineract] abhinav7sinha opened a new pull request, #3418: FINERACT-1932: Add custom Configuration class for collectionsheet module

2023-08-30 Thread via GitHub
abhinav7sinha opened a new pull request, #3418: URL: https://github.com/apache/fineract/pull/3418 …932) ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] github-actions[bot] closed pull request #3226: FINERACT-1910 Support Pagination, sorting and filtering for Datatable

2023-08-30 Thread via GitHub
github-actions[bot] closed pull request #3226: FINERACT-1910 Support Pagination, sorting and filtering for Datatable URL: https://github.com/apache/fineract/pull/3226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [fineract] abhinav7sinha opened a new pull request, #3414: FINERACT-1932: Add custom Configuration class for collateral module

2023-08-29 Thread via GitHub
abhinav7sinha opened a new pull request, #3414: URL: https://github.com/apache/fineract/pull/3414 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] adamsaghy merged pull request #3410: FINERACT-1911: Assign Data Table to Transaction - validation

2023-08-31 Thread via GitHub
adamsaghy merged PR #3410: URL: https://github.com/apache/fineract/pull/3410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] abraham-menyhart commented on pull request #3411: FINERACT-1760: savings account externalId support

2023-08-31 Thread via GitHub
abraham-menyhart commented on PR #3411: URL: https://github.com/apache/fineract/pull/3411#issuecomment-1700892287 Thanks for your review @adamsaghy, I fixed the code according to your comments. Can you please review it again? -- This is an automated message from the Apache Git Service.

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3411: FINERACT-1760: savings account externalId support

2023-08-31 Thread via GitHub
adamsaghy commented on code in PR #3411: URL: https://github.com/apache/fineract/pull/3411#discussion_r1311569574 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountRepository.java: ## @@ -65,5 +66,8 @@ SavingsAccount

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3409: Fineract-1969: Datatable insert, update SQL Injection

2023-08-31 Thread via GitHub
adamsaghy commented on code in PR #3409: URL: https://github.com/apache/fineract/pull/3409#discussion_r1311616319 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/DateUtils.java: ## @@ -78,6 +79,14 @@ public static LocalDateTime

[GitHub] [fineract] adamsaghy commented on pull request #3411: FINERACT-1760: savings account externalId support

2023-08-31 Thread via GitHub
adamsaghy commented on PR #3411: URL: https://github.com/apache/fineract/pull/3411#issuecomment-1701060918 @abraham-menyhart Run './gradlew :integration-tests:spotlessApply' to fix these violations. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract] abraham-menyhart commented on a diff in pull request #3411: FINERACT-1760: savings account externalId support

2023-08-31 Thread via GitHub
abraham-menyhart commented on code in PR #3411: URL: https://github.com/apache/fineract/pull/3411#discussion_r1311648580 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountRepository.java: ## @@ -65,5 +66,8 @@ SavingsAccount

[GitHub] [fineract] adamsaghy merged pull request #3450: FINERACT-1971 - validation added for the case when advanced repayment strategy is used with empty or missing allocation rules.

2023-09-14 Thread via GitHub
adamsaghy merged PR #3450: URL: https://github.com/apache/fineract/pull/3450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3449: [FINERACT-1958] Business events for down payment installments

2023-09-14 Thread via GitHub
adamsaghy commented on code in PR #3449: URL: https://github.com/apache/fineract/pull/3449#discussion_r1325935247 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainServiceJpa.java: ## @@ -313,7 +311,7 @@ private

[GitHub] [fineract] github-actions[bot] commented on pull request #3338: FINERACT-1960: Add flag to Savings Charges to be recognized as accrual income

2023-09-14 Thread via GitHub
github-actions[bot] commented on PR #3338: URL: https://github.com/apache/fineract/pull/3338#issuecomment-1720312617 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] adamsaghy merged pull request #3452: FINERACT-1724: Fix pagination

2023-09-14 Thread via GitHub
adamsaghy merged PR #3452: URL: https://github.com/apache/fineract/pull/3452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy merged pull request #3453: FINERACT-1975: BatchAPI - JSON handler cannot handle null (fix)

2023-09-15 Thread via GitHub
adamsaghy merged PR #3453: URL: https://github.com/apache/fineract/pull/3453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] ruchiD opened a new pull request, #3454: FINERACT-1971-Loan-Product-modify-PUT-api-error-fix

2023-09-15 Thread via GitHub
ruchiD opened a new pull request, #3454: URL: https://github.com/apache/fineract/pull/3454 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] galovics opened a new pull request, #3424: FINERACT-1724: Made inline loan COB reader and processor job scoped to avoid state sharing

2023-09-04 Thread via GitHub
galovics opened a new pull request, #3424: URL: https://github.com/apache/fineract/pull/3424 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

  1   2   3   4   5   6   7   8   9   10   >