[GitHub] [hudi] helanto commented on a change in pull request #3740: [HUDI-2496] Insert duplicate keys when precombined is deactivated

2021-10-08 Thread GitBox
helanto commented on a change in pull request #3740: URL: https://github.com/apache/hudi/pull/3740#discussion_r725275190 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java ## @@ -257,6 +257,21 @@ private boolean

[GitHub] [hudi] helanto commented on a change in pull request #3740: [HUDI-2496] Insert duplicate keys when precombined is deactivated

2021-10-06 Thread GitBox
helanto commented on a change in pull request #3740: URL: https://github.com/apache/hudi/pull/3740#discussion_r723551743 ## File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSourceConsistentInserts.scala ## @@ -0,0 +1,86 @@ +/* +

[GitHub] [hudi] helanto commented on a change in pull request #3740: [HUDI-2496] Insert duplicate keys when precombined is deactivated

2021-10-06 Thread GitBox
helanto commented on a change in pull request #3740: URL: https://github.com/apache/hudi/pull/3740#discussion_r723551743 ## File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSourceConsistentInserts.scala ## @@ -0,0 +1,86 @@ +/* +

[GitHub] [hudi] helanto commented on a change in pull request #3740: [HUDI-2496] Insert duplicate keys when precombined is deactivated

2021-10-01 Thread GitBox
helanto commented on a change in pull request #3740: URL: https://github.com/apache/hudi/pull/3740#discussion_r720090162 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieConcatHandle.java ## @@ -94,4 +107,34 @@ public void

[GitHub] [hudi] helanto commented on a change in pull request #3740: [HUDI-2496] Insert duplicate keys when precombined is deactivated

2021-10-01 Thread GitBox
helanto commented on a change in pull request #3740: URL: https://github.com/apache/hudi/pull/3740#discussion_r720083666 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieConcatHandle.java ## @@ -94,4 +107,34 @@ public void