[GitHub] [hudi] lw309637554 commented on a change in pull request #1756: [HUDI-839] Adding unit test for MarkerFiles,RollbackUtils, RollbackActionExecutor for markers and filelisting

lw309637554 commented on a change in pull request #1756: URL: https://github.com/apache/hudi/pull/1756#discussion_r455475745 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/rollback/ListingBasedRollbackHelper.java ## @@ -182,12 +162,12 @@ private

[GitHub] [hudi] lw309637554 commented on a change in pull request #1756: [HUDI-839] Adding unit test for MarkerFiles,RollbackUtils, RollbackActionExecutor for markers and filelisting

lw309637554 commented on a change in pull request #1756: URL: https://github.com/apache/hudi/pull/1756#discussion_r455474421 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/rollback/ListingBasedRollbackHelper.java ## @@ -182,12 +162,12 @@ private

[GitHub] [hudi] lw309637554 commented on a change in pull request #1756: [HUDI-839] Adding unit test for MarkerFiles,RollbackUtils, RollbackActionExecutor for markers and filelisting

lw309637554 commented on a change in pull request #1756: URL: https://github.com/apache/hudi/pull/1756#discussion_r449948557 ## File path: hudi-client/src/test/java/org/apache/hudi/table/action/rollback/TestCopyOnWriteRollbackActionExecutor.java ## @@ -0,0 +1,247 @@ +/* + *

[GitHub] [hudi] lw309637554 commented on a change in pull request #1756: [HUDI-839] Adding unit test for MarkerFiles,RollbackUtils, RollbackActionExecutor for markers and filelisting

lw309637554 commented on a change in pull request #1756: URL: https://github.com/apache/hudi/pull/1756#discussion_r449947875 ## File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java ## @@ -97,28 +98,9 @@ public Path makeNewPath(String partitionPath) {

[GitHub] [hudi] lw309637554 commented on a change in pull request #1756: [HUDI-839] Adding unit test for MarkerFiles,RollbackUtils, RollbackActionExecutor for markers and filelisting

lw309637554 commented on a change in pull request #1756: URL: https://github.com/apache/hudi/pull/1756#discussion_r449948302 ## File path: hudi-client/src/test/java/org/apache/hudi/table/action/rollback/TestMergeOnReadRollbackActionExecutor.java ## @@ -0,0 +1,211 @@ +/* + *

[GitHub] [hudi] lw309637554 commented on a change in pull request #1756: [HUDI-839] Adding unit test for MarkerFiles,RollbackUtils, RollbackActionExecutor for markers and filelisting

lw309637554 commented on a change in pull request #1756: URL: https://github.com/apache/hudi/pull/1756#discussion_r449948082 ## File path: hudi-client/src/test/java/org/apache/hudi/table/TestHoodieMergeOnReadTable.java ## @@ -445,10 +442,20 @@ public void

[GitHub] [hudi] lw309637554 commented on a change in pull request #1756: [HUDI-839] Adding unit test for MarkerFiles,RollbackUtils, RollbackActionExecutor for markers and filelisting

lw309637554 commented on a change in pull request #1756: URL: https://github.com/apache/hudi/pull/1756#discussion_r449947875 ## File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java ## @@ -97,28 +98,9 @@ public Path makeNewPath(String partitionPath) {

[GitHub] [hudi] lw309637554 commented on a change in pull request #1756: [HUDI-839] Adding unit test for MarkerFiles,RollbackUtils, RollbackActionExecutor for markers and filelisting

lw309637554 commented on a change in pull request #1756: URL: https://github.com/apache/hudi/pull/1756#discussion_r449947972 ## File path: hudi-client/src/test/java/org/apache/hudi/table/TestCleaner.java ## @@ -904,6 +901,19 @@ public void testCleanMarkerDataFilesOnRollback()

[GitHub] [hudi] lw309637554 commented on a change in pull request #1756: [HUDI-839] Adding unit test for MarkerFiles,RollbackUtils, RollbackActionExecutor for markers and filelisting

lw309637554 commented on a change in pull request #1756: URL: https://github.com/apache/hudi/pull/1756#discussion_r449947922 ## File path: hudi-client/src/main/java/org/apache/hudi/table/action/rollback/ListingBasedRollbackHelper.java ## @@ -54,29 +53,28 @@ /** * Performs

[GitHub] [hudi] lw309637554 commented on a change in pull request #1756: [HUDI-839] Adding unit test for MarkerFiles,RollbackUtils, RollbackActionExecutor for markers and filelisting

lw309637554 commented on a change in pull request #1756: URL: https://github.com/apache/hudi/pull/1756#discussion_r449947358 ## File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java ## @@ -113,8 +109,9 @@ private void init(String fileId, String

[GitHub] [hudi] lw309637554 commented on a change in pull request #1756: [HUDI-839] Adding unit test for MarkerFiles,RollbackUtils, RollbackActionExecutor for markers and filelisting

lw309637554 commented on a change in pull request #1756: URL: https://github.com/apache/hudi/pull/1756#discussion_r449946532 ## File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java ## @@ -278,6 +286,11 @@ public WriteStatus getWriteStatus() {

[GitHub] [hudi] lw309637554 commented on a change in pull request #1756: [HUDI-839] Adding unit test for MarkerFiles,RollbackUtils, RollbackActionExecutor for markers and filelisting

lw309637554 commented on a change in pull request #1756: URL: https://github.com/apache/hudi/pull/1756#discussion_r449946413 ## File path: hudi-client/src/main/java/org/apache/hudi/client/HoodieWriteClient.java ## @@ -332,9 +333,11 @@ public static SparkConf