[GitHub] [hudi] yihua commented on a change in pull request #3743: [HUDI-2513] Refactor table upgrade and downgrade actions in hudi-client module

2021-10-06 Thread GitBox
yihua commented on a change in pull request #3743: URL: https://github.com/apache/hudi/pull/3743#discussion_r722944964 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngrade.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the

[GitHub] [hudi] yihua commented on a change in pull request #3743: [HUDI-2513] Refactor table upgrade and downgrade actions in hudi-client module

2021-10-06 Thread GitBox
yihua commented on a change in pull request #3743: URL: https://github.com/apache/hudi/pull/3743#discussion_r722939258 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngrade.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the

[GitHub] [hudi] yihua commented on a change in pull request #3743: [HUDI-2513] Refactor table upgrade and downgrade actions in hudi-client module

2021-10-06 Thread GitBox
yihua commented on a change in pull request #3743: URL: https://github.com/apache/hudi/pull/3743#discussion_r722938371 ## File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/FlinkTaskContextSupplier.java ## @@ -62,4 +64,9 @@ public RuntimeContext

[GitHub] [hudi] yihua commented on a change in pull request #3743: [HUDI-2513] Refactor table upgrade and downgrade actions in hudi-client module

2021-10-06 Thread GitBox
yihua commented on a change in pull request #3743: URL: https://github.com/apache/hudi/pull/3743#discussion_r722937716 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngrade.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the

[GitHub] [hudi] yihua commented on a change in pull request #3743: [HUDI-2513] Refactor table upgrade and downgrade actions in hudi-client module

2021-10-06 Thread GitBox
yihua commented on a change in pull request #3743: URL: https://github.com/apache/hudi/pull/3743#discussion_r722936410 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/RollbackUtils.java ## @@ -120,21 +120,24 @@ static

[GitHub] [hudi] yihua commented on a change in pull request #3743: [HUDI-2513] Refactor table upgrade and downgrade actions in hudi-client module

2021-10-06 Thread GitBox
yihua commented on a change in pull request #3743: URL: https://github.com/apache/hudi/pull/3743#discussion_r722936242 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/marker/WriteMarkersFactory.java ## @@ -34,24 +36,28 @@ private static

[GitHub] [hudi] yihua commented on a change in pull request #3743: [HUDI-2513] Refactor table upgrade and downgrade actions in hudi-client module

2021-10-06 Thread GitBox
yihua commented on a change in pull request #3743: URL: https://github.com/apache/hudi/pull/3743#discussion_r722935917 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/ListingBasedRollbackStrategy.java ## @@ -63,7 +63,8 @@