[jira] [Commented] (HUDI-590) Cut a new Doc version 0.5.1 explicitly
[ https://issues.apache.org/jira/browse/HUDI-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032167#comment-17032167 ] Bhavani Sudha commented on HUDI-590: [~xleesf] There are couple minor query side doc changes needed. I spotted few. I ll send PR for them. Along with that I ll also cut this 0.5.1 version directory for docs. > Cut a new Doc version 0.5.1 explicitly > -- > > Key: HUDI-590 > URL: https://issues.apache.org/jira/browse/HUDI-590 > Project: Apache Hudi (incubating) > Issue Type: Task > Components: Docs, Release Administrative >Reporter: Bhavani Sudha >Assignee: Bhavani Sudha >Priority: Major > > The latest version of docs needs to be tagged as 0.5.1 explicitly in the > site. Follow instructions in > [https://github.com/apache/incubator-hudi/blob/asf-site/README.md#updating-site] > to create a new dir 0.5.1 under docs/_docs/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HUDI-590) Cut a new Doc version 0.5.1 explicitly
[ https://issues.apache.org/jira/browse/HUDI-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bhavani Sudha updated HUDI-590: --- Status: In Progress (was: Open) > Cut a new Doc version 0.5.1 explicitly > -- > > Key: HUDI-590 > URL: https://issues.apache.org/jira/browse/HUDI-590 > Project: Apache Hudi (incubating) > Issue Type: Task > Components: Docs, Release Administrative >Reporter: Bhavani Sudha >Assignee: Bhavani Sudha >Priority: Major > > The latest version of docs needs to be tagged as 0.5.1 explicitly in the > site. Follow instructions in > [https://github.com/apache/incubator-hudi/blob/asf-site/README.md#updating-site] > to create a new dir 0.5.1 under docs/_docs/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-554) Restructure code/packages to move more code back into hudi-writer-common
[ https://issues.apache.org/jira/browse/HUDI-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032164#comment-17032164 ] vinoyang commented on HUDI-554: --- Got it! cc [~xleesf] > Restructure code/packages to move more code back into hudi-writer-common > - > > Key: HUDI-554 > URL: https://issues.apache.org/jira/browse/HUDI-554 > Project: Apache Hudi (incubating) > Issue Type: Sub-task > Components: Code Cleanup >Reporter: Vinoth Chandar >Assignee: Vinoth Chandar >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HUDI-602) Add some guidance about how to judge the scope of MINOR to the contribution guidance
[ https://issues.apache.org/jira/browse/HUDI-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang resolved HUDI-602. --- Resolution: Done Done via asf-site branch: b1bb7b0e050b2d7acfb7c5bccdbc2a98e6a35743 > Add some guidance about how to judge the scope of MINOR to the contribution > guidance > > > Key: HUDI-602 > URL: https://issues.apache.org/jira/browse/HUDI-602 > Project: Apache Hudi (incubating) > Issue Type: Improvement > Components: Docs >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Currently, The semantic and the scope of "MINOR" pr is not a bit clear. Some > big change should not be a "MINOR" pr. We need some guidance to tell > contributors how to judge what kind of PRs belongs "MINOR" pr. > There is a thread on hudi dev mailing list talking about this topic: > https://lists.apache.org/thread.html/rc77546c7de7b2fa40330f889ed39dec7c0ab335e30e93d25745508ef%40%3Cdev.hudi.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HUDI-602) Add some guidance about how to judge the scope of MINOR to the contribution guidance
[ https://issues.apache.org/jira/browse/HUDI-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated HUDI-602: -- Status: Open (was: New) > Add some guidance about how to judge the scope of MINOR to the contribution > guidance > > > Key: HUDI-602 > URL: https://issues.apache.org/jira/browse/HUDI-602 > Project: Apache Hudi (incubating) > Issue Type: Improvement > Components: Docs >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Currently, The semantic and the scope of "MINOR" pr is not a bit clear. Some > big change should not be a "MINOR" pr. We need some guidance to tell > contributors how to judge what kind of PRs belongs "MINOR" pr. > There is a thread on hudi dev mailing list talking about this topic: > https://lists.apache.org/thread.html/rc77546c7de7b2fa40330f889ed39dec7c0ab335e30e93d25745508ef%40%3Cdev.hudi.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-hudi] yanghua merged pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
yanghua merged pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-hudi] branch asf-site updated: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance (#1311)
This is an automated email from the ASF dual-hosted git repository. vinoyang pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git The following commit(s) were added to refs/heads/asf-site by this push: new b1bb7b0 [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance (#1311) b1bb7b0 is described below commit b1bb7b0e050b2d7acfb7c5bccdbc2a98e6a35743 Author: vinoyang AuthorDate: Fri Feb 7 15:00:43 2020 +0800 [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance (#1311) * [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance --- docs/_pages/contributing.cn.md | 6 +- docs/_pages/contributing.md| 6 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/docs/_pages/contributing.cn.md b/docs/_pages/contributing.cn.md index 9e017ad..e66deea 100644 --- a/docs/_pages/contributing.cn.md +++ b/docs/_pages/contributing.cn.md @@ -88,7 +88,11 @@ and more importantly also try to improve the process along the way as well. - Once you finalize on a project/task, please open a new JIRA or assign an existing one to yourself. - Almost all PRs should be linked to a JIRA. It's always good to have a JIRA upfront to avoid duplicating efforts. - - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. + - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. Below are some tips to judge **MINOR** Pull Request : +- trivial fixes (for example, a typo, a broken link, intellisense or an obvious error) +- the change does not alter functionality or performance in any way +- changed lines less than 100 +- obviously judge that the PR would pass without waiting for CI / CD verification - But, you may be asked to file a JIRA, if reviewer deems it necessary - Before you begin work, - Claim the JIRA using the process above and assign the JIRA to yourself. diff --git a/docs/_pages/contributing.md b/docs/_pages/contributing.md index 3745edd..9d84872 100644 --- a/docs/_pages/contributing.md +++ b/docs/_pages/contributing.md @@ -87,7 +87,11 @@ and more importantly also try to improve the process along the way as well. - Once you finalize on a project/task, please open a new JIRA or assign an existing one to yourself. - Almost all PRs should be linked to a JIRA. It's always good to have a JIRA upfront to avoid duplicating efforts. - - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. + - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. Below are some tips to judge **MINOR** Pull Request : +- trivial fixes (for example, a typo, a broken link, intellisense or an obvious error) +- the change does not alter functionality or performance in any way +- changed lines less than 100 +- obviously judge that the PR would pass without waiting for CI / CD verification - But, you may be asked to file a JIRA, if reviewer deems it necessary - Before you begin work, - Claim the JIRA using the process above and assign the JIRA to yourself.
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1149: [WIP] [HUDI-472] Introduce configurations and new modes of sorting for bulk_insert
vinothchandar commented on a change in pull request #1149: [WIP] [HUDI-472]
Introduce configurations and new modes of sorting for bulk_insert
URL: https://github.com/apache/incubator-hudi/pull/1149#discussion_r376236746
##
File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
##
@@ -381,20 +384,30 @@ public static SparkConf registerClasses(SparkConf conf) {
}
}
+ private BulkInsertMapFunction getBulkInsertMapFunction(
Review comment:
I was looking at this for a different JIRA. but having a class for
BulkInsertMapfunction seems like an overkill? Can we just replace with lambdas
and kill the class ?
eg, in the code on master, just change to below
```
JavaRDD writeStatusRDD = repartitionedRecords
.mapPartitionsWithIndex((partition, recordItr) ->
new CopyOnWriteLazyInsertIterable<>(recordItr, config,
commitTime, table, fileIDPrefixes.get(partition)), true)
.flatMap(List::iterator);
```
if you agree, just do it in the PR.. that way I wont introduce an
unnecessary rebase for you :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1149: [WIP] [HUDI-472] Introduce configurations and new modes of sorting for bulk_insert
vinothchandar commented on a change in pull request #1149: [WIP] [HUDI-472]
Introduce configurations and new modes of sorting for bulk_insert
URL: https://github.com/apache/incubator-hudi/pull/1149#discussion_r376236783
##
File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
##
@@ -381,20 +384,30 @@ public static SparkConf registerClasses(SparkConf conf) {
}
}
+ private BulkInsertMapFunction getBulkInsertMapFunction(
Review comment:
cc @yihua
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HUDI-553) Building/Running Hudi on higher java versions
[ https://issues.apache.org/jira/browse/HUDI-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032145#comment-17032145 ] Raymond Xu commented on HUDI-553: - [~vinoth] i'd love to but i'm having some bandwith issue.. i may come back later to this if no one picks this up. > Building/Running Hudi on higher java versions > - > > Key: HUDI-553 > URL: https://issues.apache.org/jira/browse/HUDI-553 > Project: Apache Hudi (incubating) > Issue Type: Task > Components: Usability >Reporter: Vinoth Chandar >Priority: Major > Fix For: 0.6.0 > > > [https://github.com/apache/incubator-hudi/issues/1235] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HUDI-554) Restructure code/packages to move more code back into hudi-writer-common
[ https://issues.apache.org/jira/browse/HUDI-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032142#comment-17032142 ] Vinoth Chandar commented on HUDI-554: - fyi [~yanghua] I am starting on this one.. > Restructure code/packages to move more code back into hudi-writer-common > - > > Key: HUDI-554 > URL: https://issues.apache.org/jira/browse/HUDI-554 > Project: Apache Hudi (incubating) > Issue Type: Sub-task > Components: Code Cleanup >Reporter: Vinoth Chandar >Assignee: Vinoth Chandar >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HUDI-554) Restructure code/packages to move more code back into hudi-writer-common
[ https://issues.apache.org/jira/browse/HUDI-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar updated HUDI-554: Status: Open (was: New) > Restructure code/packages to move more code back into hudi-writer-common > - > > Key: HUDI-554 > URL: https://issues.apache.org/jira/browse/HUDI-554 > Project: Apache Hudi (incubating) > Issue Type: Sub-task > Components: Code Cleanup >Reporter: Vinoth Chandar >Assignee: Vinoth Chandar >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HUDI-554) Restructure code/packages to move more code back into hudi-writer-common
[ https://issues.apache.org/jira/browse/HUDI-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar updated HUDI-554: Status: In Progress (was: Open) > Restructure code/packages to move more code back into hudi-writer-common > - > > Key: HUDI-554 > URL: https://issues.apache.org/jira/browse/HUDI-554 > Project: Apache Hudi (incubating) > Issue Type: Sub-task > Components: Code Cleanup >Reporter: Vinoth Chandar >Assignee: Vinoth Chandar >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-hudi] liujianhuiouc commented on issue #1216: [HUDI-525] lack of insert info in delta_commit inflight
liujianhuiouc commented on issue #1216: [HUDI-525] lack of insert info in delta_commit inflight URL: https://github.com/apache/incubator-hudi/pull/1216#issuecomment-583253681 @n3nash I'm sorry to reply so late, i have fix that with HoodieWriteStat.NULL_COMMIT This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
vinothchandar commented on issue #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311#issuecomment-583249124 Please go ahead merge when ready @yanghua This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
yanghua commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311#discussion_r376186088 ## File path: docs/_pages/contributing.cn.md ## @@ -88,7 +88,11 @@ and more importantly also try to improve the process along the way as well. - Once you finalize on a project/task, please open a new JIRA or assign an existing one to yourself. - Almost all PRs should be linked to a JIRA. It's always good to have a JIRA upfront to avoid duplicating efforts. - - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. + - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. Below are some tips to judge **MINOR** Pull Request : +- trivial fixes (for example, a typo, a broken link, intellisense or an obvious error) +- the change is not functionality relevant Review comment: Have addressed your two suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
yanghua commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311#discussion_r376184198 ## File path: docs/_pages/contributing.cn.md ## @@ -88,7 +88,11 @@ and more importantly also try to improve the process along the way as well. - Once you finalize on a project/task, please open a new JIRA or assign an existing one to yourself. - Almost all PRs should be linked to a JIRA. It's always good to have a JIRA upfront to avoid duplicating efforts. - - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. + - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. There are some tips to help to judge **MINOR** Pull Request : +- trivial fixes (for example, a typo, a broken link or an obvious error) +- the change is not functionality relevant +- changed lines less than 50 Review comment: agree too This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
pratyakshsharma commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311#discussion_r376064490 ## File path: docs/_pages/contributing.cn.md ## @@ -88,7 +88,11 @@ and more importantly also try to improve the process along the way as well. - Once you finalize on a project/task, please open a new JIRA or assign an existing one to yourself. - Almost all PRs should be linked to a JIRA. It's always good to have a JIRA upfront to avoid duplicating efforts. - - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. + - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. There are some tips to help to judge **MINOR** Pull Request : +- trivial fixes (for example, a typo, a broken link or an obvious error) +- the change is not functionality relevant +- changed lines less than 50 Review comment: I was trying to raise a similar point :) I was thinking since anyways this needs mentor's/reviewer's approval, so may be we could do away with this tip here. :) But this is a valid point that mentioning the limit will help make the contributor aware that MINOR PR is supposed to have limited changes. LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HUDI-603) HoodieDeltaStreamer should periodically fetch table schema update
Yixue Zhu created HUDI-603: -- Summary: HoodieDeltaStreamer should periodically fetch table schema update Key: HUDI-603 URL: https://issues.apache.org/jira/browse/HUDI-603 Project: Apache Hudi (incubating) Issue Type: Bug Components: DeltaStreamer Reporter: Yixue Zhu HoodieDeltaStreamer create SchemaProvider instance and delegate to DeltaSync for periodical sync. However, default implementation of SchemaProvider does not refresh schema, which can change due to schema evolution. DeltaSync snapshot the schema when it creates writeClient, using the SchemaProvider instance or pick up from source, and the schema for writeClient is not refreshed during the loop of Sync. I think this needs to be addressed to support schema evolution fully. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
vinothchandar commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311#discussion_r375999410 ## File path: docs/_pages/contributing.cn.md ## @@ -88,7 +88,11 @@ and more importantly also try to improve the process along the way as well. - Once you finalize on a project/task, please open a new JIRA or assign an existing one to yourself. - Almost all PRs should be linked to a JIRA. It's always good to have a JIRA upfront to avoid duplicating efforts. - - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. + - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. Below are some tips to judge **MINOR** Pull Request : +- trivial fixes (for example, a typo, a broken link, intellisense or an obvious error) +- the change is not functionality relevant Review comment: nit: the change does not alter functionality or performance in any way This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
vinothchandar commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311#discussion_r375998821 ## File path: docs/_pages/contributing.cn.md ## @@ -88,7 +88,11 @@ and more importantly also try to improve the process along the way as well. - Once you finalize on a project/task, please open a new JIRA or assign an existing one to yourself. - Almost all PRs should be linked to a JIRA. It's always good to have a JIRA upfront to avoid duplicating efforts. - - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. + - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. There are some tips to help to judge **MINOR** Pull Request : +- trivial fixes (for example, a typo, a broken link or an obvious error) +- the change is not functionality relevant +- changed lines less than 50 Review comment: We could make the limit larger to say 100.. may be? but I do feel there should be a limit. we are not saying we won't take larger code changes. Just saying if someone is going to change 300 files and cause everyone to rebase/resolve conflicts, lets have them file a JIRA and get some consensus.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
yanghua commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311#discussion_r375824665 ## File path: docs/_pages/contributing.cn.md ## @@ -88,7 +88,11 @@ and more importantly also try to improve the process along the way as well. - Once you finalize on a project/task, please open a new JIRA or assign an existing one to yourself. - Almost all PRs should be linked to a JIRA. It's always good to have a JIRA upfront to avoid duplicating efforts. - - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. + - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. There are some tips to help to judge **MINOR** Pull Request : +- trivial fixes (for example, a typo, a broken link or an obvious error) Review comment: Ok, let me add it as a kind of example. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
pratyakshsharma commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311#discussion_r375822561 ## File path: docs/_pages/contributing.cn.md ## @@ -88,7 +88,11 @@ and more importantly also try to improve the process along the way as well. - Once you finalize on a project/task, please open a new JIRA or assign an existing one to yourself. - Almost all PRs should be linked to a JIRA. It's always good to have a JIRA upfront to avoid duplicating efforts. - - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. + - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. There are some tips to help to judge **MINOR** Pull Request : +- trivial fixes (for example, a typo, a broken link or an obvious error) Review comment: @yanghua I was referring to intellisense i.e we can mention it like - trivial fixes (for example, a typo, a broken link, intellisense or an obvious error) Let me know if it makes sense. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
yanghua commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311#discussion_r375789475 ## File path: docs/_pages/contributing.cn.md ## @@ -88,7 +88,11 @@ and more importantly also try to improve the process along the way as well. - Once you finalize on a project/task, please open a new JIRA or assign an existing one to yourself. - Almost all PRs should be linked to a JIRA. It's always good to have a JIRA upfront to avoid duplicating efforts. - - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. + - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. There are some tips to help to judge **MINOR** Pull Request : +- trivial fixes (for example, a typo, a broken link or an obvious error) +- the change is not functionality relevant +- changed lines less than 50 Review comment: Maybe your opinion is reasonable. The number of lines is only for reference. The main factor should be the content that the PR changed. Let's listen to @vinothchandar 's opinion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
yanghua commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311#discussion_r375784708 ## File path: docs/_pages/contributing.cn.md ## @@ -88,7 +88,11 @@ and more importantly also try to improve the process along the way as well. - Once you finalize on a project/task, please open a new JIRA or assign an existing one to yourself. - Almost all PRs should be linked to a JIRA. It's always good to have a JIRA upfront to avoid duplicating efforts. - - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. + - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. There are some tips to help to judge **MINOR** Pull Request : +- trivial fixes (for example, a typo, a broken link or an obvious error) Review comment: > may be we should add IDE suggestions also here? What's the meaning of "suggestions" that you mentioned? If you mean our discussion on the thread(`[DISCUSS] Unify Hudi code cleanup and improvement `) of the mailing list. I would suggest filing jira issues. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] pratyakshsharma commented on issue #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
pratyakshsharma commented on issue #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311#issuecomment-582850274 Looks good overall to me @yanghua, only left minor comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
pratyakshsharma commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311#discussion_r375768601 ## File path: docs/_pages/contributing.cn.md ## @@ -88,7 +88,11 @@ and more importantly also try to improve the process along the way as well. - Once you finalize on a project/task, please open a new JIRA or assign an existing one to yourself. - Almost all PRs should be linked to a JIRA. It's always good to have a JIRA upfront to avoid duplicating efforts. - - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. + - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. There are some tips to help to judge **MINOR** Pull Request : Review comment: I guess it would look better with - "Below are some tips to judge **MINOR** Pull Request"? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
pratyakshsharma commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311#discussion_r375765642 ## File path: docs/_pages/contributing.cn.md ## @@ -88,7 +88,11 @@ and more importantly also try to improve the process along the way as well. - Once you finalize on a project/task, please open a new JIRA or assign an existing one to yourself. - Almost all PRs should be linked to a JIRA. It's always good to have a JIRA upfront to avoid duplicating efforts. - - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. + - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. There are some tips to help to judge **MINOR** Pull Request : +- trivial fixes (for example, a typo, a broken link or an obvious error) +- the change is not functionality relevant +- changed lines less than 50 Review comment: Now I am skeptical of actually quantifying a MINOR PR based on the number of lines. Just by following IDE suggestions, one might modify more than 50-60 lines of code and still it can be considered as a MINOR PR. I guess it is better to not mention number of lines here. Open to hearing others' suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
pratyakshsharma commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311#discussion_r375764388 ## File path: docs/_pages/contributing.cn.md ## @@ -88,7 +88,11 @@ and more importantly also try to improve the process along the way as well. - Once you finalize on a project/task, please open a new JIRA or assign an existing one to yourself. - Almost all PRs should be linked to a JIRA. It's always good to have a JIRA upfront to avoid duplicating efforts. - - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. + - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. There are some tips to help to judge **MINOR** Pull Request : +- trivial fixes (for example, a typo, a broken link or an obvious error) Review comment: may be we should add IDE suggestions also here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
yanghua commented on issue #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311#issuecomment-582802669 I cannot find a good way to show these tips. I am open to listening to suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HUDI-602) Add some guidance about how to judge the scope of MINOR to the contribution guidance
[ https://issues.apache.org/jira/browse/HUDI-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-602: Labels: pull-request-available (was: ) > Add some guidance about how to judge the scope of MINOR to the contribution > guidance > > > Key: HUDI-602 > URL: https://issues.apache.org/jira/browse/HUDI-602 > Project: Apache Hudi (incubating) > Issue Type: Improvement > Components: Docs >Reporter: vinoyang >Assignee: vinoyang >Priority: Major > Labels: pull-request-available > > Currently, The semantic and the scope of "MINOR" pr is not a bit clear. Some > big change should not be a "MINOR" pr. We need some guidance to tell > contributors how to judge what kind of PRs belongs "MINOR" pr. > There is a thread on hudi dev mailing list talking about this topic: > https://lists.apache.org/thread.html/rc77546c7de7b2fa40330f889ed39dec7c0ab335e30e93d25745508ef%40%3Cdev.hudi.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-hudi] yanghua opened a new pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
yanghua opened a new pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311 ## What is the purpose of the pull request *This pull request adds some guidance about how to judge the scope of MINOR to the contribution guidance* ## Brief change log - *Add some guidance about how to judge the scope of MINOR to the contribution guidance* ## Verify this pull request This pull request is a trivial rework / code cleanup without any test coverage. ## Committer checklist - [ ] Has a corresponding JIRA in PR title & commit - [ ] Commit message is descriptive of the change - [ ] CI is green - [ ] Necessary doc changes done or have another open PR - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
