Re: [PR] [HUDI-7503] Compaction and LogCompaction executions should start a heartbeat on every attempt and block concurrent executions of same plan [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10965: URL: https://github.com/apache/hudi/pull/10965#issuecomment-2040959029 ## CI report: * c8e268903a19c7ecc5cd927fd8afa3332a1c3aea Azure:

Re: [PR] [HUDI-7503] Compaction and LogCompaction executions should start a heartbeat on every attempt and block concurrent executions of same plan [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10965: URL: https://github.com/apache/hudi/pull/10965#issuecomment-2040940759 ## CI report: * 54e443683a42e1a59f533a50f98abb4dc0583ea7 Azure:

Re: [PR] [HUDI-7503] Compaction and LogCompaction executions should start a heartbeat on every attempt and block concurrent executions of same plan [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10965: URL: https://github.com/apache/hudi/pull/10965#issuecomment-2040929959 ## CI report: * 54e443683a42e1a59f533a50f98abb4dc0583ea7 Azure:

Re: [PR] [HUDI-6854] Change default payload type to HOODIE_AVRO_DEFAULT [hudi]

2024-04-05 Thread via GitHub
wombatu-kun commented on code in PR #10949: URL: https://github.com/apache/hudi/pull/10949#discussion_r1554482596 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/ddl/TestSpark3DDL.scala: ## @@ -742,6 +744,8 @@ class TestSpark3DDL extends

Re: [PR] [HUDI-7503] Compaction and LogCompaction executions should start a heartbeat on every attempt and block concurrent executions of same plan [hudi]

2024-04-05 Thread via GitHub
danny0405 commented on code in PR #10965: URL: https://github.com/apache/hudi/pull/10965#discussion_r1554475930 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java: ## @@ -1135,8 +1138,36 @@ protected void

Re: [PR] [HUDI-7503] Compaction and LogCompaction executions should start a heartbeat on every attempt and block concurrent executions of same plan [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10965: URL: https://github.com/apache/hudi/pull/10965#issuecomment-2040845295 ## CI report: * 54e443683a42e1a59f533a50f98abb4dc0583ea7 Azure:

Re: [PR] [HUDI-7503] Compaction and LogCompaction executions should start a heartbeat on every attempt and block concurrent executions of same plan [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10965: URL: https://github.com/apache/hudi/pull/10965#issuecomment-2040842997 ## CI report: * ddd6cf2655e073aacd3b48de126781abacd7e111 Azure:

Re: [PR] [HUDI-6854] Change default payload type to HOODIE_AVRO_DEFAULT [hudi]

2024-04-05 Thread via GitHub
danny0405 commented on code in PR #10949: URL: https://github.com/apache/hudi/pull/10949#discussion_r1554469272 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/ddl/TestSpark3DDL.scala: ## @@ -742,6 +744,8 @@ class TestSpark3DDL extends

(hudi) branch master updated: [MINOR] Handle cases of malformed records when converting to json (#10943)

2024-04-05 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new d41541cb9f8 [MINOR] Handle cases of malformed

Re: [PR] [MINOR] Handle cases of malformed records when converting to json [hudi]

2024-04-05 Thread via GitHub
danny0405 merged PR #10943: URL: https://github.com/apache/hudi/pull/10943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [DO NOT MERGE][HUDI-7566] Add schema evolution to spark file readers [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10956: URL: https://github.com/apache/hudi/pull/10956#issuecomment-2040805995 ## CI report: * 088f69ed54db32d1686caa4f457f6fc9aed0 Azure:

Re: [PR] [HUDI-7565] Create spark file readers to read a single file instead of an entire partition [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10954: URL: https://github.com/apache/hudi/pull/10954#issuecomment-2040805972 ## CI report: * 8ca12f25bce0d5cfb2dc56785db076e0fa90df33 Azure:

Re: [PR] [HUDI-7235] Fix checkpoint bug for S3/GCS Incremental Source [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10336: URL: https://github.com/apache/hudi/pull/10336#issuecomment-2040753004 ## CI report: * de49a9da9db751d6fd6e0eaa1a750f8726a55018 UNKNOWN * 1bb5e222b29e392a69ef2ff0a4c990ba0ad7219d Azure:

[jira] [Updated] (HUDI-7507) ongoing concurrent writers with smaller timestamp can cause issues with table services

2024-04-05 Thread Krishen Bhan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krishen Bhan updated HUDI-7507: --- Description: *Scenarios:* Although HUDI operations hold a table lock when creating a .requested

[jira] [Updated] (HUDI-7507) ongoing concurrent writers with smaller timestamp can cause issues with table services

2024-04-05 Thread Krishen Bhan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krishen Bhan updated HUDI-7507: --- Description: *Scenarios:* Although HUDI operations hold a table lock when creating a .requested

(hudi) branch master updated: [MINOR] Removed FSUtils.makeBaseFileName without fileExt param (#10963)

2024-04-05 Thread vbalaji
This is an automated email from the ASF dual-hosted git repository. vbalaji pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new bac6ea7b26b [MINOR] Removed

Re: [PR] [MINOR] Removed FSUtils.makeBaseFileName without fileExtension param [hudi]

2024-04-05 Thread via GitHub
bvaradar merged PR #10963: URL: https://github.com/apache/hudi/pull/10963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [DO NOT MERGE][HUDI-7567] Add schema evolution to the filegroup reader [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10957: URL: https://github.com/apache/hudi/pull/10957#issuecomment-2040652504 ## CI report: * 28200fd3db4c98241062c682178291635e972c98 Azure:

Re: [PR] [HUDI-7565] Create spark file readers to read a single file instead of an entire partition [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10954: URL: https://github.com/apache/hudi/pull/10954#issuecomment-2040652407 ## CI report: * 867593d87c13cc1963488e0b66e9292ffb88a192 Azure:

Re: [PR] [DO NOT MERGE][HUDI-7566] Add schema evolution to spark file readers [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10956: URL: https://github.com/apache/hudi/pull/10956#issuecomment-2040652444 ## CI report: * b12c0183f2f517c9ae6065936a67a48c131bb482 Azure:

Re: [PR] [HUDI-7235] Fix checkpoint bug for S3/GCS Incremental Source [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10336: URL: https://github.com/apache/hudi/pull/10336#issuecomment-2040651358 ## CI report: * de49a9da9db751d6fd6e0eaa1a750f8726a55018 UNKNOWN * 0656fa60257ac3e8d5b6d3a4e5b47d6d12d20a03 Azure:

Re: [PR] [HUDI-7565] Create spark file readers to read a single file instead of an entire partition [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10954: URL: https://github.com/apache/hudi/pull/10954#issuecomment-2040643204 ## CI report: * 867593d87c13cc1963488e0b66e9292ffb88a192 Azure:

Re: [PR] [DO NOT MERGE][HUDI-7566] Add schema evolution to spark file readers [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10956: URL: https://github.com/apache/hudi/pull/10956#issuecomment-2040643262 ## CI report: * b12c0183f2f517c9ae6065936a67a48c131bb482 Azure:

Re: [PR] [HUDI-7235] Fix checkpoint bug for S3/GCS Incremental Source [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10336: URL: https://github.com/apache/hudi/pull/10336#issuecomment-2040642100 ## CI report: * de49a9da9db751d6fd6e0eaa1a750f8726a55018 UNKNOWN * 0656fa60257ac3e8d5b6d3a4e5b47d6d12d20a03 Azure:

Re: [PR] [HUDI-7503] Compaction and LogCompaction executions should start a heartbeat on every attempt and block concurrent executions of same plan [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10965: URL: https://github.com/apache/hudi/pull/10965#issuecomment-2040635432 ## CI report: * ddd6cf2655e073aacd3b48de126781abacd7e111 Azure:

Re: [PR] [9999][DO NOT MERGE] test schema evolution change [hudi]

2024-04-05 Thread via GitHub
jonvex closed pull request #10966: [][DO NOT MERGE] test schema evolution change URL: https://github.com/apache/hudi/pull/10966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [DO NOT MERGE][HUDI-7567] Add schema evolution to the filegroup reader [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10957: URL: https://github.com/apache/hudi/pull/10957#issuecomment-2040573270 ## CI report: * 8319069bcc7de044f8ee0e289792613ca57215ac Azure:

Re: [PR] [9999][DO NOT MERGE] test schema evolution change [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10966: URL: https://github.com/apache/hudi/pull/10966#issuecomment-2040573384 ## CI report: * 8a3ed83e9615534ddf9fb52b411f38f6f953da0e Azure:

Re: [PR] [HUDI-7503] Compaction and LogCompaction executions should start a heartbeat on every attempt and block concurrent executions of same plan [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10965: URL: https://github.com/apache/hudi/pull/10965#issuecomment-2040573327 ## CI report: * ddd6cf2655e073aacd3b48de126781abacd7e111 Azure:

Re: [PR] [9999][DO NOT MERGE] test schema evolution change [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10966: URL: https://github.com/apache/hudi/pull/10966#issuecomment-2040564563 ## CI report: * 8a3ed83e9615534ddf9fb52b411f38f6f953da0e UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run

Re: [PR] [HUDI-7503] Compaction and LogCompaction executions should start a heartbeat on every attempt and block concurrent executions of same plan [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10965: URL: https://github.com/apache/hudi/pull/10965#issuecomment-2040564503 ## CI report: * ddd6cf2655e073aacd3b48de126781abacd7e111 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run

Re: [PR] [DO NOT MERGE][HUDI-7567] Add schema evolution to the filegroup reader [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10957: URL: https://github.com/apache/hudi/pull/10957#issuecomment-2040564415 ## CI report: * 8319069bcc7de044f8ee0e289792613ca57215ac Azure:

Re: [PR] [DO NOT MERGE][HUDI-7567] Add schema evolution to the filegroup reader [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10957: URL: https://github.com/apache/hudi/pull/10957#issuecomment-2040555488 ## CI report: * 8319069bcc7de044f8ee0e289792613ca57215ac Azure:

[PR] [9999][DO NOT MERGE] test schema evolution change [hudi]

2024-04-05 Thread via GitHub
jonvex opened a new pull request, #10966: URL: https://github.com/apache/hudi/pull/10966 ### Change Logs asdgfsafgafs ### Impact sagfasfdsad ### Risk level (write none, low medium or high below) none ### Documentation Update N/A ###

[jira] [Updated] (HUDI-7503) Concurrent executions of table service plan should not corrupt dataset

2024-04-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-7503: - Labels: pull-request-available (was: ) > Concurrent executions of table service plan should not

[PR] [HUDI-7503] Compaction and LogCompaction executions should start a heartbeat on every attempt and block concurrent executions of same plan [hudi]

2024-04-05 Thread via GitHub
kbuci opened a new pull request, #10965: URL: https://github.com/apache/hudi/pull/10965 ### Change Logs Updated compact and logcompact to start a heartbeat (within a transaction) before attempting to execute a plan. If multiple writers attempt to execute same

Re: [PR] [DO NOT MERGE][HUDI-7567] Add schema evolution to the filegroup reader [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10957: URL: https://github.com/apache/hudi/pull/10957#issuecomment-2040499724 ## CI report: * b7a7c272eb2c884e42016628b10e3030ebf43869 Azure:

Re: [PR] [HUDI-7045] Create parquet readers inside the reader context and implement schema.on.read in the filegroup reader in spark [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10278: URL: https://github.com/apache/hudi/pull/10278#issuecomment-2040498537 ## CI report: * 83064f1614c80f4ff518d05bf40563881ad12a5e Azure:

Re: [PR] [DO NOT MERGE][HUDI-7567] Add schema evolution to the filegroup reader [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10957: URL: https://github.com/apache/hudi/pull/10957#issuecomment-2040490679 ## CI report: * b7a7c272eb2c884e42016628b10e3030ebf43869 Azure:

[PR] [HUDI-7045] Create parquet readers inside the reader context and implement schema.on.read in the filegroup reader in spark [hudi]

2024-04-05 Thread via GitHub
jonvex opened a new pull request, #10278: URL: https://github.com/apache/hudi/pull/10278 ### Change Logs - Create Spark Parquet reader inside of the reader context - Eliminate parquet reader map - Eliminate parallel implementation of setting up reader - Schema.on.read for

Re: [PR] [HUDI-7571] Add api to get exception details in HoodieMetadataTableValidator with ignoreFailed mode [hudi]

2024-04-05 Thread via GitHub
the-other-tim-brown commented on code in PR #10960: URL: https://github.com/apache/hudi/pull/10960#discussion_r1554147334 ## hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java: ## @@ -197,6 +200,27 @@ public

Re: [I] [SUPPORT] Rollback failed clustering 0.12.2 [hudi]

2024-04-05 Thread via GitHub
VitoMakarevich commented on issue #10964: URL: https://github.com/apache/hudi/issues/10964#issuecomment-2040415437 Update - dug into the code `clusteringHandleUpdate`, and see that if: Updates rejected - write fails. Updates accepted -

Re: [PR] [MINOR] Handle cases of malformed records when converting to json [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10943: URL: https://github.com/apache/hudi/pull/10943#issuecomment-2040365541 ## CI report: * 1a93215057676d877e916be9f16b5df77a3b290b Azure:

Re: [PR] [DO NOT MERGE][HUDI-7567] Add schema evolution to the filegroup reader [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10957: URL: https://github.com/apache/hudi/pull/10957#issuecomment-2040365775 ## CI report: * b7a7c272eb2c884e42016628b10e3030ebf43869 Azure:

Re: [I] [SUPPORT] Rollback failed clustering 0.12.2 [hudi]

2024-04-05 Thread via GitHub
VitoMakarevich commented on issue #10964: URL: https://github.com/apache/hudi/issues/10964#issuecomment-2040341590 I see this property `hoodie.clustering.rollback.pending.replacecommit.on.conflict` - is it generally safe to use if we have single writer with inline services only? -- This

Re: [I] [SUPPORT] Rollback failed clustering 0.12.2 [hudi]

2024-04-05 Thread via GitHub
VitoMakarevich commented on issue #10964: URL: https://github.com/apache/hudi/issues/10964#issuecomment-2040330648 Update: managed to reproduce it, after stopping job during clustering, subsequent write fails with the exception `Not allowed to update the clustering file group

Re: [PR] [DO NOT MERGE][HUDI-7567] Add schema evolution to the filegroup reader [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10957: URL: https://github.com/apache/hudi/pull/10957#issuecomment-2040303354 ## CI report: * d59fd1bb95adf43998b20501c4df7f9fce405742 Azure:

Re: [PR] [DO NOT MERGE][HUDI-7567] Add schema evolution to the filegroup reader [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10957: URL: https://github.com/apache/hudi/pull/10957#issuecomment-2040292762 ## CI report: * d59fd1bb95adf43998b20501c4df7f9fce405742 Azure:

[I] [SUPPORT] Rollback failed clustering 0.12.2 [hudi]

2024-04-05 Thread via GitHub
VitoMakarevich opened a new issue, #10964: URL: https://github.com/apache/hudi/issues/10964 **_Tips before filing an issue_** - Have you gone through our [FAQs](https://hudi.apache.org/learn/faq/)? - Join the mailing list to engage in conversations and get faster support at

Re: [I] [SUPPORT] Change drop.partitionpath behavior [hudi]

2024-04-05 Thread via GitHub
VitoMakarevich closed issue #10878: [SUPPORT] Change drop.partitionpath behavior URL: https://github.com/apache/hudi/issues/10878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [HUDI-7571] Add api to get exception details in HoodieMetadataTableValidator with ignoreFailed mode [hudi]

2024-04-05 Thread via GitHub
codope commented on code in PR #10960: URL: https://github.com/apache/hudi/pull/10960#discussion_r1553974586 ## hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java: ## @@ -197,6 +200,27 @@ public HoodieMetadataTableValidator(JavaSparkContext

(hudi) branch master updated: [HUDI-7571] Add api to get exception details in HoodieMetadataTableValidator with ignoreFailed mode (#10960)

2024-04-05 Thread codope
This is an automated email from the ASF dual-hosted git repository. codope pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 19c20e4dd93 [HUDI-7571] Add api to get exception

Re: [PR] [HUDI-7571] Add api to get exception details in HoodieMetadataTableValidator with ignoreFailed mode [hudi]

2024-04-05 Thread via GitHub
codope merged PR #10960: URL: https://github.com/apache/hudi/pull/10960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [MINOR] Handle cases of malformed records when converting to json [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10943: URL: https://github.com/apache/hudi/pull/10943#issuecomment-2040216420 ## CI report: * 9df777edbf8d388523401e25d7a5ab55c22973c9 Azure:

Re: [PR] [MINOR] Removed FSUtils.makeBaseFileName without fileExtension param [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10963: URL: https://github.com/apache/hudi/pull/10963#issuecomment-2040216570 ## CI report: * a90a42fc4c3b9787a6cdd907e87160655f69cd8f Azure:

Re: [PR] [DO NOT MERGE][HUDI-7566] Add schema evolution to spark file readers [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10956: URL: https://github.com/apache/hudi/pull/10956#issuecomment-2040206172 ## CI report: * b12c0183f2f517c9ae6065936a67a48c131bb482 Azure:

Re: [PR] [MINOR] Handle cases of malformed records when converting to json [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10943: URL: https://github.com/apache/hudi/pull/10943#issuecomment-2040206059 ## CI report: * 9df777edbf8d388523401e25d7a5ab55c22973c9 Azure:

Re: [PR] [DO NOT MERGE][HUDI-7566] Add schema evolution to spark file readers [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10956: URL: https://github.com/apache/hudi/pull/10956#issuecomment-2040194653 ## CI report: * b12c0183f2f517c9ae6065936a67a48c131bb482 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run

Re: [PR] [HUDI-7571] Add api to get exception details in HoodieMetadataTableValidator with ignoreFailed mode [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10960: URL: https://github.com/apache/hudi/pull/10960#issuecomment-2040093637 ## CI report: * bb34417b88338bb1e994f08ccde4acda7d10837c Azure:

Re: [PR] [HUDI-7571] Add api to get exception details in HoodieMetadataTableValidator with ignoreFailed mode [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10960: URL: https://github.com/apache/hudi/pull/10960#issuecomment-2040077134 ## CI report: * bb34417b88338bb1e994f08ccde4acda7d10837c UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run

Re: [PR] [HUDI-7559] Fix RecordLevelIndexSupport::filterQueryWithRecordKey [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10947: URL: https://github.com/apache/hudi/pull/10947#issuecomment-2040077012 ## CI report: * 0c84a761b5f5378bcd51d987c9f29b1f649cf820 Azure:

Re: [PR] [MINOR] Removed FSUtils.makeBaseFileName without fileExtension param [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10963: URL: https://github.com/apache/hudi/pull/10963#issuecomment-2040061253 ## CI report: * a90a42fc4c3b9787a6cdd907e87160655f69cd8f Azure:

Re: [PR] [MINOR] Removed FSUtils.makeBaseFileName without fileExtension param [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10963: URL: https://github.com/apache/hudi/pull/10963#issuecomment-2039949094 ## CI report: * a90a42fc4c3b9787a6cdd907e87160655f69cd8f UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run

Re: [PR] [HUDI-7559] Fix RecordLevelIndexSupport::filterQueryWithRecordKey [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10947: URL: https://github.com/apache/hudi/pull/10947#issuecomment-2039933797 ## CI report: * d301dd2162f24dd66fd55885f76c8c3aa415b253 Azure:

[PR] [MINOR] Removed FSUtils.makeBaseFileName without fileExtension param [hudi]

2024-04-05 Thread via GitHub
wombatu-kun opened a new pull request, #10963: URL: https://github.com/apache/hudi/pull/10963 ### Change Logs I found in `FSUtils` class: ``` // TODO: this should be removed public static String makeBaseFileName(String instantTime, String writeToken, String fileId)

Re: [PR] [HUDI-7559] Fix RecordLevelIndexSupport::filterQueryWithRecordKey [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10947: URL: https://github.com/apache/hudi/pull/10947#issuecomment-2039916266 ## CI report: * d301dd2162f24dd66fd55885f76c8c3aa415b253 Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-05 Thread via GitHub
danny0405 commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r155535 ## hudi-common/src/main/java/org/apache/hudi/common/table/view/TableFileSystemView.java: ## @@ -107,6 +107,14 @@ interface SliceViewWithLatestSlice { */

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-05 Thread via GitHub
danny0405 commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1553326198 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -991,9 +1001,9 @@ private void

Re: [I] [SUPPORT] AWS Athena query fail when compaction is scheduled for MOR table [hudi]

2024-04-05 Thread via GitHub
brightwon commented on issue #9907: URL: https://github.com/apache/hudi/issues/9907#issuecomment-2039252471 @ad1happy2go I resolved the issue by downgrading the version, and we didn't find anything else to check. I don't need help right now. -- This is an automated message from the

Re: [PR] [HUDI-7571] Add api to get exception details in HoodieMetadataTableValidator with ignoreFailed mode [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10960: URL: https://github.com/apache/hudi/pull/10960#issuecomment-2039218081 ## CI report: * bb34417b88338bb1e994f08ccde4acda7d10837c Azure:

Re: [PR] [HUDI-7571] Add api to get exception details in HoodieMetadataTableValidator with ignoreFailed mode [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10960: URL: https://github.com/apache/hudi/pull/10960#issuecomment-2039128437 ## CI report: * 4d98b60fc24c99937c29d68784d2e1638e7e323d Azure:

Re: [PR] [HUDI-7571] Add api to get exception details in HoodieMetadataTableValidator with ignoreFailed mode [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10960: URL: https://github.com/apache/hudi/pull/10960#issuecomment-2039114760 ## CI report: * 4d98b60fc24c99937c29d68784d2e1638e7e323d Azure:

Re: [PR] [HUDI-7571] Add api to get exception details in HoodieMetadataTableValidator with ignoreFailed mode [hudi]

2024-04-05 Thread via GitHub
lokeshj1703 commented on code in PR #10960: URL: https://github.com/apache/hudi/pull/10960#discussion_r1552995109 ## hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java: ## @@ -180,6 +181,8 @@ public class HoodieMetadataTableValidator

Re: [PR] [HUDI-7571] Add api to get exception details in HoodieMetadataTableValidator with ignoreFailed mode [hudi]

2024-04-05 Thread via GitHub
lokeshj1703 commented on code in PR #10960: URL: https://github.com/apache/hudi/pull/10960#discussion_r1552994094 ## hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java: ## @@ -197,6 +200,27 @@ public

Re: [PR] [MINOR] Add a test case on pending rollback commits when the instantsToRollback are deleted [hudi]

2024-04-05 Thread via GitHub
hudi-bot commented on PR #10648: URL: https://github.com/apache/hudi/pull/10648#issuecomment-2039016993 ## CI report: * 314969b1a7d2e5e24f099829d2b5e5b0c5b99893 Azure: