[GitHub] [incubator-mxnet] iblis17 commented on issue #15613: [Discussion] 1.5.1 Patch Release

2019-07-19 Thread GitBox
iblis17 commented on issue #15613: [Discussion] 1.5.1 Patch Release URL: https://github.com/apache/incubator-mxnet/issues/15613#issuecomment-513439987 I will track Julia stuffs that need to be backported here: - [ ] https://github.com/apache/incubator-mxnet/pull/15609 - [ ] https://gi

[incubator-mxnet] branch ib/dump-win-prebult updated (15db992 -> 3aba159)

2019-07-19 Thread iblis
This is an automated email from the ASF dual-hosted git repository. iblis pushed a change to branch ib/dump-win-prebult in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. discard 15db992 julia: bump window prebult binary version to v1.5.0 add 6bdcef2 Deprecate USE_PRO

[incubator-mxnet] branch ib/bump-jl-ver updated (873f2ad -> 897682e)

2019-07-19 Thread iblis
This is an automated email from the ASF dual-hosted git repository. iblis pushed a change to branch ib/bump-jl-ver in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. discard 873f2ad julia: bump binding version to v1.6.0 add 6bdcef2 Deprecate USE_PROFILER flag (#15595)

[GitHub] [incubator-mxnet] iblis17 commented on issue #15609: update julia install doc

2019-07-19 Thread GitBox
iblis17 commented on issue #15609: update julia install doc URL: https://github.com/apache/incubator-mxnet/pull/15609#issuecomment-513439338 Could you add a section about "install the latest release" ?... via ``` ]add MXNet ``` --

[GitHub] [incubator-mxnet] yuxihu commented on issue #15591: Export symbols for checking cuda/cudnn versions

2019-07-19 Thread GitBox
yuxihu commented on issue #15591: Export symbols for checking cuda/cudnn versions URL: https://github.com/apache/incubator-mxnet/pull/15591#issuecomment-513439100 > The default constructor of Context creates the equivalent CPU context on device 0, without calling the problematic Context::C

[GitHub] [incubator-mxnet] iblis17 commented on issue #15587: Can't install on Julia 1.1

2019-07-19 Thread GitBox
iblis17 commented on issue #15587: Can't install on Julia 1.1 URL: https://github.com/apache/incubator-mxnet/issues/15587#issuecomment-513439042 That PR got merged. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-mxnet] iblis17 closed issue #15587: Can't install on Julia 1.1

2019-07-19 Thread GitBox
iblis17 closed issue #15587: Can't install on Julia 1.1 URL: https://github.com/apache/incubator-mxnet/issues/15587 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-mxnet] iblis17 commented on issue #9550: Pkg MXNet doesn't build on Julia

2019-07-19 Thread GitBox
iblis17 commented on issue #9550: Pkg MXNet doesn't build on Julia URL: https://github.com/apache/incubator-mxnet/issues/9550#issuecomment-513439017 Please try out the v1.5.0 release. This is an automated message from the Apa

[GitHub] [incubator-mxnet] iblis17 closed issue #9550: Pkg MXNet doesn't build on Julia

2019-07-19 Thread GitBox
iblis17 closed issue #9550: Pkg MXNet doesn't build on Julia URL: https://github.com/apache/incubator-mxnet/issues/9550 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on issue #15253: [MXNET-978] Add higher order gradient support `tan`, `tanh`

2019-07-19 Thread GitBox
sandeep-krishnamurthy commented on issue #15253: [MXNET-978] Add higher order gradient support `tan`, `tanh` URL: https://github.com/apache/incubator-mxnet/pull/15253#issuecomment-513438826 @apeforest - Can you please take look at this PR and merge if it looks good? Thanks ---

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on issue #15517: Tensor Inspector Tutorial

2019-07-19 Thread GitBox
sandeep-krishnamurthy commented on issue #15517: Tensor Inspector Tutorial URL: https://github.com/apache/incubator-mxnet/pull/15517#issuecomment-513438550 Thanks @Zha0q1 @IvyBazan @ChaiBapchya @larroy @apeforest @marcoabreu

[incubator-mxnet] branch master updated (d14fa69 -> cc861f0)

2019-07-19 Thread skm
This is an automated email from the ASF dual-hosted git repository. skm pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from d14fa69 Update profiler.md (#15477) add cc861f0 Tensor Inspector Tutorial (#15517) No new revisions wer

[GitHub] [incubator-mxnet] sandeep-krishnamurthy merged pull request #15517: Tensor Inspector Tutorial

2019-07-19 Thread GitBox
sandeep-krishnamurthy merged pull request #15517: Tensor Inspector Tutorial URL: https://github.com/apache/incubator-mxnet/pull/15517 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #15580: update profiler tutorial

2019-07-19 Thread GitBox
sandeep-krishnamurthy commented on a change in pull request #15580: update profiler tutorial URL: https://github.com/apache/incubator-mxnet/pull/15580#discussion_r305568430 ## File path: docs/tutorials/python/profiler.md ## @@ -212,11 +212,6 @@ Should the existing NDArray

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #15580: update profiler tutorial

2019-07-19 Thread GitBox
sandeep-krishnamurthy commented on a change in pull request #15580: update profiler tutorial URL: https://github.com/apache/incubator-mxnet/pull/15580#discussion_r305568441 ## File path: docs/tutorials/python/profiler.md ## @@ -244,15 +239,17 @@ class CustomAddOneProp(mx.o

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #15580: update profiler tutorial

2019-07-19 Thread GitBox
sandeep-krishnamurthy commented on a change in pull request #15580: update profiler tutorial URL: https://github.com/apache/incubator-mxnet/pull/15580#discussion_r305568465 ## File path: docs/tutorials/python/profiler.md ## @@ -278,9 +275,15 @@ c = b.bind(mx.cpu(), {'a': i

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #15580: update profiler tutorial

2019-07-19 Thread GitBox
sandeep-krishnamurthy commented on a change in pull request #15580: update profiler tutorial URL: https://github.com/apache/incubator-mxnet/pull/15580#discussion_r305568427 ## File path: docs/tutorials/python/profiler.md ## @@ -193,10 +193,10 @@ print(profiler.dumps()) Yo

[GitHub] [incubator-mxnet] TaoLv commented on issue #15169: Softmax with length

2019-07-19 Thread GitBox
TaoLv commented on issue #15169: Softmax with length URL: https://github.com/apache/incubator-mxnet/pull/15169#issuecomment-513432618 Sorry for missing the review. Do we need to change MKL-DNN softmax to accommodate the change? -

[GitHub] [incubator-mxnet] Zha0q1 commented on issue #15517: Tensor Inspector Tutorial

2019-07-19 Thread GitBox
Zha0q1 commented on issue #15517: Tensor Inspector Tutorial URL: https://github.com/apache/incubator-mxnet/pull/15517#issuecomment-513431989 Haha you guys are BREATHTAKING This is an automated message from the Apache Git Servi

[GitHub] [incubator-mxnet] xf05888 closed issue #15598: ImportError: cannot import name '_adamw_update'

2019-07-19 Thread GitBox
xf05888 closed issue #15598: ImportError: cannot import name '_adamw_update' URL: https://github.com/apache/incubator-mxnet/issues/15598 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-mxnet] DickJC123 edited a comment on issue #15591: Export symbols for checking cuda/cudnn versions

2019-07-19 Thread GitBox
DickJC123 edited a comment on issue #15591: Export symbols for checking cuda/cudnn versions URL: https://github.com/apache/incubator-mxnet/pull/15591#issuecomment-513430854 The above change was in the file tensor_util.cc. Also needed to avoid the link error is the following change in mpi_

[GitHub] [incubator-mxnet] DickJC123 edited a comment on issue #15591: Export symbols for checking cuda/cudnn versions

2019-07-19 Thread GitBox
DickJC123 edited a comment on issue #15591: Export symbols for checking cuda/cudnn versions URL: https://github.com/apache/incubator-mxnet/pull/15591#issuecomment-513430854 The above change was in the file tensor_util.cc. Also needed to avoid the link error is the following change in mpi_

[GitHub] [incubator-mxnet] DickJC123 edited a comment on issue #15591: Export symbols for checking cuda/cudnn versions

2019-07-19 Thread GitBox
DickJC123 edited a comment on issue #15591: Export symbols for checking cuda/cudnn versions URL: https://github.com/apache/incubator-mxnet/pull/15591#issuecomment-513430854 The above change was in the file tensor_util.cc. Also needed to avoid the link error is the following change in mpi_

[GitHub] [incubator-mxnet] DickJC123 edited a comment on issue #15591: Export symbols for checking cuda/cudnn versions

2019-07-19 Thread GitBox
DickJC123 edited a comment on issue #15591: Export symbols for checking cuda/cudnn versions URL: https://github.com/apache/incubator-mxnet/pull/15591#issuecomment-513430854 The above change was in the file tensor_util.cc. Also needed to avoid the link error is the following change in mpi_

[GitHub] [incubator-mxnet] DickJC123 commented on issue #15591: Export symbols for checking cuda/cudnn versions

2019-07-19 Thread GitBox
DickJC123 commented on issue #15591: Export symbols for checking cuda/cudnn versions URL: https://github.com/apache/incubator-mxnet/pull/15591#issuecomment-513430854 The above change was in the file tensor_util.cc. Also needed is the following chane in mpi_ops.cc: Was: ``` stat

[GitHub] [incubator-mxnet] yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels

2019-07-19 Thread GitBox
yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels URL: https://github.com/apache/incubator-mxnet/pull/15550#discussion_r305562623 ## File path: src/operator/contrib/tvmop/ufunc.cc ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Softw

[GitHub] [incubator-mxnet] yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels

2019-07-19 Thread GitBox
yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels URL: https://github.com/apache/incubator-mxnet/pull/15550#discussion_r305562449 ## File path: Makefile ## @@ -589,6 +603,30 @@ $(DMLC_CORE)/libdmlc.a: DMLCCORE DMLCCORE: + cd $(

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-07-19 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 3114023 Bump the publish

[GitHub] [incubator-mxnet] DickJC123 commented on issue #15591: Export symbols for checking cuda/cudnn versions

2019-07-19 Thread GitBox
DickJC123 commented on issue #15591: Export symbols for checking cuda/cudnn versions URL: https://github.com/apache/incubator-mxnet/pull/15591#issuecomment-513418039 Regarding compatibility, old horovod builds that still reference Context::Create() would not link against newer libmxnet.so

[GitHub] [incubator-mxnet] DickJC123 edited a comment on issue #15591: Export symbols for checking cuda/cudnn versions

2019-07-19 Thread GitBox
DickJC123 edited a comment on issue #15591: Export symbols for checking cuda/cudnn versions URL: https://github.com/apache/incubator-mxnet/pull/15591#issuecomment-513416364 It seems horovod is going around the official mxnet API by refering directly to NDArray and Context. MXNet provides o

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305558322 ## File path: src/operator/nn/fully_connected-inl.h ## @@ -134,59 +177,52 @@ void FCBackward(const

[GitHub] [incubator-mxnet] DickJC123 edited a comment on issue #15591: Export symbols for checking cuda/cudnn versions

2019-07-19 Thread GitBox
DickJC123 edited a comment on issue #15591: Export symbols for checking cuda/cudnn versions URL: https://github.com/apache/incubator-mxnet/pull/15591#issuecomment-513416364 It seems horovod is going around the official mxnet API by refering directly to NDArray and Context. MXNet provides o

[GitHub] [incubator-mxnet] samskalicky commented on issue #15601: changed constructor args for TShape

2019-07-19 Thread GitBox
samskalicky commented on issue #15601: changed constructor args for TShape URL: https://github.com/apache/incubator-mxnet/pull/15601#issuecomment-513416921 @szha removed the incorrect merge This is an automated message from th

[GitHub] [incubator-mxnet] DickJC123 commented on issue #15591: Export symbols for checking cuda/cudnn versions

2019-07-19 Thread GitBox
DickJC123 commented on issue #15591: Export symbols for checking cuda/cudnn versions URL: https://github.com/apache/incubator-mxnet/pull/15591#issuecomment-513416364 It seems horovod is going around the official mxnet API by refering directly to NDArray and Context. MXNet provides opaque p

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #15592: Flaky test test_metric.test_global_metric

2019-07-19 Thread GitBox
ChaiBapchya commented on issue #15592: Flaky test test_metric.test_global_metric URL: https://github.com/apache/incubator-mxnet/issues/15592#issuecomment-513413852 Unrelated PR - https://github.com/apache/incubator-mxnet/pull/15601 Pipeline - http://jenkins.mxnet-ci.amazon-ml.com/blue/o

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r30362 ## File path: src/operator/nn/fully_connected-inl.h ## @@ -47,7 +48,23 @@ namespace fullc { enum F

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #15603: Flaky test test_operator_gpu.test_convolution_independent_gradients

2019-07-19 Thread GitBox
ChaiBapchya commented on issue #15603: Flaky test test_operator_gpu.test_convolution_independent_gradients URL: https://github.com/apache/incubator-mxnet/issues/15603#issuecomment-513413654 PR #15601 Pipeline - http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-val

[GitHub] [incubator-mxnet] larroy commented on issue #14940: Fix warnings

2019-07-19 Thread GitBox
larroy commented on issue #14940: Fix warnings URL: https://github.com/apache/incubator-mxnet/pull/14940#issuecomment-513413494 Fixed the whitespace, let me know if there's something else. This is an automated message from the

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305554939 ## File path: src/operator/nn/fully_connected.cc ## @@ -176,11 +176,23 @@ struct FullyConnectedGrad

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305554797 ## File path: tests/python/unittest/test_higher_order_grad.py ## @@ -173,6 +182,87 @@ def check_sec

[GitHub] [incubator-mxnet] zboldyga commented on issue #14962: Improve linear algebra functions

2019-07-19 Thread GitBox
zboldyga commented on issue #14962: Improve linear algebra functions URL: https://github.com/apache/incubator-mxnet/issues/14962#issuecomment-513412955 Regarding svd and pinv: if you implement svd, a short stub in the documentation describing why pinv isn't provided and how to use svd to g

[GitHub] [incubator-mxnet] zboldyga commented on issue #14962: Improve linear algebra functions

2019-07-19 Thread GitBox
zboldyga commented on issue #14962: Improve linear algebra functions URL: https://github.com/apache/incubator-mxnet/issues/14962#issuecomment-513412443 @mseeger I agree with your sentiment overall. Users shouldn't wander into using these multi-step ops without a warning, and the likelihood

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305554124 ## File path: tests/python/unittest/test_higher_order_grad.py ## @@ -18,8 +18,17 @@ import math

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305554124 ## File path: tests/python/unittest/test_higher_order_grad.py ## @@ -18,8 +18,17 @@ import math

[GitHub] [incubator-mxnet] larroy commented on issue #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on issue #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#issuecomment-513412193 Thanks for the review. Is the approach correct in your opinion? This i

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305553693 ## File path: tests/python/unittest/test_higher_order_grad.py ## @@ -173,6 +182,87 @@ def check_sec

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305553411 ## File path: tests/python/unittest/test_higher_order_grad.py ## @@ -173,6 +182,87 @@ def check_sec

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305553238 ## File path: tests/python/unittest/test_gluon.py ## @@ -21,7 +21,7 @@ import mxnet as mx from mx

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305553178 ## File path: tests/python/unittest/test_gluon.py ## @@ -21,7 +21,7 @@ import mxnet as mx from mx

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305553141 ## File path: src/operator/nn/fully_connected.cc ## @@ -331,5 +346,32 @@ NNVM_REGISTER_OP(_backward

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14836: Refactor AGInfo and Imperative

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14836: Refactor AGInfo and Imperative URL: https://github.com/apache/incubator-mxnet/pull/14836#discussion_r305551132 ## File path: src/imperative/imperative.cc ## @@ -316,181 +312,223 @@ std::vector Imperative::Backward(

[GitHub] [incubator-mxnet] ThomasDelteil closed issue #15615: How to add mail server

2019-07-19 Thread GitBox
ThomasDelteil closed issue #15615: How to add mail server URL: https://github.com/apache/incubator-mxnet/issues/15615 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-mxnet] szha commented on a change in pull request #15550: Infra to use tvm write op kernels

2019-07-19 Thread GitBox
szha commented on a change in pull request #15550: Infra to use tvm write op kernels URL: https://github.com/apache/incubator-mxnet/pull/15550#discussion_r305549027 ## File path: contrib/tvmop/prepare_tvm.sh ## @@ -0,0 +1,63 @@ +# Licensed to the Apache Software Foundation

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #14174: CI fails for unix cpu Static build CPU 14.04

2019-07-19 Thread GitBox
ChaiBapchya commented on issue #14174: CI fails for unix cpu Static build CPU 14.04 URL: https://github.com/apache/incubator-mxnet/issues/14174#issuecomment-513406742 For unrelated 15606 http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/de

[GitHub] [incubator-mxnet] ChaiBapchya edited a comment on issue #14174: CI fails for unix cpu Static build CPU 14.04

2019-07-19 Thread GitBox
ChaiBapchya edited a comment on issue #14174: CI fails for unix cpu Static build CPU 14.04 URL: https://github.com/apache/incubator-mxnet/issues/14174#issuecomment-513406742 For unrelated #15606 http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funi

[incubator-mxnet] branch master updated: Update profiler.md (#15477)

2019-07-19 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new d14fa69 Update profiler.md (#15477)

[GitHub] [incubator-mxnet] szha merged pull request #15477: Update profiler.md

2019-07-19 Thread GitBox
szha merged pull request #15477: Update profiler.md URL: https://github.com/apache/incubator-mxnet/pull/15477 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305547229 ## File path: tests/python/unittest/test_higher_order_grad.py ## @@ -173,6 +182,87 @@ def check_

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305546851 ## File path: tests/python/unittest/test_higher_order_grad.py ## @@ -173,6 +182,87 @@ def check_

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305546839 ## File path: tests/python/unittest/test_higher_order_grad.py ## @@ -173,6 +182,87 @@ def check_

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305546739 ## File path: tests/python/unittest/test_higher_order_grad.py ## @@ -173,6 +182,87 @@ def check_

[GitHub] [incubator-mxnet] larroy commented on issue #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on issue #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#issuecomment-513403668 Thanks for the comments about the whitespace. Is the calculation correct? Let's focus on the important stuff first, then do a round of

[GitHub] [incubator-mxnet] szha commented on issue #15591: Export symbols for checking cuda/cudnn versions

2019-07-19 Thread GitBox
szha commented on issue #15591: Export symbols for checking cuda/cudnn versions URL: https://github.com/apache/incubator-mxnet/pull/15591#issuecomment-513403578 libmxnet.so shouldn't expose symbols that are not part of the API. if it's needed as API, it needs to be added to C-API. I think t

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305546401 ## File path: tests/python/unittest/test_higher_order_grad.py ## @@ -173,6 +182,87 @@ def check_

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305546292 ## File path: src/operator/nn/fully_connected.cc ## @@ -210,11 +222,11 @@ inline static bool FCStor

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305546152 ## File path: src/operator/nn/fully_connected.cc ## @@ -1,4 +1,4 @@ -/* +/* Review comment:

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305546156 ## File path: tests/python/unittest/test_higher_order_grad.py ## @@ -18,8 +18,14 @@ import ma

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305545886 ## File path: tests/python/unittest/test_higher_order_grad.py ## @@ -18,8 +18,14 @@ import ma

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305545773 ## File path: tests/python/unittest/test_higher_order_grad.py ## @@ -18,8 +18,17 @@ import ma

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305545709 ## File path: tests/python/unittest/test_gluon.py ## @@ -21,7 +21,7 @@ import mxnet as mx from

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305545634 ## File path: src/operator/nn/fully_connected.cc ## @@ -331,5 +346,32 @@ NNVM_REGISTER_OP(_backw

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305545540 ## File path: src/operator/nn/fully_connected.cc ## @@ -331,5 +346,32 @@ NNVM_REGISTER_OP(_backw

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305545140 ## File path: src/operator/nn/fully_connected-inl.h ## @@ -91,21 +140,14 @@ void FCForward(const Op

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305545431 ## File path: src/operator/nn/fully_connected.cc ## @@ -331,5 +346,32 @@ NNVM_REGISTER_OP(_backw

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305545140 ## File path: src/operator/nn/fully_connected-inl.h ## @@ -91,21 +140,14 @@ void FCForward(const Op

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305545364 ## File path: src/operator/nn/fully_connected.cc ## @@ -240,6 +252,8 @@ inline static bool Backw

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305545393 ## File path: src/operator/nn/fully_connected-inl.h ## @@ -134,59 +177,52 @@ void FCBackward(const

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305545329 ## File path: src/operator/nn/fully_connected.cc ## @@ -176,11 +176,23 @@ struct FullyConnectedG

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305545354 ## File path: src/operator/nn/fully_connected.cc ## @@ -210,11 +222,11 @@ inline static bool FCS

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305545247 ## File path: src/operator/nn/fully_connected.cc ## @@ -1,4 +1,4 @@ -/* +/* Review commen

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305545160 ## File path: src/operator/nn/fully_connected-inl.h ## @@ -249,6 +285,99 @@ void FullyConnectedG

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305545140 ## File path: src/operator/nn/fully_connected-inl.h ## @@ -91,21 +140,14 @@ void FCForward(const Op

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305544847 ## File path: src/operator/nn/fully_connected-inl.h ## @@ -134,59 +177,52 @@ void FCBackward(con

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305544787 ## File path: src/operator/nn/fully_connected-inl.h ## @@ -126,6 +168,7 @@ void FCForward(const

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305544739 ## File path: src/operator/nn/fully_connected-inl.h ## @@ -91,21 +140,14 @@ void FCForward(const

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
apeforest commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305544474 ## File path: src/operator/nn/fully_connected-inl.h ## @@ -47,7 +48,23 @@ namespace fullc { enu

[incubator-mxnet] branch master updated (da71324 -> 7e632c9)

2019-07-19 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from da71324 Fix dumps for Constant initializer (#15150) add 7e632c9 add myself to interested modules (#

[GitHub] [incubator-mxnet] szha merged pull request #15590: Update CODEOWNER

2019-07-19 Thread GitBox
szha merged pull request #15590: Update CODEOWNER URL: https://github.com/apache/incubator-mxnet/pull/15590 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-mxnet] szha closed issue #12404: init.Constant does not work in symbol

2019-07-19 Thread GitBox
szha closed issue #12404: init.Constant does not work in symbol URL: https://github.com/apache/incubator-mxnet/issues/12404 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-mxnet] branch master updated (eab6da6 -> da71324)

2019-07-19 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from eab6da6 Fix warnings in CLang: (#15270) add da71324 Fix dumps for Constant initializer (#15150) No

[GitHub] [incubator-mxnet] szha merged pull request #15150: Fix dumps for Constant initializer

2019-07-19 Thread GitBox
szha merged pull request #15150: Fix dumps for Constant initializer URL: https://github.com/apache/incubator-mxnet/pull/15150 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-mxnet] szha commented on issue #15150: Fix dumps for Constant initializer

2019-07-19 Thread GitBox
szha commented on issue #15150: Fix dumps for Constant initializer URL: https://github.com/apache/incubator-mxnet/pull/15150#issuecomment-513400189 Merged. Thanks for the fix @abhinavs95 This is an automated message from the A

[GitHub] [incubator-mxnet] roywei commented on issue #15137: 1.5.0 news

2019-07-19 Thread GitBox
roywei commented on issue #15137: 1.5.0 news URL: https://github.com/apache/incubator-mxnet/pull/15137#issuecomment-513399915 @aaronmarkham 1.5 is released, this is good to go. We also need to update the website. This is an a

[GitHub] [incubator-mxnet] larroy commented on issue #15270: Fix warnings in CLang.

2019-07-19 Thread GitBox
larroy commented on issue #15270: Fix warnings in CLang. URL: https://github.com/apache/incubator-mxnet/pull/15270#issuecomment-513397706 appreciate, thanks This is an automated message from the Apache Git Service. To respond

[incubator-mxnet] branch master updated (076b2f3 -> eab6da6)

2019-07-19 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 076b2f3 Softmax with length (#15169) add eab6da6 Fix warnings in CLang: (#15270) No new revision

[GitHub] [incubator-mxnet] marcoabreu merged pull request #15270: Fix warnings in CLang.

2019-07-19 Thread GitBox
marcoabreu merged pull request #15270: Fix warnings in CLang. URL: https://github.com/apache/incubator-mxnet/pull/15270 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-mxnet] abhinavs95 commented on issue #15150: Fix dumps for Constant initializer

2019-07-19 Thread GitBox
abhinavs95 commented on issue #15150: Fix dumps for Constant initializer URL: https://github.com/apache/incubator-mxnet/pull/15150#issuecomment-513395749 @karan6181 yes its good to go from my side This is an automated message

[GitHub] [incubator-mxnet] larroy commented on issue #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on issue #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#issuecomment-513395506 @sxjscience @kshitij12345 please help review. This is an automated mes

[GitHub] [incubator-mxnet] larroy commented on issue #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on issue #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#issuecomment-513395100 From my side is just missing the bias term, please help review the approach. --

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad

2019-07-19 Thread GitBox
larroy commented on a change in pull request #14779: [WIP] Fully connected, higher order grad URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r305539303 ## File path: src/operator/nn/fully_connected-inl.h ## @@ -1,4 +1,4 @@ -/* + /* Review comment:

  1   2   3   >