[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r193424379 ## File path: tests/python/mkl/test_quantization_mkldnn.py ## @@ -0,0 +1,28 @@ +#

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r193374740 ## File path: tests/python/quantization/test_quantization.py ## @@ -319,6 +339,11 @@

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r193374791 ## File path: tests/python/quantization/test_quantization.py ## @@ -409,11 +441,19 @@

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r193374412 ## File path: tests/python/mkl/test_quantization_mkldnn.py ## @@ -0,0 +1,28 @@ +#

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r193372537 ## File path: ci/docker/runtime_functions.sh ## @@ -382,7 +381,6 @@

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r193374954 ## File path: tests/python/quantization/test_quantization.py ## @@ -409,11 +441,19 @@

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r193374762 ## File path: tests/python/quantization/test_quantization.py ## @@ -353,6 +378,11 @@

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r193374459 ## File path: tests/python/mkl/test_quantization_mkldnn.py ## @@ -0,0 +1,28 @@ +#

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r193374638 ## File path: tests/python/quantization/test_quantization.py ## @@ -120,114 +128,126

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r193374697 ## File path: tests/python/quantization/test_quantization.py ## @@ -120,114 +128,126

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r183235359 ## File path: ci/docker/runtime_functions.sh ## @@ -371,7 +371,6 @@

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r182468883 ## File path: src/operator/quantization/quantized_conv.cc ## @@ -86,12 +89,10 @@ bool

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r182468602 ## File path: src/operator/quantization/quantize_graph_pass.cc ## @@ -198,7 +198,7 @@

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r182468565 ## File path: src/operator/quantization/quantize_graph_pass.cc ## @@ -159,7 +159,7 @@

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r182467890 ## File path: src/c_api/c_api_symbolic.cc ## @@ -595,7 +597,12 @@ int

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r182467604 ## File path: python/mxnet/contrib/quantization.py ## @@ -72,7 +72,7 @@ def

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r182467087 ## File path: include/mxnet/c_api.h ## @@ -1409,13 +1409,17 @@ MXNET_DLL int

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r182466761 ## File path: ci/docker/runtime_functions.sh ## @@ -407,26 +405,28 @@

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r182466678 ## File path: ci/docker/runtime_functions.sh ## @@ -407,26 +405,28 @@

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r182466521 ## File path: ci/docker/runtime_functions.sh ## @@ -407,26 +405,28 @@

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r182411485 ## File path: ci/docker/runtime_functions.sh ## @@ -371,7 +371,6 @@

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r182411505 ## File path: ci/docker/runtime_functions.sh ## @@ -382,7 +381,6 @@

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r179800671 ## File path: tests/python/quantization/test_quantization_mkldnn.py ## @@ -0,0 +1,309

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r179752389 ## File path: tests/python/quantization/test_quantization_mkldnn.py ## @@ -0,0 +1,309

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r179747474 ## File path: tests/python/quantization/test_quantization_mkldnn.py ## @@ -0,0 +1,309

[GitHub] marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization

marcoabreu commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r179747207 ## File path: tests/python/quantization/test_quantization_mkldnn.py ## @@ -0,0 +1,309