[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17316: [NumPy] add op random.laplace

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17316: [NumPy] add op random.laplace URL: https://github.com/apache/incubator-mxnet/pull/17316#discussion_r366767278 ## File path: src/operator/numpy/random/np_laplace_op.h ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17316: [NumPy] add op random.laplace

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17316: [NumPy] add op random.laplace URL: https://github.com/apache/incubator-mxnet/pull/17316#discussion_r366767071 ## File path: python/mxnet/symbol/numpy/random.py ## @@ -290,6 +290,54 @@ def choice(a, size=None,

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17316: [NumPy] add op random.laplace

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17316: [NumPy] add op random.laplace URL: https://github.com/apache/incubator-mxnet/pull/17316#discussion_r366766965 ## File path: python/mxnet/symbol/numpy/random.py ## @@ -290,6 +290,54 @@ def choice(a, size=None,

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17316: [NumPy] add op random.laplace

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17316: [NumPy] add op random.laplace URL: https://github.com/apache/incubator-mxnet/pull/17316#discussion_r366767024 ## File path: python/mxnet/symbol/numpy/random.py ## @@ -290,6 +290,54 @@ def choice(a, size=None,

[GitHub] [incubator-mxnet] liuzh91 opened a new issue #17320: Add customized event handlers in ValidationHandler

2020-01-15 Thread GitBox
liuzh91 opened a new issue #17320: Add customized event handlers in ValidationHandler URL: https://github.com/apache/incubator-mxnet/issues/17320 ## Description Current `mxnet.gluon.contrib.ValidationHandler` does not support customized event handlers although `eval_fn` usually

[GitHub] [incubator-mxnet] xidulu commented on a change in pull request #17316: [NumPy] add op random.laplace

2020-01-15 Thread GitBox
xidulu commented on a change in pull request #17316: [NumPy] add op random.laplace URL: https://github.com/apache/incubator-mxnet/pull/17316#discussion_r366736430 ## File path: src/operator/numpy/random/np_laplace_op.cu ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-mxnet] xidulu commented on a change in pull request #17316: [NumPy] add op random.laplace

2020-01-15 Thread GitBox
xidulu commented on a change in pull request #17316: [NumPy] add op random.laplace URL: https://github.com/apache/incubator-mxnet/pull/17316#discussion_r366735999 ## File path: src/operator/numpy/random/np_laplace_op.cc ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-mxnet] TaoLv opened a new pull request #17318: [WIP] Enable MKL-DNN FullyConnected backward

2020-01-15 Thread GitBox
TaoLv opened a new pull request #17318: [WIP] Enable MKL-DNN FullyConnected backward URL: https://github.com/apache/incubator-mxnet/pull/17318 ## Description ## Discussed with @rongzha1 offline. This PR incorporates the code changes in #16890 which was reverted previously. ##

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17254: [numpy] change unary infer type

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17254: [numpy] change unary infer type URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r366778186 ## File path: src/operator/tensor/elemwise_binary_op.h ## @@ -525,6 +525,67 @@ class ElemwiseBinaryOp :

[GitHub] [incubator-mxnet] rongzha1 commented on issue #16890: Mkldnn fullyConnect bwd bug fix

2020-01-15 Thread GitBox
rongzha1 commented on issue #16890: Mkldnn fullyConnect bwd bug fix URL: https://github.com/apache/incubator-mxnet/pull/16890#issuecomment-574551579 Can not reproduced in local machine, still not find the root cause. This is

[GitHub] [incubator-mxnet] perdasilva opened a new pull request #17319: [BugFix] Fixes version comparison algorithm

2020-01-15 Thread GitBox
perdasilva opened a new pull request #17319: [BugFix] Fixes version comparison algorithm URL: https://github.com/apache/incubator-mxnet/pull/17319 ## Description ## The version comparison algorithm for minimum cuda version decorator was wrong. This PR fixes it. ## Checklist ##

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17254: [numpy] change unary infer type

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17254: [numpy] change unary infer type URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r366774634 ## File path: src/operator/tensor/elemwise_unary_op.h ## @@ -252,6 +252,39 @@ class UnaryOp : public

[GitHub] [incubator-mxnet] ZheyuYe opened a new issue #17317: Floor division operator "//" in deepnumpy

2020-01-15 Thread GitBox
ZheyuYe opened a new issue #17317: Floor division operator "//" in deepnumpy URL: https://github.com/apache/incubator-mxnet/issues/17317 ## Description According the motivation of mx.np.ndarray, they should share same operation as numpy. But it seems that there is no operation of floor

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17302: [numpy]add op random.logistic

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17302: [numpy]add op random.logistic URL: https://github.com/apache/incubator-mxnet/pull/17302#discussion_r366763583 ## File path: src/operator/numpy/random/np_logistic_op.h ## @@ -0,0 +1,331 @@ +/* + * Licensed to the Apache

[incubator-mxnet] branch master updated (05a0e5b -> e58623c)

2020-01-15 Thread haoj
This is an automated email from the ASF dual-hosted git repository. haoj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 05a0e5b Fix CosineEmbeddingLoss in when symbol API is used (#17308) add e58623c all/any_fix (#17314)

[incubator-mxnet] branch master updated (05a0e5b -> e58623c)

2020-01-15 Thread haoj
This is an automated email from the ASF dual-hosted git repository. haoj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 05a0e5b Fix CosineEmbeddingLoss in when symbol API is used (#17308) add e58623c all/any_fix (#17314)

[GitHub] [incubator-mxnet] zhhoper commented on issue #17231: cannot quantization example

2020-01-15 Thread GitBox
zhhoper commented on issue #17231: cannot quantization example URL: https://github.com/apache/incubator-mxnet/issues/17231#issuecomment-574543735 @wuxun-zhang @ZhennanQin I run the example using mxnet 1.6.0, it seems to work ok. However, the run time of quantized model is much slower

[GitHub] [incubator-mxnet] haojin2 merged pull request #17314: all/any_fix [Numpy]

2020-01-15 Thread GitBox
haojin2 merged pull request #17314: all/any_fix [Numpy] URL: https://github.com/apache/incubator-mxnet/pull/17314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17316: [NumPy] add op random.laplace

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17316: [NumPy] add op random.laplace URL: https://github.com/apache/incubator-mxnet/pull/17316#discussion_r366767094 ## File path: python/mxnet/symbol/numpy/random.py ## @@ -290,6 +290,54 @@ def choice(a, size=None,

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17254: [numpy] change unary infer type

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17254: [numpy] change unary infer type URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r366773395 ## File path: src/operator/tensor/elemwise_binary_op.h ## @@ -525,6 +525,67 @@ class ElemwiseBinaryOp :

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17254: [numpy] change unary infer type

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17254: [numpy] change unary infer type URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r366773595 ## File path: src/operator/tensor/elemwise_unary_op.h ## @@ -252,6 +252,39 @@ class UnaryOp : public

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17254: [numpy] change unary infer type

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17254: [numpy] change unary infer type URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r366773091 ## File path: src/operator/tensor/elemwise_binary_op.h ## @@ -525,6 +525,67 @@ class ElemwiseBinaryOp :

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17254: [numpy] change unary infer type

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17254: [numpy] change unary infer type URL: https://github.com/apache/incubator-mxnet/pull/17254#discussion_r366778630 ## File path: src/operator/tensor/elemwise_binary_op.h ## @@ -525,6 +525,67 @@ class ElemwiseBinaryOp :

[GitHub] [incubator-mxnet] kshitij12345 opened a new pull request #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh

2020-01-15 Thread GitBox
kshitij12345 opened a new pull request #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh URL: https://github.com/apache/incubator-mxnet/pull/17321 @apeforest @reminisce Going through the code for `_backward_tanh`, it is implemented as `1 - (tanh^2(x))`, which is

[GitHub] [incubator-mxnet] kshitij12345 commented on issue #15530: [MXNET-978] Higher Order Gradient Support `arcsinh`, `arccosh`.

2020-01-15 Thread GitBox
kshitij12345 commented on issue #15530: [MXNET-978] Higher Order Gradient Support `arcsinh`, `arccosh`. URL: https://github.com/apache/incubator-mxnet/pull/15530#issuecomment-574596211 @larroy , Can you please check if it is always failing on windows system. I tried running with the

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17302: [numpy]add op random.logistic

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17302: [numpy]add op random.logistic URL: https://github.com/apache/incubator-mxnet/pull/17302#discussion_r366765107 ## File path: src/operator/numpy/random/np_logistic_op.h ## @@ -0,0 +1,331 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17302: [numpy]add op random.logistic

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17302: [numpy]add op random.logistic URL: https://github.com/apache/incubator-mxnet/pull/17302#discussion_r366765196 ## File path: src/operator/numpy/random/np_logistic_op.h ## @@ -0,0 +1,331 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-mxnet] liuzh91 opened a new pull request #17322: Add event handlers in validation handler

2020-01-15 Thread GitBox
liuzh91 opened a new pull request #17322: Add event handlers in validation handler URL: https://github.com/apache/incubator-mxnet/pull/17322 ## Description ## Add customized event handlers in `ValidationHandler`, fixes #17320 ## Checklist ## ### Essentials ### Please feel

[GitHub] [incubator-mxnet] hanke580 opened a new pull request #17323: [Numpy] Kron operator

2020-01-15 Thread GitBox
hanke580 opened a new pull request #17323: [Numpy] Kron operator URL: https://github.com/apache/incubator-mxnet/pull/17323 ## Description ## * Add Kron operator * Including Forward and Backward ## Checklist ## ### Essentials ### Please feel free to remove inapplicable

[GitHub] [incubator-mxnet] kshitij12345 commented on issue #17325: Fix Flaky Test Higher Order Grad

2020-01-15 Thread GitBox
kshitij12345 commented on issue #17325: Fix Flaky Test Higher Order Grad URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-574670206 @apeforest @larroy @sxjscience Please review. This is an automated

[incubator-mxnet] branch leezu-patch-1 updated: Update config.mk

2020-01-15 Thread lausen
This is an automated email from the ASF dual-hosted git repository. lausen pushed a commit to branch leezu-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/leezu-patch-1 by this push: new 78e3bb5 Update

[GitHub] [incubator-mxnet] leezu opened a new pull request #17324: USE_JEMALLOC=OFF by default

2020-01-15 Thread GitBox
leezu opened a new pull request #17324: USE_JEMALLOC=OFF by default URL: https://github.com/apache/incubator-mxnet/pull/17324 ## Description ## As of jemalloc 5, jemalloc default build can not be used in libraries that are dlopened. However, libmxnet.so is dlopened by Python (ctypes).

[GitHub] [incubator-mxnet] leezu commented on issue #15647: Segmentation fault: 11

2020-01-15 Thread GitBox
leezu commented on issue #15647: Segmentation fault: 11 URL: https://github.com/apache/incubator-mxnet/issues/15647#issuecomment-574623185 Please uninstall and reinstall mxnet This is an automated message from the Apache Git

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2020-01-15 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 8658d9b Bump the

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix

2020-01-15 Thread GitBox
leezu commented on a change in pull request #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix URL: https://github.com/apache/incubator-mxnet/pull/17293#discussion_r366856342 ## File path: CMakeLists.txt ## @@ -84,6 +84,10 @@ message(STATUS "CMake

[GitHub] [incubator-mxnet] leezu commented on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix

2020-01-15 Thread GitBox
leezu commented on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix URL: https://github.com/apache/incubator-mxnet/pull/17293#issuecomment-574643566 It's expected that to compile software, the compiler must be available. For that, it must be either on `$PATH`

[GitHub] [incubator-mxnet] codecov-io commented on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh

2020-01-15 Thread GitBox
codecov-io commented on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh URL: https://github.com/apache/incubator-mxnet/pull/17321#issuecomment-574647005 # [Codecov](https://codecov.io/gh/apache/incubator-mxnet/pull/17321?src=pr=h1) Report > Merging

[GitHub] [incubator-mxnet] codecov-io edited a comment on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh

2020-01-15 Thread GitBox
codecov-io edited a comment on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh URL: https://github.com/apache/incubator-mxnet/pull/17321#issuecomment-574647005 # [Codecov](https://codecov.io/gh/apache/incubator-mxnet/pull/17321?src=pr=h1) Report > Merging

[GitHub] [incubator-mxnet] codecov-io edited a comment on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh

2020-01-15 Thread GitBox
codecov-io edited a comment on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh URL: https://github.com/apache/incubator-mxnet/pull/17321#issuecomment-574647005 # [Codecov](https://codecov.io/gh/apache/incubator-mxnet/pull/17321?src=pr=h1) Report > Merging

[GitHub] [incubator-mxnet] codecov-io edited a comment on issue #17319: [BugFix] Fixes version comparison algorithm

2020-01-15 Thread GitBox
codecov-io edited a comment on issue #17319: [BugFix] Fixes version comparison algorithm URL: https://github.com/apache/incubator-mxnet/pull/17319#issuecomment-574631930 # [Codecov](https://codecov.io/gh/apache/incubator-mxnet/pull/17319?src=pr=h1) Report > Merging

[GitHub] [incubator-mxnet] codecov-io commented on issue #17319: [BugFix] Fixes version comparison algorithm

2020-01-15 Thread GitBox
codecov-io commented on issue #17319: [BugFix] Fixes version comparison algorithm URL: https://github.com/apache/incubator-mxnet/pull/17319#issuecomment-574631930 # [Codecov](https://codecov.io/gh/apache/incubator-mxnet/pull/17319?src=pr=h1) Report > Merging

[GitHub] [incubator-mxnet] codecov-io edited a comment on issue #17319: [BugFix] Fixes version comparison algorithm

2020-01-15 Thread GitBox
codecov-io edited a comment on issue #17319: [BugFix] Fixes version comparison algorithm URL: https://github.com/apache/incubator-mxnet/pull/17319#issuecomment-574631930 # [Codecov](https://codecov.io/gh/apache/incubator-mxnet/pull/17319?src=pr=h1) Report > Merging

[GitHub] [incubator-mxnet] ZheyuYe opened a new issue #17327: np.ndarray indexing after hybridize

2020-01-15 Thread GitBox
ZheyuYe opened a new issue #17327: np.ndarray indexing after hybridize URL: https://github.com/apache/incubator-mxnet/issues/17327 ## Description Indexing is an important feature of numpy that supports complex positioning and value operations as [Numpy |

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix

2020-01-15 Thread GitBox
leezu commented on a change in pull request #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix URL: https://github.com/apache/incubator-mxnet/pull/17293#discussion_r366856342 ## File path: CMakeLists.txt ## @@ -84,6 +84,10 @@ message(STATUS "CMake

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix

2020-01-15 Thread GitBox
leezu commented on a change in pull request #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix URL: https://github.com/apache/incubator-mxnet/pull/17293#discussion_r366920430 ## File path: CMakeLists.txt ## @@ -84,6 +84,10 @@ message(STATUS "CMake

[GitHub] [incubator-mxnet] codecov-io edited a comment on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh

2020-01-15 Thread GitBox
codecov-io edited a comment on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh URL: https://github.com/apache/incubator-mxnet/pull/17321#issuecomment-574647005 # [Codecov](https://codecov.io/gh/apache/incubator-mxnet/pull/17321?src=pr=h1) Report > Merging

[GitHub] [incubator-mxnet] ptrendx commented on a change in pull request #17265: Add bfloat16 floating-point format support based on AMP

2020-01-15 Thread GitBox
ptrendx commented on a change in pull request #17265: Add bfloat16 floating-point format support based on AMP URL: https://github.com/apache/incubator-mxnet/pull/17265#discussion_r366978831 ## File path: 3rdparty/mshadow/mshadow/base.h ## @@ -988,6 +1034,7 @@ struct

[GitHub] [incubator-mxnet] haojin2 commented on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh

2020-01-15 Thread GitBox
haojin2 commented on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh URL: https://github.com/apache/incubator-mxnet/pull/17321#issuecomment-574773304 @kshitij12345 Have you tried to run this new version with > 500 trials?

[GitHub] [incubator-mxnet] apeforest commented on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix

2020-01-15 Thread GitBox
apeforest commented on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix URL: https://github.com/apache/incubator-mxnet/pull/17293#issuecomment-574792629 @larroy In which environment did you see this problem? Could you paste the diagnose.py result here?

[GitHub] [incubator-mxnet] CassiniXu opened a new pull request #17328: [numpy] add op pad

2020-01-15 Thread GitBox
CassiniXu opened a new pull request #17328: [numpy] add op pad URL: https://github.com/apache/incubator-mxnet/pull/17328 ## Description ## add op pad ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ ] The PR title starts

[GitHub] [incubator-mxnet] anjishnu edited a comment on issue #17298: [MXNET-1438] Adding SDML loss function

2020-01-15 Thread GitBox
anjishnu edited a comment on issue #17298: [MXNET-1438] Adding SDML loss function URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-574802286 @haojin2 if I randomized the input data in the original test code the losses would would have different values during each run

[GitHub] [incubator-mxnet] anjishnu commented on issue #17298: [MXNET-1438] Adding SDML loss function

2020-01-15 Thread GitBox
anjishnu commented on issue #17298: [MXNET-1438] Adding SDML loss function URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-574802286 @haojin2 if I randomized the input data in the original test code the losses would would have different values during each run (SDML

[GitHub] [incubator-mxnet] ptrendx commented on a change in pull request #17265: Add bfloat16 floating-point format support based on AMP

2020-01-15 Thread GitBox
ptrendx commented on a change in pull request #17265: Add bfloat16 floating-point format support based on AMP URL: https://github.com/apache/incubator-mxnet/pull/17265#discussion_r366948096 ## File path: 3rdparty/mshadow/mshadow/base.h ## @@ -988,6 +1034,7 @@ struct

[GitHub] [incubator-mxnet] kshitij12345 commented on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh

2020-01-15 Thread GitBox
kshitij12345 commented on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh URL: https://github.com/apache/incubator-mxnet/pull/17321#issuecomment-574775392 @haojin2 , Hi can you tell me how I can do that.

[GitHub] [incubator-mxnet] haojin2 commented on issue #17298: [MXNET-1438] Adding SDML loss function

2020-01-15 Thread GitBox
haojin2 commented on issue #17298: [MXNET-1438] Adding SDML loss function URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-574779763 @anjishnu I was actually only asking for getting the input data randomized with the original version of test code untouched.

[GitHub] [incubator-mxnet] kshitij12345 commented on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh

2020-01-15 Thread GitBox
kshitij12345 commented on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh URL: https://github.com/apache/incubator-mxnet/pull/17321#issuecomment-574789490 @apeforest @haojin2 , Yes I have seen that it is happening for `arcsin` and `arctanh` as well as #16739.

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17297: Fix NCCL Cmake autodetect issue

2020-01-15 Thread GitBox
ChaiBapchya commented on issue #17297: Fix NCCL Cmake autodetect issue URL: https://github.com/apache/incubator-mxnet/pull/17297#issuecomment-574796638 Verified this works by running following Fresh cmake build ``` rm -rf build mkdir -p build && cd build cmake -GNinja \

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2020-01-15 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 84b1c08 Bump the

[GitHub] [incubator-mxnet] haojin2 commented on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh

2020-01-15 Thread GitBox
haojin2 commented on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh URL: https://github.com/apache/incubator-mxnet/pull/17321#issuecomment-574777476 @kshitij12345 like this: `MXNET_TEST_COUNT=500 nosetests

[GitHub] [incubator-mxnet] apeforest commented on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh

2020-01-15 Thread GitBox
apeforest commented on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh URL: https://github.com/apache/incubator-mxnet/pull/17321#issuecomment-574787894 @kshitij12345 Could you please also do so for other operators? I suspect they might have similar issues as

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs

2020-01-15 Thread GitBox
access2rohit commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs URL: https://github.com/apache/incubator-mxnet/pull/17309#discussion_r367037006 ## File path: include/mxnet/c_api.h ## @@

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs

2020-01-15 Thread GitBox
access2rohit commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs URL: https://github.com/apache/incubator-mxnet/pull/17309#discussion_r367037006 ## File path: include/mxnet/c_api.h ## @@

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17297: Fix NCCL Cmake autodetect issue

2020-01-15 Thread GitBox
ChaiBapchya commented on issue #17297: Fix NCCL Cmake autodetect issue URL: https://github.com/apache/incubator-mxnet/pull/17297#issuecomment-574798885 @mxnet-label-bot [pr-awaiting-review] This is an automated message from

[GitHub] [incubator-mxnet] aaronmarkham edited a comment on issue #17244: Incorrect installation instruction

2020-01-15 Thread GitBox
aaronmarkham edited a comment on issue #17244: Incorrect installation instruction URL: https://github.com/apache/incubator-mxnet/issues/17244#issuecomment-574759781 > @aaronmarkham what's the alternative solution you're proposing? Maybe mxnet-oncall can spend time looking at the

[GitHub] [incubator-mxnet] aaronmarkham commented on issue #17244: Incorrect installation instruction

2020-01-15 Thread GitBox
aaronmarkham commented on issue #17244: Incorrect installation instruction URL: https://github.com/apache/incubator-mxnet/issues/17244#issuecomment-574759781 > @aaronmarkham what's the alternative solution you're proposing? Maybe mxnet-oncall can spend time looking at the js function

[GitHub] [incubator-mxnet] kshitij12345 commented on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh

2020-01-15 Thread GitBox
kshitij12345 commented on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh URL: https://github.com/apache/incubator-mxnet/pull/17321#issuecomment-574786882 @haojin2 Thank You. That helped, first order test failed once. Have relaxed the tolerance for first

[GitHub] [incubator-mxnet] kshitij12345 commented on issue #17325: Fix Flaky Test Higher Order Grad

2020-01-15 Thread GitBox
kshitij12345 commented on issue #17325: Fix Flaky Test Higher Order Grad URL: https://github.com/apache/incubator-mxnet/pull/17325#issuecomment-574789821 It is failing the test with multiple trials. Still needs to be fixed.

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #17305: grouping large array tests based on type and updating nightly CI funtion

2020-01-15 Thread GitBox
access2rohit commented on a change in pull request #17305: grouping large array tests based on type and updating nightly CI funtion URL: https://github.com/apache/incubator-mxnet/pull/17305#discussion_r367048895 ## File path: tests/nightly/test_large_array.py ## @@

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17311: Added beamsearch_set_finished Operator

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17311: Added beamsearch_set_finished Operator URL: https://github.com/apache/incubator-mxnet/pull/17311#discussion_r367028141 ## File path: src/operator/contrib/beamsearch_set_finished.cc ## @@ -0,0 +1,66 @@ +#include

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17311: Added beamsearch_set_finished Operator

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17311: Added beamsearch_set_finished Operator URL: https://github.com/apache/incubator-mxnet/pull/17311#discussion_r367027893 ## File path: src/operator/contrib/beamsearch_set_finished-inl.h ## @@ -0,0 +1,148 @@ +#include +

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17311: Added beamsearch_set_finished Operator

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17311: Added beamsearch_set_finished Operator URL: https://github.com/apache/incubator-mxnet/pull/17311#discussion_r367028420 ## File path: tests/python/gpu/test_operator_gpu.py ## @@ -1698,6 +1698,54 @@ def

[GitHub] [incubator-mxnet] apeforest commented on issue #17181: Fail to build mxnet from source

2020-01-15 Thread GitBox
apeforest commented on issue #17181: Fail to build mxnet from source URL: https://github.com/apache/incubator-mxnet/issues/17181#issuecomment-574793797 Okay if I follow all the instructions on the web to apt update all required packages, I no longer face the issue. I guess it's probably I

[GitHub] [incubator-mxnet] ChaiBapchya edited a comment on issue #17297: Fix NCCL Cmake autodetect issue

2020-01-15 Thread GitBox
ChaiBapchya edited a comment on issue #17297: Fix NCCL Cmake autodetect issue URL: https://github.com/apache/incubator-mxnet/pull/17297#issuecomment-574798885 @mxnet-label-bot add [pr-awaiting-review] This is an automated

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17311: Added beamsearch_set_finished Operator

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17311: Added beamsearch_set_finished Operator URL: https://github.com/apache/incubator-mxnet/pull/17311#discussion_r367027893 ## File path: src/operator/contrib/beamsearch_set_finished-inl.h ## @@ -0,0 +1,148 @@ +#include +

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs

2020-01-15 Thread GitBox
access2rohit commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs URL: https://github.com/apache/incubator-mxnet/pull/17309#discussion_r367037006 ## File path: include/mxnet/c_api.h ## @@

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs

2020-01-15 Thread GitBox
access2rohit commented on a change in pull request #17309: adding docs for 64bit C APIs of large tensor and removing not required int64 C APIs URL: https://github.com/apache/incubator-mxnet/pull/17309#discussion_r367037006 ## File path: include/mxnet/c_api.h ## @@

[GitHub] [incubator-mxnet] anirudh2290 commented on issue #16654: Multithreaded Inference Support

2020-01-15 Thread GitBox
anirudh2290 commented on issue #16654: Multithreaded Inference Support URL: https://github.com/apache/incubator-mxnet/pull/16654#issuecomment-574818547 @rondogency I am happy to add more comments for the thread safe cached op or the code that I have touched in this PR.

[GitHub] [incubator-mxnet] larroy commented on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix

2020-01-15 Thread GitBox
larroy commented on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix URL: https://github.com/apache/incubator-mxnet/pull/17293#issuecomment-574833068 @apeforest ubuntu 18.04 with nvidia machine learning APT repositories, pretty standard. I will update with

[GitHub] [incubator-mxnet] eric-haibin-lin commented on issue #17292: Can't run horovod with latest nightly wheel

2020-01-15 Thread GitBox
eric-haibin-lin commented on issue #17292: Can't run horovod with latest nightly wheel URL: https://github.com/apache/incubator-mxnet/issues/17292#issuecomment-574832896 @szha This is an automated message from the Apache

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix

2020-01-15 Thread GitBox
larroy commented on a change in pull request #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix URL: https://github.com/apache/incubator-mxnet/pull/17293#discussion_r367079684 ## File path: CMakeLists.txt ## @@ -84,6 +84,10 @@ message(STATUS "CMake

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix

2020-01-15 Thread GitBox
larroy commented on a change in pull request #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix URL: https://github.com/apache/incubator-mxnet/pull/17293#discussion_r367079561 ## File path: CMakeLists.txt ## @@ -84,6 +84,10 @@ message(STATUS "CMake

[GitHub] [incubator-mxnet] apeforest edited a comment on issue #17292: Can't run horovod with latest nightly wheel

2020-01-15 Thread GitBox
apeforest edited a comment on issue #17292: Can't run horovod with latest nightly wheel URL: https://github.com/apache/incubator-mxnet/issues/17292#issuecomment-574848779 Thanks @stephenrawls for the analysis. Here are the causes of the problem: 1) Horovod uses MX_API_BEGIN()

[GitHub] [incubator-mxnet] haojin2 commented on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh

2020-01-15 Thread GitBox
haojin2 commented on issue #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh URL: https://github.com/apache/incubator-mxnet/pull/17321#issuecomment-574882067 Merged, please continue with fixing other flaky higher-order gradient tests @kshitij12345

[GitHub] [incubator-mxnet] haojin2 closed issue #17304: [flaky] test_higher_order_grad.test_tanh

2020-01-15 Thread GitBox
haojin2 closed issue #17304: [flaky] test_higher_order_grad.test_tanh URL: https://github.com/apache/incubator-mxnet/issues/17304 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-mxnet] haojin2 merged pull request #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh

2020-01-15 Thread GitBox
haojin2 merged pull request #17321: Fixes #17304 Flaky Test -> test_higher_order_grad.test_tanh URL: https://github.com/apache/incubator-mxnet/pull/17321 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-mxnet] roywei opened a new issue #17329: License issue with 1.6.0.rc1

2020-01-15 Thread GitBox
roywei opened a new issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329 Following are the license issue found by mentors during 1.6.0.rc1 vote @general.

[GitHub] [incubator-mxnet] leezu commented on issue #17181: Fail to build mxnet from source

2020-01-15 Thread GitBox
leezu commented on issue #17181: Fail to build mxnet from source URL: https://github.com/apache/incubator-mxnet/issues/17181#issuecomment-574822917 I'll close this issue for now, please reopen @mjsML if you can still reproduce this.

[GitHub] [incubator-mxnet] leezu closed issue #17181: Fail to build mxnet from source

2020-01-15 Thread GitBox
leezu closed issue #17181: Fail to build mxnet from source URL: https://github.com/apache/incubator-mxnet/issues/17181 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-mxnet] haojin2 commented on issue #17302: [numpy]add op random.logistic

2020-01-15 Thread GitBox
haojin2 commented on issue #17302: [numpy]add op random.logistic URL: https://github.com/apache/incubator-mxnet/pull/17302#issuecomment-574875122 also, fix the sanity issues: ``` src/operator/numpy/random/np_logistic_op.h:331: #endif line should be "#endif //

[GitHub] [incubator-mxnet] sxjscience commented on issue #17327: np.ndarray indexing after hybridize

2020-01-15 Thread GitBox
sxjscience commented on issue #17327: np.ndarray indexing after hybridize URL: https://github.com/apache/incubator-mxnet/issues/17327#issuecomment-574875177 @ZheyuYe In terms of `mx.npx.pick` we can support multiple-dimensional selection as long as we are selecting the leading ones:

[GitHub] [incubator-mxnet] roywei opened a new pull request #17330: update notice

2020-01-15 Thread GitBox
roywei opened a new pull request #17330: update notice URL: https://github.com/apache/incubator-mxnet/pull/17330 ## Description ## fix NOTICE issues in https://github.com/apache/incubator-mxnet/issues/17329 Looks like we have to specify the current year and update it every year.

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17323: [Numpy] Kron operator

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17323: [Numpy] Kron operator URL: https://github.com/apache/incubator-mxnet/pull/17323#discussion_r367131577 ## File path: tests/python/unittest/test_numpy_op.py ## @@ -418,6 +418,55 @@ def hybrid_forward(self, F, a, b):

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17328: [numpy] add op pad

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17328: [numpy] add op pad URL: https://github.com/apache/incubator-mxnet/pull/17328#discussion_r367138993 ## File path: python/mxnet/numpy/multiarray.py ## @@ -8517,3 +8516,98 @@ def bincount(x, weights=None, minlength=0):

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17328: [numpy] add op pad

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17328: [numpy] add op pad URL: https://github.com/apache/incubator-mxnet/pull/17328#discussion_r367139109 ## File path: python/mxnet/numpy/multiarray.py ## @@ -8467,7 +8467,6 @@ def where(condition, x=None, y=None): """

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17328: [numpy] add op pad

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17328: [numpy] add op pad URL: https://github.com/apache/incubator-mxnet/pull/17328#discussion_r367139190 ## File path: python/mxnet/numpy/multiarray.py ## @@ -8517,3 +8516,98 @@ def bincount(x, weights=None, minlength=0):

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17328: [numpy] add op pad

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17328: [numpy] add op pad URL: https://github.com/apache/incubator-mxnet/pull/17328#discussion_r367139047 ## File path: python/mxnet/numpy/multiarray.py ## @@ -8517,3 +8516,98 @@ def bincount(x, weights=None, minlength=0):

[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #16654: Multithreaded Inference Support

2020-01-15 Thread GitBox
anirudh2290 commented on a change in pull request #16654: Multithreaded Inference Support URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r367063730 ## File path: src/imperative/cached_op_threadsafe.cc ## @@ -0,0 +1,329 @@ +/* + * Licensed to the

[GitHub] [incubator-mxnet] apeforest commented on issue #17292: Can't run horovod with latest nightly wheel

2020-01-15 Thread GitBox
apeforest commented on issue #17292: Can't run horovod with latest nightly wheel URL: https://github.com/apache/incubator-mxnet/issues/17292#issuecomment-574848779 Thanks @stephenrawls for the analysis. Here is the rootcause of the problem: 1) Horovod uses MX_API_BEGIN() and

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17323: [Numpy] Kron operator

2020-01-15 Thread GitBox
haojin2 commented on a change in pull request #17323: [Numpy] Kron operator URL: https://github.com/apache/incubator-mxnet/pull/17323#discussion_r367133643 ## File path: src/operator/numpy/np_kron-inl.h ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-mxnet] roywei commented on issue #17329: License issue with 1.6.0.rc1

2020-01-15 Thread GitBox
roywei commented on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-574831171 @hzfan @reminisce @haojin2 Looks like we need to remove the ASF header if this file is directly copied from numpy, and add it to whitelist of

  1   2   3   >