[GitHub] pengzhao-intel commented on issue #9828: Building with MKL fails on OSX

2018-02-26 Thread GitBox
pengzhao-intel commented on issue #9828: Building with MKL fails on OSX URL: https://github.com/apache/incubator-mxnet/issues/9828#issuecomment-368712362 Update: This bug is fixed in MKL-DNN and the patch will be ready in the official branch soon. @xinyu-intel

[GitHub] pengzhao-intel commented on issue #9828: Building with MKL fails on OSX

2018-02-26 Thread GitBox
pengzhao-intel commented on issue #9828: Building with MKL fails on OSX URL: https://github.com/apache/incubator-mxnet/issues/9828#issuecomment-368712362 Update: This bug is fixed in MKL-DNN and the patch will be ready in the official branch soon. @xiinyu-intel

[GitHub] pengzhao-intel commented on issue #9828: Building with MKL fails on OSX

2018-02-26 Thread GitBox
pengzhao-intel commented on issue #9828: Building with MKL fails on OSX URL: https://github.com/apache/incubator-mxnet/issues/9828#issuecomment-368712362 Update: This bug is fixed in MKL-DNN and the patch will be ready in the official branch soon. @xinyulab

[GitHub] thinksanky commented on issue #9896: Updated build_doc.sh to build on the new release tag found

2018-02-26 Thread GitBox
thinksanky commented on issue #9896: Updated build_doc.sh to build on the new release tag found URL: https://github.com/apache/incubator-mxnet/pull/9896#issuecomment-368772292 * Testing: Currently building on ubuntu. I can see the extracted tag and building it when found, but the build

[GitHub] thinksanky opened a new pull request #9896: Updated build_doc.sh to build on the new release tag found

2018-02-26 Thread GitBox
thinksanky opened a new pull request #9896: Updated build_doc.sh to build on the new release tag found URL: https://github.com/apache/incubator-mxnet/pull/9896 ## Description ## - Checked out the new release tag if found and do makes docs on it. - Rest of the logic stays same. -

[GitHub] thinksanky opened a new pull request #9895: updated version to 1.1.0

2018-02-26 Thread GitBox
thinksanky opened a new pull request #9895: updated version to 1.1.0 URL: https://github.com/apache/incubator-mxnet/pull/9895 ## Description ## Update Version number to 1.1.0 This is an automated message from the Apache

[GitHub] pengzhao-intel commented on issue #9545: Profiling discussion

2018-02-26 Thread GitBox
pengzhao-intel commented on issue #9545: Profiling discussion URL: https://github.com/apache/incubator-mxnet/issues/9545#issuecomment-368759486 @cjolivier01 I come back to this discussion regarding MKL-DNN backend profiling :) Now, adding the env "export MKLDNN_VERBOSE =1" and run

[GitHub] jeremiedb commented on issue #9625: sparse regression operators

2018-02-26 Thread GitBox
jeremiedb commented on issue #9625: sparse regression operators URL: https://github.com/apache/incubator-mxnet/pull/9625#issuecomment-368752590 @ZiyueHuang The issue with `Matrix Factorization` seems to comes from the `label` argument to the regressionOutput operator being named as `score`

[GitHub] arokem opened a new issue #9894: Undefined name `get_cifar10_iterator` in gluon image_classification example

2018-02-26 Thread GitBox
arokem opened a new issue #9894: Undefined name `get_cifar10_iterator` in gluon image_classification example URL: https://github.com/apache/incubator-mxnet/issues/9894 Note: Providing complete information in the most concise form is the best way to get help. This issue template serves as

[GitHub] billhyde commented on issue #8707: Fail to build amalgamation for Android in latest version

2018-02-26 Thread GitBox
billhyde commented on issue #8707: Fail to build amalgamation for Android in latest version URL: https://github.com/apache/incubator-mxnet/issues/8707#issuecomment-368732166 @someoneAlready Thank you for your reply, I will try it. Thanks

[GitHub] ZiyueHuang commented on issue #9625: sparse regression operators

2018-02-26 Thread GitBox
ZiyueHuang commented on issue #9625: sparse regression operators URL: https://github.com/apache/incubator-mxnet/pull/9625#issuecomment-368732046 Hi @thirdwing @jeremiedb , R-test fails on `Matrix Factorization` > test_model.R:242: error: Matrix Factorization [16:33:22]

[GitHub] someoneAlready commented on issue #8707: Fail to build amalgamation for Android in latest version

2018-02-26 Thread GitBox
someoneAlready commented on issue #8707: Fail to build amalgamation for Android in latest version URL: https://github.com/apache/incubator-mxnet/issues/8707#issuecomment-368729480 @billhyde I use [docker](https://github.com/apache/incubator-mxnet/tree/master/docker_multiarch) to build

[GitHub] someoneAlready commented on issue #8707: Fail to build amalgamation for Android in latest version

2018-02-26 Thread GitBox
someoneAlready commented on issue #8707: Fail to build amalgamation for Android in latest version URL: https://github.com/apache/incubator-mxnet/issues/8707#issuecomment-368729480 @billhyde I use [docker](https://github.com/apache/incubator-mxnet/tree/master/docker_multiarch) to build

[GitHub] billhyde commented on issue #8707: Fail to build amalgamation for Android in latest version

2018-02-26 Thread GitBox
billhyde commented on issue #8707: Fail to build amalgamation for Android in latest version URL: https://github.com/apache/incubator-mxnet/issues/8707#issuecomment-368727944 @someoneAlready I meet the same problem,have you solve this?

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

2018-02-26 Thread GitBox
tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368727403 This design is certainly unconventional and takes me a while to come up with it, in a sense that it tries to achieve something

[GitHub] tqchen commented on a change in pull request #9880: TVM bridge support to JIT NDArray Function by TVM

2018-02-26 Thread GitBox
tqchen commented on a change in pull request #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#discussion_r170800127 ## File path: src/nnvm/tvm_bridge.cc ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache

[GitHub] ascust commented on issue #9885: A question about Operator "crop" and "slice".

2018-02-26 Thread GitBox
ascust commented on issue #9885: A question about Operator "crop" and "slice". URL: https://github.com/apache/incubator-mxnet/issues/9885#issuecomment-368722912 @reminisce For fixed-sized input, your way has no problem, but image we have various input size for both "data" and "ref", we

[GitHub] piiswrong commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

2018-02-26 Thread GitBox
piiswrong commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368722092 I understand that this is a quick hack to plug TVM support to mxnet NDArray and I think we should merge it for the time

[GitHub] piiswrong commented on a change in pull request #9880: TVM bridge support to JIT NDArray Function by TVM

2018-02-26 Thread GitBox
piiswrong commented on a change in pull request #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#discussion_r170796863 ## File path: src/nnvm/tvm_bridge.cc ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache

[GitHub] thbupt commented on issue #9420: add use_global_stats in nn.BatchNorm

2018-02-26 Thread GitBox
thbupt commented on issue #9420: add use_global_stats in nn.BatchNorm URL: https://github.com/apache/incubator-mxnet/pull/9420#issuecomment-368721069 @7oud I think 8 is too small for bn, you can try larger bz like 16, 32.

[GitHub] piiswrong opened a new pull request #9893: Add constant parameter

2018-02-26 Thread GitBox
piiswrong opened a new pull request #9893: Add constant parameter URL: https://github.com/apache/incubator-mxnet/pull/9893 ## Description ## (Brief description on what this PR is about) ## Checklist ## ### Essentials ### - [ ] Passed code style checking (`make lint`) - [

[GitHub] JulianSlzr commented on a change in pull request #9877: Better even_split=False support in gluon.split_data()

2018-02-26 Thread GitBox
JulianSlzr commented on a change in pull request #9877: Better even_split=False support in gluon.split_data() URL: https://github.com/apache/incubator-mxnet/pull/9877#discussion_r170796056 ## File path: python/mxnet/gluon/utils.py ## @@ -56,13 +56,10 @@ def

[GitHub] yancz1989 commented on issue #9888: get runtime error when compile and install

2018-02-26 Thread GitBox
yancz1989 commented on issue #9888: get runtime error when compile and install URL: https://github.com/apache/incubator-mxnet/issues/9888#issuecomment-368717591 I found if I use "import requests" first, it would run smoothly. This should be a dependency problem, I suggest the develop team

[GitHub] piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet

2018-02-26 Thread GitBox
piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet URL: https://github.com/apache/incubator-mxnet/pull/9892#discussion_r170791350 ## File path: python/mxnet/contrib/serde/_import/backend.py ## @@

[GitHub] piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet

2018-02-26 Thread GitBox
piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet URL: https://github.com/apache/incubator-mxnet/pull/9892#discussion_r170791109 ## File path: python/mxnet/contrib/serde/_export/__init__.py ## @@

[GitHub] piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet

2018-02-26 Thread GitBox
piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet URL: https://github.com/apache/incubator-mxnet/pull/9892#discussion_r170793607 ## File path: python/mxnet/contrib/serde/_import/import_onnx.py ##

[GitHub] piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet

2018-02-26 Thread GitBox
piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet URL: https://github.com/apache/incubator-mxnet/pull/9892#discussion_r170793654 ## File path: python/mxnet/contrib/serde/_import/import_onnx.py ##

[GitHub] piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet

2018-02-26 Thread GitBox
piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet URL: https://github.com/apache/incubator-mxnet/pull/9892#discussion_r170791122 ## File path: python/mxnet/contrib/__init__.py ## @@ -28,3 +28,4 @@

[GitHub] piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet

2018-02-26 Thread GitBox
piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet URL: https://github.com/apache/incubator-mxnet/pull/9892#discussion_r170793263 ## File path: python/mxnet/contrib/serde/_import/tests/onnx_backend_test.py

[GitHub] piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet

2018-02-26 Thread GitBox
piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet URL: https://github.com/apache/incubator-mxnet/pull/9892#discussion_r170792427 ## File path: python/mxnet/contrib/serde/_import/common.py ## @@

[GitHub] 7oud commented on issue #9420: add use_global_stats in nn.BatchNorm

2018-02-26 Thread GitBox
7oud commented on issue #9420: add use_global_stats in nn.BatchNorm URL: https://github.com/apache/incubator-mxnet/pull/9420#issuecomment-368716803 @thbupt batch size in training is 8, and in inference is usually 1. This is

[GitHub] cjolivier01 commented on issue #9868: MKL and CMake

2018-02-26 Thread GitBox
cjolivier01 commented on issue #9868: MKL and CMake URL: https://github.com/apache/incubator-mxnet/issues/9868#issuecomment-368716489 ...or @pengzhao-intel or @jinhuang415 or someone who is more familiar with the changes

[GitHub] cjolivier01 commented on issue #9868: MKL and CMake

2018-02-26 Thread GitBox
cjolivier01 commented on issue #9868: MKL and CMake URL: https://github.com/apache/incubator-mxnet/issues/9868#issuecomment-368716124 I don?t know what?s still left of USE_MKLML_MKL, so I?ll leave it to @zheng-da?s judgement

[GitHub] tornadomeet commented on issue #9420: add use_global_stats in nn.BatchNorm

2018-02-26 Thread GitBox
tornadomeet commented on issue #9420: add use_global_stats in nn.BatchNorm URL: https://github.com/apache/incubator-mxnet/pull/9420#issuecomment-368715334 @7oud the correct way which using bn during training from scratch is setting `use_global_status=False`; just make

[GitHub] thbupt commented on issue #9420: add use_global_stats in nn.BatchNorm

2018-02-26 Thread GitBox
thbupt commented on issue #9420: add use_global_stats in nn.BatchNorm URL: https://github.com/apache/incubator-mxnet/pull/9420#issuecomment-368715232 @7oud how about your batch size? bn seems to prefer large batch size. This

[GitHub] reminisce commented on issue #9885: A question about Operator "crop" and "slice".

2018-02-26 Thread GitBox
reminisce commented on issue #9885: A question about Operator "crop" and "slice". URL: https://github.com/apache/incubator-mxnet/issues/9885#issuecomment-368715135 I don't know why `Crop` is deprecated, but it looks like so. As I said in a previous comment, you can use `slice` to achieve

[GitHub] tornadomeet commented on issue #9420: add use_global_stats in nn.BatchNorm

2018-02-26 Thread GitBox
tornadomeet commented on issue #9420: add use_global_stats in nn.BatchNorm URL: https://github.com/apache/incubator-mxnet/pull/9420#issuecomment-368713864 @7oud do you mean in your small task, set `use_global_stats=True` during training will get better result than `use_global_stats=False`

[GitHub] 7oud commented on issue #9420: add use_global_stats in nn.BatchNorm

2018-02-26 Thread GitBox
7oud commented on issue #9420: add use_global_stats in nn.BatchNorm URL: https://github.com/apache/incubator-mxnet/pull/9420#issuecomment-368714486 @tornadomeet it seems that, but I cannot give the conclusion, bcz the dataset is too small to giving truth

[GitHub] tornadomeet commented on issue #9420: add use_global_stats in nn.BatchNorm

2018-02-26 Thread GitBox
tornadomeet commented on issue #9420: add use_global_stats in nn.BatchNorm URL: https://github.com/apache/incubator-mxnet/pull/9420#issuecomment-368713864 @7oud do you mean in your small task, set `use_global_stats=True` during training will get better result than `use_global_stats=False`

[GitHub] thbupt commented on issue #9420: add use_global_stats in nn.BatchNorm

2018-02-26 Thread GitBox
thbupt commented on issue #9420: add use_global_stats in nn.BatchNorm URL: https://github.com/apache/incubator-mxnet/pull/9420#issuecomment-368714220 @tornadomeet Is there a simple way to set all use_global_status=True as finetuning. I know one way is to set use_global_status=True for

[GitHub] 7oud commented on issue #9420: add use_global_stats in nn.BatchNorm

2018-02-26 Thread GitBox
7oud commented on issue #9420: add use_global_stats in nn.BatchNorm URL: https://github.com/apache/incubator-mxnet/pull/9420#issuecomment-368713958 @thbupt Actually I did like what you said, but the same data batch has different output when using forward(is_train=False) and

[GitHub] tornadomeet commented on issue #9420: add use_global_stats in nn.BatchNorm

2018-02-26 Thread GitBox
tornadomeet commented on issue #9420: add use_global_stats in nn.BatchNorm URL: https://github.com/apache/incubator-mxnet/pull/9420#issuecomment-368713864 @7oud do you mean in your small task, set `use_global_stats=True` during training will get better result than `use_global_stats=False`

[GitHub] piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet

2018-02-26 Thread GitBox
piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet URL: https://github.com/apache/incubator-mxnet/pull/9892#discussion_r170791038 ## File path: python/mxnet/contrib/__init__.py ## @@ -28,3 +28,4 @@

[GitHub] ascust commented on issue #9885: A question about Operator "crop" and "slice".

2018-02-26 Thread GitBox
ascust commented on issue #9885: A question about Operator "crop" and "slice". URL: https://github.com/apache/incubator-mxnet/issues/9885#issuecomment-368713425 @reminisce It seems both Crop and crop are deprecated in the documentation. So are you saying the documentation is a bit

[GitHub] piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet

2018-02-26 Thread GitBox
piiswrong commented on a change in pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet URL: https://github.com/apache/incubator-mxnet/pull/9892#discussion_r170791038 ## File path: python/mxnet/contrib/__init__.py ## @@ -28,3 +28,4 @@

[GitHub] pengzhao-intel commented on issue #9828: Building with MKL fails on OSX

2018-02-26 Thread GitBox
pengzhao-intel commented on issue #9828: Building with MKL fails on OSX URL: https://github.com/apache/incubator-mxnet/issues/9828#issuecomment-368712362 Update: This bug is fixed in MKL-DNN and the patch will be ready in the official branch soon.

[GitHub] reminisce commented on issue #9885: A question about Operator "crop" and "slice".

2018-02-26 Thread GitBox
reminisce commented on issue #9885: A question about Operator "crop" and "slice". URL: https://github.com/apache/incubator-mxnet/issues/9885#issuecomment-368711743 I just checked the code, there is indeed a `Crop` (upper-case C) operator working as you described. What has been deprecated

[GitHub] pengzhao-intel commented on issue #9868: MKL and CMake

2018-02-26 Thread GitBox
pengzhao-intel commented on issue #9868: MKL and CMake URL: https://github.com/apache/incubator-mxnet/issues/9868#issuecomment-368711665 @jinhuang415 please take a look for this issue and file a PR to fix. This is an

[GitHub] jinhuang415 commented on a change in pull request #9810: remove MKL_EXPERIMENTAL and update make files for MKL-DNN

2018-02-26 Thread GitBox
jinhuang415 commented on a change in pull request #9810: remove MKL_EXPERIMENTAL and update make files for MKL-DNN URL: https://github.com/apache/incubator-mxnet/pull/9810#discussion_r170617385 ## File path: docker_multiarch/arm.crosscompile.mk ## @@ -115,13 +100,10 @@

[GitHub] 7oud commented on issue #9420: add use_global_stats in nn.BatchNorm

2018-02-26 Thread GitBox
7oud commented on issue #9420: add use_global_stats in nn.BatchNorm URL: https://github.com/apache/incubator-mxnet/pull/9420#issuecomment-368709872 @thbupt I found in some small dataset training tasks such as segmentation, the inference result is worse than training when using BatchNorm

[GitHub] iblis17 commented on issue #8727: jenkins: julia build script

2018-02-26 Thread GitBox
iblis17 commented on issue #8727: jenkins: julia build script URL: https://github.com/apache/incubator-mxnet/pull/8727#issuecomment-368709434 I agree your thought-process. cc (other MXNet.jl maintainer) @pluskid, @vchuravy . > then publishes it to a new repository, e.g.

[GitHub] anirudhacharya opened a new pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet

2018-02-26 Thread GitBox
anirudhacharya opened a new pull request #9892: [WIP] Serde Module for Import/Export of models between Onnx and Mxnet URL: https://github.com/apache/incubator-mxnet/pull/9892 ## Description ## ImportExport module based on this design doc -

[GitHub] tornadomeet commented on issue #9420: add use_global_stats in nn.BatchNorm

2018-02-26 Thread GitBox
tornadomeet commented on issue #9420: add use_global_stats in nn.BatchNorm URL: https://github.com/apache/incubator-mxnet/pull/9420#issuecomment-368707758 @7oud just as @thbupt said, it used for fine-tune pre-trained model, such as fix some layer which using bn during fine-tune. if with

[GitHub] zhanghang1989 commented on issue #9547: Implementing new operators in an external module

2018-02-26 Thread GitBox
zhanghang1989 commented on issue #9547: Implementing new operators in an external module URL: https://github.com/apache/incubator-mxnet/issues/9547#issuecomment-368705813 Agree. A feature similar to [PyTorch FFI](https://github.com/pytorch/extension-ffi) is desired.

[GitHub] Caenorst commented on issue #9874: ResNet-50 is slower on Volta since #8302

2018-02-26 Thread GitBox
Caenorst commented on issue #9874: ResNet-50 is slower on Volta since #8302 URL: https://github.com/apache/incubator-mxnet/issues/9874#issuecomment-368701787 It's averaged over 1200 batches, I'm ignoring the 100 first batches.

[GitHub] szha commented on issue #8638: allow_extra parameter in Line 652 in incubator-mxnet/python/mxnet/module/base_module.py needs to be removed to make things work

2018-02-26 Thread GitBox
szha commented on issue #8638: allow_extra parameter in Line 652 in incubator-mxnet/python/mxnet/module/base_module.py needs to be removed to make things work URL: https://github.com/apache/incubator-mxnet/issues/8638#issuecomment-368701198 @apache/mxnet-committers: This issue has been

[GitHub] reminisce commented on issue #9885: A question about Operator "crop" and "slice".

2018-02-26 Thread GitBox
reminisce commented on issue #9885: A question about Operator "crop" and "slice". URL: https://github.com/apache/incubator-mxnet/issues/9885#issuecomment-36879 Are you referring to the definition here: https://turi.com/products/create/docs/generated/graphlab.mxnet.symbol.Crop.html?

[GitHub] rahul003 commented on issue #9874: ResNet-50 is slower on Volta since #8302

2018-02-26 Thread GitBox
rahul003 commented on issue #9874: ResNet-50 is slower on Volta since #8302 URL: https://github.com/apache/incubator-mxnet/issues/9874#issuecomment-368699365 Are the speeds that you mention averages? If so, averaged over how many batches?

[GitHub] ascust commented on issue #9885: A question about Operator "crop" and "slice".

2018-02-26 Thread GitBox
ascust commented on issue #9885: A question about Operator "crop" and "slice". URL: https://github.com/apache/incubator-mxnet/issues/9885#issuecomment-368698180 @reminisce In the official doc, Crop the 2nd and 3rd dim of input data, with the corresponding size of h_w or with

[GitHub] reminisce commented on issue #9885: A question about Operator "crop" and "slice".

2018-02-26 Thread GitBox
reminisce commented on issue #9885: A question about Operator "crop" and "slice". URL: https://github.com/apache/incubator-mxnet/issues/9885#issuecomment-368697755 What is the role of `ref` here? What's the expected behavior of `Crop` in your code?

[GitHub] pharish93 commented on issue #9690: Possible memory leak with de-convolution operator in CPU mode

2018-02-26 Thread GitBox
pharish93 commented on issue #9690: Possible memory leak with de-convolution operator in CPU mode URL: https://github.com/apache/incubator-mxnet/issues/9690#issuecomment-368695565 hi @sxjscience sorry for the delay got held up with other work . I'll provide you updates soon

[GitHub] lupesko commented on issue #9874: ResNet-50 is slower on Volta since #8302

2018-02-26 Thread GitBox
lupesko commented on issue #9874: ResNet-50 is slower on Volta since #8302 URL: https://github.com/apache/incubator-mxnet/issues/9874#issuecomment-368694710 @piiswrong @zheng-da - please take a look, this degradation may be related to your commit.

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

2018-02-26 Thread GitBox
tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368694729 Thanks for the reviews! If there is no requests to change things today. I am going to merge this in tomorrow

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

2018-02-26 Thread GitBox
tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368693448 OK, will do an update in the python part as well This is an

[GitHub] anirudh2290 opened a new issue #9891: UTF-8 Support for Text Parsers

2018-02-26 Thread GitBox
anirudh2290 opened a new issue #9891: UTF-8 Support for Text Parsers URL: https://github.com/apache/incubator-mxnet/issues/9891 Please see: https://github.com/dmlc/dmlc-core/issues/372 This is an automated message from the

[GitHub] ascust commented on issue #9885: A question about Operator "crop" and "slice".

2018-02-26 Thread GitBox
ascust commented on issue #9885: A question about Operator "crop" and "slice". URL: https://github.com/apache/incubator-mxnet/issues/9885#issuecomment-368687459 @reminisce For example, for "crop", we can have something like this: ``` data = mx.sym.Variable("data") ref =

[GitHub] marcoabreu commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

2018-02-26 Thread GitBox
marcoabreu commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368687349 Not in the Python part and there's no link to where this number actually comes from. I personally would not know where to

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

2018-02-26 Thread GitBox
tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368686482 I added comment in the declaration point This is an automated

[GitHub] piiswrong commented on a change in pull request #9877: Better even_split=False support in gluon.split_data()

2018-02-26 Thread GitBox
piiswrong commented on a change in pull request #9877: Better even_split=False support in gluon.split_data() URL: https://github.com/apache/incubator-mxnet/pull/9877#discussion_r170760306 ## File path: python/mxnet/gluon/utils.py ## @@ -56,13 +56,10 @@ def

[GitHub] piiswrong closed pull request #9889: Fix doc in autograd.Function

2018-02-26 Thread GitBox
piiswrong closed pull request #9889: Fix doc in autograd.Function URL: https://github.com/apache/incubator-mxnet/pull/9889 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-mxnet] branch master updated: Fix doc (#9889)

2018-02-26 Thread jxie
This is an automated email from the ASF dual-hosted git repository. jxie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 5d49205 Fix doc (#9889) 5d49205 is

[GitHub] piiswrong closed issue #9872: A bug in an example in the python API document

2018-02-26 Thread GitBox
piiswrong closed issue #9872: A bug in an example in the python API document URL: https://github.com/apache/incubator-mxnet/issues/9872 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] dabraude commented on a change in pull request #9860: [WIP] CMake NNPack support

2018-02-26 Thread GitBox
dabraude commented on a change in pull request #9860: [WIP] CMake NNPack support URL: https://github.com/apache/incubator-mxnet/pull/9860#discussion_r170758657 ## File path: CMakeLists.txt ## @@ -551,6 +552,37 @@ if(NOT EXISTS

[GitHub] anirudh2290 commented on issue #9869: Exception handling documentation

2018-02-26 Thread GitBox
anirudh2290 commented on issue #9869: Exception handling documentation URL: https://github.com/apache/incubator-mxnet/pull/9869#issuecomment-368673277 @rahul003 All exceptions that are a subclass of dmlc::Error in the C++ backend is propagated to the frontend and rethrown as

[GitHub] marcoabreu commented on a change in pull request #9860: [WIP] CMake NNPack support

2018-02-26 Thread GitBox
marcoabreu commented on a change in pull request #9860: [WIP] CMake NNPack support URL: https://github.com/apache/incubator-mxnet/pull/9860#discussion_r170756315 ## File path: CMakeLists.txt ## @@ -551,6 +552,37 @@ if(NOT EXISTS

[GitHub] dabraude commented on a change in pull request #9860: [WIP] CMake NNPack support

2018-02-26 Thread GitBox
dabraude commented on a change in pull request #9860: [WIP] CMake NNPack support URL: https://github.com/apache/incubator-mxnet/pull/9860#discussion_r170755593 ## File path: CMakeLists.txt ## @@ -551,6 +552,37 @@ if(NOT EXISTS

[GitHub] dabraude commented on a change in pull request #9860: [WIP] CMake NNPack support

2018-02-26 Thread GitBox
dabraude commented on a change in pull request #9860: [WIP] CMake NNPack support URL: https://github.com/apache/incubator-mxnet/pull/9860#discussion_r170749738 ## File path: CMakeLists.txt ## @@ -551,6 +552,37 @@ if(NOT EXISTS

[GitHub] dabraude commented on issue #9860: [WIP] CMake NNPack support

2018-02-26 Thread GitBox
dabraude commented on issue #9860: [WIP] CMake NNPack support URL: https://github.com/apache/incubator-mxnet/pull/9860#issuecomment-368664643 I wasn't going to push but I had conflicts with the upstream/master that needed to be resolved. The problem is that none of the old

[GitHub] marcoabreu commented on a change in pull request #9860: [WIP] CMake NNPack support

2018-02-26 Thread GitBox
marcoabreu commented on a change in pull request #9860: [WIP] CMake NNPack support URL: https://github.com/apache/incubator-mxnet/pull/9860#discussion_r170745042 ## File path: CMakeLists.txt ## @@ -551,6 +552,37 @@ if(NOT EXISTS

[GitHub] mayer79 commented on issue #8936: Issue on MXNet R installation with GPU support on Windows

2018-02-26 Thread GitBox
mayer79 commented on issue #8936: Issue on MXNet R installation with GPU support on Windows URL: https://github.com/apache/incubator-mxnet/issues/8936#issuecomment-368654683 I have exactly the same problem. This is an

[GitHub] rahul003 commented on a change in pull request #9869: Exception handling documentation

2018-02-26 Thread GitBox
rahul003 commented on a change in pull request #9869: Exception handling documentation URL: https://github.com/apache/incubator-mxnet/pull/9869#discussion_r170734554 ## File path: docs/tutorials/basic/exception_handling.md ## @@ -0,0 +1,111 @@ +# Exception Handling in

[GitHub] rahul003 commented on a change in pull request #9869: Exception handling documentation

2018-02-26 Thread GitBox
rahul003 commented on a change in pull request #9869: Exception handling documentation URL: https://github.com/apache/incubator-mxnet/pull/9869#discussion_r170736736 ## File path: docs/tutorials/basic/exception_handling.md ## @@ -0,0 +1,111 @@ +# Exception Handling in

[GitHub] rahul003 commented on a change in pull request #9869: Exception handling documentation

2018-02-26 Thread GitBox
rahul003 commented on a change in pull request #9869: Exception handling documentation URL: https://github.com/apache/incubator-mxnet/pull/9869#discussion_r170734563 ## File path: docs/tutorials/basic/exception_handling.md ## @@ -0,0 +1,111 @@ +# Exception Handling in

[GitHub] rahul003 commented on a change in pull request #9869: Exception handling documentation

2018-02-26 Thread GitBox
rahul003 commented on a change in pull request #9869: Exception handling documentation URL: https://github.com/apache/incubator-mxnet/pull/9869#discussion_r170735533 ## File path: docs/tutorials/basic/exception_handling.md ## @@ -0,0 +1,111 @@ +# Exception Handling in

[GitHub] sxjscience commented on issue #9881: Inconsistent weight decay logics in multiple optimizers

2018-02-26 Thread GitBox
sxjscience commented on issue #9881: Inconsistent weight decay logics in multiple optimizers URL: https://github.com/apache/incubator-mxnet/issues/9881#issuecomment-368639164 Just curious, is `clip_gradient` used anywhere?

[GitHub] tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM

2018-02-26 Thread GitBox
tqchen commented on issue #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#issuecomment-368636020 @piiswrong Can you check and merge, or provide a list of action items that you think should change?

[GitHub] piiswrong commented on issue #9881: Inconsistent weight decay logics in multiple optimizers

2018-02-26 Thread GitBox
piiswrong commented on issue #9881: Inconsistent weight decay logics in multiple optimizers URL: https://github.com/apache/incubator-mxnet/issues/9881#issuecomment-368632961 Could you clarify which ones multiply wd with lr and which ones don't?

[GitHub] anirudh2290 closed pull request #9795: Add tests for Exception Handling in Iterators

2018-02-26 Thread GitBox
anirudh2290 closed pull request #9795: Add tests for Exception Handling in Iterators URL: https://github.com/apache/incubator-mxnet/pull/9795 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] anirudh2290 commented on issue #9795: Add tests for Exception Handling in Iterators

2018-02-26 Thread GitBox
anirudh2290 commented on issue #9795: Add tests for Exception Handling in Iterators URL: https://github.com/apache/incubator-mxnet/pull/9795#issuecomment-368629079 Closing this. Please see #9869 which contains these tests

[GitHub] cjolivier01 closed pull request #9883: added function for loading content of nd_array files from a buffer

2018-02-26 Thread GitBox
cjolivier01 closed pull request #9883: added function for loading content of nd_array files from a buffer URL: https://github.com/apache/incubator-mxnet/pull/9883 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[incubator-mxnet] branch master updated: added function for loading content of nd_array files from a buffer (#9883)

2018-02-26 Thread cjolivier01
This is an automated email from the ASF dual-hosted git repository. cjolivier01 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new a352d1e added function for

[GitHub] Caenorst opened a new issue #9890: MxNet allow to use same name

2018-02-26 Thread GitBox
Caenorst opened a new issue #9890: MxNet allow to use same name URL: https://github.com/apache/incubator-mxnet/issues/9890 ## Description MxNet allow me to reuse a name of a symbol without returning an error, it eventually leads to a cyclic graph in the visualization. We should

[GitHub] dabraude commented on a change in pull request #9883: added function for loading content of nd_array files from a buffer

2018-02-26 Thread GitBox
dabraude commented on a change in pull request #9883: added function for loading content of nd_array files from a buffer URL: https://github.com/apache/incubator-mxnet/pull/9883#discussion_r170708924 ## File path: src/c_api/c_api.cc ## @@ -322,6 +322,38 @@ int

[GitHub] tqchen commented on a change in pull request #9880: TVM bridge support to JIT NDArray Function by TVM

2018-02-26 Thread GitBox
tqchen commented on a change in pull request #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#discussion_r170707789 ## File path: tests/python/gpu/test_tvm_bridge.py ## @@ -0,0 +1,63 @@ +# Licensed to the

[GitHub] tqchen commented on a change in pull request #9880: TVM bridge support to JIT NDArray Function by TVM

2018-02-26 Thread GitBox
tqchen commented on a change in pull request #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#discussion_r170707789 ## File path: tests/python/gpu/test_tvm_bridge.py ## @@ -0,0 +1,63 @@ +# Licensed to the

[GitHub] cjolivier01 commented on a change in pull request #9880: TVM bridge support to JIT NDArray Function by TVM

2018-02-26 Thread GitBox
cjolivier01 commented on a change in pull request #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#discussion_r170706390 ## File path: tests/python/gpu/test_tvm_bridge.py ## @@ -0,0 +1,63 @@ +# Licensed to

[GitHub] tqchen commented on a change in pull request #9880: TVM bridge support to JIT NDArray Function by TVM

2018-02-26 Thread GitBox
tqchen commented on a change in pull request #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#discussion_r170705949 ## File path: tests/python/gpu/test_tvm_bridge.py ## @@ -0,0 +1,63 @@ +# Licensed to the

[GitHub] cjolivier01 commented on a change in pull request #9883: added function for loading content of nd_array files from a buffer

2018-02-26 Thread GitBox
cjolivier01 commented on a change in pull request #9883: added function for loading content of nd_array files from a buffer URL: https://github.com/apache/incubator-mxnet/pull/9883#discussion_r170704930 ## File path: src/c_api/c_api.cc ## @@ -322,6 +322,38 @@ int

[GitHub] tqchen commented on a change in pull request #9880: TVM bridge support to JIT NDArray Function by TVM

2018-02-26 Thread GitBox
tqchen commented on a change in pull request #9880: TVM bridge support to JIT NDArray Function by TVM URL: https://github.com/apache/incubator-mxnet/pull/9880#discussion_r170703656 ## File path: tests/python/gpu/test_tvm_bridge.py ## @@ -0,0 +1,63 @@ +# Licensed to the

[GitHub] marcoabreu commented on a change in pull request #9878: Docs build all versions refactor

2018-02-26 Thread GitBox
marcoabreu commented on a change in pull request #9878: Docs build all versions refactor URL: https://github.com/apache/incubator-mxnet/pull/9878#discussion_r170701486 ## File path: docs/build_version_doc/setup_docs_ubuntu.sh ## @@ -0,0 +1,42 @@ +# If you need to build <=

  1   2   >