[GitHub] pengzhao-intel commented on issue #10089: enable all activations in MKLDNN.

2018-03-13 Thread GitBox
pengzhao-intel commented on issue #10089: enable all activations in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10089#issuecomment-372914320 @zheng-da tests/python/unittest/test_loss.py fail too which used softrelu. I will look the case you pointed. > =

[GitHub] pengzhao-intel commented on issue #10089: enable all activations in MKLDNN.

2018-03-13 Thread GitBox
pengzhao-intel commented on issue #10089: enable all activations in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10089#issuecomment-372914320 @zheng-da tests/python/unittest/test_loss.py fail too which used softrelu. I will look the case you pointed. -

[GitHub] pengzhao-intel commented on issue #10075: [MXNET-83] Fix CMake build issue with MKL.

2018-03-13 Thread GitBox
pengzhao-intel commented on issue #10075: [MXNET-83] Fix CMake build issue with MKL. URL: https://github.com/apache/incubator-mxnet/pull/10075#issuecomment-372868894 @anirudh2290 it's in the MKL-DNN readme by "Intel MKL small libraries" and I am working on improving the explanations. I wil

[GitHub] pengzhao-intel commented on issue #10075: [MXNET-83] Fix CMake build issue with MKL.

2018-03-13 Thread GitBox
pengzhao-intel commented on issue #10075: [MXNET-83] Fix CMake build issue with MKL. URL: https://github.com/apache/incubator-mxnet/pull/10075#issuecomment-372868894 @anirudh2290 it's in the MKL-DNN readme by "Intel MKL small libraries" and I am working on improving the explanations. I wil

[GitHub] CoinCheung commented on a change in pull request #10000: [MXNET-80] Fix average pooling kernel size assignment error

2018-03-13 Thread GitBox
CoinCheung commented on a change in pull request #1: [MXNET-80] Fix average pooling kernel size assignment error URL: https://github.com/apache/incubator-mxnet/pull/1#discussion_r174359301 ## File path: src/operator/nn/pooling.cc ## @@ -98,9 +103,24 @@ static bool

[GitHub] zheng-da commented on issue #10089: enable all activations in MKLDNN.

2018-03-13 Thread GitBox
zheng-da commented on issue #10089: enable all activations in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10089#issuecomment-372913471 but the error happens here: https://github.com/apache/incubator-mxnet/blob/master/tests/python/gpu/test_operator_gpu.py#L activation

[GitHub] thinksanky opened a new pull request #10099: fixed the order of adding the new version into tag list before updati…

2018-03-13 Thread GitBox
thinksanky opened a new pull request #10099: fixed the order of adding the new version into tag list before updati… URL: https://github.com/apache/incubator-mxnet/pull/10099 ## Description ## The order of adding the latest version to the tag list is fixed now. It is required for thi

[GitHub] pengzhao-intel commented on issue #10092: No "full" pooling convention support with MKL-DNN

2018-03-13 Thread GitBox
pengzhao-intel commented on issue #10092: No "full" pooling convention support with MKL-DNN URL: https://github.com/apache/incubator-mxnet/issues/10092#issuecomment-372911501 I think the current change is fine and the path can be back when MKL-DNN supports 'full' pooling convention. @

[GitHub] pengzhao-intel commented on issue #8532: mxnet-mkl (v0.12.0) crash when using (conda-installed) numpy with MKL

2018-03-13 Thread GitBox
pengzhao-intel commented on issue #8532: mxnet-mkl (v0.12.0) crash when using (conda-installed) numpy with MKL URL: https://github.com/apache/incubator-mxnet/issues/8532#issuecomment-372910970 @fhieber @rsdubtso is correct. It caused by multiple omp lib. The workaround is to set MP_DUPLI

[GitHub] CoinCheung commented on a change in pull request #10000: [MXNET-80] Fix average pooling kernel size assignment error

2018-03-13 Thread GitBox
CoinCheung commented on a change in pull request #1: [MXNET-80] Fix average pooling kernel size assignment error URL: https://github.com/apache/incubator-mxnet/pull/1#discussion_r174356271 ## File path: src/operator/nn/pooling.cc ## @@ -98,9 +103,24 @@ static bool

[GitHub] nihui opened a new pull request #10098: implement DepthwiseConv2dBackwardFilterKernel from tensorflow codebase

2018-03-13 Thread GitBox
nihui opened a new pull request #10098: implement DepthwiseConv2dBackwardFilterKernel from tensorflow codebase URL: https://github.com/apache/incubator-mxnet/pull/10098 implement DepthwiseConv2dBackwardFilterKernel from tensorflow codebase, which is over 5x faster ## Description ##

[GitHub] pengzhao-intel commented on issue #10089: enable all activations in MKLDNN.

2018-03-13 Thread GitBox
pengzhao-intel commented on issue #10089: enable all activations in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10089#issuecomment-372908964 Look at the code, two implementations are the difference for the soft_relu. So, we get the different results. mxnet: https:

[GitHub] chinakook opened a new issue #10097: When to merge mxnet-fold to master?

2018-03-13 Thread GitBox
chinakook opened a new issue #10097: When to merge mxnet-fold to master? URL: https://github.com/apache/incubator-mxnet/issues/10097 I found [mxnet-fold](https://github.com/szha/mxnet-fold) is very useful in some situation, so I wonder that when to merge this feature to master. ---

[GitHub] cjolivier01 commented on issue #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on issue #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#issuecomment-372905350 yeah I actually tried setting omp_num_threads() to one there earlier today but it didn’t fix it. I think we’ll need to

[GitHub] sxjscience commented on issue #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
sxjscience commented on issue #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#issuecomment-372903762 @cjolivier01 Eric said that `pthread_atfork` that is used in the engine code (https://github.com/apache/incubator-mxnet/

[GitHub] sxjscience commented on issue #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
sxjscience commented on issue #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#issuecomment-372903762 @cjolivier01 Eric said that `pthread_atfork` http://pubs.opengroup.org/onlinepubs/007904975/functions/pthread_atfork.htm

[incubator-mxnet] branch master updated: [MXNET-86] Revert to pre-profile-changes copy code (#10090)

2018-03-13 Thread sxjscience
This is an automated email from the ASF dual-hosted git repository. sxjscience pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new c9ec311 [MXNET-86] Revert to pre-p

[GitHub] sxjscience closed pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
sxjscience closed pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] Jerryzcn commented on issue #10096: Fix multi worker

2018-03-13 Thread GitBox
Jerryzcn commented on issue #10096: Fix multi worker URL: https://github.com/apache/incubator-mxnet/pull/10096#issuecomment-372899924 can we add tests for the race condition? This is an automated message from the Apache Git S

[GitHub] Jerryzcn commented on issue #10096: Fix multi worker

2018-03-13 Thread GitBox
Jerryzcn commented on issue #10096: Fix multi worker URL: https://github.com/apache/incubator-mxnet/pull/10096#issuecomment-372899924 can we add tests for the race condition? This is an automated message from the Apache Git S

[GitHub] sxjscience commented on a change in pull request #10096: Fix multi worker

2018-03-13 Thread GitBox
sxjscience commented on a change in pull request #10096: Fix multi worker URL: https://github.com/apache/incubator-mxnet/pull/10096#discussion_r174349573 ## File path: python/mxnet/gluon/data/dataloader.py ## @@ -119,6 +119,71 @@ def worker_loop(dataset, key_queue, data_que

[GitHub] Jerryzcn commented on issue #10096: Fix multi worker

2018-03-13 Thread GitBox
Jerryzcn commented on issue #10096: Fix multi worker URL: https://github.com/apache/incubator-mxnet/pull/10096#issuecomment-372899569 I will patch this and test on our speech dataset. This will take approx. 2 day This is an a

[GitHub] Jerryzcn commented on issue #10096: Fix multi worker

2018-03-13 Thread GitBox
Jerryzcn commented on issue #10096: Fix multi worker URL: https://github.com/apache/incubator-mxnet/pull/10096#issuecomment-372899569 I will patch this and test on our speech dataset. This will take approx. 1 day This is an a

[GitHub] Jerryzcn commented on issue #10096: Fix multi worker

2018-03-13 Thread GitBox
Jerryzcn commented on issue #10096: Fix multi worker URL: https://github.com/apache/incubator-mxnet/pull/10096#issuecomment-372899569 I will patch this and test on our speech dataset This is an automated message from the Apach

[GitHub] Jerryzcn commented on issue #10096: Fix multi worker

2018-03-13 Thread GitBox
Jerryzcn commented on issue #10096: Fix multi worker URL: https://github.com/apache/incubator-mxnet/pull/10096#issuecomment-372899201 thank god This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] sxjscience commented on issue #10096: Fix multi worker

2018-03-13 Thread GitBox
sxjscience commented on issue #10096: Fix multi worker URL: https://github.com/apache/incubator-mxnet/pull/10096#issuecomment-372899155 @cjolivier01 @Jerryzcn This is an automated message from the Apache Git Service. To respo

[GitHub] haoliyoupai09 commented on issue #6635: OnlyImplementedInNDArray

2018-03-13 Thread GitBox
haoliyoupai09 commented on issue #6635: OnlyImplementedInNDArray URL: https://github.com/apache/incubator-mxnet/pull/6635#issuecomment-372896258 That helps, thanks a lot. This is an automated message from the Apache Git Servic

[GitHub] zhreshold opened a new pull request #10096: Fix multi worker

2018-03-13 Thread GitBox
zhreshold opened a new pull request #10096: Fix multi worker URL: https://github.com/apache/incubator-mxnet/pull/10096 ## Description ## - Fix race condition for CPUSharedStorageManager->Free - Launch workers at iter init stage to avoid frequent relaunch @piiswrong @sxjscience @

[GitHub] szha commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-13 Thread GitBox
szha commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174341439 ## File path: python/mxnet/gluon/text/embedding.py ## @@ -29,10 +29,10 @@ import warnings import zipfile -from

[GitHub] szha commented on issue #6635: OnlyImplementedInNDArray

2018-03-13 Thread GitBox
szha commented on issue #6635: OnlyImplementedInNDArray URL: https://github.com/apache/incubator-mxnet/pull/6635#issuecomment-372888019 The error message you got is accurate in that the in-place add is indeed not available in symbol. Instead of doing `sym_a += sym_b`, you can do `sym_a = s

[GitHub] haoliyoupai09 commented on issue #6635: OnlyImplementedInNDArray

2018-03-13 Thread GitBox
haoliyoupai09 commented on issue #6635: OnlyImplementedInNDArray URL: https://github.com/apache/incubator-mxnet/pull/6635#issuecomment-372883452 raise NotImplementedForSymbol(self.iadd, '+=', other, 1) mxnet.base.NotImplementedForSymbol: Function iadd (namely operator "+=") with argument

[GitHub] xinyu-intel commented on issue #9918: [MXNET-74]Update mkldnn to the newest & Add clang build test with mkldnn.

2018-03-13 Thread GitBox
xinyu-intel commented on issue #9918: [MXNET-74]Update mkldnn to the newest & Add clang build test with mkldnn. URL: https://github.com/apache/incubator-mxnet/pull/9918#issuecomment-372883194 @marcoabreu @cjolivier01 please help confirm the latest changes, Thanks!

[GitHub] haoliyoupai09 commented on issue #9667: [Feature request] += operator for Symbol

2018-03-13 Thread GitBox
haoliyoupai09 commented on issue #9667: [Feature request] += operator for Symbol URL: https://github.com/apache/incubator-mxnet/issues/9667#issuecomment-372882885 raise NotImplementedForSymbol(self.__iadd__, '+=', other, 1) mxnet.base.NotImplementedForSymbol: Function __iadd__ (namely op

[GitHub] safrooze commented on issue #8593: Runtime errors during forward in a custom gluon.Block

2018-03-13 Thread GitBox
safrooze commented on issue #8593: Runtime errors during forward in a custom gluon.Block URL: https://github.com/apache/incubator-mxnet/issues/8593#issuecomment-372881526 This is a question that preferably is asked on [discuss.mxnet.io](https://discuss.mxnet.io/). To answer your question,

[GitHub] ashokei commented on issue #10092: No "full" pooling convention support with MKL-DNN

2018-03-13 Thread GitBox
ashokei commented on issue #10092: No "full" pooling convention support with MKL-DNN URL: https://github.com/apache/incubator-mxnet/issues/10092#issuecomment-372879308 not been implemented by mkldnn for this specific case, hence with fix in #10021 we fallback to CPU just like any other fe

[GitHub] feevos commented on issue #9822: gluon HybridBlock wrapper of constant nd.array, is it possible?

2018-03-13 Thread GitBox
feevos commented on issue #9822: gluon HybridBlock wrapper of constant nd.array, is it possible? URL: https://github.com/apache/incubator-mxnet/issues/9822#issuecomment-372877890 Thanks @jmacglashan you are right. On mxnet [discuss forum](https://discuss.mxnet.io/t/custom-layer-infer-sha

[GitHub] feevos commented on issue #9822: gluon HybridBlock wrapper of constant nd.array, is it possible?

2018-03-13 Thread GitBox
feevos commented on issue #9822: gluon HybridBlock wrapper of constant nd.array, is it possible? URL: https://github.com/apache/incubator-mxnet/issues/9822#issuecomment-372877890 Thanks @jmacglashan you are right. On mxnet [discuss forum](https://discuss.mxnet.io/t/custom-layer-infer-sha

[GitHub] chinakook opened a new issue #10095: BatchNorm on axis=-1 is very slower than axis=1

2018-03-13 Thread GitBox
chinakook opened a new issue #10095: BatchNorm on axis=-1 is very slower than axis=1 URL: https://github.com/apache/incubator-mxnet/issues/10095 As profiler shows, the "nn.BatchNorm(axis=-1)" will cause 10x lower speed on my application than "nn.BatchNorm(axis=1)". However, We often nee

[GitHub] anirudh2290 opened a new pull request #10094: [MXNET-89] [WIP] Bug fix for bucketing module

2018-03-13 Thread GitBox
anirudh2290 opened a new pull request #10094: [MXNET-89] [WIP] Bug fix for bucketing module URL: https://github.com/apache/incubator-mxnet/pull/10094 ## Description ## Fix #9405 ## Checklist ## ### Essentials ### - [ ] Passed code style checking (`make lint`) - [ ] Change

[GitHub] ThomasDelteil commented on issue #10093: Cannot print summary of models loaded from onnx-mxnet

2018-03-13 Thread GitBox
ThomasDelteil commented on issue #10093: Cannot print summary of models loaded from onnx-mxnet URL: https://github.com/apache/incubator-mxnet/issues/10093#issuecomment-372875127 work around: `sym.save('symbol.json')` replace the "True" and "False" with "1" and "0" `sym = mx.sym.lo

[GitHub] ThomasDelteil opened a new issue #10093: Cannot print summary of models loaded from onnx-mxnet

2018-03-13 Thread GitBox
ThomasDelteil opened a new issue #10093: Cannot print summary of models loaded from onnx-mxnet URL: https://github.com/apache/incubator-mxnet/issues/10093 ## Description Trying to print a model loaded from onnx-mxnet does not work because the value of `node["attrs"]["no_bias"]` is `"Fal

[GitHub] marcoabreu commented on issue #10092: No "full" pooling convention support with MKL-DNN

2018-03-13 Thread GitBox
marcoabreu commented on issue #10092: No "full" pooling convention support with MKL-DNN URL: https://github.com/apache/incubator-mxnet/issues/10092#issuecomment-372869822 Thanks a lot for the explanation. Does it fail because it has not been implemented by MKLDNN or because the im

[GitHub] pengzhao-intel commented on issue #10075: [MXNET-83] Fix CMake build issue with MKL.

2018-03-13 Thread GitBox
pengzhao-intel commented on issue #10075: [MXNET-83] Fix CMake build issue with MKL. URL: https://github.com/apache/incubator-mxnet/pull/10075#issuecomment-372868894 @anirudh2290 it's in the MKL-DNN readme by "Intel MKL small libraries" and I am working on improving the explanations. I wil

[GitHub] zheng-da commented on issue #10089: enable all activations in MKLDNN.

2018-03-13 Thread GitBox
zheng-da commented on issue #10089: enable all activations in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10089#issuecomment-372867710 I wanted to test if MKLDNN activation is working now. We can close the PR for now and reopen it after the bug in MKLDNN is fixed, or just ke

[GitHub] pengzhao-intel commented on issue #10089: enable all activations in MKLDNN.

2018-03-13 Thread GitBox
pengzhao-intel commented on issue #10089: enable all activations in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10089#issuecomment-372867519 @zheng-da thanks a lot. I will follow up with our team :) This is an

[GitHub] ashokei commented on issue #10092: No "full" pooling convention support with MKL-DNN

2018-03-13 Thread GitBox
ashokei commented on issue #10092: No "full" pooling convention support with MKL-DNN URL: https://github.com/apache/incubator-mxnet/issues/10092#issuecomment-372866683 @marcoabreu The issue is with a specific SSD-VGG16-reduced model, in which pooling convention of full (only with maxpool)

[GitHub] ashokei commented on issue #10092: No "full" pooling convention support with MKL-DNN

2018-03-13 Thread GitBox
ashokei commented on issue #10092: No "full" pooling convention support with MKL-DNN URL: https://github.com/apache/incubator-mxnet/issues/10092#issuecomment-372866683 @marcoabreu The issue is with a specific SSD-VGG16-reduced model, in which pooling convention of full (only with maxpool)

[GitHub] ashokei commented on issue #10092: No "full" pooling convention support with MKL-DNN

2018-03-13 Thread GitBox
ashokei commented on issue #10092: No "full" pooling convention support with MKL-DNN URL: https://github.com/apache/incubator-mxnet/issues/10092#issuecomment-372866683 @marcoabreu The issue is with a specific SSD-VGG16-reduced model, in which pooling convention of full (only with maxpool)

[GitHub] marcoabreu commented on issue #10089: enable all activations in MKLDNN.

2018-03-13 Thread GitBox
marcoabreu commented on issue #10089: enable all activations in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10089#issuecomment-372866159 I see, thanks a lot! So we'll wait to merge this until Intel fixed the problem or how would you propose to move forward?

[GitHub] zheng-da commented on issue #10089: enable all activations in MKLDNN.

2018-03-13 Thread GitBox
zheng-da commented on issue #10089: enable all activations in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10089#issuecomment-372865309 it seems the precision problem hasn't been fixed in mkldnn. I'm notify them of this problem. hopefully, it can be fixed soon. -

[GitHub] marcoabreu commented on issue #10088: R can not install, 404 Not Found

2018-03-13 Thread GitBox
marcoabreu commented on issue #10088: R can not install, 404 Not Found URL: https://github.com/apache/incubator-mxnet/issues/10088#issuecomment-372864754 Hello, MXNet 0.10.1 is a quite old version - the latest released version is 1.1. Would you mind explaining where you found the instructi

[GitHub] astonzhang commented on a change in pull request #10074: Add vocabulary and embedding

2018-03-13 Thread GitBox
astonzhang commented on a change in pull request #10074: Add vocabulary and embedding URL: https://github.com/apache/incubator-mxnet/pull/10074#discussion_r174324845 ## File path: python/mxnet/text/embedding.py ## @@ -38,8 +38,12 @@ def register(embedding_cls): """

[GitHub] marcoabreu opened a new issue #10092: No "full" pooling convention support with MKL-DNN

2018-03-13 Thread GitBox
marcoabreu opened a new issue #10092: No "full" pooling convention support with MKL-DNN URL: https://github.com/apache/incubator-mxnet/issues/10092 I'm kind of lacking context here, but I'd like to track this issue. More details are available at https://github.com/apache/incubator-mxnet/pu

[GitHub] marcoabreu commented on issue #10021: [MXNET-33] SSD example not working with mkl-dnn

2018-03-13 Thread GitBox
marcoabreu commented on issue #10021: [MXNET-33] SSD example not working with mkl-dnn URL: https://github.com/apache/incubator-mxnet/pull/10021#issuecomment-372864199 That's not an issue, we're already testing a variety of models and the bigger diversity, the better. We can re-visit this d

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174324064 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def t

[GitHub] eric-haibin-lin closed issue #10084: which optimizer to support sparse update except adam, ftrl, sgd?

2018-03-13 Thread GitBox
eric-haibin-lin closed issue #10084: which optimizer to support sparse update except adam, ftrl, sgd? URL: https://github.com/apache/incubator-mxnet/issues/10084 This is an automated message from the Apache Git Service. To r

[GitHub] eric-haibin-lin commented on issue #10084: which optimizer to support sparse update except adam, ftrl, sgd?

2018-03-13 Thread GitBox
eric-haibin-lin commented on issue #10084: which optimizer to support sparse update except adam, ftrl, sgd? URL: https://github.com/apache/incubator-mxnet/issues/10084#issuecomment-372863154 https://mxnet.incubator.apache.org/versions/master/api/python/ndarray/sparse.html#updater -

[GitHub] ashokei commented on issue #10021: [MXNET-33] SSD example not working with mkl-dnn

2018-03-13 Thread GitBox
ashokei commented on issue #10021: [MXNET-33] SSD example not working with mkl-dnn URL: https://github.com/apache/incubator-mxnet/pull/10021#issuecomment-372861771 @marcoabreu this issue only happens inside a particular model (SSD VGG16-reduced), i clarified in title/description. I'm not s

[GitHub] marcoabreu commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174321757 ## File path: python/mxnet/contrib/onnx/_import/import_model.py ## @@ -0,0 +1,46 @

[GitHub] marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174321395 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def te

[GitHub] sxjscience commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
sxjscience commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174320555 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def te

[GitHub] anirudhacharya commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet

2018-03-13 Thread GitBox
anirudhacharya commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174319252 ## File path: python/mxnet/contrib/onnx/_import/import_helper.py ## @@ -0,0 +1

[GitHub] anirudhacharya commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet

2018-03-13 Thread GitBox
anirudhacharya commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174318632 ## File path: python/mxnet/contrib/onnx/_import/import_helper.py ## @@ -0,0 +1

[GitHub] Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet

2018-03-13 Thread GitBox
Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174317953 ## File path: python/mxnet/contrib/onnx/_import/import_helper.py ## @@ -0,0 +1,105 @

[GitHub] Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet

2018-03-13 Thread GitBox
Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174316464 ## File path: python/mxnet/contrib/onnx/_import/import_model.py ## @@ -0,0 +1,46 @@

[GitHub] Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet

2018-03-13 Thread GitBox
Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174315641 ## File path: python/mxnet/contrib/onnx/_import/import_helper.py ## @@ -0,0 +1,105 @

[GitHub] Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet

2018-03-13 Thread GitBox
Roshrini commented on a change in pull request #9963: [MXNET-34] Onnx Module to import onnx models into mxnet URL: https://github.com/apache/incubator-mxnet/pull/9963#discussion_r174316786 ## File path: python/mxnet/contrib/onnx/_import/import_model.py ## @@ -0,0 +1,46 @@

[GitHub] marcoabreu commented on a change in pull request #10089: enable all activations in MKLDNN.

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #10089: enable all activations in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10089#discussion_r174304740 ## File path: src/operator/nn/mkldnn/mkldnn_act.cc ## @@ -45,11 +45,9 @@ namespace op { bool SupportM

[GitHub] marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174314312 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def te

[GitHub] marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174313685 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def te

[GitHub] reminisce opened a new pull request #10091: Add quadratic op for the tutorial of adding ops in backend

2018-03-13 Thread GitBox
reminisce opened a new pull request #10091: Add quadratic op for the tutorial of adding ops in backend URL: https://github.com/apache/incubator-mxnet/pull/10091 ## Description ## The operator `quadratic` is used as an example of this [tutorial](https://mxnet.incubator.apache.org/faq/add

[GitHub] marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174312690 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include "./nda

[GitHub] rahul003 commented on issue #8509: test_operator_gpu.py:test_batchnorm_with_type robustness

2018-03-13 Thread GitBox
rahul003 commented on issue #8509: test_operator_gpu.py:test_batchnorm_with_type robustness URL: https://github.com/apache/incubator-mxnet/issues/8509#issuecomment-372849471 That looks like something we can look into if similar issues persist. But for now, we believe this is because of fl

[GitHub] rahul003 commented on issue #9916: precision bug in batchnorm.

2018-03-13 Thread GitBox
rahul003 commented on issue #9916: precision bug in batchnorm. URL: https://github.com/apache/incubator-mxnet/issues/9916#issuecomment-372847814 Relevant suggestion https://github.com/apache/incubator-mxnet/issues/8509 This i

[GitHub] rahul003 commented on issue #9916: precision bug in batchnorm.

2018-03-13 Thread GitBox
rahul003 commented on issue #9916: precision bug in batchnorm. URL: https://github.com/apache/incubator-mxnet/issues/9916#issuecomment-372847814 Relevant comment https://github.com/apache/incubator-mxnet/issues/8509 This is a

[GitHub] rahul003 commented on issue #8529: What is the functionality of OrderMutation

2018-03-13 Thread GitBox
rahul003 commented on issue #8529: What is the functionality of OrderMutation URL: https://github.com/apache/incubator-mxnet/issues/8529#issuecomment-372847594 @eric-haibin-lin please add the labels Doc, Question This is an a

[GitHub] cjolivier01 commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r174309509 ## File path: python/mxnet/profiler.py ## @@ -35,13 +68,16 @@

[GitHub] eric-haibin-lin commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

2018-03-13 Thread GitBox
eric-haibin-lin commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r174309219 ## File path: python/mxnet/profiler.py ## @@ -35,13 +68,16

[GitHub] sxjscience commented on issue #10085: Ordering operators do not support kNullOp

2018-03-13 Thread GitBox
sxjscience commented on issue #10085: Ordering operators do not support kNullOp URL: https://github.com/apache/incubator-mxnet/issues/10085#issuecomment-372845417 Sorry that I'm too busy with other stuffs. Can anyone help solve the bug? If not, I will solve it later. -

[GitHub] eric-haibin-lin commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

2018-03-13 Thread GitBox
eric-haibin-lin commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc. URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r174309219 ## File path: python/mxnet/profiler.py ## @@ -35,13 +68,16

[GitHub] sxjscience commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
sxjscience commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174308148 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include "./nda

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174307840 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def t

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174307840 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def t

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174307538 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include "./nd

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174307193 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def t

[GitHub] Jerryzcn commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
Jerryzcn commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174306619 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def test

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174306094 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def t

[GitHub] Jerryzcn commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
Jerryzcn commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174304900 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def test

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174304792 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include "./nd

[GitHub] marcoabreu commented on a change in pull request #10089: enable all activations in MKLDNN.

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #10089: enable all activations in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10089#discussion_r174304740 ## File path: src/operator/nn/mkldnn/mkldnn_act.cc ## @@ -45,11 +45,9 @@ namespace op { bool SupportM

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174304476 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include "./nd

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174304476 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include "./nd

[GitHub] marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174304481 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def te

[GitHub] marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
marcoabreu commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174304377 ## File path: tests/python/unittest/test_gluon_data.py ## @@ -112,6 +117,76 @@ def te

[GitHub] sxjscience commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
sxjscience commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174303894 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include "./nda

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174303574 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include "./nd

[GitHub] sxjscience commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
sxjscience commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174303261 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include "./nda

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174300231 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include "./nd

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174300231 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include "./nd

[GitHub] cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code

2018-03-13 Thread GitBox
cjolivier01 commented on a change in pull request #10090: [MXNET-86] Revert to pre-profile-changes copy code URL: https://github.com/apache/incubator-mxnet/pull/10090#discussion_r174300231 ## File path: src/ndarray/ndarray_function.cc ## @@ -26,35 +26,24 @@ #include "./nd

  1   2   3   >