[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310762141 ## File path: python/mxnet/base.py ## @@ -735,7 +739,121 @@ def write_all_str(module_file, module_all_list):

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310761998 ## File path: include/mxnet/tuple.h ## @@ -653,6 +661,13 @@ inline bool shape_is_known(const TShape& x) { return

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310761998 ## File path: include/mxnet/tuple.h ## @@ -653,6 +661,13 @@ inline bool shape_is_known(const TShape& x) { return

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310761132 ## File path: include/mxnet/tuple.h ## @@ -272,6 +272,14 @@ class Tuple { is.get(); if (ch == '(' || ch

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-03 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310340412 ## File path: include/mxnet/c_api.h ## @@ -2902,6 +2902,18 @@ MXNET_DLL int MXEnginePushSync(EngineSyncFunc

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-03 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310340506 ## File path: include/mxnet/tuple.h ## @@ -272,6 +272,14 @@ class Tuple { is.get(); if (ch == '(' || ch

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-03 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310340739 ## File path: python/mxnet/base.py ## @@ -735,7 +739,121 @@ def write_all_str(module_file, module_all_list):

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-03 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310340557 ## File path: include/mxnet/tuple.h ## @@ -653,6 +661,13 @@ inline bool shape_is_known(const TShape& x) { return

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-03 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310341343 ## File path: src/operator/tensor/broadcast_reduce_op.h ## @@ -977,24 +1037,40 @@ inline void

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-03 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310340808 ## File path: python/mxnet/base.py ## @@ -735,7 +739,121 @@ def write_all_str(module_file, module_all_list):

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-03 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310340621 ## File path: python/mxnet/_ctypes/symbol.py ## @@ -27,6 +27,7 @@ from ..base import check_call _symbol_cls =

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-03 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310340597 ## File path: python/mxnet/_ctypes/symbol.py ## @@ -115,7 +116,13 @@ def _set_symbol_class(cls): _symbol_cls =

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-03 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310340701 ## File path: python/mxnet/base.py ## @@ -735,7 +739,121 @@ def write_all_str(module_file, module_all_list):

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-03 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310341358 ## File path: src/operator/tensor/broadcast_reduce_op.h ## @@ -977,24 +1037,40 @@ inline void

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-03 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310341395 ## File path: src/operator/tensor/broadcast_reduce_op.h ## @@ -168,15 +168,24 @@ struct BroadcastLikeParam : public

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-03 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310340395 ## File path: include/mxnet/base.h ## @@ -451,7 +451,9 @@ inline int32_t Context::GetGPUCount() { } int32_t