[GitHub] jacobrosenthal commented on issue #957: nrf52 adc fixes

jacobrosenthal commented on issue #957: nrf52 adc fixes URL: https://github.com/apache/mynewt-core/pull/957#issuecomment-381302601 I dont know what commit message you want, seems best if you just merge and alter the commit message to suit your request.

[GitHub] kasjer commented on issue #1015: nrf52840 support for qspi flash

kasjer commented on issue #1015: nrf52840 support for qspi flash URL: https://github.com/apache/mynewt-core/pull/1015#issuecomment-381255576 @wes3 I though about putting all definition in MCU. I moved some of them to the BSP because there are not sensible default values for pins or flash

[GitHub] sdalu opened a new issue #1017: HW drivers: BME280 I2C not supported

sdalu opened a new issue #1017: HW drivers: BME280 I2C not supported URL: https://github.com/apache/mynewt-core/issues/1017 BME280 support both I2C and SPI. Currently I2C support is missing. This is an automated message from

[GitHub] kasjer commented on a change in pull request #1015: nrf52840 support for qspi flash

kasjer commented on a change in pull request #1015: nrf52840 support for qspi flash URL: https://github.com/apache/mynewt-core/pull/1015#discussion_r181502265 ## File path: hw/mcu/nordic/nrf52xxx/src/hal_qspi.c ## @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software

[GitHub] joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes

joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes URL: https://github.com/apache/mynewt-core/pull/699#issuecomment-381252318 Thank for @ccollins476ad for the very helpful explanation. If finally get it! Now, after I did a force to my fork the PR was

[GitHub] ccollins476ad commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes

ccollins476ad commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes URL: https://github.com/apache/mynewt-core/pull/699#issuecomment-381254122 @joshgrob - no, the PR should not have closed automatically! It appears your PR-specific commits aren't in the remote branch

[GitHub] vrahane closed pull request #1012: LIS2DW12 add bitfields

vrahane closed pull request #1012: LIS2DW12 add bitfields URL: https://github.com/apache/mynewt-core/pull/1012 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] sterlinghughes opened a new issue #159: cmake build failing for NRF targets

sterlinghughes opened a new issue #159: cmake build failing for NRF targets URL: https://github.com/apache/mynewt-newt/issues/159 newt target show nrf52dk_defapp targets/nrf52dk_defapp app=apps/defapp bsp=@apache-mynewt-core/hw/bsp/nrf52dk build_profile=optimized

[GitHub] sdalu commented on issue #1001: TSL2561, i2c transaction seemed to be stopped too soon

sdalu commented on issue #1001: TSL2561, i2c transaction seemed to be stopped too soon URL: https://github.com/apache/mynewt-core/issues/1001#issuecomment-381258734 There was some unrelated talk on i2c on slack, and I'm not sure that's really an issue and not a misunderstanding of my

[GitHub] utzig commented on issue #973: Add BSD compatibility queue.h

utzig commented on issue #973: Add BSD compatibility queue.h URL: https://github.com/apache/mynewt-core/pull/973#issuecomment-381266614 `sys/queue.h` is definitely better for portability. This is an automated message from the

[GitHub] vrahane commented on issue #973: Add BSD compatibility queue.h

vrahane commented on issue #973: Add BSD compatibility queue.h URL: https://github.com/apache/mynewt-core/pull/973#issuecomment-381256678 So, what about components breaking off of mynewt like NFFS or NFC or nimble, which header would they include ? I would assume `sys/queue.h`.

[GitHub] utzig commented on issue #973: Add BSD compatibility queue.h

utzig commented on issue #973: Add BSD compatibility queue.h URL: https://github.com/apache/mynewt-core/pull/973#issuecomment-381239415 @vrahane I would favour using `os/queue.h` for everything *Mynewt* and leave `sys/queue.h` for compatibility. But since it doesn't really matter I would

[GitHub] joshgrob closed pull request #699: Sensors/BMA2XX - New PR based on PR #697 changes

joshgrob closed pull request #699: Sensors/BMA2XX - New PR based on PR #697 changes URL: https://github.com/apache/mynewt-core/pull/699 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] sterlinghughes commented on issue #1001: TSL2561, i2c transaction seemed to be stopped too soon

sterlinghughes commented on issue #1001: TSL2561, i2c transaction seemed to be stopped too soon URL: https://github.com/apache/mynewt-core/issues/1001#issuecomment-381257579 why closed? This is an automated message from the

[GitHub] wes3 commented on issue #1015: nrf52840 support for qspi flash

wes3 commented on issue #1015: nrf52840 support for qspi flash URL: https://github.com/apache/mynewt-core/pull/1015#issuecomment-381258918 @kasjer I understand about the lack of sensible defaults. One way I have seen this done (and I am not saying this is good or bad) is that "nonsensical"

[GitHub] kasjer commented on issue #1015: nrf52840 support for qspi flash

kasjer commented on issue #1015: nrf52840 support for qspi flash URL: https://github.com/apache/mynewt-core/pull/1015#issuecomment-381259746 @wes3 I agree, I will move definitions to MCU and I will add preprocessor checks to detect unchanged values as you suggested, thanks.

[GitHub] joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes

joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes URL: https://github.com/apache/mynewt-core/pull/699#issuecomment-381202294 Hi @sterlinghughes @rymanluk, quick question. I made the remaining changes, tested the code on my bmd300eval, and successfully did

[GitHub] joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes

joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes URL: https://github.com/apache/mynewt-core/pull/699#issuecomment-381202294 Hi @sterlinghughes @rymanluk, quick question. I made the remaining changes, tested the code on my bmd300eval, and successfully did

[GitHub] mlampert commented on issue #955: pwm enabled?

mlampert commented on issue #955: pwm enabled? URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-381237426 Looking at the API from a disable/stop perspective it might be worthwhile to reflect the channel in the API name: pwm_enable_duty_cycle ->

[GitHub] mlaz opened a new pull request #1016: [WIP] Adding pwm_is_enabled and other improvements.

mlaz opened a new pull request #1016: [WIP] Adding pwm_is_enabled and other improvements. URL: https://github.com/apache/mynewt-core/pull/1016 This PR addresses several issues described on https://github.com/apache/mynewt-core/issues/955

[mynewt-core] branch master updated: change config structure to use bitfields, fix bit shift and style error (#1012)

This is an automated email from the ASF dual-hosted git repository. vipulrahane pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 5f5ffe0 change config structure to

[GitHub] joshgrob opened a new pull request #1018: Sensors/BMA2XX - New PR from PR #699 comments

joshgrob opened a new pull request #1018: Sensors/BMA2XX - New PR from PR #699 comments URL: https://github.com/apache/mynewt-core/pull/1018 I prematurely closed PR 699, and this is the new PR based on the last discussions. Thank @ccollins476ad for the help and schooling and in GIT. It

[GitHub] vrahane opened a new pull request #1023: Sensor API: Support only one event per notifier/notification

vrahane opened a new pull request #1023: Sensor API: Support only one event per notifier/notification URL: https://github.com/apache/mynewt-core/pull/1023 - Earlier this was multiplexing multiple events for a single notification - This fixes #1021

[GitHub] vrahane opened a new pull request #1024: lis2dw12: Support sleep change event for notifications

vrahane opened a new pull request #1024: lis2dw12: Support sleep change event for notifications URL: https://github.com/apache/mynewt-core/pull/1024 - lis2dw12: Support sleep change event for notifications - Also cleaning up a bit, removing extraneous spaces, adding comments - Also

[GitHub] vrahane commented on issue #1024: lis2dw12: Support sleep change event for notifications

vrahane commented on issue #1024: lis2dw12: Support sleep change event for notifications URL: https://github.com/apache/mynewt-core/pull/1024#issuecomment-381293768 cc @brolan-juul : Please check it out. This is an automated

[mynewt-core] 01/01: Merge pull request #1025 from ccollins476ad/img-ver2-warning

This is an automated email from the ASF dual-hosted git repository. ccollins pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit 00396d5871d0632ced8969094ce969bab39d1e40 Merge: 5f5ffe0 13737bd Author: ccollins476ad

[GitHub] ccollins476ad closed pull request #1025: imgmgr: Prevent `maybe-uninitialized` warning.

ccollins476ad closed pull request #1025: imgmgr: Prevent `maybe-uninitialized` warning. URL: https://github.com/apache/mynewt-core/pull/1025 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] vrahane opened a new issue #1021: Sensor API: Support only one event per notifier/notification

vrahane opened a new issue #1021: Sensor API: Support only one event per notifier/notification URL: https://github.com/apache/mynewt-core/issues/1021 Earlier multiple events were being multiplexed into a single notification which should not be the case. It should be one event per

[GitHub] vrahane opened a new issue #1020: lis2dw12: int2 not routable for sensor notifications

vrahane opened a new issue #1020: lis2dw12: int2 not routable for sensor notifications URL: https://github.com/apache/mynewt-core/issues/1020 int2 not routable for sensor notifications This is an automated message from the

[GitHub] vrahane commented on issue #1024: lis2dw12: Support sleep change event for notifications

vrahane commented on issue #1024: lis2dw12: Support sleep change event for notifications URL: https://github.com/apache/mynewt-core/pull/1024#issuecomment-381293622 cc @matthewwarnes There were a bunch of things in the driver which needed changes. Please review it to make sure I haven't

[GitHub] vrahane commented on issue #1023: Sensor API: Support only one event per notifier/notification

vrahane commented on issue #1023: Sensor API: Support only one event per notifier/notification URL: https://github.com/apache/mynewt-core/pull/1023#issuecomment-381293700 cc @brolan-juul : Making sure I covered everything. Let me know if this looks good.

[mynewt-core] branch master updated (5f5ffe0 -> 00396d5)

This is an automated email from the ASF dual-hosted git repository. ccollins pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 5f5ffe0 change config structure to use bitfields, fix bit shift and style error (#1012) add 13737bd

[GitHub] vrahane closed issue #1022: lis2dw12: Support sleep change event for notifications

vrahane closed issue #1022: lis2dw12: Support sleep change event for notifications URL: https://github.com/apache/mynewt-core/issues/1022 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] vrahane closed pull request #1024: lis2dw12: Support sleep change event for notifications

vrahane closed pull request #1024: lis2dw12: Support sleep change event for notifications URL: https://github.com/apache/mynewt-core/pull/1024 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[mynewt-core] branch master updated: lis2dw12: Support sleep change event for notifications (#1024)

This is an automated email from the ASF dual-hosted git repository. vipulrahane pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new e0d46d6 lis2dw12: Support sleep

[GitHub] vrahane closed issue #1020: lis2dw12: int2 not routable for sensor notifications

vrahane closed issue #1020: lis2dw12: int2 not routable for sensor notifications URL: https://github.com/apache/mynewt-core/issues/1020 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] ccollins476ad opened a new pull request #1025: imgmgr: Prevent `maybe-uninitialized` warning.

ccollins476ad opened a new pull request #1025: imgmgr: Prevent `maybe-uninitialized` warning. URL: https://github.com/apache/mynewt-core/pull/1025 gcc 5.4.1 reports the following warning when `BOOTUTIL_IMAGE_FORMAT_V2` is enabled: ``` Error:

[GitHub] vrahane closed issue #1021: Sensor API: Support only one event per notifier/notification

vrahane closed issue #1021: Sensor API: Support only one event per notifier/notification URL: https://github.com/apache/mynewt-core/issues/1021 This is an automated message from the Apache Git Service. To respond to the

[mynewt-core] branch master updated: Sensor API: Support only one event per notifier/notification (#1023)

This is an automated email from the ASF dual-hosted git repository. vipulrahane pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 7fc8e45 Sensor API: Support only one

[GitHub] ccollins476ad opened a new pull request #1019: boot_serial: Remove required API "console"

ccollins476ad opened a new pull request #1019: boot_serial: Remove required API "console" URL: https://github.com/apache/mynewt-core/pull/1019 Now that the serial boot loader accesses the UART directly, it doesn't require a console package.

[GitHub] michal-narajowski commented on issue #876: UART logging caused an exception for nrf51 board

michal-narajowski commented on issue #876: UART logging caused an exception for nrf51 board URL: https://github.com/apache/mynewt-core/issues/876#issuecomment-381040717 Exactly. Here is a PR that replaces malloc with static allocation in nimble transport:

[GitHub] andrzej-kaczmarek closed pull request #894: console: Add asynchronous RX handling for UART

andrzej-kaczmarek closed pull request #894: console: Add asynchronous RX handling for UART URL: https://github.com/apache/mynewt-core/pull/894 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[mynewt-core] 01/01: Merge pull request #894 from andrzej-kaczmarek/console-fix

This is an automated email from the ASF dual-hosted git repository. andk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit 8ac604d63ac004ad18734c19dc34dbcb36a6772d Merge: 4df2d38 2f98c17 Author: Andrzej Kaczmarek

[mynewt-core] branch master updated (4df2d38 -> 8ac604d)

This is an automated email from the ASF dual-hosted git repository. andk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 4df2d38 Merge pull request #1008 from mkiiskila/lora_join_mic_acct add bcdb7b1 Revert "sys/console: Fix

[GitHub] michal-narajowski commented on issue #38: [WIP] Mesh storage

michal-narajowski commented on issue #38: [WIP] Mesh storage URL: https://github.com/apache/mynewt-nimble/pull/38#issuecomment-381062129 @jhedberg FYI This is an automated message from the Apache Git Service. To respond to

[GitHub] michal-narajowski opened a new pull request #1014: sys/shell: Improve command help information

michal-narajowski opened a new pull request #1014: sys/shell: Improve command help information URL: https://github.com/apache/mynewt-core/pull/1014 With this patch every piece of help (summary, usage, params) can be printed if is provided for a command. ``` btshell> help

[GitHub] michal-narajowski closed pull request #40: nimble/transport: Use static allocation for mempools

michal-narajowski closed pull request #40: nimble/transport: Use static allocation for mempools URL: https://github.com/apache/mynewt-nimble/pull/40 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[mynewt-nimble] branch master updated (d4fbd69 -> 42826d5)

This is an automated email from the ASF dual-hosted git repository. naraj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git. from d4fbd69 Merge pull request #42 from sjanc/le_ping add 4f39f1b nimble/transport: Use static allocation

[GitHub] mlaz commented on issue #955: pwm enabled?

mlaz commented on issue #955: pwm enabled? URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-381148189 Ok, I see 2 issues here, probably we want : 1 - To make pwm_disable to just stop the channel playback and not unconfigure it. Sincelosing the device will make every

[GitHub] jhedberg commented on a change in pull request #38: [WIP] Mesh storage

jhedberg commented on a change in pull request #38: [WIP] Mesh storage URL: https://github.com/apache/mynewt-nimble/pull/38#discussion_r181398002 ## File path: nimble/host/mesh/src/net.h ## @@ -266,9 +269,27 @@ extern struct bt_mesh_net bt_mesh; #define

[GitHub] mlaz commented on issue #955: pwm enabled?

mlaz commented on issue #955: pwm enabled? URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-381148189 Ok, I see 2 issues here, probably we want : 1 - pwm_disable to just make the channel stop and not unconfigure it. 2 - Closing the device will make every channel

[GitHub] mlaz commented on issue #955: pwm enabled?

mlaz commented on issue #955: pwm enabled? URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-381148189 Ok, I see 2 issues here, probably we want : 1 - To make pwm_disable to just stop the channel playback and not unconfigure it. 2 - Closing the device will make every

[GitHub] mlaz commented on issue #955: pwm enabled?

mlaz commented on issue #955: pwm enabled? URL: https://github.com/apache/mynewt-core/issues/955#issuecomment-381148189 Ok, I see 2 issues here, probably we want : 1 - To make pwm_disable to just stop the channel playback and not unconfigure it. Sincelosing the device will make every

[GitHub] sterlinghughes commented on issue #1015: nrf52840 support for qspi flash

sterlinghughes commented on issue #1015: nrf52840 support for qspi flash URL: https://github.com/apache/mynewt-core/pull/1015#issuecomment-381178519  This is an automated message from the Apache Git Service. To respond to

[GitHub] mlaz commented on a change in pull request #1015: nrf52840 support for qspi flash

mlaz commented on a change in pull request #1015: nrf52840 support for qspi flash URL: https://github.com/apache/mynewt-core/pull/1015#discussion_r181438590 ## File path: hw/mcu/nordic/nrf52xxx/src/hal_qspi.c ## @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software