vrahane merged pull request #2533:
URL: https://github.com/apache/mynewt-core/pull/2533
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
vipulrahane pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new bb8dc18 mcu/nrf5340: HAL gpio irq sho
This is an automated email from the ASF dual-hosted git repository.
vipulrahane pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new db685bc mcu/nrf5340: Pins should be c
vrahane merged pull request #2532:
URL: https://github.com/apache/mynewt-core/pull/2532
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vrahane opened a new pull request #2533:
URL: https://github.com/apache/mynewt-core/pull/2533
- hal gpio irq should use GPIOTE0 but GPIOTE1 was getting used
This is an automated message from the Apache Git Service.
To respond
This is an automated email from the ASF dual-hosted git repository.
wes3 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git
The following commit(s) were added to refs/heads/master by this push:
new dda185b nimble/ll: Fix possible race on TX
wes3 merged pull request #936:
URL: https://github.com/apache/mynewt-nimble/pull/936
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
apache-mynewt-bot commented on pull request #2532:
URL: https://github.com/apache/mynewt-core/pull/2532#issuecomment-799834106
## Style check summary
No suggestions at this time!
This is an automat
vrahane opened a new pull request #2532:
URL: https://github.com/apache/mynewt-core/pull/2532
- Pins hsould be checked for -1 for invalidity
This is an automated message from the Apache Git Service.
To respond to the message,
utzig commented on pull request #31:
URL: https://github.com/apache/mynewt-artifact/pull/31#issuecomment-799824484
@sjanc This fix should go into 1.9.0; need to update `newt` once this is
merged.
This is an automated message
utzig opened a new pull request #31:
URL: https://github.com/apache/mynewt-artifact/pull/31
When encrypting images, the hash was being calculated using the encrypted
image body. This is invalid for MCUboot, the hash must be calculated first from
the plain body and afterwards this body must
kasjer merged pull request #2531:
URL: https://github.com/apache/mynewt-core/pull/2531
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
jerzy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new 9927834 bsp/black_vet6: Fix ETH configurati
apache-mynewt-bot removed a comment on pull request #2531:
URL: https://github.com/apache/mynewt-core/pull/2531#issuecomment-799711352
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
apache-mynewt-bot commented on pull request #2531:
URL: https://github.com/apache/mynewt-core/pull/2531#issuecomment-799725071
## Style check summary
No suggestions at this time!
This is an automat
utzig commented on a change in pull request #2531:
URL: https://github.com/apache/mynewt-core/pull/2531#discussion_r594647034
##
File path: hw/bsp/black_vet6/src/hal_bsp.c
##
@@ -261,14 +261,15 @@ const struct stm32_eth_cfg os_bsp_eth0_cfg = {
.sec_port_mask[2] = (1 << 1)
apache-mynewt-bot commented on pull request #2531:
URL: https://github.com/apache/mynewt-core/pull/2531#issuecomment-799711352
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
hw/
utzig commented on pull request #2530:
URL: https://github.com/apache/mynewt-core/pull/2530#issuecomment-799708572
> I am not entirely sure what you mean by "code would stack in interrupt" on
the commit message, but code looks good!
Nicely improved now! :-)
kasjer opened a new pull request #2531:
URL: https://github.com/apache/mynewt-core/pull/2531
Some of the ETH pins were set up to port G.
There are not Port G pins on MCU on this board.
But there are pins from port B that can be used.
IRQ was hard coded to PA3 while ETH code allo
apache-mynewt-bot commented on pull request #2530:
URL: https://github.com/apache/mynewt-core/pull/2530#issuecomment-799684868
## Style check summary
No suggestions at this time!
This is an automat
apache-mynewt-bot removed a comment on pull request #2530:
URL: https://github.com/apache/mynewt-core/pull/2530#issuecomment-799608507
## Style check summary
No suggestions at this time!
This is an
kasjer commented on a change in pull request #2530:
URL: https://github.com/apache/mynewt-core/pull/2530#discussion_r594562480
##
File path: hw/mcu/sifive/fe310/src/hal_timer.c
##
@@ -169,9 +182,9 @@ int
hal_timer_init(int timer_num, void *cfg)
{
struct fe310_hal_tmr *tm
utzig commented on a change in pull request #2530:
URL: https://github.com/apache/mynewt-core/pull/2530#discussion_r594551372
##
File path: hw/mcu/sifive/fe310/src/hal_timer.c
##
@@ -169,9 +182,9 @@ int
hal_timer_init(int timer_num, void *cfg)
{
struct fe310_hal_tmr *tmr
apache-mynewt-bot commented on pull request #2530:
URL: https://github.com/apache/mynewt-core/pull/2530#issuecomment-799608507
## Style check summary
No suggestions at this time!
This is an automat
kasjer opened a new pull request #2530:
URL: https://github.com/apache/mynewt-core/pull/2530
Hal timer was not correctly setting up compare timer resulting
in interrupts firing at wrong time.
Problem was hidden if hal timer operated at high frequencies.
For low hal_timer frequencies
apache-mynewt-bot commented on pull request #936:
URL: https://github.com/apache/mynewt-nimble/pull/936#issuecomment-799568755
## Style check summary
No suggestions at this time!
This is an automat
andrzej-kaczmarek opened a new pull request #936:
URL: https://github.com/apache/mynewt-nimble/pull/936
Removing from ll_tx_pkt_q should be done in critical section since
insertion can be done from isr.
There's no need to protect peek on 1st element since we only insert
in isr a
utzig closed pull request #63:
URL: https://github.com/apache/mynewt-mcumgr/pull/63
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andrzej-kaczmarek merged pull request #2529:
URL: https://github.com/apache/mynewt-core/pull/2529
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
This is an automated email from the ASF dual-hosted git repository.
andk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
The following commit(s) were added to refs/heads/master by this push:
new 24d453e hw/bsp/dialog: Bump default msys blo
sjanc opened a new issue #119:
URL: https://github.com/apache/mynewt-mcumgr/issues/119
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
sjanc merged pull request #118:
URL: https://github.com/apache/mynewt-mcumgr/pull/118
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
This is an automated email from the ASF dual-hosted git repository.
janc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-mcumgr.git
The following commit(s) were added to refs/heads/master by this push:
new 62009e0 img_mgmt_state_set_pending: correc
apache-mynewt-bot commented on pull request #2529:
URL: https://github.com/apache/mynewt-core/pull/2529#issuecomment-799359976
## Style check summary
No suggestions at this time!
This is an automat
andrzej-kaczmarek opened a new pull request #2529:
URL: https://github.com/apache/mynewt-core/pull/2529
If msys block size is less than 308, all PDUs with max length will be
fragmented into chain. This is not only inefficient in terms of block
usage but also costs some time when alloca
sjanc merged pull request #899:
URL: https://github.com/apache/mynewt-nimble/pull/899
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
This is an automated email from the ASF dual-hosted git repository.
janc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git
The following commit(s) were added to refs/heads/master by this push:
new e83b12c NimBLE host: Make LE data length s
KKopyscinski commented on pull request #118:
URL: https://github.com/apache/mynewt-mcumgr/pull/118#issuecomment-799307428
@de-nordic I changed the code to what I think is inteded behavior
This is an automated message from the
de-nordic commented on a change in pull request #115:
URL: https://github.com/apache/mynewt-mcumgr/pull/115#discussion_r594168908
##
File path: cmd/img_mgmt/port/zephyr/src/zephyr_img_mgmt.c
##
@@ -400,6 +400,7 @@ int img_mgmt_impl_erase_if_needed(uint32_t off, uint32_t
len)
sjanc commented on a change in pull request #115:
URL: https://github.com/apache/mynewt-mcumgr/pull/115#discussion_r594180276
##
File path: cmd/img_mgmt/port/zephyr/src/zephyr_img_mgmt.c
##
@@ -400,6 +400,7 @@ int img_mgmt_impl_erase_if_needed(uint32_t off, uint32_t
len)
int
sjanc commented on a change in pull request #115:
URL: https://github.com/apache/mynewt-mcumgr/pull/115#discussion_r594180276
##
File path: cmd/img_mgmt/port/zephyr/src/zephyr_img_mgmt.c
##
@@ -400,6 +400,7 @@ int img_mgmt_impl_erase_if_needed(uint32_t off, uint32_t
len)
int
de-nordic commented on a change in pull request #115:
URL: https://github.com/apache/mynewt-mcumgr/pull/115#discussion_r594168908
##
File path: cmd/img_mgmt/port/zephyr/src/zephyr_img_mgmt.c
##
@@ -400,6 +400,7 @@ int img_mgmt_impl_erase_if_needed(uint32_t off, uint32_t
len)
de-nordic commented on pull request #118:
URL: https://github.com/apache/mynewt-mcumgr/pull/118#issuecomment-799254718
>
>
> So maybe just not overwrite error from `img_mgmt_impl_write_pending` and
straight out return it?
I think that should be ok. Better change it though by
sjanc commented on a change in pull request #115:
URL: https://github.com/apache/mynewt-mcumgr/pull/115#discussion_r594162611
##
File path: cmd/img_mgmt/port/zephyr/src/zephyr_img_mgmt.c
##
@@ -400,6 +400,7 @@ int img_mgmt_impl_erase_if_needed(uint32_t off, uint32_t
len)
int
KKopyscinski commented on pull request #118:
URL: https://github.com/apache/mynewt-mcumgr/pull/118#issuecomment-799249071
So maybe just not overwrite error from `img_mgmt_impl_write_pending` and
straight out return it?
This
de-nordic commented on a change in pull request #118:
URL: https://github.com/apache/mynewt-mcumgr/pull/118#discussion_r594157565
##
File path: cmd/img_mgmt/src/img_mgmt_state.c
##
@@ -133,15 +133,15 @@ img_mgmt_state_set_pending(int slot, int permanent)
*/
if (state
KKopyscinski commented on pull request #118:
URL: https://github.com/apache/mynewt-mcumgr/pull/118#issuecomment-799244691
@sjanc After looking at it again, I agree :) And this change makes `done`
marker obsolete
This is an a
sjanc commented on pull request #118:
URL: https://github.com/apache/mynewt-mcumgr/pull/118#issuecomment-799233008
Are you sure we should just ignore return value from write_pending() and not
bail out instead?
@utzig @de-nordic thoughts?
--
apache-mynewt-bot commented on pull request #899:
URL: https://github.com/apache/mynewt-nimble/pull/899#issuecomment-799204976
## Style check summary
### Our coding style is
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
nim
apache-mynewt-bot removed a comment on pull request #899:
URL: https://github.com/apache/mynewt-nimble/pull/899#issuecomment-799145823
## Style check summary
No suggestions at this time!
This is an
prasad-alatkar commented on pull request #899:
URL: https://github.com/apache/mynewt-nimble/pull/899#issuecomment-799201553
> looks good, could you just squash those into single commit? (it makes git
bisect a bit easier in future)
Sure, sure!!
--
sjanc commented on pull request #899:
URL: https://github.com/apache/mynewt-nimble/pull/899#issuecomment-799200973
looks good, could you just squash those into single commit? (it makes git
bisect a bit easier in future)
Thi
52 matches
Mail list logo
