Re: [PR] FWS-1372 Fix os_eventq_put() to wake up task only if EVQ_WAIT flag is set [mynewt-core]

2023-12-08 Thread via GitHub
vrahane commented on code in PR #3117: URL: https://github.com/apache/mynewt-core/pull/3117#discussion_r1419781700 ## kernel/os/src/os_eventq.c: ## @@ -69,7 +69,8 @@ os_eventq_put(struct os_eventq *evq, struct os_event *ev) * Check if task is sleeping, because another

Re: [PR] apps: add Auracast USB sample with LC3 codec [mynewt-nimble]

2023-12-11 Thread via GitHub
sjanc commented on code in PR #1659: URL: https://github.com/apache/mynewt-nimble/pull/1659#discussion_r1422097779 ## apps/auracast_usb/syscfg.usb.yml: ## @@ -0,0 +1,169 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] apps: add Auracast USB sample with LC3 codec [mynewt-nimble]

2023-12-11 Thread via GitHub
KKopyscinski commented on code in PR #1659: URL: https://github.com/apache/mynewt-nimble/pull/1659#discussion_r1422104953 ## apps/auracast_usb/syscfg.usb.yml: ## @@ -0,0 +1,169 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] apps: add Auracast USB sample with LC3 codec [mynewt-nimble]

2023-12-11 Thread via GitHub
KKopyscinski commented on code in PR #1659: URL: https://github.com/apache/mynewt-nimble/pull/1659#discussion_r1422105166 ## apps/auracast_usb/syscfg.usb.yml: ## @@ -0,0 +1,169 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

[PR] hw/drivers/i2s: Fix sample count for nrfx in i2s buffers [mynewt-core]

2023-12-11 Thread via GitHub
kasjer opened a new pull request, #3118: URL: https://github.com/apache/mynewt-core/pull/3118 For i2s in (microphone) sample_count was never set. It resulted in buffers returned to i2s client with no data. Now capacity is copied to sample_count as it is actual number of samples that were ca

[PR] hw/mcu/dialog: Fix download script [mynewt-core]

2023-12-11 Thread via GitHub
andrzej-kaczmarek opened a new pull request, #3119: URL: https://github.com/apache/mynewt-core/pull/3119 Need to break on mynewt_main instead of main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] hw/drivers/i2s: Fix sample count for nrfx in i2s buffers [mynewt-core]

2023-12-11 Thread via GitHub
kasjer merged PR #3118: URL: https://github.com/apache/mynewt-core/pull/3118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.

[PR] hw/drivers/i2s: Allow custom mck config [mynewt-core]

2023-12-11 Thread via GitHub
kasjer opened a new pull request, #3120: URL: https://github.com/apache/mynewt-core/pull/3120 It was possible to have custom value for MCK setup and ratio, but if it was set ACLK was no started. Now custom ration and mck setup can be set and ACLK still be started if requested -- This

Re: [PR] hw/mcu/dialog: Fix download script [mynewt-core]

2023-12-11 Thread via GitHub
andrzej-kaczmarek merged PR #3119: URL: https://github.com/apache/mynewt-core/pull/3119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[PR] nimble/gatts: Add check for RFU bits [mynewt-nimble]

2023-12-11 Thread via GitHub
Roshan23699 opened a new pull request, #1660: URL: https://github.com/apache/mynewt-nimble/pull/1660 Add Reserved For Future use bits check(needed for PTS) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] nimble/gatts: Add check for RFU bits [mynewt-nimble]

2023-12-11 Thread via GitHub
Roshan23699 commented on PR #1660: URL: https://github.com/apache/mynewt-nimble/pull/1660#issuecomment-1851258160 @sjanc PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] ext: add LC3 codec library [mynewt-nimble]

2023-12-11 Thread via GitHub
KKopyscinski merged PR #1658: URL: https://github.com/apache/mynewt-nimble/pull/1658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [I] Is it possible to run Nimble auto-pts on linux? [mynewt-nimble]

2023-12-12 Thread via GitHub
KKopyscinski commented on issue #1649: URL: https://github.com/apache/mynewt-nimble/issues/1649#issuecomment-1851573808 It is possible but it would require work on both auto-pts and NimBLE side. On autopts you'd have to create support in autoptsclient for new project - there is one for Myne

[PR] nimble/gatts: Modify client supported features READ [mynewt-nimble]

2023-12-12 Thread via GitHub
Roshan23699 opened a new pull request, #1661: URL: https://github.com/apache/mynewt-nimble/pull/1661 1. Fix read on client-supported features. 2. Read cannot return the local client-supported features, it should return the client-supported features for the reading connection. (This chang

[PR] baselibc: Fix fflush duplicate error [mynewt-core]

2023-12-12 Thread via GitHub
kasjer opened a new pull request, #3121: URL: https://github.com/apache/mynewt-core/pull/3121 This tries to fix error: Linking review/bin/targets/nordic_pca10056-auracast_usb/app/@apache-mynewt-nimble/apps/auracast_usb/auracast_usb.elf Error: Arm GNU Toolchain arm-none-eabi/13.2 Rel1/bi

Re: [PR] nimble/gatts: Modify client supported features READ [mynewt-nimble]

2023-12-13 Thread via GitHub
Roshan23699 commented on PR #1661: URL: https://github.com/apache/mynewt-nimble/pull/1661#issuecomment-1855109363 @sjanc could you PTAL ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] nimble/gatts: Modify client supported features READ [mynewt-nimble]

2023-12-13 Thread via GitHub
sjanc commented on PR #1661: URL: https://github.com/apache/mynewt-nimble/pull/1661#issuecomment-1855317885 Hi, which test was affected by this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] nimble/gatts: Modify client supported features READ [mynewt-nimble]

2023-12-14 Thread via GitHub
Roshan23699 commented on PR #1661: URL: https://github.com/apache/mynewt-nimble/pull/1661#issuecomment-1855583906 **GATT/SR/GAS/BV-04-C** Maintaining Client-Supported Features Characteristic Values for Bonded Devices. -- This is an automated message from the Apache Git Service

[I] SC Pairing not working: Inconsistent behavior in DH key exchange. [mynewt-nimble]

2023-12-15 Thread via GitHub
sacca97 opened a new issue, #1662: URL: https://github.com/apache/mynewt-nimble/issues/1662 When attempting to pair using SC with JustWorks inside the `ble_sm_sc_public_key_exec()` function the call to `ble_sm_tx()` writes the wrong content to the output buffer ~80% of the time, causing SC

Re: [I] Linker error: undefined reference to `console_rx_restart' when using Mynewt Console API [mynewt-core]

2023-12-16 Thread via GitHub
Kisszalimo closed issue #3109: Linker error: undefined reference to `console_rx_restart' when using Mynewt Console API URL: https://github.com/apache/mynewt-core/issues/3109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] nimble/host: Broadcast sink initial implementation [mynewt-nimble]

2023-12-18 Thread via GitHub
KKopyscinski opened a new pull request, #1663: URL: https://github.com/apache/mynewt-nimble/pull/1663 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [I] SC Pairing not working: Inconsistent behavior in DH key exchange. [mynewt-nimble]

2023-12-18 Thread via GitHub
sacca97 commented on issue #1662: URL: https://github.com/apache/mynewt-nimble/issues/1662#issuecomment-1860981598 My hypothesis: this is due to how the m_bufs are managed. So if you try to fill them just by working with pointers you will break something (?) if the content is too big.

Re: [I] SC Pairing not working: Inconsistent behavior in DH key exchange. [mynewt-nimble]

2023-12-18 Thread via GitHub
sjanc commented on issue #1662: URL: https://github.com/apache/mynewt-nimble/issues/1662#issuecomment-1861024835 Hi, Do you tune MSYS_1_BLOCK_SIZE ? Default 292 should be fine for LE SC. I think SMP code assumes continuous buffer for SMP commands so probably we miss some restricti

Re: [I] SC Pairing not working: Inconsistent behavior in DH key exchange. [mynewt-nimble]

2023-12-18 Thread via GitHub
sacca97 commented on issue #1662: URL: https://github.com/apache/mynewt-nimble/issues/1662#issuecomment-1861845024 Yeah I was using the provided sample app bleprp, which sets it to 110. I can see the problem now. I can work on a fix that fits all the scenarios in the next days and make a

[PR] hw/usb/tinyusb: Fix msc fat view with coredump on mcuboot [mynewt-core]

2023-12-19 Thread via GitHub
andrzej-kaczmarek opened a new pull request, #3122: URL: https://github.com/apache/mynewt-core/pull/3122 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] hw/usb/tinyusb: Fix msc fat view with coredump on mcuboot [mynewt-core]

2023-12-19 Thread via GitHub
andrzej-kaczmarek merged PR #3122: URL: https://github.com/apache/mynewt-core/pull/3122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

Re: [PR] nimble/gatts: Add check for RFU bits [mynewt-nimble]

2023-12-19 Thread via GitHub
sjanc commented on code in PR #1660: URL: https://github.com/apache/mynewt-nimble/pull/1660#discussion_r1424970147 ## nimble/host/src/ble_gatts.c: ## @@ -1587,6 +1587,8 @@ ble_gatts_peer_cl_sup_feat_update(uint16_t conn_handle, struct os_mbuf *om) int rc = 0; int feat

[PR] nimble/host: move ble_gatts_peer_cl_sup_feat_update to private API [mynewt-nimble]

2023-12-19 Thread via GitHub
KKopyscinski opened a new pull request, #1664: URL: https://github.com/apache/mynewt-nimble/pull/1664 This should be only for internal use. Return ATT error in ble_svc_gatt_cl_sup_feat_access, as ble_gatts_peer_cl_sup_feat_update returns host one. -- This is an automated message from the

Re: [PR] nimble/gatts: Add check for RFU bits [mynewt-nimble]

2023-12-20 Thread via GitHub
Roshan23699 commented on code in PR #1660: URL: https://github.com/apache/mynewt-nimble/pull/1660#discussion_r1432452776 ## nimble/host/src/ble_gatts.c: ## @@ -1587,6 +1587,8 @@ ble_gatts_peer_cl_sup_feat_update(uint16_t conn_handle, struct os_mbuf *om) int rc = 0; in

Re: [PR] nimble/gatts: Add check for RFU bits [mynewt-nimble]

2023-12-20 Thread via GitHub
Roshan23699 commented on code in PR #1660: URL: https://github.com/apache/mynewt-nimble/pull/1660#discussion_r1432453996 ## nimble/host/src/ble_gatts.c: ## @@ -1618,10 +1620,15 @@ ble_gatts_peer_cl_sup_feat_update(uint16_t conn_handle, struct os_mbuf *om) */

Re: [PR] nimble/gatts: Modify client supported features READ [mynewt-nimble]

2023-12-20 Thread via GitHub
sjanc commented on code in PR #1661: URL: https://github.com/apache/mynewt-nimble/pull/1661#discussion_r1432661663 ## nimble/host/include/host/ble_gatt.h: ## @@ -1096,6 +1096,25 @@ int ble_gatts_start(void); int ble_gatts_peer_cl_sup_feat_update(uint16_t conn_handle,

Re: [PR] nimble/gatts: Modify client supported features READ [mynewt-nimble]

2023-12-20 Thread via GitHub
KKopyscinski commented on code in PR #1661: URL: https://github.com/apache/mynewt-nimble/pull/1661#discussion_r1432667638 ## nimble/host/src/ble_gatts.c: ## @@ -1580,6 +1580,31 @@ ble_gatts_chr_updated(uint16_t chr_val_handle) } } +int +ble_gatts_get_peer_cl_sup_feat(uin

Re: [PR] nimble/gatts: Modify client supported features READ [mynewt-nimble]

2023-12-20 Thread via GitHub
sjanc commented on code in PR #1661: URL: https://github.com/apache/mynewt-nimble/pull/1661#discussion_r1432679893 ## nimble/host/src/ble_gatts.c: ## @@ -1580,6 +1580,31 @@ ble_gatts_chr_updated(uint16_t chr_val_handle) } } +int +ble_gatts_get_peer_cl_sup_feat(uint16_t c

[PR] nimble/host: Read supported HCI commands from controller [mynewt-nimble]

2023-12-21 Thread via GitHub
donatieng opened a new pull request, #1666: URL: https://github.com/apache/mynewt-nimble/pull/1666 This patch adds a new function, `ble_hs_startup_read_sup_cmd_tx()`, which reads the list of supported HCI commands from the controller, which is used on HCI startup. This is used to determine

[PR] tinyusb/msc_fat_view: Fix directory population condition [mynewt-core]

2023-12-21 Thread via GitHub
kasjer opened a new pull request, #3123: URL: https://github.com/apache/mynewt-core/pull/3123 Condition to populate disk presented over USB checked if last SCSI command was TEST_UNIT_READY. This only worked if TEST_UNIT_READY was send twice one after the other. It seems to work on Linux

[PR] tinyusb: Disable unused variable warning [mynewt-core]

2023-12-21 Thread via GitHub
kasjer opened a new pull request, #3124: URL: https://github.com/apache/mynewt-core/pull/3124 TinyUSB is not a part of mynewt-core and may occasionally has code that produces unsued-varialble warning that is escalated in mynewt to error. This disable warning that may cause builds to f

[PR] util/stream: Add streaming API [mynewt-core]

2023-12-21 Thread via GitHub
kasjer opened a new pull request, #3125: URL: https://github.com/apache/mynewt-core/pull/3125 This API provides interface to streams it should replace util/streamer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] nimble/gatts: Modify client supported features READ [mynewt-nimble]

2023-12-21 Thread via GitHub
Roshan23699 commented on code in PR #1661: URL: https://github.com/apache/mynewt-nimble/pull/1661#discussion_r1434777292 ## nimble/host/include/host/ble_gatt.h: ## @@ -1096,6 +1096,25 @@ int ble_gatts_start(void); int ble_gatts_peer_cl_sup_feat_update(uint16_t conn_handle,

Re: [PR] nimble/gatts: Modify client supported features READ [mynewt-nimble]

2023-12-22 Thread via GitHub
sjanc merged PR #1661: URL: https://github.com/apache/mynewt-nimble/pull/1661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt

Re: [PR] nimble/gatts: Add check for RFU bits [mynewt-nimble]

2023-12-22 Thread via GitHub
sjanc merged PR #1660: URL: https://github.com/apache/mynewt-nimble/pull/1660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt

[PR] Support for characteristic format descriptors. [mynewt-nimble]

2023-12-29 Thread via GitHub
Singh-Sumeet opened a new pull request, #1667: URL: https://github.com/apache/mynewt-nimble/pull/1667 The MR aims to add: 1. Support for one or more than one characteristic format descriptors for each characteristic. 2. Support for host add characteristic aggregate format descriptor if

[PR] Feature: Support to ask user for authorization [mynewt-nimble]

2023-12-29 Thread via GitHub
Singh-Sumeet opened a new pull request, #1668: URL: https://github.com/apache/mynewt-nimble/pull/1668 This MR aims to add: 1. Support to ask user for authorization in case of GATT read or write operations. 2. Relevant event handling in bleprph app. -- This is an automated message fr

Re: [PR] Feature: Support for characteristic format descriptors. [mynewt-nimble]

2023-12-29 Thread via GitHub
Singh-Sumeet commented on PR #1667: URL: https://github.com/apache/mynewt-nimble/pull/1667#issuecomment-1871898479 @sjanc Please TAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Feature: Support to ask user for authorization [mynewt-nimble]

2023-12-29 Thread via GitHub
Singh-Sumeet commented on PR #1668: URL: https://github.com/apache/mynewt-nimble/pull/1668#issuecomment-1871898696 @sjanc Please TAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Feature: Support to ask user for authorization [mynewt-nimble]

2023-12-29 Thread via GitHub
andrzej-kaczmarek commented on code in PR #1668: URL: https://github.com/apache/mynewt-nimble/pull/1668#discussion_r1438254833 ## nimble/host/include/host/ble_gap.h: ## @@ -292,6 +295,19 @@ struct hci_conn_update; /** @} */ +/** + * @defgroup GAP Authorize event possible re

Re: [I] GAP callback when receiving HCI completed packets [mynewt-nimble]

2023-12-30 Thread via GitHub
xyzzy42 commented on issue #1170: URL: https://github.com/apache/mynewt-nimble/issues/1170#issuecomment-1872500793 I'm trying to implement high bandwidth streaming from the BLE server to the client, using Notify, which is something I've done before with another BLE stack. Discovered

Re: [I] GAP callback when receiving HCI completed packets [mynewt-nimble]

2023-12-30 Thread via GitHub
xyzzy42 commented on issue #1170: URL: https://github.com/apache/mynewt-nimble/issues/1170#issuecomment-1872513014 I wondered how Espressif could claim 90 kB/sec BLE throughput, when lack of flow control means one needs to use indicate, write with response, or read, and these kill throughpu

[I] nimble-linux: ble_hci_sock_init: Assertion `rc == 0' failed. [mynewt-nimble]

2023-12-30 Thread via GitHub
Fanhang32 opened a new issue, #1669: URL: https://github.com/apache/mynewt-nimble/issues/1669 The linux examples failed to run in the latest code ``` bind() failed 16 hci0 nimble-linux: ../../../nimble/transport/socket/src/ble_hci_socket.c:828: ble_hci_sock_init: Assertion `rc == 0'

Re: [I] nimble-linux: ble_hci_sock_init: Assertion `rc == 0' failed. [mynewt-nimble]

2023-12-30 Thread via GitHub
Fanhang32 commented on issue #1669: URL: https://github.com/apache/mynewt-nimble/issues/1669#issuecomment-1872550715 If it is indeed necessary to do so,i can fix it by remove `ble_hci_sock_init ` from `ble_transport_ll_init ` in `ble_hci_socket.c` -- This is an automated message from the

Re: [PR] porting/linux: fix ble_hci_sock_init assertion [mynewt-nimble]

2023-12-30 Thread via GitHub
Fanhang32 commented on PR #1670: URL: https://github.com/apache/mynewt-nimble/pull/1670#issuecomment-1872550827 @sjanc @CW-B-W FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [I] nimble-linux: ble_hci_sock_init: Assertion `rc == 0' failed. [mynewt-nimble]

2023-12-30 Thread via GitHub
andrzej-kaczmarek commented on issue #1669: URL: https://github.com/apache/mynewt-nimble/issues/1669#issuecomment-1872558276 `ble_hci_sock_init` calls should be removed from apps. `ble_transport_ll_init` initializes LL side of transport which in case of external controller is a HCI so

Re: [I] nimble-linux: ble_hci_sock_init: Assertion `rc == 0' failed. [mynewt-nimble]

2023-12-30 Thread via GitHub
CW-B-W commented on issue #1669: URL: https://github.com/apache/mynewt-nimble/issues/1669#issuecomment-1872598661 Hello @Fanhang32, I'm only a user of this project, and I only played it with FreeRTOS, therefore the below might not be completely correct. --- In **mynewt-n

Re: [I] nimble-linux: ble_hci_sock_init: Assertion `rc == 0' failed. [mynewt-nimble]

2023-12-30 Thread via GitHub
Fanhang32 commented on issue #1669: URL: https://github.com/apache/mynewt-nimble/issues/1669#issuecomment-1872635850 @andrzej-kaczmarek @CW-B-W Got it , thanks a lot! I‘ve removed `ble_hci_sock_init` in example apps in https://github.com/apache/mynewt-nimble/pull/1670 -- This is an autom

Re: [PR] porting/linux: fix ble_hci_sock_init assertion [mynewt-nimble]

2023-12-31 Thread via GitHub
andrzej-kaczmarek merged PR #1670: URL: https://github.com/apache/mynewt-nimble/pull/1670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

Re: [I] nimble-linux: ble_hci_sock_init: Assertion `rc == 0' failed. [mynewt-nimble]

2023-12-31 Thread via GitHub
andrzej-kaczmarek closed issue #1669: nimble-linux: ble_hci_sock_init: Assertion `rc == 0' failed. URL: https://github.com/apache/mynewt-nimble/issues/1669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] GAP callback when receiving HCI completed packets [mynewt-nimble]

2024-01-02 Thread via GitHub
sjanc commented on issue #1170: URL: https://github.com/apache/mynewt-nimble/issues/1170#issuecomment-1873924295 Hi, We've been discussing this with @andrzej-kaczmarek a bit and have some thoughts on how using num complete packets could be implemented Since num complete packets

[PR] nimble/host: Fix possible overflow in ble_gatts_peer_cl_sup_feat_update [mynewt-nimble]

2024-01-02 Thread via GitHub
sjanc opened a new pull request, #1671: URL: https://github.com/apache/mynewt-nimble/pull/1671 This function would write pass conn->bhc_gatt_svr.peer_cl_sup_feat buffer. Since supported features are likely to be small (currently only 3 bits are defined) lets keep this simple and just make l

Re: [PR] nimble/host: Fix possible overflow in ble_gatts_peer_cl_sup_feat_update [mynewt-nimble]

2024-01-02 Thread via GitHub
sjanc commented on PR #1671: URL: https://github.com/apache/mynewt-nimble/pull/1671#issuecomment-1874218325 @Roshan23699 FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Fix HCI Set Event Mask Page 2 support in host and controller [mynewt-nimble]

2024-01-02 Thread via GitHub
donatieng commented on PR #1666: URL: https://github.com/apache/mynewt-nimble/pull/1666#issuecomment-1874318062 Issues (host tests and style) should now be fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] GAP callback when receiving HCI completed packets [mynewt-nimble]

2024-01-02 Thread via GitHub
xyzzy42 commented on issue #1170: URL: https://github.com/apache/mynewt-nimble/issues/1170#issuecomment-1874448906 The ENOMEM system I've already tried, but it has two major flaws. One is that the latency caused by the buffer size being that large is high. Anything with a real-time compon

Re: [PR] tinyusb: Disable unused variable warning [mynewt-core]

2024-01-04 Thread via GitHub
kasjer merged PR #3124: URL: https://github.com/apache/mynewt-core/pull/3124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.

Re: [PR] tinyusb/msc_fat_view: Fix directory population condition [mynewt-core]

2024-01-04 Thread via GitHub
kasjer merged PR #3123: URL: https://github.com/apache/mynewt-core/pull/3123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.

Re: [PR] baselibc: Fix fflush duplicate error [mynewt-core]

2024-01-04 Thread via GitHub
kasjer merged PR #3121: URL: https://github.com/apache/mynewt-core/pull/3121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.

Re: [PR] hw/drivers/i2s: Allow custom mck config [mynewt-core]

2024-01-04 Thread via GitHub
kasjer merged PR #3120: URL: https://github.com/apache/mynewt-core/pull/3120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.

Re: [PR] mscu/STM32H7 compatibility fixes [mynewt-core]

2024-01-04 Thread via GitHub
kasjer merged PR #3101: URL: https://github.com/apache/mynewt-core/pull/3101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.

Re: [PR] mcu/stm32: Use ST HAL for hal_nvreg [mynewt-core]

2024-01-04 Thread via GitHub
kasjer merged PR #3111: URL: https://github.com/apache/mynewt-core/pull/3111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.

[PR] Fix sysinit test [mynewt-newt]

2024-01-04 Thread via GitHub
sjanc opened a new pull request, #538: URL: https://github.com/apache/mynewt-newt/pull/538 Remove unneeded commands and update test reference data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Fix sysinit test [mynewt-newt]

2024-01-04 Thread via GitHub
sjanc commented on PR #538: URL: https://github.com/apache/mynewt-newt/pull/538#issuecomment-1876836496 for now just update test data, but we should reconsider on how we test this and how stable this should be -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] hw/bsp: Add arduino_zero bsp [mynewt-core]

2024-01-04 Thread via GitHub
kasjer merged PR #3107: URL: https://github.com/apache/mynewt-core/pull/3107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.

Re: [PR] ci: Build application samples [mynewt-core]

2024-01-04 Thread via GitHub
sjanc merged PR #3114: URL: https://github.com/apache/mynewt-core/pull/3114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.a

Re: [PR] Feature: Support to ask user for authorization [mynewt-nimble]

2024-01-04 Thread via GitHub
Singh-Sumeet commented on code in PR #1668: URL: https://github.com/apache/mynewt-nimble/pull/1668#discussion_r1442543442 ## nimble/host/src/ble_gap.c: ## @@ -6521,6 +6521,33 @@ ble_gap_unhandled_hci_event(bool is_le_meta, bool is_vs, const void *buf, } #endif +int +ble_gap

Re: [PR] Feature: Support to ask user for authorization [mynewt-nimble]

2024-01-04 Thread via GitHub
Singh-Sumeet commented on code in PR #1668: URL: https://github.com/apache/mynewt-nimble/pull/1668#discussion_r1442543919 ## nimble/host/src/ble_gap.c: ## @@ -6458,7 +6458,7 @@ ble_gap_subscribe_event(uint16_t conn_handle, uint16_t attr_handle, uint8_t

Re: [PR] Feature: Support to ask user for authorization [mynewt-nimble]

2024-01-04 Thread via GitHub
Singh-Sumeet commented on code in PR #1668: URL: https://github.com/apache/mynewt-nimble/pull/1668#discussion_r1442543136 ## nimble/host/include/host/ble_gap.h: ## @@ -258,6 +258,9 @@ struct hci_conn_update; /** GAP event: BIG (Broadcast Isochronous Group) information report */

Re: [PR] Feature: Support to ask user for authorization [mynewt-nimble]

2024-01-04 Thread via GitHub
Singh-Sumeet commented on code in PR #1668: URL: https://github.com/apache/mynewt-nimble/pull/1668#discussion_r1442547803 ## nimble/host/include/host/ble_gap.h: ## @@ -292,6 +295,19 @@ struct hci_conn_update; /** @} */ +/** + * @defgroup GAP Authorize event possible respons

[PR] Signed Write support [mynewt-nimble]

2024-01-04 Thread via GitHub
Singh-Sumeet opened a new pull request, #1672: URL: https://github.com/apache/mynewt-nimble/pull/1672 This PR aims to: 1. Add support for sending signed write commands 2. Add support of receiving signed write commands -- This is an automated message from the Apache Git Service. To re

Re: [PR] Signed Write support [mynewt-nimble]

2024-01-04 Thread via GitHub
Singh-Sumeet commented on PR #1672: URL: https://github.com/apache/mynewt-nimble/pull/1672#issuecomment-1878244923 @sjanc PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Signed Write support [mynewt-nimble]

2024-01-05 Thread via GitHub
sjanc commented on PR #1672: URL: https://github.com/apache/mynewt-nimble/pull/1672#issuecomment-1878396092 Hi, Few general things (I'll have more detailed comments after doing full code review) 1) add support for this in bttester (and maybe btshell) 2) test it with PTS (eg vi

Re: [PR] Fix sysinit test [mynewt-newt]

2024-01-05 Thread via GitHub
sjanc merged PR #538: URL: https://github.com/apache/mynewt-newt/pull/538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apa

Re: [PR] apps: add Auracast USB sample with LC3 codec [mynewt-nimble]

2024-01-08 Thread via GitHub
KKopyscinski commented on PR #1659: URL: https://github.com/apache/mynewt-nimble/pull/1659#issuecomment-1880700604 @sjanc https://github.com/apache/mynewt-core/pull/3121 patch was merged and this builds now, can I merge this PR? -- This is an automated message from the Apache Git Service.

Re: [PR] compiler: Strip .image_header section in bin [mynewt-newt]

2024-01-08 Thread via GitHub
kasjer merged PR #535: URL: https://github.com/apache/mynewt-newt/pull/535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.ap

Re: [PR] builder: Export more env variables for scripts [mynewt-newt]

2024-01-08 Thread via GitHub
kasjer merged PR #536: URL: https://github.com/apache/mynewt-newt/pull/536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.ap

Re: [PR] apps: add Auracast USB sample with LC3 codec [mynewt-nimble]

2024-01-08 Thread via GitHub
KKopyscinski commented on PR #1659: URL: https://github.com/apache/mynewt-nimble/pull/1659#issuecomment-1880953691 @andrzej-kaczmarek removed unused and debug code, added serial ID config -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] GAP callback when receiving HCI completed packets [mynewt-nimble]

2024-01-08 Thread via GitHub
xyzzy42 commented on issue #1170: URL: https://github.com/apache/mynewt-nimble/issues/1170#issuecomment-1881727008 Micropython is now streaming data with BLE at over 110 kB/sec. Didn't even need to write the streaming code in C. It's actually better than the ESP32 throughput demo (Bluedro

Re: [PR] nimble/host: Fix possible overflow in ble_gatts_peer_cl_sup_feat_update [mynewt-nimble]

2024-01-09 Thread via GitHub
sjanc merged PR #1671: URL: https://github.com/apache/mynewt-nimble/pull/1671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt

Re: [I] Passkey/password pairing with NimBLE? [mynewt-nimble]

2024-01-09 Thread via GitHub
xyzzy42 commented on issue #1193: URL: https://github.com/apache/mynewt-nimble/issues/1193#issuecomment-1884119494 You can used a (semi-)fixed passkey and print it on the device, or, as described in OP's original design, have some kind of enrollment mode where the passkey is set. The

[PR] Update NRFX to version 3.3 [mynewt-core]

2024-01-10 Thread via GitHub
kasjer opened a new pull request, #3126: URL: https://github.com/apache/mynewt-core/pull/3126 NRFX change to vesion 3.3 required: - update of I2S due to multiply I2S peripheral instance support in (API changed) - pwm unused pin constant changed name - function to change pin assignme

Re: [I] Error during execution of build.sh [mynewt-newt]

2024-01-10 Thread via GitHub
qiuchengkai commented on issue #390: URL: https://github.com/apache/mynewt-newt/issues/390#issuecomment-1885132901 怎么解决的? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] nimble/ll: Fix PHY update instant calculation [mynewt-nimble]

2024-01-12 Thread via GitHub
sjanc merged PR #1665: URL: https://github.com/apache/mynewt-nimble/pull/1665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt

[PR] newt: Add possibility to mark package as experimental [mynewt-newt]

2024-01-12 Thread via GitHub
m-gorecki opened a new pull request, #539: URL: https://github.com/apache/mynewt-newt/pull/539 This adds possibility to mark package as experimental by adding "pkg.experimental: 1" line in the pkg.yml file. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] newt: Add possibility to mark package as experimental [mynewt-newt]

2024-01-12 Thread via GitHub
MariuszSkamra commented on PR #539: URL: https://github.com/apache/mynewt-newt/pull/539#issuecomment-1889413360 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[I] 在 ./build.sh后报如下错误 [mynewt-core]

2024-01-12 Thread via GitHub
qiuchengkai opened a new issue, #3127: URL: https://github.com/apache/mynewt-core/issues/3127 15141@qiu UCRT64 ~/mynewt-newt-mynewt_1_3_0_tag $ ./build.sh ./build.sh: line 30: go: command not found * Error: could not extract go version (version string: ) 15141@qiu UCRT64 ~

[PR] sys/log/modlog: Add modlog hexdump [mynewt-core]

2024-01-15 Thread via GitHub
m-gorecki opened a new pull request, #3128: URL: https://github.com/apache/mynewt-core/pull/3128 This adds MODLOG_HEXDUMP macros which allow to write specified number of bytes' values in a string format into the log modules. -- This is an automated message from the Apache Git Service. To

[PR] Fix pairing error [mynewt-nimble]

2024-01-16 Thread via GitHub
szymon-czapracki opened a new pull request, #1673: URL: https://github.com/apache/mynewt-nimble/pull/1673 This commit fixes an issue regarding pairing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Fix pairing error [mynewt-nimble]

2024-01-16 Thread via GitHub
andrzej-kaczmarek commented on PR #1673: URL: https://github.com/apache/mynewt-nimble/pull/1673#issuecomment-1893746381 issue description is missing in commit message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Update NRFX to version 3.3 [mynewt-core]

2024-01-17 Thread via GitHub
rymanluk merged PR #3126: URL: https://github.com/apache/mynewt-core/pull/3126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynew

[I] Ability for ble_gatts_notify_custom() to wait for new packet buffers [mynewt-nimble]

2024-01-17 Thread via GitHub
bryghtlabs-richard opened a new issue, #1674: URL: https://github.com/apache/mynewt-nimble/issues/1674 I suggest a new feature where a caller can wait for new packet buffers and specify a timeout limiting how long to wait for a packet buffer or queue entry to become available. I have an ide

[PR] [VIP] Add common startup [mynewt-core]

2024-01-19 Thread via GitHub
kasjer opened a new pull request, #3129: URL: https://github.com/apache/mynewt-core/pull/3129 Nor ready yet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] [WIP] newt: Use default linker script if it's not specified in bsp.yml [mynewt-newt]

2024-01-19 Thread via GitHub
m-gorecki opened a new pull request, #540: URL: https://github.com/apache/mynewt-newt/pull/540 Now if "bsp.linkerscript" key is empty default linker script will be passed to the linker. IMPORTANT: bsp.linkerscript key still has to be present in the bsp.yml file. It simply has to exis

Re: [PR] Fix pairing error [mynewt-nimble]

2024-01-21 Thread via GitHub
sjanc commented on code in PR #1673: URL: https://github.com/apache/mynewt-nimble/pull/1673#discussion_r1461455159 ## nimble/host/src/ble_gap.c: ## @@ -6201,7 +6201,8 @@ ble_gap_unpair(const ble_addr_t *peer_addr) rc = ble_hs_pvcy_remove_entry(peer_addr->type,

Re: [PR] nimble/services: add PACS [mynewt-nimble]

2024-01-22 Thread via GitHub
KKopyscinski commented on PR #1675: URL: https://github.com/apache/mynewt-nimble/pull/1675#issuecomment-1903930547 @MariuszSkamra -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

<    1   2   3   4   5   6   7   8   9   10   >