[GitHub] [mynewt-nimble] sjanc merged pull request #1607: porting/linux: fix deadlock in ble_npl_hw_enter_critical

2023-09-20 Thread via GitHub
sjanc merged PR #1607: URL: https://github.com/apache/mynewt-nimble/pull/1607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] sjanc opened a new pull request, #3074: ci: Don't build all targets on Windows and Mac

2023-09-20 Thread via GitHub
sjanc opened a new pull request, #3074: URL: https://github.com/apache/mynewt-core/pull/3074 Mac and (especially) Windows VMs are much slower than Linux. There is no need to build all targets on all platforms and thus build only few selected targets on slow VMs. -- This is an automated

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1624: ci: Build tests under standard project folder tree

2023-09-25 Thread via GitHub
sjanc opened a new pull request, #1624: URL: https://github.com/apache/mynewt-nimble/pull/1624 This uses standard folder tree to build tests (where nimble is in repos folder, and not as a top project folder). -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [mynewt-core] Kisszalimo commented on issue #3066: RAM overflow error when build app for PineTime

2023-09-25 Thread via GitHub
Kisszalimo commented on issue #3066: URL: https://github.com/apache/mynewt-core/issues/3066#issuecomment-1734148661 @kasjer i was able to reduce my build by applying your advice. Now it uses ~180KB space which is a notable difference (of course it depends on the needs of your application).

[GitHub] [mynewt-core] dustinfranco opened a new pull request, #3084: [FWW-262] added critical section to dma acquire peripheral

2023-09-28 Thread via GitHub
dustinfranco opened a new pull request, #3084: URL: https://github.com/apache/mynewt-core/pull/3084 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [mynewt-core] dustinfranco closed pull request #3084: hw/mcu/dialog: added critical section to dma acquire peripheral

2023-09-28 Thread via GitHub
dustinfranco closed pull request #3084: hw/mcu/dialog: added critical section to dma acquire peripheral URL: https://github.com/apache/mynewt-core/pull/3084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [mynewt-core] wes3 merged pull request #3085: hw/mcu/dialog: added critical section to dma acquire peripheral

2023-09-28 Thread via GitHub
wes3 merged PR #3085: URL: https://github.com/apache/mynewt-core/pull/3085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] dustinfranco opened a new pull request, #3085: hw/mcu/dialog: added critical section to dma acquire peripheral

2023-09-28 Thread via GitHub
dustinfranco opened a new pull request, #3085: URL: https://github.com/apache/mynewt-core/pull/3085 Added critical section inside of da1469x_dma_acquire_periph() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [mynewt-core] sjanc merged pull request #3082: ci: Enable Bluetooth Enhanced CoC code in coverity targets

2023-09-29 Thread via GitHub
sjanc merged PR #3082: URL: https://github.com/apache/mynewt-core/pull/3082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] sjanc opened a new pull request, #3086: ci: Restore bootloader target for nRF51

2023-09-29 Thread via GitHub
sjanc opened a new pull request, #3086: URL: https://github.com/apache/mynewt-core/pull/3086 It was accidentally moved to NimBLE CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1537: Added periodic adv feature updates in ble 5.3

2023-09-29 Thread via GitHub
sjanc commented on code in PR #1537: URL: https://github.com/apache/mynewt-nimble/pull/1537#discussion_r1341122770 ## nimble/host/src/ble_gap.c: ## @@ -3817,7 +3846,9 @@ ble_gap_periodic_adv_set_data_validate(uint8_t instance, } int -ble_gap_periodic_adv_set_data(uint8_t

[GitHub] [mynewt-core] 5614037u commented on issue #3064: apache-mynewt-core repo dirty state and Blinky sample nrf52_boot build failure

2023-09-29 Thread via GitHub
5614037u commented on issue #3064: URL: https://github.com/apache/mynewt-core/issues/3064#issuecomment-1740552070 > Hi, > > Try clearing up changes in core repo before retrying (cd repos/apache-mynewt-core; git stash) and retrying > > I'd also suggest to try with newt 1.11

[GitHub] [mynewt-core] sjanc commented on a diff in pull request #3080: lvgl: Add driver for cst816s touch screen

2023-09-29 Thread via GitHub
sjanc commented on code in PR #3080: URL: https://github.com/apache/mynewt-core/pull/3080#discussion_r1341237666 ## hw/drivers/display/lvgl/indev/cst816s/src/cst816s.c: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1629: ci: Fix test targets configurations

2023-09-29 Thread via GitHub
sjanc opened a new pull request, #1629: URL: https://github.com/apache/mynewt-nimble/pull/1629 Some test targets were not configured properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [mynewt-core] sjanc merged pull request #3086: ci: Restore bootloader target for nRF51

2023-09-29 Thread via GitHub
sjanc merged PR #3086: URL: https://github.com/apache/mynewt-core/pull/3086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] kasjer opened a new pull request, #3088: lvgl: Add i2c interface driver

2023-09-29 Thread via GitHub
kasjer opened a new pull request, #3088: URL: https://github.com/apache/mynewt-core/pull/3088 Driver for display that have I2C interface (SDD1306) Signed-off-by: Jerzy Kasenberg -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [mynewt-core] kasjer opened a new pull request, #3087: hw/bsp/nucleo-u575zi-q: Fix I2C register names

2023-09-29 Thread via GitHub
kasjer opened a new pull request, #3087: URL: https://github.com/apache/mynewt-core/pull/3087 Registers names for I2C were incorrect resulting in build error when I2C was enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [mynewt-nimble] RoshanESP commented on a diff in pull request #1537: Added periodic adv feature updates in ble 5.3

2023-09-27 Thread via GitHub
RoshanESP commented on code in PR #1537: URL: https://github.com/apache/mynewt-nimble/pull/1537#discussion_r1339543382 ## nimble/host/include/host/ble_gap.h: ## @@ -1558,10 +1588,15 @@ int ble_gap_periodic_adv_configure(uint8_t instance, * Start periodic advertising for

[GitHub] [mynewt-nimble] RoshanESP commented on a diff in pull request #1537: Added periodic adv feature updates in ble 5.3

2023-09-27 Thread via GitHub
RoshanESP commented on code in PR #1537: URL: https://github.com/apache/mynewt-nimble/pull/1537#discussion_r1339544035 ## nimble/host/include/host/ble_gap.h: ## @@ -1578,10 +1613,14 @@ int ble_gap_periodic_adv_stop(uint8_t instance); * * @param instanceInstance

[GitHub] [mynewt-nimble] RoshanESP commented on a diff in pull request #1537: Added periodic adv feature updates in ble 5.3

2023-09-27 Thread via GitHub
RoshanESP commented on code in PR #1537: URL: https://github.com/apache/mynewt-nimble/pull/1537#discussion_r1339544689 ## nimble/host/src/ble_gap.c: ## @@ -3703,6 +3713,25 @@ ble_gap_periodic_adv_start(uint8_t instance) return 0; } +#if MYNEWT_VAL(BLE_PERIODIC_ADV_ENH)

[GitHub] [mynewt-nimble] RoshanESP commented on a diff in pull request #1537: Added periodic adv feature updates in ble 5.3

2023-09-27 Thread via GitHub
RoshanESP commented on code in PR #1537: URL: https://github.com/apache/mynewt-nimble/pull/1537#discussion_r1339543564 ## nimble/host/include/host/ble_gap.h: ## @@ -1524,6 +1524,30 @@ struct ble_gap_periodic_adv_params { uint16_t itvl_max; }; +/** @brief Periodic

[GitHub] [mynewt-nimble] RoshanESP commented on a diff in pull request #1537: Added periodic adv feature updates in ble 5.3

2023-09-27 Thread via GitHub
RoshanESP commented on code in PR #1537: URL: https://github.com/apache/mynewt-nimble/pull/1537#discussion_r1339543756 ## nimble/host/include/host/ble_gap.h: ## @@ -1625,10 +1664,14 @@ int ble_gap_periodic_adv_sync_terminate(uint16_t sync_handle); * * @param sync_handle

[GitHub] [mynewt-nimble] rymanluk commented on a diff in pull request #1622: nimble/host: Add Initial ISO implementation

2023-10-02 Thread via GitHub
rymanluk commented on code in PR #1622: URL: https://github.com/apache/mynewt-nimble/pull/1622#discussion_r1342333074 ## nimble/host/src/ble_hs.c: ## @@ -301,6 +312,10 @@ ble_hs_clear_rx_queue(void) while ((om = ble_mqueue_get(_hs_rx_q)) != NULL) {

[GitHub] [mynewt-nimble] rymanluk commented on a diff in pull request #1622: nimble/host: Add Initial ISO implementation

2023-10-02 Thread via GitHub
rymanluk commented on code in PR #1622: URL: https://github.com/apache/mynewt-nimble/pull/1622#discussion_r1342333578 ## nimble/host/src/ble_hs.c: ## @@ -675,6 +696,24 @@ ble_hs_rx_data(struct os_mbuf *om, void *arg) return 0; } +static int +ble_hs_rx_iso(struct os_mbuf

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342368088 ## nimble/host/include/host/ble_iso.h: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342381328 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342381083 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342393231 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342401698 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [mynewt-nimble] pfyra commented on a diff in pull request #1591: porting/npl/freertos: Add way of including HW specific header

2023-10-02 Thread via GitHub
pfyra commented on code in PR #1591: URL: https://github.com/apache/mynewt-nimble/pull/1591#discussion_r1342327256 ## porting/npl/freertos/src/npl_os_freertos.c: ## @@ -22,6 +22,10 @@ #include #include "nimble/nimble_npl.h" +#ifdef NIMBLE_NPL_OS_EXTRA_INCLUDE +#include

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
rymanluk commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342355116 ## nimble/host/include/host/ble_iso.h: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342388553 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342399723 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342403891 ## nimble/host/services/leaudio/auracast/include/leaudio/auracast/auracast.h: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342404402 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [mynewt-nimble] rymanluk commented on a diff in pull request #1622: nimble/host: Add Initial ISO implementation

2023-10-02 Thread via GitHub
rymanluk commented on code in PR #1622: URL: https://github.com/apache/mynewt-nimble/pull/1622#discussion_r1342331500 ## nimble/host/include/host/ble_iso.h: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [mynewt-nimble] rymanluk commented on a diff in pull request #1619: nimble/host: broadcast and Auracast API

2023-10-02 Thread via GitHub
rymanluk commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342349115 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342370944 ## nimble/host/include/host/ble_audio_common.h: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342369805 ## nimble/host/include/host/ble_iso.h: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342369805 ## nimble/host/include/host/ble_iso.h: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342379985 ## nimble/host/include/host/ble_audio_common.h: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342380563 ## nimble/host/include/host/ble_audio_common.h: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342379563 ## nimble/host/include/host/ble_audio_common.h: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342400241 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342400869 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342401698 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342403401 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342375997 ## nimble/host/include/host/ble_audio_common.h: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342388136 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342366819 ## nimble/host/include/host/ble_iso.h: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342365559 ## nimble/host/include/host/ble_iso.h: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342385962 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342405292 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342405292 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] nimble/host: broadcast and Auracast API [mynewt-nimble]

2023-10-02 Thread via GitHub
KKopyscinski commented on code in PR #1619: URL: https://github.com/apache/mynewt-nimble/pull/1619#discussion_r1342412569 ## nimble/host/include/host/ble_audio_broadcast.h: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] porting/npl/freertos: Add way of including HW specific header [mynewt-nimble]

2023-10-02 Thread via GitHub
sjanc merged PR #1591: URL: https://github.com/apache/mynewt-nimble/pull/1591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] nimble/host: Add Initial ISO implementation [mynewt-nimble]

2023-10-03 Thread via GitHub
KKopyscinski commented on code in PR #1622: URL: https://github.com/apache/mynewt-nimble/pull/1622#discussion_r1343575705 ## nimble/host/include/host/ble_iso.h: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

Re: [PR] nimble/host: Add Initial ISO implementation [mynewt-nimble]

2023-10-03 Thread via GitHub
KKopyscinski commented on code in PR #1622: URL: https://github.com/apache/mynewt-nimble/pull/1622#discussion_r1343575519 ## nimble/host/src/ble_hs.c: ## @@ -675,6 +696,24 @@ ble_hs_rx_data(struct os_mbuf *om, void *arg) return 0; } +static int +ble_hs_rx_iso(struct

Re: [PR] nimble/host: Add Initial ISO implementation [mynewt-nimble]

2023-10-03 Thread via GitHub
KKopyscinski commented on PR #1622: URL: https://github.com/apache/mynewt-nimble/pull/1622#issuecomment-1744302739 @rymanluk I also checked build again, resolved some issues and added missing code from cd795d0 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] mcu/nordic: Require LF clock source to be specified [mynewt-core]

2023-10-03 Thread via GitHub
sjanc commented on PR #3059: URL: https://github.com/apache/mynewt-core/pull/3059#issuecomment-1744372039 > (Continued from Slack) My mistake was to explicitly use LFRC though and `$notnull` would not catch that. I was wondering whether a restriction like `MCU_LFCLK_SOURCE == 'LFRC' &&

Re: [PR] mcu/nordic: Require LF clock source to be specified [mynewt-core]

2023-10-03 Thread via GitHub
sjanc merged PR #3059: URL: https://github.com/apache/mynewt-core/pull/3059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] hw/bsp/nucleo-u575zi-q: Fix I2C register names [mynewt-core]

2023-10-02 Thread via GitHub
kasjer merged PR #3087: URL: https://github.com/apache/mynewt-core/pull/3087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] RayCxggg opened a new issue, #3083: Program received signal SIGTRAP

2023-09-26 Thread via GitHub
RayCxggg opened a new issue, #3083: URL: https://github.com/apache/mynewt-core/issues/3083 Hi, I am using Ubuntu 20.04 on WSL2 to develop Mynewt on Nordic 52840 DK. I am trying to build a simple NimBLE application following the

[GitHub] [mynewt-core] sjanc commented on issue #1389: SPI never initialized and no errors (stm32)

2023-09-26 Thread via GitHub
sjanc commented on issue #1389: URL: https://github.com/apache/mynewt-core/issues/1389#issuecomment-1734914764 should be fixed in master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [mynewt-core] sjanc closed issue #1389: SPI never initialized and no errors (stm32)

2023-09-26 Thread via GitHub
sjanc closed issue #1389: SPI never initialized and no errors (stm32) URL: https://github.com/apache/mynewt-core/issues/1389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [mynewt-core] sjanc closed issue #2122: Removed field `t_stacktop`still referenced in a few places

2023-09-26 Thread via GitHub
sjanc closed issue #2122: Removed field `t_stacktop`still referenced in a few places URL: https://github.com/apache/mynewt-core/issues/2122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [mynewt-core] kasjer commented on issue #3066: RAM overflow error when build app for PineTime

2023-09-26 Thread via GitHub
kasjer commented on issue #3066: URL: https://github.com/apache/mynewt-core/issues/3066#issuecomment-1734908651 For now there is no effort to have older version supported. If I have time I will see if we can override LVGL version in project.yml (I'm not sure if this will require some

[GitHub] [mynewt-nimble] sjanc closed issue #123: Split UART transport into host and controller parts

2023-09-26 Thread via GitHub
sjanc closed issue #123: Split UART transport into host and controller parts URL: https://github.com/apache/mynewt-nimble/issues/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [mynewt-nimble] sjanc closed issue #989: Multiple simultaneous connections cause reset after many PHY updates

2023-09-26 Thread via GitHub
sjanc closed issue #989: Multiple simultaneous connections cause reset after many PHY updates URL: https://github.com/apache/mynewt-nimble/issues/989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1626: ci: Add workflow for testing various GCC versions

2023-09-26 Thread via GitHub
sjanc opened a new pull request, #1626: URL: https://github.com/apache/mynewt-nimble/pull/1626 This will help make sure we build correctly with more GCC version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [mynewt-core] sjanc closed issue #879: Add API to lock/unlock the scheduler.

2023-09-26 Thread via GitHub
sjanc closed issue #879: Add API to lock/unlock the scheduler. URL: https://github.com/apache/mynewt-core/issues/879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [mynewt-nimble] sjanc merged pull request #1624: ci: Build tests under standard project folder tree

2023-09-26 Thread via GitHub
sjanc merged PR #1624: URL: https://github.com/apache/mynewt-nimble/pull/1624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] sjanc merged pull request #3081: ci: Build tests under standard project folder tree

2023-09-26 Thread via GitHub
sjanc merged PR #3081: URL: https://github.com/apache/mynewt-core/pull/3081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] KKopyscinski merged pull request #1586: nimble/host: Add connection handle realated GAP APIs to header file

2023-09-26 Thread via GitHub
KKopyscinski merged PR #1586: URL: https://github.com/apache/mynewt-nimble/pull/1586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] RayCxggg closed issue #3083: Program received signal SIGTRAP

2023-09-27 Thread via GitHub
RayCxggg closed issue #3083: Program received signal SIGTRAP URL: https://github.com/apache/mynewt-core/issues/3083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [mynewt-core] RayCxggg commented on issue #3083: Program received signal SIGTRAP

2023-09-27 Thread via GitHub
RayCxggg commented on issue #3083: URL: https://github.com/apache/mynewt-core/issues/3083#issuecomment-1736796645 Sorry, I figure it out. Since the BLE doc presumes that you have come through the previous chapters, it omits the steps to load the bootloader. However, I happened to load

[GitHub] [mynewt-core] sjanc opened a new pull request, #3082: ci: Enable Bluetooth Enhanced CoC code in coverity targets

2023-09-26 Thread via GitHub
sjanc opened a new pull request, #3082: URL: https://github.com/apache/mynewt-core/pull/3082 Allows to cover more code on analysis. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [mynewt-nimble] sjanc merged pull request #1627: apps/btshell: fix cmd_l2cap_reconfig command

2023-09-26 Thread via GitHub
sjanc merged PR #1627: URL: https://github.com/apache/mynewt-nimble/pull/1627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] sjanc opened a new pull request, #1628: ci: Enable BLE_L2CAP_ENHANCED_COC in btshell_all target

2023-09-26 Thread via GitHub
sjanc opened a new pull request, #1628: URL: https://github.com/apache/mynewt-nimble/pull/1628 This allows to test more code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [mynewt-core] RayCxggg commented on issue #3070: NimBLE sample build error with apache-mynewt-core

2023-09-26 Thread via GitHub
RayCxggg commented on issue #3070: URL: https://github.com/apache/mynewt-core/issues/3070#issuecomment-1735403552 Thanks a lot. I will try to report to Ubuntu community. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [mynewt-nimble] sjanc merged pull request #1628: ci: Enable BLE_L2CAP_ENHANCED_COC in btshell_all target

2023-09-26 Thread via GitHub
sjanc merged PR #1628: URL: https://github.com/apache/mynewt-nimble/pull/1628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-nimble] KKopyscinski opened a new pull request, #1627: apps/btshell: fix cmd_l2cap_reconfig command

2023-09-26 Thread via GitHub
KKopyscinski opened a new pull request, #1627: URL: https://github.com/apache/mynewt-nimble/pull/1627 parse_arg_byte_stream_custom takes unsigned int as argument for result lenght. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [mynewt-core] Kisszalimo closed issue #3066: RAM overflow error when build app for PineTime

2023-09-26 Thread via GitHub
Kisszalimo closed issue #3066: RAM overflow error when build app for PineTime URL: https://github.com/apache/mynewt-core/issues/3066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] ci: Add workflow for testing various GCC versions [mynewt-nimble]

2023-10-03 Thread via GitHub
andrzej-kaczmarek commented on code in PR #1626: URL: https://github.com/apache/mynewt-nimble/pull/1626#discussion_r1344824325 ## .github/workflows/build_cc_target.yml: ## @@ -0,0 +1,62 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [I] NimBLE supports to disable BLE GATT client or server [mynewt-nimble]

2023-10-03 Thread via GitHub
sjanc commented on issue #1615: URL: https://github.com/apache/mynewt-nimble/issues/1615#issuecomment-1745146056 Hi, Hmm yes, we don't have global config to disable GATT client but you should be able to reduce code side by disabling GATT client procedures BLE_GATT_DISC_ALL_SVCS,

[PR] hw/mcu/pic32: Put cache init code in non-cached space [mynewt-core]

2023-10-04 Thread via GitHub
kasjer opened a new pull request, #3089: URL: https://github.com/apache/mynewt-core/pull/3089 kseg1_program_mem and kseg0_program_mem point to same physical memory. kseg1 is not cached while kseg0 is cached. cache init was placed in cached segment which cold lead to crashes during

Re: [PR] nimble/host: Fix not catching conversion error in hex2bin [mynewt-nimble]

2023-10-04 Thread via GitHub
sjanc merged PR #1625: URL: https://github.com/apache/mynewt-nimble/pull/1625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] ci: Fix test targets configurations [mynewt-nimble]

2023-10-04 Thread via GitHub
sjanc merged PR #1629: URL: https://github.com/apache/mynewt-nimble/pull/1629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] nimble/hs: Fix API comments [mynewt-nimble]

2023-10-04 Thread via GitHub
Roshan23699 opened a new pull request, #1631: URL: https://github.com/apache/mynewt-nimble/pull/1631 Fixed Api comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] ci: Add workflow for testing various GCC versions [mynewt-nimble]

2023-10-04 Thread via GitHub
sjanc merged PR #1626: URL: https://github.com/apache/mynewt-nimble/pull/1626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] porting: Remove dependency on Mynewt logging system [mynewt-nimble]

2023-10-04 Thread via GitHub
andrzej-kaczmarek commented on code in PR #1570: URL: https://github.com/apache/mynewt-nimble/pull/1570#discussion_r1345382838 ## porting/npl/riot/include/nimble/nimble_npl_os_log.h: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] ci: Add workflow for testing various GCC versions [mynewt-nimble]

2023-10-04 Thread via GitHub
os: [ubuntu-latest] +gcc: ['12.2.Rel1', '11.3.Rel1', '10.3-2021.10', '9-2019-q4', '8-2018-q4'] Review Comment: I left 9-2019-q4 because it is available in Ubuntu 20.04 which is stil quite common, we can drop 8 I guess. I'll add GCC 13 when it becomes available via github action

Re: [PR] porting: Remove dependency on Mynewt logging system [mynewt-nimble]

2023-10-04 Thread via GitHub
sjanc commented on PR #1570: URL: https://github.com/apache/mynewt-nimble/pull/1570#issuecomment-1746381069 @xiaoxiang781216 @haukepetersen FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] ci: Add workflow for testing various GCC versions [mynewt-core]

2023-10-04 Thread via GitHub
sjanc merged PR #3015: URL: https://github.com/apache/mynewt-core/pull/3015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Fix compilation issue when Max Bonds or CCCD is set as 0 [mynewt-nimble]

2023-10-04 Thread via GitHub
rahult-github opened a new pull request, #1632: URL: https://github.com/apache/mynewt-nimble/pull/1632 This MR address the issue of code compilation warnings if Max bonds or Mac CCCDs is set to 0. Current code assumes that these values will never be 0. -- This is an automated message

[PR] CI: Build all sample applications [mynewt-nimble]

2023-10-04 Thread via GitHub
sjanc opened a new pull request, #1633: URL: https://github.com/apache/mynewt-nimble/pull/1633 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] lvgl: Add driver for cst816s touch screen [mynewt-core]

2023-10-03 Thread via GitHub
kasjer merged PR #3080: URL: https://github.com/apache/mynewt-core/pull/3080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] nimble/ll: Add hack for generating RPA on init [mynewt-nimble]

2023-10-03 Thread via GitHub
andrzej-kaczmarek opened a new pull request, #1630: URL: https://github.com/apache/mynewt-nimble/pull/1630 This adds hack (optional) to make controller generate local RPA when connecting to peer which is not on resolving list, i.e. usually a peer which we are not paired with. In

Re: [PR] nimble/host: Set length correctly in perdioic_set_adv_data [mynewt-nimble]

2023-10-03 Thread via GitHub
sjanc merged PR #1539: URL: https://github.com/apache/mynewt-nimble/pull/1539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [mynewt-core] kasjer merged pull request #3063: lvgl: Display driver optimizations

2023-09-18 Thread via GitHub
kasjer merged PR #3063: URL: https://github.com/apache/mynewt-core/pull/3063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

<    1   2   3   4   5   6   7   8   9   10   >